Precise Float Fixes

Fixes artifacts in TOTK

src/Ryujinx.Graphics.Shader/CodeGen/Msl/Declarations.cs

@@ -122,6 +122,11 @@ namespace Ryujinx.Graphics.Shader.CodeGen.Msl
                 AppendHelperFunction(context, "Ryujinx.Graphics.Shader/CodeGen/Msl/HelperFunctions/SwizzleAdd.metal");
             }
 
+            if ((info.HelperFunctionsMask & HelperFunctionsMask.Precise) != 0)
+            {
+                AppendHelperFunction(context, "Ryujinx.Graphics.Shader/CodeGen/Msl/HelperFunctions/Precise.metal");
+            }
+
             return sets;
         }
 

src/Ryujinx.Graphics.Shader/CodeGen/Msl/HelperFunctions/Precise.metal

@@ -0,0 +1,14 @@
+template<typename T>
+[[clang::optnone]] T PreciseFAdd(T l, T r) {
+    return fma(T(1), l, r);
+}
+
+template<typename T>
+[[clang::optnone]] T PreciseFSub(T l, T r) {
+    return fma(T(-1), r, l);
+}
+
+template<typename T>
+[[clang::optnone]] T PreciseFMul(T l, T r) {
+    return fma(l, r, T(0));
+}

src/Ryujinx.Graphics.Shader/CodeGen/Msl/Instructions/InstGen.cs

@@ -118,6 +118,18 @@ namespace Ryujinx.Graphics.Shader.CodeGen.Msl.Instructions
                         return op + expr[0];
 
                     case 2:
+                        if (operation.ForcePrecise)
+                        {
+                            var func = (inst & Instruction.Mask) switch
+                            {
+                                Instruction.Add => "PreciseFAdd",
+                                Instruction.Subtract => "PreciseFSub",
+                                Instruction.Multiply => "PreciseFMul",
+                            };
+
+                            return $"{func}({expr[0]}, {expr[1]})";
+                        }
+
                         return $"{expr[0]} {op} {expr[1]}";
 
                     case 3:

src/Ryujinx.Graphics.Shader/CodeGen/Msl/NumberFormatter.cs

@@ -49,9 +49,11 @@ namespace Ryujinx.Graphics.Shader.CodeGen.Msl
                 return false;
             }
 
-            formatted = value.ToString("F9", CultureInfo.InvariantCulture);
+            formatted = value.ToString("G9", CultureInfo.InvariantCulture);
 
-            if (!formatted.Contains('.'))
+            if (!(formatted.Contains('.') ||
+                  formatted.Contains('e') ||
+                  formatted.Contains('E')))
             {
                 formatted += ".0f";
             }

src/Ryujinx.Graphics.Shader/Ryujinx.Graphics.Shader.csproj

@@ -20,5 +20,6 @@
     <EmbeddedResource Include="CodeGen\Msl\HelperFunctions\FindMSBS32.metal" />
     <EmbeddedResource Include="CodeGen\Msl\HelperFunctions\FindMSBU32.metal" />
     <EmbeddedResource Include="CodeGen\Msl\HelperFunctions\SwizzleAdd.metal" />
+    <EmbeddedResource Include="CodeGen\Msl\HelperFunctions\Precise.metal" />
   </ItemGroup>
 </Project>

src/Ryujinx.Graphics.Shader/StructuredIr/HelperFunctionsMask.cs

@@ -14,5 +14,7 @@ namespace Ryujinx.Graphics.Shader.StructuredIr
 
         SwizzleAdd = 1 << 10,
         FSI = 1 << 11,
+
+        Precise = 1 << 13
     }
 }

src/Ryujinx.Graphics.Shader/StructuredIr/StructuredProgram.cs

@@ -18,9 +18,10 @@ namespace Ryujinx.Graphics.Shader.StructuredIr
             ShaderDefinitions definitions,
             ResourceManager resourceManager,
             TargetLanguage targetLanguage,
+            bool precise,
             bool debugMode)
         {
-            StructuredProgramContext context = new(attributeUsage, definitions, resourceManager, debugMode);
+            StructuredProgramContext context = new(attributeUsage, definitions, resourceManager, precise, debugMode);
 
             for (int funcIndex = 0; funcIndex < functions.Count; funcIndex++)
             {

src/Ryujinx.Graphics.Shader/StructuredIr/StructuredProgramContext.cs

@@ -36,9 +36,10 @@ namespace Ryujinx.Graphics.Shader.StructuredIr
             AttributeUsage attributeUsage,
             ShaderDefinitions definitions,
             ResourceManager resourceManager,
+            bool precise,
             bool debugMode)
         {
-            Info = new StructuredProgramInfo();
+            Info = new StructuredProgramInfo(precise);
 
             Definitions = definitions;
             ResourceManager = resourceManager;

src/Ryujinx.Graphics.Shader/StructuredIr/StructuredProgramInfo.cs

@@ -10,11 +10,16 @@ namespace Ryujinx.Graphics.Shader.StructuredIr
 
         public HelperFunctionsMask HelperFunctionsMask { get; set; }
 
-        public StructuredProgramInfo()
+        public StructuredProgramInfo(bool precise)
         {
             Functions = new List<StructuredFunction>();
 
             IoDefinitions = new HashSet<IoDefinition>();
+
+            if (precise)
+            {
+                HelperFunctionsMask |= HelperFunctionsMask.Precise;
+            }
         }
     }
 }

src/Ryujinx.Graphics.Shader/Translation/FeatureFlags.cs

@@ -26,5 +26,6 @@ namespace Ryujinx.Graphics.Shader.Translation
         SharedMemory = 1 << 11,
         Store = 1 << 12,
         VtgAsCompute = 1 << 13,
+        Precise = 1 << 14,
     }
 }

src/Ryujinx.Graphics.Shader/Translation/Transforms/ForcePreciseEnable.cs

@@ -27,6 +27,8 @@ namespace Ryujinx.Graphics.Shader.Translation.Transforms
                 addOp.Inst == (Instruction.FP32 | Instruction.Add) &&
                 addOp.GetSource(1).Type == OperandType.Constant)
             {
+                context.UsedFeatures |= FeatureFlags.Precise;
+
                 addOp.ForcePrecise = true;
             }
 

src/Ryujinx.Graphics.Shader/Translation/TranslatorContext.cs

@@ -332,6 +332,7 @@ namespace Ryujinx.Graphics.Shader.Translation
                 definitions,
                 resourceManager,
                 Options.TargetLanguage,
+                usedFeatures.HasFlag(FeatureFlags.Precise),
                 Options.Flags.HasFlag(TranslationFlags.DebugMode));
 
             int geometryVerticesPerPrimitive = Definitions.OutputTopology switch