asgardius/alsa-utils
1
0
Fork 0
mirror of https://github.com/alsa-project/alsa-utils synced 2024-09-19 17:49:59 +02:00
Code Issues Projects Releases Packages Wiki Activity

configure.ac: fix the check for xmlto availability

Browse source 
The same $xmlto variable is used both in AC_ARG_ENABLE and
AC_CHECK_PROG, but the latter is not setting a value to it when the
program is not found.

These two facts result in the "yes" value from the AC_ARG_ENABLE macro
to be still kept in the variable when the program is not found by
AC_CHECK_PROG, causing USE_XMLTO to be always set, finally resulting in
a build failure in case the xmlto program is not actually in the PATH.

As possible fix could have been to set "no" as a value in AC_CHECK_PROG
when program is not found.

However using two separate variables is more explicit, so fix the issue
this way.

Signed-off-by: Antonio Ospite <ao2@ao2.it>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Antonio Ospite 2016-12-09 14:02:29 +01:00 committed by Takashi Iwai
parent c21b3a4b62
commit b235b50129
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
configure.ac
View file

@ -166,14 +166,14 @@ AC_ARG_ENABLE(alsaloop,
esac],[alsaloop=true]) esac],[alsaloop=true])
AM_CONDITIONAL(ALSALOOP, test x$alsaloop = xtrue) AM_CONDITIONAL(ALSALOOP, test x$alsaloop = xtrue)
xmlto="" xmlto_available=""
AC_ARG_ENABLE(xmlto, AC_ARG_ENABLE(xmlto,
AS_HELP_STRING([--disable-xmlto], [Disable man page creation via xmlto]), AS_HELP_STRING([--disable-xmlto], [Disable man page creation via xmlto]),
xmlto="$enableval", xmlto="yes") xmlto="$enableval", xmlto="yes")
if test "$xmlto" = "yes"; then if test "$xmlto" = "yes"; then
AC_CHECK_PROG([xmlto], [xmlto], [yes]) AC_CHECK_PROG([xmlto_available], [xmlto], [yes])
fi fi
AM_CONDITIONAL(USE_XMLTO, test x"$xmlto" = xyes) AM_CONDITIONAL(USE_XMLTO, test x"$xmlto_available" = xyes)
AC_ARG_WITH( AC_ARG_WITH(
[udev-rules-dir], [udev-rules-dir],