2007-09-23 06:19:54 +02:00
|
|
|
/*
|
|
|
|
|
* libata-pmp.c - libata port multiplier support
|
|
|
|
|
*
|
|
|
|
|
* Copyright (c) 2007 SUSE Linux Products GmbH
|
|
|
|
|
* Copyright (c) 2007 Tejun Heo <teheo@suse.de>
|
|
|
|
|
*
|
|
|
|
|
* This file is released under the GPLv2.
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
|
#include <linux/libata.h>
|
|
|
|
|
#include "libata.h"
|
|
|
|
|
|
2008-04-07 15:47:21 +02:00
|
|
|
const struct ata_port_operations sata_pmp_port_ops = {
|
|
|
|
|
.inherits = &sata_port_ops,
|
|
|
|
|
.pmp_prereset = ata_std_prereset,
|
|
|
|
|
.pmp_hardreset = sata_std_hardreset,
|
|
|
|
|
.pmp_postreset = ata_std_postreset,
|
|
|
|
|
.error_handler = sata_pmp_error_handler,
|
|
|
|
|
};
|
|
|
|
|
|
2007-09-23 06:19:54 +02:00
|
|
|
/**
|
|
|
|
|
* sata_pmp_read - read PMP register
|
|
|
|
|
* @link: link to read PMP register for
|
|
|
|
|
* @reg: register to read
|
|
|
|
|
* @r_val: resulting value
|
|
|
|
|
*
|
2007-10-09 08:06:48 +02:00
|
|
|
* Read PMP register.
|
2007-09-23 06:19:54 +02:00
|
|
|
*
|
|
|
|
|
* LOCKING:
|
|
|
|
|
* Kernel thread context (may sleep).
|
|
|
|
|
*
|
|
|
|
|
* RETURNS:
|
2007-10-09 08:06:48 +02:00
|
|
|
* 0 on success, AC_ERR_* mask on failure.
|
2007-09-23 06:19:54 +02:00
|
|
|
*/
|
2007-10-09 08:06:48 +02:00
|
|
|
static unsigned int sata_pmp_read(struct ata_link *link, int reg, u32 *r_val)
|
2007-09-23 06:19:54 +02:00
|
|
|
{
|
|
|
|
|
struct ata_port *ap = link->ap;
|
|
|
|
|
struct ata_device *pmp_dev = ap->link.device;
|
2007-10-09 08:06:48 +02:00
|
|
|
struct ata_taskfile tf;
|
|
|
|
|
unsigned int err_mask;
|
|
|
|
|
|
|
|
|
|
ata_tf_init(pmp_dev, &tf);
|
|
|
|
|
tf.command = ATA_CMD_PMP_READ;
|
|
|
|
|
tf.protocol = ATA_PROT_NODATA;
|
2008-02-21 21:52:25 +01:00
|
|
|
tf.flags |= ATA_TFLAG_ISADDR | ATA_TFLAG_DEVICE | ATA_TFLAG_LBA48;
|
2007-10-09 08:06:48 +02:00
|
|
|
tf.feature = reg;
|
|
|
|
|
tf.device = link->pmp;
|
|
|
|
|
|
|
|
|
|
err_mask = ata_exec_internal(pmp_dev, &tf, NULL, DMA_NONE, NULL, 0,
|
2008-05-18 18:15:10 +02:00
|
|
|
SATA_PMP_RW_TIMEOUT);
|
2007-10-09 08:06:48 +02:00
|
|
|
if (err_mask)
|
|
|
|
|
return err_mask;
|
|
|
|
|
|
|
|
|
|
*r_val = tf.nsect | tf.lbal << 8 | tf.lbam << 16 | tf.lbah << 24;
|
|
|
|
|
return 0;
|
2007-09-23 06:19:54 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* sata_pmp_write - write PMP register
|
|
|
|
|
* @link: link to write PMP register for
|
|
|
|
|
* @reg: register to write
|
|
|
|
|
* @r_val: value to write
|
|
|
|
|
*
|
2007-10-09 08:06:48 +02:00
|
|
|
* Write PMP register.
|
2007-09-23 06:19:54 +02:00
|
|
|
*
|
|
|
|
|
* LOCKING:
|
|
|
|
|
* Kernel thread context (may sleep).
|
|
|
|
|
*
|
|
|
|
|
* RETURNS:
|
2007-10-09 08:06:48 +02:00
|
|
|
* 0 on success, AC_ERR_* mask on failure.
|
2007-09-23 06:19:54 +02:00
|
|
|
*/
|
2007-10-09 08:06:48 +02:00
|
|
|
static unsigned int sata_pmp_write(struct ata_link *link, int reg, u32 val)
|
2007-09-23 06:19:54 +02:00
|
|
|
{
|
|
|
|
|
struct ata_port *ap = link->ap;
|
|
|
|
|
struct ata_device *pmp_dev = ap->link.device;
|
2007-10-09 08:06:48 +02:00
|
|
|
struct ata_taskfile tf;
|
|
|
|
|
|
|
|
|
|
ata_tf_init(pmp_dev, &tf);
|
|
|
|
|
tf.command = ATA_CMD_PMP_WRITE;
|
|
|
|
|
tf.protocol = ATA_PROT_NODATA;
|
2008-02-21 21:52:25 +01:00
|
|
|
tf.flags |= ATA_TFLAG_ISADDR | ATA_TFLAG_DEVICE | ATA_TFLAG_LBA48;
|
2007-10-09 08:06:48 +02:00
|
|
|
tf.feature = reg;
|
|
|
|
|
tf.device = link->pmp;
|
|
|
|
|
tf.nsect = val & 0xff;
|
|
|
|
|
tf.lbal = (val >> 8) & 0xff;
|
|
|
|
|
tf.lbam = (val >> 16) & 0xff;
|
|
|
|
|
tf.lbah = (val >> 24) & 0xff;
|
|
|
|
|
|
|
|
|
|
return ata_exec_internal(pmp_dev, &tf, NULL, DMA_NONE, NULL, 0,
|
2008-05-18 18:15:10 +02:00
|
|
|
SATA_PMP_RW_TIMEOUT);
|
2007-09-23 06:19:54 +02:00
|
|
|
}
|
|
|
|
|
|
2007-09-23 06:19:54 +02:00
|
|
|
/**
|
|
|
|
|
* sata_pmp_qc_defer_cmd_switch - qc_defer for command switching PMP
|
|
|
|
|
* @qc: ATA command in question
|
|
|
|
|
*
|
|
|
|
|
* A host which has command switching PMP support cannot issue
|
|
|
|
|
* commands to multiple links simultaneously.
|
|
|
|
|
*
|
|
|
|
|
* LOCKING:
|
|
|
|
|
* spin_lock_irqsave(host lock)
|
|
|
|
|
*
|
|
|
|
|
* RETURNS:
|
|
|
|
|
* ATA_DEFER_* if deferring is needed, 0 otherwise.
|
|
|
|
|
*/
|
|
|
|
|
int sata_pmp_qc_defer_cmd_switch(struct ata_queued_cmd *qc)
|
|
|
|
|
{
|
|
|
|
|
struct ata_link *link = qc->dev->link;
|
|
|
|
|
struct ata_port *ap = link->ap;
|
|
|
|
|
|
|
|
|
|
if (ap->excl_link == NULL || ap->excl_link == link) {
|
|
|
|
|
if (ap->nr_active_links == 0 || ata_link_active(link)) {
|
|
|
|
|
qc->flags |= ATA_QCFLAG_CLEAR_EXCL;
|
|
|
|
|
return ata_std_qc_defer(qc);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
ap->excl_link = link;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return ATA_DEFER_PORT;
|
|
|
|
|
}
|
|
|
|
|
|
2007-09-23 06:19:54 +02:00
|
|
|
/**
|
|
|
|
|
* sata_pmp_scr_read - read PSCR
|
|
|
|
|
* @link: ATA link to read PSCR for
|
|
|
|
|
* @reg: PSCR to read
|
|
|
|
|
* @r_val: resulting value
|
|
|
|
|
*
|
|
|
|
|
* Read PSCR @reg into @r_val for @link, to be called from
|
|
|
|
|
* ata_scr_read().
|
|
|
|
|
*
|
|
|
|
|
* LOCKING:
|
|
|
|
|
* Kernel thread context (may sleep).
|
|
|
|
|
*
|
|
|
|
|
* RETURNS:
|
|
|
|
|
* 0 on success, -errno on failure.
|
|
|
|
|
*/
|
|
|
|
|
int sata_pmp_scr_read(struct ata_link *link, int reg, u32 *r_val)
|
|
|
|
|
{
|
2007-10-09 08:06:48 +02:00
|
|
|
unsigned int err_mask;
|
|
|
|
|
|
2007-09-23 06:19:54 +02:00
|
|
|
if (reg > SATA_PMP_PSCR_CONTROL)
|
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
2007-10-09 08:06:48 +02:00
|
|
|
err_mask = sata_pmp_read(link, reg, r_val);
|
|
|
|
|
if (err_mask) {
|
|
|
|
|
ata_link_printk(link, KERN_WARNING, "failed to read SCR %d "
|
|
|
|
|
"(Emask=0x%x)\n", reg, err_mask);
|
|
|
|
|
return -EIO;
|
|
|
|
|
}
|
|
|
|
|
return 0;
|
2007-09-23 06:19:54 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* sata_pmp_scr_write - write PSCR
|
|
|
|
|
* @link: ATA link to write PSCR for
|
|
|
|
|
* @reg: PSCR to write
|
|
|
|
|
* @val: value to be written
|
|
|
|
|
*
|
|
|
|
|
* Write @val to PSCR @reg for @link, to be called from
|
|
|
|
|
* ata_scr_write() and ata_scr_write_flush().
|
|
|
|
|
*
|
|
|
|
|
* LOCKING:
|
|
|
|
|
* Kernel thread context (may sleep).
|
|
|
|
|
*
|
|
|
|
|
* RETURNS:
|
|
|
|
|
* 0 on success, -errno on failure.
|
|
|
|
|
*/
|
|
|
|
|
int sata_pmp_scr_write(struct ata_link *link, int reg, u32 val)
|
|
|
|
|
{
|
2007-10-09 08:06:48 +02:00
|
|
|
unsigned int err_mask;
|
|
|
|
|
|
2007-09-23 06:19:54 +02:00
|
|
|
if (reg > SATA_PMP_PSCR_CONTROL)
|
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
2007-10-09 08:06:48 +02:00
|
|
|
err_mask = sata_pmp_write(link, reg, val);
|
|
|
|
|
if (err_mask) {
|
|
|
|
|
ata_link_printk(link, KERN_WARNING, "failed to write SCR %d "
|
|
|
|
|
"(Emask=0x%x)\n", reg, err_mask);
|
|
|
|
|
return -EIO;
|
|
|
|
|
}
|
|
|
|
|
return 0;
|
2007-09-23 06:19:54 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* sata_pmp_read_gscr - read GSCR block of SATA PMP
|
|
|
|
|
* @dev: PMP device
|
|
|
|
|
* @gscr: buffer to read GSCR block into
|
|
|
|
|
*
|
|
|
|
|
* Read selected PMP GSCRs from the PMP at @dev. This will serve
|
|
|
|
|
* as configuration and identification info for the PMP.
|
|
|
|
|
*
|
|
|
|
|
* LOCKING:
|
|
|
|
|
* Kernel thread context (may sleep).
|
|
|
|
|
*
|
|
|
|
|
* RETURNS:
|
|
|
|
|
* 0 on success, -errno on failure.
|
|
|
|
|
*/
|
|
|
|
|
static int sata_pmp_read_gscr(struct ata_device *dev, u32 *gscr)
|
|
|
|
|
{
|
|
|
|
|
static const int gscr_to_read[] = { 0, 1, 2, 32, 33, 64, 96 };
|
2007-10-09 08:06:48 +02:00
|
|
|
int i;
|
2007-09-23 06:19:54 +02:00
|
|
|
|
|
|
|
|
for (i = 0; i < ARRAY_SIZE(gscr_to_read); i++) {
|
|
|
|
|
int reg = gscr_to_read[i];
|
2007-10-09 08:06:48 +02:00
|
|
|
unsigned int err_mask;
|
2007-09-23 06:19:54 +02:00
|
|
|
|
2007-10-09 08:06:48 +02:00
|
|
|
err_mask = sata_pmp_read(dev->link, reg, &gscr[reg]);
|
|
|
|
|
if (err_mask) {
|
|
|
|
|
ata_dev_printk(dev, KERN_ERR, "failed to read PMP "
|
|
|
|
|
"GSCR[%d] (Emask=0x%x)\n", reg, err_mask);
|
|
|
|
|
return -EIO;
|
2007-09-23 06:19:54 +02:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static const char *sata_pmp_spec_rev_str(const u32 *gscr)
|
|
|
|
|
{
|
|
|
|
|
u32 rev = gscr[SATA_PMP_GSCR_REV];
|
|
|
|
|
|
|
|
|
|
if (rev & (1 << 2))
|
|
|
|
|
return "1.1";
|
|
|
|
|
if (rev & (1 << 1))
|
|
|
|
|
return "1.0";
|
|
|
|
|
return "<unknown>";
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static int sata_pmp_configure(struct ata_device *dev, int print_info)
|
|
|
|
|
{
|
|
|
|
|
struct ata_port *ap = dev->link->ap;
|
|
|
|
|
u32 *gscr = dev->gscr;
|
2007-10-09 08:06:48 +02:00
|
|
|
unsigned int err_mask = 0;
|
2007-09-23 06:19:54 +02:00
|
|
|
const char *reason;
|
|
|
|
|
int nr_ports, rc;
|
|
|
|
|
|
|
|
|
|
nr_ports = sata_pmp_gscr_ports(gscr);
|
|
|
|
|
|
|
|
|
|
if (nr_ports <= 0 || nr_ports > SATA_PMP_MAX_PORTS) {
|
|
|
|
|
rc = -EINVAL;
|
|
|
|
|
reason = "invalid nr_ports";
|
|
|
|
|
goto fail;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ((ap->flags & ATA_FLAG_AN) &&
|
|
|
|
|
(gscr[SATA_PMP_GSCR_FEAT] & SATA_PMP_FEAT_NOTIFY))
|
|
|
|
|
dev->flags |= ATA_DFLAG_AN;
|
|
|
|
|
|
|
|
|
|
/* monitor SERR_PHYRDY_CHG on fan-out ports */
|
2007-10-09 08:06:48 +02:00
|
|
|
err_mask = sata_pmp_write(dev->link, SATA_PMP_GSCR_ERROR_EN,
|
|
|
|
|
SERR_PHYRDY_CHG);
|
|
|
|
|
if (err_mask) {
|
|
|
|
|
rc = -EIO;
|
2007-09-23 06:19:54 +02:00
|
|
|
reason = "failed to write GSCR_ERROR_EN";
|
|
|
|
|
goto fail;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (print_info) {
|
|
|
|
|
ata_dev_printk(dev, KERN_INFO, "Port Multiplier %s, "
|
|
|
|
|
"0x%04x:0x%04x r%d, %d ports, feat 0x%x/0x%x\n",
|
|
|
|
|
sata_pmp_spec_rev_str(gscr),
|
|
|
|
|
sata_pmp_gscr_vendor(gscr),
|
|
|
|
|
sata_pmp_gscr_devid(gscr),
|
|
|
|
|
sata_pmp_gscr_rev(gscr),
|
|
|
|
|
nr_ports, gscr[SATA_PMP_GSCR_FEAT_EN],
|
|
|
|
|
gscr[SATA_PMP_GSCR_FEAT]);
|
|
|
|
|
|
|
|
|
|
if (!(dev->flags & ATA_DFLAG_AN))
|
|
|
|
|
ata_dev_printk(dev, KERN_INFO,
|
|
|
|
|
"Asynchronous notification not supported, "
|
|
|
|
|
"hotplug won't\n work on fan-out "
|
|
|
|
|
"ports. Use warm-plug instead.\n");
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
|
|
fail:
|
|
|
|
|
ata_dev_printk(dev, KERN_ERR,
|
2007-10-09 08:06:48 +02:00
|
|
|
"failed to configure Port Multiplier (%s, Emask=0x%x)\n",
|
|
|
|
|
reason, err_mask);
|
2007-09-23 06:19:54 +02:00
|
|
|
return rc;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static int sata_pmp_init_links(struct ata_port *ap, int nr_ports)
|
|
|
|
|
{
|
|
|
|
|
struct ata_link *pmp_link = ap->pmp_link;
|
|
|
|
|
int i;
|
|
|
|
|
|
|
|
|
|
if (!pmp_link) {
|
|
|
|
|
pmp_link = kzalloc(sizeof(pmp_link[0]) * SATA_PMP_MAX_PORTS,
|
|
|
|
|
GFP_NOIO);
|
|
|
|
|
if (!pmp_link)
|
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
|
|
for (i = 0; i < SATA_PMP_MAX_PORTS; i++)
|
|
|
|
|
ata_link_init(ap, &pmp_link[i], i);
|
|
|
|
|
|
|
|
|
|
ap->pmp_link = pmp_link;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
for (i = 0; i < nr_ports; i++) {
|
|
|
|
|
struct ata_link *link = &pmp_link[i];
|
|
|
|
|
struct ata_eh_context *ehc = &link->eh_context;
|
|
|
|
|
|
|
|
|
|
link->flags = 0;
|
2008-01-23 16:05:14 +01:00
|
|
|
ehc->i.probe_mask |= ATA_ALL_DEVICES;
|
libata: prefer hardreset
When both soft and hard resets are available, libata preferred
softreset till now. The logic behind it was to be softer to devices;
however, this doesn't really help much. Rationales for the change:
* BIOS may freeze lock certain things during boot and softreset can't
unlock those. This by itself is okay but during operation PHY event
or other error conditions can trigger hardreset and the device may
end up with different configuration.
For example, after a hardreset, previously unlockable HPA can be
unlocked resulting in different device size and thus revalidation
failure. Similar condition can occur during or after resume.
* Certain ATAPI devices require hardreset to recover after certain
error conditions. On PATA, this is done by issuing the DEVICE RESET
command. On SATA, COMRESET has equivalent effect. The problem is
that DEVICE RESET needs its own execution protocol.
For SFF controllers with bare TF access, it can be easily
implemented but more advanced controllers (e.g. ahci and sata_sil24)
require specialized implementations. Simply using hardreset solves
the problem nicely.
* COMRESET initialization sequence is the norm in SATA land and many
SATA devices don't work properly if only SRST is used. For example,
some PMPs behave this way and libata works around by always issuing
hardreset if the host supports PMP.
Like the above example, libata has developed a number of mechanisms
aiming to promote softreset to hardreset if softreset is not going
to work. This approach is time consuming and error prone.
Also, note that, dependingon how you read the specs, it could be
argued that PMP fan-out ports require COMRESET to start operation.
In fact, all the PMPs on the market except one don't work properly
if COMRESET is not issued to fan-out ports after PMP reset.
* COMRESET is an integral part of SATA connection and any working
device should be able to handle COMRESET properly. After all, it's
the way to signal hardreset during reboot. This is the most used
and recommended (at least by the ahci spec) method of resetting
devices.
So, this patch makes libata prefer hardreset over softreset by making
the following changes.
* Rename ATA_EH_RESET_MASK to ATA_EH_RESET and use it whereever
ATA_EH_{SOFT|HARD}RESET used to be used. ATA_EH_{SOFT|HARD}RESET is
now only used to tell prereset whether soft or hard reset will be
issued.
* Strip out now unneeded promote-to-hardreset logics from
ata_eh_reset(), ata_std_prereset(), sata_pmp_std_prereset() and
other places.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-01-23 16:05:14 +01:00
|
|
|
ehc->i.action |= ATA_EH_RESET;
|
2007-09-23 06:19:54 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void sata_pmp_quirks(struct ata_port *ap)
|
|
|
|
|
{
|
|
|
|
|
u32 *gscr = ap->link.device->gscr;
|
|
|
|
|
u16 vendor = sata_pmp_gscr_vendor(gscr);
|
|
|
|
|
u16 devid = sata_pmp_gscr_devid(gscr);
|
|
|
|
|
struct ata_link *link;
|
|
|
|
|
|
|
|
|
|
if (vendor == 0x1095 && devid == 0x3726) {
|
|
|
|
|
/* sil3726 quirks */
|
|
|
|
|
ata_port_for_each_link(link, ap) {
|
2008-05-21 07:11:24 +02:00
|
|
|
/* Class code report is unreliable and SRST
|
|
|
|
|
* times out under certain configurations.
|
|
|
|
|
*/
|
2007-09-23 06:19:54 +02:00
|
|
|
if (link->pmp < 5)
|
2008-05-21 07:11:24 +02:00
|
|
|
link->flags |= ATA_LFLAG_NO_SRST |
|
|
|
|
|
ATA_LFLAG_ASSUME_ATA;
|
2007-09-23 06:19:54 +02:00
|
|
|
|
|
|
|
|
/* port 5 is for SEMB device and it doesn't like SRST */
|
|
|
|
|
if (link->pmp == 5)
|
|
|
|
|
link->flags |= ATA_LFLAG_NO_SRST |
|
|
|
|
|
ATA_LFLAG_ASSUME_SEMB;
|
|
|
|
|
}
|
|
|
|
|
} else if (vendor == 0x1095 && devid == 0x4723) {
|
|
|
|
|
/* sil4723 quirks */
|
|
|
|
|
ata_port_for_each_link(link, ap) {
|
|
|
|
|
/* class code report is unreliable */
|
|
|
|
|
if (link->pmp < 2)
|
|
|
|
|
link->flags |= ATA_LFLAG_ASSUME_ATA;
|
|
|
|
|
|
|
|
|
|
/* the config device at port 2 locks up on SRST */
|
|
|
|
|
if (link->pmp == 2)
|
|
|
|
|
link->flags |= ATA_LFLAG_NO_SRST |
|
|
|
|
|
ATA_LFLAG_ASSUME_ATA;
|
|
|
|
|
}
|
|
|
|
|
} else if (vendor == 0x1095 && devid == 0x4726) {
|
|
|
|
|
/* sil4726 quirks */
|
|
|
|
|
ata_port_for_each_link(link, ap) {
|
2008-01-10 05:38:46 +01:00
|
|
|
/* Class code report is unreliable and SRST
|
|
|
|
|
* times out under certain configurations.
|
|
|
|
|
* Config device can be at port 0 or 5 and
|
|
|
|
|
* locks up on SRST.
|
2007-09-23 06:19:54 +02:00
|
|
|
*/
|
2008-01-10 05:38:46 +01:00
|
|
|
if (link->pmp <= 5)
|
2007-09-23 06:19:54 +02:00
|
|
|
link->flags |= ATA_LFLAG_NO_SRST |
|
|
|
|
|
ATA_LFLAG_ASSUME_ATA;
|
|
|
|
|
|
|
|
|
|
/* Port 6 is for SEMB device which doesn't
|
|
|
|
|
* like SRST either.
|
|
|
|
|
*/
|
|
|
|
|
if (link->pmp == 6)
|
|
|
|
|
link->flags |= ATA_LFLAG_NO_SRST |
|
|
|
|
|
ATA_LFLAG_ASSUME_SEMB;
|
|
|
|
|
}
|
|
|
|
|
} else if (vendor == 0x1095 && (devid == 0x5723 || devid == 0x5733 ||
|
|
|
|
|
devid == 0x5734 || devid == 0x5744)) {
|
|
|
|
|
/* sil5723/5744 quirks */
|
|
|
|
|
|
|
|
|
|
/* sil5723/5744 has either two or three downstream
|
|
|
|
|
* ports depending on operation mode. The last port
|
|
|
|
|
* is empty if any actual IO device is available or
|
|
|
|
|
* occupied by a pseudo configuration device
|
|
|
|
|
* otherwise. Don't try hard to recover it.
|
|
|
|
|
*/
|
|
|
|
|
ap->pmp_link[ap->nr_pmp_links - 1].flags |= ATA_LFLAG_NO_RETRY;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* sata_pmp_attach - attach a SATA PMP device
|
|
|
|
|
* @dev: SATA PMP device to attach
|
|
|
|
|
*
|
|
|
|
|
* Configure and attach SATA PMP device @dev. This function is
|
|
|
|
|
* also responsible for allocating and initializing PMP links.
|
|
|
|
|
*
|
|
|
|
|
* LOCKING:
|
|
|
|
|
* Kernel thread context (may sleep).
|
|
|
|
|
*
|
|
|
|
|
* RETURNS:
|
|
|
|
|
* 0 on success, -errno on failure.
|
|
|
|
|
*/
|
|
|
|
|
int sata_pmp_attach(struct ata_device *dev)
|
|
|
|
|
{
|
|
|
|
|
struct ata_link *link = dev->link;
|
|
|
|
|
struct ata_port *ap = link->ap;
|
|
|
|
|
unsigned long flags;
|
|
|
|
|
struct ata_link *tlink;
|
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
|
|
/* is it hanging off the right place? */
|
2008-04-07 15:47:22 +02:00
|
|
|
if (!sata_pmp_supported(ap)) {
|
2007-09-23 06:19:54 +02:00
|
|
|
ata_dev_printk(dev, KERN_ERR,
|
|
|
|
|
"host does not support Port Multiplier\n");
|
|
|
|
|
return -EINVAL;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (!ata_is_host_link(link)) {
|
|
|
|
|
ata_dev_printk(dev, KERN_ERR,
|
|
|
|
|
"Port Multipliers cannot be nested\n");
|
|
|
|
|
return -EINVAL;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (dev->devno) {
|
|
|
|
|
ata_dev_printk(dev, KERN_ERR,
|
|
|
|
|
"Port Multiplier must be the first device\n");
|
|
|
|
|
return -EINVAL;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
WARN_ON(link->pmp != 0);
|
|
|
|
|
link->pmp = SATA_PMP_CTRL_PORT;
|
|
|
|
|
|
|
|
|
|
/* read GSCR block */
|
|
|
|
|
rc = sata_pmp_read_gscr(dev, dev->gscr);
|
|
|
|
|
if (rc)
|
|
|
|
|
goto fail;
|
|
|
|
|
|
|
|
|
|
/* config PMP */
|
|
|
|
|
rc = sata_pmp_configure(dev, 1);
|
|
|
|
|
if (rc)
|
|
|
|
|
goto fail;
|
|
|
|
|
|
|
|
|
|
rc = sata_pmp_init_links(ap, sata_pmp_gscr_ports(dev->gscr));
|
|
|
|
|
if (rc) {
|
|
|
|
|
ata_dev_printk(dev, KERN_INFO,
|
|
|
|
|
"failed to initialize PMP links\n");
|
|
|
|
|
goto fail;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* attach it */
|
|
|
|
|
spin_lock_irqsave(ap->lock, flags);
|
|
|
|
|
WARN_ON(ap->nr_pmp_links);
|
|
|
|
|
ap->nr_pmp_links = sata_pmp_gscr_ports(dev->gscr);
|
|
|
|
|
spin_unlock_irqrestore(ap->lock, flags);
|
|
|
|
|
|
|
|
|
|
sata_pmp_quirks(ap);
|
|
|
|
|
|
|
|
|
|
if (ap->ops->pmp_attach)
|
|
|
|
|
ap->ops->pmp_attach(ap);
|
|
|
|
|
|
|
|
|
|
ata_port_for_each_link(tlink, ap)
|
|
|
|
|
sata_link_init_spd(tlink);
|
|
|
|
|
|
2007-09-23 06:19:54 +02:00
|
|
|
ata_acpi_associate_sata_port(ap);
|
|
|
|
|
|
2007-09-23 06:19:54 +02:00
|
|
|
return 0;
|
|
|
|
|
|
|
|
|
|
fail:
|
|
|
|
|
link->pmp = 0;
|
|
|
|
|
return rc;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* sata_pmp_detach - detach a SATA PMP device
|
|
|
|
|
* @dev: SATA PMP device to detach
|
|
|
|
|
*
|
|
|
|
|
* Detach SATA PMP device @dev. This function is also
|
|
|
|
|
* responsible for deconfiguring PMP links.
|
|
|
|
|
*
|
|
|
|
|
* LOCKING:
|
|
|
|
|
* Kernel thread context (may sleep).
|
|
|
|
|
*/
|
|
|
|
|
static void sata_pmp_detach(struct ata_device *dev)
|
|
|
|
|
{
|
|
|
|
|
struct ata_link *link = dev->link;
|
|
|
|
|
struct ata_port *ap = link->ap;
|
|
|
|
|
struct ata_link *tlink;
|
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
|
|
ata_dev_printk(dev, KERN_INFO, "Port Multiplier detaching\n");
|
|
|
|
|
|
|
|
|
|
WARN_ON(!ata_is_host_link(link) || dev->devno ||
|
|
|
|
|
link->pmp != SATA_PMP_CTRL_PORT);
|
|
|
|
|
|
|
|
|
|
if (ap->ops->pmp_detach)
|
|
|
|
|
ap->ops->pmp_detach(ap);
|
|
|
|
|
|
|
|
|
|
ata_port_for_each_link(tlink, ap)
|
|
|
|
|
ata_eh_detach_dev(tlink->device);
|
|
|
|
|
|
|
|
|
|
spin_lock_irqsave(ap->lock, flags);
|
|
|
|
|
ap->nr_pmp_links = 0;
|
|
|
|
|
link->pmp = 0;
|
|
|
|
|
spin_unlock_irqrestore(ap->lock, flags);
|
2007-09-23 06:19:54 +02:00
|
|
|
|
|
|
|
|
ata_acpi_associate_sata_port(ap);
|
2007-09-23 06:19:54 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* sata_pmp_same_pmp - does new GSCR matches the configured PMP?
|
|
|
|
|
* @dev: PMP device to compare against
|
|
|
|
|
* @new_gscr: GSCR block of the new device
|
|
|
|
|
*
|
|
|
|
|
* Compare @new_gscr against @dev and determine whether @dev is
|
|
|
|
|
* the PMP described by @new_gscr.
|
|
|
|
|
*
|
|
|
|
|
* LOCKING:
|
|
|
|
|
* None.
|
|
|
|
|
*
|
|
|
|
|
* RETURNS:
|
|
|
|
|
* 1 if @dev matches @new_gscr, 0 otherwise.
|
|
|
|
|
*/
|
|
|
|
|
static int sata_pmp_same_pmp(struct ata_device *dev, const u32 *new_gscr)
|
|
|
|
|
{
|
|
|
|
|
const u32 *old_gscr = dev->gscr;
|
|
|
|
|
u16 old_vendor, new_vendor, old_devid, new_devid;
|
|
|
|
|
int old_nr_ports, new_nr_ports;
|
|
|
|
|
|
|
|
|
|
old_vendor = sata_pmp_gscr_vendor(old_gscr);
|
|
|
|
|
new_vendor = sata_pmp_gscr_vendor(new_gscr);
|
|
|
|
|
old_devid = sata_pmp_gscr_devid(old_gscr);
|
|
|
|
|
new_devid = sata_pmp_gscr_devid(new_gscr);
|
|
|
|
|
old_nr_ports = sata_pmp_gscr_ports(old_gscr);
|
|
|
|
|
new_nr_ports = sata_pmp_gscr_ports(new_gscr);
|
|
|
|
|
|
|
|
|
|
if (old_vendor != new_vendor) {
|
|
|
|
|
ata_dev_printk(dev, KERN_INFO, "Port Multiplier "
|
|
|
|
|
"vendor mismatch '0x%x' != '0x%x'\n",
|
|
|
|
|
old_vendor, new_vendor);
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (old_devid != new_devid) {
|
|
|
|
|
ata_dev_printk(dev, KERN_INFO, "Port Multiplier "
|
|
|
|
|
"device ID mismatch '0x%x' != '0x%x'\n",
|
|
|
|
|
old_devid, new_devid);
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (old_nr_ports != new_nr_ports) {
|
|
|
|
|
ata_dev_printk(dev, KERN_INFO, "Port Multiplier "
|
|
|
|
|
"nr_ports mismatch '0x%x' != '0x%x'\n",
|
|
|
|
|
old_nr_ports, new_nr_ports);
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return 1;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* sata_pmp_revalidate - revalidate SATA PMP
|
|
|
|
|
* @dev: PMP device to revalidate
|
|
|
|
|
* @new_class: new class code
|
|
|
|
|
*
|
|
|
|
|
* Re-read GSCR block and make sure @dev is still attached to the
|
|
|
|
|
* port and properly configured.
|
|
|
|
|
*
|
|
|
|
|
* LOCKING:
|
|
|
|
|
* Kernel thread context (may sleep).
|
|
|
|
|
*
|
|
|
|
|
* RETURNS:
|
|
|
|
|
* 0 on success, -errno otherwise.
|
|
|
|
|
*/
|
|
|
|
|
static int sata_pmp_revalidate(struct ata_device *dev, unsigned int new_class)
|
|
|
|
|
{
|
|
|
|
|
struct ata_link *link = dev->link;
|
|
|
|
|
struct ata_port *ap = link->ap;
|
|
|
|
|
u32 *gscr = (void *)ap->sector_buf;
|
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
|
|
DPRINTK("ENTER\n");
|
|
|
|
|
|
|
|
|
|
ata_eh_about_to_do(link, NULL, ATA_EH_REVALIDATE);
|
|
|
|
|
|
|
|
|
|
if (!ata_dev_enabled(dev)) {
|
|
|
|
|
rc = -ENODEV;
|
|
|
|
|
goto fail;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* wrong class? */
|
|
|
|
|
if (ata_class_enabled(new_class) && new_class != ATA_DEV_PMP) {
|
|
|
|
|
rc = -ENODEV;
|
|
|
|
|
goto fail;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* read GSCR */
|
|
|
|
|
rc = sata_pmp_read_gscr(dev, gscr);
|
|
|
|
|
if (rc)
|
|
|
|
|
goto fail;
|
|
|
|
|
|
|
|
|
|
/* is the pmp still there? */
|
|
|
|
|
if (!sata_pmp_same_pmp(dev, gscr)) {
|
|
|
|
|
rc = -ENODEV;
|
|
|
|
|
goto fail;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
memcpy(dev->gscr, gscr, sizeof(gscr[0]) * SATA_PMP_GSCR_DWORDS);
|
|
|
|
|
|
|
|
|
|
rc = sata_pmp_configure(dev, 0);
|
|
|
|
|
if (rc)
|
|
|
|
|
goto fail;
|
|
|
|
|
|
|
|
|
|
ata_eh_done(link, NULL, ATA_EH_REVALIDATE);
|
|
|
|
|
|
|
|
|
|
DPRINTK("EXIT, rc=0\n");
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
|
|
fail:
|
|
|
|
|
ata_dev_printk(dev, KERN_ERR,
|
|
|
|
|
"PMP revalidation failed (errno=%d)\n", rc);
|
|
|
|
|
DPRINTK("EXIT, rc=%d\n", rc);
|
|
|
|
|
return rc;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* sata_pmp_revalidate_quick - revalidate SATA PMP quickly
|
|
|
|
|
* @dev: PMP device to revalidate
|
|
|
|
|
*
|
|
|
|
|
* Make sure the attached PMP is accessible.
|
|
|
|
|
*
|
|
|
|
|
* LOCKING:
|
|
|
|
|
* Kernel thread context (may sleep).
|
|
|
|
|
*
|
|
|
|
|
* RETURNS:
|
|
|
|
|
* 0 on success, -errno otherwise.
|
|
|
|
|
*/
|
|
|
|
|
static int sata_pmp_revalidate_quick(struct ata_device *dev)
|
|
|
|
|
{
|
2007-10-09 08:06:48 +02:00
|
|
|
unsigned int err_mask;
|
2007-09-23 06:19:54 +02:00
|
|
|
u32 prod_id;
|
|
|
|
|
|
2007-10-09 08:06:48 +02:00
|
|
|
err_mask = sata_pmp_read(dev->link, SATA_PMP_GSCR_PROD_ID, &prod_id);
|
|
|
|
|
if (err_mask) {
|
|
|
|
|
ata_dev_printk(dev, KERN_ERR, "failed to read PMP product ID "
|
|
|
|
|
"(Emask=0x%x)\n", err_mask);
|
|
|
|
|
return -EIO;
|
2007-09-23 06:19:54 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (prod_id != dev->gscr[SATA_PMP_GSCR_PROD_ID]) {
|
|
|
|
|
ata_dev_printk(dev, KERN_ERR, "PMP product ID mismatch\n");
|
|
|
|
|
/* something weird is going on, request full PMP recovery */
|
|
|
|
|
return -EIO;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* sata_pmp_eh_recover_pmp - recover PMP
|
|
|
|
|
* @ap: ATA port PMP is attached to
|
|
|
|
|
* @prereset: prereset method (can be NULL)
|
|
|
|
|
* @softreset: softreset method
|
|
|
|
|
* @hardreset: hardreset method
|
|
|
|
|
* @postreset: postreset method (can be NULL)
|
|
|
|
|
*
|
|
|
|
|
* Recover PMP attached to @ap. Recovery procedure is somewhat
|
|
|
|
|
* similar to that of ata_eh_recover() except that reset should
|
|
|
|
|
* always be performed in hard->soft sequence and recovery
|
|
|
|
|
* failure results in PMP detachment.
|
|
|
|
|
*
|
|
|
|
|
* LOCKING:
|
|
|
|
|
* Kernel thread context (may sleep).
|
|
|
|
|
*
|
|
|
|
|
* RETURNS:
|
|
|
|
|
* 0 on success, -errno on failure.
|
|
|
|
|
*/
|
|
|
|
|
static int sata_pmp_eh_recover_pmp(struct ata_port *ap,
|
|
|
|
|
ata_prereset_fn_t prereset, ata_reset_fn_t softreset,
|
|
|
|
|
ata_reset_fn_t hardreset, ata_postreset_fn_t postreset)
|
|
|
|
|
{
|
|
|
|
|
struct ata_link *link = &ap->link;
|
|
|
|
|
struct ata_eh_context *ehc = &link->eh_context;
|
|
|
|
|
struct ata_device *dev = link->device;
|
|
|
|
|
int tries = ATA_EH_PMP_TRIES;
|
|
|
|
|
int detach = 0, rc = 0;
|
|
|
|
|
int reval_failed = 0;
|
|
|
|
|
|
|
|
|
|
DPRINTK("ENTER\n");
|
|
|
|
|
|
|
|
|
|
if (dev->flags & ATA_DFLAG_DETACH) {
|
|
|
|
|
detach = 1;
|
|
|
|
|
goto fail;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
retry:
|
|
|
|
|
ehc->classes[0] = ATA_DEV_UNKNOWN;
|
|
|
|
|
|
libata: prefer hardreset
When both soft and hard resets are available, libata preferred
softreset till now. The logic behind it was to be softer to devices;
however, this doesn't really help much. Rationales for the change:
* BIOS may freeze lock certain things during boot and softreset can't
unlock those. This by itself is okay but during operation PHY event
or other error conditions can trigger hardreset and the device may
end up with different configuration.
For example, after a hardreset, previously unlockable HPA can be
unlocked resulting in different device size and thus revalidation
failure. Similar condition can occur during or after resume.
* Certain ATAPI devices require hardreset to recover after certain
error conditions. On PATA, this is done by issuing the DEVICE RESET
command. On SATA, COMRESET has equivalent effect. The problem is
that DEVICE RESET needs its own execution protocol.
For SFF controllers with bare TF access, it can be easily
implemented but more advanced controllers (e.g. ahci and sata_sil24)
require specialized implementations. Simply using hardreset solves
the problem nicely.
* COMRESET initialization sequence is the norm in SATA land and many
SATA devices don't work properly if only SRST is used. For example,
some PMPs behave this way and libata works around by always issuing
hardreset if the host supports PMP.
Like the above example, libata has developed a number of mechanisms
aiming to promote softreset to hardreset if softreset is not going
to work. This approach is time consuming and error prone.
Also, note that, dependingon how you read the specs, it could be
argued that PMP fan-out ports require COMRESET to start operation.
In fact, all the PMPs on the market except one don't work properly
if COMRESET is not issued to fan-out ports after PMP reset.
* COMRESET is an integral part of SATA connection and any working
device should be able to handle COMRESET properly. After all, it's
the way to signal hardreset during reboot. This is the most used
and recommended (at least by the ahci spec) method of resetting
devices.
So, this patch makes libata prefer hardreset over softreset by making
the following changes.
* Rename ATA_EH_RESET_MASK to ATA_EH_RESET and use it whereever
ATA_EH_{SOFT|HARD}RESET used to be used. ATA_EH_{SOFT|HARD}RESET is
now only used to tell prereset whether soft or hard reset will be
issued.
* Strip out now unneeded promote-to-hardreset logics from
ata_eh_reset(), ata_std_prereset(), sata_pmp_std_prereset() and
other places.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-01-23 16:05:14 +01:00
|
|
|
if (ehc->i.action & ATA_EH_RESET) {
|
2007-09-23 06:19:54 +02:00
|
|
|
struct ata_link *tlink;
|
|
|
|
|
|
|
|
|
|
/* reset */
|
|
|
|
|
rc = ata_eh_reset(link, 0, prereset, softreset, hardreset,
|
|
|
|
|
postreset);
|
|
|
|
|
if (rc) {
|
|
|
|
|
ata_link_printk(link, KERN_ERR,
|
|
|
|
|
"failed to reset PMP, giving up\n");
|
|
|
|
|
goto fail;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* PMP is reset, SErrors cannot be trusted, scan all */
|
2008-01-23 16:05:14 +01:00
|
|
|
ata_port_for_each_link(tlink, ap) {
|
|
|
|
|
struct ata_eh_context *ehc = &tlink->eh_context;
|
|
|
|
|
|
|
|
|
|
ehc->i.probe_mask |= ATA_ALL_DEVICES;
|
|
|
|
|
ehc->i.action |= ATA_EH_RESET;
|
|
|
|
|
}
|
2007-09-23 06:19:54 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* If revalidation is requested, revalidate and reconfigure;
|
|
|
|
|
* otherwise, do quick revalidation.
|
|
|
|
|
*/
|
|
|
|
|
if (ehc->i.action & ATA_EH_REVALIDATE)
|
|
|
|
|
rc = sata_pmp_revalidate(dev, ehc->classes[0]);
|
|
|
|
|
else
|
|
|
|
|
rc = sata_pmp_revalidate_quick(dev);
|
|
|
|
|
|
|
|
|
|
if (rc) {
|
|
|
|
|
tries--;
|
|
|
|
|
|
|
|
|
|
if (rc == -ENODEV) {
|
2008-01-23 16:05:14 +01:00
|
|
|
ehc->i.probe_mask |= ATA_ALL_DEVICES;
|
2007-09-23 06:19:54 +02:00
|
|
|
detach = 1;
|
|
|
|
|
/* give it just two more chances */
|
|
|
|
|
tries = min(tries, 2);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (tries) {
|
|
|
|
|
/* consecutive revalidation failures? speed down */
|
|
|
|
|
if (reval_failed)
|
|
|
|
|
sata_down_spd_limit(link);
|
|
|
|
|
else
|
|
|
|
|
reval_failed = 1;
|
|
|
|
|
|
libata: prefer hardreset
When both soft and hard resets are available, libata preferred
softreset till now. The logic behind it was to be softer to devices;
however, this doesn't really help much. Rationales for the change:
* BIOS may freeze lock certain things during boot and softreset can't
unlock those. This by itself is okay but during operation PHY event
or other error conditions can trigger hardreset and the device may
end up with different configuration.
For example, after a hardreset, previously unlockable HPA can be
unlocked resulting in different device size and thus revalidation
failure. Similar condition can occur during or after resume.
* Certain ATAPI devices require hardreset to recover after certain
error conditions. On PATA, this is done by issuing the DEVICE RESET
command. On SATA, COMRESET has equivalent effect. The problem is
that DEVICE RESET needs its own execution protocol.
For SFF controllers with bare TF access, it can be easily
implemented but more advanced controllers (e.g. ahci and sata_sil24)
require specialized implementations. Simply using hardreset solves
the problem nicely.
* COMRESET initialization sequence is the norm in SATA land and many
SATA devices don't work properly if only SRST is used. For example,
some PMPs behave this way and libata works around by always issuing
hardreset if the host supports PMP.
Like the above example, libata has developed a number of mechanisms
aiming to promote softreset to hardreset if softreset is not going
to work. This approach is time consuming and error prone.
Also, note that, dependingon how you read the specs, it could be
argued that PMP fan-out ports require COMRESET to start operation.
In fact, all the PMPs on the market except one don't work properly
if COMRESET is not issued to fan-out ports after PMP reset.
* COMRESET is an integral part of SATA connection and any working
device should be able to handle COMRESET properly. After all, it's
the way to signal hardreset during reboot. This is the most used
and recommended (at least by the ahci spec) method of resetting
devices.
So, this patch makes libata prefer hardreset over softreset by making
the following changes.
* Rename ATA_EH_RESET_MASK to ATA_EH_RESET and use it whereever
ATA_EH_{SOFT|HARD}RESET used to be used. ATA_EH_{SOFT|HARD}RESET is
now only used to tell prereset whether soft or hard reset will be
issued.
* Strip out now unneeded promote-to-hardreset logics from
ata_eh_reset(), ata_std_prereset(), sata_pmp_std_prereset() and
other places.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-01-23 16:05:14 +01:00
|
|
|
ehc->i.action |= ATA_EH_RESET;
|
2007-09-23 06:19:54 +02:00
|
|
|
goto retry;
|
|
|
|
|
} else {
|
|
|
|
|
ata_dev_printk(dev, KERN_ERR, "failed to recover PMP "
|
|
|
|
|
"after %d tries, giving up\n",
|
|
|
|
|
ATA_EH_PMP_TRIES);
|
|
|
|
|
goto fail;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* okay, PMP resurrected */
|
|
|
|
|
ehc->i.flags = 0;
|
|
|
|
|
|
|
|
|
|
DPRINTK("EXIT, rc=0\n");
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
|
|
fail:
|
|
|
|
|
sata_pmp_detach(dev);
|
|
|
|
|
if (detach)
|
|
|
|
|
ata_eh_detach_dev(dev);
|
|
|
|
|
else
|
|
|
|
|
ata_dev_disable(dev);
|
|
|
|
|
|
|
|
|
|
DPRINTK("EXIT, rc=%d\n", rc);
|
|
|
|
|
return rc;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static int sata_pmp_eh_handle_disabled_links(struct ata_port *ap)
|
|
|
|
|
{
|
|
|
|
|
struct ata_link *link;
|
|
|
|
|
unsigned long flags;
|
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
|
|
spin_lock_irqsave(ap->lock, flags);
|
|
|
|
|
|
|
|
|
|
ata_port_for_each_link(link, ap) {
|
|
|
|
|
if (!(link->flags & ATA_LFLAG_DISABLED))
|
|
|
|
|
continue;
|
|
|
|
|
|
|
|
|
|
spin_unlock_irqrestore(ap->lock, flags);
|
|
|
|
|
|
|
|
|
|
/* Some PMPs require hardreset sequence to get
|
|
|
|
|
* SError.N working.
|
|
|
|
|
*/
|
libata: prefer hardreset
When both soft and hard resets are available, libata preferred
softreset till now. The logic behind it was to be softer to devices;
however, this doesn't really help much. Rationales for the change:
* BIOS may freeze lock certain things during boot and softreset can't
unlock those. This by itself is okay but during operation PHY event
or other error conditions can trigger hardreset and the device may
end up with different configuration.
For example, after a hardreset, previously unlockable HPA can be
unlocked resulting in different device size and thus revalidation
failure. Similar condition can occur during or after resume.
* Certain ATAPI devices require hardreset to recover after certain
error conditions. On PATA, this is done by issuing the DEVICE RESET
command. On SATA, COMRESET has equivalent effect. The problem is
that DEVICE RESET needs its own execution protocol.
For SFF controllers with bare TF access, it can be easily
implemented but more advanced controllers (e.g. ahci and sata_sil24)
require specialized implementations. Simply using hardreset solves
the problem nicely.
* COMRESET initialization sequence is the norm in SATA land and many
SATA devices don't work properly if only SRST is used. For example,
some PMPs behave this way and libata works around by always issuing
hardreset if the host supports PMP.
Like the above example, libata has developed a number of mechanisms
aiming to promote softreset to hardreset if softreset is not going
to work. This approach is time consuming and error prone.
Also, note that, dependingon how you read the specs, it could be
argued that PMP fan-out ports require COMRESET to start operation.
In fact, all the PMPs on the market except one don't work properly
if COMRESET is not issued to fan-out ports after PMP reset.
* COMRESET is an integral part of SATA connection and any working
device should be able to handle COMRESET properly. After all, it's
the way to signal hardreset during reboot. This is the most used
and recommended (at least by the ahci spec) method of resetting
devices.
So, this patch makes libata prefer hardreset over softreset by making
the following changes.
* Rename ATA_EH_RESET_MASK to ATA_EH_RESET and use it whereever
ATA_EH_{SOFT|HARD}RESET used to be used. ATA_EH_{SOFT|HARD}RESET is
now only used to tell prereset whether soft or hard reset will be
issued.
* Strip out now unneeded promote-to-hardreset logics from
ata_eh_reset(), ata_std_prereset(), sata_pmp_std_prereset() and
other places.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-01-23 16:05:14 +01:00
|
|
|
sata_link_hardreset(link, sata_deb_timing_normal,
|
2008-05-19 19:17:51 +02:00
|
|
|
ata_deadline(jiffies, ATA_TMOUT_INTERNAL_QUICK),
|
|
|
|
|
NULL, NULL);
|
2007-09-23 06:19:54 +02:00
|
|
|
|
|
|
|
|
/* unconditionally clear SError.N */
|
|
|
|
|
rc = sata_scr_write(link, SCR_ERROR, SERR_PHYRDY_CHG);
|
|
|
|
|
if (rc) {
|
|
|
|
|
ata_link_printk(link, KERN_ERR, "failed to clear "
|
|
|
|
|
"SError.N (errno=%d)\n", rc);
|
|
|
|
|
return rc;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
spin_lock_irqsave(ap->lock, flags);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
spin_unlock_irqrestore(ap->lock, flags);
|
|
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static int sata_pmp_handle_link_fail(struct ata_link *link, int *link_tries)
|
|
|
|
|
{
|
|
|
|
|
struct ata_port *ap = link->ap;
|
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
|
|
if (link_tries[link->pmp] && --link_tries[link->pmp])
|
|
|
|
|
return 1;
|
|
|
|
|
|
|
|
|
|
/* disable this link */
|
|
|
|
|
if (!(link->flags & ATA_LFLAG_DISABLED)) {
|
|
|
|
|
ata_link_printk(link, KERN_WARNING,
|
|
|
|
|
"failed to recover link after %d tries, disabling\n",
|
|
|
|
|
ATA_EH_PMP_LINK_TRIES);
|
|
|
|
|
|
|
|
|
|
spin_lock_irqsave(ap->lock, flags);
|
|
|
|
|
link->flags |= ATA_LFLAG_DISABLED;
|
|
|
|
|
spin_unlock_irqrestore(ap->lock, flags);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
ata_dev_disable(link->device);
|
|
|
|
|
link->eh_context.i.action = 0;
|
|
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* sata_pmp_eh_recover - recover PMP-enabled port
|
|
|
|
|
* @ap: ATA port to recover
|
|
|
|
|
*
|
|
|
|
|
* Drive EH recovery operation for PMP enabled port @ap. This
|
|
|
|
|
* function recovers host and PMP ports with proper retrials and
|
|
|
|
|
* fallbacks. Actual recovery operations are performed using
|
|
|
|
|
* ata_eh_recover() and sata_pmp_eh_recover_pmp().
|
|
|
|
|
*
|
|
|
|
|
* LOCKING:
|
|
|
|
|
* Kernel thread context (may sleep).
|
|
|
|
|
*
|
|
|
|
|
* RETURNS:
|
|
|
|
|
* 0 on success, -errno on failure.
|
|
|
|
|
*/
|
libata: make reset related methods proper port operations
Currently reset methods are not specified directly in the
ata_port_operations table. If a LLD wants to use custom reset
methods, it should construct and use a error_handler which uses those
reset methods. It's done this way for two reasons.
First, the ops table already contained too many methods and adding
four more of them would noticeably increase the amount of necessary
boilerplate code all over low level drivers.
Second, as ->error_handler uses those reset methods, it can get
confusing. ie. By overriding ->error_handler, those reset ops can be
made useless making layering a bit hazy.
Now that ops table uses inheritance, the first problem doesn't exist
anymore. The second isn't completely solved but is relieved by
providing default values - most drivers can just override what it has
implemented and don't have to concern itself about higher level
callbacks. In fact, there currently is no driver which actually
modifies error handling behavior. Drivers which override
->error_handler just wraps the standard error handler only to prepare
the controller for EH. I don't think making ops layering strict has
any noticeable benefit.
This patch makes ->prereset, ->softreset, ->hardreset, ->postreset and
their PMP counterparts propoer ops. Default ops are provided in the
base ops tables and drivers are converted to override individual reset
methods instead of creating custom error_handler.
* ata_std_error_handler() doesn't use sata_std_hardreset() if SCRs
aren't accessible. sata_promise doesn't need to use separate
error_handlers for PATA and SATA anymore.
* softreset is broken for sata_inic162x and sata_sx4. As libata now
always prefers hardreset, this doesn't really matter but the ops are
forced to NULL using ATA_OP_NULL for documentation purpose.
* pata_hpt374 needs to use different prereset for the first and second
PCI functions. This used to be done by branching from
hpt374_error_handler(). The proper way to do this is to use
separate ops and port_info tables for each function. Converted.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-03-25 04:22:50 +01:00
|
|
|
static int sata_pmp_eh_recover(struct ata_port *ap)
|
2007-09-23 06:19:54 +02:00
|
|
|
{
|
libata: make reset related methods proper port operations
Currently reset methods are not specified directly in the
ata_port_operations table. If a LLD wants to use custom reset
methods, it should construct and use a error_handler which uses those
reset methods. It's done this way for two reasons.
First, the ops table already contained too many methods and adding
four more of them would noticeably increase the amount of necessary
boilerplate code all over low level drivers.
Second, as ->error_handler uses those reset methods, it can get
confusing. ie. By overriding ->error_handler, those reset ops can be
made useless making layering a bit hazy.
Now that ops table uses inheritance, the first problem doesn't exist
anymore. The second isn't completely solved but is relieved by
providing default values - most drivers can just override what it has
implemented and don't have to concern itself about higher level
callbacks. In fact, there currently is no driver which actually
modifies error handling behavior. Drivers which override
->error_handler just wraps the standard error handler only to prepare
the controller for EH. I don't think making ops layering strict has
any noticeable benefit.
This patch makes ->prereset, ->softreset, ->hardreset, ->postreset and
their PMP counterparts propoer ops. Default ops are provided in the
base ops tables and drivers are converted to override individual reset
methods instead of creating custom error_handler.
* ata_std_error_handler() doesn't use sata_std_hardreset() if SCRs
aren't accessible. sata_promise doesn't need to use separate
error_handlers for PATA and SATA anymore.
* softreset is broken for sata_inic162x and sata_sx4. As libata now
always prefers hardreset, this doesn't really matter but the ops are
forced to NULL using ATA_OP_NULL for documentation purpose.
* pata_hpt374 needs to use different prereset for the first and second
PCI functions. This used to be done by branching from
hpt374_error_handler(). The proper way to do this is to use
separate ops and port_info tables for each function. Converted.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-03-25 04:22:50 +01:00
|
|
|
struct ata_port_operations *ops = ap->ops;
|
2007-09-23 06:19:54 +02:00
|
|
|
int pmp_tries, link_tries[SATA_PMP_MAX_PORTS];
|
|
|
|
|
struct ata_link *pmp_link = &ap->link;
|
|
|
|
|
struct ata_device *pmp_dev = pmp_link->device;
|
|
|
|
|
struct ata_eh_context *pmp_ehc = &pmp_link->eh_context;
|
2008-05-18 18:15:11 +02:00
|
|
|
u32 *gscr = pmp_dev->gscr;
|
2007-09-23 06:19:54 +02:00
|
|
|
struct ata_link *link;
|
|
|
|
|
struct ata_device *dev;
|
2007-10-09 08:06:48 +02:00
|
|
|
unsigned int err_mask;
|
2007-09-23 06:19:54 +02:00
|
|
|
u32 gscr_error, sntf;
|
|
|
|
|
int cnt, rc;
|
|
|
|
|
|
|
|
|
|
pmp_tries = ATA_EH_PMP_TRIES;
|
|
|
|
|
ata_port_for_each_link(link, ap)
|
|
|
|
|
link_tries[link->pmp] = ATA_EH_PMP_LINK_TRIES;
|
|
|
|
|
|
|
|
|
|
retry:
|
|
|
|
|
/* PMP attached? */
|
2008-04-07 15:47:22 +02:00
|
|
|
if (!sata_pmp_attached(ap)) {
|
libata: make reset related methods proper port operations
Currently reset methods are not specified directly in the
ata_port_operations table. If a LLD wants to use custom reset
methods, it should construct and use a error_handler which uses those
reset methods. It's done this way for two reasons.
First, the ops table already contained too many methods and adding
four more of them would noticeably increase the amount of necessary
boilerplate code all over low level drivers.
Second, as ->error_handler uses those reset methods, it can get
confusing. ie. By overriding ->error_handler, those reset ops can be
made useless making layering a bit hazy.
Now that ops table uses inheritance, the first problem doesn't exist
anymore. The second isn't completely solved but is relieved by
providing default values - most drivers can just override what it has
implemented and don't have to concern itself about higher level
callbacks. In fact, there currently is no driver which actually
modifies error handling behavior. Drivers which override
->error_handler just wraps the standard error handler only to prepare
the controller for EH. I don't think making ops layering strict has
any noticeable benefit.
This patch makes ->prereset, ->softreset, ->hardreset, ->postreset and
their PMP counterparts propoer ops. Default ops are provided in the
base ops tables and drivers are converted to override individual reset
methods instead of creating custom error_handler.
* ata_std_error_handler() doesn't use sata_std_hardreset() if SCRs
aren't accessible. sata_promise doesn't need to use separate
error_handlers for PATA and SATA anymore.
* softreset is broken for sata_inic162x and sata_sx4. As libata now
always prefers hardreset, this doesn't really matter but the ops are
forced to NULL using ATA_OP_NULL for documentation purpose.
* pata_hpt374 needs to use different prereset for the first and second
PCI functions. This used to be done by branching from
hpt374_error_handler(). The proper way to do this is to use
separate ops and port_info tables for each function. Converted.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-03-25 04:22:50 +01:00
|
|
|
rc = ata_eh_recover(ap, ops->prereset, ops->softreset,
|
|
|
|
|
ops->hardreset, ops->postreset, NULL);
|
2007-09-23 06:19:54 +02:00
|
|
|
if (rc) {
|
|
|
|
|
ata_link_for_each_dev(dev, &ap->link)
|
|
|
|
|
ata_dev_disable(dev);
|
|
|
|
|
return rc;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (pmp_dev->class != ATA_DEV_PMP)
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
|
|
/* new PMP online */
|
|
|
|
|
ata_port_for_each_link(link, ap)
|
|
|
|
|
link_tries[link->pmp] = ATA_EH_PMP_LINK_TRIES;
|
|
|
|
|
|
|
|
|
|
/* fall through */
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* recover pmp */
|
libata: make reset related methods proper port operations
Currently reset methods are not specified directly in the
ata_port_operations table. If a LLD wants to use custom reset
methods, it should construct and use a error_handler which uses those
reset methods. It's done this way for two reasons.
First, the ops table already contained too many methods and adding
four more of them would noticeably increase the amount of necessary
boilerplate code all over low level drivers.
Second, as ->error_handler uses those reset methods, it can get
confusing. ie. By overriding ->error_handler, those reset ops can be
made useless making layering a bit hazy.
Now that ops table uses inheritance, the first problem doesn't exist
anymore. The second isn't completely solved but is relieved by
providing default values - most drivers can just override what it has
implemented and don't have to concern itself about higher level
callbacks. In fact, there currently is no driver which actually
modifies error handling behavior. Drivers which override
->error_handler just wraps the standard error handler only to prepare
the controller for EH. I don't think making ops layering strict has
any noticeable benefit.
This patch makes ->prereset, ->softreset, ->hardreset, ->postreset and
their PMP counterparts propoer ops. Default ops are provided in the
base ops tables and drivers are converted to override individual reset
methods instead of creating custom error_handler.
* ata_std_error_handler() doesn't use sata_std_hardreset() if SCRs
aren't accessible. sata_promise doesn't need to use separate
error_handlers for PATA and SATA anymore.
* softreset is broken for sata_inic162x and sata_sx4. As libata now
always prefers hardreset, this doesn't really matter but the ops are
forced to NULL using ATA_OP_NULL for documentation purpose.
* pata_hpt374 needs to use different prereset for the first and second
PCI functions. This used to be done by branching from
hpt374_error_handler(). The proper way to do this is to use
separate ops and port_info tables for each function. Converted.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-03-25 04:22:50 +01:00
|
|
|
rc = sata_pmp_eh_recover_pmp(ap, ops->prereset, ops->softreset,
|
|
|
|
|
ops->hardreset, ops->postreset);
|
2007-09-23 06:19:54 +02:00
|
|
|
if (rc)
|
|
|
|
|
goto pmp_fail;
|
|
|
|
|
|
2008-05-18 18:15:11 +02:00
|
|
|
/* PHY event notification can disturb reset and other recovery
|
|
|
|
|
* operations. Turn it off.
|
|
|
|
|
*/
|
|
|
|
|
if (gscr[SATA_PMP_GSCR_FEAT_EN] & SATA_PMP_FEAT_NOTIFY) {
|
|
|
|
|
gscr[SATA_PMP_GSCR_FEAT_EN] &= ~SATA_PMP_FEAT_NOTIFY;
|
|
|
|
|
|
|
|
|
|
err_mask = sata_pmp_write(pmp_link, SATA_PMP_GSCR_FEAT_EN,
|
|
|
|
|
gscr[SATA_PMP_GSCR_FEAT_EN]);
|
|
|
|
|
if (err_mask) {
|
|
|
|
|
ata_link_printk(pmp_link, KERN_WARNING,
|
|
|
|
|
"failed to disable NOTIFY (err_mask=0x%x)\n",
|
|
|
|
|
err_mask);
|
|
|
|
|
goto pmp_fail;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2007-09-23 06:19:54 +02:00
|
|
|
/* handle disabled links */
|
|
|
|
|
rc = sata_pmp_eh_handle_disabled_links(ap);
|
|
|
|
|
if (rc)
|
|
|
|
|
goto pmp_fail;
|
|
|
|
|
|
|
|
|
|
/* recover links */
|
libata: make reset related methods proper port operations
Currently reset methods are not specified directly in the
ata_port_operations table. If a LLD wants to use custom reset
methods, it should construct and use a error_handler which uses those
reset methods. It's done this way for two reasons.
First, the ops table already contained too many methods and adding
four more of them would noticeably increase the amount of necessary
boilerplate code all over low level drivers.
Second, as ->error_handler uses those reset methods, it can get
confusing. ie. By overriding ->error_handler, those reset ops can be
made useless making layering a bit hazy.
Now that ops table uses inheritance, the first problem doesn't exist
anymore. The second isn't completely solved but is relieved by
providing default values - most drivers can just override what it has
implemented and don't have to concern itself about higher level
callbacks. In fact, there currently is no driver which actually
modifies error handling behavior. Drivers which override
->error_handler just wraps the standard error handler only to prepare
the controller for EH. I don't think making ops layering strict has
any noticeable benefit.
This patch makes ->prereset, ->softreset, ->hardreset, ->postreset and
their PMP counterparts propoer ops. Default ops are provided in the
base ops tables and drivers are converted to override individual reset
methods instead of creating custom error_handler.
* ata_std_error_handler() doesn't use sata_std_hardreset() if SCRs
aren't accessible. sata_promise doesn't need to use separate
error_handlers for PATA and SATA anymore.
* softreset is broken for sata_inic162x and sata_sx4. As libata now
always prefers hardreset, this doesn't really matter but the ops are
forced to NULL using ATA_OP_NULL for documentation purpose.
* pata_hpt374 needs to use different prereset for the first and second
PCI functions. This used to be done by branching from
hpt374_error_handler(). The proper way to do this is to use
separate ops and port_info tables for each function. Converted.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-03-25 04:22:50 +01:00
|
|
|
rc = ata_eh_recover(ap, ops->pmp_prereset, ops->pmp_softreset,
|
|
|
|
|
ops->pmp_hardreset, ops->pmp_postreset, &link);
|
2007-09-23 06:19:54 +02:00
|
|
|
if (rc)
|
|
|
|
|
goto link_fail;
|
|
|
|
|
|
|
|
|
|
/* Connection status might have changed while resetting other
|
|
|
|
|
* links, check SATA_PMP_GSCR_ERROR before returning.
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
/* clear SNotification */
|
|
|
|
|
rc = sata_scr_read(&ap->link, SCR_NOTIFICATION, &sntf);
|
|
|
|
|
if (rc == 0)
|
|
|
|
|
sata_scr_write(&ap->link, SCR_NOTIFICATION, sntf);
|
|
|
|
|
|
|
|
|
|
/* enable notification */
|
|
|
|
|
if (pmp_dev->flags & ATA_DFLAG_AN) {
|
2008-05-18 18:15:11 +02:00
|
|
|
gscr[SATA_PMP_GSCR_FEAT_EN] |= SATA_PMP_FEAT_NOTIFY;
|
2007-09-23 06:19:54 +02:00
|
|
|
|
2008-05-18 18:15:11 +02:00
|
|
|
err_mask = sata_pmp_write(pmp_link, SATA_PMP_GSCR_FEAT_EN,
|
|
|
|
|
gscr[SATA_PMP_GSCR_FEAT_EN]);
|
2007-10-09 08:06:48 +02:00
|
|
|
if (err_mask) {
|
|
|
|
|
ata_dev_printk(pmp_dev, KERN_ERR, "failed to write "
|
|
|
|
|
"PMP_FEAT_EN (Emask=0x%x)\n", err_mask);
|
|
|
|
|
rc = -EIO;
|
2007-09-23 06:19:54 +02:00
|
|
|
goto pmp_fail;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* check GSCR_ERROR */
|
2007-10-09 08:06:48 +02:00
|
|
|
err_mask = sata_pmp_read(pmp_link, SATA_PMP_GSCR_ERROR, &gscr_error);
|
|
|
|
|
if (err_mask) {
|
|
|
|
|
ata_dev_printk(pmp_dev, KERN_ERR, "failed to read "
|
|
|
|
|
"PMP_GSCR_ERROR (Emask=0x%x)\n", err_mask);
|
|
|
|
|
rc = -EIO;
|
2007-09-23 06:19:54 +02:00
|
|
|
goto pmp_fail;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
cnt = 0;
|
|
|
|
|
ata_port_for_each_link(link, ap) {
|
|
|
|
|
if (!(gscr_error & (1 << link->pmp)))
|
|
|
|
|
continue;
|
|
|
|
|
|
|
|
|
|
if (sata_pmp_handle_link_fail(link, link_tries)) {
|
|
|
|
|
ata_ehi_hotplugged(&link->eh_context.i);
|
|
|
|
|
cnt++;
|
|
|
|
|
} else {
|
|
|
|
|
ata_link_printk(link, KERN_WARNING,
|
|
|
|
|
"PHY status changed but maxed out on retries, "
|
|
|
|
|
"giving up\n");
|
|
|
|
|
ata_link_printk(link, KERN_WARNING,
|
|
|
|
|
"Manully issue scan to resume this link\n");
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (cnt) {
|
|
|
|
|
ata_port_printk(ap, KERN_INFO, "PMP SError.N set for some "
|
|
|
|
|
"ports, repeating recovery\n");
|
|
|
|
|
goto retry;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
|
|
link_fail:
|
|
|
|
|
if (sata_pmp_handle_link_fail(link, link_tries)) {
|
libata: prefer hardreset
When both soft and hard resets are available, libata preferred
softreset till now. The logic behind it was to be softer to devices;
however, this doesn't really help much. Rationales for the change:
* BIOS may freeze lock certain things during boot and softreset can't
unlock those. This by itself is okay but during operation PHY event
or other error conditions can trigger hardreset and the device may
end up with different configuration.
For example, after a hardreset, previously unlockable HPA can be
unlocked resulting in different device size and thus revalidation
failure. Similar condition can occur during or after resume.
* Certain ATAPI devices require hardreset to recover after certain
error conditions. On PATA, this is done by issuing the DEVICE RESET
command. On SATA, COMRESET has equivalent effect. The problem is
that DEVICE RESET needs its own execution protocol.
For SFF controllers with bare TF access, it can be easily
implemented but more advanced controllers (e.g. ahci and sata_sil24)
require specialized implementations. Simply using hardreset solves
the problem nicely.
* COMRESET initialization sequence is the norm in SATA land and many
SATA devices don't work properly if only SRST is used. For example,
some PMPs behave this way and libata works around by always issuing
hardreset if the host supports PMP.
Like the above example, libata has developed a number of mechanisms
aiming to promote softreset to hardreset if softreset is not going
to work. This approach is time consuming and error prone.
Also, note that, dependingon how you read the specs, it could be
argued that PMP fan-out ports require COMRESET to start operation.
In fact, all the PMPs on the market except one don't work properly
if COMRESET is not issued to fan-out ports after PMP reset.
* COMRESET is an integral part of SATA connection and any working
device should be able to handle COMRESET properly. After all, it's
the way to signal hardreset during reboot. This is the most used
and recommended (at least by the ahci spec) method of resetting
devices.
So, this patch makes libata prefer hardreset over softreset by making
the following changes.
* Rename ATA_EH_RESET_MASK to ATA_EH_RESET and use it whereever
ATA_EH_{SOFT|HARD}RESET used to be used. ATA_EH_{SOFT|HARD}RESET is
now only used to tell prereset whether soft or hard reset will be
issued.
* Strip out now unneeded promote-to-hardreset logics from
ata_eh_reset(), ata_std_prereset(), sata_pmp_std_prereset() and
other places.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-01-23 16:05:14 +01:00
|
|
|
pmp_ehc->i.action |= ATA_EH_RESET;
|
2007-09-23 06:19:54 +02:00
|
|
|
goto retry;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* fall through */
|
|
|
|
|
pmp_fail:
|
|
|
|
|
/* Control always ends up here after detaching PMP. Shut up
|
|
|
|
|
* and return if we're unloading.
|
|
|
|
|
*/
|
|
|
|
|
if (ap->pflags & ATA_PFLAG_UNLOADING)
|
|
|
|
|
return rc;
|
|
|
|
|
|
2008-04-07 15:47:22 +02:00
|
|
|
if (!sata_pmp_attached(ap))
|
2007-09-23 06:19:54 +02:00
|
|
|
goto retry;
|
|
|
|
|
|
|
|
|
|
if (--pmp_tries) {
|
libata: prefer hardreset
When both soft and hard resets are available, libata preferred
softreset till now. The logic behind it was to be softer to devices;
however, this doesn't really help much. Rationales for the change:
* BIOS may freeze lock certain things during boot and softreset can't
unlock those. This by itself is okay but during operation PHY event
or other error conditions can trigger hardreset and the device may
end up with different configuration.
For example, after a hardreset, previously unlockable HPA can be
unlocked resulting in different device size and thus revalidation
failure. Similar condition can occur during or after resume.
* Certain ATAPI devices require hardreset to recover after certain
error conditions. On PATA, this is done by issuing the DEVICE RESET
command. On SATA, COMRESET has equivalent effect. The problem is
that DEVICE RESET needs its own execution protocol.
For SFF controllers with bare TF access, it can be easily
implemented but more advanced controllers (e.g. ahci and sata_sil24)
require specialized implementations. Simply using hardreset solves
the problem nicely.
* COMRESET initialization sequence is the norm in SATA land and many
SATA devices don't work properly if only SRST is used. For example,
some PMPs behave this way and libata works around by always issuing
hardreset if the host supports PMP.
Like the above example, libata has developed a number of mechanisms
aiming to promote softreset to hardreset if softreset is not going
to work. This approach is time consuming and error prone.
Also, note that, dependingon how you read the specs, it could be
argued that PMP fan-out ports require COMRESET to start operation.
In fact, all the PMPs on the market except one don't work properly
if COMRESET is not issued to fan-out ports after PMP reset.
* COMRESET is an integral part of SATA connection and any working
device should be able to handle COMRESET properly. After all, it's
the way to signal hardreset during reboot. This is the most used
and recommended (at least by the ahci spec) method of resetting
devices.
So, this patch makes libata prefer hardreset over softreset by making
the following changes.
* Rename ATA_EH_RESET_MASK to ATA_EH_RESET and use it whereever
ATA_EH_{SOFT|HARD}RESET used to be used. ATA_EH_{SOFT|HARD}RESET is
now only used to tell prereset whether soft or hard reset will be
issued.
* Strip out now unneeded promote-to-hardreset logics from
ata_eh_reset(), ata_std_prereset(), sata_pmp_std_prereset() and
other places.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-01-23 16:05:14 +01:00
|
|
|
pmp_ehc->i.action |= ATA_EH_RESET;
|
2007-09-23 06:19:54 +02:00
|
|
|
goto retry;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
ata_port_printk(ap, KERN_ERR,
|
|
|
|
|
"failed to recover PMP after %d tries, giving up\n",
|
|
|
|
|
ATA_EH_PMP_TRIES);
|
|
|
|
|
sata_pmp_detach(pmp_dev);
|
|
|
|
|
ata_dev_disable(pmp_dev);
|
|
|
|
|
|
|
|
|
|
return rc;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
libata: make reset related methods proper port operations
Currently reset methods are not specified directly in the
ata_port_operations table. If a LLD wants to use custom reset
methods, it should construct and use a error_handler which uses those
reset methods. It's done this way for two reasons.
First, the ops table already contained too many methods and adding
four more of them would noticeably increase the amount of necessary
boilerplate code all over low level drivers.
Second, as ->error_handler uses those reset methods, it can get
confusing. ie. By overriding ->error_handler, those reset ops can be
made useless making layering a bit hazy.
Now that ops table uses inheritance, the first problem doesn't exist
anymore. The second isn't completely solved but is relieved by
providing default values - most drivers can just override what it has
implemented and don't have to concern itself about higher level
callbacks. In fact, there currently is no driver which actually
modifies error handling behavior. Drivers which override
->error_handler just wraps the standard error handler only to prepare
the controller for EH. I don't think making ops layering strict has
any noticeable benefit.
This patch makes ->prereset, ->softreset, ->hardreset, ->postreset and
their PMP counterparts propoer ops. Default ops are provided in the
base ops tables and drivers are converted to override individual reset
methods instead of creating custom error_handler.
* ata_std_error_handler() doesn't use sata_std_hardreset() if SCRs
aren't accessible. sata_promise doesn't need to use separate
error_handlers for PATA and SATA anymore.
* softreset is broken for sata_inic162x and sata_sx4. As libata now
always prefers hardreset, this doesn't really matter but the ops are
forced to NULL using ATA_OP_NULL for documentation purpose.
* pata_hpt374 needs to use different prereset for the first and second
PCI functions. This used to be done by branching from
hpt374_error_handler(). The proper way to do this is to use
separate ops and port_info tables for each function. Converted.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-03-25 04:22:50 +01:00
|
|
|
* sata_pmp_error_handler - do standard error handling for PMP-enabled host
|
2007-09-23 06:19:54 +02:00
|
|
|
* @ap: host port to handle error for
|
|
|
|
|
*
|
|
|
|
|
* Perform standard error handling sequence for PMP-enabled host
|
|
|
|
|
* @ap.
|
|
|
|
|
*
|
|
|
|
|
* LOCKING:
|
|
|
|
|
* Kernel thread context (may sleep).
|
|
|
|
|
*/
|
libata: make reset related methods proper port operations
Currently reset methods are not specified directly in the
ata_port_operations table. If a LLD wants to use custom reset
methods, it should construct and use a error_handler which uses those
reset methods. It's done this way for two reasons.
First, the ops table already contained too many methods and adding
four more of them would noticeably increase the amount of necessary
boilerplate code all over low level drivers.
Second, as ->error_handler uses those reset methods, it can get
confusing. ie. By overriding ->error_handler, those reset ops can be
made useless making layering a bit hazy.
Now that ops table uses inheritance, the first problem doesn't exist
anymore. The second isn't completely solved but is relieved by
providing default values - most drivers can just override what it has
implemented and don't have to concern itself about higher level
callbacks. In fact, there currently is no driver which actually
modifies error handling behavior. Drivers which override
->error_handler just wraps the standard error handler only to prepare
the controller for EH. I don't think making ops layering strict has
any noticeable benefit.
This patch makes ->prereset, ->softreset, ->hardreset, ->postreset and
their PMP counterparts propoer ops. Default ops are provided in the
base ops tables and drivers are converted to override individual reset
methods instead of creating custom error_handler.
* ata_std_error_handler() doesn't use sata_std_hardreset() if SCRs
aren't accessible. sata_promise doesn't need to use separate
error_handlers for PATA and SATA anymore.
* softreset is broken for sata_inic162x and sata_sx4. As libata now
always prefers hardreset, this doesn't really matter but the ops are
forced to NULL using ATA_OP_NULL for documentation purpose.
* pata_hpt374 needs to use different prereset for the first and second
PCI functions. This used to be done by branching from
hpt374_error_handler(). The proper way to do this is to use
separate ops and port_info tables for each function. Converted.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-03-25 04:22:50 +01:00
|
|
|
void sata_pmp_error_handler(struct ata_port *ap)
|
2007-09-23 06:19:54 +02:00
|
|
|
{
|
|
|
|
|
ata_eh_autopsy(ap);
|
|
|
|
|
ata_eh_report(ap);
|
libata: make reset related methods proper port operations
Currently reset methods are not specified directly in the
ata_port_operations table. If a LLD wants to use custom reset
methods, it should construct and use a error_handler which uses those
reset methods. It's done this way for two reasons.
First, the ops table already contained too many methods and adding
four more of them would noticeably increase the amount of necessary
boilerplate code all over low level drivers.
Second, as ->error_handler uses those reset methods, it can get
confusing. ie. By overriding ->error_handler, those reset ops can be
made useless making layering a bit hazy.
Now that ops table uses inheritance, the first problem doesn't exist
anymore. The second isn't completely solved but is relieved by
providing default values - most drivers can just override what it has
implemented and don't have to concern itself about higher level
callbacks. In fact, there currently is no driver which actually
modifies error handling behavior. Drivers which override
->error_handler just wraps the standard error handler only to prepare
the controller for EH. I don't think making ops layering strict has
any noticeable benefit.
This patch makes ->prereset, ->softreset, ->hardreset, ->postreset and
their PMP counterparts propoer ops. Default ops are provided in the
base ops tables and drivers are converted to override individual reset
methods instead of creating custom error_handler.
* ata_std_error_handler() doesn't use sata_std_hardreset() if SCRs
aren't accessible. sata_promise doesn't need to use separate
error_handlers for PATA and SATA anymore.
* softreset is broken for sata_inic162x and sata_sx4. As libata now
always prefers hardreset, this doesn't really matter but the ops are
forced to NULL using ATA_OP_NULL for documentation purpose.
* pata_hpt374 needs to use different prereset for the first and second
PCI functions. This used to be done by branching from
hpt374_error_handler(). The proper way to do this is to use
separate ops and port_info tables for each function. Converted.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-03-25 04:22:50 +01:00
|
|
|
sata_pmp_eh_recover(ap);
|
2007-09-23 06:19:54 +02:00
|
|
|
ata_eh_finish(ap);
|
|
|
|
|
}
|
2008-04-07 15:47:21 +02:00
|
|
|
|
|
|
|
|
EXPORT_SYMBOL_GPL(sata_pmp_port_ops);
|
|
|
|
|
EXPORT_SYMBOL_GPL(sata_pmp_qc_defer_cmd_switch);
|
|
|
|
|
EXPORT_SYMBOL_GPL(sata_pmp_error_handler);
|
