bfa: remove useless return variables
This patch remove variables that are initialized with a constant, are never updated, and are only used as parameter of return. Return the constant instead of using a variable. Verified by compilation only. The coccinelle script that find and fixes this issue is: // <smpl> @@ type T; constant C; identifier ret; @@ - T ret = C; ... when != ret when strict return - ret + C ; // </smpl> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> Acked-by: Sudarsana Kalluru <Sudarsana.Kalluru@qlogic.com> Signed-off-by: Christoph Hellwig <hch@lst.de>
This commit is contained in:
parent
03a6c3ff32
commit
0e772b33a1
1 changed files with 4 additions and 6 deletions
|
@ -26,7 +26,6 @@ int
|
||||||
bfad_iocmd_ioc_enable(struct bfad_s *bfad, void *cmd)
|
bfad_iocmd_ioc_enable(struct bfad_s *bfad, void *cmd)
|
||||||
{
|
{
|
||||||
struct bfa_bsg_gen_s *iocmd = (struct bfa_bsg_gen_s *)cmd;
|
struct bfa_bsg_gen_s *iocmd = (struct bfa_bsg_gen_s *)cmd;
|
||||||
int rc = 0;
|
|
||||||
unsigned long flags;
|
unsigned long flags;
|
||||||
|
|
||||||
spin_lock_irqsave(&bfad->bfad_lock, flags);
|
spin_lock_irqsave(&bfad->bfad_lock, flags);
|
||||||
|
@ -34,7 +33,7 @@ bfad_iocmd_ioc_enable(struct bfad_s *bfad, void *cmd)
|
||||||
if (!bfa_ioc_is_disabled(&bfad->bfa.ioc)) {
|
if (!bfa_ioc_is_disabled(&bfad->bfa.ioc)) {
|
||||||
spin_unlock_irqrestore(&bfad->bfad_lock, flags);
|
spin_unlock_irqrestore(&bfad->bfad_lock, flags);
|
||||||
iocmd->status = BFA_STATUS_OK;
|
iocmd->status = BFA_STATUS_OK;
|
||||||
return rc;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
init_completion(&bfad->enable_comp);
|
init_completion(&bfad->enable_comp);
|
||||||
|
@ -43,21 +42,20 @@ bfad_iocmd_ioc_enable(struct bfad_s *bfad, void *cmd)
|
||||||
spin_unlock_irqrestore(&bfad->bfad_lock, flags);
|
spin_unlock_irqrestore(&bfad->bfad_lock, flags);
|
||||||
wait_for_completion(&bfad->enable_comp);
|
wait_for_completion(&bfad->enable_comp);
|
||||||
|
|
||||||
return rc;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
int
|
int
|
||||||
bfad_iocmd_ioc_disable(struct bfad_s *bfad, void *cmd)
|
bfad_iocmd_ioc_disable(struct bfad_s *bfad, void *cmd)
|
||||||
{
|
{
|
||||||
struct bfa_bsg_gen_s *iocmd = (struct bfa_bsg_gen_s *)cmd;
|
struct bfa_bsg_gen_s *iocmd = (struct bfa_bsg_gen_s *)cmd;
|
||||||
int rc = 0;
|
|
||||||
unsigned long flags;
|
unsigned long flags;
|
||||||
|
|
||||||
spin_lock_irqsave(&bfad->bfad_lock, flags);
|
spin_lock_irqsave(&bfad->bfad_lock, flags);
|
||||||
if (bfa_ioc_is_disabled(&bfad->bfa.ioc)) {
|
if (bfa_ioc_is_disabled(&bfad->bfa.ioc)) {
|
||||||
spin_unlock_irqrestore(&bfad->bfad_lock, flags);
|
spin_unlock_irqrestore(&bfad->bfad_lock, flags);
|
||||||
iocmd->status = BFA_STATUS_OK;
|
iocmd->status = BFA_STATUS_OK;
|
||||||
return rc;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (bfad->disable_active) {
|
if (bfad->disable_active) {
|
||||||
|
@ -74,7 +72,7 @@ bfad_iocmd_ioc_disable(struct bfad_s *bfad, void *cmd)
|
||||||
bfad->disable_active = BFA_FALSE;
|
bfad->disable_active = BFA_FALSE;
|
||||||
iocmd->status = BFA_STATUS_OK;
|
iocmd->status = BFA_STATUS_OK;
|
||||||
|
|
||||||
return rc;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
static int
|
static int
|
||||||
|
|
Loading…
Reference in a new issue