asgardius/android_kernel_motorola_sm6225
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

sctp: handle invalid error codes without calling BUG()

Browse source 
[ Upstream commit a0067dfcd9418fd3b0632bc59210d120d038a9c6 ]

The sctp_sf_eat_auth() function is supposed to return enum sctp_disposition
values but if the call to sctp_ulpevent_make_authkey() fails, it returns
-ENOMEM.

This results in calling BUG() inside the sctp_side_effects() function.
Calling BUG() is an over reaction and not helpful.  Call WARN_ON_ONCE()
instead.

This code predates git.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Dan Carpenter 2023-06-09 14:04:43 +03:00 committed by Greg Kroah-Hartman
parent 81f141d924
commit 1590c971ce
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
net/sctp/sm_sideeffect.c
View file

@ -1255,7 +1255,10 @@ static int sctp_side_effects(enum sctp_event event_type,
default: default:
pr_err("impossible disposition %d in state %d, event_type %d, event_id %d\n", pr_err("impossible disposition %d in state %d, event_type %d, event_id %d\n",
status, state, event_type, subtype.chunk); status, state, event_type, subtype.chunk);
BUG(); error = status;
if (error >= 0)
error = -EINVAL;
WARN_ON_ONCE(1);
break; break;
} }