crypto: caam - fix mem leak in ahash_setkey
In case hash key is bigger than algorithm block size, it is hashed. In this case, memory is allocated to keep this hash in hashed_key. hashed_key has to be freed on the key_dma dma mapping error path. Signed-off-by: Horia Geanta <horia.geanta@freescale.com> Reviewed-by: Marek Vasut <marex@denx.de> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
parent
f51f593b3e
commit
3d67be2761
1 changed files with 3 additions and 1 deletions
|
@ -545,7 +545,8 @@ static int ahash_setkey(struct crypto_ahash *ahash,
|
||||||
DMA_TO_DEVICE);
|
DMA_TO_DEVICE);
|
||||||
if (dma_mapping_error(jrdev, ctx->key_dma)) {
|
if (dma_mapping_error(jrdev, ctx->key_dma)) {
|
||||||
dev_err(jrdev, "unable to map key i/o memory\n");
|
dev_err(jrdev, "unable to map key i/o memory\n");
|
||||||
return -ENOMEM;
|
ret = -ENOMEM;
|
||||||
|
goto map_err;
|
||||||
}
|
}
|
||||||
#ifdef DEBUG
|
#ifdef DEBUG
|
||||||
print_hex_dump(KERN_ERR, "ctx.key@"__stringify(__LINE__)": ",
|
print_hex_dump(KERN_ERR, "ctx.key@"__stringify(__LINE__)": ",
|
||||||
|
@ -559,6 +560,7 @@ static int ahash_setkey(struct crypto_ahash *ahash,
|
||||||
DMA_TO_DEVICE);
|
DMA_TO_DEVICE);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
map_err:
|
||||||
kfree(hashed_key);
|
kfree(hashed_key);
|
||||||
return ret;
|
return ret;
|
||||||
badkey:
|
badkey:
|
||||||
|
|
Loading…
Reference in a new issue