asgardius/android_kernel_motorola_sm6225
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mfd: smsc-ece1099: Return directly after a function failure in smsc_i2c_probe()

Browse source 
This issue was detected by using the Coccinelle software.

Return directly if a call of the function "devm_regmap_init_i2c"
or "regmap_write" failed.

Delete the jump label "err" then.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
This commit is contained in:
Markus Elfring 2016-06-26 14:30:46 +02:00 committed by Lee Jones
parent 53b34b8d88
commit 4dc03d0abb
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
drivers/mfd/smsc-ece1099.c
View file

@ -46,10 +46,8 @@ static int smsc_i2c_probe(struct i2c_client *i2c,
} }
smsc->regmap = devm_regmap_init_i2c(i2c, &smsc_regmap_config); smsc->regmap = devm_regmap_init_i2c(i2c, &smsc_regmap_config);
if (IS_ERR(smsc->regmap)) { if (IS_ERR(smsc->regmap))
ret = PTR_ERR(smsc->regmap); return PTR_ERR(smsc->regmap);
goto err;
}
i2c_set_clientdata(i2c, smsc); i2c_set_clientdata(i2c, smsc);
smsc->dev = &i2c->dev; smsc->dev = &i2c->dev;
@ -68,7 +66,7 @@ static int smsc_i2c_probe(struct i2c_client *i2c,
ret = regmap_write(smsc->regmap, SMSC_CLK_CTRL, smsc->clk); ret = regmap_write(smsc->regmap, SMSC_CLK_CTRL, smsc->clk);
if (ret) if (ret)
goto err; return ret;
#ifdef CONFIG_OF #ifdef CONFIG_OF
if (i2c->dev.of_node) if (i2c->dev.of_node)
@ -76,7 +74,6 @@ static int smsc_i2c_probe(struct i2c_client *i2c,
NULL, NULL, &i2c->dev); NULL, NULL, &i2c->dev);
#endif #endif
err:
return ret; return ret;
} }