asgardius/android_kernel_motorola_sm6225
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

brcmfmac: change return type for brcmf_rollback_toq() to void

Browse source 
The function brcmf_rollback_toq() is already called in error path
and its result should not override the initial error value. As the
function releases the sk_buff there is no need to return anything
so change return type to void.

Reviewed-by: Hante Meuleman <meuleman@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
Arend van Spriel 2013-04-17 21:25:57 +02:00 committed by John W. Linville
parent 67994fa24a
commit 88f656fa10
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c
View file

@ -1574,7 +1574,7 @@ static int brcmf_fws_precommit_skb(struct brcmf_fws_info *fws, int fifo,
return rc;
}
static int
static void
brcmf_fws_rollback_toq(struct brcmf_fws_info *fws, struct sk_buff *skb)
{
/*
@ -1654,7 +1654,6 @@ fail:
fws->stats.rollback_failed++;
} else
fws->stats.rollback_success++;
return rc;
}
static int brcmf_fws_consume_credit(struct brcmf_fws_info *fws, int fifo,
@ -1733,7 +1732,7 @@ static int brcmf_fws_commit_skb(struct brcmf_fws_info *fws, int fifo,
return rc;
rollback:
rc = brcmf_fws_rollback_toq(fws, skb);
brcmf_fws_rollback_toq(fws, skb);
return rc;
}