asgardius/android_kernel_motorola_sm6225
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

net: qrtr: fifo: Add bounds check on tx path

Browse source 
Add bounds check on values read from shared memory in the tx path. In
cases where the VM is misbehaving, the qrtr transport should exit and
print a warning when bogus values may cause out of bounds to be read.

Change-Id: I7ebef28ed8eba4c4da0b32d5114365bbe6bea390
Signed-off-by: Sarannya S <quic_sarannya@quicinc.com>
This commit is contained in:
Sarannya S 2022-12-23 15:42:29 +05:30 committed by Gerrit - the friendly Code Review server
parent 27eb9f4b4d
commit a714b4b326
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
net/qrtr/fifo.c
View file

@ -120,6 +120,9 @@ static size_t fifo_tx_avail(struct fifo_pipe *pipe)
else
avail = tail - head;
if (WARN_ON_ONCE(avail > pipe->length))
avail = 0;
return avail;
}
@ -130,6 +133,8 @@ static void fifo_tx_write(struct fifo_pipe *pipe,
u32 head;
head = le32_to_cpu(*pipe->head);
if (WARN_ON_ONCE(head > pipe->length))
return;
len = min_t(size_t, count, pipe->length - head);
if (len)