From f782f43aabb135ce29a528514697d1da4b3c7726 Mon Sep 17 00:00:00 2001 From: Andrew Wheeler Date: Tue, 3 Mar 2020 10:13:02 -0600 Subject: [PATCH] defconfig.mk: Don't force make defconfig Forcing the re-make of defconfig causes a ton of stuff to get rebuilt during dirty builds. So don't do it. Change-Id: I945fc8bfe3f2a52c3a8069fa016fc6f948f1b30f Signed-off-by: zhaoxp3 Reviewed-on: https://gerrit.mot.com/1529110 SLTApproved: Slta Waiver SME-Granted: SME Approvals Granted Tested-by: Jira Key Reviewed-by: Wang Wang Submit-Approved: Jira Key --- AndroidKernel.mk | 16 ++++++++-------- defconfig.mk | 5 +---- 2 files changed, 9 insertions(+), 12 deletions(-) diff --git a/AndroidKernel.mk b/AndroidKernel.mk index feb08e7a6df1..582d8c453e95 100644 --- a/AndroidKernel.mk +++ b/AndroidKernel.mk @@ -144,11 +144,11 @@ fi endef ifneq ($(KERNEL_LEGACY_DIR),true) -$(KERNEL_USR): $(KERNEL_HEADERS_INSTALL) +$(KERNEL_USR): | $(KERNEL_HEADERS_INSTALL) rm -rf $(KERNEL_SYMLINK) ln -s kernel/$(TARGET_KERNEL) $(KERNEL_SYMLINK) -$(TARGET_PREBUILT_INT_KERNEL): $(KERNEL_USR) +$(TARGET_PREBUILT_INT_KERNEL): | $(KERNEL_USR) endif include $(TARGET_KERNEL_SOURCE)/defconfig.mk @@ -174,7 +174,7 @@ endef $(KERNEL_OUT): mkdir -p $(KERNEL_OUT) -$(KERNEL_CONFIG): $(KERNEL_OUT) $(TARGET_DEFCONFIG) +$(KERNEL_CONFIG): $(TARGET_DEFCONFIG) | $(KERNEL_OUT) $(call do-kernel-config,$(BUILD_ROOT_LOC)$(KERNEL_OUT),$@,$(TARGET_DEFCONFIG),$(TARGET_KERNEL_SOURCE),$(KERNEL_MAKE_ENV),$(KERNEL_ARCH),$(KERNEL_CROSS_COMPILE),$(MAKE),$(real_cc)) $(hide) if [ ! -z "$(KERNEL_CONFIG_OVERRIDE)" ]; then \ echo "Overriding kernel config with '$(KERNEL_CONFIG_OVERRIDE)'"; \ @@ -183,8 +183,8 @@ $(KERNEL_CONFIG): $(KERNEL_OUT) $(TARGET_DEFCONFIG) ifeq ($(TARGET_KERNEL_APPEND_DTB), true) TARGET_PREBUILT_INT_KERNEL_IMAGE := $(KERNEL_OUT)/arch/$(KERNEL_ARCH)/boot/Image -$(TARGET_PREBUILT_INT_KERNEL_IMAGE): $(KERNEL_USR) -$(TARGET_PREBUILT_INT_KERNEL_IMAGE): $(KERNEL_OUT) $(KERNEL_CONFIG) $(KERNEL_HEADERS_INSTALL) +$(TARGET_PREBUILT_INT_KERNEL_IMAGE):| $(KERNEL_USR) +$(TARGET_PREBUILT_INT_KERNEL_IMAGE): | $(KERNEL_OUT) $(KERNEL_CONFIG) $(KERNEL_HEADERS_INSTALL) $(hide) echo "Building kernel modules..." $(MAKE) -C $(TARGET_KERNEL_SOURCE) O=$(BUILD_ROOT_LOC)$(KERNEL_OUT) $(KERNEL_MAKE_ENV) ARCH=$(KERNEL_ARCH) CROSS_COMPILE=$(KERNEL_CROSS_COMPILE) $(real_cc) $(KERNEL_CFLAGS) Image $(MAKE) -C $(TARGET_KERNEL_SOURCE) O=$(BUILD_ROOT_LOC)$(KERNEL_OUT) $(KERNEL_MAKE_ENV) ARCH=$(KERNEL_ARCH) CROSS_COMPILE=$(KERNEL_CROSS_COMPILE) $(real_cc) $(KERNEL_CFLAGS) modules @@ -192,13 +192,13 @@ $(TARGET_PREBUILT_INT_KERNEL_IMAGE): $(KERNEL_OUT) $(KERNEL_CONFIG) $(KERNEL_HEA $(mv-modules) $(clean-module-folder) -$(TARGET_PREBUILT_INT_KERNEL): $(TARGET_PREBUILT_INT_KERNEL_IMAGE) +$(TARGET_PREBUILT_INT_KERNEL): | $(TARGET_PREBUILT_INT_KERNEL_IMAGE) $(hide) echo "Building kernel..." $(hide) rm -rf $(KERNEL_OUT)/arch/$(KERNEL_ARCH)/boot/dts $(MAKE) -C $(TARGET_KERNEL_SOURCE) O=$(BUILD_ROOT_LOC)$(KERNEL_OUT) $(KERNEL_MAKE_ENV) ARCH=$(KERNEL_ARCH) CROSS_COMPILE=$(KERNEL_CROSS_COMPILE) $(real_cc) $(KERNEL_CFLAGS) else TARGET_PREBUILT_INT_KERNEL_IMAGE := $(TARGET_PREBUILT_INT_KERNEL) -$(TARGET_PREBUILT_INT_KERNEL): $(KERNEL_OUT) $(KERNEL_CONFIG) $(KERNEL_HEADERS_INSTALL) +$(TARGET_PREBUILT_INT_KERNEL): | $(KERNEL_OUT) $(KERNEL_CONFIG) $(KERNEL_HEADERS_INSTALL) $(hide) echo "Building kernel..." $(MAKE) -C $(TARGET_KERNEL_SOURCE) O=$(BUILD_ROOT_LOC)$(KERNEL_OUT) $(KERNEL_MAKE_ENV) ARCH=$(KERNEL_ARCH) CROSS_COMPILE=$(KERNEL_CROSS_COMPILE) $(real_cc) $(KERNEL_CFLAGS) $(MAKE) -C $(TARGET_KERNEL_SOURCE) O=$(BUILD_ROOT_LOC)$(KERNEL_OUT) $(KERNEL_MAKE_ENV) ARCH=$(KERNEL_ARCH) CROSS_COMPILE=$(KERNEL_CROSS_COMPILE) $(real_cc) $(KERNEL_CFLAGS) modules @@ -207,7 +207,7 @@ $(TARGET_PREBUILT_INT_KERNEL): $(KERNEL_OUT) $(KERNEL_CONFIG) $(KERNEL_HEADERS_I $(clean-module-folder) endif -$(KERNEL_HEADERS_INSTALL): $(KERNEL_OUT) $(KERNEL_CONFIG) +$(KERNEL_HEADERS_INSTALL): | $(KERNEL_OUT) $(hide) if [ ! -z "$(KERNEL_HEADER_DEFCONFIG)" ]; then \ rm -f $(BUILD_ROOT_LOC)$(KERNEL_CONFIG); \ $(call do-kernel-config,$(BUILD_ROOT_LOC)$(KERNEL_OUT),$(KERNEL_CONFIG),$(KERNEL_HEADER_DEFCONFIG),$(TARGET_KERNEL_SOURCE),$(KERNEL_MAKE_ENV),$(KERNEL_ARCH),$(KERNEL_CROSS_COMPILE),$(MAKE),$(real_cc)); \ diff --git a/defconfig.mk b/defconfig.mk index c84a5745f06b..f4fe5ded02dc 100644 --- a/defconfig.mk +++ b/defconfig.mk @@ -41,8 +41,5 @@ endif # # make combined defconfig file #--------------------------------------- -$(TARGET_DEFCONFIG): FORCE $(PRODUCT_SPECIFIC_DEFCONFIGS) +$(TARGET_DEFCONFIG): $(PRODUCT_SPECIFIC_DEFCONFIGS) $(call do-make-defconfig,$@,$(PRODUCT_SPECIFIC_DEFCONFIGS)) - -.PHONY: FORCE -FORCE: