batman-adv: Return reason for failure in batadv_check_unicast_packet()
batadv_check_unicast_packet() is changed to return a value based on the reason to drop the packet, which will be useful information for future users of batadv_check_unicast_packet(). Signed-off-by: Martin Hundebøll <martin@hundeboll.net> Acked-by: Antonio Quartulli <ordex@autistici.org> Signed-off-by: Marek Lindner <lindner_marek@yahoo.de> Signed-off-by: Antonio Quartulli <ordex@autistici.org>
This commit is contained in:
parent
736292c2e8
commit
f86ce0ad10
1 changed files with 14 additions and 4 deletions
|
@ -548,27 +548,37 @@ batadv_find_ifalter_router(struct batadv_orig_node *primary_orig,
|
||||||
return router;
|
return router;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* batadv_check_unicast_packet - Check for malformed unicast packets
|
||||||
|
* @skb: packet to check
|
||||||
|
* @hdr_size: size of header to pull
|
||||||
|
*
|
||||||
|
* Check for short header and bad addresses in given packet. Returns negative
|
||||||
|
* value when check fails and 0 otherwise. The negative value depends on the
|
||||||
|
* reason: -ENODATA for bad header, -EBADR for broadcast destination or source,
|
||||||
|
* and -EREMOTE for non-local (other host) destination.
|
||||||
|
*/
|
||||||
static int batadv_check_unicast_packet(struct sk_buff *skb, int hdr_size)
|
static int batadv_check_unicast_packet(struct sk_buff *skb, int hdr_size)
|
||||||
{
|
{
|
||||||
struct ethhdr *ethhdr;
|
struct ethhdr *ethhdr;
|
||||||
|
|
||||||
/* drop packet if it has not necessary minimum size */
|
/* drop packet if it has not necessary minimum size */
|
||||||
if (unlikely(!pskb_may_pull(skb, hdr_size)))
|
if (unlikely(!pskb_may_pull(skb, hdr_size)))
|
||||||
return -1;
|
return -ENODATA;
|
||||||
|
|
||||||
ethhdr = (struct ethhdr *)skb_mac_header(skb);
|
ethhdr = (struct ethhdr *)skb_mac_header(skb);
|
||||||
|
|
||||||
/* packet with unicast indication but broadcast recipient */
|
/* packet with unicast indication but broadcast recipient */
|
||||||
if (is_broadcast_ether_addr(ethhdr->h_dest))
|
if (is_broadcast_ether_addr(ethhdr->h_dest))
|
||||||
return -1;
|
return -EBADR;
|
||||||
|
|
||||||
/* packet with broadcast sender address */
|
/* packet with broadcast sender address */
|
||||||
if (is_broadcast_ether_addr(ethhdr->h_source))
|
if (is_broadcast_ether_addr(ethhdr->h_source))
|
||||||
return -1;
|
return -EBADR;
|
||||||
|
|
||||||
/* not for me */
|
/* not for me */
|
||||||
if (!batadv_is_my_mac(ethhdr->h_dest))
|
if (!batadv_is_my_mac(ethhdr->h_dest))
|
||||||
return -1;
|
return -EREMOTE;
|
||||||
|
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue