Theodore Ts'o 22cdfca564 ext4: remove unneeded file_remove_suid() from ext4_ioctl() ... In the code to support EXT4_IOC_MOVE_EXT, ext4_ioctl calls file_remove_suid() after the call to ext4_move_extents() if any extents has been moved. There are at least three things wrong with this. First, file_remove_suid() should be called with i_mutex down, which is not here. Second, it should be called before the donor file has been modified, to avoid a potential race condition. Third, and most importantly, it's pointless, because ext4_file_extents() already checks if the donor file has the setuid or setgid bit set, and will return an error in that case. So the first two objections don't really matter, since file_remove_suid() will never need to modify the inode in any case. Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>		2011-12-21 14:14:31 -05:00
..
acl.c	switch posix_acl_equiv_mode() to umode_t *	2011-08-01 02:10:06 -04:00
acl.h	fs: take the ACL checks to common code	2011-07-25 14:30:23 -04:00
balloc.c	ext4: fix up a undefined error in ext4_free_blocks in debugging code	2011-11-21 12:09:19 -05:00
bitmap.c
block_validity.c	ext4: move ext4_ind_* functions from inode.c to indirect.c	2011-06-27 19:40:50 -04:00
dir.c	ext4: Use ext4_error_file() to print the pathname to the corrupted inode	2011-01-10 12:10:55 -05:00
ext4.h	Merge branch 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4	2011-11-02 10:06:20 -07:00
ext4_extents.h	ext4: Fix bigalloc quota accounting and i_blocks value	2011-09-09 19:04:51 -04:00
ext4_jbd2.c	jbd2: add debugging information to jbd2_journal_dirty_metadata()	2011-09-04 10:18:14 -04:00
ext4_jbd2.h	ext4: Fix ext4_should_writeback_data() for no-journal mode	2011-08-13 11:25:18 -04:00
extents.c	ext4: optimize ext4_find_delalloc_range() in nodelalloc mode	2011-12-18 23:05:43 -05:00
file.c	Merge branch 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4	2011-11-02 10:06:20 -07:00
fsync.c	ext4: optimize locking for end_io extent conversion	2011-10-31 10:56:32 -04:00
hash.c
ialloc.c	ext4: fix error handling on inode bitmap corruption	2011-12-18 17:37:02 -05:00
indirect.c	ext4: enforce bigalloc restrictions (e.g., no online resizing, etc.)	2011-09-09 18:36:51 -04:00
inode.c	ext4: correctly handle pages w/o buffers in ext4_discard_partial_buffers()	2011-12-13 22:05:05 -05:00
ioctl.c	ext4: remove unneeded file_remove_suid() from ext4_ioctl()	2011-12-21 14:14:31 -05:00
Kconfig
Makefile	ext4: move ext4_ind_* functions from inode.c to indirect.c	2011-06-27 19:40:50 -04:00
mballoc.c	ext4: do not reference pa_inode from group_pa	2011-12-18 15:49:54 -05:00
mballoc.h	ext4: fix a typo in struct ext4_allocation_context	2011-10-31 18:55:50 -04:00
migrate.c	Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/hch/vfs-queue	2011-11-02 11:41:01 -07:00
mmp.c	ext4: Fix comparison endianness problem in MMP initialization	2011-10-18 10:53:51 -04:00
move_extent.c	ext4: add some tracepoints in ext4/extents.c	2011-09-09 19:18:51 -04:00
namei.c	Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/hch/vfs-queue	2011-11-02 11:41:01 -07:00
page-io.c	ext4: handle EOF correctly in ext4_bio_write_page()	2011-12-13 22:29:12 -05:00
resize.c	ext4: Rename ext4_free_blks_{count,set}() to refer to clusters	2011-09-09 19:08:51 -04:00
super.c	ext4: add missing space to ext4_msg output in ext4_fill_super()	2011-12-18 16:13:58 -05:00
symlink.c
truncate.h	ext4: move common truncate functions to header file	2011-06-27 19:16:04 -04:00
xattr.c	ext4: fix race in xattr block allocation path	2011-10-29 10:15:35 -04:00
xattr.h	fs/vfs/security: pass last path component to LSM on inode creation	2011-02-01 11:12:29 -05:00
xattr_security.c	security: new security_inode_init_security API adds function callback	2011-07-18 12:29:38 -04:00
xattr_trusted.c	ext4: constify xattr_handler	2010-05-21 18:31:19 -04:00
xattr_user.c	ext4: constify xattr_handler	2010-05-21 18:31:19 -04:00