Zhihao Cheng 2795200724 jbd2: fix potential data lost in recovering journal raced with synchronizing fs bdev ... commit 61187fce8600e8ef90e601be84f9d0f3222c1206 upstream. JBD2 makes sure journal data is fallen on fs device by sync_blockdev(), however, other process could intercept the EIO information from bdev's mapping, which leads journal recovering successful even EIO occurs during data written back to fs device. We found this problem in our product, iscsi + multipath is chosen for block device of ext4. Unstable network may trigger kpartx to rescan partitions in device mapper layer. Detailed process is shown as following: mount kpartx irq jbd2_journal_recover do_one_pass memcpy(nbh->b_data, obh->b_data) // copy data to fs dev from journal mark_buffer_dirty // mark bh dirty vfs_read generic_file_read_iter // dio filemap_write_and_wait_range __filemap_fdatawrite_range do_writepages block_write_full_folio submit_bh_wbc >> EIO occurs in disk << end_buffer_async_write mark_buffer_write_io_error mapping_set_error set_bit(AS_EIO, &mapping->flags) // set! filemap_check_errors test_and_clear_bit(AS_EIO, &mapping->flags) // clear! err2 = sync_blockdev filemap_write_and_wait filemap_check_errors test_and_clear_bit(AS_EIO, &mapping->flags) // false err2 = 0 Filesystem is mounted successfully even data from journal is failed written into disk, and ext4/ocfs2 could become corrupted. Fix it by comparing the wb_err state in fs block device before recovering and after recovering. A reproducer can be found in the kernel bugzilla referenced below. Link: https://bugzilla.kernel.org/show_bug.cgi?id=217888 Cc: stable@vger.kernel.org Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com> Signed-off-by: Zhang Yi <yi.zhang@huawei.com> Reviewed-by: Jan Kara <jack@suse.cz> Link: https://lore.kernel.org/r/20230919012525.1783108-1-chengzhihao1@huawei.com Signed-off-by: Theodore Ts'o <tytso@mit.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2023-11-28 16:46:35 +00:00
..
9p	9p: missing chunk of "fs/9p: Don't update file type when updating file attributes"	2022-06-25 11:48:57 +02:00
adfs
affs	affs: initialize fsdata in affs_truncate()	2023-02-06 07:49:38 +01:00
afs	treewide: Remove uninitialized_var() usage	2023-08-11 11:45:01 +02:00
autofs	autofs: fix memory leak of waitqueues in autofs_catatonic_mode	2023-09-23 10:48:15 +02:00
befs
bfs
btrfs	btrfs: use u64 for buffer sizes in the tree search ioctls	2023-11-20 10:29:22 +01:00
cachefiles	cachefiles: Handle readpage error correctly	2020-11-05 11:08:54 +01:00
ceph	ceph: fix incorrect revoked caps assert in ceph_fill_file_size()	2023-10-25 11:16:31 +02:00
cifs	cifs: spnego: add ';' in HOST_KEY_LEN	2023-11-28 16:46:33 +00:00
coda
configfs	configfs: fix a race in configfs_{,un}register_subsystem()	2022-03-02 11:38:13 +01:00
cramfs
crypto	fscrypt: add fscrypt_symlink_getattr() for computing st_size	2021-09-22 11:47:56 +02:00
debugfs	new helper: lookup_positive_unlocked()	2023-09-23 10:47:59 +02:00
devpts
dlm	dlm: fix plock lookup when using multiple lockspaces	2023-09-23 10:48:11 +02:00
ecryptfs	Revert "ecryptfs: replace BUG_ON with error handling code"	2021-05-26 11:48:34 +02:00
efivarfs	efivarfs: revert "fix memory leak in efivarfs_create()"	2020-12-02 08:48:12 +01:00
efs
exofs
exportfs
ext2	ext2: fix datatype of block number in ext2_xattr_set2()	2023-09-23 10:48:16 +02:00
ext4	ext4: move 'ix' sanity check to corrent position	2023-11-20 10:29:19 +01:00
f2fs	f2fs: fix to initialize map.m_pblk in f2fs_precache_extents()	2023-11-20 10:29:20 +01:00
fat	treewide: Remove uninitialized_var() usage	2023-08-11 11:45:01 +02:00
freevxfs
fscache	fscache: Fix cookie key hashing	2021-09-22 11:48:02 +02:00
fuse	fuse: revalidate: don't invalidate if interrupted	2023-08-11 11:45:24 +02:00
gfs2	gfs2: ignore negated quota changes	2023-11-28 16:46:32 +00:00
hfs	hfs: fix missing hfs_bnode_get() in __hfs_bnode_create	2023-03-11 16:31:49 +01:00
hfsplus	treewide: Remove uninitialized_var() usage	2023-08-11 11:45:01 +02:00
hostfs
hpfs
hugetlbfs	hugetlbfs: hugetlb_fault_mutex_hash() cleanup	2021-06-03 08:38:12 +02:00
isofs	treewide: Remove uninitialized_var() usage	2023-08-11 11:45:01 +02:00
jbd2	jbd2: fix potential data lost in recovering journal raced with synchronizing fs bdev	2023-11-28 16:46:35 +00:00
jffs2	jffs2: reduce stack usage in jffs2_build_xattr_subsystem()	2023-08-11 11:45:15 +02:00
jfs	jfs: fix array-index-out-of-bounds in diAlloc	2023-11-28 16:46:32 +00:00
kernfs	new helper: lookup_positive_unlocked()	2023-09-23 10:47:59 +02:00
lockd	fs: lockd: avoid possible wrong NULL parameter	2023-09-23 10:48:06 +02:00
minix	minix: fix bug when opening a file with O_DIRECT	2022-04-15 14:15:03 +02:00
nfs	NFSv4.1: fix SP4_MACH_CRED protection for pnfs IO	2023-11-28 16:46:33 +00:00
nfs_common	nfs_common: need lock during iterate through the list	2020-12-30 11:26:02 +01:00
nfsd	nfsd: lock_rename() needs both directories to live on the same fs	2023-11-08 11:22:18 +01:00
nilfs2	nilfs2: fix potential use after free in nilfs_gccache_submit_read_data()	2023-10-10 21:44:59 +02:00
nls	fs/nls: make load_nls() take a const parameter	2023-09-23 10:47:58 +02:00
notify	fsnotify: fix wrong lockdep annotations	2022-06-14 16:59:20 +02:00
ntfs	ntfs: check overflow when iterating ATTR_RECORDs	2022-11-25 17:40:30 +01:00
ocfs2	fs: ocfs2: namei: check return value of ocfs2_add_entry()	2023-09-23 10:48:01 +02:00
omfs	treewide: Remove uninitialized_var() usage	2023-08-11 11:45:01 +02:00
openpromfs
orangefs	orangefs: Fix kmemleak in orangefs_prepare_debugfs_help_string()	2023-01-18 11:30:37 +01:00
overlayfs	overlayfs: set ctime when setting mtime and atime	2023-10-25 11:16:53 +02:00
proc	procfs: block chmod on /proc/thread-self/comm	2023-09-23 10:48:11 +02:00
pstore	pstore/ram: Check start of empty przs during init	2023-09-23 10:48:11 +02:00
qnx4	qnx4: work around gcc false positive warning bug	2021-10-06 15:31:20 +02:00
qnx6
quota	quota: Fix slow quotaoff	2023-10-25 11:16:20 +02:00
ramfs	ramfs: fix nommu mmap with gaps in the page cache	2020-10-30 10:38:21 +01:00
reiserfs	reiserfs: Check the return value from __getblk()	2023-09-23 10:47:59 +02:00
romfs	romfs: fix uninitialized memory leak in romfs_dev_read()	2020-08-26 10:30:59 +02:00
squashfs	revert "squashfs: harden sanity check in squashfs_read_xattr_id_table"	2023-02-22 12:47:20 +01:00
sysfs	fs: sysfs_emit_at: Remove PAGE_SIZE alignment check	2023-03-22 13:27:08 +01:00
sysv	fs/sysv: Null check to prevent null-ptr-deref bug	2023-08-11 11:45:39 +02:00
tracefs	tracefs: Only clobber mode/uid/gid on remount if asked	2022-09-20 12:26:48 +02:00
ubifs	treewide: Remove uninitialized_var() usage	2023-08-11 11:45:01 +02:00
udf	udf: initialize newblock to 0	2023-09-23 10:48:12 +02:00
ufs	fs/ufs: avoid potential u32 multiplication overflow	2020-08-21 11:05:38 +02:00
xfs	treewide: Remove uninitialized_var() usage	2023-08-11 11:45:01 +02:00
aio.c	aio: fix mremap after fork null-deref	2023-02-22 12:47:19 +01:00
anon_inodes.c
attr.c	attr: block mode changes of symlinks	2023-09-23 10:48:17 +02:00
bad_inode.c
binfmt_aout.c	binfmt: Move install_exec_creds after setup_new_exec to match binfmt_elf	2023-01-18 11:30:42 +01:00
binfmt_elf.c	elf: don't use MAP_FIXED_NOREPLACE for elf interpreter mappings	2021-10-06 15:31:24 +02:00
binfmt_elf_fdpic.c	fs: binfmt_elf_efpic: fix personality for ELF-FDPIC	2023-10-10 21:45:00 +02:00
binfmt_em86.c
binfmt_flat.c	binfmt: Move install_exec_creds after setup_new_exec to match binfmt_elf	2023-01-18 11:30:42 +01:00
binfmt_misc.c	binfmt_misc: fix shift-out-of-bounds in check_special_flags	2023-01-18 11:30:33 +01:00
binfmt_script.c
block_dev.c	block: reexpand iov_iter after read/write	2021-05-22 10:59:49 +02:00
buffer.c	mm: fs: initialize fsdata passed to write_begin/write_end interface	2022-11-25 17:40:29 +01:00
char_dev.c	chardev: fix error handling in cdev_device_add()	2023-01-18 11:30:27 +01:00
compat.c
compat_binfmt_elf.c
compat_ioctl.c
coredump.c	coredump: fix crash when umh is disabled	2020-05-14 07:57:21 +02:00
d_path.c
dax.c	dax: fix cache flush on PMD-mapped pages	2022-06-14 16:59:24 +02:00
dcache.c	fs, fscrypt: clear DCACHE_ENCRYPTED_NAME when unaliasing directory	2020-11-05 11:08:35 +01:00
dcookies.c
direct-io.c	fs: direct-io: fix missing sdio->boundary	2021-04-14 08:22:32 +02:00
drop_caches.c
eventfd.c	eventfd: prevent underflow for eventfd semaphores	2023-09-23 10:47:59 +02:00
eventpoll.c	ep_create_wakeup_source(): dentry name can change under you...	2020-10-07 08:00:09 +02:00
exec.c	exec: Force single empty string when argv is empty	2022-06-06 08:24:21 +02:00
fcntl.c	fcntl: fix potential deadlock for &fasync_struct.fa_lock	2021-09-22 11:47:50 +02:00
fhandle.c
file.c	fs: prevent out-of-bounds array speculation when closing a file descriptor	2023-03-17 08:31:41 +01:00
file_table.c	fs: add fget_many() and fput_many()	2021-12-08 08:50:13 +01:00
filesystems.c	fs/filesystems.c: downgrade user-reachable WARN_ONCE() to pr_warn_once()	2020-04-17 10:48:51 +02:00
fs-writeback.c	writeback: fix call of incorrect macro	2023-05-17 11:13:23 +02:00
fs_pin.c
fs_struct.c
inode.c	fs: fix UAF/GPF bug in nilfs_mdt_destroy	2022-10-26 13:19:16 +02:00
internal.h
ioctl.c
iomap.c	iomap: fix sub-page uptodate handling	2021-05-22 10:59:50 +02:00
Kconfig
Kconfig.binfmt
libfs.c	libfs: add DEFINE_SIMPLE_ATTRIBUTE_SIGNED for signed value	2023-01-18 11:30:06 +01:00
locks.c
Makefile
mbcache.c	mbcache: Avoid nesting of cache->c_list_lock under bit locks	2023-01-18 11:30:51 +01:00
mount.h
mpage.c
namei.c	fs: Fix error checking for d_hash_and_lookup()	2023-09-23 10:47:59 +02:00
namespace.c	VFS: Fix memory leak caused by concurrently mounting fs with subtype	2022-05-15 19:41:59 +02:00
no-block.c
nsfs.c
open.c	cifs_atomic_open(): fix double-put on late allocation failure	2020-03-18 07:14:21 +01:00
pipe.c	pipe: increase minimum default pipe size to 2 pages	2021-08-12 13:19:43 +02:00
pnode.c	pnode: terminate at peers of source	2023-01-18 11:30:40 +01:00
pnode.h
posix_acl.c
proc_namespace.c
read_write.c
readdir.c	readdir: make sure to verify directory entry for legacy interfaces too	2021-04-28 13:16:50 +02:00
select.c	select: Fix indefinitely sleeping task in poll_schedule_timeout()	2022-01-29 10:19:18 +01:00
seq_file.c	seq_file: disallow extremely large seq buffer allocations	2021-07-20 16:16:16 +02:00
signalfd.c	signalfd: use wake_up_pollfree()	2021-12-14 10:18:07 +01:00
splice.c	Revert "fs: check FMODE_LSEEK to control internal pipe splicing"	2022-10-26 13:19:21 +02:00
stack.c
stat.c	stat: fix inconsistency between struct stat and struct compat_stat	2022-04-27 13:39:44 +02:00
statfs.c	statfs: enforce statfs[64] structure initialization	2023-05-30 12:42:11 +01:00
super.c	vfs: make freeze_super abort when sync_filesystem returns error	2022-02-23 11:58:38 +01:00
sync.c
timerfd.c
userfaultfd.c	userfaultfd: prevent concurrent API initialization	2021-09-22 11:48:02 +02:00
utimes.c
xattr.c	fs: don't audit the capability check in simple_xattr_list()	2023-01-18 11:30:04 +01:00