Ido Schimmel 42c8406432 rtnetlink: Reject negative ifindexes in RTM_NEWLINK ... [ Upstream commit 30188bd7838c16a98a520db1fe9df01ffc6ed368 ] Negative ifindexes are illegal, but the kernel does not validate the ifindex in the ancillary header of RTM_NEWLINK messages, resulting in the kernel generating a warning [1] when such an ifindex is specified. Fix by rejecting negative ifindexes. [1] WARNING: CPU: 0 PID: 5031 at net/core/dev.c:9593 dev_index_reserve+0x1a2/0x1c0 net/core/dev.c:9593 [...] Call Trace: <TASK> register_netdevice+0x69a/0x1490 net/core/dev.c:10081 br_dev_newlink+0x27/0x110 net/bridge/br_netlink.c:1552 rtnl_newlink_create net/core/rtnetlink.c:3471 [inline] __rtnl_newlink+0x115e/0x18c0 net/core/rtnetlink.c:3688 rtnl_newlink+0x67/0xa0 net/core/rtnetlink.c:3701 rtnetlink_rcv_msg+0x439/0xd30 net/core/rtnetlink.c:6427 netlink_rcv_skb+0x16b/0x440 net/netlink/af_netlink.c:2545 netlink_unicast_kernel net/netlink/af_netlink.c:1342 [inline] netlink_unicast+0x536/0x810 net/netlink/af_netlink.c:1368 netlink_sendmsg+0x93c/0xe40 net/netlink/af_netlink.c:1910 sock_sendmsg_nosec net/socket.c:728 [inline] sock_sendmsg+0xd9/0x180 net/socket.c:751 ____sys_sendmsg+0x6ac/0x940 net/socket.c:2538 ___sys_sendmsg+0x135/0x1d0 net/socket.c:2592 __sys_sendmsg+0x117/0x1e0 net/socket.c:2621 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd Fixes: 38f7b870d4 ("[RTNETLINK]: Link creation API") Reported-by: syzbot+5ba06978f34abb058571@syzkaller.appspotmail.com Signed-off-by: Ido Schimmel <idosch@nvidia.com> Reviewed-by: Jiri Pirko <jiri@nvidia.com> Reviewed-by: Jakub Kicinski <kuba@kernel.org> Link: https://lore.kernel.org/r/20230823064348.2252280-1-idosch@nvidia.com Signed-off-by: Paolo Abeni <pabeni@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-08-30 16:31:56 +02:00
..
datagram.c	net: datagram: fix data-races in datagram_poll()	2023-05-30 12:42:08 +01:00
dev.c	Remove DECnet support from kernel	2023-06-21 15:39:57 +02:00
dev_addr_lists.c
dev_ioctl.c
devlink.c	devlink: Add missing genlmsg_cancel() in devlink_nl_sb_port_pool_fill()	2020-11-24 13:27:16 +01:00
drop_monitor.c	drop_monitor: fix data-race in dropmon_net_event / trace_napi_poll_hit	2022-02-23 11:58:39 +01:00
dst.c
dst_cache.c
ethtool.c	net/ethtool/ioctl: return -EOPNOTSUPP if we have no phy stats	2023-01-24 07:11:49 +01:00
failover.c
fib_notifier.c
fib_rules.c	fib: Return the correct errno code	2021-06-30 08:48:13 -04:00
filter.c	bpf: Always return target ifindex in bpf_fib_lookup	2023-02-22 12:47:19 +01:00
flow_dissector.c	net/sched: flower: fix parsing of ethertype following VLAN header	2022-04-20 09:12:48 +02:00
gen_estimator.c	net_sched: gen_estimator: support large ewma log	2021-02-07 14:48:37 +01:00
gen_stats.c
gro_cells.c
hwbm.c
link_watch.c
lwt_bpf.c	lwt: Disable BH too in run_lwt_bpf()	2020-12-30 11:26:06 +01:00
lwtunnel.c
Makefile
neighbour.c	neighbour: delete neigh_lookup_nodev as not used	2023-06-21 15:39:59 +02:00
net-procfs.c	net-procfs: show net devices bound packet types	2022-02-08 18:23:09 +01:00
net-sysfs.c	net-sysfs: add check for netdevice being present to speed_show	2022-03-16 13:20:27 +01:00
net-sysfs.h
net-traces.c
net_namespace.c	net: fix UaF in netns ops registration error path	2023-02-06 07:49:42 +01:00
netclassid_cgroup.c	cgroup, netclassid: remove double cond_resched	2020-05-10 10:30:12 +02:00
netevent.c
netpoll.c	net: don't let netpoll invoke NAPI if in xmit context	2023-04-20 12:04:38 +02:00
netprio_cgroup.c	netprio_cgroup: Fix unlimited memory leak of v2 cgroups	2020-05-20 08:18:38 +02:00
page_pool.c
pktgen.c	pktgen: fix misuse of BUG_ON() in pktgen_thread_worker()	2021-03-07 12:18:57 +01:00
ptp_classifier.c
request_sock.c
rtnetlink.c	rtnetlink: Reject negative ifindexes in RTM_NEWLINK	2023-08-30 16:31:56 +02:00
scm.c
secure_seq.c	secure_seq: use the 64 bits of the siphash for port offset calculation	2022-06-06 08:24:20 +02:00
skbuff.c	net: fix skb leak in __skb_tstamp_tx()	2023-05-30 12:42:14 +01:00
sock.c	sock: Fix misuse of sk_under_memory_pressure()	2023-08-30 16:31:49 +02:00
sock_diag.c
sock_reuseport.c	udp: Prevent reuseport_select_sock from reading uninitialized socks	2021-01-23 15:49:55 +01:00
stream.c	tcp: reduce POLLOUT events caused by TCP_NOTSENT_LOWAT	2023-05-30 12:42:07 +01:00
sysctl_net_core.c	net: Fix data-races around weight_p and dev_weight_[rt]x_bias.	2022-09-05 10:26:30 +02:00
timestamping.c
tso.c
utils.c	net: Fix skb->csum update in inet_proto_csum_replace16().	2020-02-05 14:43:53 +00:00
xdp.c