Lukas Czerner 47788043e5 ext4: handle read only external journal device ... [ Upstream commit 273108fa5015eeffc4bacfa5ce272af3434b96e4 ] Ext4 uses blkdev_get_by_dev() to get the block_device for journal device which does check to see if the read-only block device was opened read-only. As a result ext4 will hapily proceed mounting the file system with external journal on read-only device. This is bad as we would not be able to use the journal leading to errors later on. Instead of simply failing to mount file system in this case, treat it in a similar way we treat internal journal on read-only device. Allow to mount with -o noload in read-only mode. This can be reproduced easily like this: mke2fs -F -O journal_dev $JOURNAL_DEV 100M mkfs.$FSTYPE -F -J device=$JOURNAL_DEV $FS_DEV blockdev --setro $JOURNAL_DEV mount $FS_DEV $MNT touch $MNT/file umount $MNT leading to error like this [ 1307.318713] ------------[ cut here ]------------ [ 1307.323362] generic_make_request: Trying to write to read-only block-device dm-2 (partno 0) [ 1307.331741] WARNING: CPU: 36 PID: 3224 at block/blk-core.c:855 generic_make_request_checks+0x2c3/0x580 [ 1307.341041] Modules linked in: ext4 mbcache jbd2 rfkill intel_rapl_msr intel_rapl_common isst_if_commd [ 1307.419445] CPU: 36 PID: 3224 Comm: jbd2/dm-2 Tainted: G W I 5.8.0-rc5 #2 [ 1307.427359] Hardware name: Dell Inc. PowerEdge R740/01KPX8, BIOS 2.3.10 08/15/2019 [ 1307.434932] RIP: 0010:generic_make_request_checks+0x2c3/0x580 [ 1307.440676] Code: 94 03 00 00 48 89 df 48 8d 74 24 08 c6 05 cf 2b 18 01 01 e8 7f a4 ff ff 48 c7 c7 50e [ 1307.459420] RSP: 0018:ffffc0d70eb5fb48 EFLAGS: 00010286 [ 1307.464646] RAX: 0000000000000000 RBX: ffff9b33b2978300 RCX: 0000000000000000 [ 1307.471780] RDX: ffff9b33e12a81e0 RSI: ffff9b33e1298000 RDI: ffff9b33e1298000 [ 1307.478913] RBP: ffff9b7b9679e0c0 R08: 0000000000000837 R09: 0000000000000024 [ 1307.486044] R10: 0000000000000000 R11: ffffc0d70eb5f9f0 R12: 0000000000000400 [ 1307.493177] R13: 0000000000000000 R14: 0000000000000001 R15: 0000000000000000 [ 1307.500308] FS: 0000000000000000(0000) GS:ffff9b33e1280000(0000) knlGS:0000000000000000 [ 1307.508396] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 1307.514142] CR2: 000055eaf4109000 CR3: 0000003dee40a006 CR4: 00000000007606e0 [ 1307.521273] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 1307.528407] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 1307.535538] PKRU: 55555554 [ 1307.538250] Call Trace: [ 1307.540708] generic_make_request+0x30/0x340 [ 1307.544985] submit_bio+0x43/0x190 [ 1307.548393] ? bio_add_page+0x62/0x90 [ 1307.552068] submit_bh_wbc+0x16a/0x190 [ 1307.555833] jbd2_write_superblock+0xec/0x200 [jbd2] [ 1307.560803] jbd2_journal_update_sb_log_tail+0x65/0xc0 [jbd2] [ 1307.566557] jbd2_journal_commit_transaction+0x2ae/0x1860 [jbd2] [ 1307.572566] ? check_preempt_curr+0x7a/0x90 [ 1307.576756] ? update_curr+0xe1/0x1d0 [ 1307.580421] ? account_entity_dequeue+0x7b/0xb0 [ 1307.584955] ? newidle_balance+0x231/0x3d0 [ 1307.589056] ? __switch_to_asm+0x42/0x70 [ 1307.592986] ? __switch_to_asm+0x36/0x70 [ 1307.596918] ? lock_timer_base+0x67/0x80 [ 1307.600851] kjournald2+0xbd/0x270 [jbd2] [ 1307.604873] ? finish_wait+0x80/0x80 [ 1307.608460] ? commit_timeout+0x10/0x10 [jbd2] [ 1307.612915] kthread+0x114/0x130 [ 1307.616152] ? kthread_park+0x80/0x80 [ 1307.619816] ret_from_fork+0x22/0x30 [ 1307.623400] ---[ end trace 27490236265b1630 ]--- Signed-off-by: Lukas Czerner <lczerner@redhat.com> Reviewed-by: Andreas Dilger <adilger@dilger.ca> Link: https://lore.kernel.org/r/20200717090605.2612-1-lczerner@redhat.com Signed-off-by: Theodore Ts'o <tytso@mit.edu> Signed-off-by: Sasha Levin <sashal@kernel.org>		2020-09-03 11:24:24 +02:00
..
9p	9p: Fix memory leak in v9fs_mount	2020-08-19 08:15:06 +02:00
adfs	fs/adfs: super: fix use-after-free bug	2019-08-06 19:06:49 +02:00
affs	affs: fix a memory leak in affs_remount	2020-01-27 14:51:21 +01:00
afs	afs: Fix NULL deref in afs_dynroot_depopulate()	2020-08-26 10:31:05 +02:00
autofs	autofs: fix a leak in autofs_expire_indirect()	2019-12-13 08:51:01 +01:00
befs
bfs	bfs: add sanity check at bfs_fill_super()	2018-12-01 09:37:27 +01:00
btrfs	btrfs: file: reserve qgroup space after the hole punch range is locked	2020-09-03 11:24:22 +02:00
cachefiles	cachefiles: Fix race between read_waiter and read_copier involving op->to_do	2020-06-03 08:19:29 +02:00
ceph	ceph: fix potential mdsc use-after-free crash	2020-09-03 11:24:22 +02:00
cifs	cifs: Fix leak when handling lease break for cached root fid	2020-08-21 11:05:31 +02:00
coda	coda: add error handling for fget	2019-08-06 19:06:51 +02:00
configfs	configfs: fix config_item refcnt leak in configfs_rmdir()	2020-05-27 17:37:32 +02:00
cramfs	Cramfs: fix abad comparison when wrap-arounds occur	2018-11-13 11:08:55 -08:00
crypto	fscrypt: clean up some BUG_ON()s in block encryption/decryption	2019-07-26 09:14:02 +02:00
debugfs	debugfs: fix use-after-free on symlink traversal	2019-05-08 07:21:48 +02:00
devpts	fs/devpts: always delete dcache dentry-s in dput()	2019-03-23 20:09:59 +01:00
dlm	dlm: Fix kobject memleak	2020-08-19 08:15:02 +02:00
ecryptfs	ecryptfs: replace BUG_ON with error handling code	2020-02-28 16:38:59 +01:00
efivarfs
efs
exofs	exofs_mount(): fix leaks on failure exits	2019-12-05 09:20:32 +01:00
exportfs	exportfs: fix 'passing zero to ERR_PTR()' warning	2020-01-27 14:50:02 +01:00
ext2	ext2: fix missing percpu_counter_inc	2020-08-21 11:05:32 +02:00
ext4	ext4: handle read only external journal device	2020-09-03 11:24:24 +02:00
f2fs	f2fs: fix use-after-free issue	2020-09-03 11:24:21 +02:00
fat	fat: don't allow to mount if the FAT length == 0	2020-06-22 09:05:08 +02:00
freevxfs
fscache	fscache: fix race between enablement and dropping of object	2018-12-17 09:24:40 +01:00
fuse	fuse: fix weird page warning	2020-07-29 10:16:46 +02:00
gfs2	gfs2: read-only mounts should grab the sd_freeze_gl glock	2020-07-22 09:32:01 +02:00
hfs	fs/hfs/extent.c: fix array out of bounds read of array extent	2019-12-01 09:17:10 +01:00
hfsplus	hfsplus: fix crash and filesystem corruption when deleting files	2020-04-17 10:48:52 +02:00
hostfs	vfs: discard ATTR_ATTR_FLAG	2018-08-17 16:20:28 -07:00
hpfs	hpfs: remove unnecessary checks on the value of r when assigning error code	2018-08-25 12:42:33 -07:00
hugetlbfs	hugetlb: use same fault hash key for shared and private mappings	2019-05-22 07:37:40 +02:00
isofs	isofs: reject hardware sector size > 2048 bytes	2018-08-21 11:37:41 +02:00
jbd2	jbd2: make sure jh have b_transaction set in refile/unfile_buffer	2020-09-03 11:24:23 +02:00
jffs2	jffs2: fix UAF problem	2020-08-26 10:31:01 +02:00
jfs	jfs: fix bogus variable self-initialization	2020-01-27 14:50:33 +01:00
kernfs	kernfs: fix ino wrap-around detection	2019-12-13 08:52:43 +01:00
lockd	lockd: fix decoding of TEST results	2019-12-13 08:51:59 +01:00
minix	fs/minix: remove expected error message in block_to_path()	2020-08-21 11:05:38 +02:00
nfs	nfs: Fix getxattr kernel panic and memory overflow	2020-08-21 11:05:38 +02:00
nfs_common
nfsd	nfsd: apply umask on fs without ACL support	2020-07-09 09:37:11 +02:00
nilfs2	nilfs2: fix null pointer dereference at nilfs_segctor_do_construct()	2020-06-22 09:05:03 +02:00
nls
notify	fanotify: fix ignore mask logic for events on child and on dir	2020-06-30 23:17:00 -04:00
ntfs	ntfs: mft: remove VLA usage	2018-08-17 16:20:27 -07:00
ocfs2	ocfs2: change slot number type s16 to u16	2020-08-21 11:05:33 +02:00
omfs
openpromfs
orangefs	help_next should increase position index	2020-02-24 08:34:53 +01:00
overlayfs	ovl: fix unneeded call to ovl_change_flags()	2020-07-22 09:32:10 +02:00
proc	proc: Use new_inode not new_inode_pseudo	2020-06-22 09:05:06 +02:00
pstore	pstore: Fix linking when crypto API disabled	2020-08-19 08:15:04 +02:00
qnx4
qnx6
quota	fs: avoid softlockups in s_inodes iterators	2020-01-12 12:17:20 +01:00
ramfs
reiserfs	reiserfs: prevent NULL pointer dereference in reiserfs_insert_item()	2020-02-24 08:34:52 +01:00
romfs	romfs: fix uninitialized memory leak in romfs_dev_read()	2020-08-26 10:30:59 +02:00
squashfs
sysfs	Driver core patches for 4.19-rc1	2018-08-18 11:44:53 -07:00
sysv	sysv: return 'err' instead of 0 in __sysv_write_inode	2018-12-17 09:24:30 +01:00
tracefs
ubifs	ubifs: remove broken lazytime support	2020-05-27 17:37:30 +02:00
udf	udf: Fix free space reporting for metadata and virtual partitions	2020-02-24 08:34:45 +01:00
ufs	fs/ufs: avoid potential u32 multiplication overflow	2020-08-21 11:05:38 +02:00
xfs	xfs: Don't allow logging of XFS_ISTALE inodes	2020-09-03 11:24:20 +02:00
aio.c	aio: fix async fsync creds	2020-06-22 09:05:01 +02:00
anon_inodes.c
attr.c
bad_inode.c
binfmt_aout.c
binfmt_elf.c	fs/binfmt_elf.c: allocate initialized memory in fill_thread_core_info()	2020-06-03 08:19:41 +02:00
binfmt_elf_fdpic.c
binfmt_em86.c
binfmt_flat.c	fs/binfmt_flat.c: make load_flat_shared_library() work	2019-07-03 13:14:44 +02:00
binfmt_misc.c
binfmt_script.c	exec: load_script: Do not exec truncated interpreter path	2019-11-06 13:05:37 +01:00
block_dev.c	block: Fix use-after-free in blkdev_get()	2020-06-25 15:33:06 +02:00
buffer.c	ext4: use non-movable memory for superblock readahead	2020-04-23 10:30:12 +02:00
char_dev.c	chardev: Avoid potential use-after-free in 'chrdev_open()'	2020-01-14 20:06:57 +01:00
compat.c
compat_binfmt_elf.c
compat_ioctl.c	fix compat handling of FICLONERANGE, FIDEDUPERANGE and FS_IOC_FIEMAP	2020-01-09 10:19:07 +01:00
coredump.c	coredump: fix crash when umh is disabled	2020-05-14 07:57:21 +02:00
d_path.c
dax.c	dax: pass NOWAIT flag to iomap_apply	2020-03-05 16:42:12 +01:00
dcache.c	dcache: sort the freeing-without-RCU-delay mess for good.	2019-05-25 18:23:26 +02:00
dcookies.c
direct-io.c	direct-io: allow direct writes to empty inodes	2019-03-05 17:58:50 +01:00
drop_caches.c	fs: avoid softlockups in s_inodes iterators	2020-01-12 12:17:20 +01:00
eventfd.c	eventfd: track eventfd_signal() recursion depth	2020-02-11 04:34:08 -08:00
eventpoll.c	do_epoll_ctl(): clean the failure exits up a bit	2020-08-26 10:31:06 +02:00
exec.c	exec: Move would_dump into flush_old_exec	2020-05-20 08:18:50 +02:00
fcntl.c	signal: Don't send signals to tasks that don't exist	2018-08-15 23:03:20 -05:00
fhandle.c
file.c	fix multiplication overflow in copy_fdtable()	2020-05-27 17:37:29 +02:00
file_table.c	overlayfs update for 4.19	2018-08-21 18:19:09 -07:00
filesystems.c	fs/filesystems.c: downgrade user-reachable WARN_ONCE() to pr_warn_once()	2020-04-17 10:48:51 +02:00
fs-writeback.c	cgroup, blkcg: Prepare some symbols for module and !CONFIG_CGROUP usages	2020-06-22 09:05:03 +02:00
fs_pin.c
fs_struct.c
inode.c	futex: Fix inode life-time issue	2020-03-25 08:06:14 +01:00
internal.h	acct_on(): don't mess with freeze protection	2019-05-31 06:46:05 -07:00
ioctl.c	vfs: fix FIGETBSZ ioctl on an overlayfs file	2018-11-21 09:19:14 +01:00
iomap.c	iomap: partially revert 4721a601099 (simulated directio short read on EFAULT)	2019-12-13 08:52:56 +01:00
Kconfig
Kconfig.binfmt
libfs.c	libfs: fix infoleak in simple_attr_read()	2020-04-02 15:28:21 +02:00
locks.c	locks: print unsigned ino in /proc/locks	2020-01-09 10:19:00 +01:00
Makefile
mbcache.c
mount.h
mpage.c	mpage: mpage_readpages() should submit IO as read-ahead	2018-08-17 16:20:29 -07:00
namei.c	namei: only return -ECHILD from follow_dotdot_rcu()	2020-03-05 16:42:20 +01:00
namespace.c	fs/namespace.c: fix mountpoint reference counter race	2020-04-29 16:31:26 +02:00
no-block.c
nsfs.c	dcache: sort the freeing-without-RCU-delay mess for good.	2019-05-25 18:23:26 +02:00
open.c	cifs_atomic_open(): fix double-put on late allocation failure	2020-03-18 07:14:21 +01:00
pipe.c	fs: prevent page refcount overflow in pipe_buf_get	2019-05-04 09:20:11 +02:00
pnode.c	propagate_one(): mnt_set_mountpoint() needs mount_lock	2020-05-02 17:26:01 +02:00
pnode.h
posix_acl.c
proc_namespace.c
read_write.c	vfs: avoid problematic remapping requests into partial EOF block	2019-12-01 09:17:04 +01:00
readdir.c	filldir[64]: remove WARN_ON_ONCE() for bad directory entries	2020-01-04 19:13:26 +01:00
select.c
seq_file.c	seq_file: fix problem when seeking mid-record	2019-08-25 10:47:43 +02:00
signalfd.c	fs/signalfd.c: fix inconsistent return codes for signalfd4	2020-08-26 10:31:02 +02:00
splice.c	splice: only read in as much information as there is pipe buffer space	2019-12-17 20:35:43 +01:00
stack.c
stat.c
statfs.c	vfs: Fix EOVERFLOW testing in put_compat_statfs64	2019-10-11 18:21:39 +02:00
super.c	Merge branch 'ida-4.19' of git://git.infradead.org/users/willy/linux-dax	2018-08-26 11:48:42 -07:00
sync.c
timerfd.c	Merge branch 'work.aio' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2018-08-13 20:56:23 -07:00
userfaultfd.c	userfaultfd: require CAP_SYS_PTRACE for UFFD_FEATURE_EVENT_FORK	2020-01-04 19:13:18 +01:00
utimes.c
xattr.c	xattr: break delegations in {set,remove}xattr	2020-08-11 15:32:34 +02:00