Dan Williams 5f1a38952b serial/8250_pci: fix suspend/resume vs init/exit quirks ... Commit e86ff4a6 "serial/8250_pci: init-quirk msi support for kt serial controller" introduced a regression in suspend/resume by causing msi's to be enabled twice without an intervening disable. 00:16.3 Serial controller: Intel Corporation Patsburg KT Controller (rev 05) (prog-if 02 [16550]) Subsystem: Intel Corporation Device 7270 Flags: bus master, 66MHz, fast devsel, latency 0, IRQ 72 I/O ports at 4080 [size=8] Memory at d1c30000 (32-bit, non-prefetchable) [size=4K] Capabilities: [c8] Power Management version 3 Capabilities: [d0] MSI: Enable+ Count=1/1 Maskable- 64bit+ Kernel driver in use: serial [ 365.250523] sysfs: cannot create duplicate filename '/devices/pci0000:00/0000:00:16.3/msi_irqs' [ 365.250525] Modules linked in: nls_utf8 ipv6 uinput sg iTCO_wdt iTCO_vendor_support ioatdma dca i2c_i801 i2c_core wmi sd_mod ahci libahci isci libsas libata scsi_transport_sas [last unloaded: scsi_wait_scan] [ 365.250540] Pid: 9030, comm: kworker/u:1 Tainted: G W 3.3.0-isci-3.0.213+ #1 [ 365.250542] Call Trace: [ 365.250545] [<ffffffff8115e955>] ? sysfs_add_one+0x99/0xad [ 365.250548] [<ffffffff8102db8b>] warn_slowpath_common+0x85/0x9e [ 365.250551] [<ffffffff8102dc96>] warn_slowpath_fmt+0x6e/0x70 [ 365.250555] [<ffffffff8115e8fa>] ? sysfs_add_one+0x3e/0xad [ 365.250558] [<ffffffff8115e8b4>] ? sysfs_pathname+0x3c/0x44 [ 365.250561] [<ffffffff8115e8b4>] ? sysfs_pathname+0x3c/0x44 [ 365.250564] [<ffffffff8115e8b4>] ? sysfs_pathname+0x3c/0x44 [ 365.250567] [<ffffffff8115e8b4>] ? sysfs_pathname+0x3c/0x44 [ 365.250570] [<ffffffff8115e955>] sysfs_add_one+0x99/0xad [ 365.250573] [<ffffffff8115f031>] create_dir+0x72/0xa5 [ 365.250577] [<ffffffff8115f194>] sysfs_create_dir+0xa2/0xbe [ 365.250581] [<ffffffff81262463>] kobject_add_internal+0x126/0x1f8 [ 365.250585] [<ffffffff8126255b>] kset_register+0x26/0x3f [ 365.250588] [<ffffffff8126275a>] kset_create_and_add+0x62/0x7c [ 365.250592] [<ffffffff81293619>] populate_msi_sysfs+0x34/0x103 [ 365.250595] [<ffffffff81293e1c>] pci_enable_msi_block+0x1b3/0x216 [ 365.250599] [<ffffffff81303f7c>] try_enable_msi+0x13/0x17 [ 365.250603] [<ffffffff81303fb3>] pciserial_resume_ports+0x21/0x42 [ 365.250607] [<ffffffff81304041>] pciserial_resume_one+0x50/0x57 [ 365.250610] [<ffffffff81283e1a>] pci_legacy_resume+0x38/0x47 [ 365.250613] [<ffffffff81283e7d>] pci_pm_restore+0x54/0x87 [ 365.250616] [<ffffffff81283e29>] ? pci_legacy_resume+0x47/0x47 [ 365.250619] [<ffffffff8131e9e8>] dpm_run_callback+0x48/0x7b [ 365.250623] [<ffffffff8131f39a>] device_resume+0x342/0x394 [ 365.250626] [<ffffffff8131f5b7>] async_resume+0x21/0x49 That patch has since been reverted, but by inspection it seems that pciserial_suspend_ports() should be invoking .exit() quirks to release resources acquired during .init(). Acked-by: Alan Cox <alan@linux.intel.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2012-04-18 16:26:46 -07:00
..
8250	serial/8250_pci: fix suspend/resume vs init/exit quirks	2012-04-18 16:26:46 -07:00
cpm_uart	TTY: serial, fix includes in some drivers	2011-09-22 15:49:26 -07:00
jsm	jsm: Fixed EEH recovery error	2012-01-24 12:55:36 -08:00
21285.c	Disintegrate asm/system.h for ARM	2012-03-28 18:30:01 +01:00
68328serial.c	TTY: 68328serial, use tty_port_block_til_ready	2012-04-09 12:02:45 -07:00
altera_jtaguart.c	Merge branch 'devicetree/next' of git://git.secretlab.ca/git/linux-2.6	2011-10-27 08:35:41 +02:00
altera_uart.c	tty: serial: altera_uart: Check for NULL platform_data in probe.	2012-04-09 10:30:39 -07:00
amba-pl010.c	serial: pl010: Enable module alias autogeneration for AMBA drivers	2011-11-22 10:58:32 +00:00
amba-pl011.c	Merge 3.4-rc3 into tty-next	2012-04-18 15:57:31 -07:00
apbuart.c	apbuart: fix section mismatch warning	2011-12-27 16:33:13 -05:00
apbuart.h
ar933x_uart.c	SERIAL: AR933X: Add driver for the built-in UART of the SoC	2011-12-07 22:02:46 +00:00
atmel_serial.c	tty/serial: atmel_serial: fix RS485 half-duplex problem	2012-04-09 10:30:39 -07:00
bcm63xx_uart.c	serial: bcm63xx_uart: fix irq storm after rx fifo overrun.	2011-06-16 12:01:58 -07:00
bfin_sport_uart.c	serial: bfin-sport-uart: Add tty ASYNC_CTS_FLOW flag to do CTS flow control.	2011-12-09 19:05:33 -08:00
bfin_sport_uart.h	tty: bfin-sport-uart: Rx interrupt is not called always with irq disabled.	2011-12-09 19:05:33 -08:00
bfin_uart.c	serial: bfin-uart: Don't access tty circular buffer in TX DMA interrupt after it is reset.	2012-03-13 14:33:39 -07:00
clps711x.c	tty: remove invalid location line in file header	2011-04-19 16:33:36 -07:00
crisv10.c	TTY: crisv10, initialize tty_port	2012-04-09 11:14:49 -07:00
crisv10.h
dz.c	Remove all #inclusions of asm/system.h	2012-03-28 18:30:03 +01:00
dz.h
efm32-uart.c	serial/efm32: add new driver	2012-01-26 11:29:47 -08:00
icom.c	Remove all #inclusions of asm/system.h	2012-03-28 18:30:03 +01:00
icom.h
ifx6x60.c	TTY: remove re-assignments to tty_driver members	2012-03-08 11:37:58 -08:00
ifx6x60.h	serial: ifx6x60: minor cleanup	2011-02-17 11:16:15 -08:00
imx.c	serial: imx: add clk_prepare/clk_unprepare	2012-02-01 14:29:31 +01:00
ioc3_serial.c	TTY: serial, fix includes in some drivers	2011-09-22 15:49:26 -07:00
ioc4_serial.c	TTY: remove serialP.h inclusion from some files	2012-03-08 11:47:02 -08:00
ip22zilog.c	Fix common misspellings	2011-03-31 11:26:23 -03:00
ip22zilog.h
Kconfig	tty/serial/omap: console can only be built-in	2012-04-09 10:34:16 -07:00
kgdboc.c	tty: Add module.h to drivers/tty users who just expect it there.	2011-10-31 19:31:27 -04:00
lantiq.c	Merge branch 'tty-next' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty	2011-10-26 15:11:09 +02:00
m32r_sio.c	TTY: remove serialP.h inclusion from some files	2012-03-08 11:47:02 -08:00
m32r_sio.h	TTY: serial, include pci.h in m32r_sio	2012-03-08 11:47:02 -08:00
m32r_sio_reg.h	m32r: relocate drivers back out of 8250 dir	2012-02-08 15:04:32 -08:00
Makefile	Merge tag 'tty-3.3-rc3' tty-next	2012-02-10 10:25:27 -08:00
max3100.c	TTY: Remove redundant spi driver bus initialization	2011-11-26 20:19:21 -08:00
max3107.c	TTY: Remove redundant spi driver bus initialization	2011-11-26 20:19:21 -08:00
max3107.h	Fix common misspellings	2011-03-31 11:26:23 -03:00
mcf.c	TTY: irq: Remove IRQF_DISABLED	2011-09-22 16:08:57 -07:00
mfd.c	simple_open: automatically convert to simple_open()	2012-04-05 15:25:50 -07:00
mpc52xx_uart.c	mpc5200b/uart: select more tolerant uart prescaler on low baudrates	2012-03-08 13:15:50 -08:00
mpsc.c
mrst_max3110.c	TTY: Remove redundant spi driver bus initialization	2011-11-26 20:19:21 -08:00
mrst_max3110.h	max3110: add sysrq support	2011-08-26 11:01:15 -07:00
msm_serial.c	Merge branch 'next/dt' of git://git.linaro.org/people/arnd/arm-soc	2011-11-01 21:02:35 -07:00
msm_serial.h	tty: remove invalid location line in file header	2011-04-19 16:33:36 -07:00
msm_serial_hs.c	Remove all #inclusions of asm/system.h	2012-03-28 18:30:03 +01:00
msm_smd_tty.c	TTY: remove re-assignments to tty_driver members	2012-03-08 11:37:58 -08:00
mux.c	tty/serial/mux.c: linux/tty.h included twice	2012-02-24 13:50:45 -08:00
mxs-auart.c	clock management changes for i.MX	2012-01-09 14:44:15 -08:00
netx-serial.c	tty: remove invalid location line in file header	2011-04-19 16:33:36 -07:00
nwpserial.c	tty: Add export.h for EXPORT_SYMBOL/THIS_MODULE to exporters	2011-10-31 19:31:28 -04:00
of_serial.c	tegra, serial8250: add ->handle_break() uart_port op	2012-04-18 15:07:53 -07:00
omap-serial.c	Merge 3.4-rc3 into tty-next	2012-04-18 15:57:31 -07:00
pch_uart.c	Merge 3.4-rc3 into tty-next	2012-04-18 15:57:31 -07:00
pmac_zilog.c	serial: Kill off NO_IRQ	2012-01-26 17:14:50 -08:00
pmac_zilog.h	tty/serial/pmac_zilog: Fix suspend & resume	2011-12-16 11:10:01 +11:00
pnx8xxx_uart.c
pxa.c	ARM: device tree work	2012-03-27 16:47:35 -07:00
sa1100.c	ARM: 7342/2: sa1100: prepare for sparse irq conversion	2012-03-25 23:57:20 +01:00
samsung.c	serial: samsung: fix omission initialize ulcon in reset port fn()	2012-04-09 10:30:39 -07:00
samsung.h	serial: samsung: merge probe() function from all SoC specific extensions	2011-12-23 10:07:00 +09:00
sb1250-duart.c	TTY: serial, fix includes in some drivers	2011-09-22 15:49:26 -07:00
sc26xx.c	TTY: serial: convert drivers/tty/serial/* to use module_platform_driver()	2011-11-30 20:11:46 +09:00
serial_core.c	TTY: remove re-assignments to tty_driver members	2012-03-08 11:37:58 -08:00
serial_ks8695.c	TTY: irq: Remove IRQF_DISABLED	2011-09-22 16:08:57 -07:00
serial_txx9.c	TTY: serial, fix includes in some drivers	2011-09-22 15:49:26 -07:00
sh-sci.c	serial: sh-sci: use serial_port_in/out vs sci_in/out.	2012-03-30 19:50:15 +09:00
sh-sci.h	serial: sh-sci: use serial_port_in/out vs sci_in/out.	2012-03-30 19:50:15 +09:00
sirfsoc_uart.c	pinctrl: API changes to support multiple states per device	2012-03-05 11:22:59 +01:00
sirfsoc_uart.h	serial/sirf: fixup for changes to pin control	2012-02-22 17:59:12 +01:00
sn_console.c	Miscellaneous Itanium patches	2012-03-23 17:19:37 -07:00
suncore.c	tty: sparc: rename drivers/tty/serial/suncore.h -> include/linux/sunserialcore.h	2012-02-10 10:44:35 -08:00
sunhv.c	Disintegrate asm/system.h for Sparc	2012-03-28 18:30:03 +01:00
sunsab.c	Disintegrate asm/system.h for Sparc	2012-03-28 18:30:03 +01:00
sunsab.h
sunsu.c	Disintegrate asm/system.h for Sparc	2012-03-28 18:30:03 +01:00
sunzilog.c	serial/sunzilog: fix keyboard on SUN SPARCstation	2012-04-04 00:37:10 -07:00
sunzilog.h
timbuart.c	TTY: serial: convert drivers/tty/serial/* to use module_platform_driver()	2011-11-30 20:11:46 +09:00
timbuart.h
uartlite.c	Merge branch 'devicetree/next' of git://git.secretlab.ca/git/linux-2.6	2011-10-27 08:35:41 +02:00
ucc_uart.c	serial: Kill off NO_IRQ	2012-01-26 17:14:50 -08:00
vr41xx_siu.c	serial: Kill off NO_IRQ	2012-01-26 17:14:50 -08:00
vt8500_serial.c	tty: serial: vt8500: fix annotations for probe/remove	2012-03-12 10:21:55 -07:00
xilinx_uartps.c	tty: Add module.h to drivers/tty users who just expect it there.	2011-10-31 19:31:27 -04:00
zs.c	Remove all #inclusions of asm/system.h	2012-03-28 18:30:03 +01:00
zs.h