asgardius/android_kernel_motorola_sm6225
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
android_kernel_motorola_sm6225/drivers/scsi/bnx2fc
History
Julia Lawall 5c2dce26fd [SCSI] bnx2fc: introduce missing kfree 
Error handling code following a kmalloc should free the allocated data.

The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,f1,l;
position p1,p2;
expression *ptr != NULL;
@@

x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
<... when != x
     when != if (...) { <+...x...+> }
(
x->f1 = E
|
 (x->f1 == NULL || ...)
|
 f(...,x->f1,...)
)
...>
(
 return \(0\|<+...x...+>\|ptr\);
|
 return@p2 ...;
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Bhanu Prakash Gollapudi <bprakash@broadcom.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2011-05-01 10:18:31 -05:00
..
57xx_hsi_bnx2fc.h Fix common misspellings 2011-03-31 11:26:23 -03:00
bnx2fc.h [SCSI] bnx2fc: Bump version to 1.0.1 2011-03-23 11:37:09 -05:00
bnx2fc_constants.h [SCSI] bnx2fc: Broadcom FCoE offload driver 2011-02-28 18:40:27 -06:00
bnx2fc_debug.h [SCSI] bnx2fc: Broadcom FCoE offload driver 2011-02-28 18:40:27 -06:00
bnx2fc_els.c Fix common misspellings 2011-03-31 11:26:23 -03:00
bnx2fc_fcoe.c [SCSI] bnx2fc: IO completion not processed due to missed wakeup 2011-03-23 12:53:06 -05:00
bnx2fc_hwi.c [SCSI] bnx2fc: introduce missing kfree 2011-05-01 10:18:31 -05:00
bnx2fc_io.c Fix common misspellings 2011-03-31 11:26:23 -03:00
bnx2fc_tgt.c Fix common misspellings 2011-03-31 11:26:23 -03:00
Kconfig [SCSI] bnx2fc: Broadcom FCoE offload driver 2011-02-28 18:40:27 -06:00
Makefile [SCSI] bnx2fc: Broadcom FCoE offload driver 2011-02-28 18:40:27 -06:00