b46b8f19c9
There are two problems with the existing redzone implementation. Firstly, it's causing misalignment of structures which contain a 64-bit integer, such as netfilter's 'struct ipt_entry' -- causing netfilter modules to fail to load because of the misalignment. (In particular, the first check in net/ipv4/netfilter/ip_tables.c::check_entry_size_and_hooks()) On ppc32 and sparc32, amongst others, __alignof__(uint64_t) == 8. With slab debugging, we use 32-bit redzones. And allocated slab objects aren't sufficiently aligned to hold a structure containing a uint64_t. By _just_ setting ARCH_KMALLOC_MINALIGN to __alignof__(u64) we'd disable redzone checks on those architectures. By using 64-bit redzones we avoid that loss of debugging, and also fix the other problem while we're at it. When investigating this, I noticed that on 64-bit platforms we're using a 32-bit value of RED_ACTIVE/RED_INACTIVE in the 64-bit memory location set aside for the redzone. Which means that the four bytes immediately before or after the allocated object at 0x00,0x00,0x00,0x00 for LE and BE machines, respectively. Which is probably not the most useful choice of poison value. One way to fix both of those at once is just to switch to 64-bit redzones in all cases. Signed-off-by: David Woodhouse <dwmw2@infradead.org> Acked-by: Pekka Enberg <penberg@cs.helsinki.fi> Cc: Christoph Lameter <clameter@engr.sgi.com> Acked-by: David S. Miller <davem@davemloft.net> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
63 lines
1.8 KiB
C
63 lines
1.8 KiB
C
#ifndef _LINUX_POISON_H
|
|
#define _LINUX_POISON_H
|
|
|
|
/********** include/linux/list.h **********/
|
|
/*
|
|
* These are non-NULL pointers that will result in page faults
|
|
* under normal circumstances, used to verify that nobody uses
|
|
* non-initialized list entries.
|
|
*/
|
|
#define LIST_POISON1 ((void *) 0x00100100)
|
|
#define LIST_POISON2 ((void *) 0x00200200)
|
|
|
|
/********** mm/slab.c **********/
|
|
/*
|
|
* Magic nums for obj red zoning.
|
|
* Placed in the first word before and the first word after an obj.
|
|
*/
|
|
#define RED_INACTIVE 0x09F911029D74E35BULL /* when obj is inactive */
|
|
#define RED_ACTIVE 0xD84156C5635688C0ULL /* when obj is active */
|
|
|
|
#define SLUB_RED_INACTIVE 0xbb
|
|
#define SLUB_RED_ACTIVE 0xcc
|
|
|
|
/* ...and for poisoning */
|
|
#define POISON_INUSE 0x5a /* for use-uninitialised poisoning */
|
|
#define POISON_FREE 0x6b /* for use-after-free poisoning */
|
|
#define POISON_END 0xa5 /* end-byte of poisoning */
|
|
|
|
/********** arch/$ARCH/mm/init.c **********/
|
|
#define POISON_FREE_INITMEM 0xcc
|
|
|
|
/********** arch/ia64/hp/common/sba_iommu.c **********/
|
|
/*
|
|
* arch/ia64/hp/common/sba_iommu.c uses a 16-byte poison string with a
|
|
* value of "SBAIOMMU POISON\0" for spill-over poisoning.
|
|
*/
|
|
|
|
/********** fs/jbd/journal.c **********/
|
|
#define JBD_POISON_FREE 0x5b
|
|
|
|
/********** drivers/base/dmapool.c **********/
|
|
#define POOL_POISON_FREED 0xa7 /* !inuse */
|
|
#define POOL_POISON_ALLOCATED 0xa9 /* !initted */
|
|
|
|
/********** drivers/atm/ **********/
|
|
#define ATM_POISON_FREE 0x12
|
|
#define ATM_POISON 0xdeadbeef
|
|
|
|
/********** net/ **********/
|
|
#define NEIGHBOR_DEAD 0xdeadbeef
|
|
#define NETFILTER_LINK_POISON 0xdead57ac
|
|
|
|
/********** kernel/mutexes **********/
|
|
#define MUTEX_DEBUG_INIT 0x11
|
|
#define MUTEX_DEBUG_FREE 0x22
|
|
|
|
/********** security/ **********/
|
|
#define KEY_DESTROY 0xbd
|
|
|
|
/********** sound/oss/ **********/
|
|
#define OSS_POISON_FREE 0xAB
|
|
|
|
#endif
|