android_kernel_motorola_sm6225/drivers/net/usb
Julia Lawall f201a8a451 drivers/net/usb: use USB API functions rather than constants
This set of patches introduces calls to the following set of functions:

usb_endpoint_dir_in(epd)
usb_endpoint_dir_out(epd)
usb_endpoint_is_bulk_in(epd)
usb_endpoint_is_bulk_out(epd)
usb_endpoint_is_int_in(epd)
usb_endpoint_is_int_out(epd)
usb_endpoint_num(epd)
usb_endpoint_type(epd)
usb_endpoint_xfer_bulk(epd)
usb_endpoint_xfer_control(epd)
usb_endpoint_xfer_int(epd)
usb_endpoint_xfer_isoc(epd)

In some cases, introducing one of these functions is not possible, and it
just replaces an explicit integer value by one of the following constants:

USB_ENDPOINT_XFER_BULK
USB_ENDPOINT_XFER_CONTROL
USB_ENDPOINT_XFER_INT
USB_ENDPOINT_XFER_ISOC

In drivers/net/wireless/zd1211rw/zd_usb.c the code:

(endpoint->bEndpointAddress & USB_TYPE_MASK) == USB_DIR_OUT

is suspicious.  If it is intended to use USB_ENDPOINT_DIR_MASK rather than
USB_TYPE_MASK, then the whole conditional test could be converted to a call
to usb_endpoint_is_bulk_in.

An extract of the semantic patch that makes these changes is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r1@ struct usb_endpoint_descriptor *epd; @@

- ((epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\)) ==
- \(USB_ENDPOINT_XFER_CONTROL\|0\))
+ usb_endpoint_xfer_control(epd)

@r5@ struct usb_endpoint_descriptor *epd; @@

- ((epd->bEndpointAddress & \(USB_ENDPOINT_DIR_MASK\|0x80\)) ==
-  \(USB_DIR_IN\|0x80\))
+ usb_endpoint_dir_in(epd)

@inc@
@@

#include <linux/usb.h>

@depends on !inc && (r1||r5)@
@@

+ #include <linux/usb.h>
  #include <linux/usb/...>
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-12-29 19:40:47 -08:00
..
asix.c net: prepare usb net drivers for addition of status as a parameter 2008-12-18 23:00:59 -08:00
catc.c net: prepare usb net drivers for addition of status as a parameter 2008-12-18 23:00:59 -08:00
cdc_ether.c rndis_host: support WM6 devices as modems 2008-07-22 19:45:49 -04:00
cdc_subset.c USB: build fix 2008-05-20 14:14:15 -07:00
dm9601.c net: prepare usb net drivers for addition of status as a parameter 2008-12-18 23:00:59 -08:00
gl620a.c Move usbnet.h and rndis_host.h to include/linux/usb 2008-01-31 19:27:00 -08:00
hso.c drivers/net/usb: use USB API functions rather than constants 2008-12-29 19:40:47 -08:00
kaweth.c net: prepare usb net drivers for addition of status as a parameter 2008-12-18 23:00:59 -08:00
Kconfig net: Add SMSC LAN9500 USB2.0 10/100 ethernet adapter driver 2008-10-08 16:44:18 -07:00
Makefile drivers/net/usb/Makefile - shrink logspam 2008-10-08 17:07:40 -07:00
mcs7830.c net: prepare usb net drivers for addition of status as a parameter 2008-12-18 23:00:59 -08:00
net1080.c Move usbnet.h and rndis_host.h to include/linux/usb 2008-01-31 19:27:00 -08:00
pegasus.c net: prepare usb net drivers for addition of status as a parameter 2008-12-18 23:00:59 -08:00
pegasus.h Move USB network drivers to drivers/net/usb. 2007-05-09 21:31:55 -04:00
plusb.c Move usbnet.h and rndis_host.h to include/linux/usb 2008-01-31 19:27:00 -08:00
rndis_host.c rndis_host: support WM6 devices as modems 2008-07-22 19:45:49 -04:00
rtl8150.c net: prepare usb net drivers for addition of status as a parameter 2008-12-18 23:00:59 -08:00
smsc95xx.c net: prepare usb net drivers for addition of status as a parameter 2008-12-18 23:00:59 -08:00
smsc95xx.h net: Add SMSC LAN9500 USB2.0 10/100 ethernet adapter driver 2008-10-08 16:44:18 -07:00
usbnet.c net: convert print_mac to %pM 2008-10-27 17:06:18 -07:00
zaurus.c Move usbnet.h and rndis_host.h to include/linux/usb 2008-01-31 19:27:00 -08:00