android_kernel_motorola_sm6225/drivers/acpi/namespace
Ingo Molnar 5d0e600d90 [PATCH] x86: fix laptop bootup hang in init_acpi()
During kernel bootup, a new T60 laptop (CoreDuo, 32-bit) hangs about
10%-20% of the time in acpi_init():

 Calling initcall 0xc055ce1a: topology_init+0x0/0x2f()
 Calling initcall 0xc055d75e: mtrr_init_finialize+0x0/0x2c()
 Calling initcall 0xc05664f3: param_sysfs_init+0x0/0x175()
 Calling initcall 0xc014cb65: pm_sysrq_init+0x0/0x17()
 Calling initcall 0xc0569f99: init_bio+0x0/0xf4()
 Calling initcall 0xc056b865: genhd_device_init+0x0/0x50()
 Calling initcall 0xc056c4bd: fbmem_init+0x0/0x87()
 Calling initcall 0xc056dd74: acpi_init+0x0/0x1ee()

It's a hard hang that not even an NMI could punch through!  Frustratingly,
adding printks or function tracing to the ACPI code made the hangs go away
...

After some time an additional detail emerged: disabling the NMI watchdog
made these occasional hangs go away.

So i spent the better part of today trying to debug this and trying out
various theories when i finally found the likely reason for the hang: if
acpi_ns_initialize_devices() executes an _INI AML method and an NMI
happens to hit that AML execution in the wrong moment, the machine would
hang.  (my theory is that this must be some sort of chipset setup method
doing stores to chipset mmio registers?)

Unfortunately given the characteristics of the hang it was sheer
impossible to figure out which of the numerous AML methods is impacted
by this problem.

As a workaround i wrote an interface to disable chipset-based NMIs while
executing _INI sections - and indeed this fixed the hang.  I did a
boot-loop of 100 separate reboots and none hung - while without the patch
it would hang every 5-10 attempts.  Out of caution i did not touch the
nmi_watchdog=2 case (it's not related to the chipset anyway and didnt
hang).

I implemented this for both x86_64 and i686, tested the i686 laptop both
with nmi_watchdog=1 [which triggered the hangs] and nmi_watchdog=2, and
tested an Athlon64 box with the 64-bit kernel as well. Everything builds
and works with the patch applied.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andi Kleen <ak@suse.de>
Cc: Andi Kleen <ak@suse.de>
Cc: Len Brown <lenb@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
2007-02-13 13:26:24 +01:00
..
Makefile Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
nsaccess.c ACPICA: Update copyright to 2007. 2007-02-02 21:14:31 -05:00
nsalloc.c ACPICA: Update copyright to 2007. 2007-02-02 21:14:31 -05:00
nsdump.c ACPICA: Update copyright to 2007. 2007-02-02 21:14:31 -05:00
nsdumpdv.c ACPICA: Update copyright to 2007. 2007-02-02 21:14:31 -05:00
nseval.c ACPICA: Update copyright to 2007. 2007-02-02 21:14:31 -05:00
nsinit.c [PATCH] x86: fix laptop bootup hang in init_acpi() 2007-02-13 13:26:24 +01:00
nsload.c ACPICA: Update copyright to 2007. 2007-02-02 21:14:31 -05:00
nsnames.c ACPICA: Update copyright to 2007. 2007-02-02 21:14:31 -05:00
nsobject.c ACPICA: Update copyright to 2007. 2007-02-02 21:14:31 -05:00
nsparse.c ACPICA: fix gcc build warnings 2007-02-02 23:08:40 -05:00
nssearch.c ACPICA: Update copyright to 2007. 2007-02-02 21:14:31 -05:00
nsutils.c ACPICA: Update copyright to 2007. 2007-02-02 21:14:31 -05:00
nswalk.c ACPICA: Update copyright to 2007. 2007-02-02 21:14:31 -05:00
nsxfeval.c ACPICA: Update copyright to 2007. 2007-02-02 21:14:31 -05:00
nsxfname.c ACPICA: Update copyright to 2007. 2007-02-02 21:14:31 -05:00
nsxfobj.c ACPICA: Update copyright to 2007. 2007-02-02 21:14:31 -05:00