Cong Wang a8a0c32131 kcm: fix strp_init() order and cleanup ... [ Upstream commit 8fc29ff3910f3af08a7c40a75d436b5720efe2bf ] strp_init() is called just a few lines above this csk->sk_user_data check, it also initializes strp->work etc., therefore, it is unnecessary to call strp_done() to cancel the freshly initialized work. And if sk_user_data is already used by KCM, psock->strp should not be touched, particularly strp->work state, so we need to move strp_init() after the csk->sk_user_data check. This also makes a lockdep warning reported by syzbot go away. Reported-and-tested-by: syzbot+9fc084a4348493ef65d2@syzkaller.appspotmail.com Reported-by: syzbot+e696806ef96cdd2d87cd@syzkaller.appspotmail.com Fixes: e557124023 ("kcm: Check if sk_user_data already set in kcm_attach") Fixes: dff8baa261 ("kcm: Call strp_stop before strp_done in kcm_attach") Cc: Tom Herbert <tom@herbertland.com> Signed-off-by: Cong Wang <cong.wang@bytedance.com> Link: https://lore.kernel.org/r/20220827181314.193710-1-xiyou.wangcong@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-09-15 12:17:02 +02:00
..
kcmproc.c	proc: introduce proc_create_net_single	2018-05-16 07:24:30 +02:00
kcmsock.c	kcm: fix strp_init() order and cleanup	2022-09-15 12:17:02 +02:00
Kconfig	net: remove blank lines at end of file	2018-07-24 14:10:43 -07:00
Makefile