Taehee Yoo e117a04133 gtp: fix suspicious RCU usage ... [ Upstream commit e198987e7dd7d3645a53875151cd6f8fc425b706 ] gtp_encap_enable_socket() and gtp_encap_destroy() are not protected by rcu_read_lock(). and it's not safe to write sk->sk_user_data. This patch make these functions to use lock_sock() instead of rcu_dereference_sk_user_data(). Test commands: gtp-link add gtp1 Splat looks like: [ 83.238315] ============================= [ 83.239127] WARNING: suspicious RCU usage [ 83.239702] 5.2.0-rc6+ #49 Not tainted [ 83.240268] ----------------------------- [ 83.241205] drivers/net/gtp.c:799 suspicious rcu_dereference_check() usage! [ 83.243828] [ 83.243828] other info that might help us debug this: [ 83.243828] [ 83.246325] [ 83.246325] rcu_scheduler_active = 2, debug_locks = 1 [ 83.247314] 1 lock held by gtp-link/1008: [ 83.248523] #0: 0000000017772c7f (rtnl_mutex){+.+.}, at: __rtnl_newlink+0x5f5/0x11b0 [ 83.251503] [ 83.251503] stack backtrace: [ 83.252173] CPU: 0 PID: 1008 Comm: gtp-link Not tainted 5.2.0-rc6+ #49 [ 83.253271] Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox 12/01/2006 [ 83.254562] Call Trace: [ 83.254995] dump_stack+0x7c/0xbb [ 83.255567] gtp_encap_enable_socket+0x2df/0x360 [gtp] [ 83.256415] ? gtp_find_dev+0x1a0/0x1a0 [gtp] [ 83.257161] ? memset+0x1f/0x40 [ 83.257843] gtp_newlink+0x90/0xa21 [gtp] [ 83.258497] ? __netlink_ns_capable+0xc3/0xf0 [ 83.259260] __rtnl_newlink+0xb9f/0x11b0 [ 83.260022] ? rtnl_link_unregister+0x230/0x230 [ ... ] Fixes: 1e3a3abd8b ("gtp: make GTP sockets in gtp_newlink optional") Signed-off-by: Taehee Yoo <ap420073@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>		2019-07-26 09:14:17 +02:00
..
appletalk	net/appletalk: fix minor pointer leak to userspace in SIOCFINDIPDDPRT	2018-09-13 10:35:57 -07:00
arcnet
bonding	bonding: validate ip header before check IPPROTO_IGMP	2019-07-26 09:14:15 +02:00
caif
can	can: m_can: implement errata "Needless activation of MRAF irq"	2019-07-14 08:11:07 +02:00
dsa	net: dsa: mv88e6xxx: fix shift of FID bits in mv88e6185_g1_vtu_loadpurge()	2019-07-14 08:11:15 +02:00
ethernet	bnx2x: Prevent ptp_task to be rescheduled indefinitely	2019-07-26 09:14:15 +02:00
fddi
fjes
hamradio	net/hamradio/6pack: use mod_timer() to rearm timers	2019-01-09 17:38:32 +01:00
hippi
hyperv	hv_netvsc: Set probe mode to sync	2019-06-22 08:15:13 +02:00
ieee802154	net: ieee802154: fix missing checks for regmap_update_bits	2019-05-25 18:23:43 +02:00
ipvlan	net: ipvlan: Fix ipvlan device tso disabled while NETIF_F_IP_CSUM is set	2019-06-25 11:35:58 +08:00
netdevsim
phy	net: sfp: add mutex to prevent concurrent state checks	2019-07-26 09:14:05 +02:00
plip
ppp	ppp: mppe: Add softdep to arc4	2019-07-21 09:03:07 +02:00
slip	slip: make slhc_free() silently accept an error pointer	2019-05-02 09:58:56 +02:00
team	team: Always enable vlan tx offload	2019-07-03 13:14:47 +02:00
usb	net: usb: asix: init MAC address buffers	2019-07-26 09:14:15 +02:00
vmxnet3
wan	net/wan: fix a double free in x25_asy_open_tty()	2019-01-09 17:38:32 +01:00
wimax	wimax/i2400m: fix spelling mistake "not unitialized" -> "uninitialized"	2018-09-26 20:09:58 -07:00
wireless	iwlwifi: mvm: Drop large non sta frames	2019-07-26 09:14:14 +02:00
xen-netback	xen-netback: fix occasional leak of grant ref mappings under memory pressure	2019-03-10 07:17:19 +01:00
dummy.c
eql.c
geneve.c	geneve: correctly handle ipv6.disable module parameter	2019-03-10 07:17:17 +01:00
gtp.c	gtp: fix suspicious RCU usage	2019-07-26 09:14:17 +02:00
ifb.c
Kconfig	gtp: change NET_UDP_TUNNEL dependency to select	2019-04-03 06:26:15 +02:00
LICENSE.SRC
loopback.c	net: loopback: clear skb->tstamp before netif_rx()	2018-11-13 11:08:20 -08:00
macsec.c
macvlan.c	macvlan: return correct error value	2018-12-21 14:15:20 +01:00
macvtap.c
Makefile	net: Always descend into dsa/	2019-05-25 18:23:19 +02:00
mdio.c
mii.c
net_failover.c	failover: Add missing check to validate 'slave_dev' in net_failover_slave_unregister	2018-11-13 11:08:28 -08:00
netconsole.c
nlmon.c
ntb_netdev.c
rionet.c	rapidio/rionet: do not free skb before reading its length	2018-12-05 19:31:59 +01:00
sb1000.c
Space.c
sungem_phy.c
tap.c
thunderbolt.c	net: thunderbolt: Unregister ThunderboltIP protocol handler when suspending	2019-06-15 11:54:07 +02:00
tun.c	tun: wake up waitqueues after IFF_UP is set	2019-07-03 13:14:48 +02:00
veth.c	veth: Orphan skb before GRO	2018-09-16 15:33:50 -07:00
virtio_net.c	virtio_net: Account for tx bytes and packets on sending xdp_frames	2019-02-12 19:47:23 +01:00
vrf.c	vrf: prevent adding upper devices	2019-04-03 06:26:18 +02:00
vsockmon.c
vxlan.c	vxlan: Don't call gro_cells_destroy() before device is unregistered	2019-04-03 06:26:18 +02:00
xen-netfront.c	xen/netfront: tolerate frags with no data	2019-01-09 17:38:34 +01:00