f28169d200
I noticed that errors happening while hotplugging devices from the host were never returned back to the mconsole client. In some cases, success was returned instead of even an information-free error. This patch cleans that up by having the low-level configuration code pass back an error string along with an error code. At the top level, which knows whether it is early boot time or responding to an mconsole request, the string is printk'd or returned to the mconsole client. There are also whitespace and trivial code cleanups in the surrounding code. Signed-off-by: Jeff Dike <jdike@addtoit.com> Cc: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
52 lines
962 B
C
52 lines
962 B
C
/*
|
|
* Copyright (C) 2001, 2002 Jeff Dike (jdike@karaya.com)
|
|
* Licensed under the GPL
|
|
*/
|
|
|
|
#ifndef __MCONSOLE_KERN_H__
|
|
#define __MCONSOLE_KERN_H__
|
|
|
|
#include "linux/list.h"
|
|
#include "mconsole.h"
|
|
|
|
struct mconsole_entry {
|
|
struct list_head list;
|
|
struct mc_request request;
|
|
};
|
|
|
|
/* All these methods are called in process context. */
|
|
struct mc_device {
|
|
struct list_head list;
|
|
char *name;
|
|
int (*config)(char *, char **);
|
|
int (*get_config)(char *, char *, int, char **);
|
|
int (*id)(char **, int *, int *);
|
|
int (*remove)(int, char **);
|
|
};
|
|
|
|
#define CONFIG_CHUNK(str, size, current, chunk, end) \
|
|
do { \
|
|
current += strlen(chunk); \
|
|
if(current >= size) \
|
|
str = NULL; \
|
|
if(str != NULL){ \
|
|
strcpy(str, chunk); \
|
|
str += strlen(chunk); \
|
|
} \
|
|
if(end) \
|
|
current++; \
|
|
} while(0)
|
|
|
|
#ifdef CONFIG_MCONSOLE
|
|
|
|
extern void mconsole_register_dev(struct mc_device *new);
|
|
|
|
#else
|
|
|
|
static inline void mconsole_register_dev(struct mc_device *new)
|
|
{
|
|
}
|
|
|
|
#endif
|
|
|
|
#endif
|