From 7bf2e471fd62f3c7983526fc4a8997456ece462f Mon Sep 17 00:00:00 2001 From: Page Asgardius Date: Wed, 12 Oct 2022 12:45:10 -0700 Subject: [PATCH] optimized object list --- .../asgardius/page/s3manager/BucketSelect.java | 14 ++++++-------- .../asgardius/page/s3manager/ObjectSelect.java | 14 ++++++-------- 2 files changed, 12 insertions(+), 16 deletions(-) diff --git a/app/src/main/java/asgardius/page/s3manager/BucketSelect.java b/app/src/main/java/asgardius/page/s3manager/BucketSelect.java index da7a10b..079b14d 100644 --- a/app/src/main/java/asgardius/page/s3manager/BucketSelect.java +++ b/app/src/main/java/asgardius/page/s3manager/BucketSelect.java @@ -225,14 +225,12 @@ public class BucketSelect extends AppCompatActivity { ObjectListing result = s3client.listObjects(orequest); ArrayList objectl = new ArrayList(); List objects = result.getObjectSummaries(); - boolean nextbatch = false; - while (result.isTruncated() || !nextbatch) { - if (nextbatch) { - result = s3client.listNextBatchOfObjects (result); - objects = result.getObjectSummaries(); - } else { - nextbatch = true; - } + for (S3ObjectSummary os : objects) { + objectl.add(os.getKey()); + } + while (result.isTruncated()) { + result = s3client.listNextBatchOfObjects (result); + objects = result.getObjectSummaries(); for (S3ObjectSummary os : objects) { objectl.add(os.getKey()); diff --git a/app/src/main/java/asgardius/page/s3manager/ObjectSelect.java b/app/src/main/java/asgardius/page/s3manager/ObjectSelect.java index d5560df..88dcc9c 100644 --- a/app/src/main/java/asgardius/page/s3manager/ObjectSelect.java +++ b/app/src/main/java/asgardius/page/s3manager/ObjectSelect.java @@ -546,14 +546,12 @@ public class ObjectSelect extends AppCompatActivity { ObjectListing result = s3client.listObjects(orequest); ArrayList objectl = new ArrayList(); List objects = result.getObjectSummaries(); - boolean nextbatch = false; - while (result.isTruncated() || !nextbatch) { - if (nextbatch) { - result = s3client.listNextBatchOfObjects (result); - objects = result.getObjectSummaries(); - } else { - nextbatch = true; - } + for (S3ObjectSummary os : objects) { + objectl.add(os.getKey()); + } + while (result.isTruncated()) { + result = s3client.listNextBatchOfObjects (result); + objects = result.getObjectSummaries(); for (S3ObjectSummary os : objects) { objectl.add(os.getKey());