From 1f98f23e11b081da89f66c75195a7706634d4925 Mon Sep 17 00:00:00 2001
From: Page Asgardius <asgardius@asgardius.company>
Date: Thu, 8 Sep 2022 18:13:41 -0700
Subject: [PATCH] change share for open in

---
 .../main/java/asgardius/page/s3manager/ObjectSelect.java | 9 ++++-----
 app/src/main/res/menu/object_menu.xml                    | 2 +-
 app/src/main/res/values/strings.xml                      | 2 +-
 3 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/app/src/main/java/asgardius/page/s3manager/ObjectSelect.java b/app/src/main/java/asgardius/page/s3manager/ObjectSelect.java
index e393219..ca3f38a 100644
--- a/app/src/main/java/asgardius/page/s3manager/ObjectSelect.java
+++ b/app/src/main/java/asgardius/page/s3manager/ObjectSelect.java
@@ -8,6 +8,7 @@ import androidx.recyclerview.widget.LinearLayoutManager;
 import androidx.recyclerview.widget.RecyclerView;
 
 import android.content.Intent;
+import android.net.Uri;
 import android.os.Bundle;
 import android.view.MenuItem;
 import android.view.View;
@@ -257,7 +258,7 @@ public class ObjectSelect extends AppCompatActivity {
                         public boolean onMenuItemClick(MenuItem menuItem) {
                             // Toast message on menu item clicked
                             //Toast.makeText(MainActivity.this, "You Clicked " + menuItem.getTitle(), Toast.LENGTH_SHORT).show();
-                            if (menuItem.getTitle() == getResources().getString(R.string.file_share)) {
+                            if (menuItem.getTitle() == getResources().getString(R.string.file_external)) {
                                 GeneratePresignedUrlRequest request = new GeneratePresignedUrlRequest(bucket, prefix + Name.get(position).toString());
                                 URL objectURL = s3client.generatePresignedUrl(request);
                                 share(objectURL.toString());
@@ -324,10 +325,8 @@ public class ObjectSelect extends AppCompatActivity {
 
         try {
 
-            Intent shareIntent = new Intent(Intent.ACTION_SEND);
-            shareIntent.setType("text/plain");
-            shareIntent.putExtra(Intent.EXTRA_SUBJECT, "Share Link");
-            shareIntent.putExtra(Intent.EXTRA_TEXT, object);
+            Intent shareIntent = new Intent(Intent.ACTION_VIEW);
+            shareIntent.setData(Uri.parse(object));
             startActivity(Intent.createChooser(shareIntent, "choose one"));
         } catch(Exception e) {
             Toast.makeText(getApplicationContext(),getResources().getString(R.string.media_list_fail), Toast.LENGTH_SHORT).show();
diff --git a/app/src/main/res/menu/object_menu.xml b/app/src/main/res/menu/object_menu.xml
index 90a8148..bf81914 100644
--- a/app/src/main/res/menu/object_menu.xml
+++ b/app/src/main/res/menu/object_menu.xml
@@ -3,7 +3,7 @@
 
     <item
         android:id="@+id/sharefile"
-        android:title="@string/file_share" />
+        android:title="@string/file_external" />
 
     <item
         android:id="@+id/deletefile"
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index de7b608..4a31959 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -4,7 +4,7 @@
     <string name="title_activity_video_player">VideoPlayer</string>
     <string name="broken_database">Local database is corrupted. Please reinstall this app</string>
     <string name="pending_feature">This feature is not implemented yet</string>
-    <string name="file_share">Get link</string>
+    <string name="file_external">Open in</string>
     <string name="file_del">Delete</string>
     <string name="accountselect">Please choose an account</string>
     <string name="accountadd_button">Add Account</string>