virtualx-engine/modules/webm/config.py

def can_build(env, platform):
    if env["arch"].startswith("rv"):
        return False
    if platform == "iphone":
        return False
    # Can work in theory but our libvpx/SCsub is too broken to compile NEON .s
    # files properly on Linux arm32. Could be fixed by someone motivated.
    if platform in ["x11", "server"] and env["arch"] in ["arm", "arm32"]:
        return False
    return True


def configure(env):
    pass


def get_doc_classes():
    return [
        "VideoStreamWebm",
    ]


def get_doc_path():
    return "doc_classes"
SCons: Pass env to modules can_build method This allows to disable modules based on the environment, in particular `env[tools]` which tells us if we are building the editor or not. 2018-05-30 19:11:33 +02:00			`def can_build(env, platform):`
[3.x] Add support for the RISC-V architecture Supports RV64GC (RISC-V 64-bit with general-purpose and compressed-instruction extensions) 2021-08-31 07:27:46 +02:00			`if env["arch"].startswith("rv"):`
			`return False`
Linux: Disable webm module on arm32, we can't build libvpx properly libvpx arm32 build with NEON can be supported in theory (and it works on Android armv7), but our SCons logic for it is super convoluted and broken. It needs significant rework to be made less error prone, and ensure we can compile `.s` files properly with cross-compilation toolchains. The demand to play WebM videos on older Pi3-style SoCs is likely low, so for now this is a simple compromise. Could be improved with some effort if someone is motivated. 2024-01-17 15:01:24 +01:00			`if platform == "iphone":`
			`return False`
			`# Can work in theory but our libvpx/SCsub is too broken to compile NEON .s`
			`# files properly on Linux arm32. Could be fixed by someone motivated.`
			`if platform in ["x11", "server"] and env["arch"] in ["arm", "arm32"]:`
			`return False`
			`return True`
SCons: Format buildsystem files with psf/black Configured for a max line length of 120 characters. psf/black is very opinionated and purposely doesn't leave much room for configuration. The output is mostly OK so that should be fine for us, but some things worth noting: - Manually wrapped strings will be reflowed, so by using a line length of 120 for the sake of preserving readability for our long command calls, it also means that some manually wrapped strings are back on the same line and should be manually merged again. - Code generators using string concatenation extensively look awful, since black puts each operand on a single line. We need to refactor these generators to use more pythonic string formatting, for which many options are available (`%`, `format` or f-strings). - CI checks and a pre-commit hook will be added to ensure that future buildsystem changes are well-formatted. (cherry picked from commit cd4e46ee65dab6baa6a143bf3b3f64244be36712) 2020-03-30 08:28:32 +02:00
Add WebM module Use already existing libraries: libvorbis and libopus. Also use newly added libraries: libvpx, libwebm, libsimplewebm. 2016-10-17 17:14:07 +02:00
			`def configure(env):`
style: Start applying PEP8 to Python files, indentation issues Done with `autopep8 --select=E1`, fixes: - E101 - Reindent all lines. - E112 - Fix under-indented comments. - E113 - Fix over-indented comments. - E115 - Fix under-indented comments. - E116 - Fix over-indented comments. - E121 - Fix a badly indented line. - E122 - Fix a badly indented line. - E123 - Fix a badly indented line. - E124 - Fix a badly indented line. - E125 - Fix indentation undistinguish from the next logical line. - E126 - Fix a badly indented line. - E127 - Fix a badly indented line. - E128 - Fix a badly indented line. - E129 - Fix a badly indented line. 2016-10-30 18:44:57 +01:00			`pass`
doc: Make all module docs self-contained 2017-11-15 19:23:20 +01:00
SCons: Format buildsystem files with psf/black Configured for a max line length of 120 characters. psf/black is very opinionated and purposely doesn't leave much room for configuration. The output is mostly OK so that should be fine for us, but some things worth noting: - Manually wrapped strings will be reflowed, so by using a line length of 120 for the sake of preserving readability for our long command calls, it also means that some manually wrapped strings are back on the same line and should be manually merged again. - Code generators using string concatenation extensively look awful, since black puts each operand on a single line. We need to refactor these generators to use more pythonic string formatting, for which many options are available (`%`, `format` or f-strings). - CI checks and a pre-commit hook will be added to ensure that future buildsystem changes are well-formatted. (cherry picked from commit cd4e46ee65dab6baa6a143bf3b3f64244be36712) 2020-03-30 08:28:32 +02:00
doc: Make all module docs self-contained 2017-11-15 19:23:20 +01:00			`def get_doc_classes():`
			`return [`
			`"VideoStreamWebm",`
			`]`

SCons: Format buildsystem files with psf/black Configured for a max line length of 120 characters. psf/black is very opinionated and purposely doesn't leave much room for configuration. The output is mostly OK so that should be fine for us, but some things worth noting: - Manually wrapped strings will be reflowed, so by using a line length of 120 for the sake of preserving readability for our long command calls, it also means that some manually wrapped strings are back on the same line and should be manually merged again. - Code generators using string concatenation extensively look awful, since black puts each operand on a single line. We need to refactor these generators to use more pythonic string formatting, for which many options are available (`%`, `format` or f-strings). - CI checks and a pre-commit hook will be added to ensure that future buildsystem changes are well-formatted. (cherry picked from commit cd4e46ee65dab6baa6a143bf3b3f64244be36712) 2020-03-30 08:28:32 +02:00
doc: Make all module docs self-contained 2017-11-15 19:23:20 +01:00			`def get_doc_path():`
			`return "doc_classes"`