asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
virtualx-engine/editor/editor_node.cpp

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

8224 lines
301 KiB
C++
Raw Normal View History

GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
/**************************************************************************/
/* editor_node.cpp */
/**************************************************************************/
/* This file is part of: */
/* GODOT ENGINE */
/* https://godotengine.org */
/**************************************************************************/
/* Copyright (c) 2014-present Godot Engine contributors (see AUTHORS.md). */
/* Copyright (c) 2007-2014 Juan Linietsky, Ariel Manzur. */
/* */
/* Permission is hereby granted, free of charge, to any person obtaining */
/* a copy of this software and associated documentation files (the */
/* "Software"), to deal in the Software without restriction, including */
/* without limitation the rights to use, copy, modify, merge, publish, */
/* distribute, sublicense, and/or sell copies of the Software, and to */
/* permit persons to whom the Software is furnished to do so, subject to */
/* the following conditions: */
/* */
/* The above copyright notice and this permission notice shall be */
/* included in all copies or substantial portions of the Software. */
/* */
/* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, */
/* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF */
/* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. */
/* IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY */
/* CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, */
/* TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE */
/* SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */
/**************************************************************************/
Add missing copyright headers and fix formatting Using `misc/scripts/fix_headers.py` on all Godot files. Some missing header guards were added, and the header inclusion order was fixed in the Bullet module.
2018-01-05 00:50:27 +01:00
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
#include "editor_node.h"
Style: Cleanups, added headers, renamed files Made sure files in core/ and tools/ have a proper Godot license header when written by us. Also renamed aabb.{cpp,h} and object_type_db.{cpp,h} to rect3.{cpp,h} and class_db.{cpp,h} respectively. Also added a proper header to core/io/base64.{c,h} after clarifying the licensing with the original author (public domain).
2017-01-16 08:04:19 +01:00
Reorganized core/ directory, it was too fatty already -Removed FuncRef, since Callable makes it obsolete -Removed int_types.h as its obsolete in c++11+ -Changed color names code
2020-11-07 23:33:38 +01:00
#include "core/config/project_settings.h"
Implement reloading of GDExtensions
2023-08-05 03:34:14 +02:00
#include "core/extension/gdextension_manager.h"
Rename InputFilter back to Input It changed name as part of the DisplayServer and input refactoring in #37317, with the rationale that input no longer goes through the main loop, so the previous Input singleton now only does filtering. But the gains in consistency are quite limited in the renaming, and it breaks compatibility for all scripts and tutorials that access the Input singleton via the scripting language. A temporary option was suggested to keep the scripting singleton named `Input` even if its type is `InputFilter`, but that adds inconsistency and breaks C#. Fixes godotengine/godot-proposals#639. Fixes #37319. Fixes #37690.
2020-04-28 15:19:37 +02:00
#include "core/input/input.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "core/io/config_file.h"
Core: Move DirAccess and FileAccess to `core/io` File handling APIs are typically considered part of I/O, and we did have most `FileAccess` implementations in `core/io` already.
2021-06-11 14:51:48 +02:00
#include "core/io/file_access.h"
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
#include "core/io/resource_loader.h"
#include "core/io/resource_saver.h"
Reorganized core/ directory, it was too fatty already -Removed FuncRef, since Callable makes it obsolete -Removed int_types.h as its obsolete in c++11+ -Changed color names code
2020-11-07 23:33:38 +01:00
#include "core/object/class_db.h"
#include "core/object/message_queue.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "core/os/keyboard.h"
#include "core/os/os.h"
Add Time singleton
2021-05-24 13:54:05 +02:00
#include "core/os/time.h"
Reorganized core/ directory, it was too fatty already -Removed FuncRef, since Callable makes it obsolete -Removed int_types.h as its obsolete in c++11+ -Changed color names code
2020-11-07 23:33:38 +01:00
#include "core/string/print_string.h"
#include "core/string/translation.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "core/version.h"
Add EditorStringNames singleton
2023-08-13 02:33:39 +02:00
#include "editor/editor_string_names.h"
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
#include "main/main.h"
Reimport bone attachment fixes: Assign bone_idx to GLTF importer to fix serialization. Notifies Skeletons and BoneAttachments when reimporting. Removes usage of NOTIFICATION_NODE_RECACHE_REQUESTED
2023-09-28 06:32:32 +02:00
#include "scene/3d/bone_attachment_3d.h"
Extract EditorResourceConversionPlugin into its own source files and clean up editor includes
2022-07-31 20:14:15 +02:00
#include "scene/gui/color_picker.h"
Cleans up headers included in editor_node.h
2019-12-24 08:17:23 +01:00
#include "scene/gui/dialogs.h"
#include "scene/gui/file_dialog.h"
Make it possible to copy the Godot version identifier by clicking it This closes #24317.
2019-12-24 01:20:54 +01:00
#include "scene/gui/link_button.h"
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
#include "scene/gui/menu_bar.h"
Cleans up headers included in editor_node.h
2019-12-24 08:17:23 +01:00
#include "scene/gui/menu_button.h"
#include "scene/gui/panel.h"
#include "scene/gui/panel_container.h"
Extract editor run toolbar into its own component - Simplify and update its logic. - Simplify EditorScript. - Improve EditorNode and other relevant includes. - Fix scene-based path in the movie writer when reloading a scene.
2023-04-12 21:02:28 +02:00
#include "scene/gui/popup.h"
#include "scene/gui/rich_text_label.h"
Cleans up headers included in editor_node.h
2019-12-24 08:17:23 +01:00
#include "scene/gui/split_container.h"
#include "scene/gui/tab_container.h"
PVRTC: Move compress func to `modules/pvr`, drop obsolete PVRTexTool code The code we had for PVRTexTool doesn't work as it's not compatible with current PVRTexTool CLI options, and likely hasn't been for years. Instead, we have our own vendored pvrtccompressor thirdparty library which all users have thus de-facto been using. This commit moves the compress code to `modules/pvr` where it belongs. There's no proper compress function for PVRTC 2-bit format, that's a bug that will need to be fixed (currently it's compressed as 4-bit format even if you use Image::FORMAT_PVRTC2). Fixes #28669.
2020-12-10 15:44:05 +01:00
#include "scene/main/window.h"
Update instances of scenes which have been reimported.
2022-01-30 22:31:32 +01:00
#include "scene/property_utils.h"
Extract and reorganize texture resource classes
2023-07-11 22:29:09 +02:00
#include "scene/resources/image_texture.h"
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
#include "scene/resources/packed_scene.h"
Extract and reorganize texture resource classes
2023-07-11 22:29:09 +02:00
#include "scene/resources/portable_compressed_texture.h"
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
#include "scene/theme/theme_db.h"
PVRTC: Move compress func to `modules/pvr`, drop obsolete PVRTexTool code The code we had for PVRTexTool doesn't work as it's not compatible with current PVRTexTool CLI options, and likely hasn't been for years. Instead, we have our own vendored pvrtccompressor thirdparty library which all users have thus de-facto been using. This commit moves the compress code to `modules/pvr` where it belongs. There's no proper compress function for PVRTC 2-bit format, that's a bug that will need to be fixed (currently it's compressed as 4-bit format even if you use Image::FORMAT_PVRTC2). Fixes #28669.
2020-12-10 15:44:05 +01:00
#include "servers/display_server.h"
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 19:21:27 +01:00
#include "servers/navigation_server_3d.h"
#include "servers/physics_server_2d.h"
Reset SDFGI when changing editor scene tabs
2023-08-30 15:25:27 +02:00
#include "servers/rendering_server.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
Cleans up headers included in editor_node.h
2019-12-24 08:17:23 +01:00
#include "editor/audio_stream_preview.h"
Move Debug menu logic to DebuggerEditorPlugin
2020-03-08 18:58:31 +01:00
#include "editor/debugger/editor_debugger_node.h"
Improve editor state persistence
2023-05-11 04:17:03 +02:00
#include "editor/debugger/script_editor_debugger.h"
Cleans up headers included in editor_node.h
2019-12-24 08:17:23 +01:00
#include "editor/dependency_editor.h"
#include "editor/editor_about.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/editor_audio_buses.h"
Implement Feature Build Profiles This PR is a continuation of #50381 (which was implemented exactly a year ago!) * Add a visual interface to select which classes should not be built into Godot (well, they are built if something else uses them, but if not used the optimizer will remove them out). * Add a detection system to scan the project and figure out the actual classes used. * Added the ability for SCons to load build profiles. Obligatory Screen: A simple test with a couple of nodes in the scene resulted in a 25% reduction for the final binary size TODO: * Script languages need to implement used class detection (left for another PR). * Options to disable servers or server functionalities (like 2D or 3D physics, navigation, etc). Are missing, that should also greatly aid in reducing binary size. * Options to disable some modules would be desired. * More options to disable drivers (OpenGL, Vulkan, etc) would be desired. In general this PR is a starting point for more contributors to improve and enhance this functionality.
2022-07-14 14:18:18 +02:00
#include "editor/editor_build_profile.h"
Added EditorCommandPalette
2021-05-29 15:28:16 +02:00
#include "editor/editor_command_palette.h"
Improve compilation speed (forward declarations/includes cleanup)
2022-02-12 02:46:22 +01:00
#include "editor/editor_data.h"
Cleans up headers included in editor_node.h
2019-12-24 08:17:23 +01:00
#include "editor/editor_feature_profile.h"
Improve compilation speed (forward declarations/includes cleanup)
2022-02-12 02:46:22 +01:00
#include "editor/editor_folding.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/editor_help.h"
Cleans up headers included in editor_node.h
2019-12-24 08:17:23 +01:00
#include "editor/editor_inspector.h"
Decouple EditorInterface from EditorPlugin - Simplify some includes in the process. - Also exposes EditorInterface.movie_maker_enabled as a property.
2023-04-05 17:14:46 +02:00
#include "editor/editor_interface.h"
Cleans up headers included in editor_node.h
2019-12-24 08:17:23 +01:00
#include "editor/editor_layouts_dialog.h"
#include "editor/editor_log.h"
Improve includes of EditorNode (and everything else) Also start organizing editor-specific GUI components into a dedicated folder, `editor/gui`. Also move `editor_file_server` next to the rest of debugger classes.
2023-04-07 18:59:49 +02:00
#include "editor/editor_native_shader_source_visualizer.h"
Implement shader caching * Shader compilation is now cached. Subsequent loads take less than a millisecond. * Improved game, editor and project manager startup time. * Editor uses .godot/shader_cache to store shaders. * Game uses user://shader_cache * Project manager uses $config_dir/shader_cache * Options to tweak shader caching in project settings. * Editor path configuration moved from EditorSettings to new class, EditorPaths, so it can be available early on (before shaders are compiled). * Reworked ShaderCompilerRD to ensure deterministic shader code creation (else shader may change and cache will be invalidated). * Added shader compression with SMOLV: https://github.com/aras-p/smol-v
2021-05-25 02:25:11 +02:00
#include "editor/editor_paths.h"
Cleans up headers included in editor_node.h
2019-12-24 08:17:23 +01:00
#include "editor/editor_plugin.h"
-New inspector. -Changed UI resizing code, gained huge amount of speed. -Reorganized timer sync to clean up behavior (sorry forgot commit this before) -
2018-05-15 22:12:35 +02:00
#include "editor/editor_properties.h"
i18n: Make property paths and categories translatable
2022-03-03 11:25:11 +01:00
#include "editor/editor_property_name_processor.h"
Use forward-declarations in big editor classes
2022-11-19 12:45:49 +01:00
#include "editor/editor_quick_open.h"
#include "editor/editor_resource_preview.h"
Improve compilation speed (forward declarations/includes cleanup)
2022-02-12 02:46:22 +01:00
#include "editor/editor_run.h"
Cleans up headers included in editor_node.h
2019-12-24 08:17:23 +01:00
#include "editor/editor_run_native.h"
#include "editor/editor_scale.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/editor_settings.h"
Minor fixes/refactoring of project and editor setting dialogs
2022-02-01 00:19:01 +01:00
#include "editor/editor_settings_dialog.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/editor_themes.h"
Add translation parser plugin support
2020-06-23 13:48:59 +02:00
#include "editor/editor_translation_parser.h"
Add per-scene UndoRedo
2022-03-25 18:06:46 +01:00
#include "editor/editor_undo_redo_manager.h"
Split up editor export code into multiple files
2022-07-17 19:24:37 +02:00
#include "editor/export/editor_export.h"
Move project export and export template manager into export folder
2022-07-21 00:45:01 +02:00
#include "editor/export/export_template_manager.h"
#include "editor/export/project_export.h"
Add a dialog for customizing FBX import * If FBX files are found, a dialog will pop up asking to configure FBX2glTF. * Dialog can also be accessed by going Editor -> Configure FBX Import. * The dialog also shows a link to click to download the converter, which should contain instructions.
2022-04-02 13:43:15 +02:00
#include "editor/fbx_importer_manager.h"
Cleans up headers included in editor_node.h
2019-12-24 08:17:23 +01:00
#include "editor/filesystem_dock.h"
Improve includes of EditorNode (and everything else) Also start organizing editor-specific GUI components into a dedicated folder, `editor/gui`. Also move `editor_file_server` next to the rest of debugger classes.
2023-04-07 18:59:49 +02:00
#include "editor/gui/editor_file_dialog.h"
Extract editor run toolbar into its own component - Simplify and update its logic. - Simplify EditorScript. - Improve EditorNode and other relevant includes. - Fix scene-based path in the movie writer when reloading a scene.
2023-04-12 21:02:28 +02:00
#include "editor/gui/editor_run_bar.h"
Extract editor scene tabs into their own component
2023-08-24 12:24:29 +02:00
#include "editor/gui/editor_scene_tabs.h"
Improve includes of EditorNode (and everything else) Also start organizing editor-specific GUI components into a dedicated folder, `editor/gui`. Also move `editor_file_server` next to the rest of debugger classes.
2023-04-07 18:59:49 +02:00
#include "editor/gui/editor_title_bar.h"
#include "editor/gui/editor_toaster.h"
Add history dock
2022-08-27 13:52:06 +02:00
#include "editor/history_dock.h"
Implement BPM support Based on #62896, only implements the BPM support part. * Implements BPM support in the AudioStreamOGG/MP3 importers. * Can select BPM/Bar Size and total beats in a song file, as well as edit looping points. * Looping is now BPM aware * Added a special importer UI for configuring this. * Added a special preview showing the audio waveform as well as the playback position in the resource picker. * Renamed `AudioStream::instance` to `instantiate` for correctness.
2022-07-21 01:00:58 +02:00
#include "editor/import/audio_stream_import_settings.h"
Editor: Cleanup some includes dependencies Removes some unnecessary includes from `editor_node.h`, and instead add those where they're used. Removes unnecessary `editor_node.h` includes in various editor classes. Renames `dynamicfont` to `dynamic_font` in a couple files. Misc cleanup while jumping through that rabbit hole.
2022-02-14 14:00:03 +01:00
#include "editor/import/dynamic_font_import_settings.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/import/editor_import_collada.h"
Removed PBM bitmap loader, added abiliy to importi mages as bitmap. Fixes #14828
2018-01-06 20:36:49 +01:00
#include "editor/import/resource_importer_bitmask.h"
Makes FontData importable resource. Adds multi-channel SDF font texture generation and rendering support. Adds per-font oversampling support. Adds FontData import plugins (for dynamic fonts, BMFonts and monospaced image fonts), font texture cache pre-generation and loading. Adds BMFont binary format and outline support.
2020-12-27 14:30:33 +01:00
#include "editor/import/resource_importer_bmfont.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/import/resource_importer_csv_translation.h"
Editor: Cleanup some includes dependencies Removes some unnecessary includes from `editor_node.h`, and instead add those where they're used. Removes unnecessary `editor_node.h` includes in various editor classes. Renames `dynamicfont` to `dynamic_font` in a couple files. Misc cleanup while jumping through that rabbit hole.
2022-02-14 14:00:03 +01:00
#include "editor/import/resource_importer_dynamic_font.h"
It is now possible to import images as a separate resource, closes #5738 and likely many others
2018-07-29 21:45:23 +02:00
#include "editor/import/resource_importer_image.h"
Makes FontData importable resource. Adds multi-channel SDF font texture generation and rendering support. Adds per-font oversampling support. Adds FontData import plugins (for dynamic fonts, BMFonts and monospaced image fonts), font texture cache pre-generation and loading. Adds BMFont binary format and outline support.
2020-12-27 14:30:33 +01:00
#include "editor/import/resource_importer_imagefont.h"
Added proper import support for 3D and Array textures
2018-08-06 19:56:06 +02:00
#include "editor/import/resource_importer_layered_texture.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/import/resource_importer_obj.h"
Exposed RenderingDevice to script API Also added an easier way to load native GLSL shaders. Extras: Had to fix no-cache for subresources in resource loader, it was not properly working, making shaders not properly reload. Note: The precommit hooks are broken because they don't seem to support enums from one class being used in another. Feel free to fix this after merging this PR.
2020-04-20 04:19:21 +02:00
#include "editor/import/resource_importer_shader_file.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/import/resource_importer_texture.h"
Added ability for multiple images to be imported as an atlas This adds support for groups in the import system, which point to a single file. Add property hint for saving files in file field
2019-04-19 20:54:33 +02:00
#include "editor/import/resource_importer_texture_atlas.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/import/resource_importer_wav.h"
Improved 3D Scene Importer * Added option for importers to show an Advanced settings dialog * Created advanced settings dialog for Scene Importer * Cleaned up importers (remove many old/unused options) * Added the ability to customize every node, material, mesh and animation individually * Saving to animations and meshes to files is now a manual process, making it more predictable * Added the ability for materials to be replaced by external files (or to be made external, up to you). * When doubleclicking an impoted scene in the filesystem dock, it automatically shows the import settings instead of asking to open it. WARNING: Lightmap UV unwrap is not working, it needs to be re-made.
2021-03-19 13:57:52 +01:00
#include "editor/import/scene_import_settings.h"
Cleans up headers included in editor_node.h
2019-12-24 08:17:23 +01:00
#include "editor/import_dock.h"
Use forward-declarations in big editor classes
2022-11-19 12:45:49 +01:00
#include "editor/inspector_dock.h"
Keep focus on the top-most node for multi-selection in scene tree Makes behavior consistent with selecting/deselecting single nodes and fixes a regression about the focused node being lost when multi-selecting. Fixes #33332
2019-11-10 09:37:51 +01:00
#include "editor/multi_node_edit.h"
Cleans up headers included in editor_node.h
2019-12-24 08:17:23 +01:00
#include "editor/node_dock.h"
#include "editor/plugin_config_dialog.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/plugins/animation_player_editor_plugin.h"
#include "editor/plugins/asset_library_editor_plugin.h"
#include "editor/plugins/canvas_item_editor_plugin.h"
Huge Debugger/EditorDebugger refactor.
2020-02-07 02:52:05 +01:00
#include "editor/plugins/debugger_editor_plugin.h"
Add "dedicated server" export mode which can strip unneeded visual resources
2022-12-20 22:49:11 +01:00
#include "editor/plugins/dedicated_server_export_plugin.h"
Use forward-declarations in big editor classes
2022-11-19 12:45:49 +01:00
#include "editor/plugins/editor_preview_plugins.h"
Extract EditorResourceConversionPlugin into its own source files and clean up editor includes
2022-07-31 20:14:15 +02:00
#include "editor/plugins/editor_resource_conversion_plugin.h"
Implement GDExtension export plugin.
2022-03-10 08:48:25 +01:00
#include "editor/plugins/gdextension_export_plugin.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/plugins/material_editor_plugin.h"
Fix MeshLibrary editor
2018-08-22 00:06:52 +02:00
#include "editor/plugins/mesh_library_editor_plugin.h"
Rename more 2D and 3D nodes to follow convention Rename editor plugins to match the new node names.
2020-03-27 08:44:44 +01:00
#include "editor/plugins/node_3d_editor_plugin.h"
Add translation parser plugin support
2020-06-23 13:48:59 +02:00
#include "editor/plugins/packed_scene_translation_parser_plugin.h"
Improve editing of min/max particle properties
2023-10-10 23:48:46 +02:00
#include "editor/plugins/particle_process_material_editor_plugin.h"
-Add root motion support in AnimationTree. -Add RootMotionView, to debug root motion in 3D (disabled in runtime)
2018-06-27 00:05:11 +02:00
#include "editor/plugins/root_motion_editor_plugin.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/plugins/script_text_editor.h"
Allow opening and editing of any utf_8 file in script editor
2018-05-28 17:52:28 +02:00
#include "editor/plugins/text_editor.h"
Add VCS editor plugin UI elements to editor
2019-09-03 16:42:08 +02:00
#include "editor/plugins/version_control_editor_plugin.h"
Visual Shaders are back.
2018-07-14 23:15:42 +02:00
#include "editor/plugins/visual_shader_editor_plugin.h"
Cleans up headers included in editor_node.h
2019-12-24 08:17:23 +01:00
#include "editor/progress_dialog.h"
#include "editor/project_settings_editor.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/register_exporters.h"
Improve compilation speed (forward declarations/includes cleanup)
2022-02-12 02:46:22 +01:00
#include "editor/scene_tree_dock.h"
Implementation of tool to automatically upgrade and re-save meshes
2023-10-19 13:31:26 +02:00
#include "editor/surface_upgrade_tool.h"
Add multi window code and shader editors
2022-11-02 15:23:25 +01:00
#include "editor/window_wrapper.h"
PVRTC: Move compress func to `modules/pvr`, drop obsolete PVRTexTool code The code we had for PVRTexTool doesn't work as it's not compatible with current PVRTexTool CLI options, and likely hasn't been for years. Instead, we have our own vendored pvrtccompressor thirdparty library which all users have thus de-facto been using. This commit moves the compress code to `modules/pvr` where it belongs. There's no proper compress function for PVRTC 2-bit format, that's a bug that will need to be fixed (currently it's compressed as 4-bit format even if you use Image::FORMAT_PVRTC2). Fixes #28669.
2020-12-10 15:44:05 +01:00
Ability to delete, drag and drop audio buses!
2017-01-24 03:12:08 +01:00
#include <stdio.h>
Exit the editor export process with a non-zero exit code on error This closes #34672.
2019-12-29 16:11:58 +01:00
#include <stdlib.h>
Able to open project manager inside editor (Scene->Project Manager) Remove unnecessary include of project_manager.h
2014-02-18 05:21:06 +01:00
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
EditorNode *EditorNode::singleton = nullptr;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Make it possible to copy the Godot version identifier by clicking it This closes #24317.
2019-12-24 01:20:54 +01:00
// The metadata key used to store and retrieve the version text to copy to the clipboard.
static const String META_TEXT_TO_COPY = "text_to_copy";
Improve editor state persistence
2023-05-11 04:17:03 +02:00
static const String EDITOR_NODE_CONFIG_SECTION = "EditorNode";
implement generic filename disambiguation A static function is added to EditorNode which allows for filename disambiguation given a list of filenames and the corresponding list of absolute paths for those files. This function is then used to disambiguate scene and script tabs in the editor.
2020-05-27 06:49:05 +02:00
void EditorNode::disambiguate_filenames(const Vector<String> p_full_paths, Vector<String> &r_filenames) {
EditorFileDialog: disambiguate recent/favorite items Similar to script editor, if two folders have the same name, they will now get a more descriptive name in the item list.
2022-07-27 20:51:03 +02:00
ERR_FAIL_COND_MSG(p_full_paths.size() != r_filenames.size(), vformat("disambiguate_filenames requires two string vectors of same length (%d != %d).", p_full_paths.size(), r_filenames.size()));
implement generic filename disambiguation A static function is added to EditorNode which allows for filename disambiguation given a list of filenames and the corresponding list of absolute paths for those files. This function is then used to disambiguate scene and script tabs in the editor.
2020-05-27 06:49:05 +02:00
// Keep track of a list of "index sets," i.e. sets of indices
// within disambiguated_scene_names which contain the same name.
Replace most uses of Map by HashMap * Map is unnecessary and inefficient in almost every case. * Replaced by the new HashMap. * Renamed Map to RBMap and Set to RBSet for cases that still make sense (order matters) but use is discouraged. There were very few cases where replacing by HashMap was undesired because keeping the key order was intended. I tried to keep those (as RBMap) as much as possible, but might have missed some. Review appreciated!
2022-05-13 15:04:37 +02:00
Vector<RBSet<int>> index_sets;
HashMap<String, int> scene_name_to_set_index;
implement generic filename disambiguation A static function is added to EditorNode which allows for filename disambiguation given a list of filenames and the corresponding list of absolute paths for those files. This function is then used to disambiguate scene and script tabs in the editor.
2020-05-27 06:49:05 +02:00
for (int i = 0; i < r_filenames.size(); i++) {
String scene_name = r_filenames[i];
if (!scene_name_to_set_index.has(scene_name)) {
Replace most uses of Map by HashMap * Map is unnecessary and inefficient in almost every case. * Replaced by the new HashMap. * Renamed Map to RBMap and Set to RBSet for cases that still make sense (order matters) but use is discouraged. There were very few cases where replacing by HashMap was undesired because keeping the key order was intended. I tried to keep those (as RBMap) as much as possible, but might have missed some. Review appreciated!
2022-05-13 15:04:37 +02:00
index_sets.append(RBSet<int>());
implement generic filename disambiguation A static function is added to EditorNode which allows for filename disambiguation given a list of filenames and the corresponding list of absolute paths for those files. This function is then used to disambiguate scene and script tabs in the editor.
2020-05-27 06:49:05 +02:00
scene_name_to_set_index.insert(r_filenames[i], index_sets.size() - 1);
}
index_sets.write[scene_name_to_set_index[scene_name]].insert(i);
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// For each index set with a size > 1, we need to disambiguate.
implement generic filename disambiguation A static function is added to EditorNode which allows for filename disambiguation given a list of filenames and the corresponding list of absolute paths for those files. This function is then used to disambiguate scene and script tabs in the editor.
2020-05-27 06:49:05 +02:00
for (int i = 0; i < index_sets.size(); i++) {
Replace most uses of Map by HashMap * Map is unnecessary and inefficient in almost every case. * Replaced by the new HashMap. * Renamed Map to RBMap and Set to RBSet for cases that still make sense (order matters) but use is discouraged. There were very few cases where replacing by HashMap was undesired because keeping the key order was intended. I tried to keep those (as RBMap) as much as possible, but might have missed some. Review appreciated!
2022-05-13 15:04:37 +02:00
RBSet<int> iset = index_sets[i];
implement generic filename disambiguation A static function is added to EditorNode which allows for filename disambiguation given a list of filenames and the corresponding list of absolute paths for those files. This function is then used to disambiguate scene and script tabs in the editor.
2020-05-27 06:49:05 +02:00
while (iset.size() > 1) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Append the parent folder to each scene name.
Use range iterators for RBSet in most cases
2022-05-19 01:43:40 +02:00
for (const int &E : iset) {
int set_idx = E;
implement generic filename disambiguation A static function is added to EditorNode which allows for filename disambiguation given a list of filenames and the corresponding list of absolute paths for those files. This function is then used to disambiguate scene and script tabs in the editor.
2020-05-27 06:49:05 +02:00
String scene_name = r_filenames[set_idx];
String full_path = p_full_paths[set_idx];
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Get rid of file extensions and res:// prefixes.
Fix disambiguate_filenames absolute paths on Unix Also clean up relative path handling to use get_basename()
2022-11-06 15:51:45 +01:00
scene_name = scene_name.get_basename();
implement generic filename disambiguation A static function is added to EditorNode which allows for filename disambiguation given a list of filenames and the corresponding list of absolute paths for those files. This function is then used to disambiguate scene and script tabs in the editor.
2020-05-27 06:49:05 +02:00
if (full_path.begins_with("res://")) {
full_path = full_path.substr(6);
}
Fix disambiguate_filenames absolute paths on Unix Also clean up relative path handling to use get_basename()
2022-11-06 15:51:45 +01:00
full_path = full_path.get_basename();
implement generic filename disambiguation A static function is added to EditorNode which allows for filename disambiguation given a list of filenames and the corresponding list of absolute paths for those files. This function is then used to disambiguate scene and script tabs in the editor.
2020-05-27 06:49:05 +02:00
EditorFileDialog: disambiguate recent/favorite items Similar to script editor, if two folders have the same name, they will now get a more descriptive name in the item list.
2022-07-27 20:51:03 +02:00
// Normalize trailing slashes when normalizing directory names.
Fix #65122: disambiguate_filenames freeze
2022-08-31 12:45:01 +02:00
scene_name = scene_name.trim_suffix("/");
full_path = full_path.trim_suffix("/");
EditorFileDialog: disambiguate recent/favorite items Similar to script editor, if two folders have the same name, they will now get a more descriptive name in the item list.
2022-07-27 20:51:03 +02:00
implement generic filename disambiguation A static function is added to EditorNode which allows for filename disambiguation given a list of filenames and the corresponding list of absolute paths for those files. This function is then used to disambiguate scene and script tabs in the editor.
2020-05-27 06:49:05 +02:00
int scene_name_size = scene_name.size();
int full_path_size = full_path.size();
int difference = full_path_size - scene_name_size;
// Find just the parent folder of the current path and append it.
// If the current name is foo.tscn, and the full path is /some/folder/foo.tscn
// then slash_idx is the second '/', so that we select just "folder", and
// append that to yield "folder/foo.tscn".
if (difference > 0) {
String parent = full_path.substr(0, difference);
int slash_idx = parent.rfind("/");
slash_idx = parent.rfind("/", slash_idx - 1);
Fix disambiguate_filenames absolute paths on Unix Also clean up relative path handling to use get_basename()
2022-11-06 15:51:45 +01:00
parent = (slash_idx >= 0 && parent.length() > 1) ? parent.substr(slash_idx + 1) : parent;
implement generic filename disambiguation A static function is added to EditorNode which allows for filename disambiguation given a list of filenames and the corresponding list of absolute paths for those files. This function is then used to disambiguate scene and script tabs in the editor.
2020-05-27 06:49:05 +02:00
r_filenames.write[set_idx] = parent + r_filenames[set_idx];
}
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Loop back through scene names and remove non-ambiguous names.
implement generic filename disambiguation A static function is added to EditorNode which allows for filename disambiguation given a list of filenames and the corresponding list of absolute paths for those files. This function is then used to disambiguate scene and script tabs in the editor.
2020-05-27 06:49:05 +02:00
bool can_proceed = false;
Replace most uses of Map by HashMap * Map is unnecessary and inefficient in almost every case. * Replaced by the new HashMap. * Renamed Map to RBMap and Set to RBSet for cases that still make sense (order matters) but use is discouraged. There were very few cases where replacing by HashMap was undesired because keeping the key order was intended. I tried to keep those (as RBMap) as much as possible, but might have missed some. Review appreciated!
2022-05-13 15:04:37 +02:00
RBSet<int>::Element *E = iset.front();
implement generic filename disambiguation A static function is added to EditorNode which allows for filename disambiguation given a list of filenames and the corresponding list of absolute paths for those files. This function is then used to disambiguate scene and script tabs in the editor.
2020-05-27 06:49:05 +02:00
while (E) {
String scene_name = r_filenames[E->get()];
bool duplicate_found = false;
Use range iterators for RBSet in most cases
2022-05-19 01:43:40 +02:00
for (const int &F : iset) {
if (E->get() == F) {
implement generic filename disambiguation A static function is added to EditorNode which allows for filename disambiguation given a list of filenames and the corresponding list of absolute paths for those files. This function is then used to disambiguate scene and script tabs in the editor.
2020-05-27 06:49:05 +02:00
continue;
}
Use range iterators for RBSet in most cases
2022-05-19 01:43:40 +02:00
String other_scene_name = r_filenames[F];
implement generic filename disambiguation A static function is added to EditorNode which allows for filename disambiguation given a list of filenames and the corresponding list of absolute paths for those files. This function is then used to disambiguate scene and script tabs in the editor.
2020-05-27 06:49:05 +02:00
if (other_scene_name == scene_name) {
duplicate_found = true;
break;
}
}
Replace most uses of Map by HashMap * Map is unnecessary and inefficient in almost every case. * Replaced by the new HashMap. * Renamed Map to RBMap and Set to RBSet for cases that still make sense (order matters) but use is discouraged. There were very few cases where replacing by HashMap was undesired because keeping the key order was intended. I tried to keep those (as RBMap) as much as possible, but might have missed some. Review appreciated!
2022-05-13 15:04:37 +02:00
RBSet<int>::Element *to_erase = duplicate_found ? nullptr : E;
implement generic filename disambiguation A static function is added to EditorNode which allows for filename disambiguation given a list of filenames and the corresponding list of absolute paths for those files. This function is then used to disambiguate scene and script tabs in the editor.
2020-05-27 06:49:05 +02:00
// We need to check that we could actually append anymore names
// if we wanted to for disambiguation. If we can't, then we have
// to abort even with ambiguous names. We clean the full path
// and the scene name first to remove extensions so that this
// comparison actually works.
String path = p_full_paths[E->get()];
Fix #65122: disambiguate_filenames freeze
2022-08-31 12:45:01 +02:00
// Get rid of file extensions and res:// prefixes.
Fix disambiguate_filenames absolute paths on Unix Also clean up relative path handling to use get_basename()
2022-11-06 15:51:45 +01:00
scene_name = scene_name.get_basename();
implement generic filename disambiguation A static function is added to EditorNode which allows for filename disambiguation given a list of filenames and the corresponding list of absolute paths for those files. This function is then used to disambiguate scene and script tabs in the editor.
2020-05-27 06:49:05 +02:00
if (path.begins_with("res://")) {
path = path.substr(6);
}
Fix disambiguate_filenames absolute paths on Unix Also clean up relative path handling to use get_basename()
2022-11-06 15:51:45 +01:00
path = path.get_basename();
implement generic filename disambiguation A static function is added to EditorNode which allows for filename disambiguation given a list of filenames and the corresponding list of absolute paths for those files. This function is then used to disambiguate scene and script tabs in the editor.
2020-05-27 06:49:05 +02:00
Fix #65122: disambiguate_filenames freeze
2022-08-31 12:45:01 +02:00
// Normalize trailing slashes when normalizing directory names.
scene_name = scene_name.trim_suffix("/");
path = path.trim_suffix("/");
// We can proceed if the full path is longer than the scene name,
implement generic filename disambiguation A static function is added to EditorNode which allows for filename disambiguation given a list of filenames and the corresponding list of absolute paths for those files. This function is then used to disambiguate scene and script tabs in the editor.
2020-05-27 06:49:05 +02:00
// meaning that there is at least one more parent folder we can
// tack onto the name.
can_proceed = can_proceed || (path.size() - scene_name.size()) >= 1;
E = E->next();
if (to_erase) {
iset.erase(to_erase);
}
}
if (!can_proceed) {
break;
}
}
}
}
Add VCS editor plugin UI elements to editor
2019-09-03 16:42:08 +02:00
void EditorNode::_version_control_menu_option(int p_idx) {
switch (vcs_actions_menu->get_item_id(p_idx)) {
Allow creating .gitignore and .gitattributes when creating a new project Also allow creating these files later, and also allow disabling creating the default environment in editor settings.
2020-09-29 21:01:26 +02:00
case RUN_VCS_METADATA: {
VersionControlEditorPlugin::get_singleton()->popup_vcs_metadata_dialog();
} break;
Add VCS editor plugin UI elements to editor
2019-09-03 16:42:08 +02:00
case RUN_VCS_SETTINGS: {
VersionControlEditorPlugin::get_singleton()->popup_vcs_set_up_dialog(gui_base);
} break;
}
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
void EditorNode::_update_title() {
Unify usage of GLOBAL/EDITOR_GET
2022-10-18 16:43:37 +02:00
const String appname = GLOBAL_GET("application/config/name");
[macOS extend-to-title] Add scene/project name to the editor title, fix incorrect window button position/order when system primary language is RTL.
2022-09-22 11:06:11 +02:00
String title = (appname.is_empty() ? TTR("Unnamed Project") : appname);
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 16:30:55 +02:00
const String edited = editor_data.get_edited_scene_root() ? editor_data.get_edited_scene_root()->get_scene_file_path() : String();
Rename empty() to is_empty()
2020-12-15 13:04:21 +01:00
if (!edited.is_empty()) {
Improve the editor window title for better usability - Display the scene name, then the project name, then "Godot Engine". - Display the "modified" mark before anytihng else. Both of these changes ensure important, project-specific elements can always be seen in the task bar which may truncate strings due to its low per-item width. - Use "Unnamed Project" if the project has no name (similar to the Project Manager).
2021-04-06 19:28:23 +02:00
// Display the edited scene name before the program name so that it can be seen in the OS task bar.
title = vformat("%s - %s", edited.get_file(), title);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
if (unsaved_cache) {
Improve the editor window title for better usability - Display the scene name, then the project name, then "Godot Engine". - Display the "modified" mark before anytihng else. Both of these changes ensure important, project-specific elements can always be seen in the task bar which may truncate strings due to its low per-item width. - Use "Unnamed Project" if the project has no name (similar to the Project Manager).
2021-04-06 19:28:23 +02:00
// Display the "modified" mark before anything else so that it can always be seen in the OS task bar.
title = vformat("(*) %s", title);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
[macOS extend-to-title] Add scene/project name to the editor title, fix incorrect window button position/order when system primary language is RTL.
2022-09-22 11:06:11 +02:00
DisplayServer::get_singleton()->window_set_title(title + String(" - ") + VERSION_NAME);
if (project_title) {
project_title->set_text(title);
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
[Input] Add extra `shortcut_input` input processing step to process Unicode character input with Alt / Ctrl modifiers, after processing of shortcuts.
2022-01-11 14:59:52 +01:00
void EditorNode::shortcut_input(const Ref<InputEvent> &p_event) {
Fix crashes in *_input functions
2021-04-05 08:52:21 +02:00
ERR_FAIL_COND(p_event.is_null());
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
Ref<InputEventKey> k = p_event;
Added EditorCommandPalette
2021-05-29 15:28:16 +02:00
if ((k.is_valid() && k->is_pressed() && !k->is_echo()) || Object::cast_to<InputEventShortcut>(*p_event)) {
Fix pressing `F3` do both changing to script editor AND find next text As `KEY_F3` was used both for changing to script editor window and, in the script editor, for finding the next result in the last search, and the key event is **not** consumed, the resulting behaviour was similar to press `F3` twice, first to change to script editor and second to find the next result of a previous search. This PR sets the `key_pressed` status of `InputEvent` to `false` if this event is responsible of an editor change, simulating the consumption of the event. Fix #17334
2018-03-13 21:20:59 +01:00
EditorPlugin *old_editor = editor_plugin_screen;
Remove Quick Filter Files and fix FS search hotkey The new Quick Filter Files behaviour since 8b47e26 had not been implemented, so this implements it and makes it an editor hotkey instead of a menu entry. Fixes #7582.
2017-01-21 13:07:29 +01:00
if (ED_IS_SHORTCUT("editor/filter_files", p_event)) {
Store panels and docks singletons in their own classes
2021-11-17 21:08:55 +01:00
FileSystemDock::get_singleton()->focus_on_filter();
Fix Filter Files shortcut input is not properly handling
2023-02-26 14:34:27 +01:00
get_tree()->get_root()->set_input_as_handled();
Remove Quick Filter Files and fix FS search hotkey The new Quick Filter Files behaviour since 8b47e26 had not been implemented, so this implements it and makes it an editor hotkey instead of a menu entry. Fixes #7582.
2017-01-21 13:07:29 +01:00
}
Added fullscreen and distraction free mode shorcuts
2016-06-15 18:25:17 +02:00
Editor: Make "open 2d/3d/script editor" shortcuts configurable. Also adds shortcuts for opening the AssetLib and for switching to the next/prev editor.
2017-05-16 21:26:32 +02:00
if (ED_IS_SHORTCUT("editor/editor_2d", p_event)) {
Port remaining connections to callable_mp
2020-12-06 16:09:18 +01:00
editor_select(EDITOR_2D);
Editor: Make "open 2d/3d/script editor" shortcuts configurable. Also adds shortcuts for opening the AssetLib and for switching to the next/prev editor.
2017-05-16 21:26:32 +02:00
} else if (ED_IS_SHORTCUT("editor/editor_3d", p_event)) {
Port remaining connections to callable_mp
2020-12-06 16:09:18 +01:00
editor_select(EDITOR_3D);
Editor: Make "open 2d/3d/script editor" shortcuts configurable. Also adds shortcuts for opening the AssetLib and for switching to the next/prev editor.
2017-05-16 21:26:32 +02:00
} else if (ED_IS_SHORTCUT("editor/editor_script", p_event)) {
Port remaining connections to callable_mp
2020-12-06 16:09:18 +01:00
editor_select(EDITOR_SCRIPT);
Editor: Make "open 2d/3d/script editor" shortcuts configurable. Also adds shortcuts for opening the AssetLib and for switching to the next/prev editor.
2017-05-16 21:26:32 +02:00
} else if (ED_IS_SHORTCUT("editor/editor_help", p_event)) {
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 23:22:52 +02:00
emit_signal(SNAME("request_help_search"), "");
[AssetLib] Fix crash in Web editor. Add EditorAssetLibrary::is_available which always returns false in the Web editor and use it in EditorNode for detection.
2022-06-29 19:27:27 +02:00
} else if (ED_IS_SHORTCUT("editor/editor_assetlib", p_event) && AssetLibraryEditorPlugin::is_available()) {
Port remaining connections to callable_mp
2020-12-06 16:09:18 +01:00
editor_select(EDITOR_ASSETLIB);
Editor: Make "open 2d/3d/script editor" shortcuts configurable. Also adds shortcuts for opening the AssetLib and for switching to the next/prev editor.
2017-05-16 21:26:32 +02:00
} else if (ED_IS_SHORTCUT("editor/editor_next", p_event)) {
_editor_select_next();
} else if (ED_IS_SHORTCUT("editor/editor_prev", p_event)) {
_editor_select_prev();
Added EditorCommandPalette
2021-05-29 15:28:16 +02:00
} else if (ED_IS_SHORTCUT("editor/command_palette", p_event)) {
_open_command_palette();
} else {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Make KEY_ESCAPE close all output/debugger docks on bottom
2018-01-19 09:04:55 +01:00
Fix pressing `F3` do both changing to script editor AND find next text As `KEY_F3` was used both for changing to script editor window and, in the script editor, for finding the next result in the last search, and the key event is **not** consumed, the resulting behaviour was similar to press `F3` twice, first to change to script editor and second to find the next result of a previous search. This PR sets the `key_pressed` status of `InputEvent` to `false` if this event is responsible of an editor change, simulating the consumption of the event. Fix #17334
2018-03-13 21:20:59 +01:00
if (old_editor != editor_plugin_screen) {
Refactored input, goes all via windows now. Also renamed Input to InputFilter because all it does is filter events.
2020-03-04 17:36:09 +01:00
get_tree()->get_root()->set_input_as_handled();
Fix pressing `F3` do both changing to script editor AND find next text As `KEY_F3` was used both for changing to script editor window and, in the script editor, for finding the next result in the last search, and the key event is **not** consumed, the resulting behaviour was similar to press `F3` twice, first to change to script editor and second to find the next result of a previous search. This PR sets the `key_pressed` status of `InputEvent` to `false` if this event is responsible of an editor change, simulating the consumption of the event. Fix #17334
2018-03-13 21:20:59 +01:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
}
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 15:06:56 +01:00
void EditorNode::_update_from_settings() {
Deprecate project_settings_changed signal
2023-08-09 17:52:01 +02:00
_update_title();
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 17:44:49 +01:00
int current_filter = GLOBAL_GET("rendering/textures/canvas_textures/default_texture_filter");
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 15:06:56 +01:00
if (current_filter != scene_root->get_default_canvas_item_texture_filter()) {
Viewport::DefaultCanvasItemTextureFilter tf = (Viewport::DefaultCanvasItemTextureFilter)current_filter;
scene_root->set_default_canvas_item_texture_filter(tf);
}
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 17:44:49 +01:00
int current_repeat = GLOBAL_GET("rendering/textures/canvas_textures/default_texture_repeat");
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 15:06:56 +01:00
if (current_repeat != scene_root->get_default_canvas_item_texture_repeat()) {
Viewport::DefaultCanvasItemTextureRepeat tr = (Viewport::DefaultCanvasItemTextureRepeat)current_repeat;
scene_root->set_default_canvas_item_texture_repeat(tr);
}
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 17:44:49 +01:00
RS::DOFBokehShape dof_shape = RS::DOFBokehShape(int(GLOBAL_GET("rendering/camera/depth_of_field/depth_of_field_bokeh_shape")));
Implement Physical Light Units as an optional setting. This allows light sources to be specified in physical light units in addition to the regular energy multiplier. In order to avoid loss of precision at high values, brightness values are premultiplied by an exposure normalization value. In support of Physical Light Units this PR also renames CameraEffects to CameraAttributes.
2022-08-01 01:20:24 +02:00
RS::get_singleton()->camera_attributes_set_dof_blur_bokeh_shape(dof_shape);
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 17:44:49 +01:00
RS::DOFBlurQuality dof_quality = RS::DOFBlurQuality(int(GLOBAL_GET("rendering/camera/depth_of_field/depth_of_field_bokeh_quality")));
bool dof_jitter = GLOBAL_GET("rendering/camera/depth_of_field/depth_of_field_use_jitter");
Implement Physical Light Units as an optional setting. This allows light sources to be specified in physical light units in addition to the regular energy multiplier. In order to avoid loss of precision at high values, brightness values are premultiplied by an exposure normalization value. In support of Physical Light Units this PR also renames CameraEffects to CameraAttributes.
2022-08-01 01:20:24 +02:00
RS::get_singleton()->camera_attributes_set_dof_blur_quality(dof_quality, dof_jitter);
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 17:44:49 +01:00
RS::get_singleton()->environment_set_ssao_quality(RS::EnvironmentSSAOQuality(int(GLOBAL_GET("rendering/environment/ssao/quality"))), GLOBAL_GET("rendering/environment/ssao/half_size"), GLOBAL_GET("rendering/environment/ssao/adaptive_target"), GLOBAL_GET("rendering/environment/ssao/blur_passes"), GLOBAL_GET("rendering/environment/ssao/fadeout_from"), GLOBAL_GET("rendering/environment/ssao/fadeout_to"));
RS::get_singleton()->screen_space_roughness_limiter_set_active(GLOBAL_GET("rendering/anti_aliasing/screen_space_roughness_limiter/enabled"), GLOBAL_GET("rendering/anti_aliasing/screen_space_roughness_limiter/amount"), GLOBAL_GET("rendering/anti_aliasing/screen_space_roughness_limiter/limit"));
bool glow_bicubic = int(GLOBAL_GET("rendering/environment/glow/upscale_mode")) > 0;
Added SSIL post processing effect
2021-08-03 09:07:32 +02:00
RS::get_singleton()->environment_set_ssil_quality(RS::EnvironmentSSILQuality(int(GLOBAL_GET("rendering/environment/ssil/quality"))), GLOBAL_GET("rendering/environment/ssil/half_size"), GLOBAL_GET("rendering/environment/ssil/adaptive_target"), GLOBAL_GET("rendering/environment/ssil/blur_passes"), GLOBAL_GET("rendering/environment/ssil/fadeout_from"), GLOBAL_GET("rendering/environment/ssil/fadeout_to"));
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 15:06:56 +01:00
RS::get_singleton()->environment_glow_set_use_bicubic_upscale(glow_bicubic);
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 17:44:49 +01:00
RS::EnvironmentSSRRoughnessQuality ssr_roughness_quality = RS::EnvironmentSSRRoughnessQuality(int(GLOBAL_GET("rendering/environment/screen_space_reflection/roughness_quality")));
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 15:06:56 +01:00
RS::get_singleton()->environment_set_ssr_roughness_quality(ssr_roughness_quality);
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 17:44:49 +01:00
RS::SubSurfaceScatteringQuality sss_quality = RS::SubSurfaceScatteringQuality(int(GLOBAL_GET("rendering/environment/subsurface_scattering/subsurface_scattering_quality")));
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 15:06:56 +01:00
RS::get_singleton()->sub_surface_scattering_set_quality(sss_quality);
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 17:44:49 +01:00
float sss_scale = GLOBAL_GET("rendering/environment/subsurface_scattering/subsurface_scattering_scale");
float sss_depth_scale = GLOBAL_GET("rendering/environment/subsurface_scattering/subsurface_scattering_depth_scale");
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 15:06:56 +01:00
RS::get_singleton()->sub_surface_scattering_set_scale(sss_scale, sss_depth_scale);
Implement Physical Light Units as an optional setting. This allows light sources to be specified in physical light units in addition to the regular energy multiplier. In order to avoid loss of precision at high values, brightness values are premultiplied by an exposure normalization value. In support of Physical Light Units this PR also renames CameraEffects to CameraAttributes.
2022-08-01 01:20:24 +02:00
uint32_t directional_shadow_size = GLOBAL_GET("rendering/lights_and_shadows/directional_shadow/size");
uint32_t directional_shadow_16_bits = GLOBAL_GET("rendering/lights_and_shadows/directional_shadow/16_bits");
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 15:06:56 +01:00
RS::get_singleton()->directional_shadow_atlas_set_size(directional_shadow_size, directional_shadow_16_bits);
Implement Physical Light Units as an optional setting. This allows light sources to be specified in physical light units in addition to the regular energy multiplier. In order to avoid loss of precision at high values, brightness values are premultiplied by an exposure normalization value. In support of Physical Light Units this PR also renames CameraEffects to CameraAttributes.
2022-08-01 01:20:24 +02:00
RS::ShadowQuality shadows_quality = RS::ShadowQuality(int(GLOBAL_GET("rendering/lights_and_shadows/positional_shadow/soft_shadow_filter_quality")));
Rename soft shadow quality project settings for easier searching `rendering/quality/shadows` is now `rendering/quality/positional_shadow` to explicitly denote that the settings only affect positional light shadows, not directional light shadows. Shadow atlas settings now contain the word "atlas" for easier searching. Soft shadow quality settings were renamed to contain the word "filter". This makes the settings appear when searching for "filter" in the project settings dialog, like in Godot 3.x.
2022-05-01 01:40:30 +02:00
RS::get_singleton()->positional_soft_shadow_filter_set_quality(shadows_quality);
Implement Physical Light Units as an optional setting. This allows light sources to be specified in physical light units in addition to the regular energy multiplier. In order to avoid loss of precision at high values, brightness values are premultiplied by an exposure normalization value. In support of Physical Light Units this PR also renames CameraEffects to CameraAttributes.
2022-08-01 01:20:24 +02:00
RS::ShadowQuality directional_shadow_quality = RS::ShadowQuality(int(GLOBAL_GET("rendering/lights_and_shadows/directional_shadow/soft_shadow_filter_quality")));
Rename soft shadow quality project settings for easier searching `rendering/quality/shadows` is now `rendering/quality/positional_shadow` to explicitly denote that the settings only affect positional light shadows, not directional light shadows. Shadow atlas settings now contain the word "atlas" for easier searching. Soft shadow quality settings were renamed to contain the word "filter". This makes the settings appear when searching for "filter" in the project settings dialog, like in Godot 3.x.
2022-05-01 01:40:30 +02:00
RS::get_singleton()->directional_soft_shadow_filter_set_quality(directional_shadow_quality);
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 17:44:49 +01:00
float probe_update_speed = GLOBAL_GET("rendering/lightmapping/probe_capture/update_speed");
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 15:06:56 +01:00
RS::get_singleton()->lightmap_set_probe_capture_update_speed(probe_update_speed);
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 17:44:49 +01:00
RS::EnvironmentSDFGIFramesToConverge frames_to_converge = RS::EnvironmentSDFGIFramesToConverge(int(GLOBAL_GET("rendering/global_illumination/sdfgi/frames_to_converge")));
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 15:06:56 +01:00
RS::get_singleton()->environment_set_sdfgi_frames_to_converge(frames_to_converge);
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 17:44:49 +01:00
RS::EnvironmentSDFGIRayCount ray_count = RS::EnvironmentSDFGIRayCount(int(GLOBAL_GET("rendering/global_illumination/sdfgi/probe_ray_count")));
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 15:06:56 +01:00
RS::get_singleton()->environment_set_sdfgi_ray_count(ray_count);
Rename GI Classes * GIProbe is now VoxelGI * BakedLightmap is now LightmapGI As godot adds more ways to provide GI (as an example, SDFGI in 4.0), the different techniques (which have different pros/cons) need to be properly named to avoid confusion.
2021-06-05 00:47:26 +02:00
RS::VoxelGIQuality voxel_gi_quality = RS::VoxelGIQuality(int(GLOBAL_GET("rendering/global_illumination/voxel_gi/quality")));
RS::get_singleton()->voxel_gi_set_quality(voxel_gi_quality);
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 17:44:49 +01:00
RS::get_singleton()->environment_set_volumetric_fog_volume_size(GLOBAL_GET("rendering/environment/volumetric_fog/volume_size"), GLOBAL_GET("rendering/environment/volumetric_fog/volume_depth"));
RS::get_singleton()->environment_set_volumetric_fog_filter_active(bool(GLOBAL_GET("rendering/environment/volumetric_fog/use_filter")));
RS::get_singleton()->canvas_set_shadow_texture_size(GLOBAL_GET("rendering/2d/shadow_atlas/size"));
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 15:06:56 +01:00
Remove duplicate project settings definitions
2022-10-20 15:43:17 +02:00
bool use_half_res_gi = GLOBAL_GET("rendering/global_illumination/gi/use_half_resolution");
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 15:06:56 +01:00
RS::get_singleton()->gi_set_use_half_resolution(use_half_res_gi);
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 17:44:49 +01:00
bool snap_2d_transforms = GLOBAL_GET("rendering/2d/snap/snap_2d_transforms_to_pixel");
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 15:06:56 +01:00
scene_root->set_snap_2d_transforms_to_pixel(snap_2d_transforms);
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 17:44:49 +01:00
bool snap_2d_vertices = GLOBAL_GET("rendering/2d/snap/snap_2d_vertices_to_pixel");
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 15:06:56 +01:00
scene_root->set_snap_2d_vertices_to_pixel(snap_2d_vertices);
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 17:44:49 +01:00
Viewport::SDFOversize sdf_oversize = Viewport::SDFOversize(int(GLOBAL_GET("rendering/2d/sdf/oversize")));
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 15:06:56 +01:00
scene_root->set_sdf_oversize(sdf_oversize);
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 17:44:49 +01:00
Viewport::SDFScale sdf_scale = Viewport::SDFScale(int(GLOBAL_GET("rendering/2d/sdf/scale")));
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 15:06:56 +01:00
scene_root->set_sdf_scale(sdf_scale);
Implement MSAA for 2D [Vulkan only]
2022-08-13 01:02:32 +02:00
Viewport::MSAA msaa = Viewport::MSAA(int(GLOBAL_GET("rendering/anti_aliasing/quality/msaa_2d")));
scene_root->set_msaa_2d(msaa);
Add option to enable HDR rendering in 2D This is needed to allow 2D to fully make use of 3D effects (e.g. glow), and can be used to substantially improve quality of 2D rendering at the cost of performance Additionally, the 2D rendering pipeline is done in linear space (we skip linear_to_srgb conversion in 3D tonemapping) so the entire Viewport can be kept linear. This is necessary for proper HDR screen support in the future.
2023-08-03 14:10:01 +02:00
bool use_hdr_2d = GLOBAL_GET("rendering/viewport/hdr_2d");
scene_root->set_use_hdr_2d(use_hdr_2d);
Rename Lod Threshold to Mesh Lod Threshold This makes it more obvious that the setting only affects mesh LOD, not manual (H)LOD achieved using visibility ranges.
2021-12-29 00:10:41 +01:00
float mesh_lod_threshold = GLOBAL_GET("rendering/mesh_lod/lod_change/threshold_pixels");
scene_root->set_mesh_lod_threshold(mesh_lod_threshold);
Implement more rendering options as specialization constants * Shadow quality settings now specialization constant. * Decal and light projector filters can be set. * Changing those settings forces re-creation of the pipelines. These changes should help improve performance related to shadow mapping, and allows improving performance by sacrificing decal and light projector quality.
2021-07-19 21:41:55 +02:00
RS::get_singleton()->decals_set_filter(RS::DecalFilter(int(GLOBAL_GET("rendering/textures/decals/filter"))));
RS::get_singleton()->light_projectors_set_filter(RS::LightProjectorFilter(int(GLOBAL_GET("rendering/textures/light_projectors/filter"))));
Update SceneTree debug colors when settings changed
2022-03-28 04:49:18 +02:00
SceneTree *tree = get_tree();
tree->set_debug_collisions_color(GLOBAL_GET("debug/shapes/collision/shape_color"));
tree->set_debug_collision_contact_color(GLOBAL_GET("debug/shapes/collision/contact_color"));
Add more detailed Navigation Debug Visualization - Adds more customization options to ProjectSettings. - Displays navregion edge connections and navigation polygon edges in editor and at runtime. - Majority of debug code moved from SceneTree to NavigationServer. - Removes the irritating debug MeshInstance child node from NavigationRegion3D and replaces it with direct RenderingServer API.
2022-07-01 18:58:03 +02:00
Deprecate project_settings_changed signal
2023-08-09 17:52:01 +02:00
ResourceImporterTexture::get_singleton()->update_imports();
Add more detailed Navigation Debug Visualization - Adds more customization options to ProjectSettings. - Displays navregion edge connections and navigation polygon edges in editor and at runtime. - Majority of debug code moved from SceneTree to NavigationServer. - Removes the irritating debug MeshInstance child node from NavigationRegion3D and replaces it with direct RenderingServer API.
2022-07-01 18:58:03 +02:00
#ifdef DEBUG_ENABLED
Rework const on NavigationServer methods `const` is used on all methods, even when they cause modification of the server. This reworks the methods of the server to only use `const` on method that don't change the state of the server.
2022-12-21 23:21:43 +01:00
NavigationServer3D::get_singleton()->set_debug_navigation_edge_connection_color(GLOBAL_GET("debug/shapes/navigation/edge_connection_color"));
NavigationServer3D::get_singleton()->set_debug_navigation_geometry_edge_color(GLOBAL_GET("debug/shapes/navigation/geometry_edge_color"));
NavigationServer3D::get_singleton()->set_debug_navigation_geometry_face_color(GLOBAL_GET("debug/shapes/navigation/geometry_face_color"));
NavigationServer3D::get_singleton()->set_debug_navigation_geometry_edge_disabled_color(GLOBAL_GET("debug/shapes/navigation/geometry_edge_disabled_color"));
NavigationServer3D::get_singleton()->set_debug_navigation_geometry_face_disabled_color(GLOBAL_GET("debug/shapes/navigation/geometry_face_disabled_color"));
NavigationServer3D::get_singleton()->set_debug_navigation_enable_edge_connections(GLOBAL_GET("debug/shapes/navigation/enable_edge_connections"));
NavigationServer3D::get_singleton()->set_debug_navigation_enable_edge_connections_xray(GLOBAL_GET("debug/shapes/navigation/enable_edge_connections_xray"));
NavigationServer3D::get_singleton()->set_debug_navigation_enable_edge_lines(GLOBAL_GET("debug/shapes/navigation/enable_edge_lines"));
NavigationServer3D::get_singleton()->set_debug_navigation_enable_edge_lines_xray(GLOBAL_GET("debug/shapes/navigation/enable_edge_lines_xray"));
NavigationServer3D::get_singleton()->set_debug_navigation_enable_geometry_face_random_color(GLOBAL_GET("debug/shapes/navigation/enable_geometry_face_random_color"));
Add more detailed Navigation Debug Visualization - Adds more customization options to ProjectSettings. - Displays navregion edge connections and navigation polygon edges in editor and at runtime. - Majority of debug code moved from SceneTree to NavigationServer. - Removes the irritating debug MeshInstance child node from NavigationRegion3D and replaces it with direct RenderingServer API.
2022-07-01 18:58:03 +02:00
#endif // DEBUG_ENABLED
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 15:06:56 +01:00
}
Implement reloading of GDExtensions
2023-08-05 03:34:14 +02:00
void EditorNode::_gdextensions_reloaded() {
// In case the developer is inspecting an object that will be changed by the reload.
InspectorDock::get_inspector_singleton()->update_tree();
}
Make default main screen plugin work even if 2D and 3D are disabled
2020-08-05 05:14:39 +02:00
void EditorNode::_select_default_main_screen_plugin() {
if (EDITOR_3D < main_editor_buttons.size() && main_editor_buttons[EDITOR_3D]->is_visible()) {
// If the 3D editor is enabled, use this as the default.
Port remaining connections to callable_mp
2020-12-06 16:09:18 +01:00
editor_select(EDITOR_3D);
Make default main screen plugin work even if 2D and 3D are disabled
2020-08-05 05:14:39 +02:00
return;
}
// Switch to the first main screen plugin that is enabled. Usually this is
// 2D, but may be subsequent ones if 2D is disabled in the feature profile.
for (int i = 0; i < main_editor_buttons.size(); i++) {
Button *editor_button = main_editor_buttons[i];
if (editor_button->is_visible()) {
Port remaining connections to callable_mp
2020-12-06 16:09:18 +01:00
editor_select(i);
Make default main screen plugin work even if 2D and 3D are disabled
2020-08-05 05:14:39 +02:00
return;
}
}
Port remaining connections to callable_mp
2020-12-06 16:09:18 +01:00
editor_select(-1);
Make default main screen plugin work even if 2D and 3D are disabled
2020-08-05 05:14:39 +02:00
}
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
void EditorNode::_update_theme(bool p_skip_creation) {
if (!p_skip_creation) {
theme = create_custom_theme(theme);
DisplayServer::set_early_window_clear_color_override(true, theme->get_color(SNAME("background"), EditorStringName(Editor)));
}
List<Ref<Theme>> editor_themes;
editor_themes.push_back(theme);
editor_themes.push_back(ThemeDB::get_singleton()->get_default_theme());
ThemeContext *node_tc = ThemeDB::get_singleton()->get_theme_context(this);
if (node_tc) {
node_tc->set_themes(editor_themes);
} else {
ThemeDB::get_singleton()->create_theme_context(this, editor_themes);
}
Window *window = get_window();
if (window) {
ThemeContext *window_tc = ThemeDB::get_singleton()->get_theme_context(window);
if (window_tc) {
window_tc->set_themes(editor_themes);
} else {
ThemeDB::get_singleton()->create_theme_context(window, editor_themes);
}
}
Add a theme preview switcher to the 2D viewport This commit adds a new View submenu that allows switching between the project theme (default), the editor theme, and the default theme. The last selected option is stored per project and is restored when reloading the project.
2023-09-06 16:11:05 +02:00
if (CanvasItemEditor::get_singleton()->get_theme_preview() == CanvasItemEditor::THEME_PREVIEW_EDITOR) {
update_preview_themes(CanvasItemEditor::THEME_PREVIEW_EDITOR);
}
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
gui_base->add_theme_style_override("panel", theme->get_stylebox(SNAME("Background"), EditorStringName(EditorStyles)));
main_vbox->set_anchors_and_offsets_preset(Control::PRESET_FULL_RECT, Control::PRESET_MODE_MINSIZE, theme->get_constant(SNAME("window_border_margin"), EditorStringName(Editor)));
main_vbox->add_theme_constant_override("separation", theme->get_constant(SNAME("top_bar_separation"), EditorStringName(Editor)));
scene_root_parent->add_theme_style_override("panel", theme->get_stylebox(SNAME("Content"), EditorStringName(EditorStyles)));
bottom_panel->add_theme_style_override("panel", theme->get_stylebox(SNAME("BottomPanel"), EditorStringName(EditorStyles)));
main_menu->add_theme_style_override("hover", theme->get_stylebox(SNAME("MenuHover"), EditorStringName(EditorStyles)));
distraction_free->set_icon(theme->get_icon(SNAME("DistractionFree"), EditorStringName(EditorIcons)));
bottom_panel_raise->set_icon(theme->get_icon(SNAME("ExpandBottomDock"), EditorStringName(EditorIcons)));
if (gui_base->is_layout_rtl()) {
dock_tab_move_left->set_icon(theme->get_icon(SNAME("Forward"), EditorStringName(EditorIcons)));
dock_tab_move_right->set_icon(theme->get_icon(SNAME("Back"), EditorStringName(EditorIcons)));
} else {
dock_tab_move_left->set_icon(theme->get_icon(SNAME("Back"), EditorStringName(EditorIcons)));
dock_tab_move_right->set_icon(theme->get_icon(SNAME("Forward"), EditorStringName(EditorIcons)));
}
help_menu->set_item_icon(help_menu->get_item_index(HELP_SEARCH), theme->get_icon(SNAME("HelpSearch"), EditorStringName(EditorIcons)));
help_menu->set_item_icon(help_menu->get_item_index(HELP_DOCS), theme->get_icon(SNAME("ExternalLink"), EditorStringName(EditorIcons)));
help_menu->set_item_icon(help_menu->get_item_index(HELP_QA), theme->get_icon(SNAME("ExternalLink"), EditorStringName(EditorIcons)));
help_menu->set_item_icon(help_menu->get_item_index(HELP_REPORT_A_BUG), theme->get_icon(SNAME("ExternalLink"), EditorStringName(EditorIcons)));
help_menu->set_item_icon(help_menu->get_item_index(HELP_COPY_SYSTEM_INFO), theme->get_icon(SNAME("ActionCopy"), EditorStringName(EditorIcons)));
help_menu->set_item_icon(help_menu->get_item_index(HELP_SUGGEST_A_FEATURE), theme->get_icon(SNAME("ExternalLink"), EditorStringName(EditorIcons)));
help_menu->set_item_icon(help_menu->get_item_index(HELP_SEND_DOCS_FEEDBACK), theme->get_icon(SNAME("ExternalLink"), EditorStringName(EditorIcons)));
help_menu->set_item_icon(help_menu->get_item_index(HELP_COMMUNITY), theme->get_icon(SNAME("ExternalLink"), EditorStringName(EditorIcons)));
help_menu->set_item_icon(help_menu->get_item_index(HELP_ABOUT), theme->get_icon(SNAME("Godot"), EditorStringName(EditorIcons)));
help_menu->set_item_icon(help_menu->get_item_index(HELP_SUPPORT_GODOT_DEVELOPMENT), theme->get_icon(SNAME("Heart"), EditorStringName(EditorIcons)));
for (int i = 0; i < main_editor_buttons.size(); i++) {
main_editor_buttons.write[i]->add_theme_font_override("font", theme->get_font(SNAME("main_button_font"), EditorStringName(EditorFonts)));
main_editor_buttons.write[i]->add_theme_font_size_override("font_size", theme->get_font_size(SNAME("main_button_font_size"), EditorStringName(EditorFonts)));
}
if (EditorDebuggerNode::get_singleton()->is_visible()) {
bottom_panel->add_theme_style_override("panel", theme->get_stylebox(SNAME("BottomPanelDebuggerOverride"), EditorStringName(EditorStyles)));
}
for (int i = 0; i < main_editor_buttons.size(); i++) {
Button *tb = main_editor_buttons[i];
EditorPlugin *p_editor = editor_table[i];
Ref<Texture2D> icon = p_editor->get_icon();
if (icon.is_valid()) {
tb->set_icon(icon);
} else if (theme->has_icon(p_editor->get_name(), EditorStringName(EditorIcons))) {
tb->set_icon(theme->get_icon(p_editor->get_name(), EditorStringName(EditorIcons)));
}
}
}
Add a theme preview switcher to the 2D viewport This commit adds a new View submenu that allows switching between the project theme (default), the editor theme, and the default theme. The last selected option is stored per project and is restored when reloading the project.
2023-09-06 16:11:05 +02:00
void EditorNode::update_preview_themes(int p_mode) {
if (!scene_root->is_inside_tree()) {
return; // Too early.
}
List<Ref<Theme>> preview_themes;
switch (p_mode) {
case CanvasItemEditor::THEME_PREVIEW_PROJECT:
preview_themes.push_back(ThemeDB::get_singleton()->get_project_theme());
break;
case CanvasItemEditor::THEME_PREVIEW_EDITOR:
preview_themes.push_back(get_editor_theme());
break;
default:
break;
}
preview_themes.push_back(ThemeDB::get_singleton()->get_default_theme());
ThemeContext *preview_context = ThemeDB::get_singleton()->get_theme_context(scene_root);
if (preview_context) {
preview_context->set_themes(preview_themes);
} else {
ThemeDB::get_singleton()->create_theme_context(scene_root, preview_themes);
}
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
void EditorNode::_notification(int p_what) {
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
switch (p_what) {
Improve threading in ClassDB and EditorHelp
2023-10-20 22:14:04 +02:00
case NOTIFICATION_POSTINITIALIZE: {
EditorHelp::generate_doc();
} break;
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
case NOTIFICATION_PROCESS: {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (opening_prev && !confirmation->is_visible()) {
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
opening_prev = false;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
-Changed Godot exit to be clean. -Added more debug information on memory cleanliness on exit (if run with -v) -Fixed several memory leaks, fixes #1731, fixes #755
2015-04-21 00:38:02 +02:00
Add EditorUndoRedoManager singleton
2022-12-23 23:53:16 +01:00
bool global_unsaved = EditorUndoRedoManager::get_singleton()->is_history_unsaved(EditorUndoRedoManager::GLOBAL_HISTORY);
bool scene_or_global_unsaved = global_unsaved || EditorUndoRedoManager::get_singleton()->is_history_unsaved(editor_data.get_current_edited_scene_history_id());
Add per-scene UndoRedo
2022-03-25 18:06:46 +01:00
if (unsaved_cache != scene_or_global_unsaved) {
unsaved_cache = scene_or_global_unsaved;
_update_title();
Update the window title when the project settings were changed or when the unsaved cache was changed (either by editing something or by saving) This makes sure that: 1.) The title is always up-to-date with project settings 2.) The title always reflects the changes made in the editor by showing or hiding the '(*)'
2022-06-22 23:45:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Add per-scene UndoRedo
2022-03-25 18:06:46 +01:00
if (editor_data.is_scene_changed(-1)) {
Extract editor scene tabs into their own component
2023-08-24 12:24:29 +02:00
scene_tabs->update_scene_tabs();
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Save all 64 bits of get_ticks_msec() in more cases
2021-10-26 08:44:50 +02:00
// Update the animation frame of the update spinner.
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
uint64_t frame = Engine::get_singleton()->get_frames_drawn();
Save all 64 bits of get_ticks_msec() in more cases
2021-10-26 08:44:50 +02:00
uint64_t tick = OS::get_singleton()->get_ticks_msec();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
if (frame != update_spinner_step_frame && (tick - update_spinner_step_msec) > (1000 / 8)) {
update_spinner_step++;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (update_spinner_step >= 8) {
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
update_spinner_step = 0;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
update_spinner_step_msec = tick;
update_spinner_step_frame = frame + 1;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Save all 64 bits of get_ticks_msec() in more cases
2021-10-26 08:44:50 +02:00
// Update the icon itself only when the spinner is visible.
Unify usage of GLOBAL/EDITOR_GET
2022-10-18 16:43:37 +02:00
if (EDITOR_GET("interface/editor/show_update_spinner")) {
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
update_spinner->set_icon(theme->get_icon("Progress" + itos(update_spinner_step + 1), EditorStringName(EditorIcons)));
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
}
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
editor_selection->update();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 15:06:56 +01:00
ResourceImporterTexture::get_singleton()->update_imports();
DOF fully implemented, can be edited on the fly.
2020-01-16 01:23:21 +01:00
Fix broken bottom panel switching
2023-01-30 21:50:00 +01:00
bottom_panel_updating = false;
Overhaul the SurfaceUpgradeTool This defers the update to a fresh restart of the editor (to ensure we aren't mid way through loading scenes anymore. It also ensures that the popup can't be used by multiple threads at once Co-authored-by: Yuri Sizov <yuris@humnom.net>
2023-10-30 15:34:18 +01:00
if (requested_first_scan) {
requested_first_scan = false;
Improve engine startup/shutdown benchmarks - Add contexts to give a better sense of benchmarked areas. - Add missing benchmarks and adjust some begin/end points. - Clean up names. - Improve Android's internal benchmarks in a similar manner. Co-authored-by: Fredia Huya-Kouadio <fhuya@meta.com>
2023-12-08 12:52:49 +01:00
OS::get_singleton()->benchmark_begin_measure("Editor", "First Scan");
Overhaul the SurfaceUpgradeTool This defers the update to a fresh restart of the editor (to ensure we aren't mid way through loading scenes anymore. It also ensures that the popup can't be used by multiple threads at once Co-authored-by: Yuri Sizov <yuris@humnom.net>
2023-10-30 15:34:18 +01:00
if (run_surface_upgrade_tool) {
run_surface_upgrade_tool = false;
SurfaceUpgradeTool::get_singleton()->connect("upgrade_finished", callable_mp(EditorFileSystem::get_singleton(), &EditorFileSystem::scan), CONNECT_ONE_SHOT);
SurfaceUpgradeTool::get_singleton()->finish_upgrade();
} else {
EditorFileSystem::get_singleton()->scan();
}
}
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
} break;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
case NOTIFICATION_ENTER_TREE: {
Refactor Node Processing * Node processing works on the concept of process groups. * A node group can be inherited, run on main thread, or a sub-thread. * Groups can be ordered. * Process priority is now present for physics. This is the first steps towards implementing https://github.com/godotengine/godot-proposals/issues/6424. No threading or thread guards exist yet in most of the scene code other than Node. That will have to be added later.
2023-04-10 18:45:53 +02:00
get_tree()->set_disable_node_threading(true); // No node threading while running editor.
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
Engine::get_singleton()->set_editor_hint(true);
Properly adjust the visible editor rect and make limits respected, closes #8328
2017-06-12 21:18:17 +02:00
Fix editor progress dialog theme update.
2023-01-13 23:24:29 +01:00
Window *window = get_window();
[macOS extend-to-title] Add scene/project name to the editor title, fix incorrect window button position/order when system primary language is RTL.
2022-09-22 11:06:11 +02:00
if (window) {
// Handle macOS fullscreen and extend-to-title changes.
window->connect("titlebar_changed", callable_mp(this, &EditorNode::_titlebar_resized));
}
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
// Theme has already been created in the constructor, so we can skip that step.
_update_theme(true);
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
OS::get_singleton()->set_low_processor_usage_mode_sleep_usec(int(EDITOR_GET("interface/editor/low_processor_mode_sleep_usec")));
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 19:31:51 +02:00
get_tree()->get_root()->set_as_audio_listener_3d(false);
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
get_tree()->get_root()->set_as_audio_listener_2d(false);
Refactor pixel snapping. -Rename pixel_snap to snap_2d_to_vertices -Added snap_2d_to_transforms which is more useful Fixes #41814 Solves proposal https://github.com/godotengine/godot-proposals/issues/1666 Supersedes #35606, supersedes #41535, supersedes #41534
2020-10-29 22:09:16 +01:00
get_tree()->get_root()->set_snap_2d_transforms_to_pixel(false);
get_tree()->get_root()->set_snap_2d_vertices_to_pixel(false);
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
get_tree()->set_auto_accept_quit(false);
Android port of the Godot Editor These set of changes focus primarily on getting the core logic and overall Godot Editor UI and functionality up and running natively on Android devices. UI tweaks / cleanup / polish, as well configuration for Android specific functionality / restrictions will be addressed in follow-up PRs iteratively based on feedback. Co-authored-by: thebestnom <shoval.arad@gmail.com>
2021-06-25 15:45:16 +02:00
#ifdef ANDROID_ENABLED
get_tree()->set_quit_on_go_back(false);
#endif
Refactored input, goes all via windows now. Also renamed Input to InputFilter because all it does is filter events.
2020-03-04 17:36:09 +01:00
get_tree()->get_root()->connect("files_dropped", callable_mp(this, &EditorNode::_dropped_files));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Added EditorCommandPalette
2021-05-29 15:28:16 +02:00
command_palette->register_shortcuts_as_command();
Add Startup benchmarking support This adds support for benchmarking engine startup (and editor startup if used). The goal is to use this in the benchmarking server to track improvements and changes to engine, editor, importer and scene loading startup times.
2022-08-19 14:21:43 +02:00
MessageQueue::get_singleton()->push_callable(callable_mp(this, &EditorNode::_begin_first_scan));
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
/* DO NOT LOAD SCENES HERE, WAIT FOR FILE SCANNING AND REIMPORT TO COMPLETE */
} break;
Adds editor_hint to Engine class
2017-08-13 16:21:45 +02:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
case NOTIFICATION_EXIT_TREE: {
Automatically reparent editor progress dialog to avoid error spam.
2023-01-11 09:13:21 +01:00
if (progress_dialog) {
progress_dialog->queue_free();
}
Automatically reparent editor message dialogs to avoid error spam.
2023-02-15 15:35:16 +01:00
if (load_error_dialog) {
load_error_dialog->queue_free();
}
if (execute_output_dialog) {
execute_output_dialog->queue_free();
}
if (warning) {
warning->queue_free();
}
if (accept) {
accept->queue_free();
}
if (save_accept) {
save_accept->queue_free();
}
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
editor_data.save_editor_external_data();
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
FileAccess::set_file_close_fail_notify_callback(nullptr);
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
log->deinit(); // Do not get messages anymore.
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
editor_data.clear_edited_scenes();
} break;
Make sure restoring opened scenes happens after scanning is done.
2019-02-27 15:00:11 +01:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
case NOTIFICATION_READY: {
Revert "Load assets before enabling editor plugins" This reverts commit 1963c63b918cdab81f10d3ab48bbb225c95b9246. Fixes #52968, fixes #52995.
2021-11-15 16:08:19 +01:00
{
Display time of last save in the unsaved changes confirmation editor dialog When multitasking, this makes it clearer whether closing a window with unsaved changes is potentially dangerous or not.
2023-08-25 01:18:05 +02:00
started_timestamp = Time::get_singleton()->get_unix_time_from_system();
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
_initializing_plugins = true;
Revert "Load assets before enabling editor plugins" This reverts commit 1963c63b918cdab81f10d3ab48bbb225c95b9246. Fixes #52968, fixes #52995.
2021-11-15 16:08:19 +01:00
Vector<String> addons;
if (ProjectSettings::get_singleton()->has_setting("editor_plugins/enabled")) {
Unify usage of GLOBAL/EDITOR_GET
2022-10-18 16:43:37 +02:00
addons = GLOBAL_GET("editor_plugins/enabled");
Revert "Load assets before enabling editor plugins" This reverts commit 1963c63b918cdab81f10d3ab48bbb225c95b9246. Fixes #52968, fixes #52995.
2021-11-15 16:08:19 +01:00
}
for (int i = 0; i < addons.size(); i++) {
set_addon_plugin_enabled(addons[i], true);
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
_initializing_plugins = false;
Retry loading addons after filesystem scan
2022-12-28 13:56:53 +01:00
if (!pending_addons.is_empty()) {
EditorFileSystem::get_singleton()->connect("script_classes_updated", callable_mp(this, &EditorNode::_enable_pending_addons));
}
Revert "Load assets before enabling editor plugins" This reverts commit 1963c63b918cdab81f10d3ab48bbb225c95b9246. Fixes #52968, fixes #52995.
2021-11-15 16:08:19 +01:00
}
Clean up RenderingServer and its bindings * Rewrote bindings for RenderingServer. * They are now all up to date. * Several unused methods and deprecated features were cleaned up.
2021-07-01 04:17:47 +02:00
RenderingServer::get_singleton()->viewport_set_disable_2d(get_scene_root()->get_viewport_rid(), true);
Remove viewport_set_disable_environment in favor of viewport_set_environment_mode This allows us to set a default value inherited by child viewports and have child viewports set the value themselves which is needed for disabling the environment in the editor
2023-01-30 01:04:39 +01:00
RenderingServer::get_singleton()->viewport_set_environment_mode(get_viewport()->get_viewport_rid(), RenderingServer::VIEWPORT_ENVIRONMENT_DISABLED);
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
feature_profile_manager->notify_changed();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Make default main screen plugin work even if 2D and 3D are disabled
2020-08-05 05:14:39 +02:00
_select_default_main_screen_plugin();
New option to send canvas to render buffer allows to use 3D environment effects for post processing such as Glow, Bloom, HDR, etc. in 2D.
2015-03-16 04:47:37 +01:00
Don't save project on startup in headless mode
2021-07-23 12:44:35 +02:00
// Save the project after opening to mark it as last modified, except in headless mode.
if (DisplayServer::get_singleton()->window_can_draw()) {
ProjectSettings::get_singleton()->save();
}
Save project after opening
2021-03-26 14:10:41 +01:00
[macOS extend-to-title] Add scene/project name to the editor title, fix incorrect window button position/order when system primary language is RTL.
2022-09-22 11:06:11 +02:00
_titlebar_resized();
Add a theme preview switcher to the 2D viewport This commit adds a new View submenu that allows switching between the project theme (default), the editor theme, and the default theme. The last selected option is stored per project and is restored when reloading the project.
2023-09-06 16:11:05 +02:00
// Set up a theme context for the 2D preview viewport using the stored preview theme.
CanvasItemEditor::ThemePreviewMode theme_preview_mode = (CanvasItemEditor::ThemePreviewMode)(int)EditorSettings::get_singleton()->get_project_metadata("2d_editor", "theme_preview", CanvasItemEditor::THEME_PREVIEW_PROJECT);
update_preview_themes(theme_preview_mode);
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
/* DO NOT LOAD SCENES HERE, WAIT FOR FILE SCANNING AND REIMPORT TO COMPLETE */
} break;
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
Add a separate application focus/in notification out from Window focus notification.
2020-06-30 01:47:18 +02:00
case NOTIFICATION_APPLICATION_FOCUS_IN: {
Add a "save on focus loss" editor setting (disabled by default) This performs a Ctrl + S action every time the editor window loses focus, saving both scenes and scripts as needed.
2021-04-11 15:39:31 +02:00
// Restore the original FPS cap after focusing back on the editor.
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
OS::get_singleton()->set_low_processor_usage_mode_sleep_usec(int(EDITOR_GET("interface/editor/low_processor_mode_sleep_usec")));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
EditorFileSystem::get_singleton()->scan_changes();
Detect external modification of scenes
2019-08-28 19:42:27 +02:00
_scan_external_changes();
Implement reloading of GDExtensions
2023-08-05 03:34:14 +02:00
GDExtensionManager *gdextension_manager = GDExtensionManager::get_singleton();
callable_mp(gdextension_manager, &GDExtensionManager::reload_extensions).call_deferred();
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
} break;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Add a separate application focus/in notification out from Window focus notification.
2020-06-30 01:47:18 +02:00
case NOTIFICATION_APPLICATION_FOCUS_OUT: {
Add a "save on focus loss" editor setting (disabled by default) This performs a Ctrl + S action every time the editor window loses focus, saving both scenes and scripts as needed.
2021-04-11 15:39:31 +02:00
// Save on focus loss before applying the FPS limit to avoid slowing down the saving process.
if (EDITOR_GET("interface/editor/save_on_focus_loss")) {
_menu_option_confirm(FILE_SAVE_SCENE, false);
}
// Set a low FPS cap to decrease CPU/GPU usage while the editor is unfocused.
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
OS::get_singleton()->set_low_processor_usage_mode_sleep_usec(int(EDITOR_GET("interface/editor/unfocused_low_processor_mode_sleep_usec")));
} break;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Refactored input, goes all via windows now. Also renamed Input to InputFilter because all it does is filter events.
2020-03-04 17:36:09 +01:00
case NOTIFICATION_WM_ABOUT: {
Remove Editor dependency from SceneTree
2019-08-05 19:46:23 +02:00
show_about();
} break;
Refactored input, goes all via windows now. Also renamed Input to InputFilter because all it does is filter events.
2020-03-04 17:36:09 +01:00
case NOTIFICATION_WM_CLOSE_REQUEST: {
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
_menu_option_confirm(FILE_QUIT, false);
} break;
Decrease the editor FPS cap when the window is unfocused This decreases CPU/GPU usage when the window is unfocused, which can be beneficial to laptop users. This also makes the low-processor mode sleep project setting no longer affect the editor. Instead, two new editor settings now define the duration of sleeping when the editor is focused and unfocused. This closes #24209 and partially addresses #29257.
2019-05-29 23:12:19 +02:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
case EditorSettings::NOTIFICATION_EDITOR_SETTINGS_CHANGED: {
Fix inconsistent file dialog settings usage * Project Manager ignores display mode settings. * EditorFileDialog's default display mode and show hidden files settings are not updated when corresponding editor settings change.
2023-04-25 02:57:22 +02:00
FileDialog::set_default_show_hidden_files(EDITOR_GET("filesystem/file_dialog/show_hidden_files"));
EditorFileDialog::set_default_show_hidden_files(EDITOR_GET("filesystem/file_dialog/show_hidden_files"));
EditorFileDialog::set_default_display_mode((EditorFileDialog::DisplayMode)EDITOR_GET("filesystem/file_dialog/display_mode").operator int());
Made use of EditorSettings 'settings changed' to optimise settings changed notifications.
2021-10-15 14:34:52 +02:00
bool theme_changed =
EditorSettings::get_singleton()->check_changed_settings_in_group("interface/theme") ||
[Editor] Fix reloading editor theme on font / font size setting change.
2022-03-21 07:20:09 +01:00
EditorSettings::get_singleton()->check_changed_settings_in_group("interface/editor/font") ||
EditorSettings::get_singleton()->check_changed_settings_in_group("interface/editor/main_font") ||
Improve icon generation in the editor theme
2022-09-16 22:34:01 +02:00
EditorSettings::get_singleton()->check_changed_settings_in_group("interface/editor/code_font") ||
Make use of a theme cache in EditorHelp and ensure it's updated - Migrates the existing cache to the standard theme cache struct - Moves some parts of the codebase to use cache instead of ad-hoc fetching - Adds hooks to editor settings previously missing from theme regeneration
2023-02-11 16:29:44 +01:00
EditorSettings::get_singleton()->check_changed_settings_in_group("text_editor/theme") ||
EditorSettings::get_singleton()->check_changed_settings_in_group("text_editor/help/help") ||
Add Output font size in Theme regeneration conditions
2023-02-21 21:45:20 +01:00
EditorSettings::get_singleton()->check_changed_settings_in_group("filesystem/file_dialog/thumbnail_size") ||
Adds a `scale_gizmo_handles` entry to the `Touchscreen` editor settings When enabled, this scales the editor icons to improve usability on touchscreen devices. In addition this commit fixes touch detection for the collision_shape_2d_editor_plugin so it scales with the icons size.
2023-04-05 22:04:00 +02:00
EditorSettings::get_singleton()->check_changed_settings_in_group("run/output/font_size") ||
EditorSettings::get_singleton()->check_changed_settings_in_group("interface/touchscreen/increase_scrollbar_touch_area") ||
EditorSettings::get_singleton()->check_changed_settings_in_group("interface/touchscreen/scale_gizmo_handles");
Made use of EditorSettings 'settings changed' to optimise settings changed notifications.
2021-10-15 14:34:52 +02:00
if (theme_changed) {
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
_update_theme();
Made use of EditorSettings 'settings changed' to optimise settings changed notifications.
2021-10-15 14:34:52 +02:00
}
Fix drop-down size when resizing font #12207 Fixes Scene > Open Recent Fixes ScriptEditor > File > Open Recent
2017-10-20 12:24:00 +02:00
Extract editor scene tabs into their own component
2023-08-24 12:24:29 +02:00
scene_tabs->update_scene_tabs();
Remove set_as_minsize()
2022-03-06 00:57:42 +01:00
recent_scenes->reset_size();
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
_build_icon_type_cache();
Update icons when theme changed
2018-02-25 17:04:16 +01:00
Add a new HashSet template * Intended to replace RBSet in most cases. * Optimized for iteration speed
2022-05-19 17:00:06 +02:00
HashSet<String> updated_textfile_extensions;
Add TextFile support across the editor
2021-09-23 23:09:15 +02:00
bool extensions_match = true;
Unify usage of GLOBAL/EDITOR_GET
2022-10-18 16:43:37 +02:00
const Vector<String> textfile_ext = ((String)(EDITOR_GET("docks/filesystem/textfile_extensions"))).split(",", false);
Add TextFile support across the editor
2021-09-23 23:09:15 +02:00
for (const String &E : textfile_ext) {
updated_textfile_extensions.insert(E);
if (extensions_match && !textfile_extensions.has(E)) {
extensions_match = false;
}
}
if (!extensions_match || updated_textfile_extensions.size() < textfile_extensions.size()) {
textfile_extensions = updated_textfile_extensions;
EditorFileSystem::get_singleton()->scan();
}
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
_update_update_spinner();
} break;
add scene button and tab scrolling
2017-11-16 23:57:57 +01:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Make visibility of update spinner editor-wide, hidden by default - Make visibility of the spinner and "update always" option editor-wide, rather than per-project metadata. - Add options "Show Update Spinner" and "Update Continuously" under Editor Settings > Interface > Editor. Both options are false by default. - Rename some variables and constants to be more consistent and clearer: "update always" -> "update continuously", "update changes" -> "update when changed", "update menu" -> "update spinner", "circle" -> "update spinner". Fixes #23738.
2018-12-11 16:52:25 +01:00
void EditorNode::_update_update_spinner() {
Disable update spinner when debug redraw is active
2023-10-11 13:21:29 +02:00
update_spinner->set_visible(!RenderingServer::get_singleton()->canvas_item_get_debug_redraw() && EDITOR_GET("interface/editor/show_update_spinner"));
Make visibility of update spinner editor-wide, hidden by default - Make visibility of the spinner and "update always" option editor-wide, rather than per-project metadata. - Add options "Show Update Spinner" and "Update Continuously" under Editor Settings > Interface > Editor. Both options are false by default. - Rename some variables and constants to be more consistent and clearer: "update always" -> "update continuously", "update changes" -> "update when changed", "update menu" -> "update spinner", "circle" -> "update spinner". Fixes #23738.
2018-12-11 16:52:25 +01:00
Unify usage of GLOBAL/EDITOR_GET
2022-10-18 16:43:37 +02:00
const bool update_continuously = EDITOR_GET("interface/editor/update_continuously");
Make visibility of update spinner editor-wide, hidden by default - Make visibility of the spinner and "update always" option editor-wide, rather than per-project metadata. - Add options "Show Update Spinner" and "Update Continuously" under Editor Settings > Interface > Editor. Both options are false by default. - Rename some variables and constants to be more consistent and clearer: "update always" -> "update continuously", "update changes" -> "update when changed", "update menu" -> "update spinner", "circle" -> "update spinner". Fixes #23738.
2018-12-11 16:52:25 +01:00
PopupMenu *update_popup = update_spinner->get_popup();
update_popup->set_item_checked(update_popup->get_item_index(SETTINGS_UPDATE_CONTINUOUSLY), update_continuously);
update_popup->set_item_checked(update_popup->get_item_index(SETTINGS_UPDATE_WHEN_CHANGED), !update_continuously);
Change the editor update spinner color when updating continuously Updating continuously should only be enabled for troubleshooting purposes, as it uses a lot of CPU/GPU power. The update spinner is now displayed in red when the Update Continuously editor setting is enabled.
2021-08-03 17:22:46 +02:00
if (update_continuously) {
Rename `hint_tooltip` to `tooltip_text` & setget `hint_tooltip` -> `tooltip_text` `set_tooltip` -> `set_tooltip_text` `_get_tooltip` -> `get_tooltip_text` Updates documentation, too.
2022-08-25 12:42:17 +02:00
update_spinner->set_tooltip_text(TTR("Spins when the editor window redraws.\nUpdate Continuously is enabled, which can increase power usage. Click to disable it."));
Change the editor update spinner color when updating continuously Updating continuously should only be enabled for troubleshooting purposes, as it uses a lot of CPU/GPU power. The update spinner is now displayed in red when the Update Continuously editor setting is enabled.
2021-08-03 17:22:46 +02:00
// Use a different color for the update spinner when Update Continuously is enabled,
// as this feature should only be enabled for troubleshooting purposes.
// Make the icon modulate color overbright because icons are not completely white on a dark theme.
// On a light theme, icons are dark, so we need to modulate them with an even brighter color.
const bool dark_theme = EditorSettings::get_singleton()->is_dark_theme();
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
update_spinner->set_self_modulate(theme->get_color(SNAME("error_color"), EditorStringName(Editor)) * (dark_theme ? Color(1.1, 1.1, 1.1) : Color(4.25, 4.25, 4.25)));
Change the editor update spinner color when updating continuously Updating continuously should only be enabled for troubleshooting purposes, as it uses a lot of CPU/GPU power. The update spinner is now displayed in red when the Update Continuously editor setting is enabled.
2021-08-03 17:22:46 +02:00
} else {
Rename `hint_tooltip` to `tooltip_text` & setget `hint_tooltip` -> `tooltip_text` `set_tooltip` -> `set_tooltip_text` `_get_tooltip` -> `get_tooltip_text` Updates documentation, too.
2022-08-25 12:42:17 +02:00
update_spinner->set_tooltip_text(TTR("Spins when the editor window redraws."));
Change the editor update spinner color when updating continuously Updating continuously should only be enabled for troubleshooting purposes, as it uses a lot of CPU/GPU power. The update spinner is now displayed in red when the Update Continuously editor setting is enabled.
2021-08-03 17:22:46 +02:00
update_spinner->set_self_modulate(Color(1, 1, 1));
}
Make visibility of update spinner editor-wide, hidden by default - Make visibility of the spinner and "update always" option editor-wide, rather than per-project metadata. - Add options "Show Update Spinner" and "Update Continuously" under Editor Settings > Interface > Editor. Both options are false by default. - Rename some variables and constants to be more consistent and clearer: "update always" -> "update continuously", "update changes" -> "update when changed", "update menu" -> "update spinner", "circle" -> "update spinner". Fixes #23738.
2018-12-11 16:52:25 +01:00
OS::get_singleton()->set_low_processor_usage_mode(!update_continuously);
}
Add PluginConfigDialog, EditorPluginSettings GUI
2018-07-19 17:34:22 +02:00
void EditorNode::_on_plugin_ready(Object *p_script, const String &p_activate_name) {
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-09-29 11:53:28 +02:00
Ref<Script> scr = Object::cast_to<Script>(p_script);
if (scr.is_null()) {
Add PluginConfigDialog, EditorPluginSettings GUI
2018-07-19 17:34:22 +02:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Minor fixes/refactoring of project and editor setting dialogs
2022-02-01 00:19:01 +01:00
project_settings_editor->update_plugins();
project_settings_editor->hide();
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-09-29 11:53:28 +02:00
push_item(scr.operator->());
Enable new addon after hiding ProjectSettings - Enabling newly created addons can show a warning dialog, doing so before hiding the `ProjectSettingsEditor` dialog causes rendering glitches. - Remove unused `PuginConfigDialog` in `EditorNode`. The one actually being used is an instance in `EditorPluginSettings`.
2023-10-18 20:20:46 +02:00
if (p_activate_name.length()) {
set_addon_plugin_enabled(p_activate_name, true);
}
Add PluginConfigDialog, EditorPluginSettings GUI
2018-07-19 17:34:22 +02:00
}
Remove plugin from enabled if there's an error inform user in warning message Co-authored-by: Rémi Verschelde <rverschelde@gmail.com> Refactor remove plugin from enabled
2021-05-09 14:17:15 +02:00
void EditorNode::_remove_plugin_from_enabled(const String &p_name) {
ProjectSettings *ps = ProjectSettings::get_singleton();
PackedStringArray enabled_plugins = ps->get("editor_plugins/enabled");
for (int i = 0; i < enabled_plugins.size(); ++i) {
if (enabled_plugins.get(i) == p_name) {
Rename `remove()` to `remove_at()` when removing by index
2021-07-04 00:17:03 +02:00
enabled_plugins.remove_at(i);
Remove plugin from enabled if there's an error inform user in warning message Co-authored-by: Rémi Verschelde <rverschelde@gmail.com> Refactor remove plugin from enabled
2021-05-09 14:17:15 +02:00
break;
}
}
ps->set("editor_plugins/enabled", enabled_plugins);
}
More fixes to over plugin handling
2023-02-06 15:35:33 +01:00
void EditorNode::_plugin_over_edit(EditorPlugin *p_plugin, Object *p_object) {
if (p_object) {
editor_plugins_over->add_plugin(p_plugin);
p_plugin->make_visible(true);
p_plugin->edit(p_object);
} else {
editor_plugins_over->remove_plugin(p_plugin);
p_plugin->make_visible(false);
p_plugin->edit(nullptr);
}
}
Allow contextual plugins to persist temporarily
2023-09-10 21:29:28 +02:00
void EditorNode::_plugin_over_self_own(EditorPlugin *p_plugin) {
active_plugins[p_plugin->get_instance_id()].insert(p_plugin);
}
PoolVector is gone, replaced by Vector Typed `PoolTypeArray` types are now renamed `PackedTypeArray` and are sugar for `Vector<Type>`.
2020-02-17 22:06:54 +01:00
void EditorNode::_resources_changed(const Vector<String> &p_resources) {
Style: Set clang-format Standard to Cpp11 For us, it practically only changes the fact that `A<A<int>>` is now used instead of the C++03 compatible `A<A<int> >`. Note: clang-format 10+ changed the `Standard` arguments to fully specified `c++11`, `c++14`, etc. versions, but we can't use `c++17` now if we want to preserve compatibility with clang-format 8 and 9. `Cpp11` is still supported as deprecated alias for `Latest`.
2020-03-17 07:33:00 +01:00
List<Ref<Resource>> changed;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Reworked how non-imported resources are reloaded on change, fixes #19852
2018-11-21 01:47:48 +01:00
int rc = p_resources.size();
for (int i = 0; i < rc; i++) {
Remake resource thread safety and API * Ensures thread safety when resources are destroyed. * Simplified API by always forcing `ResourceCache::get_ref`, which needs less hacks and is fully thread safe. * Removed RWLock for resources because its not possible to use for the new logic. Should not be a problem. Supersedes #57533
2022-06-22 13:46:46 +02:00
Ref<Resource> res = ResourceCache::get_ref(p_resources.get(i));
Reworked how non-imported resources are reloaded on change, fixes #19852
2018-11-21 01:47:48 +01:00
if (res.is_null()) {
continue;
}
work in progress, resource previews
2015-05-31 06:59:42 +02:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!res->editor_can_reload_from_file()) {
Reworked how non-imported resources are reloaded on change, fixes #19852
2018-11-21 01:47:48 +01:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Rename `String.is_abs_path()` to `String.is_absolute_path()` This is more consistent with `NodePath.is_absolute()`.
2021-06-03 15:41:22 +02:00
if (!res->get_path().is_resource_file() && !res->get_path().is_absolute_path()) {
Reworked how non-imported resources are reloaded on change, fixes #19852
2018-11-21 01:47:48 +01:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
if (!FileAccess::exists(res->get_path())) {
Reworked how non-imported resources are reloaded on change, fixes #19852
2018-11-21 01:47:48 +01:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
export from command line
2016-02-10 07:41:48 +01:00
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 10:42:46 +01:00
if (!res->get_import_path().is_empty()) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// This is an imported resource, will be reloaded if reimported via the _resources_reimported() callback.
Reworked how non-imported resources are reloaded on change, fixes #19852
2018-11-21 01:47:48 +01:00
continue;
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Reworked how non-imported resources are reloaded on change, fixes #19852
2018-11-21 01:47:48 +01:00
changed.push_back(res);
}
Changed import workflow -Rearrange favorites in fs dock with drag and drop -Removed import -> sub-scene, moved to scenetree contextual menu -Removed import -> re-import , moved and integrated to FS dock -Added ability in FS dock to re-import more than one resource simultaneously -Added ability to drag from native filesystem explorer to Godot, only works on Windows though -Removed scene reimport merge options, never worked well. Eventually merging materials should be re-added -Added ability to set custom root node type when importing scenes -Re-Import is now automatic, can be configured back to manual in editor settings -Added resource previews in property list for many resource types
2016-05-27 19:18:40 +02:00
Reworked how non-imported resources are reloaded on change, fixes #19852
2018-11-21 01:47:48 +01:00
if (changed.size()) {
Use Ref<T> references as iterators where relevant And const when possible.
2021-07-26 17:50:35 +02:00
for (Ref<Resource> &res : changed) {
res->reload_from_file();
Reworked how non-imported resources are reloaded on change, fixes #19852
2018-11-21 01:47:48 +01:00
}
}
}
Changed import workflow -Rearrange favorites in fs dock with drag and drop -Removed import -> sub-scene, moved to scenetree contextual menu -Removed import -> re-import , moved and integrated to FS dock -Added ability in FS dock to re-import more than one resource simultaneously -Added ability to drag from native filesystem explorer to Godot, only works on Windows though -Removed scene reimport merge options, never worked well. Eventually merging materials should be re-added -Added ability to set custom root node type when importing scenes -Re-Import is now automatic, can be configured back to manual in editor settings -Added resource previews in property list for many resource types
2016-05-27 19:18:40 +02:00
Reworked how non-imported resources are reloaded on change, fixes #19852
2018-11-21 01:47:48 +01:00
void EditorNode::_fs_changed() {
Use range iterators for RBSet in most cases
2022-05-19 01:43:40 +02:00
for (FileDialog *E : file_dialogs) {
E->invalidate();
Reworked how non-imported resources are reloaded on change, fixes #19852
2018-11-21 01:47:48 +01:00
}
Changed import workflow -Rearrange favorites in fs dock with drag and drop -Removed import -> sub-scene, moved to scenetree contextual menu -Removed import -> re-import , moved and integrated to FS dock -Added ability in FS dock to re-import more than one resource simultaneously -Added ability to drag from native filesystem explorer to Godot, only works on Windows though -Removed scene reimport merge options, never worked well. Eventually merging materials should be re-added -Added ability to set custom root node type when importing scenes -Re-Import is now automatic, can be configured back to manual in editor settings -Added resource previews in property list for many resource types
2016-05-27 19:18:40 +02:00
Use range iterators for RBSet in most cases
2022-05-19 01:43:40 +02:00
for (EditorFileDialog *E : editor_file_dialogs) {
E->invalidate();
Changed import workflow -Rearrange favorites in fs dock with drag and drop -Removed import -> sub-scene, moved to scenetree contextual menu -Removed import -> re-import , moved and integrated to FS dock -Added ability in FS dock to re-import more than one resource simultaneously -Added ability to drag from native filesystem explorer to Godot, only works on Windows though -Removed scene reimport merge options, never worked well. Eventually merging materials should be re-added -Added ability to set custom root node type when importing scenes -Re-Import is now automatic, can be configured back to manual in editor settings -Added resource previews in property list for many resource types
2016-05-27 19:18:40 +02:00
}
EditorNode: mark opened deleted scenes as unsaved
2017-06-29 19:37:54 +02:00
_mark_unsaved_scenes();
Perform export after import is fully complete Previously command line export would go simultaneously with reimport, which caused final package to either miss something or contain outdated assets or perhaps even broken ones.
2017-12-30 10:39:09 +01:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// FIXME: Move this to a cleaner location, it's hacky to do this in _fs_changed.
Export: Improve usability of command line interface I'm barely scratching the surface of the changes needed to make the --export command line interface easy to use, but this should already improve things somewhat. - Streamline `can_export()` templates check in all platforms, checking first for the presence of official templates, then of any defined custom template, and reporting on the absence of any. Shouldn't change the actual return value much which is still true if either release or debug is usable - we might want to change that eventually and better validate against the requested target. - Fix discrepancy between platforms using `custom_package/debug` and `custom_template/debug` (resp. `release`). All now use `custom_template`, which will break compatibility for `export_presets.cfg` with earlier projects (but is easy to fix). - Use `can_export()` when attempting a command line export and report the same errors that would be shown in the editor. - Improve error reporting after a failed export attempt, handling missing template and invalid path more gracefully. - Cleanup of unused stuff in EditorNode around the export workflow. - Improve --export documentation in --help a bit. Fixes #16949 (at least many of the misunderstandings listed there). Fixes #18470.
2020-01-07 13:29:02 +01:00
String export_error;
[Command line export] return 0 exit code when export is finished with warnings.
2022-07-10 22:39:16 +02:00
Error err = OK;
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 10:42:46 +01:00
if (!export_defer.preset.is_empty() && !EditorFileSystem::get_singleton()->is_scanning()) {
Export: Improve usability of command line interface I'm barely scratching the surface of the changes needed to make the --export command line interface easy to use, but this should already improve things somewhat. - Streamline `can_export()` templates check in all platforms, checking first for the presence of official templates, then of any defined custom template, and reporting on the absence of any. Shouldn't change the actual return value much which is still true if either release or debug is usable - we might want to change that eventually and better validate against the requested target. - Fix discrepancy between platforms using `custom_package/debug` and `custom_template/debug` (resp. `release`). All now use `custom_template`, which will break compatibility for `export_presets.cfg` with earlier projects (but is easy to fix). - Use `can_export()` when attempting a command line export and report the same errors that would be shown in the editor. - Improve error reporting after a failed export attempt, handling missing template and invalid path more gracefully. - Cleanup of unused stuff in EditorNode around the export workflow. - Improve --export documentation in --help a bit. Fixes #16949 (at least many of the misunderstandings listed there). Fixes #18470.
2020-01-07 13:29:02 +01:00
String preset_name = export_defer.preset;
// Ensures export_project does not loop infinitely, because notifications may
// come during the export.
export_defer.preset = "";
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
Ref<EditorExportPreset> export_preset;
Perform export after import is fully complete Previously command line export would go simultaneously with reimport, which caused final package to either miss something or contain outdated assets or perhaps even broken ones.
2017-12-30 10:39:09 +01:00
for (int i = 0; i < EditorExport::get_singleton()->get_export_preset_count(); ++i) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
export_preset = EditorExport::get_singleton()->get_export_preset(i);
if (export_preset->get_name() == preset_name) {
Perform export after import is fully complete Previously command line export would go simultaneously with reimport, which caused final package to either miss something or contain outdated assets or perhaps even broken ones.
2017-12-30 10:39:09 +01:00
break;
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
export_preset.unref();
Perform export after import is fully complete Previously command line export would go simultaneously with reimport, which caused final package to either miss something or contain outdated assets or perhaps even broken ones.
2017-12-30 10:39:09 +01:00
}
Improve error messages for missing export presets when using `--export` - Display a specific error message if the project doesn't have an `export_presets.cfg` file. - Display a list of detected export presets if an invalid export preset name is supplied.
2021-04-06 01:44:15 +02:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
if (export_preset.is_null()) {
Make FileAccess and DirAccess classes reference counted.
2022-03-23 10:08:58 +01:00
Ref<DirAccess> da = DirAccess::create(DirAccess::ACCESS_RESOURCES);
Improve error messages for missing export presets when using `--export` - Display a specific error message if the project doesn't have an `export_presets.cfg` file. - Display a list of detected export presets if an invalid export preset name is supplied.
2021-04-06 01:44:15 +02:00
if (da->file_exists("res://export_presets.cfg")) {
[Command line export] return 0 exit code when export is finished with warnings.
2022-07-10 22:39:16 +02:00
err = FAILED;
Improve error messages for missing export presets when using `--export` - Display a specific error message if the project doesn't have an `export_presets.cfg` file. - Display a list of detected export presets if an invalid export preset name is supplied.
2021-04-06 01:44:15 +02:00
export_error = vformat(
"Invalid export preset name: %s.\nThe following presets were detected in this project's `export_presets.cfg`:\n\n",
preset_name);
for (int i = 0; i < EditorExport::get_singleton()->get_export_preset_count(); ++i) {
// Write the preset name between double quotes since it needs to be written between quotes on the command line if it contains spaces.
export_error += vformat(" \"%s\"\n", EditorExport::get_singleton()->get_export_preset(i)->get_name());
}
} else {
[Command line export] return 0 exit code when export is finished with warnings.
2022-07-10 22:39:16 +02:00
err = FAILED;
Improve error messages for missing export presets when using `--export` - Display a specific error message if the project doesn't have an `export_presets.cfg` file. - Display a list of detected export presets if an invalid export preset name is supplied.
2021-04-06 01:44:15 +02:00
export_error = "This project doesn't have an `export_presets.cfg` file at its root.\nCreate an export preset from the \"Project > Export\" dialog and try again.";
}
Perform export after import is fully complete Previously command line export would go simultaneously with reimport, which caused final package to either miss something or contain outdated assets or perhaps even broken ones.
2017-12-30 10:39:09 +01:00
} else {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
Ref<EditorExportPlatform> platform = export_preset->get_platform();
const String export_path = export_defer.path.is_empty() ? export_preset->get_export_path() : export_defer.path;
Rename empty() to is_empty()
2020-12-15 13:04:21 +01:00
if (export_path.is_empty()) {
[Command line export] return 0 exit code when export is finished with warnings.
2022-07-10 22:39:16 +02:00
err = FAILED;
Improve error messages for missing export presets when using `--export` - Display a specific error message if the project doesn't have an `export_presets.cfg` file. - Display a list of detected export presets if an invalid export preset name is supplied.
2021-04-06 01:44:15 +02:00
export_error = vformat("Export preset \"%s\" doesn't have a default export path, and none was specified.", preset_name);
Fix CLI export when export_path is in preset. Export presets contains the export_path option, to specify the default export location, but the CLI export option disregarded that, and always required and export path to be specified. After this commit, if the export path is not specified in the command, the one in the preset will be used, erroring only if it's not present or invalid.
2020-11-17 18:02:41 +01:00
} else if (platform.is_null()) {
[Command line export] return 0 exit code when export is finished with warnings.
2022-07-10 22:39:16 +02:00
err = FAILED;
Improve error messages for missing export presets when using `--export` - Display a specific error message if the project doesn't have an `export_presets.cfg` file. - Display a list of detected export presets if an invalid export preset name is supplied.
2021-04-06 01:44:15 +02:00
export_error = vformat("Export preset \"%s\" doesn't have a matching platform.", preset_name);
Perform export after import is fully complete Previously command line export would go simultaneously with reimport, which caused final package to either miss something or contain outdated assets or perhaps even broken ones.
2017-12-30 10:39:09 +01:00
} else {
Export: Add dedicated --export-pack option to export data pack The previous behavior relying on the provided extension was problematic on macOS since .zip is the main extension used for the full project export (binary + data pack). We add a dedicated `--export-pack` command line option to define when only the data pack should be exported. Its extension will still be inferred from the path. Fixes #23073.
2020-01-08 14:22:50 +01:00
if (export_defer.pack_only) { // Only export .pck or .zip data pack.
Fix CLI export when export_path is in preset. Export presets contains the export_path option, to specify the default export location, but the CLI export option disregarded that, and always required and export path to be specified. After this commit, if the export path is not specified in the command, the one in the preset will be used, erroring only if it's not present or invalid.
2020-11-17 18:02:41 +01:00
if (export_path.ends_with(".zip")) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
err = platform->export_zip(export_preset, export_defer.debug, export_path);
Fix CLI export when export_path is in preset. Export presets contains the export_path option, to specify the default export location, but the CLI export option disregarded that, and always required and export path to be specified. After this commit, if the export path is not specified in the command, the one in the preset will be used, erroring only if it's not present or invalid.
2020-11-17 18:02:41 +01:00
} else if (export_path.ends_with(".pck")) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
err = platform->export_pack(export_preset, export_defer.debug, export_path);
Perform export after import is fully complete Previously command line export would go simultaneously with reimport, which caused final package to either miss something or contain outdated assets or perhaps even broken ones.
2017-12-30 10:39:09 +01:00
}
Export: Improve usability of command line interface I'm barely scratching the surface of the changes needed to make the --export command line interface easy to use, but this should already improve things somewhat. - Streamline `can_export()` templates check in all platforms, checking first for the presence of official templates, then of any defined custom template, and reporting on the absence of any. Shouldn't change the actual return value much which is still true if either release or debug is usable - we might want to change that eventually and better validate against the requested target. - Fix discrepancy between platforms using `custom_package/debug` and `custom_template/debug` (resp. `release`). All now use `custom_template`, which will break compatibility for `export_presets.cfg` with earlier projects (but is easy to fix). - Use `can_export()` when attempting a command line export and report the same errors that would be shown in the editor. - Improve error reporting after a failed export attempt, handling missing template and invalid path more gracefully. - Cleanup of unused stuff in EditorNode around the export workflow. - Improve --export documentation in --help a bit. Fixes #16949 (at least many of the misunderstandings listed there). Fixes #18470.
2020-01-07 13:29:02 +01:00
} else { // Normal project export.
String config_error;
bool missing_templates;
Add option to install android build template for export This PR adds a new "--install-android-build-template" command-line option which causes the android build template to be installed before exporting the project.
2023-12-06 05:35:52 +01:00
if (export_defer.android_build_template) {
export_template_manager->install_android_template();
}
Allow exporting release Android builds without a debug keystore
2023-06-11 19:01:39 +02:00
if (!platform->can_export(export_preset, config_error, missing_templates, export_defer.debug)) {
Improve error messages for missing export presets when using `--export` - Display a specific error message if the project doesn't have an `export_presets.cfg` file. - Display a list of detected export presets if an invalid export preset name is supplied.
2021-04-06 01:44:15 +02:00
ERR_PRINT(vformat("Cannot export project with preset \"%s\" due to configuration errors:\n%s", preset_name, config_error));
Export: Improve usability of command line interface I'm barely scratching the surface of the changes needed to make the --export command line interface easy to use, but this should already improve things somewhat. - Streamline `can_export()` templates check in all platforms, checking first for the presence of official templates, then of any defined custom template, and reporting on the absence of any. Shouldn't change the actual return value much which is still true if either release or debug is usable - we might want to change that eventually and better validate against the requested target. - Fix discrepancy between platforms using `custom_package/debug` and `custom_template/debug` (resp. `release`). All now use `custom_template`, which will break compatibility for `export_presets.cfg` with earlier projects (but is easy to fix). - Use `can_export()` when attempting a command line export and report the same errors that would be shown in the editor. - Improve error reporting after a failed export attempt, handling missing template and invalid path more gracefully. - Cleanup of unused stuff in EditorNode around the export workflow. - Improve --export documentation in --help a bit. Fixes #16949 (at least many of the misunderstandings listed there). Fixes #18470.
2020-01-07 13:29:02 +01:00
err = missing_templates ? ERR_FILE_NOT_FOUND : ERR_UNCONFIGURED;
} else {
Add readable export errors.
2022-06-03 17:34:24 +02:00
platform->clear_messages();
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
err = platform->export_project(export_preset, export_defer.debug, export_path);
Export: Improve usability of command line interface I'm barely scratching the surface of the changes needed to make the --export command line interface easy to use, but this should already improve things somewhat. - Streamline `can_export()` templates check in all platforms, checking first for the presence of official templates, then of any defined custom template, and reporting on the absence of any. Shouldn't change the actual return value much which is still true if either release or debug is usable - we might want to change that eventually and better validate against the requested target. - Fix discrepancy between platforms using `custom_package/debug` and `custom_template/debug` (resp. `release`). All now use `custom_template`, which will break compatibility for `export_presets.cfg` with earlier projects (but is easy to fix). - Use `can_export()` when attempting a command line export and report the same errors that would be shown in the editor. - Improve error reporting after a failed export attempt, handling missing template and invalid path more gracefully. - Cleanup of unused stuff in EditorNode around the export workflow. - Improve --export documentation in --help a bit. Fixes #16949 (at least many of the misunderstandings listed there). Fixes #18470.
2020-01-07 13:29:02 +01:00
}
Explicitly print an error when --export fails. Previously this would not explicitly say the export failed. Sure you might see another error somewhere, but that's not very reliable/obvious.
2018-04-04 16:13:06 +02:00
}
Add readable export errors.
2022-06-03 17:34:24 +02:00
if (err != OK) {
export_error = vformat("Project export for preset \"%s\" failed.", preset_name);
} else if (platform->get_worst_message_type() >= EditorExportPlatform::EXPORT_MESSAGE_WARNING) {
[Command line export] return 0 exit code when export is finished with warnings.
2022-07-10 22:39:16 +02:00
export_error = vformat("Project export for preset \"%s\" completed with warnings.", preset_name);
Perform export after import is fully complete Previously command line export would go simultaneously with reimport, which caused final package to either miss something or contain outdated assets or perhaps even broken ones.
2017-12-30 10:39:09 +01:00
}
}
}
[Command line export] return 0 exit code when export is finished with warnings.
2022-07-10 22:39:16 +02:00
if (err != OK) {
Export: Improve usability of command line interface I'm barely scratching the surface of the changes needed to make the --export command line interface easy to use, but this should already improve things somewhat. - Streamline `can_export()` templates check in all platforms, checking first for the presence of official templates, then of any defined custom template, and reporting on the absence of any. Shouldn't change the actual return value much which is still true if either release or debug is usable - we might want to change that eventually and better validate against the requested target. - Fix discrepancy between platforms using `custom_package/debug` and `custom_template/debug` (resp. `release`). All now use `custom_template`, which will break compatibility for `export_presets.cfg` with earlier projects (but is easy to fix). - Use `can_export()` when attempting a command line export and report the same errors that would be shown in the editor. - Improve error reporting after a failed export attempt, handling missing template and invalid path more gracefully. - Cleanup of unused stuff in EditorNode around the export workflow. - Improve --export documentation in --help a bit. Fixes #16949 (at least many of the misunderstandings listed there). Fixes #18470.
2020-01-07 13:29:02 +01:00
ERR_PRINT(export_error);
Replace use of `OS::set_exit_code()` by `SceneTree::quit()` in `EditorNode`
2022-01-18 12:48:12 +01:00
_exit_editor(EXIT_FAILURE);
[Command line export] return 0 exit code when export is finished with warnings.
2022-07-10 22:39:16 +02:00
} else if (!export_error.is_empty()) {
WARN_PRINT(export_error);
Export: Improve usability of command line interface I'm barely scratching the surface of the changes needed to make the --export command line interface easy to use, but this should already improve things somewhat. - Streamline `can_export()` templates check in all platforms, checking first for the presence of official templates, then of any defined custom template, and reporting on the absence of any. Shouldn't change the actual return value much which is still true if either release or debug is usable - we might want to change that eventually and better validate against the requested target. - Fix discrepancy between platforms using `custom_package/debug` and `custom_template/debug` (resp. `release`). All now use `custom_template`, which will break compatibility for `export_presets.cfg` with earlier projects (but is easy to fix). - Use `can_export()` when attempting a command line export and report the same errors that would be shown in the editor. - Improve error reporting after a failed export attempt, handling missing template and invalid path more gracefully. - Cleanup of unused stuff in EditorNode around the export workflow. - Improve --export documentation in --help a bit. Fixes #16949 (at least many of the misunderstandings listed there). Fixes #18470.
2020-01-07 13:29:02 +01:00
}
[Command line export] return 0 exit code when export is finished with warnings.
2022-07-10 22:39:16 +02:00
_exit_editor(EXIT_SUCCESS);
Perform export after import is fully complete Previously command line export would go simultaneously with reimport, which caused final package to either miss something or contain outdated assets or perhaps even broken ones.
2017-12-30 10:39:09 +01:00
}
Lot of work in new importer, importing textures now works.
2017-02-01 13:45:45 +01:00
}
Changed import workflow -Rearrange favorites in fs dock with drag and drop -Removed import -> sub-scene, moved to scenetree contextual menu -Removed import -> re-import , moved and integrated to FS dock -Added ability in FS dock to re-import more than one resource simultaneously -Added ability to drag from native filesystem explorer to Godot, only works on Windows though -Removed scene reimport merge options, never worked well. Eventually merging materials should be re-added -Added ability to set custom root node type when importing scenes -Re-Import is now automatic, can be configured back to manual in editor settings -Added resource previews in property list for many resource types
2016-05-27 19:18:40 +02:00
Fix issues regarding reload of resources in imported scenes. Closes #10017
2017-08-31 23:57:03 +02:00
void EditorNode::_resources_reimported(const Vector<String> &p_resources) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
List<String> scenes;
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 05:36:23 +02:00
int current_tab = scene_tabs->get_current_tab();
Fix issues regarding reload of resources in imported scenes. Closes #10017
2017-08-31 23:57:03 +02:00
for (int i = 0; i < p_resources.size(); i++) {
String file_type = ResourceLoader::get_resource_type(p_resources[i]);
if (file_type == "PackedScene") {
scenes.push_back(p_resources[i]);
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Reload later if needed, first go with normal resources.
Fix issues regarding reload of resources in imported scenes. Closes #10017
2017-08-31 23:57:03 +02:00
continue;
}
if (!ResourceCache::has(p_resources[i])) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Not loaded, no need to reload.
continue;
Fix issues regarding reload of resources in imported scenes. Closes #10017
2017-08-31 23:57:03 +02:00
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Reload normally.
Remake resource thread safety and API * Ensures thread safety when resources are destroyed. * Simplified API by always forcing `ResourceCache::get_ref`, which needs less hacks and is fully thread safe. * Removed RWLock for resources because its not possible to use for the new logic. Should not be a problem. Supersedes #57533
2022-06-22 13:46:46 +02:00
Ref<Resource> resource = ResourceCache::get_ref(p_resources[i]);
if (resource.is_valid()) {
Fix issues regarding reload of resources in imported scenes. Closes #10017
2017-08-31 23:57:03 +02:00
resource->reload_from_file();
}
}
Fix Editor crash when re-importing GLTF while animation is playing
2023-10-11 06:58:08 +02:00
// Editor may crash when related animation is playing while re-importing GLTF scene, stop it in advance.
AnimationPlayer *ap = AnimationPlayerEditor::get_singleton()->get_player();
if (ap && scenes.size() > 0) {
ap->stop(true);
}
Use const references where possible for List range iterators
2021-07-24 15:46:25 +02:00
for (const String &E : scenes) {
Use C++ iterators for Lists in many situations
2021-07-16 05:45:57 +02:00
reload_scene(E);
Update instances of scenes which have been reimported.
2022-01-30 22:31:32 +01:00
reload_instances_with_path_in_edited_scenes(E);
Fix issues regarding reload of resources in imported scenes. Closes #10017
2017-08-31 23:57:03 +02:00
}
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 05:36:23 +02:00
scene_tabs->set_current_tab(current_tab);
Fix issues regarding reload of resources in imported scenes. Closes #10017
2017-08-31 23:57:03 +02:00
}
Lot of work in new importer, importing textures now works.
2017-02-01 13:45:45 +01:00
void EditorNode::_sources_changed(bool p_exist) {
if (waiting_for_first_scan) {
Avoid docks to be overriden while scanning, fixes #26359
2019-02-27 22:14:24 +01:00
waiting_for_first_scan = false;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Improve engine startup/shutdown benchmarks - Add contexts to give a better sense of benchmarked areas. - Add missing benchmarks and adjust some begin/end points. - Clean up names. - Improve Android's internal benchmarks in a similar manner. Co-authored-by: Fredia Huya-Kouadio <fhuya@meta.com>
2023-12-08 12:52:49 +01:00
OS::get_singleton()->benchmark_end_measure("Editor", "First Scan");
Add Startup benchmarking support This adds support for benchmarking engine startup (and editor startup if used). The goal is to use this in the benchmarking server to track improvements and changes to engine, editor, importer and scene loading startup times.
2022-08-19 14:21:43 +02:00
Implement global and per instance shader uniforms. Adds two keywords to shader language for uniforms: -'global' -'instance' This allows them to reference values outside the material.
2020-04-17 04:52:00 +02:00
// Reload the global shader variables, but this time
Fix various typos with codespell Found via `codespell -q 3 -S ./thirdparty,*.po,./DONORS.md -L ackward,ang,ans,ba,beng,cas,childs,childrens,dof,doubleclick,fave,findn,hist,inout,leapyear,lod,nd,numer,ois,ony,paket,seeked,sinc,switchs,te,uint`
2021-07-07 17:17:32 +02:00
// loading textures, as they are now properly imported.
Rename `uniform` to `parameter` across the engine
2022-08-27 11:22:43 +02:00
RenderingServer::get_singleton()->global_shader_parameters_load_settings(true);
Implement global and per instance shader uniforms. Adds two keywords to shader language for uniforms: -'global' -'instance' This allows them to reference values outside the material.
2020-04-17 04:52:00 +02:00
Improve editor state persistence
2023-05-11 04:17:03 +02:00
_load_editor_layout();
Make sure restoring opened scenes happens after scanning is done.
2019-02-27 15:00:11 +01:00
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 10:42:46 +01:00
if (!defer_load_scene.is_empty()) {
Improve engine startup/shutdown benchmarks - Add contexts to give a better sense of benchmarked areas. - Add missing benchmarks and adjust some begin/end points. - Clean up names. - Improve Android's internal benchmarks in a similar manner. Co-authored-by: Fredia Huya-Kouadio <fhuya@meta.com>
2023-12-08 12:52:49 +01:00
OS::get_singleton()->benchmark_begin_measure("Editor", "Load Scene");
Lot of work in new importer, importing textures now works.
2017-02-01 13:45:45 +01:00
load_scene(defer_load_scene);
defer_load_scene = "";
Add Startup benchmarking support This adds support for benchmarking engine startup (and editor startup if used). The goal is to use this in the benchmarking server to track improvements and changes to engine, editor, importer and scene loading startup times.
2022-08-19 14:21:43 +02:00
Improve engine startup/shutdown benchmarks - Add contexts to give a better sense of benchmarked areas. - Add missing benchmarks and adjust some begin/end points. - Clean up names. - Improve Android's internal benchmarks in a similar manner. Co-authored-by: Fredia Huya-Kouadio <fhuya@meta.com>
2023-12-08 12:52:49 +01:00
OS::get_singleton()->benchmark_end_measure("Editor", "Load Scene");
Improve startup benchmarking Move the benchmarking measuring methods from `Engine` to `OS` to allow for platform specific overrides (e.g: can be used to hook into platform specific benchmarking and tracing capabilities).
2023-01-13 20:24:12 +01:00
OS::get_singleton()->benchmark_dump();
Lot of work in new importer, importing textures now works.
2017-02-01 13:45:45 +01:00
}
Overhaul the SurfaceUpgradeTool This defers the update to a fresh restart of the editor (to ensure we aren't mid way through loading scenes anymore. It also ensures that the popup can't be used by multiple threads at once Co-authored-by: Yuri Sizov <yuris@humnom.net>
2023-10-30 15:34:18 +01:00
if (SurfaceUpgradeTool::get_singleton()->is_show_requested()) {
SurfaceUpgradeTool::get_singleton()->show_popup();
}
Rework the surface upgrade tool to inform users without blocking This removes the immediate confirmation dialog and insteads prints the message to the editor log (and it also appears as a toast). The immediate dialog is a devil's plaything, and it cannot be used in this scenario (if it can be used anywhere at all). The condition that triggers the SUT can happen during any attempt by the rendering server to read a mesh. This means it will conflict with a number of editor processes, like loading, importing, preview generation, export, CLI mode, etc. So while this is less on the nose as far as informing users goes, it's also our best option to use the log and the toaster.
2023-11-22 16:15:02 +01:00
// Start preview thread now that it's safe.
if (!singleton->cmdline_export_mode) {
EditorResourcePreview::get_singleton()->start();
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
}
Detect external modification of scenes
2019-08-28 19:42:27 +02:00
void EditorNode::_scan_external_changes() {
disk_changed_list->clear();
TreeItem *r = disk_changed_list->create_item();
disk_changed_list->set_hide_root(true);
bool need_reload = false;
// Check if any edited scene has changed.
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
Make FileAccess and DirAccess classes reference counted.
2022-03-23 10:08:58 +01:00
Ref<DirAccess> da = DirAccess::create(DirAccess::ACCESS_RESOURCES);
Don't check modified time if file doesn't exist
2021-02-26 23:18:50 +01:00
if (editor_data.get_scene_path(i) == "" || !da->file_exists(editor_data.get_scene_path(i))) {
Detect external modification of scenes
2019-08-28 19:42:27 +02:00
continue;
}
uint64_t last_date = editor_data.get_scene_modified_time(i);
uint64_t date = FileAccess::get_modified_time(editor_data.get_scene_path(i));
if (date > last_date) {
TreeItem *ti = disk_changed_list->create_item(r);
ti->set_text(0, editor_data.get_scene_path(i).get_file());
need_reload = true;
}
}
Rename String `plus_file` to `path_join`
2022-08-30 02:34:01 +02:00
String project_settings_path = ProjectSettings::get_singleton()->get_resource_path().path_join("project.godot");
Detect external modification of project.godot
2021-01-17 01:09:17 +01:00
if (FileAccess::get_modified_time(project_settings_path) > ProjectSettings::get_singleton()->get_last_saved_time()) {
TreeItem *ti = disk_changed_list->create_item(r);
ti->set_text(0, "project.godot");
need_reload = true;
}
Detect external modification of scenes
2019-08-28 19:42:27 +02:00
if (need_reload) {
Adjust size of some dialogs
2023-04-10 17:04:47 +02:00
disk_changed->call_deferred(SNAME("popup_centered_ratio"), 0.3);
Detect external modification of scenes
2019-08-28 19:42:27 +02:00
}
}
void EditorNode::_resave_scenes(String p_str) {
save_all_scenes();
Detect external modification of project.godot
2021-01-17 01:09:17 +01:00
ProjectSettings::get_singleton()->save();
Detect external modification of scenes
2019-08-28 19:42:27 +02:00
disk_changed->hide();
}
void EditorNode::_reload_modified_scenes() {
int current_idx = editor_data.get_edited_scene();
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
if (editor_data.get_scene_path(i) == "") {
continue;
}
uint64_t last_date = editor_data.get_scene_modified_time(i);
uint64_t date = FileAccess::get_modified_time(editor_data.get_scene_path(i));
if (date > last_date) {
String filename = editor_data.get_scene_path(i);
editor_data.set_edited_scene(i);
_remove_edited_scene(false);
Error err = load_scene(filename, false, false, true, false, true);
if (err != OK) {
Detect external modification of project.godot
2021-01-17 01:09:17 +01:00
ERR_PRINT(vformat("Failed to load scene: %s", filename));
Detect external modification of scenes
2019-08-28 19:42:27 +02:00
}
editor_data.move_edited_scene_to_index(i);
}
}
Extract editor scene tabs into their own component
2023-08-24 12:24:29 +02:00
_set_current_scene(current_idx);
scene_tabs->update_scene_tabs();
Detect external modification of scenes
2019-08-28 19:42:27 +02:00
disk_changed->hide();
}
Detect external modification of project.godot
2021-01-17 01:09:17 +01:00
void EditorNode::_reload_project_settings() {
ProjectSettings::get_singleton()->setup(ProjectSettings::get_singleton()->get_resource_path(), String(), true);
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
void EditorNode::_vp_resized() {
}
[macOS extend-to-title] Add scene/project name to the editor title, fix incorrect window button position/order when system primary language is RTL.
2022-09-22 11:06:11 +02:00
void EditorNode::_titlebar_resized() {
Extract editor run toolbar into its own component - Simplify and update its logic. - Simplify EditorScript. - Improve EditorNode and other relevant includes. - Fix scene-based path in the movie writer when reloading a scene.
2023-04-12 21:02:28 +02:00
DisplayServer::get_singleton()->window_set_window_buttons_offset(Vector2i(title_bar->get_global_position().y + title_bar->get_size().y / 2, title_bar->get_global_position().y + title_bar->get_size().y / 2), DisplayServer::MAIN_WINDOW_ID);
[macOS] Fix window button position and title bar size when editor scale do not match OS UI scale.
2022-10-10 09:32:41 +02:00
const Vector3i &margin = DisplayServer::get_singleton()->window_get_safe_title_margins(DisplayServer::MAIN_WINDOW_ID);
[macOS extend-to-title] Add scene/project name to the editor title, fix incorrect window button position/order when system primary language is RTL.
2022-09-22 11:06:11 +02:00
if (left_menu_spacer) {
int w = (gui_base->is_layout_rtl()) ? margin.y : margin.x;
left_menu_spacer->set_custom_minimum_size(Size2(w, 0));
}
if (right_menu_spacer) {
int w = (gui_base->is_layout_rtl()) ? margin.x : margin.y;
right_menu_spacer->set_custom_minimum_size(Size2(w, 0));
}
Extract editor run toolbar into its own component - Simplify and update its logic. - Simplify EditorScript. - Improve EditorNode and other relevant includes. - Fix scene-based path in the movie writer when reloading a scene.
2023-04-12 21:02:28 +02:00
if (title_bar) {
title_bar->set_custom_minimum_size(Size2(0, margin.z - title_bar->get_global_position().y));
[macOS] Fix window button position and title bar size when editor scale do not match OS UI scale.
2022-10-10 09:32:41 +02:00
}
[macOS extend-to-title] Add scene/project name to the editor title, fix incorrect window button position/order when system primary language is RTL.
2022-09-22 11:06:11 +02:00
}
Make it possible to copy the Godot version identifier by clicking it This closes #24317.
2019-12-24 01:20:54 +01:00
void EditorNode::_version_button_pressed() {
DisplayServer::get_singleton()->clipboard_set(version_btn->get_meta(META_TEXT_TO_COPY));
}
Fix Undo/Redo not working until Scene menu is opened.
2023-01-08 09:35:15 +01:00
void EditorNode::_update_undo_redo_allowed() {
Add EditorUndoRedoManager singleton
2022-12-23 23:53:16 +01:00
EditorUndoRedoManager *undo_redo = EditorUndoRedoManager::get_singleton();
Fix Undo/Redo not working until Scene menu is opened.
2023-01-08 09:35:15 +01:00
file_menu->set_item_disabled(file_menu->get_item_index(EDIT_UNDO), !undo_redo->has_undo());
file_menu->set_item_disabled(file_menu->get_item_index(EDIT_REDO), !undo_redo->has_redo());
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
void EditorNode::_node_renamed() {
Store panels and docks singletons in their own classes
2021-11-17 21:08:55 +01:00
if (InspectorDock::get_inspector_singleton()) {
InspectorDock::get_inspector_singleton()->update_tree();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Editor: Make "open 2d/3d/script editor" shortcuts configurable. Also adds shortcuts for opening the AssetLib and for switching to the next/prev editor.
2017-05-16 21:26:32 +02:00
void EditorNode::_editor_select_next() {
int editor = _get_current_main_editor();
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
do {
if (editor == editor_table.size() - 1) {
editor = 0;
} else {
editor++;
}
Fixes infinite loop when switching editor
2019-12-11 06:27:21 +01:00
} while (!main_editor_buttons[editor]->is_visible());
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
Port remaining connections to callable_mp
2020-12-06 16:09:18 +01:00
editor_select(editor);
Editor: Make "open 2d/3d/script editor" shortcuts configurable. Also adds shortcuts for opening the AssetLib and for switching to the next/prev editor.
2017-05-16 21:26:32 +02:00
}
Added EditorCommandPalette
2021-05-29 15:28:16 +02:00
void EditorNode::_open_command_palette() {
command_palette->open_popup();
}
Editor: Make "open 2d/3d/script editor" shortcuts configurable. Also adds shortcuts for opening the AssetLib and for switching to the next/prev editor.
2017-05-16 21:26:32 +02:00
void EditorNode::_editor_select_prev() {
int editor = _get_current_main_editor();
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
do {
if (editor == 0) {
editor = editor_table.size() - 1;
} else {
editor--;
}
Fixes infinite loop when switching editor
2019-12-11 06:27:21 +01:00
} while (!main_editor_buttons[editor]->is_visible());
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
Port remaining connections to callable_mp
2020-12-06 16:09:18 +01:00
editor_select(editor);
Editor: Make "open 2d/3d/script editor" shortcuts configurable. Also adds shortcuts for opening the AssetLib and for switching to the next/prev editor.
2017-05-16 21:26:32 +02:00
}
Let user fix dependencies in resources
2018-11-02 04:44:40 +01:00
Error EditorNode::load_resource(const String &p_resource, bool p_ignore_broken_deps) {
dependency_errors.clear();
Error err;
Add TextFile support across the editor
2021-09-23 23:09:15 +02:00
Remove `RES` and `REF` typedefs in favor of spelled out `Ref<>` These typedefs don't save much typing compared to the full `Ref<Resource>` and `Ref<RefCounted>`, yet they sometimes introduce confusion among new contributors.
2022-05-03 01:43:50 +02:00
Ref<Resource> res;
Add TextFile support across the editor
2021-09-23 23:09:15 +02:00
if (ResourceLoader::exists(p_resource, "")) {
res = ResourceLoader::load(p_resource, "", ResourceFormatLoader::CACHE_MODE_REUSE, &err);
} else if (textfile_extensions.has(p_resource.get_extension())) {
res = ScriptEditor::get_singleton()->open_file(p_resource);
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
ERR_FAIL_COND_V(!res.is_valid(), ERR_CANT_OPEN);
Let user fix dependencies in resources
2018-11-02 04:44:40 +01:00
if (!p_ignore_broken_deps && dependency_errors.has(p_resource)) {
Vector<String> errors;
Use range iterators for RBSet in most cases
2022-05-19 01:43:40 +02:00
for (const String &E : dependency_errors[p_resource]) {
errors.push_back(E);
Let user fix dependencies in resources
2018-11-02 04:44:40 +01:00
}
dependency_error->show(DependencyErrorDialog::MODE_RESOURCE, p_resource, errors);
dependency_errors.erase(p_resource);
return ERR_FILE_MISSING_DEPENDENCIES;
}
Store panels and docks singletons in their own classes
2021-11-17 21:08:55 +01:00
InspectorDock::get_singleton()->edit_resource(res);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return OK;
}
void EditorNode::edit_node(Node *p_node) {
push_item(p_node);
}
Use forward-declarations in big editor classes
2022-11-19 12:45:49 +01:00
void EditorNode::edit_resource(const Ref<Resource> &p_resource) {
InspectorDock::get_singleton()->edit_resource(p_resource);
}
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
void EditorNode::save_resource_in_path(const Ref<Resource> &p_resource, const String &p_path) {
editor_data.apply_changes_in_editors();
Prevent cache corruption when saving resources in the editor
2023-03-08 19:46:55 +01:00
if (saving_resources_in_path.has(p_resource)) {
return;
}
saving_resources_in_path.insert(p_resource);
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
int flg = 0;
Unify usage of GLOBAL/EDITOR_GET
2022-10-18 16:43:37 +02:00
if (EDITOR_GET("filesystem/on_save/compress_binary_resources")) {
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
flg |= ResourceSaver::FLAG_COMPRESS;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
-Renamed GlobalConfig to ProjectSettings, makes more sense. -Added system for feature overrides, it's pretty cool :)
2017-07-19 22:00:46 +02:00
String path = ProjectSettings::get_singleton()->localize_path(p_path);
Swap arguments of ResourceSaver.save()
2022-06-03 01:33:42 +02:00
Error err = ResourceSaver::save(p_resource, path, flg | ResourceSaver::FLAG_REPLACE_SUBRESOURCE_PATHS);
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
if (err != OK) {
Better warnings when resources can't be saved. Fixes #26531
2019-03-04 15:06:15 +01:00
if (ResourceLoader::is_imported(p_resource->get_path())) {
show_accept(TTR("Imported resources can't be saved."), TTR("OK"));
} else {
show_accept(TTR("Error saving resource!"), TTR("OK"));
}
Prevent cache corruption when saving resources in the editor
2023-03-08 19:46:55 +01:00
saving_resources_in_path.erase(p_resource);
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
return;
}
((Resource *)p_resource.ptr())->set_path(path);
Prevent cache corruption when saving resources in the editor
2023-03-08 19:46:55 +01:00
saving_resources_in_path.erase(p_resource);
_resource_saved(p_resource, path);
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 23:22:52 +02:00
emit_signal(SNAME("resource_saved"), p_resource);
Added EditorPlugin 'resource_saved' signal
2018-01-12 22:43:29 +01:00
editor_data.notify_resource_saved(p_resource);
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
}
void EditorNode::save_resource(const Ref<Resource> &p_resource) {
Save scene when saving built-in resource
2023-11-08 21:08:24 +01:00
// If built-in resource, save the scene instead.
if (p_resource->is_built_in()) {
const String scene_path = p_resource->get_path().get_slice("::", 0);
if (!scene_path.is_empty()) {
save_scene_if_open(scene_path);
return;
}
}
Disable editing properties in foreign resources from imported scenes or objects returning true from a function named '_is_read_only' and disable resaving imported resources.
2022-04-29 08:06:48 +02:00
// If the resource has been imported, ask the user to use a different path in order to save it.
String path = p_resource->get_path();
if (path.is_resource_file() && !FileAccess::exists(path + ".import")) {
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
save_resource_in_path(p_resource, p_resource->get_path());
} else {
save_resource_as(p_resource);
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 16:46:08 +02:00
void EditorNode::save_resource_as(const Ref<Resource> &p_resource, const String &p_at_path) {
Better warnings when resources can't be saved. Fixes #26531
2019-03-04 15:06:15 +01:00
{
String path = p_resource->get_path();
Disable editing properties in foreign resources from imported scenes or objects returning true from a function named '_is_read_only' and disable resaving imported resources.
2022-04-29 08:06:48 +02:00
if (!path.is_resource_file()) {
int srpos = path.find("::");
if (srpos != -1) {
String base = path.substr(0, srpos);
if (!get_edited_scene() || get_edited_scene()->get_scene_file_path() != base) {
show_warning(TTR("This resource can't be saved because it does not belong to the edited scene. Make it unique first."));
return;
}
}
Mesh instance UV2 unwrapping improvements: Enforce foreign resource modification rules. Add more helpful error handling for ArrayMesh unwrapping.
2023-10-17 14:55:47 +02:00
} else if (FileAccess::exists(path + ".import")) {
show_warning(TTR("This resource can't be saved because it was imported from another file. Make it unique first."));
return;
Better warnings when resources can't be saved. Fixes #26531
2019-03-04 15:06:15 +01:00
}
}
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
file->set_file_mode(EditorFileDialog::FILE_MODE_SAVE_FILE);
Add Save option to resource property menu
2018-11-18 15:17:04 +01:00
saving_resource = p_resource;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
current_menu_option = RESOURCE_SAVE_AS;
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
List<String> extensions;
Ref<PackedScene> sd = memnew(PackedScene);
ResourceSaver::get_recognized_extensions(p_resource, &extensions);
file->clear_filters();
properly implement save as from script editor, fixes #2415
2015-12-31 17:12:27 +01:00
List<String> preferred;
Use const references where possible for List range iterators
2021-07-24 15:46:25 +02:00
for (const String &E : extensions) {
Use C++ iterators for Lists in many situations
2021-07-16 05:45:57 +02:00
if (p_resource->is_class("Script") && (E == "tres" || E == "res")) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// This serves no purpose and confused people.
properly implement save as from script editor, fixes #2415
2015-12-31 17:12:27 +01:00
continue;
}
Seperate filter and description in FileDialog.add_filter()
2022-07-04 23:26:26 +02:00
file->add_filter("*." + E, E.to_upper());
Use C++ iterators for Lists in many situations
2021-07-16 05:45:57 +02:00
preferred.push_back(E);
Save resource: implement extension priority give .res less priority and .tres more priority as preferred extensions.
2020-12-13 02:37:23 +01:00
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Lowest priority extension.
Save resource: implement extension priority give .res less priority and .tres more priority as preferred extensions.
2020-12-13 02:37:23 +01:00
List<String>::Element *res_element = preferred.find("res");
if (res_element) {
preferred.move_to_back(res_element);
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Highest priority extension.
Save resource: implement extension priority give .res less priority and .tres more priority as preferred extensions.
2020-12-13 02:37:23 +01:00
List<String>::Element *tres_element = preferred.find("tres");
if (tres_element) {
preferred.move_to_front(tres_element);
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
}
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 10:42:46 +01:00
if (!p_at_path.is_empty()) {
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 16:46:08 +02:00
file->set_current_dir(p_at_path);
if (p_resource->get_path().is_resource_file()) {
file->set_current_file(p_resource->get_path().get_file());
} else {
if (extensions.size()) {
Add `String.to_{camel,pascal,snake}_case` methods
2022-08-30 11:36:24 +02:00
String resource_name_snake_case = p_resource->get_class().to_snake_case();
Name new resource files with `snake_case`
2021-07-30 02:42:07 +02:00
file->set_current_file("new_" + resource_name_snake_case + "." + preferred.front()->get().to_lower());
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 16:46:08 +02:00
} else {
file->set_current_file(String());
}
}
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 10:42:46 +01:00
} else if (!p_resource->get_path().is_empty()) {
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
file->set_current_path(p_resource->get_path());
if (extensions.size()) {
rename String.extension() -> String.get_extension() / String.basename() -> String.get_basename()
2017-01-14 04:51:09 +01:00
String ext = p_resource->get_path().get_extension().to_lower();
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
if (extensions.find(ext) == nullptr) {
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
file->set_current_path(p_resource->get_path().replacen("." + ext, "." + extensions.front()->get()));
}
}
properly implement save as from script editor, fixes #2415
2015-12-31 17:12:27 +01:00
} else if (preferred.size()) {
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
String existing;
if (extensions.size()) {
Add `String.to_{camel,pascal,snake}_case` methods
2022-08-30 11:36:24 +02:00
String resource_name_snake_case = p_resource->get_class().to_snake_case();
Name new resource files with `snake_case`
2021-07-30 02:42:07 +02:00
existing = "new_" + resource_name_snake_case + "." + preferred.front()->get().to_lower();
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
}
file->set_current_path(existing);
}
Change ".." punctuation for "..." in editor strings (#16507)
2018-04-22 19:36:01 +02:00
file->set_title(TTR("Save Resource As..."));
Resize dialogs (FileDialog, EditorFileDialog, Reparent, SceneTreeDialog and resource depency dialogs).
2020-07-11 18:45:19 +02:00
file->popup_file_dialog();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
void EditorNode::_menu_option(int p_option) {
_menu_option_confirm(p_option, false);
}
void EditorNode::_menu_confirm_current() {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
_menu_option_confirm(current_menu_option, true);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Extract editor scene tabs into their own component
2023-08-24 12:24:29 +02:00
void EditorNode::trigger_menu_option(int p_option, bool p_confirmed) {
_menu_option_confirm(p_option, p_confirmed);
}
EditorNode: enhance open scene error dialog
2017-08-28 05:24:50 +02:00
void EditorNode::_dialog_display_save_error(String p_file, Error p_error) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (p_error) {
switch (p_error) {
case ERR_FILE_CANT_WRITE: {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 16:47:41 +02:00
show_accept(TTR("Can't open file for writing:") + " " + p_file.get_extension(), TTR("OK"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
case ERR_FILE_UNRECOGNIZED: {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 16:47:41 +02:00
show_accept(TTR("Requested file format unknown:") + " " + p_file.get_extension(), TTR("OK"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
default: {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 16:47:41 +02:00
show_accept(TTR("Error while saving."), TTR("OK"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
}
}
}
EditorNode: enhance open scene error dialog
2017-08-28 05:24:50 +02:00
void EditorNode::_dialog_display_load_error(String p_file, Error p_error) {
if (p_error) {
switch (p_error) {
case ERR_CANT_OPEN: {
PackedScene: Prevent crash when root node has `parent` attribute The crash happens further down when setting an invalid owner in `Node::_set_owner_nocheck` but I couldn't figure out how to fix it. But here the proper fix is to catch the invalid scene file early on and fail loading it. Part of #17372.
2020-06-08 13:05:09 +02:00
show_accept(vformat(TTR("Can't open file '%s'. The file could have been moved or deleted."), p_file.get_file()), TTR("OK"));
EditorNode: enhance open scene error dialog
2017-08-28 05:24:50 +02:00
} break;
case ERR_PARSE_ERROR: {
PackedScene: Prevent crash when root node has `parent` attribute The crash happens further down when setting an invalid owner in `Node::_set_owner_nocheck` but I couldn't figure out how to fix it. But here the proper fix is to catch the invalid scene file early on and fail loading it. Part of #17372.
2020-06-08 13:05:09 +02:00
show_accept(vformat(TTR("Error while parsing file '%s'."), p_file.get_file()), TTR("OK"));
EditorNode: enhance open scene error dialog
2017-08-28 05:24:50 +02:00
} break;
case ERR_FILE_CORRUPT: {
PackedScene: Prevent crash when root node has `parent` attribute The crash happens further down when setting an invalid owner in `Node::_set_owner_nocheck` but I couldn't figure out how to fix it. But here the proper fix is to catch the invalid scene file early on and fail loading it. Part of #17372.
2020-06-08 13:05:09 +02:00
show_accept(vformat(TTR("Scene file '%s' appears to be invalid/corrupt."), p_file.get_file()), TTR("OK"));
EditorNode: enhance open scene error dialog
2017-08-28 05:24:50 +02:00
} break;
case ERR_FILE_NOT_FOUND: {
Add missing word to text of the alert dialog
2023-07-12 16:36:35 +02:00
show_accept(vformat(TTR("Missing file '%s' or one of its dependencies."), p_file.get_file()), TTR("OK"));
EditorNode: enhance open scene error dialog
2017-08-28 05:24:50 +02:00
} break;
default: {
PackedScene: Prevent crash when root node has `parent` attribute The crash happens further down when setting an invalid owner in `Node::_set_owner_nocheck` but I couldn't figure out how to fix it. But here the proper fix is to catch the invalid scene file early on and fail loading it. Part of #17372.
2020-06-08 13:05:09 +02:00
show_accept(vformat(TTR("Error while loading file '%s'."), p_file.get_file()), TTR("OK"));
EditorNode: enhance open scene error dialog
2017-08-28 05:24:50 +02:00
} break;
}
}
}
Improve editor state persistence
2023-05-11 04:17:03 +02:00
void EditorNode::_load_editor_plugin_states_from_config(const Ref<ConfigFile> &p_config_file) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
Node *scene = editor_data.get_edited_scene_root();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!scene) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
-Ensure .tscn and .tres always save in a deterministic way, fixes #2495 -Scene edit state is saved outside the scene now, to avoid changes .tscn files when nothing really changed -Created a VariantWriter helper to unify all variant to text writing -Moved SceneFormatText writing to VariantWriter -Moved ConfigFile to use VariantWriter and VariantParser, added compatibility mode for old .cfg files that use engine.cfg format
2015-12-31 04:31:00 +01:00
List<String> esl;
Improve editor state persistence
2023-05-11 04:17:03 +02:00
p_config_file->get_section_keys("editor_states", &esl);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
-Ensure .tscn and .tres always save in a deterministic way, fixes #2495 -Scene edit state is saved outside the scene now, to avoid changes .tscn files when nothing really changed -Created a VariantWriter helper to unify all variant to text writing -Moved SceneFormatText writing to VariantWriter -Moved ConfigFile to use VariantWriter and VariantParser, added compatibility mode for old .cfg files that use engine.cfg format
2015-12-31 04:31:00 +01:00
Dictionary md;
Use const references where possible for List range iterators
2021-07-24 15:46:25 +02:00
for (const String &E : esl) {
Improve editor state persistence
2023-05-11 04:17:03 +02:00
Variant st = p_config_file->get_value("editor_states", E);
Changed some code showed in LGTM and Coverage
2019-07-20 08:09:57 +02:00
if (st.get_type() != Variant::NIL) {
Use C++ iterators for Lists in many situations
2021-07-16 05:45:57 +02:00
md[E] = st;
-Ensure .tscn and .tres always save in a deterministic way, fixes #2495 -Scene edit state is saved outside the scene now, to avoid changes .tscn files when nothing really changed -Created a VariantWriter helper to unify all variant to text writing -Moved SceneFormatText writing to VariantWriter -Moved ConfigFile to use VariantWriter and VariantParser, added compatibility mode for old .cfg files that use engine.cfg format
2015-12-31 04:31:00 +01:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Improve editor state persistence
2023-05-11 04:17:03 +02:00
editor_data.set_editor_plugin_states(md);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Improve editor state persistence
2023-05-11 04:17:03 +02:00
void EditorNode::_save_editor_states(const String &p_file, int p_idx) {
Save all edited scenes when Runing (and auto-save is enabled). Fixes #4410
2016-06-26 05:54:17 +02:00
Node *scene = editor_data.get_edited_scene_root(p_idx);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!scene) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Rename String `plus_file` to `path_join`
2022-08-30 02:34:01 +02:00
String path = EditorPaths::get_singleton()->get_project_settings_dir().path_join(p_file.get_file() + "-editstate-" + p_file.md5_text() + ".cfg");
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
-Ensure .tscn and .tres always save in a deterministic way, fixes #2495 -Scene edit state is saved outside the scene now, to avoid changes .tscn files when nothing really changed -Created a VariantWriter helper to unify all variant to text writing -Moved SceneFormatText writing to VariantWriter -Moved ConfigFile to use VariantWriter and VariantParser, added compatibility mode for old .cfg files that use engine.cfg format
2015-12-31 04:31:00 +01:00
Ref<ConfigFile> cf;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
cf.instantiate();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Fix editor states saving, and remove related error messages
2016-07-17 21:59:15 +02:00
Dictionary md;
if (p_idx < 0 || editor_data.get_edited_scene() == p_idx) {
Improve editor state persistence
2023-05-11 04:17:03 +02:00
md = editor_data.get_editor_plugin_states();
Fix editor states saving, and remove related error messages
2016-07-17 21:59:15 +02:00
} else {
md = editor_data.get_scene_editor_states(p_idx);
}
-Ensure .tscn and .tres always save in a deterministic way, fixes #2495 -Scene edit state is saved outside the scene now, to avoid changes .tscn files when nothing really changed -Created a VariantWriter helper to unify all variant to text writing -Moved SceneFormatText writing to VariantWriter -Moved ConfigFile to use VariantWriter and VariantParser, added compatibility mode for old .cfg files that use engine.cfg format
2015-12-31 04:31:00 +01:00
List<Variant> keys;
md.get_key_list(&keys);
Use const references where possible for List range iterators
2021-07-24 15:46:25 +02:00
for (const Variant &E : keys) {
Use C++ iterators for Lists in many situations
2021-07-16 05:45:57 +02:00
cf->set_value("editor_states", E, md[E]);
-Ensure .tscn and .tres always save in a deterministic way, fixes #2495 -Scene edit state is saved outside the scene now, to avoid changes .tscn files when nothing really changed -Created a VariantWriter helper to unify all variant to text writing -Moved SceneFormatText writing to VariantWriter -Moved ConfigFile to use VariantWriter and VariantParser, added compatibility mode for old .cfg files that use engine.cfg format
2015-12-31 04:31:00 +01:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Improve editor state persistence
2023-05-11 04:17:03 +02:00
// Save the currently selected nodes.
List<Node *> selection = editor_selection->get_full_selected_node_list();
TypedArray<NodePath> selection_paths;
for (Node *selected_node : selection) {
selection_paths.push_back(selected_node->get_path());
}
cf->set_value("editor_states", "selected_nodes", selection_paths);
-Ensure .tscn and .tres always save in a deterministic way, fixes #2495 -Scene edit state is saved outside the scene now, to avoid changes .tscn files when nothing really changed -Created a VariantWriter helper to unify all variant to text writing -Moved SceneFormatText writing to VariantWriter -Moved ConfigFile to use VariantWriter and VariantParser, added compatibility mode for old .cfg files that use engine.cfg format
2015-12-31 04:31:00 +01:00
Error err = cf->save(path);
Added some obvious errors explanations
2019-09-25 10:28:50 +02:00
ERR_FAIL_COND_MSG(err != OK, "Cannot save config file to '" + path + "'.");
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Replace most uses of Map by HashMap * Map is unnecessary and inefficient in almost every case. * Replaced by the new HashMap. * Renamed Map to RBMap and Set to RBSet for cases that still make sense (order matters) but use is discouraged. There were very few cases where replacing by HashMap was undesired because keeping the key order was intended. I tried to keep those (as RBMap) as much as possible, but might have missed some. Review appreciated!
2022-05-13 15:04:37 +02:00
bool EditorNode::_find_and_save_resource(Ref<Resource> p_res, HashMap<Ref<Resource>, bool> &processed, int32_t flags) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (p_res.is_null()) {
properly save external resources, fixes #1924 added API to get scancode names to OS
2015-05-17 18:11:55 +02:00
return false;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
properly save external resources, fixes #1924 added API to get scancode names to OS
2015-05-17 18:11:55 +02:00
Updated function argument names
2017-08-12 18:52:50 +02:00
if (processed.has(p_res)) {
return processed[p_res];
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
}
properly save external resources, fixes #1924 added API to get scancode names to OS
2015-05-17 18:11:55 +02:00
Updated function argument names
2017-08-12 18:52:50 +02:00
bool changed = p_res->is_edited();
p_res->set_edited(false);
properly save external resources, fixes #1924 added API to get scancode names to OS
2015-05-17 18:11:55 +02:00
Updated function argument names
2017-08-12 18:52:50 +02:00
bool subchanged = _find_and_save_edited_subresources(p_res.ptr(), processed, flags);
properly save external resources, fixes #1924 added API to get scancode names to OS
2015-05-17 18:11:55 +02:00
Updated function argument names
2017-08-12 18:52:50 +02:00
if (p_res->get_path().is_resource_file()) {
properly save external resources, fixes #1924 added API to get scancode names to OS
2015-05-17 18:11:55 +02:00
if (changed || subchanged) {
Swap arguments of ResourceSaver.save()
2022-06-03 01:33:42 +02:00
ResourceSaver::save(p_res, p_res->get_path(), flags);
properly save external resources, fixes #1924 added API to get scancode names to OS
2015-05-17 18:11:55 +02:00
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
processed[p_res] = false; // Because it's a file.
properly save external resources, fixes #1924 added API to get scancode names to OS
2015-05-17 18:11:55 +02:00
return false;
} else {
Updated function argument names
2017-08-12 18:52:50 +02:00
processed[p_res] = changed;
properly save external resources, fixes #1924 added API to get scancode names to OS
2015-05-17 18:11:55 +02:00
return changed;
}
}
Replace most uses of Map by HashMap * Map is unnecessary and inefficient in almost every case. * Replaced by the new HashMap. * Renamed Map to RBMap and Set to RBSet for cases that still make sense (order matters) but use is discouraged. There were very few cases where replacing by HashMap was undesired because keeping the key order was intended. I tried to keep those (as RBMap) as much as possible, but might have missed some. Review appreciated!
2022-05-13 15:04:37 +02:00
bool EditorNode::_find_and_save_edited_subresources(Object *obj, HashMap<Ref<Resource>, bool> &processed, int32_t flags) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
bool ret_changed = false;
List<PropertyInfo> pi;
obj->get_property_list(&pi);
Use const references where possible for List range iterators
2021-07-24 15:46:25 +02:00
for (const PropertyInfo &E : pi) {
Use C++ iterators for Lists in many situations
2021-07-16 05:45:57 +02:00
if (!(E.usage & PROPERTY_USAGE_STORAGE)) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Use C++ iterators for Lists in many situations
2021-07-16 05:45:57 +02:00
switch (E.type) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
case Variant::OBJECT: {
Remove `RES` and `REF` typedefs in favor of spelled out `Ref<>` These typedefs don't save much typing compared to the full `Ref<Resource>` and `Ref<RefCounted>`, yet they sometimes introduce confusion among new contributors.
2022-05-03 01:43:50 +02:00
Ref<Resource> res = obj->get(E.name);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (_find_and_save_resource(res, processed, flags)) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
ret_changed = true;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
case Variant::ARRAY: {
Use C++ iterators for Lists in many situations
2021-07-16 05:45:57 +02:00
Array varray = obj->get(E.name);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
int len = varray.size();
for (int i = 0; i < len; i++) {
Removed unused variables, add some constants numbers
2019-12-10 05:13:02 +01:00
const Variant &v = varray.get(i);
Remove `RES` and `REF` typedefs in favor of spelled out `Ref<>` These typedefs don't save much typing compared to the full `Ref<Resource>` and `Ref<RefCounted>`, yet they sometimes introduce confusion among new contributors.
2022-05-03 01:43:50 +02:00
Ref<Resource> res = v;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (_find_and_save_resource(res, processed, flags)) {
properly save external resources, fixes #1924 added API to get scancode names to OS
2015-05-17 18:11:55 +02:00
ret_changed = true;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
properly save external resources, fixes #1924 added API to get scancode names to OS
2015-05-17 18:11:55 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
case Variant::DICTIONARY: {
Use C++ iterators for Lists in many situations
2021-07-16 05:45:57 +02:00
Dictionary d = obj->get(E.name);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
List<Variant> keys;
d.get_key_list(&keys);
Use const references where possible for List range iterators
2021-07-24 15:46:25 +02:00
for (const Variant &F : keys) {
Use C++ iterators for Lists in many situations
2021-07-16 05:45:57 +02:00
Variant v = d[F];
Remove `RES` and `REF` typedefs in favor of spelled out `Ref<>` These typedefs don't save much typing compared to the full `Ref<Resource>` and `Ref<RefCounted>`, yet they sometimes introduce confusion among new contributors.
2022-05-03 01:43:50 +02:00
Ref<Resource> res = v;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (_find_and_save_resource(res, processed, flags)) {
properly save external resources, fixes #1924 added API to get scancode names to OS
2015-05-17 18:11:55 +02:00
ret_changed = true;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
properly save external resources, fixes #1924 added API to get scancode names to OS
2015-05-17 18:11:55 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
Style: Apply new changes from clang-format 8.0 It seems to stay compatible with formatting done by clang-format 6.0 and 7.0, so contributors can keep using those versions for now (they will not undo those changes).
2019-04-09 17:08:36 +02:00
default: {
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
}
return ret_changed;
}
Replace most uses of Map by HashMap * Map is unnecessary and inefficient in almost every case. * Replaced by the new HashMap. * Renamed Map to RBMap and Set to RBSet for cases that still make sense (order matters) but use is discouraged. There were very few cases where replacing by HashMap was undesired because keeping the key order was intended. I tried to keep those (as RBMap) as much as possible, but might have missed some. Review appreciated!
2022-05-13 15:04:37 +02:00
void EditorNode::_save_edited_subresources(Node *scene, HashMap<Ref<Resource>, bool> &processed, int32_t flags) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
_find_and_save_edited_subresources(scene, processed, flags);
for (int i = 0; i < scene->get_child_count(); i++) {
Node *n = scene->get_child(i);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (n->get_owner() != editor_data.get_edited_scene_root()) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
_save_edited_subresources(n, processed, flags);
}
}
work in progress, resource previews
2015-05-31 06:59:42 +02:00
void EditorNode::_find_node_types(Node *p_node, int &count_2d, int &count_3d) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (p_node->is_class("Viewport") || (p_node != editor_data.get_edited_scene_root() && p_node->get_owner() != editor_data.get_edited_scene_root())) {
work in progress, resource previews
2015-05-31 06:59:42 +02:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
work in progress, resource previews
2015-05-31 06:59:42 +02:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (p_node->is_class("CanvasItem")) {
work in progress, resource previews
2015-05-31 06:59:42 +02:00
count_2d++;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
} else if (p_node->is_class("Node3D")) {
work in progress, resource previews
2015-05-31 06:59:42 +02:00
count_3d++;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
work in progress, resource previews
2015-05-31 06:59:42 +02:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
for (int i = 0; i < p_node->get_child_count(); i++) {
work in progress, resource previews
2015-05-31 06:59:42 +02:00
_find_node_types(p_node->get_child(i), count_2d, count_3d);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
work in progress, resource previews
2015-05-31 06:59:42 +02:00
}
Update meshes when reimporting, Save scene preview even when not doing save and play.
2017-11-12 04:48:00 +01:00
void EditorNode::_save_scene_with_preview(String p_file, int p_idx) {
Modified editor strings to be translatable in the future
2016-05-04 03:25:37 +02:00
EditorProgress save("save", TTR("Saving Scene"), 4);
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
if (editor_data.get_edited_scene_root() != nullptr) {
Don't create preview of empty scene.
2019-12-26 09:15:36 +01:00
save.step(TTR("Analyzing"), 0);
work in progress, resource previews
2015-05-31 06:59:42 +02:00
Don't create preview of empty scene.
2019-12-26 09:15:36 +01:00
int c2d = 0;
int c3d = 0;
-Restored multithread capability to VisualServer -Restored resource previews!
2017-06-09 05:23:50 +02:00
Don't create preview of empty scene.
2019-12-26 09:15:36 +01:00
_find_node_types(editor_data.get_edited_scene_root(), c2d, c3d);
work in progress, resource previews
2015-05-31 06:59:42 +02:00
Don't create preview of empty scene.
2019-12-26 09:15:36 +01:00
save.step(TTR("Creating Thumbnail"), 1);
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Current view?
Fix pixelized previews, but also instances of breaking ImageTexture cache. Closes #25378.
2019-01-27 17:39:16 +01:00
Don't create preview of empty scene.
2019-12-26 09:15:36 +01:00
Ref<Image> img;
Improve scene preview generation for empty scenes and disabled features
2020-07-06 17:55:07 +02:00
// If neither 3D or 2D nodes are present, make a 1x1 black texture.
// We cannot fallback on the 2D editor, because it may not have been used yet,
// which would result in an invalid texture.
if (c3d == 0 && c2d == 0) {
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
img.instantiate();
Make some Image methods static
2022-07-22 20:06:19 +02:00
img->initialize_data(1, 1, false, Image::FORMAT_RGB8);
Improve scene preview generation for empty scenes and disabled features
2020-07-06 17:55:07 +02:00
} else if (c3d < c2d) {
Fix errors saving a 2D scene preview when the 2D editor was never opened
2020-07-27 15:49:56 +02:00
Ref<ViewportTexture> viewport_texture = scene_root->get_texture();
if (viewport_texture->get_width() > 0 && viewport_texture->get_height() > 0) {
Rename Texture.get_data() to get_image()
2021-03-28 13:32:17 +02:00
img = viewport_texture->get_image();
Fix errors saving a 2D scene preview when the 2D editor was never opened
2020-07-27 15:49:56 +02:00
}
Don't create preview of empty scene.
2019-12-26 09:15:36 +01:00
} else {
Improve scene preview generation for empty scenes and disabled features
2020-07-06 17:55:07 +02:00
// The 3D editor may be disabled as a feature, but scenes can still be opened.
// This check prevents the preview from regenerating in case those scenes are then saved.
Fix 3D scene preview generation. File system dock previews will now be generated for 3D scenes when no editor feature profile is set.
2021-03-19 20:54:29 +01:00
// The preview will be generated if no feature profile is set (as the 3D editor is enabled by default).
Improve scene preview generation for empty scenes and disabled features
2020-07-06 17:55:07 +02:00
Ref<EditorFeatureProfile> profile = feature_profile_manager->get_current_profile();
Fix 3D scene preview generation. File system dock previews will now be generated for 3D scenes when no editor feature profile is set.
2021-03-19 20:54:29 +01:00
if (!profile.is_valid() || !profile->is_feature_disabled(EditorFeatureProfile::FEATURE_3D)) {
Rename Texture.get_data() to get_image()
2021-03-28 13:32:17 +02:00
img = Node3DEditor::get_singleton()->get_editor_viewport(0)->get_viewport_node()->get_texture()->get_image();
Improve scene preview generation for empty scenes and disabled features
2020-07-06 17:55:07 +02:00
}
Don't create preview of empty scene.
2019-12-26 09:15:36 +01:00
}
Fix pixelized previews, but also instances of breaking ImageTexture cache. Closes #25378.
2019-01-27 17:39:16 +01:00
Fix errors saving a 2D scene preview when the 2D editor was never opened
2020-07-27 15:49:56 +02:00
if (img.is_valid() && img->get_width() > 0 && img->get_height() > 0) {
Don't create preview of empty scene.
2019-12-26 09:15:36 +01:00
img = img->duplicate();
work in progress, resource previews
2015-05-31 06:59:42 +02:00
Don't create preview of empty scene.
2019-12-26 09:15:36 +01:00
save.step(TTR("Creating Thumbnail"), 2);
save.step(TTR("Creating Thumbnail"), 3);
work in progress, resource previews
2015-05-31 06:59:42 +02:00
Unify usage of GLOBAL/EDITOR_GET
2022-10-18 16:43:37 +02:00
int preview_size = EDITOR_GET("filesystem/file_dialog/thumbnail_size");
Don't create preview of empty scene.
2019-12-26 09:15:36 +01:00
preview_size *= EDSCALE;
work in progress, resource previews
2015-05-31 06:59:42 +02:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Consider a square region.
Don't create preview of empty scene.
2019-12-26 09:15:36 +01:00
int vp_size = MIN(img->get_width(), img->get_height());
int x = (img->get_width() - vp_size) / 2;
int y = (img->get_height() - vp_size) / 2;
Improved packed scene previews.
2017-11-18 04:42:14 +01:00
Don't create preview of empty scene.
2019-12-26 09:15:36 +01:00
if (vp_size < preview_size) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Just square it.
Don't create preview of empty scene.
2019-12-26 09:15:36 +01:00
img->crop_from_point(x, y, vp_size, vp_size);
} else {
int ratio = vp_size / preview_size;
int size = preview_size * MAX(1, ratio / 2);
work in progress, resource previews
2015-05-31 06:59:42 +02:00
Don't create preview of empty scene.
2019-12-26 09:15:36 +01:00
x = (img->get_width() - size) / 2;
y = (img->get_height() - size) / 2;
work in progress, resource previews
2015-05-31 06:59:42 +02:00
Don't create preview of empty scene.
2019-12-26 09:15:36 +01:00
img->crop_from_point(x, y, size, size);
img->resize(preview_size, preview_size, Image::INTERPOLATE_LANCZOS);
}
img->convert(Image::FORMAT_RGB8);
work in progress, resource previews
2015-05-31 06:59:42 +02:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Save thumbnail directly, as thumbnailer may not update due to actual scene not changing md5.
Implement shader caching * Shader compilation is now cached. Subsequent loads take less than a millisecond. * Improved game, editor and project manager startup time. * Editor uses .godot/shader_cache to store shaders. * Game uses user://shader_cache * Project manager uses $config_dir/shader_cache * Options to tweak shader caching in project settings. * Editor path configuration moved from EditorSettings to new class, EditorPaths, so it can be available early on (before shaders are compiled). * Reworked ShaderCompilerRD to ensure deterministic shader code creation (else shader may change and cache will be invalidated). * Added shader compression with SMOLV: https://github.com/aras-p/smol-v
2021-05-25 02:25:11 +02:00
String temp_path = EditorPaths::get_singleton()->get_cache_dir();
Don't create preview of empty scene.
2019-12-26 09:15:36 +01:00
String cache_base = ProjectSettings::get_singleton()->globalize_path(p_file).md5_text();
Rename String `plus_file` to `path_join`
2022-08-30 02:34:01 +02:00
cache_base = temp_path.path_join("resthumb-" + cache_base);
-Restored multithread capability to VisualServer -Restored resource previews!
2017-06-09 05:23:50 +02:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Does not have it, try to load a cached thumbnail.
Don't create preview of empty scene.
2019-12-26 09:15:36 +01:00
post_process_preview(img);
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-09-29 11:53:28 +02:00
img->save_png(cache_base + ".png");
Don't create preview of empty scene.
2019-12-26 09:15:36 +01:00
}
work in progress, resource previews
2015-05-31 06:59:42 +02:00
}
-Restored multithread capability to VisualServer -Restored resource previews!
2017-06-09 05:23:50 +02:00
Modified editor strings to be translatable in the future
2016-05-04 03:25:37 +02:00
save.step(TTR("Saving Scene"), 4);
Update meshes when reimporting, Save scene preview even when not doing save and play.
2017-11-12 04:48:00 +01:00
_save_scene(p_file, p_idx);
Export: Properly disable resource preview thread Fixes #26857. Fixes #34433. Fixes #34826.
2020-01-14 11:32:15 +01:00
if (!singleton->cmdline_export_mode) {
EditorResourcePreview::get_singleton()->check_for_invalidation(p_file);
}
work in progress, resource previews
2015-05-31 06:59:42 +02:00
}
Added test to avoid saving cyclic scene instancing, fixes #9686
2018-11-27 22:56:31 +01:00
bool EditorNode::_validate_scene_recursive(const String &p_filename, Node *p_node) {
for (int i = 0; i < p_node->get_child_count(); i++) {
Node *child = p_node->get_child(i);
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 16:30:55 +02:00
if (child->get_scene_file_path() == p_filename) {
Added test to avoid saving cyclic scene instancing, fixes #9686
2018-11-27 22:56:31 +01:00
return true;
}
if (_validate_scene_recursive(p_filename, child)) {
return true;
}
}
return false;
}
Save resources even if no scene is present, closes #26273
2019-02-28 00:00:40 +01:00
int EditorNode::_save_external_resources() {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Save external resources and its subresources if any was modified.
Save resources even if no scene is present, closes #26273
2019-02-28 00:00:40 +01:00
int flg = 0;
Unify usage of GLOBAL/EDITOR_GET
2022-10-18 16:43:37 +02:00
if (EDITOR_GET("filesystem/on_save/compress_binary_resources")) {
Save resources even if no scene is present, closes #26273
2019-02-28 00:00:40 +01:00
flg |= ResourceSaver::FLAG_COMPRESS;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Save resources even if no scene is present, closes #26273
2019-02-28 00:00:40 +01:00
flg |= ResourceSaver::FLAG_REPLACE_SUBRESOURCE_PATHS;
Simplify Subresource Saving Redo edited subresource (and resource) saving in a much more simplified way. I think this should work (unless I am missing something) and be faster than what is there. It should also supersede #55885. I am not 100% entirely convinced that this approach works, but I think it should so please test.
2022-06-22 19:03:43 +02:00
HashSet<String> edited_resources;
Save resources even if no scene is present, closes #26273
2019-02-28 00:00:40 +01:00
int saved = 0;
Style: Set clang-format Standard to Cpp11 For us, it practically only changes the fact that `A<A<int>>` is now used instead of the C++03 compatible `A<A<int> >`. Note: clang-format 10+ changed the `Standard` arguments to fully specified `c++11`, `c++14`, etc. versions, but we can't use `c++17` now if we want to preserve compatibility with clang-format 8 and 9. `Cpp11` is still supported as deprecated alias for `Latest`.
2020-03-17 07:33:00 +01:00
List<Ref<Resource>> cached;
Save resources even if no scene is present, closes #26273
2019-02-28 00:00:40 +01:00
ResourceCache::get_cached_resources(&cached);
Simplify Subresource Saving Redo edited subresource (and resource) saving in a much more simplified way. I think this should work (unless I am missing something) and be faster than what is there. It should also supersede #55885. I am not 100% entirely convinced that this approach works, but I think it should so please test.
2022-06-22 19:03:43 +02:00
for (Ref<Resource> res : cached) {
if (!res->is_edited()) {
Save resources even if no scene is present, closes #26273
2019-02-28 00:00:40 +01:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Save resources even if no scene is present, closes #26273
2019-02-28 00:00:40 +01:00
Simplify Subresource Saving Redo edited subresource (and resource) saving in a much more simplified way. I think this should work (unless I am missing something) and be faster than what is there. It should also supersede #55885. I am not 100% entirely convinced that this approach works, but I think it should so please test.
2022-06-22 19:03:43 +02:00
String path = res->get_path();
if (path.begins_with("res://")) {
int subres_pos = path.find("::");
if (subres_pos == -1) {
// Actual resource.
edited_resources.insert(path);
} else {
edited_resources.insert(path.substr(0, subres_pos));
}
}
Save resources even if no scene is present, closes #26273
2019-02-28 00:00:40 +01:00
res->set_edited(false);
}
Simplify Subresource Saving Redo edited subresource (and resource) saving in a much more simplified way. I think this should work (unless I am missing something) and be faster than what is there. It should also supersede #55885. I am not 100% entirely convinced that this approach works, but I think it should so please test.
2022-06-22 19:03:43 +02:00
for (const String &E : edited_resources) {
Fixup #62318 after ResourceCache changes
2022-06-27 14:02:21 +02:00
Ref<Resource> res = ResourceCache::get_ref(E);
Simplify Subresource Saving Redo edited subresource (and resource) saving in a much more simplified way. I think this should work (unless I am missing something) and be faster than what is there. It should also supersede #55885. I am not 100% entirely convinced that this approach works, but I think it should so please test.
2022-06-22 19:03:43 +02:00
if (!res.is_valid()) {
continue; // Maybe it was erased in a thread, who knows.
}
Ref<PackedScene> ps = res;
if (ps.is_valid()) {
continue; // Do not save PackedScenes, this will mess up the editor.
}
Swap arguments of ResourceSaver.save()
2022-06-03 01:33:42 +02:00
ResourceSaver::save(res, res->get_path(), flg);
Simplify Subresource Saving Redo edited subresource (and resource) saving in a much more simplified way. I think this should work (unless I am missing something) and be faster than what is there. It should also supersede #55885. I am not 100% entirely convinced that this approach works, but I think it should so please test.
2022-06-22 19:03:43 +02:00
saved++;
}
Add EditorUndoRedoManager singleton
2022-12-23 23:53:16 +01:00
EditorUndoRedoManager::get_singleton()->set_history_as_saved(EditorUndoRedoManager::GLOBAL_HISTORY);
Add per-scene UndoRedo
2022-03-25 18:06:46 +01:00
Save resources even if no scene is present, closes #26273
2019-02-28 00:00:40 +01:00
return saved;
}
Implement AnimationManager the base class of AnimationPlayer/Tree
2023-07-20 17:34:06 +02:00
static void _reset_animation_mixers(Node *p_node, List<Pair<AnimationMixer *, Ref<AnimatedValuesBackup>>> *r_anim_backups) {
Add animation reset track feature As a bonus, to have consistency between use Beziers and create insert tracks, use Beziers also gets a default via editor settings that is used when the confirmation dialog is disabled, instead of just falling back to creating non-Bezier tracks.
2020-12-20 11:46:44 +01:00
for (int i = 0; i < p_node->get_child_count(); i++) {
Implement AnimationManager the base class of AnimationPlayer/Tree
2023-07-20 17:34:06 +02:00
AnimationMixer *mixer = Object::cast_to<AnimationMixer>(p_node->get_child(i));
if (mixer && mixer->is_reset_on_save_enabled() && mixer->can_apply_reset()) {
Ref<AnimatedValuesBackup> backup = mixer->apply_reset();
if (backup.is_valid()) {
Pair<AnimationMixer *, Ref<AnimatedValuesBackup>> pair;
pair.first = mixer;
pair.second = backup;
r_anim_backups->push_back(pair);
Fixes crash when AnimationPlayer reset on save
2021-08-12 04:53:35 +02:00
}
Add animation reset track feature As a bonus, to have consistency between use Beziers and create insert tracks, use Beziers also gets a default via editor settings that is used when the confirmation dialog is disabled, instead of just falling back to creating non-Bezier tracks.
2020-12-20 11:46:44 +01:00
}
Implement AnimationManager the base class of AnimationPlayer/Tree
2023-07-20 17:34:06 +02:00
_reset_animation_mixers(p_node->get_child(i), r_anim_backups);
Add animation reset track feature As a bonus, to have consistency between use Beziers and create insert tracks, use Beziers also gets a default via editor settings that is used when the confirmation dialog is disabled, instead of just falling back to creating non-Bezier tracks.
2020-12-20 11:46:44 +01:00
}
}
Save all edited scenes when Runing (and auto-save is enabled). Fixes #4410
2016-06-26 05:54:17 +02:00
void EditorNode::_save_scene(String p_file, int idx) {
Avoid saving scene while already saving the scene
2023-11-20 21:57:21 +01:00
if (!saving_scene.is_empty() && saving_scene == p_file) {
return;
}
Save all edited scenes when Runing (and auto-save is enabled). Fixes #4410
2016-06-26 05:54:17 +02:00
Node *scene = editor_data.get_edited_scene_root(idx);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (!scene) {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 16:47:41 +02:00
show_accept(TTR("This operation can't be done without a tree root."), TTR("OK"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return;
}
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 10:42:46 +01:00
if (!scene->get_scene_file_path().is_empty() && _validate_scene_recursive(scene->get_scene_file_path(), scene)) {
Remove more instances of 'instance' being used as a verb
2022-11-16 00:13:39 +01:00
show_accept(TTR("This scene can't be saved because there is a cyclic instance inclusion.\nPlease resolve it and then attempt to save again."), TTR("OK"));
Added test to avoid saving cyclic scene instancing, fixes #9686
2018-11-27 22:56:31 +01:00
return;
}
New and improved IK system for Skeleton2D This PR and commit adds a new IK system for 2D with the Skeleton2D node that adds several new IK solvers, a way to control bones in a Skeleton2D node similar to that in Skeleton3D. It also adds additional changes and functionality. This work was sponsored by GSoC 2020 and TwistedTwigleg. Full list of changes: * Adds a SkeletonModifier2D resource * This resource is the base where all IK code is written and executed * Has a function for clamping angles, since it is so commonly used * Modifiers are unique when duplicated so it works with instancing * Adds a SkeletonModifierStack2D resource * This resource manages a series of SkeletonModification2Ds * This is what the Skeleton2D directly interfaces with to make IK possible * Adds SkeletonModifier2D resources for LookAt, CCDIK, FABRIK, Jiggle, and TwoBoneIK * Each modification is in its own file * There is also a SkeletonModifier2D resource that acts as a stack for using multiple stacks together * Adds a PhysicalBone2D node * Works similar to the PhysicalBone3D node, but uses a RigidBody2D node * Changes to Skeleton2D listed below: * Skeleton2D now holds a single SkeletonModificationStack2D for IK * Skeleton2D now has a local_pose_override, which overrides the Bone2D position similar to how the overrides work in Skeleton3D * Changes to Bone2D listed below: * The default_length property has been changed to length. Length is the length of the bone to its child bone node * New bone_angle property, which is the angle the bone has to its first child bone node * Bone2D caches its transform when not modified by IK for IK interpolation purposes * Bone2D draws its own editor gizmo, though this is stated to change in the future * Changes to CanvasItemEditor listed below: * Bone2D gizmo drawing code removed * The 2D IK code is removed. Now Bone2D is the only bone system for 2D * Transform2D now has a looking_at function for rotating to face a position * Two new node notifications: NOTIFICATION_EDITOR_PRE_SAVE and NOTIFICATION_EDITOR_POST_SAVE * These notifications only are called in the editor right before and after saving a scene * Needed for not saving the IK position when executing IK in the editor * Documentation for all the changes listed above.
2020-08-03 20:02:24 +02:00
scene->propagate_notification(NOTIFICATION_EDITOR_PRE_SAVE);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
editor_data.apply_changes_in_editors();
Implement AnimationManager the base class of AnimationPlayer/Tree
2023-07-20 17:34:06 +02:00
List<Pair<AnimationMixer *, Ref<AnimatedValuesBackup>>> anim_backups;
_reset_animation_mixers(scene, &anim_backups);
Extract editor run toolbar into its own component - Simplify and update its logic. - Simplify EditorScript. - Improve EditorNode and other relevant includes. - Fix scene-based path in the movie writer when reloading a scene.
2023-04-12 21:02:28 +02:00
save_default_environment();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Improve editor state persistence
2023-05-11 04:17:03 +02:00
_save_editor_states(p_file, idx);
-scenes are properly reloaded when a dependency changes, fixes #2896 (it's clevery done so local changes to scenes are kept even if unsaved)
2015-12-14 00:39:01 +01:00
Ref<PackedScene> sdata;
if (ResourceCache::has(p_file)) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Something may be referencing this resource and we are good with that.
// We must update it, but also let the previous scene state go, as
// old version still work for referencing changes in instantiated or inherited scenes.
-scenes are properly reloaded when a dependency changes, fixes #2896 (it's clevery done so local changes to scenes are kept even if unsaved)
2015-12-14 00:39:01 +01:00
Remake resource thread safety and API * Ensures thread safety when resources are destroyed. * Simplified API by always forcing `ResourceCache::get_ref`, which needs less hacks and is fully thread safe. * Removed RWLock for resources because its not possible to use for the new logic. Should not be a problem. Supersedes #57533
2022-06-22 13:46:46 +02:00
sdata = ResourceCache::get_ref(p_file);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (sdata.is_valid()) {
-scenes are properly reloaded when a dependency changes, fixes #2896 (it's clevery done so local changes to scenes are kept even if unsaved)
2015-12-14 00:39:01 +01:00
sdata->recreate_state();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
} else {
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
sdata.instantiate();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
-scenes are properly reloaded when a dependency changes, fixes #2896 (it's clevery done so local changes to scenes are kept even if unsaved)
2015-12-14 00:39:01 +01:00
} else {
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
sdata.instantiate();
-scenes are properly reloaded when a dependency changes, fixes #2896 (it's clevery done so local changes to scenes are kept even if unsaved)
2015-12-14 00:39:01 +01:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Error err = sdata->pack(scene);
if (err != OK) {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 16:47:41 +02:00
show_accept(TTR("Couldn't save scene. Likely dependencies (instances or inheritance) couldn't be satisfied."), TTR("OK"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return;
}
int flg = 0;
Unify usage of GLOBAL/EDITOR_GET
2022-10-18 16:43:37 +02:00
if (EDITOR_GET("filesystem/on_save/compress_binary_resources")) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
flg |= ResourceSaver::FLAG_COMPRESS;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Misc Fixes ========== -NOTIFICATION_WM_QUIT fixed on android (seems tha way this is reported changed in newer sdk) -WIP implementation of APK Expansion APIs for publishing games larger than 50mb in Play Store -Feaures in the new tutorials are all present in the sourcecode -This (hopefully) should get rid of the animation list order getting corrupted -Improved 3D Scene Importer (Skeletons, Animations and other stuff were not being merged). Anything missing? -In code editor, the automatic syntax checker will only use file_exists() to check preload() else it might freeze the editor too much while typing if the preload is a big resource -Fixed bugs in PolygonPathFinder, stil pending to do a node and a demo
2014-06-28 04:21:45 +02:00
flg |= ResourceSaver::FLAG_REPLACE_SUBRESOURCE_PATHS;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Swap arguments of ResourceSaver.save()
2022-06-03 01:33:42 +02:00
err = ResourceSaver::save(sdata, p_file, flg);
If resources on disk have subresources and they are edited, also save the resource on ctrl-s
2019-02-27 03:48:30 +01:00
Improve save handling for built-in scripts
2021-11-06 02:15:19 +01:00
// This needs to be emitted before saving external resources.
emit_signal(SNAME("scene_saved"), p_file);
-Fix in animationplayback, sound would be cut on loop -Fix on scene importer, keeping changes to animation tracks was not working
2018-07-01 22:44:15 +02:00
Improve save handling for built-in scripts
2021-11-06 02:15:19 +01:00
_save_external_resources();
Avoid saving scene while already saving the scene
2023-11-20 21:57:21 +01:00
saving_scene = p_file; // Some editors may save scenes of built-in resources as external data, so avoid saving this scene again.
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
editor_data.save_editor_external_data();
Avoid saving scene while already saving the scene
2023-11-20 21:57:21 +01:00
saving_scene = "";
Add animation reset track feature As a bonus, to have consistency between use Beziers and create insert tracks, use Beziers also gets a default via editor settings that is used when the confirmation dialog is disabled, instead of just falling back to creating non-Bezier tracks.
2020-12-20 11:46:44 +01:00
Implement AnimationManager the base class of AnimationPlayer/Tree
2023-07-20 17:34:06 +02:00
for (Pair<AnimationMixer *, Ref<AnimatedValuesBackup>> &E : anim_backups) {
E.first->restore(E.second);
Add animation reset track feature As a bonus, to have consistency between use Beziers and create insert tracks, use Beziers also gets a default via editor settings that is used when the confirmation dialog is disabled, instead of just falling back to creating non-Bezier tracks.
2020-12-20 11:46:44 +01:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (err == OK) {
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 16:30:55 +02:00
scene->set_scene_file_path(ProjectSettings::get_singleton()->localize_path(p_file));
Add per-scene UndoRedo
2022-03-25 18:06:46 +01:00
editor_data.set_scene_as_saved(idx);
Detect external modification of scenes
2019-08-28 19:42:27 +02:00
editor_data.set_scene_modified_time(idx, FileAccess::get_modified_time(p_file));
Moved folding outside the resource files, now saved outside the project.
2018-10-29 20:36:31 +01:00
editor_folding.save_scene_folding(scene, p_file);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
_update_title();
Extract editor scene tabs into their own component
2023-08-24 12:24:29 +02:00
scene_tabs->update_scene_tabs();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} else {
EditorNode: enhance open scene error dialog
2017-08-28 05:24:50 +02:00
_dialog_display_save_error(p_file, err);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
New and improved IK system for Skeleton2D This PR and commit adds a new IK system for 2D with the Skeleton2D node that adds several new IK solvers, a way to control bones in a Skeleton2D node similar to that in Skeleton3D. It also adds additional changes and functionality. This work was sponsored by GSoC 2020 and TwistedTwigleg. Full list of changes: * Adds a SkeletonModifier2D resource * This resource is the base where all IK code is written and executed * Has a function for clamping angles, since it is so commonly used * Modifiers are unique when duplicated so it works with instancing * Adds a SkeletonModifierStack2D resource * This resource manages a series of SkeletonModification2Ds * This is what the Skeleton2D directly interfaces with to make IK possible * Adds SkeletonModifier2D resources for LookAt, CCDIK, FABRIK, Jiggle, and TwoBoneIK * Each modification is in its own file * There is also a SkeletonModifier2D resource that acts as a stack for using multiple stacks together * Adds a PhysicalBone2D node * Works similar to the PhysicalBone3D node, but uses a RigidBody2D node * Changes to Skeleton2D listed below: * Skeleton2D now holds a single SkeletonModificationStack2D for IK * Skeleton2D now has a local_pose_override, which overrides the Bone2D position similar to how the overrides work in Skeleton3D * Changes to Bone2D listed below: * The default_length property has been changed to length. Length is the length of the bone to its child bone node * New bone_angle property, which is the angle the bone has to its first child bone node * Bone2D caches its transform when not modified by IK for IK interpolation purposes * Bone2D draws its own editor gizmo, though this is stated to change in the future * Changes to CanvasItemEditor listed below: * Bone2D gizmo drawing code removed * The 2D IK code is removed. Now Bone2D is the only bone system for 2D * Transform2D now has a looking_at function for rotating to face a position * Two new node notifications: NOTIFICATION_EDITOR_PRE_SAVE and NOTIFICATION_EDITOR_POST_SAVE * These notifications only are called in the editor right before and after saving a scene * Needed for not saving the IK position when executing IK in the editor * Documentation for all the changes listed above.
2020-08-03 20:02:24 +02:00
scene->propagate_notification(NOTIFICATION_EDITOR_POST_SAVE);
-Added .hdr format support -Added default environment editor setting -Added environment created by default in new projects -Removed default light and ambient from spatial editor, to make the editor more PBR compliant
2017-05-29 02:46:48 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Properly warn about the effects of changing an import type, as well as force editor restart. Fixes #23874
2019-01-25 21:23:56 +01:00
void EditorNode::save_all_scenes() {
Extract editor run toolbar into its own component - Simplify and update its logic. - Simplify EditorScript. - Improve EditorNode and other relevant includes. - Fix scene-based path in the movie writer when reloading a scene.
2023-04-12 21:02:28 +02:00
project_run_bar->stop_playing();
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
_save_all_scenes();
Properly warn about the effects of changing an import type, as well as force editor restart. Fixes #23874
2019-01-25 21:23:56 +01:00
}
Use Hashset for dependency list when moving
2023-10-25 15:16:38 +02:00
void EditorNode::save_scene_if_open(const String &p_scene_path) {
int idx = editor_data.get_edited_scene_from_path(p_scene_path);
if (idx >= 0) {
_save_scene(p_scene_path, idx);
}
}
void EditorNode::save_scene_list(const HashSet<String> &p_scene_paths) {
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 05:36:23 +02:00
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
Node *scene = editor_data.get_edited_scene_root(i);
Use Hashset for dependency list when moving
2023-10-25 15:16:38 +02:00
if (scene && p_scene_paths.has(scene->get_scene_file_path())) {
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 16:30:55 +02:00
_save_scene(scene->get_scene_file_path(), i);
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 05:36:23 +02:00
}
}
}
Extract editor run toolbar into its own component - Simplify and update its logic. - Simplify EditorScript. - Improve EditorNode and other relevant includes. - Fix scene-based path in the movie writer when reloading a scene.
2023-04-12 21:02:28 +02:00
void EditorNode::save_before_run() {
current_menu_option = FILE_SAVE_AND_RUN;
_menu_option_confirm(FILE_SAVE_AS_SCENE, true);
file->set_title(TTR("Save scene before running..."));
}
void EditorNode::try_autosave() {
if (!bool(EDITOR_GET("run/auto_save/save_before_running"))) {
return;
}
if (unsaved_cache) {
Node *scene = editor_data.get_edited_scene_root();
if (scene && !scene->get_scene_file_path().is_empty()) { // Only autosave if there is a scene and if it has a path.
_save_scene_with_preview(scene->get_scene_file_path());
}
}
_menu_option(FILE_SAVE_ALL_SCENES);
editor_data.save_editor_external_data();
}
Properly warn about the effects of changing an import type, as well as force editor restart. Fixes #23874
2019-01-25 21:23:56 +01:00
void EditorNode::restart_editor() {
exiting = true;
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
Extract editor run toolbar into its own component - Simplify and update its logic. - Simplify EditorScript. - Improve EditorNode and other relevant includes. - Fix scene-based path in the movie writer when reloading a scene.
2023-04-12 21:02:28 +02:00
if (project_run_bar->is_playing()) {
project_run_bar->stop_playing();
Stop game on reloading project
2022-06-17 02:20:37 +02:00
}
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
String to_reopen;
if (get_tree()->get_edited_scene_root()) {
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 16:30:55 +02:00
to_reopen = get_tree()->get_edited_scene_root()->get_scene_file_path();
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
}
Replace use of `OS::set_exit_code()` by `SceneTree::quit()` in `EditorNode`
2022-01-18 12:48:12 +01:00
_exit_editor(EXIT_SUCCESS);
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
List<String> args;
Keep crash handler status on editor restart
2022-07-26 19:07:06 +02:00
Overhaul CLI argument forwarding to processes started by the editor
2022-08-13 21:52:03 +02:00
for (const String &a : Main::get_forwardable_cli_arguments(Main::CLI_SCOPE_TOOL)) {
args.push_back(a);
}
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
args.push_back("--path");
args.push_back(ProjectSettings::get_singleton()->get_resource_path());
Keep crash handler status on editor restart
2022-07-26 19:07:06 +02:00
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
args.push_back("-e");
Keep crash handler status on editor restart
2022-07-26 19:07:06 +02:00
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 10:42:46 +01:00
if (!to_reopen.is_empty()) {
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
args.push_back(to_reopen);
}
OS::get_singleton()->set_restart_on_exit(true, args);
}
EditorNode: enhance quit dialog
2017-06-24 12:57:30 +02:00
void EditorNode::_save_all_scenes() {
Fixed editor attempting to save a blank scene with save all scenes
2021-10-12 12:14:02 +02:00
bool all_saved = true;
Revert "Fix saving unmodified scenes and resources" This reverts commits 28ab60422d648d43d219186ea0ecffce1645188f and 7821b70a00768cb99c0b48450eabe5a687ae276c. Fixes #19576, and likely the fact that subresources are no longer saved when saving scenes with no change.
2018-06-29 08:38:15 +02:00
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
EditorNode: enhance quit dialog
2017-06-24 12:57:30 +02:00
Node *scene = editor_data.get_edited_scene_root(i);
Fixed editor attempting to save a blank scene with save all scenes
2021-10-12 12:14:02 +02:00
if (scene) {
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 10:42:46 +01:00
if (!scene->get_scene_file_path().is_empty() && DirAccess::exists(scene->get_scene_file_path().get_base_dir())) {
Fixed editor attempting to save a blank scene with save all scenes
2021-10-12 12:14:02 +02:00
if (i != editor_data.get_edited_scene()) {
_save_scene(scene->get_scene_file_path(), i);
} else {
_save_scene_with_preview(scene->get_scene_file_path());
}
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 10:42:46 +01:00
} else if (!scene->get_scene_file_path().is_empty()) {
Fixed editor attempting to save a blank scene with save all scenes
2021-10-12 12:14:02 +02:00
all_saved = false;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Corrected Save Scene and Save All Scenes not working when the scene's dir no longer exists
2021-09-11 03:35:13 +02:00
}
EditorNode: enhance quit dialog
2017-06-24 12:57:30 +02:00
}
Fixed editor attempting to save a blank scene with save all scenes
2021-10-12 12:14:02 +02:00
if (!all_saved) {
show_warning(TTR("Could not save one or more scenes!"), TTR("Save All Scenes"));
}
Extract editor run toolbar into its own component - Simplify and update its logic. - Simplify EditorScript. - Improve EditorNode and other relevant includes. - Fix scene-based path in the movie writer when reloading a scene.
2023-04-12 21:02:28 +02:00
save_default_environment();
EditorNode: enhance quit dialog
2017-06-24 12:57:30 +02:00
}
EditorNode: mark opened deleted scenes as unsaved
2017-06-29 19:37:54 +02:00
void EditorNode::_mark_unsaved_scenes() {
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
Node *node = editor_data.get_edited_scene_root(i);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!node) {
EditorNode: mark opened deleted scenes as unsaved
2017-06-29 19:37:54 +02:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
EditorNode: mark opened deleted scenes as unsaved
2017-06-29 19:37:54 +02:00
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 16:30:55 +02:00
String path = node->get_scene_file_path();
Add per-scene UndoRedo
2022-03-25 18:06:46 +01:00
if (!path.is_empty() && !FileAccess::exists(path)) {
// Mark scene tab as unsaved if the file is gone.
Add EditorUndoRedoManager singleton
2022-12-23 23:53:16 +01:00
EditorUndoRedoManager::get_singleton()->set_history_as_unsaved(editor_data.get_scene_history_id(i));
EditorNode: mark opened deleted scenes as unsaved
2017-06-29 19:37:54 +02:00
}
}
_update_title();
Extract editor scene tabs into their own component
2023-08-24 12:24:29 +02:00
scene_tabs->update_scene_tabs();
EditorNode: mark opened deleted scenes as unsaved
2017-06-29 19:37:54 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
void EditorNode::_dialog_action(String p_file) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
switch (current_menu_option) {
Large improvements on scene packing and management -Ability to edit and keep changes of instanced scenes and sub-scenes -Ability to inherit from other scenes
2015-10-10 14:09:09 +02:00
case FILE_NEW_INHERITED_SCENE: {
Change empty scene closing on new inherented scene to a better approach
2019-05-08 08:12:39 +02:00
Node *scene = editor_data.get_edited_scene_root();
// If the previous scene is rootless, just close it in favor of the new one.
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!scene) {
Fix crash when inherit in rootless unsaved scene
2019-05-31 02:08:37 +02:00
_menu_option_confirm(FILE_CLOSE, true);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Change empty scene closing on new inherented scene to a better approach
2019-05-08 08:12:39 +02:00
Large improvements on scene packing and management -Ability to edit and keep changes of instanced scenes and sub-scenes -Ability to inherit from other scenes
2015-10-10 14:09:09 +02:00
load_scene(p_file, false, true);
} break;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
case FILE_OPEN_SCENE: {
load_scene(p_file);
} break;
Ask about selecting a main scene if one has not been selected.
2016-06-28 00:59:33 +02:00
case SETTINGS_PICK_MAIN_SCENE: {
-Renamed GlobalConfig to ProjectSettings, makes more sense. -Added system for feature overrides, it's pretty cool :)
2017-07-19 22:00:46 +02:00
ProjectSettings::get_singleton()->set("application/run/main_scene", p_file);
ProjectSettings::get_singleton()->save();
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// TODO: Would be nice to show the project manager opened with the highlighted field.
Ensure main scene is set when running on device
2019-03-22 02:08:28 +01:00
Extract editor run toolbar into its own component - Simplify and update its logic. - Simplify EditorScript. - Improve EditorNode and other relevant includes. - Fix scene-based path in the movie writer when reloading a scene.
2023-04-12 21:02:28 +02:00
project_run_bar->play_main_scene((bool)pick_main_scene->get_meta("from_native", false));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 06:15:39 +02:00
case FILE_CLOSE:
case SCENE_TAB_CLOSE:
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
case FILE_SAVE_SCENE:
case FILE_SAVE_AS_SCENE: {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
int scene_idx = (current_menu_option == FILE_SAVE_SCENE || current_menu_option == FILE_SAVE_AS_SCENE) ? -1 : tab_closing_idx;
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 06:15:39 +02:00
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
if (file->get_file_mode() == EditorFileDialog::FILE_MODE_SAVE_FILE) {
Prevent overwriting open scenes when saving Prevent overwriting open scenes when saving, this fixes #17628
2018-09-07 15:54:26 +02:00
bool same_open_scene = false;
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (editor_data.get_scene_path(i) == p_file && i != scene_idx) {
Prevent overwriting open scenes when saving Prevent overwriting open scenes when saving, this fixes #17628
2018-09-07 15:54:26 +02:00
same_open_scene = true;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Prevent overwriting open scenes when saving Prevent overwriting open scenes when saving, this fixes #17628
2018-09-07 15:54:26 +02:00
}
if (same_open_scene) {
show_warning(TTR("Can't overwrite scene that is still open!"));
return;
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Extract editor run toolbar into its own component - Simplify and update its logic. - Simplify EditorScript. - Improve EditorNode and other relevant includes. - Fix scene-based path in the movie writer when reloading a scene.
2023-04-12 21:02:28 +02:00
save_default_environment();
Update meshes when reimporting, Save scene preview even when not doing save and play.
2017-11-12 04:48:00 +01:00
_save_scene_with_preview(p_file, scene_idx);
Small changes to the "Recent Scenes" menu.
2018-01-09 13:42:45 +01:00
_add_to_recent_scenes(p_file);
Improve editor state persistence
2023-05-11 04:17:03 +02:00
save_editor_layout_delayed();
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 06:15:39 +02:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (scene_idx != -1) {
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 06:15:39 +02:00
_discard_changes();
Fix history mismatch Set the properties of the resource's proxy instead of setting the resource's properties directly. (For action "Set ...") Update the path of the edited scene when saving the scene. (For action "Add atlas source")
2023-06-29 09:38:19 +02:00
} else {
// Update the path of the edited scene to ensure later do/undo action history matches.
editor_data.set_scene_path(editor_data.get_edited_scene(), p_file);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
} break;
Prompt save dialog if running a unsaved scene. Solution for #966
2015-01-06 23:28:25 +01:00
case FILE_SAVE_AND_RUN: {
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
if (file->get_file_mode() == EditorFileDialog::FILE_MODE_SAVE_FILE) {
Extract editor run toolbar into its own component - Simplify and update its logic. - Simplify EditorScript. - Improve EditorNode and other relevant includes. - Fix scene-based path in the movie writer when reloading a scene.
2023-04-12 21:02:28 +02:00
save_default_environment();
work in progress, resource previews
2015-05-31 06:59:42 +02:00
_save_scene_with_preview(p_file);
Extract editor run toolbar into its own component - Simplify and update its logic. - Simplify EditorScript. - Improve EditorNode and other relevant includes. - Fix scene-based path in the movie writer when reloading a scene.
2023-04-12 21:02:28 +02:00
project_run_bar->play_custom_scene(p_file);
Prompt save dialog if running a unsaved scene. Solution for #966
2015-01-06 23:28:25 +01:00
}
} break;
[Editor]: Allow `Select Current` to Save Scenes [Editor]: Change `Select Current` to Save scenes before attempting to Run them.
2022-06-22 05:56:09 +02:00
case FILE_SAVE_AND_RUN_MAIN_SCENE: {
ProjectSettings::get_singleton()->set("application/run/main_scene", p_file);
ProjectSettings::get_singleton()->save();
if (file->get_file_mode() == EditorFileDialog::FILE_MODE_SAVE_FILE) {
Extract editor run toolbar into its own component - Simplify and update its logic. - Simplify EditorScript. - Improve EditorNode and other relevant includes. - Fix scene-based path in the movie writer when reloading a scene.
2023-04-12 21:02:28 +02:00
save_default_environment();
[Editor]: Allow `Select Current` to Save Scenes [Editor]: Change `Select Current` to Save scenes before attempting to Run them.
2022-06-22 05:56:09 +02:00
_save_scene_with_preview(p_file);
Extract editor run toolbar into its own component - Simplify and update its logic. - Simplify EditorScript. - Improve EditorNode and other relevant includes. - Fix scene-based path in the movie writer when reloading a scene.
2023-04-12 21:02:28 +02:00
project_run_bar->play_main_scene((bool)pick_main_scene->get_meta("from_native", false));
[Editor]: Allow `Select Current` to Save Scenes [Editor]: Change `Select Current` to Save scenes before attempting to Run them.
2022-06-22 05:56:09 +02:00
}
} break;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
case FILE_EXPORT_MESH_LIBRARY: {
Ref<MeshLibrary> ml;
if (file_export_lib_merge->is_pressed() && FileAccess::exists(p_file)) {
ml = ResourceLoader::load(p_file, "MeshLibrary");
if (ml.is_null()) {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 16:47:41 +02:00
show_accept(TTR("Can't load MeshLibrary for merging!"), TTR("OK"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return;
}
}
if (ml.is_null()) {
ml = Ref<MeshLibrary>(memnew(MeshLibrary));
}
implement individual mesh transform for meshlibrary items
2021-09-01 01:17:33 +02:00
MeshLibraryEditor::update_library_file(editor_data.get_edited_scene_root(), ml, true, file_export_lib_apply_xforms->is_pressed());
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Swap arguments of ResourceSaver.save()
2022-06-03 01:33:42 +02:00
Error err = ResourceSaver::save(ml, p_file);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (err) {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 16:47:41 +02:00
show_accept(TTR("Error saving MeshLibrary!"), TTR("OK"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return;
Fix problems reloading MeshLibrary
2023-06-11 18:52:49 +02:00
} else if (ResourceCache::has(p_file)) {
// Make sure MeshLibrary is updated in the editor.
ResourceLoader::load(p_file)->reload_from_file();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
} break;
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
case RESOURCE_SAVE:
case RESOURCE_SAVE_AS: {
Fix error macro calls not ending with semicolon It's not necessary, but the vast majority of calls of error macros do have an ending semicolon, so it's best to be consistent. Most WARN_DEPRECATED calls did *not* have a semicolon, but there's no reason for them to be treated differently.
2019-06-11 14:49:34 +02:00
ERR_FAIL_COND(saving_resource.is_null());
Add Save option to resource property menu
2018-11-18 15:17:04 +01:00
save_resource_in_path(saving_resource, p_file);
saving_resource = Ref<Resource>();
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-09-29 11:53:28 +02:00
ObjectID current_id = editor_history.get_current();
Object *current_obj = current_id.is_valid() ? ObjectDB::get_instance(current_id) : nullptr;
[Editor] Replace `ERR_FAIL_COND` with `ERR_FAIL_NULL` where applicable
2023-09-09 17:24:40 +02:00
ERR_FAIL_NULL(current_obj);
Removed _change_notify -For inspector refresh, the inspector now detects if a property change by polling a few times per second and then does update the control if so. This process is very cheap. -For property list refresh, a new signal (property_list_changed) was added to Object. _change_notify() is replaced by notify_property_list_changed() -Changed all objects using the old method to the signal, or just deleted the calls to _change_notify(<property>) since they are unnecesary now.
2021-02-10 21:18:45 +01:00
current_obj->notify_property_list_changed();
Editor layouts menu
2015-11-22 19:11:17 +01:00
} break;
case SETTINGS_LAYOUT_SAVE: {
Rename empty() to is_empty()
2020-12-15 13:04:21 +01:00
if (p_file.is_empty()) {
Editor layouts menu
2015-11-22 19:11:17 +01:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Editor layouts menu
2015-11-22 19:11:17 +01:00
Ref<ConfigFile> config;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
config.instantiate();
Use new XDG folders to dehardcode paths
2017-11-17 21:48:24 +01:00
Error err = config->load(EditorSettings::get_singleton()->get_editor_layouts_config());
Fix editor layout saving
2016-01-01 18:48:14 +01:00
Fix layout saving error As a result of commit b49226e085 FileAccess::open no longer returns ERR_CANT_OPEN if the file cannot be found/opened. Instead check against ERR_FILE_NOT_FOUND or ERR_FILE_CANT_OPEN.
2019-10-23 15:02:51 +02:00
if (err == ERR_FILE_CANT_OPEN || err == ERR_FILE_NOT_FOUND) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
config.instantiate();
Fix editor layout saving
2016-01-01 18:48:14 +01:00
} else if (err != OK) {
Improve messages related to overriding the default editor layout This closes #33884.
2020-08-02 14:12:50 +02:00
show_warning(TTR("An error occurred while trying to save the editor layout.\nMake sure the editor's user data path is writable."));
Fix editor layout saving
2016-01-01 18:48:14 +01:00
return;
Editor layouts menu
2015-11-22 19:11:17 +01:00
}
_save_docks_to_config(config, p_file);
Use new XDG folders to dehardcode paths
2017-11-17 21:48:24 +01:00
config->save(EditorSettings::get_singleton()->get_editor_layouts_config());
Editor layouts menu
2015-11-22 19:11:17 +01:00
layout_dialog->hide();
_update_layouts_menu();
Allow to override the default editor layout
2016-01-11 22:23:45 +01:00
if (p_file == "Default") {
Improve messages related to overriding the default editor layout This closes #33884.
2020-08-02 14:12:50 +02:00
show_warning(TTR("Default editor layout overridden.\nTo restore the Default layout to its base settings, use the Delete Layout option and delete the Default layout."));
Allow to override the default editor layout
2016-01-11 22:23:45 +01:00
}
Editor layouts menu
2015-11-22 19:11:17 +01:00
} break;
case SETTINGS_LAYOUT_DELETE: {
Rename empty() to is_empty()
2020-12-15 13:04:21 +01:00
if (p_file.is_empty()) {
Editor layouts menu
2015-11-22 19:11:17 +01:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Editor layouts menu
2015-11-22 19:11:17 +01:00
Ref<ConfigFile> config;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
config.instantiate();
Use new XDG folders to dehardcode paths
2017-11-17 21:48:24 +01:00
Error err = config->load(EditorSettings::get_singleton()->get_editor_layouts_config());
Editor layouts menu
2015-11-22 19:11:17 +01:00
Fix editor layout saving
2016-01-01 18:48:14 +01:00
if (err != OK || !config->has_section(p_file)) {
Modified editor strings to be translatable in the future
2016-05-04 03:25:37 +02:00
show_warning(TTR("Layout name not found!"));
Editor layouts menu
2015-11-22 19:11:17 +01:00
return;
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Erase key values.
Editor layouts menu
2015-11-22 19:11:17 +01:00
List<String> keys;
config->get_section_keys(p_file, &keys);
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
for (const String &key : keys) {
config->set_value(p_file, key, Variant());
Editor layouts menu
2015-11-22 19:11:17 +01:00
}
Use new XDG folders to dehardcode paths
2017-11-17 21:48:24 +01:00
config->save(EditorSettings::get_singleton()->get_editor_layouts_config());
Editor layouts menu
2015-11-22 19:11:17 +01:00
layout_dialog->hide();
_update_layouts_menu();
Allow to override the default editor layout
2016-01-11 22:23:45 +01:00
if (p_file == "Default") {
Improve messages related to overriding the default editor layout This closes #33884.
2020-08-02 14:12:50 +02:00
show_warning(TTR("Restored the Default layout to its base settings."));
Allow to override the default editor layout
2016-01-11 22:23:45 +01:00
}
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
} break;
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
default: {
// Save scene?
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
if (file->get_file_mode() == EditorFileDialog::FILE_MODE_SAVE_FILE) {
work in progress, resource previews
2015-05-31 06:59:42 +02:00
_save_scene_with_preview(p_file);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
remove trailing whitespace
2016-03-09 00:00:52 +01:00
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
}
}
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
bool EditorNode::_is_class_editor_disabled_by_feature_profile(const StringName &p_class) {
Ref<EditorFeatureProfile> profile = EditorFeatureProfileManager::get_singleton()->get_current_profile();
if (profile.is_null()) {
return false;
}
StringName class_name = p_class;
while (class_name != StringName()) {
Changes to to feature profile editor Changed "Disable Editor" to "Contextual Editor Enabled" Do not show contextual editors for disabled classes.
2019-04-09 01:20:20 +02:00
if (profile->is_class_disabled(class_name)) {
return true;
}
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
if (profile->is_class_editor_disabled(class_name)) {
return true;
}
class_name = ClassDB::get_parent_class(class_name);
}
return false;
}
Rework EditorPlugin editing logic
2023-01-21 22:49:06 +01:00
void EditorNode::edit_item(Object *p_object, Object *p_editing_owner) {
ERR_FAIL_NULL(p_editing_owner);
Avoid unnecessary inspector updates when loading or switching scenes This should result in some noticeable performance improvements, aside from fixing bugs due to conflicts in logic. This also simplifies some related code identified while debugging.
2023-08-11 15:55:47 +02:00
// Editing for this type of object may be disabled by user's feature profile.
if (!p_object || _is_class_editor_disabled_by_feature_profile(p_object->get_class())) {
// Nothing to edit, clean up the owner context and return.
hide_unused_editors(p_editing_owner);
Simplify some editor plugin logic and remove dead code
2023-01-05 19:04:37 +01:00
return;
}
Fix crashes, ability to add blendpsace into blendtree, ability to delete with delete key
2018-06-21 23:08:11 +02:00
Avoid unnecessary inspector updates when loading or switching scenes This should result in some noticeable performance improvements, aside from fixing bugs due to conflicts in logic. This also simplifies some related code identified while debugging.
2023-08-11 15:55:47 +02:00
// Get a list of editor plugins that can handle this type of object.
Vector<EditorPlugin *> available_plugins = editor_data.get_handling_sub_editors(p_object);
if (available_plugins.is_empty()) {
// None, clean up the owner context and return.
hide_unused_editors(p_editing_owner);
return;
Fix crashes, ability to add blendpsace into blendtree, ability to delete with delete key
2018-06-21 23:08:11 +02:00
}
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 03:10:48 +02:00
Avoid unnecessary inspector updates when loading or switching scenes This should result in some noticeable performance improvements, aside from fixing bugs due to conflicts in logic. This also simplifies some related code identified while debugging.
2023-08-11 15:55:47 +02:00
ObjectID owner_id = p_editing_owner->get_instance_id();
Rework EditorPlugin editing logic
2023-01-21 22:49:06 +01:00
Avoid unnecessary inspector updates when loading or switching scenes This should result in some noticeable performance improvements, aside from fixing bugs due to conflicts in logic. This also simplifies some related code identified while debugging.
2023-08-11 15:55:47 +02:00
// Remove editor plugins no longer used by this editing owner. Keep the ones that can
// still be reused by the new edited object.
Simplify some editor plugin logic and remove dead code
2023-01-05 19:04:37 +01:00
Avoid unnecessary inspector updates when loading or switching scenes This should result in some noticeable performance improvements, aside from fixing bugs due to conflicts in logic. This also simplifies some related code identified while debugging.
2023-08-11 15:55:47 +02:00
List<EditorPlugin *> to_remove;
for (EditorPlugin *plugin : active_plugins[owner_id]) {
if (!available_plugins.has(plugin)) {
to_remove.push_back(plugin);
Allow contextual plugins to persist temporarily
2023-09-10 21:29:28 +02:00
if (plugin->can_auto_hide()) {
_plugin_over_edit(plugin, nullptr);
} else {
// If plugin can't be hidden, make it own itself and become responsible for closing.
_plugin_over_self_own(plugin);
}
Fix editors potentially being used twice
2023-01-28 21:44:20 +01:00
}
Avoid unnecessary inspector updates when loading or switching scenes This should result in some noticeable performance improvements, aside from fixing bugs due to conflicts in logic. This also simplifies some related code identified while debugging.
2023-08-11 15:55:47 +02:00
}
Fix editors potentially being used twice
2023-01-28 21:44:20 +01:00
Avoid unnecessary inspector updates when loading or switching scenes This should result in some noticeable performance improvements, aside from fixing bugs due to conflicts in logic. This also simplifies some related code identified while debugging.
2023-08-11 15:55:47 +02:00
for (EditorPlugin *plugin : to_remove) {
active_plugins[owner_id].erase(plugin);
}
Fix editors potentially being used twice
2023-01-28 21:44:20 +01:00
Avoid unnecessary inspector updates when loading or switching scenes This should result in some noticeable performance improvements, aside from fixing bugs due to conflicts in logic. This also simplifies some related code identified while debugging.
2023-08-11 15:55:47 +02:00
// Send the edited object to the plugins.
for (EditorPlugin *plugin : available_plugins) {
if (active_plugins[owner_id].has(plugin)) {
// Plugin was already active, just change the object.
plugin->edit(p_object);
continue;
}
Allow contextual plugins to persist temporarily
2023-09-10 21:29:28 +02:00
if (active_plugins.has(plugin->get_instance_id())) {
// Plugin is already active, but as self-owning, so it needs a separate check.
plugin->edit(p_object);
continue;
}
Avoid unnecessary inspector updates when loading or switching scenes This should result in some noticeable performance improvements, aside from fixing bugs due to conflicts in logic. This also simplifies some related code identified while debugging.
2023-08-11 15:55:47 +02:00
// If plugin is already associated with another owner, remove it from there first.
for (KeyValue<ObjectID, HashSet<EditorPlugin *>> &kv : active_plugins) {
if (kv.key != owner_id) {
EditorPropertyResource *epres = Object::cast_to<EditorPropertyResource>(ObjectDB::get_instance(kv.key));
if (epres && kv.value.has(plugin)) {
// If it's resource property editing the same resource type, fold it.
epres->fold_resource();
Rework EditorPlugin editing logic
2023-01-21 22:49:06 +01:00
}
Avoid unnecessary inspector updates when loading or switching scenes This should result in some noticeable performance improvements, aside from fixing bugs due to conflicts in logic. This also simplifies some related code identified while debugging.
2023-08-11 15:55:47 +02:00
kv.value.erase(plugin);
Rework EditorPlugin editing logic
2023-01-21 22:49:06 +01:00
}
Don't hide/show top editor if they did not change, fixes #26644
2019-03-06 16:42:01 +01:00
}
Avoid unnecessary inspector updates when loading or switching scenes This should result in some noticeable performance improvements, aside from fixing bugs due to conflicts in logic. This also simplifies some related code identified while debugging.
2023-08-11 15:55:47 +02:00
// Activate previously inactive plugin and edit the object.
active_plugins[owner_id].insert(plugin);
_plugin_over_edit(plugin, p_object);
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 03:10:48 +02:00
}
}
Prevent wrong unedit when clicking editor viewport
2023-02-01 00:50:34 +01:00
void EditorNode::push_node_item(Node *p_node) {
Fix MultiNodeEdit not cleared after deleting nodes
2023-03-11 22:46:31 +01:00
if (p_node || Object::cast_to<Node>(InspectorDock::get_inspector_singleton()->get_edited_object()) || Object::cast_to<MultiNodeEdit>(InspectorDock::get_inspector_singleton()->get_edited_object())) {
Prevent wrong unedit when clicking editor viewport
2023-02-01 00:50:34 +01:00
// Don't push null if the currently edited object is not a Node.
push_item(p_node);
}
}
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 03:10:48 +02:00
void EditorNode::push_item(Object *p_object, const String &p_property, bool p_inspector_only) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (!p_object) {
Store panels and docks singletons in their own classes
2021-11-17 21:08:55 +01:00
InspectorDock::get_inspector_singleton()->edit(nullptr);
NodeDock::get_singleton()->set_node(nullptr);
SceneTreeDock::get_singleton()->set_selected(nullptr);
InspectorDock::get_singleton()->update(nullptr);
Rework EditorPlugin editing logic
2023-01-21 22:49:06 +01:00
hide_unused_editors();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return;
}
ObjectID converted to a structure, fixes many bugs where used incorrectly as 32 bits.
2020-02-12 18:24:06 +01:00
ObjectID id = p_object->get_instance_id();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (id != editor_history.get_current()) {
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 03:10:48 +02:00
if (p_inspector_only) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
editor_history.add_object(id, String(), true);
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 10:42:46 +01:00
} else if (p_property.is_empty()) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
editor_history.add_object(id);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
} else {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
editor_history.add_object(id, p_property);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
_edit_current();
}
Extract editor run toolbar into its own component - Simplify and update its logic. - Simplify EditorScript. - Improve EditorNode and other relevant includes. - Fix scene-based path in the movie writer when reloading a scene.
2023-04-12 21:02:28 +02:00
void EditorNode::save_default_environment() {
Change non-existent World to World3D
2020-04-18 11:00:51 +02:00
Ref<Environment> fallback = get_tree()->get_root()->get_world_3d()->get_fallback_environment();
-Added .hdr format support -Added default environment editor setting -Added environment created by default in new projects -Removed default light and ambient from spatial editor, to make the editor more PBR compliant
2017-05-29 02:46:48 +02:00
if (fallback.is_valid() && fallback->get_path().is_resource_file()) {
Replace most uses of Map by HashMap * Map is unnecessary and inefficient in almost every case. * Replaced by the new HashMap. * Renamed Map to RBMap and Set to RBSet for cases that still make sense (order matters) but use is discouraged. There were very few cases where replacing by HashMap was undesired because keeping the key order was intended. I tried to keep those (as RBMap) as much as possible, but might have missed some. Review appreciated!
2022-05-13 15:04:37 +02:00
HashMap<Ref<Resource>, bool> processed;
-Added .hdr format support -Added default environment editor setting -Added environment created by default in new projects -Removed default light and ambient from spatial editor, to make the editor more PBR compliant
2017-05-29 02:46:48 +02:00
_find_and_save_edited_subresources(fallback.ptr(), processed, 0);
Revert "Fix saving unmodified scenes and resources" This reverts commits 28ab60422d648d43d219186ea0ecffce1645188f and 7821b70a00768cb99c0b48450eabe5a687ae276c. Fixes #19576, and likely the fact that subresources are no longer saved when saving scenes with no change.
2018-06-29 08:38:15 +02:00
save_resource_in_path(fallback, fallback->get_path());
-Added .hdr format support -Added default environment editor setting -Added environment created by default in new projects -Removed default light and ambient from spatial editor, to make the editor more PBR compliant
2017-05-29 02:46:48 +02:00
}
}
Rework EditorPlugin editing logic
2023-01-21 22:49:06 +01:00
void EditorNode::hide_unused_editors(const Object *p_editing_owner) {
if (p_editing_owner) {
const ObjectID id = p_editing_owner->get_instance_id();
for (EditorPlugin *plugin : active_plugins[id]) {
Allow contextual plugins to persist temporarily
2023-09-10 21:29:28 +02:00
if (plugin->can_auto_hide()) {
_plugin_over_edit(plugin, nullptr);
} else {
_plugin_over_self_own(plugin);
}
Rework EditorPlugin editing logic
2023-01-21 22:49:06 +01:00
}
active_plugins.erase(id);
} else {
// If no editing owner is provided, this method will go over all owners and check if they are valid.
// This is to sweep properties that were removed from the inspector.
List<ObjectID> to_remove;
for (KeyValue<ObjectID, HashSet<EditorPlugin *>> &kv : active_plugins) {
Allow contextual plugins to persist temporarily
2023-09-10 21:29:28 +02:00
const Object *context = ObjectDB::get_instance(kv.key);
if (context) {
// In case of self-owning plugins, they are disabled here if they can auto hide.
const EditorPlugin *self_owning = Object::cast_to<EditorPlugin>(context);
if (self_owning && self_owning->can_auto_hide()) {
context = nullptr;
}
}
if (!context) {
Rework EditorPlugin editing logic
2023-01-21 22:49:06 +01:00
to_remove.push_back(kv.key);
for (EditorPlugin *plugin : kv.value) {
Allow contextual plugins to persist temporarily
2023-09-10 21:29:28 +02:00
if (plugin->can_auto_hide()) {
_plugin_over_edit(plugin, nullptr);
} else {
_plugin_over_self_own(plugin);
}
Rework EditorPlugin editing logic
2023-01-21 22:49:06 +01:00
}
}
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Rework EditorPlugin editing logic
2023-01-21 22:49:06 +01:00
for (const ObjectID &id : to_remove) {
active_plugins.erase(id);
}
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Fixes language overridden external editors
2017-09-03 21:23:36 +02:00
static bool overrides_external_editor(Object *p_object) {
Script *script = Object::cast_to<Script>(p_object);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!script) {
Fixes language overridden external editors
2017-09-03 21:23:36 +02:00
return false;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Fixes language overridden external editors
2017-09-03 21:23:36 +02:00
return script->get_language()->overrides_external_editor();
}
Don't edit foreign resources when restoring scene
2021-09-12 21:17:34 +02:00
void EditorNode::_edit_current(bool p_skip_foreign) {
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-09-29 11:53:28 +02:00
ObjectID current_id = editor_history.get_current();
Object *current_obj = current_id.is_valid() ? ObjectDB::get_instance(current_id) : nullptr;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Remove `RES` and `REF` typedefs in favor of spelled out `Ref<>` These typedefs don't save much typing compared to the full `Ref<Resource>` and `Ref<RefCounted>`, yet they sometimes introduce confusion among new contributors.
2022-05-03 01:43:50 +02:00
Ref<Resource> res = Object::cast_to<Resource>(current_obj);
Don't edit foreign resources when restoring scene
2021-09-12 21:17:34 +02:00
if (p_skip_foreign && res.is_valid()) {
Extract editor scene tabs into their own component
2023-08-24 12:24:29 +02:00
const int current_tab = scene_tabs->get_current_tab();
if (res->get_path().find("::") > -1 && res->get_path().get_slice("::", 0) != editor_data.get_scene_path(current_tab)) {
Don't edit foreign resources when restoring scene
2021-09-12 21:17:34 +02:00
// Trying to edit resource that belongs to another scene; abort.
current_obj = nullptr;
}
}
bool inspector_only = editor_history.is_current_inspector_only();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
this->current = current_obj;
Warn the user that changes to resources will be lost when editing imported or instanced resources from scenes.
2017-09-14 15:38:59 +02:00
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (!current_obj) {
Store panels and docks singletons in their own classes
2021-11-17 21:08:55 +01:00
SceneTreeDock::get_singleton()->set_selected(nullptr);
InspectorDock::get_inspector_singleton()->edit(nullptr);
NodeDock::get_singleton()->set_node(nullptr);
InspectorDock::get_singleton()->update(nullptr);
Rework EditorPlugin editing logic
2023-01-21 22:49:06 +01:00
hide_unused_editors();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return;
}
Avoid unnecessary inspector updates when loading or switching scenes This should result in some noticeable performance improvements, aside from fixing bugs due to conflicts in logic. This also simplifies some related code identified while debugging.
2023-08-11 15:55:47 +02:00
// Update the use folding setting and state.
Make remote inspector groups not foldable
2023-10-31 17:29:53 +01:00
bool disable_folding = bool(EDITOR_GET("interface/inspector/disable_folding")) || current_obj->is_class("EditorDebuggerRemoteObject");
Avoid unnecessary inspector updates when loading or switching scenes This should result in some noticeable performance improvements, aside from fixing bugs due to conflicts in logic. This also simplifies some related code identified while debugging.
2023-08-11 15:55:47 +02:00
if (InspectorDock::get_inspector_singleton()->is_using_folding() == disable_folding) {
InspectorDock::get_inspector_singleton()->set_use_folding(!disable_folding, false);
}
ObjectTypeDB was renamed to ClassDB. Types are meant to be more generic to Variant. All usages of "type" to refer to classes were renamed to "class" ClassDB has been exposed to GDScript. OBJ_TYPE() macro is now GDCLASS()
2017-01-03 03:03:46 +01:00
bool is_resource = current_obj->is_class("Resource");
bool is_node = current_obj->is_class("Node");
Display sub-plugins when Stay in Script Editor is On Currently, with stay_in_script_editor_on_node_selected as On, inspector_only is forcibly set, and no editors from the node selected are displayed. With this change, if the selected Node has a Main Editor, it's still not shown (the intended behaviour of the feature), but the sub-editors are shown, this correctly opens the AnimationPlayerEditor plugin and other sub-plugins. Fixes and closes #63621.
2022-08-02 09:34:37 +02:00
bool stay_in_script_editor_on_node_selected = bool(EDITOR_GET("text_editor/behavior/navigation/stay_in_script_editor_on_node_selected"));
bool skip_main_plugin = false;
Moved inspector functionality from EditorNode to InspectorDock.
2018-05-17 08:01:47 +02:00
Disable editing properties in foreign resources from imported scenes or objects returning true from a function named '_is_read_only' and disable resaving imported resources.
2022-04-29 08:06:48 +02:00
String editable_info; // None by default.
bool info_is_warning = false;
if (current_obj->has_method("_is_read_only")) {
if (current_obj->call("_is_read_only")) {
editable_info = TTR("This object is marked as read-only, so it's not editable.");
}
}
Added test to avoid saving cyclic scene instancing, fixes #9686
2018-11-27 22:56:31 +01:00
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
if (is_resource) {
Convert Object::cast_to() to the static version Currently we rely on some undefined behavior when Object->cast_to() gets called with a Null pointer. This used to work fine with GCC < 6 but newer versions of GCC remove all codepaths in which the this pointer is Null. However, the non-static cast_to() was supposed to be null safe. This patch makes cast_to() Null safe and removes the now redundant Null checks where they existed. It is explained in this article: https://www.viva64.com/en/b/0226/
2017-08-24 22:58:51 +02:00
Resource *current_res = Object::cast_to<Resource>(current_obj);
[Editor] Replace `ERR_FAIL_COND` with `ERR_FAIL_NULL` where applicable
2023-09-09 17:24:40 +02:00
ERR_FAIL_NULL(current_res);
Avoid unnecessary inspector updates when loading or switching scenes This should result in some noticeable performance improvements, aside from fixing bugs due to conflicts in logic. This also simplifies some related code identified while debugging.
2023-08-11 15:55:47 +02:00
Store panels and docks singletons in their own classes
2021-11-17 21:08:55 +01:00
InspectorDock::get_inspector_singleton()->edit(current_res);
SceneTreeDock::get_singleton()->set_selected(nullptr);
NodeDock::get_singleton()->set_node(nullptr);
InspectorDock::get_singleton()->update(nullptr);
ImportDock::get_singleton()->set_edit_path(current_res->get_path());
Warn the user that changes to resources will be lost when editing imported or instanced resources from scenes.
2017-09-14 15:38:59 +02:00
int subr_idx = current_res->get_path().find("::");
Re-Added export plugins with a more interesting API, as well as the ability to do path remapping. Also added ability to tell the exporter that a shared object needs to be bundled in the build.
2017-09-15 00:38:38 +02:00
if (subr_idx != -1) {
String base_path = current_res->get_path().substr(0, subr_idx);
Add read-only info to resource embedded in other scenes.
2023-10-27 03:08:56 +02:00
if (FileAccess::exists(base_path + ".import")) {
if (!base_path.is_resource_file()) {
Disable editing properties in foreign resources from imported scenes or objects returning true from a function named '_is_read_only' and disable resaving imported resources.
2022-04-29 08:06:48 +02:00
if (get_edited_scene() && get_edited_scene()->get_scene_file_path() == base_path) {
info_is_warning = true;
}
Warn the user that changes to resources will be lost when editing imported or instanced resources from scenes.
2017-09-14 15:38:59 +02:00
}
Add read-only info to resource embedded in other scenes.
2023-10-27 03:08:56 +02:00
editable_info = TTR("This resource belongs to a scene that was imported, so it's not editable.\nPlease read the documentation relevant to importing scenes to better understand this workflow.");
} else if ((!get_edited_scene() || get_edited_scene()->get_scene_file_path() != base_path) && ResourceLoader::get_resource_type(base_path) == "PackedScene") {
editable_info = TTR("This resource belongs to a scene that was instantiated or inherited.\nChanges to it must be made inside the original scene.");
Warn the user that changes to resources will be lost when editing imported or instanced resources from scenes.
2017-09-14 15:38:59 +02:00
}
Re-Added export plugins with a more interesting API, as well as the ability to do path remapping. Also added ability to tell the exporter that a shared object needs to be bundled in the build.
2017-09-15 00:38:38 +02:00
} else if (current_res->get_path().is_resource_file()) {
if (FileAccess::exists(current_res->get_path() + ".import")) {
Disable editing properties in foreign resources from imported scenes or objects returning true from a function named '_is_read_only' and disable resaving imported resources.
2022-04-29 08:06:48 +02:00
editable_info = TTR("This resource was imported, so it's not editable. Change its settings in the import panel and then re-import.");
Warn the user that changes to resources will be lost when editing imported or instanced resources from scenes.
2017-09-14 15:38:59 +02:00
}
}
do not show help on multi node selection, array editing, etc, closes #5550
2016-07-09 16:46:59 +02:00
} else if (is_node) {
Convert Object::cast_to() to the static version Currently we rely on some undefined behavior when Object->cast_to() gets called with a Null pointer. This used to work fine with GCC < 6 but newer versions of GCC remove all codepaths in which the this pointer is Null. However, the non-static cast_to() was supposed to be null safe. This patch makes cast_to() Null safe and removes the now redundant Null checks where they existed. It is explained in this article: https://www.viva64.com/en/b/0226/
2017-08-24 22:58:51 +02:00
Node *current_node = Object::cast_to<Node>(current_obj);
[Editor] Replace `ERR_FAIL_COND` with `ERR_FAIL_NULL` where applicable
2023-09-09 17:24:40 +02:00
ERR_FAIL_NULL(current_node);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Store panels and docks singletons in their own classes
2021-11-17 21:08:55 +01:00
InspectorDock::get_inspector_singleton()->edit(current_node);
-Added .hdr format support -Added default environment editor setting -Added environment created by default in new projects -Removed default light and ambient from spatial editor, to make the editor more PBR compliant
2017-05-29 02:46:48 +02:00
if (current_node->is_inside_tree()) {
Store panels and docks singletons in their own classes
2021-11-17 21:08:55 +01:00
NodeDock::get_singleton()->set_node(current_node);
SceneTreeDock::get_singleton()->set_selected(current_node);
InspectorDock::get_singleton()->update(current_node);
Display sub-plugins when Stay in Script Editor is On Currently, with stay_in_script_editor_on_node_selected as On, inspector_only is forcibly set, and no editors from the node selected are displayed. With this change, if the selected Node has a Main Editor, it's still not shown (the intended behaviour of the feature), but the sub-editors are shown, this correctly opens the AnimationPlayerEditor plugin and other sub-plugins. Fixes and closes #63621.
2022-08-02 09:34:37 +02:00
if (!inspector_only && !skip_main_plugin) {
fix CollisionShape3D Shape Size handle will missing when Script editor floating
2023-08-15 06:40:32 +02:00
skip_main_plugin = stay_in_script_editor_on_node_selected && !ScriptEditor::get_singleton()->is_editor_floating() && ScriptEditor::get_singleton()->is_visible_in_tree();
When selecting Nodes in the Scene Tree, if the current EditorPlugin is "Script" and if text_editor/behavior/navigation/stay_in_script_editor_on_node_selected is true, force inspector_only in order to not switch the EditorPlugin to the Node's main plugin.
2022-07-23 14:29:30 +02:00
}
-Added .hdr format support -Added default environment editor setting -Added environment created by default in new projects -Removed default light and ambient from spatial editor, to make the editor more PBR compliant
2017-05-29 02:46:48 +02:00
} else {
Store panels and docks singletons in their own classes
2021-11-17 21:08:55 +01:00
NodeDock::get_singleton()->set_node(nullptr);
SceneTreeDock::get_singleton()->set_selected(nullptr);
InspectorDock::get_singleton()->update(nullptr);
-Added .hdr format support -Added default environment editor setting -Added environment created by default in new projects -Removed default light and ambient from spatial editor, to make the editor more PBR compliant
2017-05-29 02:46:48 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 10:42:46 +01:00
if (get_edited_scene() && !get_edited_scene()->get_scene_file_path().is_empty()) {
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 16:30:55 +02:00
String source_scene = get_edited_scene()->get_scene_file_path();
Re-Added export plugins with a more interesting API, as well as the ability to do path remapping. Also added ability to tell the exporter that a shared object needs to be bundled in the build.
2017-09-15 00:38:38 +02:00
if (FileAccess::exists(source_scene + ".import")) {
Remove more instances of 'instance' being used as a verb
2022-11-16 00:13:39 +01:00
editable_info = TTR("This scene was imported, so changes to it won't be kept.\nInstantiating or inheriting it will allow you to make changes to it.\nPlease read the documentation relevant to importing scenes to better understand this workflow.");
Disable editing properties in foreign resources from imported scenes or objects returning true from a function named '_is_read_only' and disable resaving imported resources.
2022-04-29 08:06:48 +02:00
info_is_warning = true;
Warn the user that changes to resources will be lost when editing imported or instanced resources from scenes.
2017-09-14 15:38:59 +02:00
}
}
Multiple, simultaneous node editing spuport!! ..but will you be brave enough to try it? :)
2015-08-25 05:08:45 +02:00
} else {
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
Node *selected_node = nullptr;
Keep focus on the top-most node for multi-selection in scene tree Makes behavior consistent with selecting/deselecting single nodes and fixes a regression about the focused node being lost when multi-selecting. Fixes #33332
2019-11-10 09:37:51 +01:00
Make remote inspector groups not foldable
2023-10-31 17:29:53 +01:00
if (current_obj->is_class("MultiNodeEdit")) {
Keep focus on the top-most node for multi-selection in scene tree Makes behavior consistent with selecting/deselecting single nodes and fixes a regression about the focused node being lost when multi-selecting. Fixes #33332
2019-11-10 09:37:51 +01:00
Node *scene = get_edited_scene();
if (scene) {
MultiNodeEdit *multi_node_edit = Object::cast_to<MultiNodeEdit>(current_obj);
int node_count = multi_node_edit->get_node_count();
if (node_count > 0) {
List<Node *> multi_nodes;
for (int node_index = 0; node_index < node_count; ++node_index) {
Node *node = scene->get_node(multi_node_edit->get_node(node_index));
if (node) {
multi_nodes.push_back(node);
}
}
Rename empty() to is_empty()
2020-12-15 13:04:21 +01:00
if (!multi_nodes.is_empty()) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Pick the top-most node.
Keep focus on the top-most node for multi-selection in scene tree Makes behavior consistent with selecting/deselecting single nodes and fixes a regression about the focused node being lost when multi-selecting. Fixes #33332
2019-11-10 09:37:51 +01:00
multi_nodes.sort_custom<Node::Comparator>();
selected_node = multi_nodes.front()->get();
}
}
}
Better supported for remote object editing with the inspector with a simple dictionary editor implement
2017-10-17 16:39:31 +02:00
}
Store panels and docks singletons in their own classes
2021-11-17 21:08:55 +01:00
InspectorDock::get_inspector_singleton()->edit(current_obj);
NodeDock::get_singleton()->set_node(nullptr);
SceneTreeDock::get_singleton()->set_selected(selected_node);
InspectorDock::get_singleton()->update(nullptr);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Disable editing properties in foreign resources from imported scenes or objects returning true from a function named '_is_read_only' and disable resaving imported resources.
2022-04-29 08:06:48 +02:00
InspectorDock::get_singleton()->set_info(
info_is_warning ? TTR("Changes may be lost!") : TTR("This object is read-only."),
editable_info,
info_is_warning);
Warn the user that changes to resources will be lost when editing imported or instanced resources from scenes.
2017-09-14 15:38:59 +02:00
Rework EditorPlugin editing logic
2023-01-21 22:49:06 +01:00
Object *editor_owner = is_node ? (Object *)SceneTreeDock::get_singleton() : is_resource ? (Object *)InspectorDock::get_inspector_singleton()
: (Object *)this;
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Take care of the main editor plugin.
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 03:10:48 +02:00
if (!inspector_only) {
Avoid unnecessary inspector updates when loading or switching scenes This should result in some noticeable performance improvements, aside from fixing bugs due to conflicts in logic. This also simplifies some related code identified while debugging.
2023-08-11 15:55:47 +02:00
EditorPlugin *main_plugin = editor_data.get_handling_main_editor(current_obj);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Fix out of sync separate distraction-free mode
2021-06-09 01:27:30 +02:00
int plugin_index = 0;
for (; plugin_index < editor_table.size(); plugin_index++) {
if (editor_table[plugin_index] == main_plugin) {
if (!main_editor_buttons[plugin_index]->is_visible()) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
main_plugin = nullptr; // If button is not visible, then no plugin is active.
Fix out of sync separate distraction-free mode
2021-06-09 01:27:30 +02:00
}
break;
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
}
}
Rework EditorPlugin editing logic
2023-01-21 22:49:06 +01:00
ObjectID editor_owner_id = editor_owner->get_instance_id();
Display sub-plugins when Stay in Script Editor is On Currently, with stay_in_script_editor_on_node_selected as On, inspector_only is forcibly set, and no editors from the node selected are displayed. With this change, if the selected Node has a Main Editor, it's still not shown (the intended behaviour of the feature), but the sub-editors are shown, this correctly opens the AnimationPlayerEditor plugin and other sub-plugins. Fixes and closes #63621.
2022-08-02 09:34:37 +02:00
if (main_plugin && !skip_main_plugin) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Special case if use of external editor is true.
Fix compilation error after 4c30963
2022-01-04 10:40:17 +01:00
Resource *current_res = Object::cast_to<Resource>(current_obj);
Removed unused property hints and `Object::get_translatable_strings()` * Remove unused `EditorPropertyMember` and related hints, previouly used by VisualScript. Such logic should be implemented in the VS module itself. * As the above broke compatibility with the VS module, clean up the other hacks that were still in core in support of VisualScript. * `PROPERTY_USAGE_INTERNATIONALIZED` was only used in Object's `get_translatable_strings()`, which is a legacy function not used anywhere. So both are removed. * Reordered some usage flags after the above removal to minimize the diff. * General clean up. Fixes #30203. Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
2023-01-09 15:31:44 +01:00
if (main_plugin->get_name() == "Script" && current_res && !current_res->is_built_in() && (bool(EDITOR_GET("text_editor/external/use_external_editor")) || overrides_external_editor(current_obj))) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!changing_scene) {
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 03:10:48 +02:00
main_plugin->edit(current_obj);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 03:10:48 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 03:10:48 +02:00
else if (main_plugin != editor_plugin_screen && (!ScriptEditor::get_singleton() || !ScriptEditor::get_singleton()->is_visible_in_tree() || ScriptEditor::get_singleton()->can_take_away_focus())) {
Rework EditorPlugin editing logic
2023-01-21 22:49:06 +01:00
// Unedit previous plugin.
editor_plugin_screen->edit(nullptr);
active_plugins[editor_owner_id].erase(editor_plugin_screen);
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Update screen main_plugin.
Port remaining connections to callable_mp
2020-12-06 16:09:18 +01:00
editor_select(plugin_index);
Fix out of sync separate distraction-free mode
2021-06-09 01:27:30 +02:00
main_plugin->edit(current_obj);
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 03:10:48 +02:00
} else {
editor_plugin_screen->edit(current_obj);
}
Rework EditorPlugin editing logic
2023-01-21 22:49:06 +01:00
is_main_screen_editing = true;
} else if (!main_plugin && editor_plugin_screen && is_main_screen_editing) {
editor_plugin_screen->edit(nullptr);
is_main_screen_editing = false;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Rework EditorPlugin editing logic
2023-01-21 22:49:06 +01:00
edit_item(current_obj, editor_owner);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Store panels and docks singletons in their own classes
2021-11-17 21:08:55 +01:00
InspectorDock::get_singleton()->update(current_obj);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Addes ability to load build sources from file. * If not present, the dialog asks to load build sources from a file. * The export templates check now also verifies that build sources are installed and skips the template check. This makes Android development easier.
2021-07-15 15:12:56 +02:00
void EditorNode::_android_build_source_selected(const String &p_file) {
export_template_manager->install_android_template_from_file(p_file);
}
Improve scene playing and reloading
2022-03-01 23:19:02 +01:00
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
void EditorNode::_menu_option_confirm(int p_option, bool p_confirmed) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
if (!p_confirmed) { // FIXME: this may be a hack.
current_menu_option = (MenuOptions)p_option;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
switch (p_option) {
case FILE_NEW_SCENE: {
Allow to create scene from FileSystem dock
2019-08-15 19:47:21 +02:00
new_scene();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
Large improvements on scene packing and management -Ability to edit and keep changes of instanced scenes and sub-scenes -Ability to inherit from other scenes
2015-10-10 14:09:09 +02:00
case FILE_NEW_INHERITED_SCENE:
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
case FILE_OPEN_SCENE: {
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
file->set_file_mode(EditorFileDialog::FILE_MODE_OPEN_FILE);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
List<String> extensions;
ResourceLoader::get_recognized_extensions_for_type("PackedScene", &extensions);
file->clear_filters();
for (int i = 0; i < extensions.size(); i++) {
Seperate filter and description in FileDialog.add_filter()
2022-07-04 23:26:26 +02:00
file->add_filter("*." + extensions[i], extensions[i].to_upper());
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
remove trailing whitespace
2016-03-09 00:00:52 +01:00
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
Node *scene = editor_data.get_edited_scene_root();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (scene) {
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 16:30:55 +02:00
file->set_current_path(scene->get_scene_file_path());
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
};
Contextualized Scene Tree menu -Added context menu to Scene Tree Dock -Removed Buttons -Added a filter to search for nods more easily in the dock
2016-05-16 17:23:40 +02:00
file->set_title(p_option == FILE_OPEN_SCENE ? TTR("Open Scene") : TTR("Open Base Scene"));
Resize dialogs (FileDialog, EditorFileDialog, Reparent, SceneTreeDialog and resource depency dialogs).
2020-07-11 18:45:19 +02:00
file->popup_file_dialog();
remove trailing whitespace
2016-03-09 00:00:52 +01:00
Add Quick Open dialog This dialog searches every Resource-derived file in the project, making it extremely useful for searching everything from audio files to scripts. Unlike the Quick Open Script and Quick Open Scene dialogs, you don't need to think about the type of file you're opening, just its name. Shift + Alt + O was chosen to match the existing shortcuts for Quick Open Scene and Quick Open Script.
2019-05-09 22:06:35 +02:00
} break;
case FILE_QUICK_OPEN: {
quick_open->popup_dialog("Resource", true);
quick_open->set_title(TTR("Quick Open..."));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
case FILE_QUICK_OPEN_SCENE: {
Fix warnings on virtual methods [-Woverloaded-virtual] [-Wdelete-non-virtual-dtor] Fixes the following Clang 7 warnings: ``` editor/editor_help.h:123:7: warning: 'EditorHelpIndex::popup' hides overloaded virtual function [-Woverloaded-virtual] editor/editor_help.h:95:7: warning: 'EditorHelpSearch::popup' hides overloaded virtual function [-Woverloaded-virtual] editor/editor_help.h:96:7: warning: 'EditorHelpSearch::popup' hides overloaded virtual function [-Woverloaded-virtual] editor/plugins/curve_editor_plugin.h:141:15: warning: 'CurvePreviewGenerator::generate' hides overloaded virtual function [-Woverloaded-virtual] editor/plugins/script_editor_plugin.h:70:7: warning: 'ScriptEditorQuickOpen::popup' hides overloaded virtual function [-Woverloaded-virtual] editor/quick_open.h:69:7: warning: 'EditorQuickOpen::popup' hides overloaded virtual function [-Woverloaded-virtual] main/tests/test_io.cpp:53:15: warning: 'TestIO::TestMainLoop::input_event' hides overloaded virtual function [-Woverloaded-virtual] servers/audio/effects/audio_effect_record.h:69:15: warning: 'AudioEffectRecordInstance::process_silence' hides overloaded virtual function [-Woverloaded-virtual] core/os/memory.h:119:2: warning: destructor called on non-final 'ContextGL_X11' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'EditorScriptCodeCompletionCache' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'Engine' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'PhysicalBone::JointData' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'VisualServerScene' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'VisualServerViewport' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] ```
2018-10-02 12:07:44 +02:00
quick_open->popup_dialog("PackedScene", true);
Change ".." punctuation for "..." in editor strings (#16507)
2018-04-22 19:36:01 +02:00
quick_open->set_title(TTR("Quick Open Scene..."));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
case FILE_QUICK_OPEN_SCRIPT: {
Fix warnings on virtual methods [-Woverloaded-virtual] [-Wdelete-non-virtual-dtor] Fixes the following Clang 7 warnings: ``` editor/editor_help.h:123:7: warning: 'EditorHelpIndex::popup' hides overloaded virtual function [-Woverloaded-virtual] editor/editor_help.h:95:7: warning: 'EditorHelpSearch::popup' hides overloaded virtual function [-Woverloaded-virtual] editor/editor_help.h:96:7: warning: 'EditorHelpSearch::popup' hides overloaded virtual function [-Woverloaded-virtual] editor/plugins/curve_editor_plugin.h:141:15: warning: 'CurvePreviewGenerator::generate' hides overloaded virtual function [-Woverloaded-virtual] editor/plugins/script_editor_plugin.h:70:7: warning: 'ScriptEditorQuickOpen::popup' hides overloaded virtual function [-Woverloaded-virtual] editor/quick_open.h:69:7: warning: 'EditorQuickOpen::popup' hides overloaded virtual function [-Woverloaded-virtual] main/tests/test_io.cpp:53:15: warning: 'TestIO::TestMainLoop::input_event' hides overloaded virtual function [-Woverloaded-virtual] servers/audio/effects/audio_effect_record.h:69:15: warning: 'AudioEffectRecordInstance::process_silence' hides overloaded virtual function [-Woverloaded-virtual] core/os/memory.h:119:2: warning: destructor called on non-final 'ContextGL_X11' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'EditorScriptCodeCompletionCache' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'Engine' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'PhysicalBone::JointData' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'VisualServerScene' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'VisualServerViewport' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] ```
2018-10-02 12:07:44 +02:00
quick_open->popup_dialog("Script", true);
Change ".." punctuation for "..." in editor strings (#16507)
2018-04-22 19:36:01 +02:00
quick_open->set_title(TTR("Quick Open Script..."));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
case FILE_OPEN_PREV: {
Rename empty() to is_empty()
2020-12-15 13:04:21 +01:00
if (previous_scenes.is_empty()) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
break;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
opening_prev = true;
open_request(previous_scenes.back()->get());
Add Undo Close Tab option in tabs context menu
2019-04-10 17:21:26 +02:00
previous_scenes.pop_back();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Add Close Others/Right/All for scene tabs
2019-04-21 11:44:21 +02:00
} break;
Scene tab closing refactor
2022-10-14 20:41:05 +02:00
case FILE_CLOSE_OTHERS: {
tab_closing_menu_option = -1;
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
if (i == editor_data.get_edited_scene()) {
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Scene tab closing refactor
2022-10-14 20:41:05 +02:00
tabs_to_close.push_back(editor_data.get_scene_path(i));
Add Close Others/Right/All for scene tabs
2019-04-21 11:44:21 +02:00
}
Scene tab closing refactor
2022-10-14 20:41:05 +02:00
_proceed_closing_scene_tabs();
} break;
case FILE_CLOSE_RIGHT: {
tab_closing_menu_option = -1;
for (int i = editor_data.get_edited_scene() + 1; i < editor_data.get_edited_scene_count(); i++) {
tabs_to_close.push_back(editor_data.get_scene_path(i));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Scene tab closing refactor
2022-10-14 20:41:05 +02:00
_proceed_closing_scene_tabs();
} break;
case FILE_CLOSE_ALL: {
tab_closing_menu_option = -1;
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
tabs_to_close.push_back(editor_data.get_scene_path(i));
}
_proceed_closing_scene_tabs();
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
} break;
case FILE_CLOSE: {
Make closing current scene faster
2020-07-20 01:09:36 +02:00
_scene_tab_closed(editor_data.get_edited_scene());
} break;
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 06:15:39 +02:00
case SCENE_TAB_CLOSE:
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
case FILE_SAVE_SCENE: {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
int scene_idx = (p_option == FILE_SAVE_SCENE) ? -1 : tab_closing_idx;
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 06:15:39 +02:00
Node *scene = editor_data.get_edited_scene_root(scene_idx);
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 10:42:46 +01:00
if (scene && !scene->get_scene_file_path().is_empty()) {
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 16:30:55 +02:00
if (DirAccess::exists(scene->get_scene_file_path().get_base_dir())) {
Corrected Save Scene and Save All Scenes not working when the scene's dir no longer exists
2021-09-11 03:35:13 +02:00
if (scene_idx != editor_data.get_edited_scene()) {
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 16:30:55 +02:00
_save_scene_with_preview(scene->get_scene_file_path(), scene_idx);
Corrected Save Scene and Save All Scenes not working when the scene's dir no longer exists
2021-09-11 03:35:13 +02:00
} else {
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 16:30:55 +02:00
_save_scene_with_preview(scene->get_scene_file_path());
Corrected Save Scene and Save All Scenes not working when the scene's dir no longer exists
2021-09-11 03:35:13 +02:00
}
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 06:15:39 +02:00
Corrected Save Scene and Save All Scenes not working when the scene's dir no longer exists
2021-09-11 03:35:13 +02:00
if (scene_idx != -1) {
_discard_changes();
}
Improve editor state persistence
2023-05-11 04:17:03 +02:00
save_editor_layout_delayed();
Corrected Save Scene and Save All Scenes not working when the scene's dir no longer exists
2021-09-11 03:35:13 +02:00
} else {
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 16:30:55 +02:00
show_save_accept(vformat(TTR("%s no longer exists! Please specify a new save location."), scene->get_scene_file_path().get_base_dir()), TTR("OK"));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
break;
}
Replace FALLTHROUGH macro by C++17 [[fallthrough]] This attribute is now part of the standard we target so we no longer need compiler-specific hacks. Also enables -Wimplicit-fallthrough for Clang now that we can properly support it. It's already on by default for GCC's -Wextra. Fixes new warnings raised by Clang's -Wimplicit-fallthrough.
2020-02-22 20:47:50 +01:00
[[fallthrough]];
Fix -Wimplicit-fallthrough warnings from GCC 8 Adds `FALLTHROUGH` macro to specify when a fallthrough is intentional. Can be replaced by `[[fallthrough]]` if/when we switch to C++17. The warning is now enabled by default for GCC on `extra` warnings level (part of GCC's `-Wextra`). It's not enabled in Clang's `-Wextra` yet, but we could enable it manually once we switch to C++11. There's no equivalent feature in MSVC for now. Fixes #26135.
2019-04-05 14:06:16 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
case FILE_SAVE_AS_SCENE: {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
int scene_idx = (p_option == FILE_SAVE_SCENE || p_option == FILE_SAVE_AS_SCENE) ? -1 : tab_closing_idx;
remove trailing whitespace
2016-03-09 00:00:52 +01:00
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
Node *scene = editor_data.get_edited_scene_root(scene_idx);
remove trailing whitespace
2016-03-09 00:00:52 +01:00
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (!scene) {
Save the current script when pressing Ctrl + S if no scene is open - Tweak the dialog messages to be more informative. - The "Saved N modified resources" dialog is not a warning per se, so make it more explicit.
2021-05-09 12:29:50 +02:00
if (p_option == FILE_SAVE_SCENE) {
// Pressing Ctrl + S saves the current script if a scene is currently open, but it won't if the scene has no root node.
// Work around this by explicitly saving the script in this case (similar to pressing Ctrl + Alt + S).
ScriptEditor::get_singleton()->save_current_script();
}
const int saved = _save_external_resources();
Save resources even if no scene is present, closes #26273
2019-02-28 00:00:40 +01:00
if (saved > 0) {
Save the current script when pressing Ctrl + S if no scene is open - Tweak the dialog messages to be more informative. - The "Saved N modified resources" dialog is not a warning per se, so make it more explicit.
2021-05-09 12:29:50 +02:00
show_accept(
vformat(TTR("The current scene has no root node, but %d modified external resource(s) were saved anyway."), saved),
TTR("OK"));
} else if (p_option == FILE_SAVE_AS_SCENE) {
// Don't show this dialog when pressing Ctrl + S to avoid interfering with script saving.
show_accept(
TTR("A root node is required to save the scene. You can add a root node using the Scene tree dock."),
TTR("OK"));
Save resources even if no scene is present, closes #26273
2019-02-28 00:00:40 +01:00
}
remove trailing whitespace
2016-03-09 00:00:52 +01:00
break;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
remove trailing whitespace
2016-03-09 00:00:52 +01:00
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
file->set_file_mode(EditorFileDialog::FILE_MODE_SAVE_FILE);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
List<String> extensions;
Ref<PackedScene> sd = memnew(PackedScene);
ResourceSaver::get_recognized_extensions(sd, &extensions);
file->clear_filters();
for (int i = 0; i < extensions.size(); i++) {
Seperate filter and description in FileDialog.add_filter()
2022-07-04 23:26:26 +02:00
file->add_filter("*." + extensions[i], extensions[i].to_upper());
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
remove trailing whitespace
2016-03-09 00:00:52 +01:00
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 10:42:46 +01:00
if (!scene->get_scene_file_path().is_empty()) {
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 16:30:55 +02:00
String path = scene->get_scene_file_path();
Enhance editor file dialog 1. show valid directory path when opening editor file dialog 2. keep file name when changing path by entering path 3. add first extension in filter automatically if not given 4. remove directory in recent list if it's not valid anymore
2020-10-13 20:28:45 +02:00
file->set_current_path(path);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (extensions.size()) {
Enhance editor file dialog 1. show valid directory path when opening editor file dialog 2. keep file name when changing path by entering path 3. add first extension in filter automatically if not given 4. remove directory in recent list if it's not valid anymore
2020-10-13 20:28:45 +02:00
String ext = path.get_extension().to_lower();
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
if (extensions.find(ext) == nullptr) {
Enhance editor file dialog 1. show valid directory path when opening editor file dialog 2. keep file name when changing path by entering path 3. add first extension in filter automatically if not given 4. remove directory in recent list if it's not valid anymore
2020-10-13 20:28:45 +02:00
file->set_current_path(path.replacen("." + ext, "." + extensions.front()->get()));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
}
Add project setting to change scene file casing
2021-09-12 13:21:24 +02:00
} else if (extensions.size()) {
String root_name = scene->get_name();
Fix inconsistent scene file name casing by moving existing Name_Casing code to separate function in editor_node, and adding a call from both editor_node and scene_tree_dock.
2022-09-09 02:29:59 +02:00
root_name = EditorNode::adjust_scene_name_casing(root_name);
Add project setting to change scene file casing
2021-09-12 13:21:24 +02:00
file->set_current_path(root_name + "." + extensions.front()->get().to_lower());
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Resize dialogs (FileDialog, EditorFileDialog, Reparent, SceneTreeDialog and resource depency dialogs).
2020-07-11 18:45:19 +02:00
file->popup_file_dialog();
Change ".." punctuation for "..." in editor strings (#16507)
2018-04-22 19:36:01 +02:00
file->set_title(TTR("Save Scene As..."));
remove trailing whitespace
2016-03-09 00:00:52 +01:00
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
Save all edited scenes when Runing (and auto-save is enabled). Fixes #4410
2016-06-26 05:54:17 +02:00
case FILE_SAVE_ALL_SCENES: {
EditorNode: enhance quit dialog
2017-06-24 12:57:30 +02:00
_save_all_scenes();
Prompt save dialog if running a unsaved scene. Solution for #966
2015-01-06 23:28:25 +01:00
} break;
Extract editor run toolbar into its own component - Simplify and update its logic. - Simplify EditorScript. - Improve EditorNode and other relevant includes. - Fix scene-based path in the movie writer when reloading a scene.
2023-04-12 21:02:28 +02:00
case FILE_RUN_SCENE: {
project_run_bar->play_current_scene();
} break;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
case FILE_EXPORT_PROJECT: {
Editor Export Settings Dialog is completed!! Now on to make some exporters..
2017-02-20 03:19:30 +01:00
project_export->popup_export();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
case FILE_EXTERNAL_OPEN_SCENE: {
if (unsaved_cache && !p_confirmed) {
Add ok_button_text to AcceptDialog and cancel_button_text to ConfirmationDialog
2022-07-08 02:31:19 +02:00
confirmation->set_ok_button_text(TTR("Open"));
Modified editor strings to be translatable in the future
2016-05-04 03:25:37 +02:00
confirmation->set_text(TTR("Current scene not saved. Open anyway?"));
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
confirmation->popup_centered();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
break;
}
bool oprev = opening_prev;
Error err = load_scene(external_file);
if (err == OK && oprev) {
previous_scenes.pop_back();
opening_prev = false;
}
} break;
case EDIT_UNDO: {
Use "enum class" for input enums
2021-08-13 23:31:57 +02:00
if ((int)Input::get_singleton()->get_mouse_button_mask() & 0x7) {
Improve Undo/Redo menu items * Make Undo/Redo menu items disabled when clicking it does nothing. * Context menu of `TextEdit` * Context menu of `LineEdit` * Editor's Scene menu * Script editor's Edit menu and context menu (for Script and Text) * Make editor undo/redo log messages translatable. * Mark `UndoRedo`'s `has_{un,re}do()` methods as `const`. * Expose `TextEdit`'s `has_{un,re}do()` to scripts since `{un,re}do()` are already available.
2021-08-17 05:41:46 +02:00
log->add_message(TTR("Can't undo while mouse buttons are pressed."), EditorLog::MSG_TYPE_EDITOR);
Add a message when there is nothing to Undo or Redo
2018-05-27 04:41:19 +02:00
} else {
Add EditorUndoRedoManager singleton
2022-12-23 23:53:16 +01:00
EditorUndoRedoManager *undo_redo = EditorUndoRedoManager::get_singleton();
String action = undo_redo->get_current_action_name();
int id = undo_redo->get_current_action_history_id();
if (!undo_redo->undo()) {
Improve Undo/Redo menu items * Make Undo/Redo menu items disabled when clicking it does nothing. * Context menu of `TextEdit` * Context menu of `LineEdit` * Editor's Scene menu * Script editor's Edit menu and context menu (for Script and Text) * Make editor undo/redo log messages translatable. * Mark `UndoRedo`'s `has_{un,re}do()` methods as `const`. * Expose `TextEdit`'s `has_{un,re}do()` to scripts since `{un,re}do()` are already available.
2021-08-17 05:41:46 +02:00
log->add_message(TTR("Nothing to undo."), EditorLog::MSG_TYPE_EDITOR);
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 10:42:46 +01:00
} else if (!action.is_empty()) {
Add scope prefix to undo actions
2022-12-08 14:04:48 +01:00
switch (id) {
case EditorUndoRedoManager::GLOBAL_HISTORY:
log->add_message(vformat(TTR("Global Undo: %s"), action), EditorLog::MSG_TYPE_EDITOR);
break;
case EditorUndoRedoManager::REMOTE_HISTORY:
log->add_message(vformat(TTR("Remote Undo: %s"), action), EditorLog::MSG_TYPE_EDITOR);
break;
default:
log->add_message(vformat(TTR("Scene Undo: %s"), action), EditorLog::MSG_TYPE_EDITOR);
}
Add a message when there is nothing to Undo or Redo
2018-05-27 04:41:19 +02:00
}
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
case EDIT_REDO: {
Add EditorUndoRedoManager singleton
2022-12-23 23:53:16 +01:00
EditorUndoRedoManager *undo_redo = EditorUndoRedoManager::get_singleton();
Use "enum class" for input enums
2021-08-13 23:31:57 +02:00
if ((int)Input::get_singleton()->get_mouse_button_mask() & 0x7) {
Improve Undo/Redo menu items * Make Undo/Redo menu items disabled when clicking it does nothing. * Context menu of `TextEdit` * Context menu of `LineEdit` * Editor's Scene menu * Script editor's Edit menu and context menu (for Script and Text) * Make editor undo/redo log messages translatable. * Mark `UndoRedo`'s `has_{un,re}do()` methods as `const`. * Expose `TextEdit`'s `has_{un,re}do()` to scripts since `{un,re}do()` are already available.
2021-08-17 05:41:46 +02:00
log->add_message(TTR("Can't redo while mouse buttons are pressed."), EditorLog::MSG_TYPE_EDITOR);
Add a message when there is nothing to Undo or Redo
2018-05-27 04:41:19 +02:00
} else {
Add EditorUndoRedoManager singleton
2022-12-23 23:53:16 +01:00
if (!undo_redo->redo()) {
Improve Undo/Redo menu items * Make Undo/Redo menu items disabled when clicking it does nothing. * Context menu of `TextEdit` * Context menu of `LineEdit` * Editor's Scene menu * Script editor's Edit menu and context menu (for Script and Text) * Make editor undo/redo log messages translatable. * Mark `UndoRedo`'s `has_{un,re}do()` methods as `const`. * Expose `TextEdit`'s `has_{un,re}do()` to scripts since `{un,re}do()` are already available.
2021-08-17 05:41:46 +02:00
log->add_message(TTR("Nothing to redo."), EditorLog::MSG_TYPE_EDITOR);
Add a message when there is nothing to Undo or Redo
2018-05-27 04:41:19 +02:00
} else {
Add EditorUndoRedoManager singleton
2022-12-23 23:53:16 +01:00
String action = undo_redo->get_current_action_name();
Add scope prefix to undo actions
2022-12-08 14:04:48 +01:00
if (action.is_empty()) {
break;
}
Add EditorUndoRedoManager singleton
2022-12-23 23:53:16 +01:00
switch (undo_redo->get_current_action_history_id()) {
Add scope prefix to undo actions
2022-12-08 14:04:48 +01:00
case EditorUndoRedoManager::GLOBAL_HISTORY:
log->add_message(vformat(TTR("Global Redo: %s"), action), EditorLog::MSG_TYPE_EDITOR);
break;
case EditorUndoRedoManager::REMOTE_HISTORY:
log->add_message(vformat(TTR("Remote Redo: %s"), action), EditorLog::MSG_TYPE_EDITOR);
break;
default:
log->add_message(vformat(TTR("Scene Redo: %s"), action), EditorLog::MSG_TYPE_EDITOR);
}
Add a message when there is nothing to Undo or Redo
2018-05-27 04:41:19 +02:00
}
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
Add a revert menu item.
2015-01-25 01:14:06 +01:00
Rename the editor action "Revert Scene" to "Reload Saved Scene" This option can be used to workaround various issues with stuff not reloading properly when changes are made. The option was renamed to clarify the fact that it actually reloads the scene saved on the filesystem.
2020-05-10 20:12:25 +02:00
case EDIT_RELOAD_SAVED_SCENE: {
Add a revert menu item.
2015-01-25 01:14:06 +01:00
Node *scene = get_edited_scene();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!scene) {
Add a revert menu item.
2015-01-25 01:14:06 +01:00
break;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
-Fixed revert scene, should work proprely now, fixes #2782
2016-01-23 22:28:30 +01:00
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 16:30:55 +02:00
String filename = scene->get_scene_file_path();
-Fixed revert scene, should work proprely now, fixes #2782
2016-01-23 22:28:30 +01:00
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 10:42:46 +01:00
if (filename.is_empty()) {
i18n: Proofreading of all strings Done to ensure that no important identifiers are translatable, to fix compound strings using the new vformat() function, and some general English proofreading here and there.
2016-05-19 00:08:12 +02:00
show_warning(TTR("Can't reload a scene that was never saved."));
-Fixed revert scene, should work proprely now, fixes #2782
2016-01-23 22:28:30 +01:00
break;
}
Show a confirmation for the revert action.
2015-01-27 01:00:07 +01:00
if (unsaved_cache && !p_confirmed) {
Add ok_button_text to AcceptDialog and cancel_button_text to ConfirmationDialog
2022-07-08 02:31:19 +02:00
confirmation->set_ok_button_text(TTR("Reload Saved Scene"));
Rename the editor action "Revert Scene" to "Reload Saved Scene" This option can be used to workaround various issues with stuff not reloading properly when changes are made. The option was renamed to clarify the fact that it actually reloads the scene saved on the filesystem.
2020-05-10 20:12:25 +02:00
confirmation->set_text(
TTR("The current scene has unsaved changes.\nReload the saved scene anyway? This action cannot be undone."));
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
confirmation->popup_centered();
Show a confirmation for the revert action.
2015-01-27 01:00:07 +01:00
break;
}
Add a revert menu item.
2015-01-25 01:14:06 +01:00
-Fixed revert scene, should work proprely now, fixes #2782
2016-01-23 22:28:30 +01:00
int cur_idx = editor_data.get_edited_scene();
_remove_edited_scene();
Error err = load_scene(filename);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (err != OK) {
Fix unused variable warnings The forth in my quest to make Godot 3.x compile with -Werror on GCC7
2017-09-02 22:32:31 +02:00
ERR_PRINT("Failed to load scene");
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
-Fixed revert scene, should work proprely now, fixes #2782
2016-01-23 22:28:30 +01:00
editor_data.move_edited_scene_to_index(cur_idx);
Add EditorUndoRedoManager singleton
2022-12-23 23:53:16 +01:00
EditorUndoRedoManager::get_singleton()->clear_history(false, editor_data.get_current_edited_scene_history_id());
-Fixed revert scene, should work proprely now, fixes #2782
2016-01-23 22:28:30 +01:00
scene_tabs->set_current_tab(cur_idx);
Add a revert menu item.
2015-01-25 01:14:06 +01:00
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
Replace the -show in filesystem- button by a RMB entry
2018-09-13 19:06:40 +02:00
case FILE_SHOW_IN_FILESYSTEM: {
String path = editor_data.get_scene_path(editor_data.get_edited_scene());
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 10:42:46 +01:00
if (!path.is_empty()) {
Store panels and docks singletons in their own classes
2021-11-17 21:08:55 +01:00
FileSystemDock::get_singleton()->navigate_to_path(path);
Replace the -show in filesystem- button by a RMB entry
2018-09-13 19:06:40 +02:00
}
} break;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
case RUN_SETTINGS: {
Minor fixes/refactoring of project and editor setting dialogs
2022-02-01 00:19:01 +01:00
project_settings_editor->popup_project_settings();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
case FILE_INSTALL_ANDROID_SOURCE: {
if (p_confirmed) {
export_template_manager->install_android_template();
} else {
if (DirAccess::exists("res://android/build")) {
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
remove_android_build_template->popup_centered();
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
} else if (export_template_manager->can_install_android_template()) {
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
install_android_build_template->popup_centered();
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
} else {
Rename Godot's 'custom build' to 'gradle build' to better reflect the underlying build process.
2023-02-02 00:17:06 +01:00
gradle_build_manage_templates->popup_centered();
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
}
}
} break;
Implement Feature Build Profiles This PR is a continuation of #50381 (which was implemented exactly a year ago!) * Add a visual interface to select which classes should not be built into Godot (well, they are built if something else uses them, but if not used the optimizer will remove them out). * Add a detection system to scan the project and figure out the actual classes used. * Added the ability for SCons to load build profiles. Obligatory Screen: A simple test with a couple of nodes in the scene resulted in a 25% reduction for the final binary size TODO: * Script languages need to implement used class detection (left for another PR). * Options to disable servers or server functionalities (like 2D or 3D physics, navigation, etc). Are missing, that should also greatly aid in reducing binary size. * Options to disable some modules would be desired. * More options to disable drivers (OpenGL, Vulkan, etc) would be desired. In general this PR is a starting point for more contributors to improve and enhance this functionality.
2022-07-14 14:18:18 +02:00
case TOOLS_BUILD_PROFILE_MANAGER: {
build_profile_manager->popup_centered_clamped(Size2(700, 800) * EDSCALE, 0.8);
} break;
Reword "Open Project Data Folder" as "Open User Data Folder" Clarifies that the button opens the user:// dir and for better consistency with certain ProjectSettings values: "Use Hidden Project Data Directory" is named similarly, but refers to data within res:// and two values refer to user:// as "User Dir" (Translations were not updated) and rename enum value accordingly
2021-12-28 01:51:45 +01:00
case RUN_USER_DATA_FOLDER: {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Ensure_user_data_dir() to prevent the edge case: "Open User Data Folder" won't work after the project was renamed in ProjectSettingsEditor unless the project is saved.
creater user-dir, if non-existant and pressing 'Open Project Data Folder'
2020-09-13 14:49:53 +02:00
OS::get_singleton()->ensure_user_data_dir();
Implement and expose OS::shell_show_in_file_manager()
2022-12-07 04:33:35 +01:00
OS::get_singleton()->shell_show_in_file_manager(OS::get_singleton()->get_user_data_dir(), true);
Fixed unable to open project data folder Removed `default` case to prevent hiding such errors in the future. Fixes #31939.
2019-09-04 19:46:12 +02:00
} break;
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
case FILE_EXPLORE_ANDROID_BUILD_TEMPLATES: {
Implement and expose OS::shell_show_in_file_manager()
2022-12-07 04:33:35 +01:00
OS::get_singleton()->shell_show_in_file_manager(ProjectSettings::get_singleton()->get_resource_path().path_join("android"), true);
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
} break;
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
case FILE_QUIT:
Made reload current project ask for confirmation with unsaved changes
2022-03-23 12:07:29 +01:00
case RUN_PROJECT_MANAGER:
case RELOAD_CURRENT_PROJECT: {
Add `_get_unsaved_status()` method to EditorPlugin
2022-10-16 18:09:17 +02:00
if (p_confirmed && plugin_to_save) {
plugin_to_save->save_external_data();
p_confirmed = false;
}
Able to open project manager inside editor (Scene->Project Manager) Remove unnecessary include of project_manager.h
2014-02-18 05:21:06 +01:00
if (!p_confirmed) {
-Ability to open resources in the same window -Plenty of fixes and improvements to new inspector -Fixes that were needed to make inspector work better
2018-05-17 23:02:16 +02:00
bool save_each = EDITOR_GET("interface/editor/save_each_scene_on_quit");
Scene tab closing refactor
2022-10-14 20:41:05 +02:00
if (_next_unsaved_scene(!save_each) == -1) {
if (EditorUndoRedoManager::get_singleton()->is_history_unsaved(EditorUndoRedoManager::GLOBAL_HISTORY)) {
Made reload current project ask for confirmation with unsaved changes
2022-03-23 12:07:29 +01:00
if (p_option == RELOAD_CURRENT_PROJECT) {
Add ok_button_text to AcceptDialog and cancel_button_text to ConfirmationDialog
2022-07-08 02:31:19 +02:00
save_confirmation->set_ok_button_text(TTR("Save & Reload"));
Scene tab closing refactor
2022-10-14 20:41:05 +02:00
save_confirmation->set_text(TTR("Save modified resources before reloading?"));
Made reload current project ask for confirmation with unsaved changes
2022-03-23 12:07:29 +01:00
} else {
Add ok_button_text to AcceptDialog and cancel_button_text to ConfirmationDialog
2022-07-08 02:31:19 +02:00
save_confirmation->set_ok_button_text(TTR("Save & Quit"));
Scene tab closing refactor
2022-10-14 20:41:05 +02:00
save_confirmation->set_text(TTR("Save modified resources before closing?"));
Made reload current project ask for confirmation with unsaved changes
2022-03-23 12:07:29 +01:00
}
Adjust size of some dialogs
2023-04-10 17:04:47 +02:00
save_confirmation->reset_size();
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
save_confirmation->popup_centered();
Scene tab closing refactor
2022-10-14 20:41:05 +02:00
break;
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
}
Check for unsaved changes when closing a scene
2023-04-05 15:45:41 +02:00
Add `_get_unsaved_status()` method to EditorPlugin
2022-10-16 18:09:17 +02:00
plugin_to_save = nullptr;
for (int i = 0; i < editor_data.get_editor_plugin_count(); i++) {
const String unsaved_status = editor_data.get_editor_plugin(i)->get_unsaved_status();
if (!unsaved_status.is_empty()) {
if (p_option == RELOAD_CURRENT_PROJECT) {
save_confirmation->set_ok_button_text(TTR("Save & Reload"));
Check for unsaved changes when closing a scene
2023-04-05 15:45:41 +02:00
save_confirmation->set_text(unsaved_status);
Add `_get_unsaved_status()` method to EditorPlugin
2022-10-16 18:09:17 +02:00
} else {
save_confirmation->set_ok_button_text(TTR("Save & Quit"));
Check for unsaved changes when closing a scene
2023-04-05 15:45:41 +02:00
save_confirmation->set_text(unsaved_status);
Add `_get_unsaved_status()` method to EditorPlugin
2022-10-16 18:09:17 +02:00
}
Check for unsaved changes when closing a scene
2023-04-05 15:45:41 +02:00
save_confirmation->reset_size();
Add `_get_unsaved_status()` method to EditorPlugin
2022-10-16 18:09:17 +02:00
save_confirmation->popup_centered();
plugin_to_save = editor_data.get_editor_plugin(i);
break;
}
}
Check for unsaved changes when closing a scene
2023-04-05 15:45:41 +02:00
Add `_get_unsaved_status()` method to EditorPlugin
2022-10-16 18:09:17 +02:00
if (plugin_to_save) {
break;
}
Scene tab closing refactor
2022-10-14 20:41:05 +02:00
_discard_changes();
break;
}
if (save_each) {
tab_closing_menu_option = current_menu_option;
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
tabs_to_close.push_back(editor_data.get_scene_path(i));
}
_proceed_closing_scene_tabs();
} else {
String unsaved_scenes;
int i = _next_unsaved_scene(true, 0);
while (i != -1) {
unsaved_scenes += "\n " + editor_data.get_edited_scene_root(i)->get_scene_file_path();
i = _next_unsaved_scene(true, ++i);
}
if (p_option == RELOAD_CURRENT_PROJECT) {
save_confirmation->set_ok_button_text(TTR("Save & Reload"));
save_confirmation->set_text(TTR("Save changes to the following scene(s) before reloading?") + unsaved_scenes);
} else {
save_confirmation->set_ok_button_text(TTR("Save & Quit"));
save_confirmation->set_text((p_option == FILE_QUIT ? TTR("Save changes to the following scene(s) before quitting?") : TTR("Save changes to the following scene(s) before opening Project Manager?")) + unsaved_scenes);
}
Adjust size of some dialogs
2023-04-10 17:04:47 +02:00
save_confirmation->reset_size();
Scene tab closing refactor
2022-10-14 20:41:05 +02:00
save_confirmation->popup_centered();
EditorNode: enhance quit dialog
2017-06-24 12:57:30 +02:00
}
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 14:36:29 +01:00
DisplayServer::get_singleton()->window_request_attention();
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
break;
EditorNode: enhance quit dialog
2017-06-24 12:57:30 +02:00
}
Scene tab closing refactor
2022-10-14 20:41:05 +02:00
_save_external_resources();
EditorNode: enhance quit dialog
2017-06-24 12:57:30 +02:00
_discard_changes();
Able to open project manager inside editor (Scene->Project Manager) Remove unnecessary include of project_manager.h
2014-02-18 05:21:06 +01:00
} break;
Make visibility of update spinner editor-wide, hidden by default - Make visibility of the spinner and "update always" option editor-wide, rather than per-project metadata. - Add options "Show Update Spinner" and "Update Continuously" under Editor Settings > Interface > Editor. Both options are false by default. - Rename some variables and constants to be more consistent and clearer: "update always" -> "update continuously", "update changes" -> "update when changed", "update menu" -> "update spinner", "circle" -> "update spinner". Fixes #23738.
2018-12-11 16:52:25 +01:00
case SETTINGS_UPDATE_CONTINUOUSLY: {
EditorSettings::get_singleton()->set("interface/editor/update_continuously", true);
_update_update_spinner();
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 16:47:41 +02:00
show_accept(TTR("This option is deprecated. Situations where refresh must be forced are now considered a bug. Please report."), TTR("OK"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
Make visibility of update spinner editor-wide, hidden by default - Make visibility of the spinner and "update always" option editor-wide, rather than per-project metadata. - Add options "Show Update Spinner" and "Update Continuously" under Editor Settings > Interface > Editor. Both options are false by default. - Rename some variables and constants to be more consistent and clearer: "update always" -> "update continuously", "update changes" -> "update when changed", "update menu" -> "update spinner", "circle" -> "update spinner". Fixes #23738.
2018-12-11 16:52:25 +01:00
case SETTINGS_UPDATE_WHEN_CHANGED: {
EditorSettings::get_singleton()->set("interface/editor/update_continuously", false);
_update_update_spinner();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
WIP new AudioServer, with buses, effects, etc.
2017-01-21 23:00:25 +01:00
case SETTINGS_UPDATE_SPINNER_HIDE: {
Make visibility of update spinner editor-wide, hidden by default - Make visibility of the spinner and "update always" option editor-wide, rather than per-project metadata. - Add options "Show Update Spinner" and "Update Continuously" under Editor Settings > Interface > Editor. Both options are false by default. - Rename some variables and constants to be more consistent and clearer: "update always" -> "update continuously", "update changes" -> "update when changed", "update menu" -> "update spinner", "circle" -> "update spinner". Fixes #23738.
2018-12-11 16:52:25 +01:00
EditorSettings::get_singleton()->set("interface/editor/show_update_spinner", false);
_update_update_spinner();
WIP new AudioServer, with buses, effects, etc.
2017-01-21 23:00:25 +01:00
} break;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
case SETTINGS_PREFERENCES: {
Minor fixes/refactoring of project and editor setting dialogs
2022-02-01 00:19:01 +01:00
editor_settings_dialog->popup_edit_settings();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
Add menu buttons to open the project and editor data folders
2018-07-25 19:53:12 +02:00
case SETTINGS_EDITOR_DATA_FOLDER: {
Implement and expose OS::shell_show_in_file_manager()
2022-12-07 04:33:35 +01:00
OS::get_singleton()->shell_show_in_file_manager(EditorPaths::get_singleton()->get_data_dir(), true);
Add menu buttons to open the project and editor data folders
2018-07-25 19:53:12 +02:00
} break;
case SETTINGS_EDITOR_CONFIG_FOLDER: {
Implement and expose OS::shell_show_in_file_manager()
2022-12-07 04:33:35 +01:00
OS::get_singleton()->shell_show_in_file_manager(EditorPaths::get_singleton()->get_config_dir(), true);
Add menu buttons to open the project and editor data folders
2018-07-25 19:53:12 +02:00
} break;
Export template management dialog. Missing download (need to discuss this!)
2017-03-21 03:31:41 +01:00
case SETTINGS_MANAGE_EXPORT_TEMPLATES: {
export_template_manager->popup_manager();
Add a dialog for customizing FBX import * If FBX files are found, a dialog will pop up asking to configure FBX2glTF. * Dialog can also be accessed by going Editor -> Configure FBX Import. * The dialog also shows a link to click to download the converter, which should contain instructions.
2022-04-02 13:43:15 +02:00
} break;
case SETTINGS_MANAGE_FBX_IMPORTER: {
#if !defined(ANDROID_ENABLED) && !defined(WEB_ENABLED)
fbx_importer_manager->show_dialog();
#endif
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
} break;
Addes ability to load build sources from file. * If not present, the dialog asks to load build sources from a file. * The export templates check now also verifies that build sources are installed and skips the template check. This makes Android development easier.
2021-07-15 15:12:56 +02:00
case SETTINGS_INSTALL_ANDROID_BUILD_TEMPLATE: {
Rename Godot's 'custom build' to 'gradle build' to better reflect the underlying build process.
2023-02-02 00:17:06 +01:00
gradle_build_manage_templates->hide();
Addes ability to load build sources from file. * If not present, the dialog asks to load build sources from a file. * The export templates check now also verifies that build sources are installed and skips the template check. This makes Android development easier.
2021-07-15 15:12:56 +02:00
file_android_build_source->popup_centered_ratio();
} break;
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
case SETTINGS_MANAGE_FEATURE_PROFILES: {
Add Popup::popup_centered_clamped method - Also replace redundant duplicate code in editor dialogs with calls to popup_centered_clamped()
2019-04-26 21:36:44 +02:00
feature_profile_manager->popup_centered_clamped(Size2(900, 800) * EDSCALE, 0.8);
-Add a distraction free mode button (so users know it's there) -Made distaction free not hide the top bar, it's more loss than gain to hide it -Fix fullscreen toggling and added a menu option for it so it's also visible in settings.
2016-09-13 14:46:17 +02:00
} break;
Fix shortcuts using KEY_MASK_CTRL instead of KEY_MASK_CMD KEY_MASK_CMD is automatically replaced by KEY_MASK_CTRL on non-OSX and KEY_MASK_META (Command key) on OSX, so it should be used for all Ctrl/Cmd + key shortcuts. Also de-hacked the macOS shortcut replacements with proper conditional definition. Not tested on macOS, cannot judge if they are good shortcuts. Fixes #10761.
2018-06-11 07:53:25 +02:00
case SETTINGS_TOGGLE_FULLSCREEN: {
[Editor] Save and restore previous window mode when toggling full-screen.
2023-11-27 11:44:30 +01:00
DisplayServer::WindowMode mode = DisplayServer::get_singleton()->window_get_mode();
if (mode == DisplayServer::WINDOW_MODE_FULLSCREEN || mode == DisplayServer::WINDOW_MODE_EXCLUSIVE_FULLSCREEN) {
DisplayServer::get_singleton()->window_set_mode(prev_mode);
} else {
prev_mode = mode;
DisplayServer::get_singleton()->window_set_mode(DisplayServer::WINDOW_MODE_FULLSCREEN);
}
Add option to toggle console window on Windows This is an editor setting and its value can also be toggled using an entry in the Editor toolbar. The console will still appear briefly when starting the project manager or editor, as it's still compiled as console application. Does not impact exported games, which will still run without console in release and with console in debug mode. A project setting or export option could be added to disable it in debug mode if there's demand for it, but that would greatly reduce the usefulness of debug builds if Windows users can no longer report error and crash messages. Fixes #17889. Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
2018-12-18 14:17:43 +01:00
} break;
Add editor screenshot on control - f12.
2019-03-29 14:53:11 +01:00
case EDITOR_SCREENSHOT: {
screenshot_timer->start();
} break;
Ask about selecting a main scene if one has not been selected.
2016-06-28 00:59:33 +02:00
case SETTINGS_PICK_MAIN_SCENE: {
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
file->set_file_mode(EditorFileDialog::FILE_MODE_OPEN_FILE);
Ask about selecting a main scene if one has not been selected.
2016-06-28 00:59:33 +02:00
List<String> extensions;
ResourceLoader::get_recognized_extensions_for_type("PackedScene", &extensions);
file->clear_filters();
for (int i = 0; i < extensions.size(); i++) {
Seperate filter and description in FileDialog.add_filter()
2022-07-04 23:26:26 +02:00
file->add_filter("*." + extensions[i], extensions[i].to_upper());
Ask about selecting a main scene if one has not been selected.
2016-06-28 00:59:33 +02:00
}
Node *scene = editor_data.get_edited_scene_root();
if (scene) {
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 16:30:55 +02:00
file->set_current_path(scene->get_scene_file_path());
Ask about selecting a main scene if one has not been selected.
2016-06-28 00:59:33 +02:00
};
i18n: Corrected a typo (#5460)
2016-06-28 12:00:18 +02:00
file->set_title(TTR("Pick a Main Scene"));
Resize dialogs (FileDialog, EditorFileDialog, Reparent, SceneTreeDialog and resource depency dialogs).
2020-07-11 18:45:19 +02:00
file->popup_file_dialog();
Ask about selecting a main scene if one has not been selected.
2016-06-28 00:59:33 +02:00
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
Added an help menu Also renamed the "tutorials" button in the script editor to be consistent with the help menu entry. Fixed #8921
2017-05-26 16:34:41 +02:00
case HELP_SEARCH: {
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 23:22:52 +02:00
emit_signal(SNAME("request_help_search"), "");
Added an help menu Also renamed the "tutorials" button in the script editor to be consistent with the help menu entry. Fixed #8921
2017-05-26 16:34:41 +02:00
} break;
Added EditorCommandPalette
2021-05-29 15:28:16 +02:00
case HELP_COMMAND_PALETTE: {
command_palette->open_popup();
} break;
Added an help menu Also renamed the "tutorials" button in the script editor to be consistent with the help menu entry. Fixed #8921
2017-05-26 16:34:41 +02:00
case HELP_DOCS: {
Use versioned URL for "Online Documentation" buttons in the editor This also avoids a redirect, making the page appear to load faster.
2022-02-17 18:16:11 +01:00
OS::get_singleton()->shell_open(VERSION_DOCS_URL "/");
Added an help menu Also renamed the "tutorials" button in the script editor to be consistent with the help menu entry. Fixed #8921
2017-05-26 16:34:41 +02:00
} break;
case HELP_QA: {
OS::get_singleton()->shell_open("https://godotengine.org/qa/");
} break;
Remove Request Docs button in the script editor due to various issues The Request Docs button is partly responsible for layout overflow issues on narrow displays, such as #31133. It also tended to attract spam and low-effort issues that were difficult to act upon. A "Send Docs Feedback" menu option has been added to replace it.
2020-01-29 23:10:09 +01:00
case HELP_REPORT_A_BUG: {
Added an help menu Also renamed the "tutorials" button in the script editor to be consistent with the help menu entry. Fixed #8921
2017-05-26 16:34:41 +02:00
OS::get_singleton()->shell_open("https://github.com/godotengine/godot/issues");
} break;
Copy system info to clipboard + Update bug_report.yml plus minor static-related fixes * linuxbsd: get_systemd_os_release_info_value() -> static breaks usage if used multiple times * windows/linuxbsd: get_video_adapter_driver_info() writes info into static * linuxbsd: get_distribution_name() + get_version() -> write bsd fallback into static variable * windows/uwp/android: remove unnecessary use of static
2023-05-27 18:21:23 +02:00
case HELP_COPY_SYSTEM_INFO: {
String info = _get_system_info();
DisplayServer::get_singleton()->clipboard_set(info);
} break;
Add "Suggest a Feature" to the help dialog. Links to Godot Proposals's readme.
2021-06-16 02:24:34 +02:00
case HELP_SUGGEST_A_FEATURE: {
OS::get_singleton()->shell_open("https://github.com/godotengine/godot-proposals#readme");
} break;
Remove Request Docs button in the script editor due to various issues The Request Docs button is partly responsible for layout overflow issues on narrow displays, such as #31133. It also tended to attract spam and low-effort issues that were difficult to act upon. A "Send Docs Feedback" menu option has been added to replace it.
2020-01-29 23:10:09 +01:00
case HELP_SEND_DOCS_FEEDBACK: {
OS::get_singleton()->shell_open("https://github.com/godotengine/godot-docs/issues");
} break;
Added an help menu Also renamed the "tutorials" button in the script editor to be consistent with the help menu entry. Fixed #8921
2017-05-26 16:34:41 +02:00
case HELP_COMMUNITY: {
OS::get_singleton()->shell_open("https://godotengine.org/community");
} break;
case HELP_ABOUT: {
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
about->popup_centered(Size2(780, 500) * EDSCALE);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
Add "Support Godot Development" option to the editor's Help menu
2021-05-15 01:57:21 +02:00
case HELP_SUPPORT_GODOT_DEVELOPMENT: {
OS::get_singleton()->shell_open("https://godotengine.org/donate");
} break;
Split rendering driver project setting into renderer_name and rendering_driver. To differentiate between a driver (e.g. Vulkan or D3D12) and a renderer (e.g. clustered or mobile renderer).
2022-09-08 02:44:36 +02:00
case SET_RENDERER_NAME_SAVE_AND_RESTART: {
ProjectSettings::get_singleton()->set("rendering/renderer/rendering_method", renderer_request);
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
ProjectSettings::get_singleton()->save();
Properly warn about the effects of changing an import type, as well as force editor restart. Fixes #23874
2019-01-25 21:23:56 +01:00
save_all_scenes();
restart_editor();
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
} break;
remove trailing whitespace
2016-03-09 00:00:52 +01:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Fix inconsistent scene file name casing by moving existing Name_Casing code to separate function in editor_node, and adding a call from both editor_node and scene_tree_dock.
2022-09-09 02:29:59 +02:00
String EditorNode::adjust_scene_name_casing(const String &root_name) {
Rearrange `editor/naming/*` project settings
2023-01-12 09:41:13 +01:00
switch (GLOBAL_GET("editor/naming/scene_name_casing").operator int()) {
Fix inconsistent scene file name casing by moving existing Name_Casing code to separate function in editor_node, and adding a call from both editor_node and scene_tree_dock.
2022-09-09 02:29:59 +02:00
case SCENE_NAME_CASING_AUTO:
// Use casing of the root node.
break;
case SCENE_NAME_CASING_PASCAL_CASE:
return root_name.to_pascal_case();
case SCENE_NAME_CASING_SNAKE_CASE:
return root_name.replace("-", "_").to_snake_case();
}
return root_name;
}
Add editor screenshot on control - f12.
2019-03-29 14:53:11 +01:00
void EditorNode::_request_screenshot() {
_screenshot();
}
void EditorNode::_screenshot(bool p_use_utc) {
Add Time singleton
2021-05-24 13:54:05 +02:00
String name = "editor_screenshot_" + Time::get_singleton()->get_datetime_string_from_system(p_use_utc).replace(":", "") + ".png";
Add editor screenshot on control - f12.
2019-03-29 14:53:11 +01:00
NodePath path = String("user://") + name;
_save_screenshot(path);
Unify usage of GLOBAL/EDITOR_GET
2022-10-18 16:43:37 +02:00
if (EDITOR_GET("interface/editor/automatically_open_screenshots")) {
Implement and expose OS::shell_show_in_file_manager()
2022-12-07 04:33:35 +01:00
OS::get_singleton()->shell_show_in_file_manager(ProjectSettings::get_singleton()->globalize_path(path), true);
Add editor screenshot on control - f12.
2019-03-29 14:53:11 +01:00
}
}
void EditorNode::_save_screenshot(NodePath p_path) {
Rename EditorInterface.get_editor_main_control to get_editor_main_screen
2022-09-07 01:30:54 +02:00
Control *editor_main_screen = EditorInterface::get_singleton()->get_editor_main_screen();
[Editor] Replace `ERR_FAIL_COND` with `ERR_FAIL_NULL` where applicable
2023-09-09 17:24:40 +02:00
ERR_FAIL_NULL_MSG(editor_main_screen, "Cannot get the editor main screen control.");
Rename EditorInterface.get_editor_main_control to get_editor_main_screen
2022-09-07 01:30:54 +02:00
Viewport *viewport = editor_main_screen->get_viewport();
[Editor] Replace `ERR_FAIL_COND` with `ERR_FAIL_NULL` where applicable
2023-09-09 17:24:40 +02:00
ERR_FAIL_NULL_MSG(viewport, "Cannot get a viewport from the editor main screen.");
Restore screenshot button.
2020-11-11 23:12:31 +01:00
Ref<ViewportTexture> texture = viewport->get_texture();
Rename EditorInterface.get_editor_main_control to get_editor_main_screen
2022-09-07 01:30:54 +02:00
ERR_FAIL_COND_MSG(texture.is_null(), "Cannot get a viewport texture from the editor main screen.");
Rename Texture.get_data() to get_image()
2021-03-28 13:32:17 +02:00
Ref<Image> img = texture->get_image();
Rename EditorInterface.get_editor_main_control to get_editor_main_screen
2022-09-07 01:30:54 +02:00
ERR_FAIL_COND_MSG(img.is_null(), "Cannot get an image from a viewport texture of the editor main screen.");
Add editor screenshot on control - f12.
2019-03-29 14:53:11 +01:00
Error error = img->save_png(p_path);
Added some obvious errors explanations
2019-09-25 10:28:50 +02:00
ERR_FAIL_COND_MSG(error != OK, "Cannot save screenshot to file '" + p_path + "'.");
Add editor screenshot on control - f12.
2019-03-29 14:53:11 +01:00
}
Added tool menu functions in EditorPlugin
2018-03-17 02:50:35 +01:00
void EditorNode::_tool_menu_option(int p_idx) {
switch (tool_menu->get_item_id(p_idx)) {
case TOOLS_ORPHAN_RESOURCES: {
orphan_resources->show();
} break;
Prevent the surface upgrade tool from running during export Also add an explicit way to trigger the tool manually at user's will.
2023-11-20 14:44:38 +01:00
case TOOLS_SURFACE_UPGRADE: {
Rework the surface upgrade tool to inform users without blocking This removes the immediate confirmation dialog and insteads prints the message to the editor log (and it also appears as a toast). The immediate dialog is a devil's plaything, and it cannot be used in this scenario (if it can be used anywhere at all). The condition that triggers the SUT can happen during any attempt by the rendering server to read a mesh. This means it will conflict with a number of editor processes, like loading, importing, preview generation, export, CLI mode, etc. So while this is less on the nose as far as informing users goes, it's also our best option to use the log and the toaster.
2023-11-22 16:15:02 +01:00
surface_upgrade_dialog->popup_on_demand();
Prevent the surface upgrade tool from running during export Also add an explicit way to trigger the tool manually at user's will.
2023-11-20 14:44:38 +01:00
} break;
Added tool menu functions in EditorPlugin
2018-03-17 02:50:35 +01:00
case TOOLS_CUSTOM: {
if (tool_menu->get_item_submenu(p_idx) == "") {
Make tool menu plugins use Callables for callback
2020-12-16 00:04:21 +01:00
Callable callback = tool_menu->get_item_metadata(p_idx);
Reworked signal connection system, added support for Callable and Signal objects and made them default.
2020-02-19 20:27:19 +01:00
Callable::CallError ce;
Make tool menu plugins use Callables for callback
2020-12-16 00:04:21 +01:00
Variant result;
Remove Signal connect binds Remove the optional argument p_binds from `Object::connect` since it was deprecated by Callable.bind(). Changed all uses of it to Callable.bind()
2022-07-28 22:56:41 +02:00
callback.callp(nullptr, 0, result, ce);
Added tool menu functions in EditorPlugin
2018-03-17 02:50:35 +01:00
Reworked signal connection system, added support for Callable and Signal objects and made them default.
2020-02-19 20:27:19 +01:00
if (ce.error != Callable::CallError::CALL_OK) {
Make tool menu plugins use Callables for callback
2020-12-16 00:04:21 +01:00
String err = Variant::get_callable_error_text(callback, nullptr, 0, ce);
Remove duplicate ERR_PRINT macro.
2019-11-06 17:03:04 +01:00
ERR_PRINT("Error calling function from tool menu: " + err);
Added tool menu functions in EditorPlugin
2018-03-17 02:50:35 +01:00
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
} // Else it's a submenu so don't do anything.
Added tool menu functions in EditorPlugin
2018-03-17 02:50:35 +01:00
} break;
}
}
move gltf export under scene menu
2022-04-06 14:41:04 +02:00
void EditorNode::_export_as_menu_option(int p_idx) {
if (p_idx == 0) { // MeshLibrary
current_menu_option = FILE_EXPORT_MESH_LIBRARY;
if (!editor_data.get_edited_scene_root()) {
show_accept(TTR("This operation can't be done without a scene."), TTR("OK"));
return;
}
List<String> extensions;
Ref<MeshLibrary> ml(memnew(MeshLibrary));
ResourceSaver::get_recognized_extensions(ml, &extensions);
file_export_lib->clear_filters();
for (const String &E : extensions) {
file_export_lib->add_filter("*." + E);
}
file_export_lib->popup_file_dialog();
file_export_lib->set_title(TTR("Export Mesh Library"));
} else { // Custom menu options added by plugins
if (export_as_menu->get_item_submenu(p_idx).is_empty()) { // If not a submenu
Callable callback = export_as_menu->get_item_metadata(p_idx);
Callable::CallError ce;
Variant result;
Remove Signal connect binds Remove the optional argument p_binds from `Object::connect` since it was deprecated by Callable.bind(). Changed all uses of it to Callable.bind()
2022-07-28 22:56:41 +02:00
callback.callp(nullptr, 0, result, ce);
move gltf export under scene menu
2022-04-06 14:41:04 +02:00
if (ce.error != Callable::CallError::CALL_OK) {
String err = Variant::get_callable_error_text(callback, nullptr, 0, ce);
ERR_PRINT("Error calling function from export_as menu: " + err);
}
}
}
}
Fix !save_each_scene saving scenes with no filename When save_each_scene is false, only scenes that have been saved at least once are saved. But EditorNode tries to save scenes with no filename too (they're never saved), so it crashes.
2017-07-26 13:29:45 +02:00
int EditorNode::_next_unsaved_scene(bool p_valid_filename, int p_start) {
for (int i = p_start; i < editor_data.get_edited_scene_count(); i++) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!editor_data.get_edited_scene_root(i)) {
Fix crash on closing [empty](*) scene tab
2017-07-09 20:48:39 +02:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Check for unsaved changes when closing a scene
2023-04-05 15:45:41 +02:00
String scene_filename = editor_data.get_edited_scene_root(i)->get_scene_file_path();
if (p_valid_filename && scene_filename.is_empty()) {
continue;
}
Add EditorUndoRedoManager singleton
2022-12-23 23:53:16 +01:00
bool unsaved = EditorUndoRedoManager::get_singleton()->is_history_unsaved(editor_data.get_scene_history_id(i));
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
if (unsaved) {
return i;
Check for unsaved changes when closing a scene
2023-04-05 15:45:41 +02:00
} else {
for (int j = 0; j < editor_data.get_editor_plugin_count(); j++) {
if (!editor_data.get_editor_plugin(j)->get_unsaved_status(scene_filename).is_empty()) {
return i;
}
}
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
}
EditorNode: enhance quit dialog
2017-06-24 12:57:30 +02:00
}
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
return -1;
EditorNode: enhance quit dialog
2017-06-24 12:57:30 +02:00
}
Replace use of `OS::set_exit_code()` by `SceneTree::quit()` in `EditorNode`
2022-01-18 12:48:12 +01:00
void EditorNode::_exit_editor(int p_exit_code) {
Perform a cleaner exit for resource preview, fixes #24206
2019-01-17 13:09:01 +01:00
exiting = true;
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
resource_preview->stop(); // Stop early to avoid crashes.
Improve editor state persistence
2023-05-11 04:17:03 +02:00
_save_editor_layout();
Dim the editor window while it's quitting This makes it clearer that the editor window is busy while it's quitting (which can take a while on slower PCs). This also makes it feel more responsive to user input. Note that the effect is only visible if "Interface > Editor > Quit Confirmation" is disabled in the Editor Settings, as the quit confirmation already makes the editor window dim while quitting.
2019-07-04 23:45:51 +02:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Dim the editor window while it's quitting to make it clearer that it's busy.
Remove `dim_editor_on_dialog_popup` from editor settings
2021-05-29 01:58:03 +02:00
dim_editor(true);
Dim the editor window while it's quitting This makes it clearer that the editor window is busy while it's quitting (which can take a while on slower PCs). This also makes it feel more responsive to user input. Note that the effect is only visible if "Interface > Editor > Quit Confirmation" is disabled in the Editor Settings, as the quit confirmation already makes the editor window dim while quitting.
2019-07-04 23:45:51 +02:00
Replace use of `OS::set_exit_code()` by `SceneTree::quit()` in `EditorNode`
2022-01-18 12:48:12 +01:00
get_tree()->quit(p_exit_code);
Perform a cleaner exit for resource preview, fixes #24206
2019-01-17 13:09:01 +01:00
}
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 06:15:39 +02:00
void EditorNode::_discard_changes(const String &p_str) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
switch (current_menu_option) {
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 06:15:39 +02:00
case FILE_CLOSE:
case SCENE_TAB_CLOSE: {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
Node *scene = editor_data.get_edited_scene_root(tab_closing_idx);
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
if (scene != nullptr) {
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 16:30:55 +02:00
String scene_filename = scene->get_scene_file_path();
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 10:42:46 +01:00
if (!scene_filename.is_empty()) {
Don't add unsaved scene to previous scenes list
2019-07-31 23:49:16 +02:00
previous_scenes.push_back(scene_filename);
}
Add Undo Close Tab option in tabs context menu
2019-04-10 17:21:26 +02:00
}
Scene tab closing refactor
2022-10-14 20:41:05 +02:00
// Don't close tabs when exiting the editor (required for "restore_scenes_on_load" setting).
if (!_is_closing_editor()) {
_remove_scene(tab_closing_idx);
Extract editor scene tabs into their own component
2023-08-24 12:24:29 +02:00
scene_tabs->update_scene_tabs();
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
}
Scene tab closing refactor
2022-10-14 20:41:05 +02:00
_proceed_closing_scene_tabs();
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 06:15:39 +02:00
} break;
EditorNode: enhance quit dialog
2017-06-24 12:57:30 +02:00
case FILE_QUIT: {
Extract editor run toolbar into its own component - Simplify and update its logic. - Simplify EditorScript. - Improve EditorNode and other relevant includes. - Fix scene-based path in the movie writer when reloading a scene.
2023-04-12 21:02:28 +02:00
project_run_bar->stop_playing();
Replace use of `OS::set_exit_code()` by `SceneTree::quit()` in `EditorNode`
2022-01-18 12:48:12 +01:00
_exit_editor(EXIT_SUCCESS);
Perform a cleaner exit for resource preview, fixes #24206
2019-01-17 13:09:01 +01:00
EditorNode: enhance quit dialog
2017-06-24 12:57:30 +02:00
} break;
case RUN_PROJECT_MANAGER: {
Extract editor run toolbar into its own component - Simplify and update its logic. - Simplify EditorScript. - Improve EditorNode and other relevant includes. - Fix scene-based path in the movie writer when reloading a scene.
2023-04-12 21:02:28 +02:00
project_run_bar->stop_playing();
Replace use of `OS::set_exit_code()` by `SceneTree::quit()` in `EditorNode`
2022-01-18 12:48:12 +01:00
_exit_editor(EXIT_SUCCESS);
EditorNode: enhance quit dialog
2017-06-24 12:57:30 +02:00
String exec = OS::get_singleton()->get_executable_path();
List<String> args;
Overhaul CLI argument forwarding to processes started by the editor
2022-08-13 21:52:03 +02:00
for (const String &a : Main::get_forwardable_cli_arguments(Main::CLI_SCOPE_TOOL)) {
args.push_back(a);
}
Fix issue causing the project manager to crash because of missing path argument In the process, the initialization logic is updated to show an error message and gracefully close the engine when setup errors occur.
2022-09-07 23:21:34 +02:00
String exec_base_dir = exec.get_base_dir();
if (!exec_base_dir.is_empty()) {
args.push_back("--path");
args.push_back(exec_base_dir);
}
Tweak command-line arguments to make them more UNIX-like Also improves the command-line help text readability.
2017-06-21 11:09:30 +02:00
args.push_back("--project-manager");
EditorNode: enhance quit dialog
2017-06-24 12:57:30 +02:00
[macOS] Add `create_instance` function to spawn editor copies. [macOS] Modify `create_project` function to detect and run app bundles using NSWorkspace to ensure app window is registered and activated correctly.
2021-11-01 10:12:52 +01:00
Error err = OS::get_singleton()->create_instance(args);
EditorNode: enhance quit dialog
2017-06-24 12:57:30 +02:00
ERR_FAIL_COND(err);
} break;
Made reload current project ask for confirmation with unsaved changes
2022-03-23 12:07:29 +01:00
case RELOAD_CURRENT_PROJECT: {
restart_editor();
} break;
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 06:15:39 +02:00
}
}
Add Undo Close Tab option in tabs context menu
2019-04-10 17:21:26 +02:00
void EditorNode::_update_file_menu_opened() {
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
file_menu->set_item_disabled(file_menu->get_item_index(FILE_OPEN_PREV), previous_scenes.is_empty());
Fix Undo/Redo not working until Scene menu is opened.
2023-01-08 09:35:15 +01:00
_update_undo_redo_allowed();
Add Undo Close Tab option in tabs context menu
2019-04-10 17:21:26 +02:00
}
void EditorNode::_update_file_menu_closed() {
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
file_menu->set_item_disabled(file_menu->get_item_index(FILE_OPEN_PREV), false);
Add Undo Close Tab option in tabs context menu
2019-04-10 17:21:26 +02:00
}
Rename EditorInterface.get_editor_main_control to get_editor_main_screen
2022-09-07 01:30:54 +02:00
VBoxContainer *EditorNode::get_main_screen_control() {
return main_screen_vbox;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Port remaining connections to callable_mp
2020-12-06 16:09:18 +01:00
void EditorNode::editor_select(int p_which) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
static bool selecting = false;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (selecting || changing_scene) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
ERR_FAIL_INDEX(p_which, editor_table.size());
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
if (!main_editor_buttons[p_which]->is_visible()) { // Button hidden, no editor.
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
selecting = true;
-fixed tabs
2015-11-18 08:47:41 +01:00
for (int i = 0; i < main_editor_buttons.size(); i++) {
main_editor_buttons[i]->set_pressed(i == p_which);
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
selecting = false;
EditorPlugin *new_editor = editor_table[p_which];
[Editor] Replace `ERR_FAIL_COND` with `ERR_FAIL_NULL` where applicable
2023-09-09 17:24:40 +02:00
ERR_FAIL_NULL(new_editor);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (editor_plugin_screen == new_editor) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (editor_plugin_screen) {
editor_plugin_screen->make_visible(false);
}
editor_plugin_screen = new_editor;
editor_plugin_screen->make_visible(true);
editor_plugin_screen->selected_notify();
Separate fullscreen state for scene & script editor
2017-04-25 13:48:35 +02:00
Make available more informations about editor for Tool Plugins
2017-07-06 09:18:20 +02:00
int plugin_count = editor_data.get_editor_plugin_count();
for (int i = 0; i < plugin_count; i++) {
editor_data.get_editor_plugin(i)->notify_main_screen_changed(editor_plugin_screen->get_name());
}
Unify usage of GLOBAL/EDITOR_GET
2022-10-18 16:43:37 +02:00
if (EDITOR_GET("interface/editor/separate_distraction_mode")) {
Separate fullscreen state for scene & script editor
2017-04-25 13:48:35 +02:00
if (p_which == EDITOR_SCRIPT) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
set_distraction_free_mode(script_distraction_free);
Separate fullscreen state for scene & script editor
2017-04-25 13:48:35 +02:00
} else {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
set_distraction_free_mode(scene_distraction_free);
Separate fullscreen state for scene & script editor
2017-04-25 13:48:35 +02:00
}
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Let EditorPlugins set editor/distraction-free mode
2019-08-05 19:57:23 +02:00
void EditorNode::select_editor_by_name(const String &p_name) {
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 10:42:46 +01:00
ERR_FAIL_COND(p_name.is_empty());
Let EditorPlugins set editor/distraction-free mode
2019-08-05 19:57:23 +02:00
for (int i = 0; i < main_editor_buttons.size(); i++) {
if (main_editor_buttons[i]->get_text() == p_name) {
Port remaining connections to callable_mp
2020-12-06 16:09:18 +01:00
editor_select(i);
Let EditorPlugins set editor/distraction-free mode
2019-08-05 19:57:23 +02:00
return;
}
}
Replace 'ERR_EXPLAIN' with 'ERR_FAIL_*_MSG' in 'core/' and 'editor/' Condensed some if and ERR statements. Added dots to end of error messages Couldn't figure out EXPLAINC. These files gave me trouble: core/error_macros.h, core/io/file_access_buffered_fa.h (where is it?), core/os/memory.cpp, drivers/png/png_driver_common.cpp, drivers/xaudio2/audio_driver_xaudio2.cpp (where is it?)
2019-08-15 04:57:49 +02:00
ERR_FAIL_MSG("The editor name '" + p_name + "' was not found.");
Let EditorPlugins set editor/distraction-free mode
2019-08-05 19:57:23 +02:00
}
Added basic support for custom resource savers and loaders
2018-06-11 02:59:53 +02:00
void EditorNode::add_editor_plugin(EditorPlugin *p_editor, bool p_config_changed) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (p_editor->has_main_screen()) {
Remove ToolButton in favor of Button ToolButton has no redeeming differences with Button; it's just a Button with the Flat property enabled by default. Removing it avoids some confusion when creating GUIs. Existing ToolButtons will be converted to Buttons, but the Flat property won't be enabled automatically. This closes https://github.com/godotengine/godot-proposals/issues/1081.
2020-06-19 20:49:04 +02:00
Button *tb = memnew(Button);
tb->set_flat(true);
-fixed tabs
2015-11-18 08:47:41 +01:00
tb->set_toggle_mode(true);
Port remaining connections to callable_mp
2020-12-06 16:09:18 +01:00
tb->connect("pressed", callable_mp(singleton, &EditorNode::editor_select).bind(singleton->main_editor_buttons.size()));
Make default main screen plugin work even if 2D and 3D are disabled
2020-08-05 05:14:39 +02:00
tb->set_name(p_editor->get_name());
Revert "Add new editor and default theme (WIP)" This reverts commit f045efe007cffb87238ee519b7f33d710814ded7.
2017-05-02 23:02:06 +02:00
tb->set_text(p_editor->get_name());
Add method to set main screen plugin icon
2017-12-06 23:27:45 +01:00
Make default main screen plugin work even if 2D and 3D are disabled
2020-08-05 05:14:39 +02:00
Ref<Texture2D> icon = p_editor->get_icon();
Add method to set main screen plugin icon
2017-12-06 23:27:45 +01:00
if (icon.is_valid()) {
tb->set_icon(icon);
Allow images to be imported "for editor use" and respect editor settings
2022-08-22 21:07:02 +02:00
// Make sure the control is updated if the icon is reimported.
Unify and streamline connecting to Resource changes
2023-07-03 21:29:37 +02:00
icon->connect_changed(callable_mp((Control *)tb, &Control::update_minimum_size));
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
} else if (singleton->theme->has_icon(p_editor->get_name(), EditorStringName(EditorIcons))) {
tb->set_icon(singleton->theme->get_icon(p_editor->get_name(), EditorStringName(EditorIcons)));
Add method to set main screen plugin icon
2017-12-06 23:27:45 +01:00
}
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
tb->add_theme_font_override("font", singleton->theme->get_font(SNAME("main_button_font"), EditorStringName(EditorFonts)));
tb->add_theme_font_size_override("font_size", singleton->theme->get_font_size(SNAME("main_button_font_size"), EditorStringName(EditorFonts)));
Use bold fonts in editor * Labels are now bold * Categories in trees are bold * Main editor buttons are bold * Fixed section folding arrows in inspector
2021-05-27 17:32:30 +02:00
-fixed tabs
2015-11-18 08:47:41 +01:00
singleton->main_editor_buttons.push_back(tb);
[macOS extend-to-title] Add scene/project name to the editor title, fix incorrect window button position/order when system primary language is RTL.
2022-09-22 11:06:11 +02:00
singleton->main_editor_button_hb->add_child(tb);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
singleton->editor_table.push_back(p_editor);
-Add a distraction free mode button (so users know it's there) -Made distaction free not hide the top bar, it's more loss than gain to hide it -Fix fullscreen toggling and added a menu option for it so it's also visible in settings.
2016-09-13 14:46:17 +02:00
Rename raise() to move_to_front()
2022-04-10 20:52:55 +02:00
singleton->distraction_free->move_to_front();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
singleton->editor_data.add_editor_plugin(p_editor);
singleton->add_child(p_editor);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (p_config_changed) {
Added basic support for custom resource savers and loaders
2018-06-11 02:59:53 +02:00
p_editor->enable_plugin();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Added basic support for custom resource savers and loaders
2018-06-11 02:59:53 +02:00
void EditorNode::remove_editor_plugin(EditorPlugin *p_editor, bool p_config_changed) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (p_editor->has_main_screen()) {
Solve a bug with main window plugins. When removing a main window plugin the bindings of the main window buttons was not changed to reflect the changed indices.
2022-10-06 19:23:34 +02:00
// Remove the main editor button and update the bindings of
// all buttons behind it to point to the correct main window.
for (int i = singleton->main_editor_buttons.size() - 1; i >= 0; i--) {
Add a function to plugin get the main screen parent - Fix a bug where the main screen button did not disappear when the plugin was deactivated.
2016-09-16 20:02:01 +02:00
if (p_editor->get_name() == singleton->main_editor_buttons[i]->get_text()) {
Fix crash when disabling main screen plugin
2016-09-22 00:17:55 +02:00
if (singleton->main_editor_buttons[i]->is_pressed()) {
Port remaining connections to callable_mp
2020-12-06 16:09:18 +01:00
singleton->editor_select(EDITOR_SCRIPT);
Fix crash when disabling main screen plugin
2016-09-22 00:17:55 +02:00
}
-fixed tabs
2015-11-18 08:47:41 +01:00
memdelete(singleton->main_editor_buttons[i]);
Rename `remove()` to `remove_at()` when removing by index
2021-07-04 00:17:03 +02:00
singleton->main_editor_buttons.remove_at(i);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
break;
Solve a bug with main window plugins. When removing a main window plugin the bindings of the main window buttons was not changed to reflect the changed indices.
2022-10-06 19:23:34 +02:00
} else {
singleton->main_editor_buttons[i]->disconnect("pressed", callable_mp(singleton, &EditorNode::editor_select));
singleton->main_editor_buttons[i]->connect("pressed", callable_mp(singleton, &EditorNode::editor_select).bind(i - 1));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
}
singleton->editor_table.erase(p_editor);
}
editor_node.cpp now takes care of removing plugin after deactivating it
2016-06-19 00:29:16 +02:00
p_editor->make_visible(false);
p_editor->clear();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (p_config_changed) {
Added basic support for custom resource savers and loaders
2018-06-11 02:59:53 +02:00
p_editor->disable_plugin();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Fix crash after disabling plugin using set_force_draw_over_forwarding_enabled()
2021-05-17 10:46:59 +02:00
singleton->editor_plugins_over->remove_plugin(p_editor);
singleton->editor_plugins_force_over->remove_plugin(p_editor);
singleton->editor_plugins_force_input_forwarding->remove_plugin(p_editor);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
singleton->remove_child(p_editor);
singleton->editor_data.remove_editor_plugin(p_editor);
Remove disabled plugins from active plugins
2023-03-25 21:12:47 +01:00
for (KeyValue<ObjectID, HashSet<EditorPlugin *>> &kv : singleton->active_plugins) {
kv.value.erase(p_editor);
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Allow GDExtensions to add editor plugins
2023-05-11 23:46:53 +02:00
void EditorNode::add_extension_editor_plugin(const StringName &p_class_name) {
ERR_FAIL_COND_MSG(!ClassDB::class_exists(p_class_name), vformat("No such editor plugin registered: %s", p_class_name));
ERR_FAIL_COND_MSG(!ClassDB::is_parent_class(p_class_name, SNAME("EditorPlugin")), vformat("Class is not an editor plugin: %s", p_class_name));
ERR_FAIL_COND_MSG(singleton->editor_data.has_extension_editor_plugin(p_class_name), vformat("Editor plugin already added for class: %s", p_class_name));
EditorPlugin *plugin = Object::cast_to<EditorPlugin>(ClassDB::instantiate(p_class_name));
singleton->editor_data.add_extension_editor_plugin(p_class_name, plugin);
add_editor_plugin(plugin);
}
void EditorNode::remove_extension_editor_plugin(const StringName &p_class_name) {
// If we're exiting, the editor plugins will get cleaned up anyway, so don't do anything.
if (singleton->exiting) {
return;
}
ERR_FAIL_COND_MSG(!singleton->editor_data.has_extension_editor_plugin(p_class_name), vformat("No editor plugin added for class: %s", p_class_name));
EditorPlugin *plugin = singleton->editor_data.get_extension_editor_plugin(p_class_name);
remove_editor_plugin(plugin);
Implement reloading of GDExtensions
2023-08-05 03:34:14 +02:00
memdelete(plugin);
Allow GDExtensions to add editor plugins
2023-05-11 23:46:53 +02:00
singleton->editor_data.remove_extension_editor_plugin(p_class_name);
}
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
void EditorNode::_update_addon_config() {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
if (_initializing_plugins) {
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
Vector<String> enabled_addons;
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
for (const KeyValue<String, EditorPlugin *> &E : addon_name_to_plugin) {
Use range iterators for `Map`
2021-08-09 22:13:42 +02:00
enabled_addons.push_back(E.key);
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
}
if (enabled_addons.size() == 0) {
-Renamed GlobalConfig to ProjectSettings, makes more sense. -Added system for feature overrides, it's pretty cool :)
2017-07-19 22:00:46 +02:00
ProjectSettings::get_singleton()->set("editor_plugins/enabled", Variant());
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
} else {
Sort the list of addons before saving them
2023-05-11 20:39:26 +02:00
enabled_addons.sort();
-Renamed GlobalConfig to ProjectSettings, makes more sense. -Added system for feature overrides, it's pretty cool :)
2017-07-19 22:00:46 +02:00
ProjectSettings::get_singleton()->set("editor_plugins/enabled", enabled_addons);
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
}
Minor fixes/refactoring of project and editor setting dialogs
2022-02-01 00:19:01 +01:00
project_settings_editor->queue_save();
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
}
Added basic support for custom resource savers and loaders
2018-06-11 02:59:53 +02:00
void EditorNode::set_addon_plugin_enabled(const String &p_addon, bool p_enabled, bool p_config_changed) {
Allow plugin name in `is_plugin_enabled` Fixes #61604.
2022-06-08 19:22:30 +02:00
String addon_path = p_addon;
if (!addon_path.begins_with("res://")) {
addon_path = "res://addons/" + addon_path + "/plugin.cfg";
}
ERR_FAIL_COND(p_enabled && addon_name_to_plugin.has(addon_path));
ERR_FAIL_COND(!p_enabled && !addon_name_to_plugin.has(addon_path));
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
if (!p_enabled) {
Allow plugin name in `is_plugin_enabled` Fixes #61604.
2022-06-08 19:22:30 +02:00
EditorPlugin *addon = addon_name_to_plugin[addon_path];
Added basic support for custom resource savers and loaders
2018-06-11 02:59:53 +02:00
remove_editor_plugin(addon, p_config_changed);
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
memdelete(addon);
Allow plugin name in `is_plugin_enabled` Fixes #61604.
2022-06-08 19:22:30 +02:00
addon_name_to_plugin.erase(addon_path);
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
_update_addon_config();
return;
}
Ref<ConfigFile> cf;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
cf.instantiate();
Allow plugin name in `is_plugin_enabled` Fixes #61604.
2022-06-08 19:22:30 +02:00
if (!DirAccess::exists(addon_path.get_base_dir())) {
_remove_plugin_from_enabled(addon_path);
WARN_PRINT("Addon '" + addon_path + "' failed to load. No directory found. Removing from enabled plugins.");
Auto-cleanup missing addons
2019-02-17 00:53:14 +01:00
return;
}
Allow plugin name in `is_plugin_enabled` Fixes #61604.
2022-06-08 19:22:30 +02:00
Error err = cf->load(addon_path);
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
if (err != OK) {
Allow plugin name in `is_plugin_enabled` Fixes #61604.
2022-06-08 19:22:30 +02:00
show_warning(vformat(TTR("Unable to enable addon plugin at: '%s' parsing of config failed."), addon_path));
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
return;
}
Re-architect how Android plugins are packaged and handled at export time The previous packaging format for Godot Android plugins consisted of the plugin's `gdap` config file accompanied by binaries defined in the `gdap` file. This format is now deprecated (starting with Godot 4.2), and instead Godot Android plugins are now packaged as `EditorExportPlugin` plugins. The `EditorExportPlugin` class has been updated with the following methods to provide the necessary set of functionality: - `_supports_platform`: returns true if the plugin supports the given platform - `_get_android_dependencies`: retrieve the set of android dependencies (e.g: `org.godot.example:my-plugin:0.0.0`) provided by the plugin - `_get_android_dependencies_maven_repos`: retrieve the urls of the maven repos for the provided android dependencies - `_get_android_libraries`: retrieve the local paths of the android libraries (AAR files) provided by the plugin - `_get_android_manifest_activity_element_contents`: update the contents of the `<activity>` element in the generated Android manifest - `_get_android_manifest_application_element_contents`: update the contents of the `<application>` element in the generated Android manifest - `_get_android_manifest_element_contents`: update the contents of the `<manifest>` element in the generated Android manifest
2023-07-02 20:14:29 +02:00
String plugin_version;
if (cf->has_section_key("plugin", "version")) {
plugin_version = cf->get_value("plugin", "version");
}
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
if (!cf->has_section_key("plugin", "script")) {
Allow plugin name in `is_plugin_enabled` Fixes #61604.
2022-06-08 19:22:30 +02:00
show_warning(vformat(TTR("Unable to find script field for addon plugin at: '%s'."), addon_path));
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
return;
}
Allow plugins to not have an init script
2019-08-15 19:40:22 +02:00
String script_path = cf->get_value("plugin", "script");
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-09-29 11:53:28 +02:00
Ref<Script> scr; // We need to save it for creating "ep" below.
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
Allow plugins to not have an init script
2019-08-15 19:40:22 +02:00
// Only try to load the script if it has a name. Else, the plugin has no init script.
if (script_path.length() > 0) {
Rename String `plus_file` to `path_join`
2022-08-30 02:34:01 +02:00
script_path = addon_path.get_base_dir().path_join(script_path);
Load script for addons without cache Since they are postponed sometimes due to transient script errors, it needs to try again without the cache to compile the script again instead of using the failed one.
2023-02-22 19:52:36 +01:00
scr = ResourceLoader::load(script_path, "Script", ResourceFormatLoader::CACHE_MODE_IGNORE);
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-09-29 11:53:28 +02:00
if (scr.is_null()) {
Allow plugins to not have an init script
2019-08-15 19:40:22 +02:00
show_warning(vformat(TTR("Unable to load addon script from path: '%s'."), script_path));
return;
}
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
Refactor some object type checking code with `cast_to` Less stringly typed logic, and less String allocations and comparisons.
2022-02-06 14:12:19 +01:00
// Errors in the script cause the base_type to be an empty StringName.
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-09-29 11:53:28 +02:00
if (scr->get_instance_base_type() == StringName()) {
Retry loading addons after filesystem scan
2022-12-28 13:56:53 +01:00
if (_initializing_plugins) {
// However, if it happens during initialization, waiting for file scan might help.
pending_addons.push_back(p_addon);
return;
}
Allow plugin name in `is_plugin_enabled` Fixes #61604.
2022-06-08 19:22:30 +02:00
show_warning(vformat(TTR("Unable to load addon script from path: '%s'. This might be due to a code error in that script.\nDisabling the addon at '%s' to prevent further errors."), script_path, addon_path));
_remove_plugin_from_enabled(addon_path);
Allow plugins to not have an init script
2019-08-15 19:40:22 +02:00
return;
}
Better error message for malformed plugins
2018-10-13 14:20:18 +02:00
Allow plugins to not have an init script
2019-08-15 19:40:22 +02:00
// Plugin init scripts must inherit from EditorPlugin and be tools.
Correctly check scripts that must inherit `EditorPlugin` Also updates some error messages related to this kind of check across the codebase.
2023-11-23 16:19:24 +01:00
if (!ClassDB::is_parent_class(scr->get_instance_base_type(), "EditorPlugin")) {
show_warning(vformat(TTR("Unable to load addon script from path: '%s'. Base type is not 'EditorPlugin'."), script_path));
Allow plugins to not have an init script
2019-08-15 19:40:22 +02:00
return;
}
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-09-29 11:53:28 +02:00
if (!scr->is_tool()) {
Correctly check scripts that must inherit `EditorPlugin` Also updates some error messages related to this kind of check across the codebase.
2023-11-23 16:19:24 +01:00
show_warning(vformat(TTR("Unable to load addon script from path: '%s'. Script is not in tool mode."), script_path));
Allow plugins to not have an init script
2019-08-15 19:40:22 +02:00
return;
}
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
}
EditorPlugin *ep = memnew(EditorPlugin);
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-09-29 11:53:28 +02:00
ep->set_script(scr);
Re-architect how Android plugins are packaged and handled at export time The previous packaging format for Godot Android plugins consisted of the plugin's `gdap` config file accompanied by binaries defined in the `gdap` file. This format is now deprecated (starting with Godot 4.2), and instead Godot Android plugins are now packaged as `EditorExportPlugin` plugins. The `EditorExportPlugin` class has been updated with the following methods to provide the necessary set of functionality: - `_supports_platform`: returns true if the plugin supports the given platform - `_get_android_dependencies`: retrieve the set of android dependencies (e.g: `org.godot.example:my-plugin:0.0.0`) provided by the plugin - `_get_android_dependencies_maven_repos`: retrieve the urls of the maven repos for the provided android dependencies - `_get_android_libraries`: retrieve the local paths of the android libraries (AAR files) provided by the plugin - `_get_android_manifest_activity_element_contents`: update the contents of the `<activity>` element in the generated Android manifest - `_get_android_manifest_application_element_contents`: update the contents of the `<application>` element in the generated Android manifest - `_get_android_manifest_element_contents`: update the contents of the `<manifest>` element in the generated Android manifest
2023-07-02 20:14:29 +02:00
ep->set_plugin_version(plugin_version);
Allow plugin name in `is_plugin_enabled` Fixes #61604.
2022-06-08 19:22:30 +02:00
addon_name_to_plugin[addon_path] = ep;
Added basic support for custom resource savers and loaders
2018-06-11 02:59:53 +02:00
add_editor_plugin(ep, p_config_changed);
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
_update_addon_config();
}
bool EditorNode::is_addon_plugin_enabled(const String &p_addon) const {
Allow plugin name in `is_plugin_enabled` Fixes #61604.
2022-06-08 19:22:30 +02:00
if (p_addon.begins_with("res://")) {
return addon_name_to_plugin.has(p_addon);
}
return addon_name_to_plugin.has("res://addons/" + p_addon + "/plugin.cfg");
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
}
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 05:36:23 +02:00
void EditorNode::_remove_edited_scene(bool p_change_tab) {
Unedit nodes early when closing scene tab
2023-08-21 14:12:26 +02:00
// When scene gets closed no node is edited anymore, so make sure the editors are notified before nodes are freed.
hide_unused_editors(SceneTreeDock::get_singleton());
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
int new_index = editor_data.get_edited_scene();
int old_index = new_index;
if (new_index > 0) {
new_index = new_index - 1;
} else if (editor_data.get_edited_scene_count() > 1) {
new_index = 1;
} else {
editor_data.add_edited_scene(-1);
new_index = 1;
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (p_change_tab) {
Extract editor scene tabs into their own component
2023-08-24 12:24:29 +02:00
_set_current_scene(new_index);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
editor_data.remove_scene(old_index);
_update_title();
Extract editor scene tabs into their own component
2023-08-24 12:24:29 +02:00
scene_tabs->update_scene_tabs();
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
}
Fix #2623
2015-10-22 00:23:42 +02:00
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 05:36:23 +02:00
void EditorNode::_remove_scene(int index, bool p_change_tab) {
Cache script icons in editor
2022-05-05 14:27:29 +02:00
// Clear icon cache in case some scripts are no longer needed.
Add a script method to get its class icon Co-authored-by: Danil Alexeev <danil@alexeev.xyz>
2023-08-24 12:49:20 +02:00
// FIXME: Ideally the cache should never be cleared and only updated on per-script basis, when an icon changes.
Streamline class icon resolution in the editor
2023-03-31 21:17:59 +02:00
editor_data.clear_script_icon_cache();
Cache script icons in editor
2022-05-05 14:27:29 +02:00
Fix #2623
2015-10-22 00:23:42 +02:00
if (editor_data.get_edited_scene() == index) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Scene to remove is current scene.
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 05:36:23 +02:00
_remove_edited_scene(p_change_tab);
Fix #2623
2015-10-22 00:23:42 +02:00
} else {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Scene to remove is not active scene.
Fix #2623
2015-10-22 00:23:42 +02:00
editor_data.remove_scene(index);
}
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
void EditorNode::set_edited_scene(Node *p_scene) {
Update the edit scene root in time after it is replaced When changing the type of the edited scene root node, it may be necessary to update edited scene root in time for the child nodes to work properly.
2022-11-13 07:52:37 +01:00
Node *old_edited_scene_root = get_editor_data().get_edited_scene_root();
if (old_edited_scene_root) {
if (old_edited_scene_root->get_parent() == scene_root) {
scene_root->remove_child(old_edited_scene_root);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Update the edit scene root in time after it is replaced When changing the type of the edited scene root node, it may be necessary to update edited scene root in time for the child nodes to work properly.
2022-11-13 07:52:37 +01:00
old_edited_scene_root->disconnect(SNAME("replacing_by"), callable_mp(this, &EditorNode::set_edited_scene));
remove trailing whitespace
2016-03-09 00:00:52 +01:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
get_editor_data().set_edited_scene_root(p_scene);
remove trailing whitespace
2016-03-09 00:00:52 +01:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (Object::cast_to<Popup>(p_scene)) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
Object::cast_to<Popup>(p_scene)->show();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Store panels and docks singletons in their own classes
2021-11-17 21:08:55 +01:00
SceneTreeDock::get_singleton()->set_edited_scene(p_scene);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (get_tree()) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
get_tree()->set_edited_scene_root(p_scene);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
if (p_scene) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (p_scene->get_parent() != scene_root) {
Remove node_hrcr hack
2021-10-21 16:46:07 +02:00
scene_root->add_child(p_scene, true);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Update the edit scene root in time after it is replaced When changing the type of the edited scene root node, it may be necessary to update edited scene root in time for the child nodes to work properly.
2022-11-13 07:52:37 +01:00
p_scene->connect(SNAME("replacing_by"), callable_mp(this, &EditorNode::set_edited_scene));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
}
-fixed tabs
2015-11-18 08:47:41 +01:00
int EditorNode::_get_current_main_editor() {
for (int i = 0; i < editor_table.size(); i++) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (editor_table[i] == editor_plugin_screen) {
-fixed tabs
2015-11-18 08:47:41 +01:00
return i;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
-fixed tabs
2015-11-18 08:47:41 +01:00
}
return 0;
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
Dictionary EditorNode::_get_main_scene_state() {
Dictionary state;
-fixed tabs
2015-11-18 08:47:41 +01:00
state["main_tab"] = _get_current_main_editor();
Store panels and docks singletons in their own classes
2021-11-17 21:08:55 +01:00
state["scene_tree_offset"] = SceneTreeDock::get_singleton()->get_tree_editor()->get_scene_tree()->get_vscroll_bar()->get_value();
state["property_edit_offset"] = InspectorDock::get_inspector_singleton()->get_scroll_offset();
state["node_filter"] = SceneTreeDock::get_singleton()->get_filter();
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
return state;
}
Editor properly reloads scenes if they changed on disk or were reimported
2016-06-28 23:53:31 +02:00
void EditorNode::_set_main_scene_state(Dictionary p_state, Node *p_for_scene) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (get_edited_scene() != p_for_scene && p_for_scene != nullptr) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
return; // Not for this scene.
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
-Merged Script and Help tabs -Help tabs can be opened many at the same time -Color temperatures for opened scripts -Dominant script opening when switching scene tab
2015-11-17 13:46:08 +01:00
changing_scene = false;
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-09-29 11:53:28 +02:00
int current_tab = -1;
Fixed Tab Switching of Main Scene State. Closes #11045
2017-09-08 23:45:04 +02:00
for (int i = 0; i < editor_table.size(); i++) {
if (editor_plugin_screen == editor_table[i]) {
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-09-29 11:53:28 +02:00
current_tab = i;
Fixed Tab Switching of Main Scene State. Closes #11045
2017-09-08 23:45:04 +02:00
break;
-Merged Script and Help tabs -Help tabs can be opened many at the same time -Color temperatures for opened scripts -Dominant script opening when switching scene tab
2015-11-17 13:46:08 +01:00
}
Fixed Tab Switching of Main Scene State. Closes #11045
2017-09-08 23:45:04 +02:00
}
-Merged Script and Help tabs -Help tabs can be opened many at the same time -Color temperatures for opened scripts -Dominant script opening when switching scene tab
2015-11-17 13:46:08 +01:00
Fixed Tab Switching of Main Scene State. Closes #11045
2017-09-08 23:45:04 +02:00
if (p_state.has("editor_index")) {
int index = p_state["editor_index"];
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-09-29 11:53:28 +02:00
if (current_tab < 2) { // If currently in spatial/2d, only switch to spatial/2d. If currently in script, stay there.
Improve guessing of what editor to switch to, fixes #10405
2017-09-04 23:00:09 +02:00
if (index < 2 || !get_edited_scene()) {
Port remaining connections to callable_mp
2020-12-06 16:09:18 +01:00
editor_select(index);
Fixed Tab Switching of Main Scene State. Closes #11045
2017-09-08 23:45:04 +02:00
}
}
}
if (get_edited_scene()) {
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-09-29 11:53:28 +02:00
if (current_tab < 2) {
Use selected node type for choosing editor tab Use selected node type for choosing editor tab Update editor/editor_node.cpp Co-authored-by: Tomek <kobewi4e@gmail.com>
2023-01-22 03:27:04 +01:00
Node *editor_node = SceneTreeDock::get_singleton()->get_tree_editor()->get_selected();
editor_node = editor_node == nullptr ? get_edited_scene() : editor_node;
Check for CanvasItem instead of Control and Node2D
2023-02-11 09:18:10 +01:00
if (Object::cast_to<CanvasItem>(editor_node)) {
Port remaining connections to callable_mp
2020-12-06 16:09:18 +01:00
editor_select(EDITOR_2D);
Use selected node type for choosing editor tab Use selected node type for choosing editor tab Update editor/editor_node.cpp Co-authored-by: Tomek <kobewi4e@gmail.com>
2023-01-22 03:27:04 +01:00
} else if (Object::cast_to<Node3D>(editor_node)) {
Port remaining connections to callable_mp
2020-12-06 16:09:18 +01:00
editor_select(EDITOR_3D);
-Merged Script and Help tabs -Help tabs can be opened many at the same time -Color temperatures for opened scripts -Dominant script opening when switching scene tab
2015-11-17 13:46:08 +01:00
}
}
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (p_state.has("scene_tree_offset")) {
Store panels and docks singletons in their own classes
2021-11-17 21:08:55 +01:00
SceneTreeDock::get_singleton()->get_tree_editor()->get_scene_tree()->get_vscroll_bar()->set_value(p_state["scene_tree_offset"]);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
if (p_state.has("property_edit_offset")) {
Store panels and docks singletons in their own classes
2021-11-17 21:08:55 +01:00
InspectorDock::get_inspector_singleton()->set_scroll_offset(p_state["property_edit_offset"]);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (p_state.has("node_filter")) {
Store panels and docks singletons in their own classes
2021-11-17 21:08:55 +01:00
SceneTreeDock::get_singleton()->set_filter(p_state["node_filter"]);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// This should only happen at the very end.
-Merged Script and Help tabs -Help tabs can be opened many at the same time -Color temperatures for opened scripts -Dominant script opening when switching scene tab
2015-11-17 13:46:08 +01:00
Huge Debugger/EditorDebugger refactor.
2020-02-07 02:52:05 +01:00
EditorDebuggerNode::get_singleton()->update_live_edit_root();
-Merged Script and Help tabs -Help tabs can be opened many at the same time -Color temperatures for opened scripts -Dominant script opening when switching scene tab
2015-11-17 13:46:08 +01:00
ScriptEditor::get_singleton()->set_scene_root_script(editor_data.get_scene_root_script(editor_data.get_edited_scene()));
-ability to change scripts in external editor and still have properties reloaded in godot UI, fixes #3003
2015-12-09 13:08:41 +01:00
editor_data.notify_edited_scene_changed();
Add history dock
2022-08-27 13:52:06 +02:00
emit_signal(SNAME("scene_changed"));
Reset SDFGI when changing editor scene tabs
2023-08-30 15:25:27 +02:00
// Reset SDFGI after everything else so that any last-second scene modifications will be processed.
RenderingServer::get_singleton()->sdfgi_reset();
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
}
bool EditorNode::is_changing_scene() const {
return changing_scene;
}
-scenes are properly reloaded when a dependency changes, fixes #2896 (it's clevery done so local changes to scenes are kept even if unsaved)
2015-12-14 00:39:01 +01:00
Extract editor scene tabs into their own component
2023-08-24 12:24:29 +02:00
void EditorNode::_set_current_scene(int p_idx) {
if (p_idx == editor_data.get_edited_scene()) {
return; // Pointless.
}
_set_current_scene_nocheck(p_idx);
}
void EditorNode::_set_current_scene_nocheck(int p_idx) {
Rename `Tabs` to `TabBar`
2021-10-17 18:55:44 +02:00
// Save the folding in case the scene gets reloaded.
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (editor_data.get_scene_path(p_idx) != "" && editor_data.get_edited_scene_root(p_idx)) {
Preserve folding when sub-scene is changed
2019-09-10 14:43:46 +02:00
editor_folding.save_scene_folding(editor_data.get_edited_scene_root(p_idx), editor_data.get_scene_path(p_idx));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Preserve folding when sub-scene is changed
2019-09-10 14:43:46 +02:00
-scenes are properly reloaded when a dependency changes, fixes #2896 (it's clevery done so local changes to scenes are kept even if unsaved)
2015-12-14 00:39:01 +01:00
if (editor_data.check_and_update_scene(p_idx)) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (editor_data.get_scene_path(p_idx) != "") {
Preserve folding when sub-scene is changed
2019-09-10 14:43:46 +02:00
editor_folding.load_scene_folding(editor_data.get_edited_scene_root(p_idx), editor_data.get_scene_path(p_idx));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Preserve folding when sub-scene is changed
2019-09-10 14:43:46 +02:00
Add EditorUndoRedoManager singleton
2022-12-23 23:53:16 +01:00
EditorUndoRedoManager::get_singleton()->clear_history(false, editor_data.get_scene_history_id(p_idx));
-scenes are properly reloaded when a dependency changes, fixes #2896 (it's clevery done so local changes to scenes are kept even if unsaved)
2015-12-14 00:39:01 +01:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
changing_scene = true;
editor_data.save_edited_scene_state(editor_selection, &editor_history, _get_main_scene_state());
if (get_editor_data().get_edited_scene_root()) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (get_editor_data().get_edited_scene_root()->get_parent() == scene_root) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
scene_root->remove_child(get_editor_data().get_edited_scene_root());
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
}
editor_selection->clear();
editor_data.set_edited_scene(p_idx);
Node *new_scene = editor_data.get_edited_scene_root();
Add per-scene UndoRedo
2022-03-25 18:06:46 +01:00
if (Popup *p = Object::cast_to<Popup>(new_scene)) {
p->show();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
Store panels and docks singletons in their own classes
2021-11-17 21:08:55 +01:00
SceneTreeDock::get_singleton()->set_edited_scene(new_scene);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (get_tree()) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
get_tree()->set_edited_scene_root(new_scene);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
if (new_scene) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (new_scene->get_parent() != scene_root) {
Remove node_hrcr hack
2021-10-21 16:46:07 +02:00
scene_root->add_child(new_scene, true);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
}
Dictionary state = editor_data.restore_edited_scene_state(editor_selection, &editor_history);
Don't edit foreign resources when restoring scene
2021-09-12 21:17:34 +02:00
_edit_current(true);
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
update window title when switching scenes
2018-09-11 12:28:32 +02:00
_update_title();
Correctly free relevant scripts when closing scene tabs
2023-12-18 14:41:07 +01:00
callable_mp(scene_tabs, &EditorSceneTabs::update_scene_tabs).call_deferred();
update window title when switching scenes
2018-09-11 12:28:32 +02:00
Fix scene tab close
2023-07-27 07:38:40 +02:00
if (tabs_to_close.is_empty()) {
call_deferred(SNAME("_set_main_scene_state"), state, get_edited_scene()); // Do after everything else is done setting up.
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
}
Remove editor dependencies from ColorPicker
2022-10-11 14:57:20 +02:00
void EditorNode::setup_color_picker(ColorPicker *p_picker) {
p_picker->set_editor_settings(EditorSettings::get_singleton());
Remember last 'color_mode' and 'picker_shape' in 'ColorPicker's in the editor
2023-12-13 21:05:20 +01:00
int default_color_mode = EditorSettings::get_singleton()->get_project_metadata("color_picker", "color_mode", EDITOR_GET("interface/inspector/default_color_picker_mode"));
int picker_shape = EditorSettings::get_singleton()->get_project_metadata("color_picker", "picker_shape", EDITOR_GET("interface/inspector/default_color_picker_shape"));
Remove editor dependencies from ColorPicker
2022-10-11 14:57:20 +02:00
p_picker->set_color_mode((ColorPicker::ColorModeType)default_color_mode);
p_picker->set_picker_shape((ColorPicker::PickerShapeType)picker_shape);
Color Pickers Respect Settings Updated editor_node with function that sets up color pickers throughout Godot to respect editor's settings.
2022-07-01 05:43:46 +02:00
}
**WARNING BEFORE PULLING** This push changes the binary and XML formats and bumps the major version to 2.0. As such, files saved in this version WILL NO LONGER WORK IN PREVIOUS VERSIONS. This compatibility breakage with older versions was required in order to properly provide project refactoring tools. If I were you, unless you are brave, I would wait a week or two before pulling, in case of bugs :) Summary of Changes -New Filesystem dock, with filesystem & tree view modes. -New refactoring tools, to change or fix dependencies. -Quick search dialog, to quickly search any file
2015-08-24 01:15:56 +02:00
bool EditorNode::is_scene_open(const String &p_path) {
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (editor_data.get_scene_path(i) == p_path) {
**WARNING BEFORE PULLING** This push changes the binary and XML formats and bumps the major version to 2.0. As such, files saved in this version WILL NO LONGER WORK IN PREVIOUS VERSIONS. This compatibility breakage with older versions was required in order to properly provide project refactoring tools. If I were you, unless you are brave, I would wait a week or two before pulling, in case of bugs :) Summary of Changes -New Filesystem dock, with filesystem & tree view modes. -New refactoring tools, to change or fix dependencies. -Quick search dialog, to quickly search any file
2015-08-24 01:15:56 +02:00
return true;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
**WARNING BEFORE PULLING** This push changes the binary and XML formats and bumps the major version to 2.0. As such, files saved in this version WILL NO LONGER WORK IN PREVIOUS VERSIONS. This compatibility breakage with older versions was required in order to properly provide project refactoring tools. If I were you, unless you are brave, I would wait a week or two before pulling, in case of bugs :) Summary of Changes -New Filesystem dock, with filesystem & tree view modes. -New refactoring tools, to change or fix dependencies. -Quick search dialog, to quickly search any file
2015-08-24 01:15:56 +02:00
}
return false;
}
void EditorNode::fix_dependencies(const String &p_for_file) {
dependency_fixer->edit(p_for_file);
}
Allow to create scene from FileSystem dock
2019-08-15 19:47:21 +02:00
int EditorNode::new_scene() {
int idx = editor_data.add_edited_scene(-1);
Fix saving wrong edited scene state when switching scene tabs When creating a new scene, the scene tab will actually switch to the newly created one. Also worth noting that switching scene tabs saves state (by `save_edited_scene_state`). When trying New Scene again, the previously empty scene tab will be removed. So the correct logic is: switch the tab save state first, and then remove the previous empty scene tab. To prevent `current_edited_scene` from being incorrect when saving state.
2023-10-13 10:38:33 +02:00
_set_current_scene(idx); // Before trying to remove an empty scene, set the current tab index to the newly added tab index.
Added a placeholder tab check before creating a new scene.
2022-08-27 21:41:48 +02:00
// Remove placeholder empty scene.
if (editor_data.get_edited_scene_count() > 1) {
for (int i = 0; i < editor_data.get_edited_scene_count() - 1; i++) {
Add EditorUndoRedoManager singleton
2022-12-23 23:53:16 +01:00
bool unsaved = EditorUndoRedoManager::get_singleton()->is_history_unsaved(editor_data.get_scene_history_id(i));
Prevent unsaved inherited scenes from being detected as the 'placeholder' scene
2022-09-16 02:09:54 +02:00
if (!unsaved && editor_data.get_scene_path(i).is_empty() && editor_data.get_edited_scene_root(i) == nullptr) {
Added a placeholder tab check before creating a new scene.
2022-08-27 21:41:48 +02:00
editor_data.remove_scene(i);
idx--;
}
}
}
Allow to create scene from FileSystem dock
2019-08-15 19:47:21 +02:00
editor_data.clear_editor_states();
Extract editor scene tabs into their own component
2023-08-24 12:24:29 +02:00
scene_tabs->update_scene_tabs();
Allow to create scene from FileSystem dock
2019-08-15 19:47:21 +02:00
return idx;
}
Detect external modification of scenes
2019-08-28 19:42:27 +02:00
Error EditorNode::load_scene(const String &p_scene, bool p_ignore_broken_deps, bool p_set_inherited, bool p_clear_errors, bool p_force_open_imported, bool p_silent_change_tab) {
SceneMainLoop -> SceneTree -=-=-=-=-=-=-=-=-=-=-=-=-=- *YOUR SOURCE MIGHT NOT WORK* For mor information on fix: https://github.com/okamstudio/godot/wiki/devel_scene_tree Other stuff: -Shower of bullets demo -Fixes all around
2014-11-06 01:20:42 +01:00
if (!is_inside_tree()) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
defer_load_scene = p_scene;
return OK;
}
You can create an inherited scene based on an already opened scene.
2016-01-02 23:42:41 +01:00
if (!p_set_inherited) {
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
if (editor_data.get_scene_path(i) == p_scene) {
Extract editor scene tabs into their own component
2023-08-24 12:24:29 +02:00
_set_current_scene(i);
You can create an inherited scene based on an already opened scene.
2016-01-02 23:42:41 +01:00
return OK;
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
}
completed scene importing (I hope?)
2017-02-05 00:31:15 +01:00
if (!p_force_open_imported && FileAccess::exists(p_scene + ".import")) {
open_imported->set_text(vformat(TTR("Scene '%s' was automatically imported, so it can't be modified.\nTo make changes to it, a new inherited scene can be created."), p_scene.get_file()));
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
open_imported->popup_centered();
completed scene importing (I hope?)
2017-02-05 00:31:15 +01:00
new_inherited_button->grab_focus();
open_import_request = p_scene;
return OK;
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (p_clear_errors) {
Fix error reporting when a scene is not imported properly, closes #3968
2016-06-26 20:37:04 +02:00
load_errors->clear();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Fix error reporting when a scene is not imported properly, closes #3968
2016-06-26 20:37:04 +02:00
-Renamed GlobalConfig to ProjectSettings, makes more sense. -Added system for feature overrides, it's pretty cool :)
2017-07-19 22:00:46 +02:00
String lpath = ProjectSettings::get_singleton()->localize_path(p_scene);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (!lpath.begins_with("res://")) {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 16:47:41 +02:00
show_accept(TTR("Error loading scene, it must be inside the project path. Use 'Import' to open the scene, then save it inside the project path."), TTR("OK"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
opening_prev = false;
return ERR_FILE_NOT_FOUND;
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
int prev = editor_data.get_edited_scene();
int idx = editor_data.add_edited_scene(-1);
if (!editor_data.get_edited_scene_root() && editor_data.get_edited_scene_count() == 2) {
_remove_edited_scene();
Extract editor scene tabs into their own component
2023-08-24 12:24:29 +02:00
} else if (p_silent_change_tab) {
_set_current_scene_nocheck(idx);
Detect external modification of scenes
2019-08-28 19:42:27 +02:00
} else {
Extract editor scene tabs into their own component
2023-08-24 12:24:29 +02:00
_set_current_scene(idx);
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
}
**WARNING BEFORE PULLING** This push changes the binary and XML formats and bumps the major version to 2.0. As such, files saved in this version WILL NO LONGER WORK IN PREVIOUS VERSIONS. This compatibility breakage with older versions was required in order to properly provide project refactoring tools. If I were you, unless you are brave, I would wait a week or two before pulling, in case of bugs :) Summary of Changes -New Filesystem dock, with filesystem & tree view modes. -New refactoring tools, to change or fix dependencies. -Quick search dialog, to quickly search any file
2015-08-24 01:15:56 +02:00
dependency_errors.clear();
EditorNode: enhance open scene error dialog
2017-08-28 05:24:50 +02:00
Error err;
Improve resource load cache -Added a new method in Resource: reset_state , used for reloading the same resource from disk -Added a new cache mode "replace" in ResourceLoader, which reuses existing loaded sub-resources but resets their data from disk (or replaces them if they chaged type) -Because the correct sub-resource paths are always loaded now, this fixes bugs with subresource folding or subresource ordering when saving.
2021-02-11 18:18:45 +01:00
Ref<PackedScene> sdata = ResourceLoader::load(lpath, "", ResourceFormatLoader::CACHE_MODE_REPLACE, &err);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
**WARNING BEFORE PULLING** This push changes the binary and XML formats and bumps the major version to 2.0. As such, files saved in this version WILL NO LONGER WORK IN PREVIOUS VERSIONS. This compatibility breakage with older versions was required in order to properly provide project refactoring tools. If I were you, unless you are brave, I would wait a week or two before pulling, in case of bugs :) Summary of Changes -New Filesystem dock, with filesystem & tree view modes. -New refactoring tools, to change or fix dependencies. -Quick search dialog, to quickly search any file
2015-08-24 01:15:56 +02:00
if (!p_ignore_broken_deps && dependency_errors.has(lpath)) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
current_menu_option = -1;
**WARNING BEFORE PULLING** This push changes the binary and XML formats and bumps the major version to 2.0. As such, files saved in this version WILL NO LONGER WORK IN PREVIOUS VERSIONS. This compatibility breakage with older versions was required in order to properly provide project refactoring tools. If I were you, unless you are brave, I would wait a week or two before pulling, in case of bugs :) Summary of Changes -New Filesystem dock, with filesystem & tree view modes. -New refactoring tools, to change or fix dependencies. -Quick search dialog, to quickly search any file
2015-08-24 01:15:56 +02:00
Vector<String> errors;
Use range iterators for RBSet in most cases
2022-05-19 01:43:40 +02:00
for (const String &E : dependency_errors[lpath]) {
errors.push_back(E);
**WARNING BEFORE PULLING** This push changes the binary and XML formats and bumps the major version to 2.0. As such, files saved in this version WILL NO LONGER WORK IN PREVIOUS VERSIONS. This compatibility breakage with older versions was required in order to properly provide project refactoring tools. If I were you, unless you are brave, I would wait a week or two before pulling, in case of bugs :) Summary of Changes -New Filesystem dock, with filesystem & tree view modes. -New refactoring tools, to change or fix dependencies. -Quick search dialog, to quickly search any file
2015-08-24 01:15:56 +02:00
}
Let user fix dependencies in resources
2018-11-02 04:44:40 +01:00
dependency_error->show(DependencyErrorDialog::MODE_SCENE, lpath, errors);
**WARNING BEFORE PULLING** This push changes the binary and XML formats and bumps the major version to 2.0. As such, files saved in this version WILL NO LONGER WORK IN PREVIOUS VERSIONS. This compatibility breakage with older versions was required in order to properly provide project refactoring tools. If I were you, unless you are brave, I would wait a week or two before pulling, in case of bugs :) Summary of Changes -New Filesystem dock, with filesystem & tree view modes. -New refactoring tools, to change or fix dependencies. -Quick search dialog, to quickly search any file
2015-08-24 01:15:56 +02:00
opening_prev = false;
if (prev != -1) {
Extract editor scene tabs into their own component
2023-08-24 12:24:29 +02:00
_set_current_scene(prev);
**WARNING BEFORE PULLING** This push changes the binary and XML formats and bumps the major version to 2.0. As such, files saved in this version WILL NO LONGER WORK IN PREVIOUS VERSIONS. This compatibility breakage with older versions was required in order to properly provide project refactoring tools. If I were you, unless you are brave, I would wait a week or two before pulling, in case of bugs :) Summary of Changes -New Filesystem dock, with filesystem & tree view modes. -New refactoring tools, to change or fix dependencies. -Quick search dialog, to quickly search any file
2015-08-24 01:15:56 +02:00
editor_data.remove_scene(idx);
}
return ERR_FILE_MISSING_DEPENDENCIES;
}
Fix dependency menu not showing up if scene failed to load.
2023-10-09 04:15:46 +02:00
if (!sdata.is_valid()) {
_dialog_display_load_error(lpath, err);
opening_prev = false;
if (prev != -1) {
_set_current_scene(prev);
editor_data.remove_scene(idx);
}
return ERR_FILE_NOT_FOUND;
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
dependency_errors.erase(lpath); // At least not self path.
**WARNING BEFORE PULLING** This push changes the binary and XML formats and bumps the major version to 2.0. As such, files saved in this version WILL NO LONGER WORK IN PREVIOUS VERSIONS. This compatibility breakage with older versions was required in order to properly provide project refactoring tools. If I were you, unless you are brave, I would wait a week or two before pulling, in case of bugs :) Summary of Changes -New Filesystem dock, with filesystem & tree view modes. -New refactoring tools, to change or fix dependencies. -Quick search dialog, to quickly search any file
2015-08-24 01:15:56 +02:00
Add a new HashSet template * Intended to replace RBSet in most cases. * Optimized for iteration speed
2022-05-19 17:00:06 +02:00
for (KeyValue<String, HashSet<String>> &E : dependency_errors) {
Use range iterators for `Map`
2021-08-09 22:13:42 +02:00
String txt = vformat(TTR("Scene '%s' has broken dependencies:"), E.key) + "\n";
Use range iterators for RBSet in most cases
2022-05-19 01:43:40 +02:00
for (const String &F : E.value) {
txt += "\t" + F + "\n";
**WARNING BEFORE PULLING** This push changes the binary and XML formats and bumps the major version to 2.0. As such, files saved in this version WILL NO LONGER WORK IN PREVIOUS VERSIONS. This compatibility breakage with older versions was required in order to properly provide project refactoring tools. If I were you, unless you are brave, I would wait a week or two before pulling, in case of bugs :) Summary of Changes -New Filesystem dock, with filesystem & tree view modes. -New refactoring tools, to change or fix dependencies. -Quick search dialog, to quickly search any file
2015-08-24 01:15:56 +02:00
}
add_io_error(txt);
}
-Make sure scenes properly update when switching tabs, even if sub-instances changed. Fixes #3201
2016-01-14 15:06:20 +01:00
if (ResourceCache::has(lpath)) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Used from somewhere else? No problem! Update state and replace sdata.
Remake resource thread safety and API * Ensures thread safety when resources are destroyed. * Simplified API by always forcing `ResourceCache::get_ref`, which needs less hacks and is fully thread safe. * Removed RWLock for resources because its not possible to use for the new logic. Should not be a problem. Supersedes #57533
2022-06-22 13:46:46 +02:00
Ref<PackedScene> ps = ResourceCache::get_ref(lpath);
-Make sure scenes properly update when switching tabs, even if sub-instances changed. Fixes #3201
2016-01-14 15:06:20 +01:00
if (ps.is_valid()) {
ps->replace_state(sdata->get_state());
ps->set_last_modified_time(sdata->get_last_modified_time());
sdata = ps;
}
} else {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
sdata->set_path(lpath, true); // Take over path.
-Make sure scenes properly update when switching tabs, even if sub-instances changed. Fixes #3201
2016-01-14 15:06:20 +01:00
}
improved get_node(), connect(), etc code completion. -properly completes text arguments -includes the "/root" autoloads
2015-06-26 06:14:31 +02:00
Add property value pinning
2021-10-26 21:12:25 +02:00
Node *new_scene = sdata->instantiate(p_set_inherited ? PackedScene::GEN_EDIT_STATE_MAIN_INHERITED : PackedScene::GEN_EDIT_STATE_MAIN);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (!new_scene) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
sdata.unref();
PackedScene: Prevent crash when root node has `parent` attribute The crash happens further down when setting an invalid owner in `Node::_set_owner_nocheck` but I couldn't figure out how to fix it. But here the proper fix is to catch the invalid scene file early on and fail loading it. Part of #17372.
2020-06-08 13:05:09 +02:00
_dialog_display_load_error(lpath, ERR_FILE_CORRUPT);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
opening_prev = false;
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
if (prev != -1) {
Extract editor scene tabs into their own component
2023-08-24 12:24:29 +02:00
_set_current_scene(prev);
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
editor_data.remove_scene(idx);
}
PackedScene: Prevent crash when root node has `parent` attribute The crash happens further down when setting an invalid owner in `Node::_set_owner_nocheck` but I couldn't figure out how to fix it. But here the proper fix is to catch the invalid scene file early on and fail loading it. Part of #17372.
2020-06-08 13:05:09 +02:00
return ERR_FILE_CORRUPT;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Large improvements on scene packing and management -Ability to edit and keep changes of instanced scenes and sub-scenes -Ability to inherit from other scenes
2015-10-10 14:09:09 +02:00
if (p_set_inherited) {
Ref<SceneState> state = sdata->get_state();
remove trailing whitespace
2016-03-09 00:00:52 +01:00
state->set_path(lpath);
Large improvements on scene packing and management -Ability to edit and keep changes of instanced scenes and sub-scenes -Ability to inherit from other scenes
2015-10-10 14:09:09 +02:00
new_scene->set_scene_inherited_state(state);
Fix path for unsaved inherited scenes.
2023-01-25 04:06:59 +01:00
new_scene->set_scene_file_path(String());
Large improvements on scene packing and management -Ability to edit and keep changes of instanced scenes and sub-scenes -Ability to inherit from other scenes
2015-10-10 14:09:09 +02:00
}
-Fixed bug with scene inheritance, should work again -Proper .tscn and .tres parsing, should work, please test well!
2015-11-29 00:56:14 +01:00
new_scene->set_scene_instance_state(Ref<SceneState>());
Large improvements on scene packing and management -Ability to edit and keep changes of instanced scenes and sub-scenes -Ability to inherit from other scenes
2015-10-10 14:09:09 +02:00
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
set_edited_scene(new_scene);
Improve editor state persistence
2023-05-11 04:17:03 +02:00
String config_file_path = EditorPaths::get_singleton()->get_project_settings_dir().path_join(p_scene.get_file() + "-editstate-" + p_scene.md5_text() + ".cfg");
Ref<ConfigFile> editor_state_cf;
editor_state_cf.instantiate();
Error editor_state_cf_err = editor_state_cf->load(config_file_path);
if (editor_state_cf_err == OK || editor_state_cf->has_section("editor_states")) {
_load_editor_plugin_states_from_config(editor_state_cf);
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
_update_title();
Extract editor scene tabs into their own component
2023-08-24 12:24:29 +02:00
scene_tabs->update_scene_tabs();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
_add_to_recent_scenes(lpath);
Rewrite code for unfolding and make it automatic on scene load, which works better.
2018-11-25 14:46:26 +01:00
if (editor_folding.has_folding_data(lpath)) {
editor_folding.load_scene_folding(new_scene, lpath);
} else if (EDITOR_GET("interface/inspector/auto_unfold_foreign_scenes")) {
editor_folding.unfold_scene(new_scene);
editor_folding.save_scene_folding(new_scene, lpath);
}
Moved folding outside the resource files, now saved outside the project.
2018-10-29 20:36:31 +01:00
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
opening_prev = false;
Huge Debugger/EditorDebugger refactor.
2020-02-07 02:52:05 +01:00
EditorDebuggerNode::get_singleton()->update_live_edit_root();
Live edit WORK IN PROGRESS 1) press the heart while the game is running 2) select a scene to live edit from the opened scenes 3) edit/add/remove nodes or resources, change their properties, etc. 4) watch changes reflected in running game, in all places this scene is edited 5) It's not perfect obviously, but the aim of it is to try to reflect your changes as best as possible in the running game.
2015-08-02 17:29:37 +02:00
Avoid unnecessary inspector updates when loading or switching scenes This should result in some noticeable performance improvements, aside from fixing bugs due to conflicts in logic. This also simplifies some related code identified while debugging.
2023-08-11 15:55:47 +02:00
// Tell everything to edit this object, unless we're in the process of restoring scenes.
// If we are, we'll edit it after the restoration is done.
if (!restoring_scenes) {
push_item(new_scene);
Fix saving wrong edited scene state when switching scene tabs When creating a new scene, the scene tab will actually switch to the newly created one. Also worth noting that switching scene tabs saves state (by `save_edited_scene_state`). When trying New Scene again, the previously empty scene tab will be removed. So the correct logic is: switch the tab save state first, and then remove the previous empty scene tab. To prevent `current_edited_scene` from being incorrect when saving state.
2023-10-13 10:38:33 +02:00
} else {
// Initialize history for restored scenes.
ObjectID id = new_scene->get_instance_id();
if (id != editor_history.get_current()) {
editor_history.add_object(id);
}
Avoid unnecessary inspector updates when loading or switching scenes This should result in some noticeable performance improvements, aside from fixing bugs due to conflicts in logic. This also simplifies some related code identified while debugging.
2023-08-11 15:55:47 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Improve editor state persistence
2023-05-11 04:17:03 +02:00
// Load the selected nodes.
if (editor_state_cf->has_section_key("editor_states", "selected_nodes")) {
TypedArray<NodePath> selected_node_list = editor_state_cf->get_value("editor_states", "selected_nodes", TypedArray<String>());
for (int i = 0; i < selected_node_list.size(); i++) {
Node *selected_node = new_scene->get_node_or_null(selected_node_list[i]);
if (selected_node) {
editor_selection->add_node(selected_node);
}
}
}
Restore scenes on startup, issue 2385
2017-11-25 00:32:54 +01:00
if (!restoring_scenes) {
Improve editor state persistence
2023-05-11 04:17:03 +02:00
save_editor_layout_delayed();
Restore scenes on startup, issue 2385
2017-11-25 00:32:54 +01:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return OK;
}
Update instances of scenes which have been reimported.
2022-01-30 22:31:32 +01:00
HashMap<StringName, Variant> EditorNode::get_modified_properties_for_node(Node *p_node) {
HashMap<StringName, Variant> modified_property_map;
List<PropertyInfo> pinfo;
p_node->get_property_list(&pinfo);
for (const PropertyInfo &E : pinfo) {
if (E.usage & PROPERTY_USAGE_STORAGE) {
bool is_valid_revert = false;
Variant revert_value = EditorPropertyRevert::get_property_revert_value(p_node, E.name, &is_valid_revert);
Variant current_value = p_node->get(E.name);
if (is_valid_revert) {
if (PropertyUtils::is_property_value_different(current_value, revert_value)) {
modified_property_map[E.name] = current_value;
}
}
}
}
return modified_property_map;
}
Fix ownership bug on ancestor nodes when scene is reimported.
2023-02-22 19:07:36 +01:00
void EditorNode::update_ownership_table_for_addition_node_ancestors(Node *p_current_node, HashMap<Node *, Node *> &p_ownership_table) {
p_ownership_table.insert(p_current_node, p_current_node->get_owner());
for (int i = 0; i < p_current_node->get_child_count(); i++) {
Node *child = p_current_node->get_child(i);
update_ownership_table_for_addition_node_ancestors(child, p_ownership_table);
}
}
Update instances of scenes which have been reimported.
2022-01-30 22:31:32 +01:00
void EditorNode::update_diff_data_for_node(
Node *p_edited_scene,
Node *p_root,
Node *p_node,
HashMap<NodePath, ModificationNodeEntry> &p_modification_table,
List<AdditiveNodeEntry> &p_addition_list) {
bool node_part_of_subscene = p_node != p_edited_scene &&
p_edited_scene->get_scene_inherited_state().is_valid() &&
p_edited_scene->get_scene_inherited_state()->find_node_by_path(p_edited_scene->get_path_to(p_node)) >= 0;
// Loop through the owners until either we reach the root node or nullptr
Node *valid_node_owner = p_node->get_owner();
while (valid_node_owner) {
if (valid_node_owner == p_root) {
break;
}
valid_node_owner = valid_node_owner->get_owner();
}
if ((valid_node_owner == p_root && (p_root != p_edited_scene || !p_edited_scene->get_scene_file_path().is_empty())) || node_part_of_subscene || p_node == p_root) {
HashMap<StringName, Variant> modified_properties = get_modified_properties_for_node(p_node);
// Find all valid connections to other nodes.
List<Connection> connections_to;
p_node->get_all_signal_connections(&connections_to);
List<ConnectionWithNodePath> valid_connections_to;
for (const Connection &c : connections_to) {
Node *connection_target_node = Object::cast_to<Node>(c.callable.get_object());
if (connection_target_node) {
// TODO: add support for reinstating custom callables
if (!c.callable.is_custom()) {
ConnectionWithNodePath connection_to;
connection_to.connection = c;
connection_to.node_path = p_node->get_path_to(connection_target_node);
valid_connections_to.push_back(connection_to);
}
}
}
// Find all valid connections from other nodes.
List<Connection> connections_from;
p_node->get_signals_connected_to_this(&connections_from);
List<Connection> valid_connections_from;
for (const Connection &c : connections_from) {
Node *source_node = Object::cast_to<Node>(c.signal.get_object());
Node *valid_source_owner = nullptr;
if (source_node) {
valid_source_owner = source_node->get_owner();
while (valid_source_owner) {
if (valid_source_owner == p_root) {
break;
}
valid_source_owner = valid_source_owner->get_owner();
}
}
if (!source_node || valid_source_owner == nullptr) {
// TODO: add support for reinstating custom callables
if (!c.callable.is_custom()) {
valid_connections_from.push_back(c);
}
}
}
// Find all node groups.
List<Node::GroupInfo> groups;
p_node->get_groups(&groups);
if (!modified_properties.is_empty() || !valid_connections_to.is_empty() || !valid_connections_from.is_empty() || !groups.is_empty()) {
ModificationNodeEntry modification_node_entry;
modification_node_entry.property_table = modified_properties;
modification_node_entry.connections_to = valid_connections_to;
modification_node_entry.connections_from = valid_connections_from;
modification_node_entry.groups = groups;
p_modification_table[p_root->get_path_to(p_node)] = modification_node_entry;
}
} else {
AdditiveNodeEntry new_additive_node_entry;
new_additive_node_entry.node = p_node;
new_additive_node_entry.parent = p_root->get_path_to(p_node->get_parent());
new_additive_node_entry.owner = p_node->get_owner();
new_additive_node_entry.index = p_node->get_index();
Node2D *node_2d = Object::cast_to<Node2D>(p_node);
if (node_2d) {
new_additive_node_entry.transform_2d = node_2d->get_relative_transform_to_parent(node_2d->get_parent());
}
Node3D *node_3d = Object::cast_to<Node3D>(p_node);
if (node_3d) {
new_additive_node_entry.transform_3d = node_3d->get_relative_transform(node_3d->get_parent());
}
Fix ownership bug on ancestor nodes when scene is reimported.
2023-02-22 19:07:36 +01:00
// Gathers the ownership of all ancestor nodes for later use.
HashMap<Node *, Node *> ownership_table;
for (int i = 0; i < p_node->get_child_count(); i++) {
Node *child = p_node->get_child(i);
update_ownership_table_for_addition_node_ancestors(child, ownership_table);
}
new_additive_node_entry.ownership_table = ownership_table;
Update instances of scenes which have been reimported.
2022-01-30 22:31:32 +01:00
p_addition_list.push_back(new_additive_node_entry);
return;
}
for (int i = 0; i < p_node->get_child_count(); i++) {
Node *child = p_node->get_child(i);
update_diff_data_for_node(p_edited_scene, p_root, child, p_modification_table, p_addition_list);
}
}
//
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
void EditorNode::open_request(const String &p_path) {
Add Undo Close Tab option in tabs context menu
2019-04-10 17:21:26 +02:00
if (!opening_prev) {
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-09-29 11:53:28 +02:00
List<String>::Element *prev_scene_item = previous_scenes.find(p_path);
if (prev_scene_item != nullptr) {
prev_scene_item->erase();
Add Undo Close Tab option in tabs context menu
2019-04-10 17:21:26 +02:00
}
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
load_scene(p_path); // As it will be opened in separate tab.
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Extract editor scene tabs into their own component
2023-08-24 12:24:29 +02:00
bool EditorNode::has_previous_scenes() const {
return !previous_scenes.is_empty();
}
Remove `RES` and `REF` typedefs in favor of spelled out `Ref<>` These typedefs don't save much typing compared to the full `Ref<Resource>` and `Ref<RefCounted>`, yet they sometimes introduce confusion among new contributors.
2022-05-03 01:43:50 +02:00
void EditorNode::edit_foreign_resource(Ref<Resource> p_resource) {
Switch scene when editing foreign resource
2022-03-25 01:17:30 +01:00
load_scene(p_resource->get_path().get_slice("::", 0));
InspectorDock::get_singleton()->call_deferred("edit_resource", p_resource);
}
In inspector, show 'edit' button instead of 'inspect' when resource is part of an editable scene.
2022-09-07 11:14:06 +02:00
bool EditorNode::is_resource_read_only(Ref<Resource> p_resource, bool p_foreign_resources_are_writable) {
Disable editing properties in foreign resources from imported scenes or objects returning true from a function named '_is_read_only' and disable resaving imported resources.
2022-04-29 08:06:48 +02:00
ERR_FAIL_COND_V(p_resource.is_null(), false);
String path = p_resource->get_path();
if (!path.is_resource_file()) {
// If the resource name contains '::', that means it is a subresource embedded in another resource.
int srpos = path.find("::");
if (srpos != -1) {
String base = path.substr(0, srpos);
// If the base resource is a packed scene, we treat it as read-only if it is not the currently edited scene.
if (ResourceLoader::get_resource_type(base) == "PackedScene") {
if (!get_tree()->get_edited_scene_root() || get_tree()->get_edited_scene_root()->get_scene_file_path() != base) {
In inspector, show 'edit' button instead of 'inspect' when resource is part of an editable scene.
2022-09-07 11:14:06 +02:00
// If we have not flagged foreign resources as writable or the base scene the resource is
// part was imported, it can be considered read-only.
if (!p_foreign_resources_are_writable || FileAccess::exists(base + ".import")) {
return true;
}
Disable editing properties in foreign resources from imported scenes or objects returning true from a function named '_is_read_only' and disable resaving imported resources.
2022-04-29 08:06:48 +02:00
}
} else {
// If a corresponding .import file exists for the base file, we assume it to be imported and should therefore treated as read-only.
if (FileAccess::exists(base + ".import")) {
return true;
}
}
}
Mesh instance UV2 unwrapping improvements: Enforce foreign resource modification rules. Add more helpful error handling for ArrayMesh unwrapping.
2023-10-17 14:55:47 +02:00
} else if (FileAccess::exists(path + ".import")) {
Disable editing properties in foreign resources from imported scenes or objects returning true from a function named '_is_read_only' and disable resaving imported resources.
2022-04-29 08:06:48 +02:00
// The resource is not a subresource, but if it has an .import file, it's imported so treat it as read only.
Mesh instance UV2 unwrapping improvements: Enforce foreign resource modification rules. Add more helpful error handling for ArrayMesh unwrapping.
2023-10-17 14:55:47 +02:00
return true;
Disable editing properties in foreign resources from imported scenes or objects returning true from a function named '_is_read_only' and disable resaving imported resources.
2022-04-29 08:06:48 +02:00
}
return false;
}
Remove more instances of 'instance' being used as a verb
2022-11-16 00:13:39 +01:00
void EditorNode::request_instantiate_scene(const String &p_path) {
Store panels and docks singletons in their own classes
2021-11-17 21:08:55 +01:00
SceneTreeDock::get_singleton()->instantiate(p_path);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
void EditorNode::request_instantiate_scenes(const Vector<String> &p_files) {
Store panels and docks singletons in their own classes
2021-11-17 21:08:55 +01:00
SceneTreeDock::get_singleton()->instantiate_scenes(p_files);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Make possible to create inherited scenes via the RMB menu in the FileSystem dock
2019-05-08 04:35:23 +02:00
void EditorNode::_inherit_request(String p_file) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
current_menu_option = FILE_NEW_INHERITED_SCENE;
Make possible to create inherited scenes via the RMB menu in the FileSystem dock
2019-05-08 04:35:23 +02:00
_dialog_action(p_file);
}
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
void EditorNode::_instantiate_request(const Vector<String> &p_files) {
request_instantiate_scenes(p_files);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
void EditorNode::_close_messages() {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
old_split_ofs = center_split->get_split_offset();
center_split->set_split_offset(0);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
void EditorNode::_show_messages() {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
center_split->set_split_offset(old_split_ofs);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
void EditorNode::_add_to_recent_scenes(const String &p_scene) {
Small changes to the "Recent Scenes" menu.
2018-01-09 13:42:45 +01:00
Array rc = EditorSettings::get_singleton()->get_project_metadata("recent_files", "scenes", Array());
Vectors: Use clear() and has(). Use clear() instead of resize(0). Use has() instead of "find(p_val) != -1".
2022-02-01 19:19:13 +01:00
if (rc.has(p_scene)) {
Small changes to the "Recent Scenes" menu.
2018-01-09 13:42:45 +01:00
rc.erase(p_scene);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Small changes to the "Recent Scenes" menu.
2018-01-09 13:42:45 +01:00
rc.push_front(p_scene);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (rc.size() > 10) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
rc.resize(10);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Small changes to the "Recent Scenes" menu.
2018-01-09 13:42:45 +01:00
EditorSettings::get_singleton()->set_project_metadata("recent_files", "scenes", rc);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
_update_recent_scenes();
}
void EditorNode::_open_recent_scene(int p_idx) {
Add an option to clear recent scenes in the 'Open Recent' submenu
2017-10-12 04:35:15 +02:00
if (p_idx == recent_scenes->get_item_count() - 1) {
Small changes to the "Recent Scenes" menu.
2018-01-09 13:42:45 +01:00
EditorSettings::get_singleton()->set_project_metadata("recent_files", "scenes", Array());
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 23:22:52 +02:00
call_deferred(SNAME("_update_recent_scenes"));
Add an option to clear recent scenes in the 'Open Recent' submenu
2017-10-12 04:35:15 +02:00
} else {
Small changes to the "Recent Scenes" menu.
2018-01-09 13:42:45 +01:00
Array rc = EditorSettings::get_singleton()->get_project_metadata("recent_files", "scenes", Array());
Add an option to clear recent scenes in the 'Open Recent' submenu
2017-10-12 04:35:15 +02:00
ERR_FAIL_INDEX(p_idx, rc.size());
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Small changes to the "Recent Scenes" menu.
2018-01-09 13:42:45 +01:00
if (load_scene(rc[p_idx]) != OK) {
Rename `remove()` to `remove_at()` when removing by index
2021-07-04 00:17:03 +02:00
rc.remove_at(p_idx);
Small changes to the "Recent Scenes" menu.
2018-01-09 13:42:45 +01:00
EditorSettings::get_singleton()->set_project_metadata("recent_files", "scenes", rc);
_update_recent_scenes();
}
Add an option to clear recent scenes in the 'Open Recent' submenu
2017-10-12 04:35:15 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
void EditorNode::_update_recent_scenes() {
Small changes to the "Recent Scenes" menu.
2018-01-09 13:42:45 +01:00
Array rc = EditorSettings::get_singleton()->get_project_metadata("recent_files", "scenes", Array());
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
recent_scenes->clear();
Add an option to clear recent scenes in the 'Open Recent' submenu
2017-10-12 04:35:15 +02:00
Small changes to the "Recent Scenes" menu.
2018-01-09 13:42:45 +01:00
String path;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
for (int i = 0; i < rc.size(); i++) {
Small changes to the "Recent Scenes" menu.
2018-01-09 13:42:45 +01:00
path = rc[i];
recent_scenes->add_item(path.replace("res://", ""), i);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Add an option to clear recent scenes in the 'Open Recent' submenu
2017-10-12 04:35:15 +02:00
recent_scenes->add_separator();
recent_scenes->add_shortcut(ED_SHORTCUT("editor/clear_recent", TTR("Clear Recent Scenes")));
Remove set_as_minsize()
2022-03-06 00:57:42 +01:00
recent_scenes->reset_size();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Quick open now can open multiple scenes and scripts
2016-01-08 12:27:34 +01:00
void EditorNode::_quick_opened() {
Vector<String> files = quick_open->get_selected_files();
Open scene selected from Quick Open dialog.
2020-06-29 01:04:28 +02:00
bool open_scene_dialog = quick_open->get_base_type() == "PackedScene";
Quick open now can open multiple scenes and scripts
2016-01-08 12:27:34 +01:00
for (int i = 0; i < files.size(); i++) {
String res_path = files[i];
Fix Quick Open not opening binary resources
2023-08-28 12:57:14 +02:00
if (open_scene_dialog || ClassDB::is_parent_class(ResourceLoader::get_resource_type(res_path), "PackedScene")) {
Quick open now can open multiple scenes and scripts
2016-01-08 12:27:34 +01:00
open_request(res_path);
} else {
load_resource(res_path);
}
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Extract editor run toolbar into its own component - Simplify and update its logic. - Simplify EditorScript. - Improve EditorNode and other relevant includes. - Fix scene-based path in the movie writer when reloading a scene.
2023-04-12 21:02:28 +02:00
void EditorNode::_project_run_started() {
if (bool(EDITOR_GET("run/output/always_clear_output_on_play"))) {
log->clear();
}
if (bool(EDITOR_GET("run/output/always_open_output_on_play"))) {
make_bottom_panel_item_visible(log);
}
}
void EditorNode::_project_run_stopped() {
if (!bool(EDITOR_GET("run/output/always_close_output_on_stop"))) {
return;
}
for (int i = 0; i < bottom_panel_items.size(); i++) {
if (bottom_panel_items[i].control == log) {
_bottom_panel_switch(false, i);
break;
}
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Huge Debugger/EditorDebugger refactor.
2020-02-07 02:52:05 +01:00
void EditorNode::notify_all_debug_sessions_exited() {
Extract editor run toolbar into its own component - Simplify and update its logic. - Simplify EditorScript. - Improve EditorNode and other relevant includes. - Fix scene-based path in the movie writer when reloading a scene.
2023-04-12 21:02:28 +02:00
project_run_bar->stop_playing();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
void EditorNode::add_io_error(const String &p_error) {
Enhance thread safety of loaders and importers
2023-01-19 13:45:04 +01:00
DEV_ASSERT(Thread::get_caller_id() == Thread::get_main_id());
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
singleton->load_errors->add_image(singleton->theme->get_icon(SNAME("Error"), EditorStringName(EditorIcons)));
Simplify ResourceLoader error callbacks
2023-01-17 14:26:16 +01:00
singleton->load_errors->add_text(p_error + "\n");
Expose dialog parent-and-popup logic to the API
2023-04-20 15:13:21 +02:00
EditorInterface::get_singleton()->popup_dialog_centered_ratio(singleton->load_error_dialog, 0.5);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Let editor workaround a case of inconsistency in compound scenes
2023-06-07 13:44:37 +02:00
void EditorNode::add_io_warning(const String &p_warning) {
DEV_ASSERT(Thread::get_caller_id() == Thread::get_main_id());
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
singleton->load_errors->add_image(singleton->theme->get_icon(SNAME("Warning"), EditorStringName(EditorIcons)));
Let editor workaround a case of inconsistency in compound scenes
2023-06-07 13:44:37 +02:00
singleton->load_errors->add_text(p_warning + "\n");
EditorInterface::get_singleton()->popup_dialog_centered_ratio(singleton->load_error_dialog, 0.5);
}
Import 3D Scene Improvements -=-=-=-=-=-=-=-=-=-=-=-=-=-=- -If re-importing from the "dependency changed" dialog, edited scene will keep the local changes. -Imported scene will keep track of changes in the source asset -Geometry changes in source geometry or nodes with a different transform will be updated. -Materials will be kept if changed locally. -New nodes added will be kept -If nodes were reparented or renamed, they will still keep track -Deleted notes will be restored, use the -noimp option to avoid this. -In general, you can trust that if you do local modifications to the imported scene, they will not be erased after re-import. -Erasing your changes is done by re-importing from the "Re-Import" menu, re-opening the "Import 3D Scene" dialog. This wil re-import fresh. Overall, This should allow you to work on a scene and see changes made to 3D assets in real-time. So Please test!!
2014-06-19 07:23:03 +02:00
bool EditorNode::_find_scene_in_use(Node *p_node, const String &p_path) const {
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 16:30:55 +02:00
if (p_node->get_scene_file_path() == p_path) {
Import 3D Scene Improvements -=-=-=-=-=-=-=-=-=-=-=-=-=-=- -If re-importing from the "dependency changed" dialog, edited scene will keep the local changes. -Imported scene will keep track of changes in the source asset -Geometry changes in source geometry or nodes with a different transform will be updated. -Materials will be kept if changed locally. -New nodes added will be kept -If nodes were reparented or renamed, they will still keep track -Deleted notes will be restored, use the -noimp option to avoid this. -In general, you can trust that if you do local modifications to the imported scene, they will not be erased after re-import. -Erasing your changes is done by re-importing from the "Re-Import" menu, re-opening the "Import 3D Scene" dialog. This wil re-import fresh. Overall, This should allow you to work on a scene and see changes made to 3D assets in real-time. So Please test!!
2014-06-19 07:23:03 +02:00
return true;
}
for (int i = 0; i < p_node->get_child_count(); i++) {
if (_find_scene_in_use(p_node->get_child(i), p_path)) {
return true;
}
}
return false;
}
bool EditorNode::is_scene_in_use(const String &p_path) {
Node *es = get_edited_scene();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (es) {
Import 3D Scene Improvements -=-=-=-=-=-=-=-=-=-=-=-=-=-=- -If re-importing from the "dependency changed" dialog, edited scene will keep the local changes. -Imported scene will keep track of changes in the source asset -Geometry changes in source geometry or nodes with a different transform will be updated. -Materials will be kept if changed locally. -New nodes added will be kept -If nodes were reparented or renamed, they will still keep track -Deleted notes will be restored, use the -noimp option to avoid this. -In general, you can trust that if you do local modifications to the imported scene, they will not be erased after re-import. -Erasing your changes is done by re-importing from the "Re-Import" menu, re-opening the "Import 3D Scene" dialog. This wil re-import fresh. Overall, This should allow you to work on a scene and see changes made to 3D assets in real-time. So Please test!!
2014-06-19 07:23:03 +02:00
return _find_scene_in_use(es, p_path);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Import 3D Scene Improvements -=-=-=-=-=-=-=-=-=-=-=-=-=-=- -If re-importing from the "dependency changed" dialog, edited scene will keep the local changes. -Imported scene will keep track of changes in the source asset -Geometry changes in source geometry or nodes with a different transform will be updated. -Materials will be kept if changed locally. -New nodes added will be kept -If nodes were reparented or renamed, they will still keep track -Deleted notes will be restored, use the -noimp option to avoid this. -In general, you can trust that if you do local modifications to the imported scene, they will not be erased after re-import. -Erasing your changes is done by re-importing from the "Re-Import" menu, re-opening the "Import 3D Scene" dialog. This wil re-import fresh. Overall, This should allow you to work on a scene and see changes made to 3D assets in real-time. So Please test!!
2014-06-19 07:23:03 +02:00
return false;
}
Extract editor run toolbar into its own component - Simplify and update its logic. - Simplify EditorScript. - Improve EditorNode and other relevant includes. - Fix scene-based path in the movie writer when reloading a scene.
2023-04-12 21:02:28 +02:00
OS::ProcessID EditorNode::has_child_process(OS::ProcessID p_pid) const {
return project_run_bar->has_child_process(p_pid);
}
Huge Debugger/EditorDebugger refactor.
2020-02-07 02:52:05 +01:00
void EditorNode::stop_child_process(OS::ProcessID p_pid) {
Extract editor run toolbar into its own component - Simplify and update its logic. - Simplify EditorScript. - Improve EditorNode and other relevant includes. - Fix scene-based path in the movie writer when reloading a scene.
2023-04-12 21:02:28 +02:00
project_run_bar->stop_child_process(p_pid);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 21:21:30 +02:00
Ref<Script> EditorNode::get_object_custom_type_base(const Object *p_object) const {
[Editor] Replace `ERR_FAIL_COND` with `ERR_FAIL_NULL` where applicable
2023-09-09 17:24:40 +02:00
ERR_FAIL_NULL_V(p_object, nullptr);
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 21:21:30 +02:00
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-09-29 11:53:28 +02:00
Ref<Script> scr = p_object->get_script();
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 21:21:30 +02:00
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-09-29 11:53:28 +02:00
if (scr.is_valid()) {
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 21:21:30 +02:00
// Uncommenting would break things! Consider adding a parameter if you need it.
// StringName name = EditorNode::get_editor_data().script_class_get_name(base_script->get_path());
Style: Cleanup single-line blocks, semicolons, dead code Remove currently unused implementation of TextureBasisU, could be re-added later on if needed and ported.
2022-02-16 13:56:32 +01:00
// if (name != StringName()) {
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 21:21:30 +02:00
// return name;
Style: Cleanup single-line blocks, semicolons, dead code Remove currently unused implementation of TextureBasisU, could be re-added later on if needed and ported.
2022-02-16 13:56:32 +01:00
// }
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 21:21:30 +02:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// TODO: Should probably be deprecated in 4.x
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-09-29 11:53:28 +02:00
StringName base = scr->get_instance_base_type();
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 21:21:30 +02:00
if (base != StringName() && EditorNode::get_editor_data().get_custom_types().has(base)) {
const Vector<EditorData::CustomType> &types = EditorNode::get_editor_data().get_custom_types()[base];
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-09-29 11:53:28 +02:00
Ref<Script> base_scr = scr;
while (base_scr.is_valid()) {
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 21:21:30 +02:00
for (int i = 0; i < types.size(); ++i) {
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-09-29 11:53:28 +02:00
if (types[i].script == base_scr) {
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 21:21:30 +02:00
return types[i].script;
}
}
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-09-29 11:53:28 +02:00
base_scr = base_scr->get_base_script();
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 21:21:30 +02:00
}
}
}
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
return nullptr;
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 21:21:30 +02:00
}
StringName EditorNode::get_object_custom_type_name(const Object *p_object) const {
[Editor] Replace `ERR_FAIL_COND` with `ERR_FAIL_NULL` where applicable
2023-09-09 17:24:40 +02:00
ERR_FAIL_NULL_V(p_object, StringName());
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 21:21:30 +02:00
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-09-29 11:53:28 +02:00
Ref<Script> scr = p_object->get_script();
if (scr.is_null() && Object::cast_to<Script>(p_object)) {
scr = p_object;
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 21:21:30 +02:00
}
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-09-29 11:53:28 +02:00
if (scr.is_valid()) {
Ref<Script> base_scr = scr;
while (base_scr.is_valid()) {
StringName name = EditorNode::get_editor_data().script_class_get_name(base_scr->get_path());
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (name != StringName()) {
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 21:21:30 +02:00
return name;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 21:21:30 +02:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// TODO: Should probably be deprecated in 4.x.
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-09-29 11:53:28 +02:00
StringName base = base_scr->get_instance_base_type();
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 21:21:30 +02:00
if (base != StringName() && EditorNode::get_editor_data().get_custom_types().has(base)) {
const Vector<EditorData::CustomType> &types = EditorNode::get_editor_data().get_custom_types()[base];
for (int i = 0; i < types.size(); ++i) {
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-09-29 11:53:28 +02:00
if (types[i].script == base_scr) {
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 21:21:30 +02:00
return types[i].name;
}
}
}
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-09-29 11:53:28 +02:00
base_scr = base_scr->get_base_script();
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 21:21:30 +02:00
}
}
return StringName();
}
Added 'Select Current' option when user is prompted to select main scene after clicking play
2021-07-06 16:10:07 +02:00
void EditorNode::_pick_main_scene_custom_action(const String &p_custom_action_name) {
if (p_custom_action_name == "select_current") {
Node *scene = editor_data.get_edited_scene_root();
if (!scene) {
show_accept(TTR("There is no defined scene to run."), TTR("OK"));
return;
}
pick_main_scene->hide();
[Editor]: Allow `Select Current` to Save Scenes [Editor]: Change `Select Current` to Save scenes before attempting to Run them.
2022-06-22 05:56:09 +02:00
if (!FileAccess::exists(scene->get_scene_file_path())) {
current_menu_option = FILE_SAVE_AND_RUN_MAIN_SCENE;
_menu_option_confirm(FILE_SAVE_AS_SCENE, true);
file->set_title(TTR("Save scene before running..."));
} else {
current_menu_option = SETTINGS_PICK_MAIN_SCENE;
_dialog_action(scene->get_scene_file_path());
}
Added 'Select Current' option when user is prompted to select main scene after clicking play
2021-07-06 16:10:07 +02:00
}
}
Don't grab theme icons for scripts
2023-07-08 15:03:54 +02:00
Ref<Texture2D> EditorNode::_get_class_or_script_icon(const String &p_class, const Ref<Script> &p_script, const String &p_fallback, bool p_fallback_script_to_theme) {
Streamline class icon resolution in the editor
2023-03-31 21:17:59 +02:00
ERR_FAIL_COND_V_MSG(p_class.is_empty(), nullptr, "Class name cannot be empty.");
EditorData &ed = EditorNode::get_editor_data();
Refactor editor icon retrieval
2018-09-02 23:40:51 +02:00
Streamline class icon resolution in the editor
2023-03-31 21:17:59 +02:00
// Check for a script icon first.
if (p_script.is_valid()) {
Ref<Texture2D> script_icon = ed.get_script_icon(p_script);
if (script_icon.is_valid()) {
return script_icon;
}
Don't grab theme icons for scripts
2023-07-08 15:03:54 +02:00
if (p_fallback_script_to_theme) {
Check the native base of scripts when resolving icons
2023-09-06 15:20:07 +02:00
// Look for the native base type in the editor theme. This is relevant for
// scripts extending other scripts and for built-in classes.
String script_class_name = p_script->get_language()->get_global_class_name(p_script->get_path());
String base_type = ScriptServer::get_global_class_native_base(script_class_name);
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
if (theme.is_valid() && theme->has_icon(base_type, EditorStringName(EditorIcons))) {
return theme->get_icon(base_type, EditorStringName(EditorIcons));
Don't grab theme icons for scripts
2023-07-08 15:03:54 +02:00
}
}
Refactor editor icon retrieval
2018-09-02 23:40:51 +02:00
}
Streamline class icon resolution in the editor
2023-03-31 21:17:59 +02:00
// Script was not valid or didn't yield any useful values, try the class name
// directly.
Refactor editor icon retrieval
2018-09-02 23:40:51 +02:00
Add support for icons in GDExtension classes Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
2023-03-31 21:17:59 +02:00
// Check if the class name is an extension-defined type.
Ref<Texture2D> ext_icon = ed.extension_class_get_icon(p_class);
if (ext_icon.is_valid()) {
return ext_icon;
}
Streamline class icon resolution in the editor
2023-03-31 21:17:59 +02:00
// Check if the class name is a custom type.
// TODO: Should probably be deprecated in 4.x
const EditorData::CustomType *ctype = ed.get_custom_type_by_name(p_class);
if (ctype && ctype->icon.is_valid()) {
return ctype->icon;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Refactor editor icon retrieval
2018-09-02 23:40:51 +02:00
Streamline class icon resolution in the editor
2023-03-31 21:17:59 +02:00
// Look up the class name or the fallback name in the editor theme.
// This is only relevant for built-in classes.
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
if (theme.is_valid()) {
if (theme->has_icon(p_class, EditorStringName(EditorIcons))) {
return theme->get_icon(p_class, EditorStringName(EditorIcons));
Streamline class icon resolution in the editor
2023-03-31 21:17:59 +02:00
}
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
if (!p_fallback.is_empty() && theme->has_icon(p_fallback, EditorStringName(EditorIcons))) {
return theme->get_icon(p_fallback, EditorStringName(EditorIcons));
Streamline class icon resolution in the editor
2023-03-31 21:17:59 +02:00
}
Use the gray color for all abstract classes
2023-08-01 19:04:28 +02:00
// If the fallback is empty or wasn't found, use the default fallback.
if (ClassDB::class_exists(p_class)) {
bool instantiable = !ClassDB::is_virtual(p_class) && ClassDB::can_instantiate(p_class);
if (ClassDB::is_parent_class(p_class, SNAME("Node"))) {
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
return theme->get_icon(instantiable ? "Node" : "NodeDisabled", EditorStringName(EditorIcons));
Use the gray color for all abstract classes
2023-08-01 19:04:28 +02:00
} else {
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
return theme->get_icon(instantiable ? "Object" : "ObjectDisabled", EditorStringName(EditorIcons));
Use the gray color for all abstract classes
2023-08-01 19:04:28 +02:00
}
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Refactor editor icon retrieval
2018-09-02 23:40:51 +02:00
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
return nullptr;
Refactor editor icon retrieval
2018-09-02 23:40:51 +02:00
}
Streamline class icon resolution in the editor
2023-03-31 21:17:59 +02:00
Ref<Texture2D> EditorNode::get_object_icon(const Object *p_object, const String &p_fallback) {
ERR_FAIL_NULL_V_MSG(p_object, nullptr, "Object cannot be null.");
Fix inherited icons for script classes
2019-02-07 00:53:24 +01:00
Streamline class icon resolution in the editor
2023-03-31 21:17:59 +02:00
Ref<Script> scr = p_object->get_script();
if (scr.is_null() && p_object->is_class("Script")) {
scr = p_object;
Refactor editor icon retrieval
2018-09-02 23:40:51 +02:00
}
Streamline class icon resolution in the editor
2023-03-31 21:17:59 +02:00
return _get_class_or_script_icon(p_object->get_class(), scr, p_fallback);
}
Refactor editor icon retrieval
2018-09-02 23:40:51 +02:00
Streamline class icon resolution in the editor
2023-03-31 21:17:59 +02:00
Ref<Texture2D> EditorNode::get_class_icon(const String &p_class, const String &p_fallback) {
ERR_FAIL_COND_V_MSG(p_class.is_empty(), nullptr, "Class name cannot be empty.");
Don't use arbitrary theme editor icons for scripts with the same name The existing theme editor icon could be unintentionally set for any global class with matching name (`Group` icon, `Group` class_name etc), which would only show up in the "Create Dialog" context, but not the scene tree dock. This change prevents this behavior, and ensures that the icon can be actually overidden by explicit icon path in `class_name`, if there's any custom icon to begin with. The correct built-in type's icon is fetched for child classes if there are no custom icons detected throughout base classes as well, so it isn't left empty for those cases.
2020-06-25 01:13:13 +02:00
Streamline class icon resolution in the editor
2023-03-31 21:17:59 +02:00
Ref<Script> scr;
if (ScriptServer::is_global_class(p_class)) {
scr = EditorNode::get_editor_data().script_class_load_script(p_class);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Refactor editor icon retrieval
2018-09-02 23:40:51 +02:00
Don't grab theme icons for scripts
2023-07-08 15:03:54 +02:00
return _get_class_or_script_icon(p_class, scr, p_fallback, true);
Refactor editor icon retrieval
2018-09-02 23:40:51 +02:00
}
Added custom node export
2022-10-08 00:16:54 +02:00
bool EditorNode::is_object_of_custom_type(const Object *p_object, const StringName &p_class) {
[Editor] Replace `ERR_FAIL_COND` with `ERR_FAIL_NULL` where applicable
2023-09-09 17:24:40 +02:00
ERR_FAIL_NULL_V(p_object, false);
Added custom node export
2022-10-08 00:16:54 +02:00
Ref<Script> scr = p_object->get_script();
if (scr.is_null() && Object::cast_to<Script>(p_object)) {
scr = p_object;
}
if (scr.is_valid()) {
Ref<Script> base_script = scr;
while (base_script.is_valid()) {
StringName name = EditorNode::get_editor_data().script_class_get_name(base_script->get_path());
if (name == p_class) {
return true;
}
base_script = base_script->get_base_script();
}
}
return false;
}
-Add lightmapper -Fixes to unwrapper (remove degenerates), makes Thekla not crash -Added optional cancel button in EditorProgress -Added function to force processing of events (needed for cancel button)
2017-12-14 12:59:46 +01:00
void EditorNode::progress_add_task(const String &p_task, const String &p_label, int p_steps, bool p_can_cancel) {
Export: Properly disable resource preview thread Fixes #26857. Fixes #34433. Fixes #34826.
2020-01-14 11:32:15 +01:00
if (singleton->cmdline_export_mode) {
Disable progress dialog on export from command line, stab at fixing #24031
2018-11-28 12:45:51 +01:00
print_line(p_task + ": begin: " + p_label + " steps: " + itos(p_steps));
Automatically reparent editor progress dialog to avoid error spam.
2023-01-11 09:13:21 +01:00
} else if (singleton->progress_dialog) {
Disable progress dialog on export from command line, stab at fixing #24031
2018-11-28 12:45:51 +01:00
singleton->progress_dialog->add_task(p_task, p_label, p_steps, p_can_cancel);
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
-Add lightmapper -Fixes to unwrapper (remove degenerates), makes Thekla not crash -Added optional cancel button in EditorProgress -Added function to force processing of events (needed for cancel button)
2017-12-14 12:59:46 +01:00
bool EditorNode::progress_task_step(const String &p_task, const String &p_state, int p_step, bool p_force_refresh) {
Export: Properly disable resource preview thread Fixes #26857. Fixes #34433. Fixes #34826.
2020-01-14 11:32:15 +01:00
if (singleton->cmdline_export_mode) {
Disable progress dialog on export from command line, stab at fixing #24031
2018-11-28 12:45:51 +01:00
print_line("\t" + p_task + ": step " + itos(p_step) + ": " + p_state);
return false;
Automatically reparent editor progress dialog to avoid error spam.
2023-01-11 09:13:21 +01:00
} else if (singleton->progress_dialog) {
Disable progress dialog on export from command line, stab at fixing #24031
2018-11-28 12:45:51 +01:00
return singleton->progress_dialog->task_step(p_task, p_state, p_step, p_force_refresh);
Automatically reparent editor progress dialog to avoid error spam.
2023-01-11 09:13:21 +01:00
} else {
return false;
Disable progress dialog on export from command line, stab at fixing #24031
2018-11-28 12:45:51 +01:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
void EditorNode::progress_end_task(const String &p_task) {
Export: Properly disable resource preview thread Fixes #26857. Fixes #34433. Fixes #34826.
2020-01-14 11:32:15 +01:00
if (singleton->cmdline_export_mode) {
Disable progress dialog on export from command line, stab at fixing #24031
2018-11-28 12:45:51 +01:00
print_line(p_task + ": end");
Automatically reparent editor progress dialog to avoid error spam.
2023-01-11 09:13:21 +01:00
} else if (singleton->progress_dialog) {
Disable progress dialog on export from command line, stab at fixing #24031
2018-11-28 12:45:51 +01:00
singleton->progress_dialog->end_task(p_task);
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
void EditorNode::progress_add_task_bg(const String &p_task, const String &p_label, int p_steps) {
singleton->progress_hb->add_task(p_task, p_label, p_steps);
}
void EditorNode::progress_task_step_bg(const String &p_task, int p_step) {
singleton->progress_hb->task_step(p_task, p_step);
}
void EditorNode::progress_end_task_bg(const String &p_task) {
singleton->progress_hb->end_task(p_task);
}
Copy system info to clipboard + Update bug_report.yml plus minor static-related fixes * linuxbsd: get_systemd_os_release_info_value() -> static breaks usage if used multiple times * windows/linuxbsd: get_video_adapter_driver_info() writes info into static * linuxbsd: get_distribution_name() + get_version() -> write bsd fallback into static variable * windows/uwp/android: remove unnecessary use of static
2023-05-27 18:21:23 +02:00
String EditorNode::_get_system_info() const {
String distribution_name = OS::get_singleton()->get_distribution_name();
if (distribution_name.is_empty()) {
distribution_name = OS::get_singleton()->get_name();
}
if (distribution_name.is_empty()) {
distribution_name = "Other";
}
const String distribution_version = OS::get_singleton()->get_version();
Make system information for issue reports single-line Additionally: * for custom builds, add commit hash * added a tooltip to help mitigate potential/understandable confusion whether the single-line output might be a bug * prettify driver name
2023-05-29 22:20:40 +02:00
String godot_version = "Godot v" + String(VERSION_FULL_CONFIG);
if (String(VERSION_BUILD) != "official") {
String hash = String(VERSION_HASH);
hash = hash.is_empty() ? String("unknown") : vformat("(%s)", hash.left(9));
godot_version += " " + hash;
}
Copy system info to clipboard + Update bug_report.yml plus minor static-related fixes * linuxbsd: get_systemd_os_release_info_value() -> static breaks usage if used multiple times * windows/linuxbsd: get_video_adapter_driver_info() writes info into static * linuxbsd: get_distribution_name() + get_version() -> write bsd fallback into static variable * windows/uwp/android: remove unnecessary use of static
2023-05-27 18:21:23 +02:00
Include Display Server Type in Copy System Info Add info about X11 or Wayland to System Information on LinuxBSD.
2023-07-12 23:12:31 +02:00
#ifdef LINUXBSD_ENABLED
const String display_server = OS::get_singleton()->get_environment("XDG_SESSION_TYPE").capitalize().replace(" ", ""); // `replace` is necessary, because `capitalize` introduces a whitespace between "x" and "11".
#endif // LINUXBSD_ENABLED
Make system information for issue reports single-line Additionally: * for custom builds, add commit hash * added a tooltip to help mitigate potential/understandable confusion whether the single-line output might be a bug * prettify driver name
2023-05-29 22:20:40 +02:00
String driver_name = GLOBAL_GET("rendering/rendering_device/driver");
Copy system info to clipboard + Update bug_report.yml plus minor static-related fixes * linuxbsd: get_systemd_os_release_info_value() -> static breaks usage if used multiple times * windows/linuxbsd: get_video_adapter_driver_info() writes info into static * linuxbsd: get_distribution_name() + get_version() -> write bsd fallback into static variable * windows/uwp/android: remove unnecessary use of static
2023-05-27 18:21:23 +02:00
String rendering_method = GLOBAL_GET("rendering/renderer/rendering_method");
Replace get_rendering_device() call to prevent crashes on OpenGL. And make OpenGL video adapter info align with Vulkan.
2023-06-06 23:29:36 +02:00
const String rendering_device_name = RenderingServer::get_singleton()->get_video_adapter_name();
Copy system info to clipboard + Update bug_report.yml plus minor static-related fixes * linuxbsd: get_systemd_os_release_info_value() -> static breaks usage if used multiple times * windows/linuxbsd: get_video_adapter_driver_info() writes info into static * linuxbsd: get_distribution_name() + get_version() -> write bsd fallback into static variable * windows/uwp/android: remove unnecessary use of static
2023-05-27 18:21:23 +02:00
RenderingDevice::DeviceType device_type = RenderingServer::get_singleton()->get_video_adapter_type();
String device_type_string;
switch (device_type) {
case RenderingDevice::DeviceType::DEVICE_TYPE_INTEGRATED_GPU:
device_type_string = "integrated";
break;
case RenderingDevice::DeviceType::DEVICE_TYPE_DISCRETE_GPU:
device_type_string = "dedicated";
break;
case RenderingDevice::DeviceType::DEVICE_TYPE_VIRTUAL_GPU:
device_type_string = "virtual";
break;
case RenderingDevice::DeviceType::DEVICE_TYPE_CPU:
Make system information for issue reports single-line Additionally: * for custom builds, add commit hash * added a tooltip to help mitigate potential/understandable confusion whether the single-line output might be a bug * prettify driver name
2023-05-29 22:20:40 +02:00
device_type_string = "(software emulation on CPU)";
Copy system info to clipboard + Update bug_report.yml plus minor static-related fixes * linuxbsd: get_systemd_os_release_info_value() -> static breaks usage if used multiple times * windows/linuxbsd: get_video_adapter_driver_info() writes info into static * linuxbsd: get_distribution_name() + get_version() -> write bsd fallback into static variable * windows/uwp/android: remove unnecessary use of static
2023-05-27 18:21:23 +02:00
break;
case RenderingDevice::DeviceType::DEVICE_TYPE_OTHER:
case RenderingDevice::DeviceType::DEVICE_TYPE_MAX:
break; // Can't happen, but silences warning for DEVICE_TYPE_MAX
}
const Vector<String> video_adapter_driver_info = OS::get_singleton()->get_video_adapter_driver_info();
const String processor_name = OS::get_singleton()->get_processor_name();
const int processor_count = OS::get_singleton()->get_processor_count();
// Prettify
if (rendering_method == "forward_plus") {
rendering_method = "Forward+";
} else if (rendering_method == "mobile") {
rendering_method = "Mobile";
} else if (rendering_method == "gl_compatibility") {
rendering_method = "Compatibility";
Fix Copy System Info to copy the correct rendering driver for the Compatibility rendering method
2023-07-13 11:54:45 +02:00
driver_name = GLOBAL_GET("rendering/gl_compatibility/driver");
}
if (driver_name == "vulkan") {
driver_name = "Vulkan";
[X11] Add support for using EGL/GLES instead of GLX.
2023-09-22 09:55:55 +02:00
} else if (driver_name.begins_with("opengl3")) {
Fix Copy System Info to copy the correct rendering driver for the Compatibility rendering method
2023-07-13 11:54:45 +02:00
driver_name = "GLES3";
Copy system info to clipboard + Update bug_report.yml plus minor static-related fixes * linuxbsd: get_systemd_os_release_info_value() -> static breaks usage if used multiple times * windows/linuxbsd: get_video_adapter_driver_info() writes info into static * linuxbsd: get_distribution_name() + get_version() -> write bsd fallback into static variable * windows/uwp/android: remove unnecessary use of static
2023-05-27 18:21:23 +02:00
}
// Join info.
Vector<String> info;
Make system information for issue reports single-line Additionally: * for custom builds, add commit hash * added a tooltip to help mitigate potential/understandable confusion whether the single-line output might be a bug * prettify driver name
2023-05-29 22:20:40 +02:00
info.push_back(godot_version);
Copy system info to clipboard + Update bug_report.yml plus minor static-related fixes * linuxbsd: get_systemd_os_release_info_value() -> static breaks usage if used multiple times * windows/linuxbsd: get_video_adapter_driver_info() writes info into static * linuxbsd: get_distribution_name() + get_version() -> write bsd fallback into static variable * windows/uwp/android: remove unnecessary use of static
2023-05-27 18:21:23 +02:00
if (!distribution_version.is_empty()) {
Make system information for issue reports single-line Additionally: * for custom builds, add commit hash * added a tooltip to help mitigate potential/understandable confusion whether the single-line output might be a bug * prettify driver name
2023-05-29 22:20:40 +02:00
info.push_back(distribution_name + " " + distribution_version);
Copy system info to clipboard + Update bug_report.yml plus minor static-related fixes * linuxbsd: get_systemd_os_release_info_value() -> static breaks usage if used multiple times * windows/linuxbsd: get_video_adapter_driver_info() writes info into static * linuxbsd: get_distribution_name() + get_version() -> write bsd fallback into static variable * windows/uwp/android: remove unnecessary use of static
2023-05-27 18:21:23 +02:00
} else {
Make system information for issue reports single-line Additionally: * for custom builds, add commit hash * added a tooltip to help mitigate potential/understandable confusion whether the single-line output might be a bug * prettify driver name
2023-05-29 22:20:40 +02:00
info.push_back(distribution_name);
Copy system info to clipboard + Update bug_report.yml plus minor static-related fixes * linuxbsd: get_systemd_os_release_info_value() -> static breaks usage if used multiple times * windows/linuxbsd: get_video_adapter_driver_info() writes info into static * linuxbsd: get_distribution_name() + get_version() -> write bsd fallback into static variable * windows/uwp/android: remove unnecessary use of static
2023-05-27 18:21:23 +02:00
}
Include Display Server Type in Copy System Info Add info about X11 or Wayland to System Information on LinuxBSD.
2023-07-12 23:12:31 +02:00
#ifdef LINUXBSD_ENABLED
if (!display_server.is_empty()) {
info.push_back(display_server);
}
#endif // LINUXBSD_ENABLED
Make system information for issue reports single-line Additionally: * for custom builds, add commit hash * added a tooltip to help mitigate potential/understandable confusion whether the single-line output might be a bug * prettify driver name
2023-05-29 22:20:40 +02:00
info.push_back(vformat("%s (%s)", driver_name, rendering_method));
String graphics;
if (!device_type_string.is_empty()) {
graphics = device_type_string + " ";
Copy system info to clipboard + Update bug_report.yml plus minor static-related fixes * linuxbsd: get_systemd_os_release_info_value() -> static breaks usage if used multiple times * windows/linuxbsd: get_video_adapter_driver_info() writes info into static * linuxbsd: get_distribution_name() + get_version() -> write bsd fallback into static variable * windows/uwp/android: remove unnecessary use of static
2023-05-27 18:21:23 +02:00
}
Make system information for issue reports single-line Additionally: * for custom builds, add commit hash * added a tooltip to help mitigate potential/understandable confusion whether the single-line output might be a bug * prettify driver name
2023-05-29 22:20:40 +02:00
graphics += rendering_device_name;
Copy system info to clipboard + Update bug_report.yml plus minor static-related fixes * linuxbsd: get_systemd_os_release_info_value() -> static breaks usage if used multiple times * windows/linuxbsd: get_video_adapter_driver_info() writes info into static * linuxbsd: get_distribution_name() + get_version() -> write bsd fallback into static variable * windows/uwp/android: remove unnecessary use of static
2023-05-27 18:21:23 +02:00
if (video_adapter_driver_info.size() == 2) { // This vector is always either of length 0 or 2.
String vad_name = video_adapter_driver_info[0];
String vad_version = video_adapter_driver_info[1]; // Version could be potentially empty on Linux/BSD.
if (!vad_version.is_empty()) {
Make system information for issue reports single-line Additionally: * for custom builds, add commit hash * added a tooltip to help mitigate potential/understandable confusion whether the single-line output might be a bug * prettify driver name
2023-05-29 22:20:40 +02:00
graphics += vformat(" (%s; %s)", vad_name, vad_version);
Copy system info to clipboard + Update bug_report.yml plus minor static-related fixes * linuxbsd: get_systemd_os_release_info_value() -> static breaks usage if used multiple times * windows/linuxbsd: get_video_adapter_driver_info() writes info into static * linuxbsd: get_distribution_name() + get_version() -> write bsd fallback into static variable * windows/uwp/android: remove unnecessary use of static
2023-05-27 18:21:23 +02:00
} else {
Make system information for issue reports single-line Additionally: * for custom builds, add commit hash * added a tooltip to help mitigate potential/understandable confusion whether the single-line output might be a bug * prettify driver name
2023-05-29 22:20:40 +02:00
graphics += vformat(" (%s)", vad_name);
Copy system info to clipboard + Update bug_report.yml plus minor static-related fixes * linuxbsd: get_systemd_os_release_info_value() -> static breaks usage if used multiple times * windows/linuxbsd: get_video_adapter_driver_info() writes info into static * linuxbsd: get_distribution_name() + get_version() -> write bsd fallback into static variable * windows/uwp/android: remove unnecessary use of static
2023-05-27 18:21:23 +02:00
}
}
Make system information for issue reports single-line Additionally: * for custom builds, add commit hash * added a tooltip to help mitigate potential/understandable confusion whether the single-line output might be a bug * prettify driver name
2023-05-29 22:20:40 +02:00
info.push_back(graphics);
info.push_back(vformat("%s (%d Threads)", processor_name, processor_count));
Copy system info to clipboard + Update bug_report.yml plus minor static-related fixes * linuxbsd: get_systemd_os_release_info_value() -> static breaks usage if used multiple times * windows/linuxbsd: get_video_adapter_driver_info() writes info into static * linuxbsd: get_distribution_name() + get_version() -> write bsd fallback into static variable * windows/uwp/android: remove unnecessary use of static
2023-05-27 18:21:23 +02:00
Make system information for issue reports single-line Additionally: * for custom builds, add commit hash * added a tooltip to help mitigate potential/understandable confusion whether the single-line output might be a bug * prettify driver name
2023-05-29 22:20:40 +02:00
return String(" - ").join(info);
Copy system info to clipboard + Update bug_report.yml plus minor static-related fixes * linuxbsd: get_systemd_os_release_info_value() -> static breaks usage if used multiple times * windows/linuxbsd: get_video_adapter_driver_info() writes info into static * linuxbsd: get_distribution_name() + get_version() -> write bsd fallback into static variable * windows/uwp/android: remove unnecessary use of static
2023-05-27 18:21:23 +02:00
}
Texture refactor -Texture renamed to Texture2D -TextureLayered as base now inherits 2Darray, cubemap and cubemap array -Removed all references to flags in textures (they will go in the shader) -Texture3D gone for now (will come back later done properly) -Create base rasterizer for RenderDevice, RasterizerRD
2019-06-11 20:43:37 +02:00
Ref<Texture2D> EditorNode::_file_dialog_get_icon(const String &p_path) {
removed duplicated functions in class hierarchy that were bound more than once added a check to detect this case in the future
2017-01-14 15:07:57 +01:00
EditorFileSystemDirectory *efsd = EditorFileSystem::get_singleton()->get_filesystem_path(p_path.get_base_dir());
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (efsd) {
String file = p_path.get_file();
for (int i = 0; i < efsd->get_file_count(); i++) {
if (efsd->get_file(i) == file) {
String type = efsd->get_file_type(i);
if (singleton->icon_type_cache.has(type)) {
return singleton->icon_type_cache[type];
} else {
return singleton->icon_type_cache["Object"];
}
}
}
}
return singleton->icon_type_cache["Object"];
}
Update icons when theme changed
2018-02-25 17:04:16 +01:00
void EditorNode::_build_icon_type_cache() {
List<StringName> tl;
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
theme->get_icon_list(EditorStringName(EditorIcons), &tl);
Use const references where possible for List range iterators
2021-07-24 15:46:25 +02:00
for (const StringName &E : tl) {
Use C++ iterators for Lists in many situations
2021-07-16 05:45:57 +02:00
if (!ClassDB::class_exists(E)) {
Update icons when theme changed
2018-02-25 17:04:16 +01:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
icon_type_cache[E] = theme->get_icon(E, EditorStringName(EditorIcons));
Update icons when theme changed
2018-02-25 17:04:16 +01:00
}
}
Retry loading addons after filesystem scan
2022-12-28 13:56:53 +01:00
void EditorNode::_enable_pending_addons() {
for (uint32_t i = 0; i < pending_addons.size(); i++) {
set_addon_plugin_enabled(pending_addons[i], true);
}
pending_addons.clear();
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
void EditorNode::_file_dialog_register(FileDialog *p_dialog) {
singleton->file_dialogs.insert(p_dialog);
}
void EditorNode::_file_dialog_unregister(FileDialog *p_dialog) {
singleton->file_dialogs.erase(p_dialog);
}
work in progress, resource previews
2015-05-31 06:59:42 +02:00
void EditorNode::_editor_file_dialog_register(EditorFileDialog *p_dialog) {
singleton->editor_file_dialogs.insert(p_dialog);
}
void EditorNode::_editor_file_dialog_unregister(EditorFileDialog *p_dialog) {
singleton->editor_file_dialogs.erase(p_dialog);
}
-scripts are converted to bytecode on export -fix bug in doc where touchscreen events were not documented
2014-02-25 13:31:47 +01:00
Vector<EditorNodeInitCallback> EditorNode::_init_callbacks;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Add Startup benchmarking support This adds support for benchmarking engine startup (and editor startup if used). The goal is to use this in the benchmarking server to track improvements and changes to engine, editor, importer and scene loading startup times.
2022-08-19 14:21:43 +02:00
void EditorNode::_begin_first_scan() {
Scan the filesystem in the first frame when using headless mode
2023-11-07 10:46:56 +01:00
// In headless mode, scan right away.
// This allows users to continue using `godot --headless --editor --quit` to prepare a project.
if (!DisplayServer::get_singleton()->window_can_draw()) {
Improve engine startup/shutdown benchmarks - Add contexts to give a better sense of benchmarked areas. - Add missing benchmarks and adjust some begin/end points. - Clean up names. - Improve Android's internal benchmarks in a similar manner. Co-authored-by: Fredia Huya-Kouadio <fhuya@meta.com>
2023-12-08 12:52:49 +01:00
OS::get_singleton()->benchmark_begin_measure("Editor", "First Scan");
Scan the filesystem in the first frame when using headless mode
2023-11-07 10:46:56 +01:00
EditorFileSystem::get_singleton()->scan();
return;
}
Overhaul the SurfaceUpgradeTool This defers the update to a fresh restart of the editor (to ensure we aren't mid way through loading scenes anymore. It also ensures that the popup can't be used by multiple threads at once Co-authored-by: Yuri Sizov <yuris@humnom.net>
2023-10-30 15:34:18 +01:00
if (!waiting_for_first_scan) {
return;
}
requested_first_scan = true;
Add Startup benchmarking support This adds support for benchmarking engine startup (and editor startup if used). The goal is to use this in the benchmarking server to track improvements and changes to engine, editor, importer and scene loading startup times.
2022-08-19 14:21:43 +02:00
}
Add option to install android build template for export This PR adds a new "--install-android-build-template" command-line option which causes the android build template to be installed before exporting the project.
2023-12-06 05:35:52 +01:00
Error EditorNode::export_preset(const String &p_preset, const String &p_path, bool p_debug, bool p_pack_only, bool p_android_build_template) {
Renamed function arguments to keep them consistent between declaration and implementation
2017-09-14 19:49:11 +02:00
export_defer.preset = p_preset;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
export_defer.path = p_path;
export_defer.debug = p_debug;
Export: Add dedicated --export-pack option to export data pack The previous behavior relying on the provided extension was problematic on macOS since .zip is the main extension used for the full project export (binary + data pack). We add a dedicated `--export-pack` command line option to define when only the data pack should be exported. Its extension will still be inferred from the path. Fixes #23073.
2020-01-08 14:22:50 +01:00
export_defer.pack_only = p_pack_only;
Add option to install android build template for export This PR adds a new "--install-android-build-template" command-line option which causes the android build template to be installed before exporting the project.
2023-12-06 05:35:52 +01:00
export_defer.android_build_template = p_android_build_template;
Export: Properly disable resource preview thread Fixes #26857. Fixes #34433. Fixes #34826.
2020-01-14 11:32:15 +01:00
cmdline_export_mode = true;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return OK;
}
Prevent the surface upgrade tool from running during export Also add an explicit way to trigger the tool manually at user's will.
2023-11-20 14:44:38 +01:00
bool EditorNode::is_project_exporting() const {
return project_export && project_export->is_exporting();
}
Add a message when there is nothing to Undo or Redo
2018-05-27 04:41:19 +02:00
void EditorNode::show_accept(const String &p_text, const String &p_title) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
current_menu_option = -1;
Automatically reparent editor message dialogs to avoid error spam.
2023-02-15 15:35:16 +01:00
if (accept) {
accept->set_ok_button_text(p_title);
accept->set_text(p_text);
Expose dialog parent-and-popup logic to the API
2023-04-20 15:13:21 +02:00
EditorInterface::get_singleton()->popup_dialog_centered(accept);
Automatically reparent editor message dialogs to avoid error spam.
2023-02-15 15:35:16 +01:00
}
Add a message when there is nothing to Undo or Redo
2018-05-27 04:41:19 +02:00
}
Corrected Save Scene and Save All Scenes not working when the scene's dir no longer exists
2021-09-11 03:35:13 +02:00
void EditorNode::show_save_accept(const String &p_text, const String &p_title) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
current_menu_option = -1;
Automatically reparent editor message dialogs to avoid error spam.
2023-02-15 15:35:16 +01:00
if (save_accept) {
save_accept->set_ok_button_text(p_title);
save_accept->set_text(p_text);
Expose dialog parent-and-popup logic to the API
2023-04-20 15:13:21 +02:00
EditorInterface::get_singleton()->popup_dialog_centered(save_accept);
Automatically reparent editor message dialogs to avoid error spam.
2023-02-15 15:35:16 +01:00
}
Corrected Save Scene and Save All Scenes not working when the scene's dir no longer exists
2021-09-11 03:35:13 +02:00
}
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 14:44:12 +01:00
void EditorNode::show_warning(const String &p_text, const String &p_title) {
Automatically reparent editor message dialogs to avoid error spam.
2023-02-15 15:35:16 +01:00
if (warning) {
EditorNode::show_warning displays a console warning instead of failing during project load Fixes #31522
2019-08-21 09:04:55 +02:00
warning->set_text(p_text);
warning->set_title(p_title);
Expose dialog parent-and-popup logic to the API
2023-04-20 15:13:21 +02:00
EditorInterface::get_singleton()->popup_dialog_centered(warning);
EditorNode::show_warning displays a console warning instead of failing during project load Fixes #31522
2019-08-21 09:04:55 +02:00
} else {
Remove duplicate WARN_PRINT macro.
2019-11-07 09:44:15 +01:00
WARN_PRINT(p_title + " " + p_text);
EditorNode::show_warning displays a console warning instead of failing during project load Fixes #31522
2019-08-21 09:04:55 +02:00
}
New Navigation & Pathfinding support for 2D -Added Navigation & NavigationPolygon nodes -Added corresponding visual editor -New pathfinding algorithm is modern and fast! -Similar API to 3D Pathfinding (more coherent)
2015-02-14 16:09:52 +01:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Add a way to copy the text of warnings shown in the editor Closes #20662
2019-07-09 20:11:31 +02:00
void EditorNode::_copy_warning(const String &p_str) {
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 14:36:29 +01:00
DisplayServer::get_singleton()->clipboard_set(warning->get_text());
Add a way to copy the text of warnings shown in the editor Closes #20662
2019-07-09 20:11:31 +02:00
}
Add multi window code and shader editors
2022-11-02 15:23:25 +01:00
void EditorNode::_dock_floating_close_request(WindowWrapper *p_wrapper) {
int dock_slot_num = p_wrapper->get_meta("dock_slot");
int dock_slot_index = p_wrapper->get_meta("dock_index");
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
Add multi window code and shader editors
2022-11-02 15:23:25 +01:00
// Give back the dock to the original owner.
Control *dock = p_wrapper->release_wrapped_control();
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
fix dock visibility issues
2023-10-28 17:08:59 +02:00
int target_index = MIN(dock_slot_index, dock_slot[dock_slot_num]->get_tab_count());
Add multi window code and shader editors
2022-11-02 15:23:25 +01:00
dock_slot[dock_slot_num]->add_child(dock);
fix dock visibility issues
2023-10-28 17:08:59 +02:00
dock_slot[dock_slot_num]->move_child(dock, target_index);
dock_slot[dock_slot_num]->set_current_tab(target_index);
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
Add multi window code and shader editors
2022-11-02 15:23:25 +01:00
floating_docks.erase(p_wrapper);
p_wrapper->queue_free();
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
fix dock visibility issues
2023-10-28 17:08:59 +02:00
_update_dock_slots_visibility(true);
Inspector retains content when detached and when docked
2022-01-29 19:32:36 +01:00
_edit_current();
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
}
Add multi window code and shader editors
2022-11-02 15:23:25 +01:00
void EditorNode::_dock_make_selected_float() {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
Control *dock = dock_slot[dock_popup_selected_idx]->get_current_tab_control();
Add multi window code and shader editors
2022-11-02 15:23:25 +01:00
_dock_make_float(dock, dock_popup_selected_idx);
dock_select_popup->hide();
_edit_current();
}
void EditorNode::_dock_make_float(Control *p_dock, int p_slot_index, bool p_show_window) {
[Editor] Replace `ERR_FAIL_COND` with `ERR_FAIL_NULL` where applicable
2023-09-09 17:24:40 +02:00
ERR_FAIL_NULL(p_dock);
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
Fix theming for floating window docks
2022-01-13 22:13:45 +01:00
Size2 borders = Size2(4, 4) * EDSCALE;
// Remember size and position before removing it from the main window.
Add multi window code and shader editors
2022-11-02 15:23:25 +01:00
Size2 dock_size = p_dock->get_size() + borders * 2;
Point2 dock_screen_pos = p_dock->get_screen_position();
int dock_index = p_dock->get_index() - 1;
dock_slot[p_slot_index]->remove_child(p_dock);
WindowWrapper *wrapper = memnew(WindowWrapper);
wrapper->set_window_title(vformat(TTR("%s - Godot Engine"), p_dock->get_name()));
wrapper->set_margins_enabled(true);
gui_base->add_child(wrapper);
wrapper->set_wrapped_control(p_dock);
wrapper->set_meta("dock_slot", p_slot_index);
wrapper->set_meta("dock_index", dock_index);
wrapper->set_meta("dock_name", p_dock->get_name().operator String());
fix load floating dock layout
2023-10-03 21:36:53 +02:00
p_dock->show();
Add multi window code and shader editors
2022-11-02 15:23:25 +01:00
wrapper->connect("window_close_requested", callable_mp(this, &EditorNode::_dock_floating_close_request).bind(wrapper));
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
dock_select_popup->hide();
Add multi window code and shader editors
2022-11-02 15:23:25 +01:00
if (p_show_window) {
wrapper->restore_window(Rect2i(dock_screen_pos, dock_size), get_window()->get_current_screen());
}
fix dock visibility issues
2023-10-28 17:08:59 +02:00
_update_dock_slots_visibility(true);
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
Add multi window code and shader editors
2022-11-02 15:23:25 +01:00
floating_docks.push_back(wrapper);
Inspector retains content when detached and when docked
2022-01-29 19:32:36 +01:00
_edit_current();
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
}
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
void EditorNode::_dock_select_input(const Ref<InputEvent> &p_input) {
Ref<InputEventMouse> me = p_input;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
if (me.is_valid()) {
InputEvent: Renamed "pos" property to "position" Make the naming consistent with other classes.
2017-06-03 10:54:24 +02:00
Vector2 point = me->get_position();
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
int nrect = -1;
for (int i = 0; i < DOCK_SLOT_MAX; i++) {
if (dock_select_rect[i].has_point(point)) {
nrect = i;
break;
}
}
fixes for dock motion
2015-06-14 05:41:08 +02:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
if (nrect != dock_select_rect_over_idx) {
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
dock_select->queue_redraw();
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
dock_select_rect_over_idx = nrect;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (nrect == -1) {
fixes for dock motion
2015-06-14 05:41:08 +02:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
fixes for dock motion
2015-06-14 05:41:08 +02:00
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
Ref<InputEventMouseButton> mb = me;
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
if (mb.is_valid() && mb->get_button_index() == MouseButton::LEFT && mb->is_pressed() && dock_popup_selected_idx != nrect) {
Fix tab dragging issues
2023-10-19 04:12:50 +02:00
dock_slot[nrect]->move_tab_from_tab_container(dock_slot[dock_popup_selected_idx], dock_slot[dock_popup_selected_idx]->get_current_tab(), dock_slot[nrect]->get_tab_count());
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
if (dock_slot[dock_popup_selected_idx]->get_tab_count() == 0) {
dock_slot[dock_popup_selected_idx]->hide();
fixed small refresh issue when moving docks
2015-06-14 06:09:58 +02:00
} else {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
dock_slot[dock_popup_selected_idx]->set_current_tab(0);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
}
fixed small refresh issue when moving docks
2015-06-14 06:09:58 +02:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
dock_popup_selected_idx = nrect;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
dock_slot[nrect]->show();
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
dock_select->queue_redraw();
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
fix dock visibility issues
2023-10-28 17:08:59 +02:00
_update_dock_slots_visibility(true);
Fixed right dock dragger not disappearing when there is no docks there.
2017-12-22 19:49:14 +01:00
Inspector re-edits edited object when dock moves, closes #9287
2017-08-19 00:51:17 +02:00
_edit_current();
Improve editor state persistence
2023-05-11 04:17:03 +02:00
_save_editor_layout();
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
}
}
}
fixes for dock motion
2015-06-14 05:41:08 +02:00
void EditorNode::_dock_popup_exit() {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
dock_select_rect_over_idx = -1;
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
dock_select->queue_redraw();
fixes for dock motion
2015-06-14 05:41:08 +02:00
}
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
void EditorNode::_dock_pre_popup(int p_which) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
dock_popup_selected_idx = p_which;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
}
fixes for dock motion
2015-06-14 05:41:08 +02:00
void EditorNode::_dock_move_left() {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
if (dock_popup_selected_idx < 0 || dock_popup_selected_idx >= DOCK_SLOT_MAX) {
fixes for dock motion
2015-06-14 05:41:08 +02:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-09-29 11:53:28 +02:00
Control *current_ctl = dock_slot[dock_popup_selected_idx]->get_tab_control(dock_slot[dock_popup_selected_idx]->get_current_tab());
Control *prev_ctl = dock_slot[dock_popup_selected_idx]->get_tab_control(dock_slot[dock_popup_selected_idx]->get_current_tab() - 1);
if (!current_ctl || !prev_ctl) {
fixes for dock motion
2015-06-14 05:41:08 +02:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Fix a bug with moving dock left and right. Fixes #67039 `get_index` counts internal children by default but `move_child` ignores them therefore `move_child` had no effect. The call to `set_current_tab` is not needed anymore in Godot 4 since the current tab will change when calling `move_child`.
2022-10-07 19:15:20 +02:00
dock_slot[dock_popup_selected_idx]->move_child(current_ctl, prev_ctl->get_index(false));
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
dock_select->queue_redraw();
Inspector re-edits edited object when dock moves, closes #9287
2017-08-19 00:51:17 +02:00
_edit_current();
Improve editor state persistence
2023-05-11 04:17:03 +02:00
_save_editor_layout();
fixes for dock motion
2015-06-14 05:41:08 +02:00
}
void EditorNode::_dock_move_right() {
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-09-29 11:53:28 +02:00
Control *current_ctl = dock_slot[dock_popup_selected_idx]->get_tab_control(dock_slot[dock_popup_selected_idx]->get_current_tab());
Control *next_ctl = dock_slot[dock_popup_selected_idx]->get_tab_control(dock_slot[dock_popup_selected_idx]->get_current_tab() + 1);
if (!current_ctl || !next_ctl) {
fixes for dock motion
2015-06-14 05:41:08 +02:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Fix a bug with moving dock left and right. Fixes #67039 `get_index` counts internal children by default but `move_child` ignores them therefore `move_child` had no effect. The call to `set_current_tab` is not needed anymore in Godot 4 since the current tab will change when calling `move_child`.
2022-10-07 19:15:20 +02:00
dock_slot[dock_popup_selected_idx]->move_child(next_ctl, current_ctl->get_index(false));
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
dock_select->queue_redraw();
Inspector re-edits edited object when dock moves, closes #9287
2017-08-19 00:51:17 +02:00
_edit_current();
Improve editor state persistence
2023-05-11 04:17:03 +02:00
_save_editor_layout();
fixes for dock motion
2015-06-14 05:41:08 +02:00
}
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
void EditorNode::_dock_select_draw() {
Size2 s = dock_select->get_size();
s.y /= 2.0;
s.x /= 6.0;
Color used = Color(0.6, 0.6, 0.6, 0.8);
Color used_selected = Color(0.8, 0.8, 0.8, 0.8);
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
Color tab_selected = theme->get_color(SNAME("mono_color"), EditorStringName(Editor));
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
Color unused = used;
unused.a = 0.4;
Color unusable = unused;
unusable.a = 0.1;
Rect2 unr(s.x * 2, 0, s.x * 2, s.y * 2);
renamed all Rect2.pos to Rect2.position
2017-06-04 00:25:13 +02:00
unr.position += Vector2(2, 5);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
unr.size -= Vector2(4, 7);
dock_select->draw_rect(unr, unusable);
dock_tab_move_left->set_disabled(true);
dock_tab_move_right->set_disabled(true);
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
if (dock_popup_selected_idx != -1 && dock_slot[dock_popup_selected_idx]->get_tab_count()) {
dock_tab_move_left->set_disabled(dock_slot[dock_popup_selected_idx]->get_current_tab() == 0);
dock_tab_move_right->set_disabled(dock_slot[dock_popup_selected_idx]->get_current_tab() >= dock_slot[dock_popup_selected_idx]->get_tab_count() - 1);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
}
for (int i = 0; i < DOCK_SLOT_MAX; i++) {
Vector2 ofs;
switch (i) {
case DOCK_SLOT_LEFT_UL: {
} break;
case DOCK_SLOT_LEFT_BL: {
ofs.y += s.y;
} break;
case DOCK_SLOT_LEFT_UR: {
ofs.x += s.x;
} break;
case DOCK_SLOT_LEFT_BR: {
ofs += s;
} break;
case DOCK_SLOT_RIGHT_UL: {
ofs.x += s.x * 4;
} break;
case DOCK_SLOT_RIGHT_BL: {
ofs.x += s.x * 4;
ofs.y += s.y;
} break;
case DOCK_SLOT_RIGHT_UR: {
ofs.x += s.x * 4;
ofs.x += s.x;
} break;
case DOCK_SLOT_RIGHT_BR: {
ofs.x += s.x * 4;
ofs += s;
} break;
}
Rect2 r(ofs, s);
dock_select_rect[i] = r;
renamed all Rect2.pos to Rect2.position
2017-06-04 00:25:13 +02:00
r.position += Vector2(2, 5);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
r.size -= Vector2(4, 7);
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
if (i == dock_select_rect_over_idx) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
dock_select->draw_rect(r, used_selected);
Make `TabContainer` use `TabBar` internally
2022-03-02 15:37:10 +01:00
} else if (dock_slot[i]->get_tab_count() == 0) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
dock_select->draw_rect(r, unused);
} else {
dock_select->draw_rect(r, used);
}
Make `TabContainer` use `TabBar` internally
2022-03-02 15:37:10 +01:00
for (int j = 0; j < MIN(3, dock_slot[i]->get_tab_count()); j++) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
int xofs = (r.size.width / 3) * j;
Color c = used;
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
if (i == dock_popup_selected_idx && (dock_slot[i]->get_current_tab() > 3 || dock_slot[i]->get_current_tab() == j)) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
c = tab_selected;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
dock_select->draw_rect(Rect2(2 + ofs.x + xofs, ofs.y, r.size.width / 3 - 1, 3), c);
}
}
}
Improve editor state persistence
2023-05-11 04:17:03 +02:00
void EditorNode::_save_editor_layout() {
Avoid docks to be overriden while scanning, fixes #26359
2019-02-27 22:14:24 +01:00
if (waiting_for_first_scan) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
return; // Scanning, do not touch docks.
Avoid docks to be overriden while scanning, fixes #26359
2019-02-27 22:14:24 +01:00
}
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
Ref<ConfigFile> config;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
config.instantiate();
Made Editor Log buttons save their state, per project.
2021-05-05 03:05:09 +02:00
// Load and amend existing config if it exists.
Rename String `plus_file` to `path_join`
2022-08-30 02:34:01 +02:00
config->load(EditorPaths::get_singleton()->get_project_settings_dir().path_join("editor_layout.cfg"));
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
Editor layouts menu
2015-11-22 19:11:17 +01:00
_save_docks_to_config(config, "docks");
Improve editor state persistence
2023-05-11 04:17:03 +02:00
_save_open_scenes_to_config(config);
_save_central_editor_layout_to_config(config);
Editor layouts menu
2015-11-22 19:11:17 +01:00
editor_data.get_plugin_window_layout(config);
Rename String `plus_file` to `path_join`
2022-08-30 02:34:01 +02:00
config->save(EditorPaths::get_singleton()->get_project_settings_dir().path_join("editor_layout.cfg"));
Editor layouts menu
2015-11-22 19:11:17 +01:00
}
void EditorNode::_save_docks_to_config(Ref<ConfigFile> p_layout, const String &p_section) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
for (int i = 0; i < DOCK_SLOT_MAX; i++) {
String names;
for (int j = 0; j < dock_slot[i]->get_tab_count(); j++) {
String name = dock_slot[i]->get_tab_control(j)->get_name();
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 10:42:46 +01:00
if (!names.is_empty()) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
names += ",";
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
names += name;
}
Fix editor dock layout not saving correctly
2022-07-11 20:57:47 +02:00
String config_key = "dock_" + itos(i + 1);
if (p_layout->has_section_key(p_section, config_key)) {
p_layout->erase_section_key(p_section, config_key);
}
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 10:42:46 +01:00
if (!names.is_empty()) {
Fix editor dock layout not saving correctly
2022-07-11 20:57:47 +02:00
p_layout->set_value(p_section, config_key, names);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
}
Improve editor state persistence
2023-05-11 04:17:03 +02:00
int selected_tab_idx = dock_slot[i]->get_current_tab();
if (selected_tab_idx >= 0) {
p_layout->set_value(p_section, "dock_" + itos(i + 1) + "_selected_tab_idx", selected_tab_idx);
}
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
}
Add multi window code and shader editors
2022-11-02 15:23:25 +01:00
Dictionary floating_docks_dump;
for (WindowWrapper *wrapper : floating_docks) {
Control *dock = wrapper->get_wrapped_control();
Dictionary dock_dump;
dock_dump["window_rect"] = wrapper->get_window_rect();
int screen = wrapper->get_window_screen();
dock_dump["window_screen"] = wrapper->get_window_screen();
dock_dump["window_screen_rect"] = DisplayServer::get_singleton()->screen_get_usable_rect(screen);
String name = dock->get_name();
floating_docks_dump[name] = dock_dump;
int dock_slot_id = wrapper->get_meta("dock_slot");
String config_key = "dock_" + itos(dock_slot_id + 1);
String names = p_layout->get_value(p_section, config_key, "");
if (names.is_empty()) {
names = name;
} else {
names += "," + name;
}
p_layout->set_value(p_section, config_key, names);
}
p_layout->set_value(p_section, "dock_floating", floating_docks_dump);
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
for (int i = 0; i < vsplits.size(); i++) {
if (vsplits[i]->is_visible_in_tree()) {
p_layout->set_value(p_section, "dock_split_" + itos(i + 1), vsplits[i]->get_split_offset());
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
}
}
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
for (int i = 0; i < hsplits.size(); i++) {
p_layout->set_value(p_section, "dock_hsplit_" + itos(i + 1), hsplits[i]->get_split_offset());
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
}
Improve editor state persistence
2023-05-11 04:17:03 +02:00
// Save FileSystemDock state.
p_layout->set_value(p_section, "dock_filesystem_split", FileSystemDock::get_singleton()->get_split_offset());
p_layout->set_value(p_section, "dock_filesystem_display_mode", FileSystemDock::get_singleton()->get_display_mode());
p_layout->set_value(p_section, "dock_filesystem_file_sort", FileSystemDock::get_singleton()->get_file_sort());
p_layout->set_value(p_section, "dock_filesystem_file_list_display_mode", FileSystemDock::get_singleton()->get_file_list_display_mode());
PackedStringArray selected_files = FileSystemDock::get_singleton()->get_selected_paths();
p_layout->set_value(p_section, "dock_filesystem_selected_paths", selected_files);
Vector<String> uncollapsed_paths = FileSystemDock::get_singleton()->get_uncollapsed_paths();
p_layout->set_value(p_section, "dock_filesystem_uncollapsed_paths", uncollapsed_paths);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
}
Improve editor state persistence
2023-05-11 04:17:03 +02:00
void EditorNode::_save_open_scenes_to_config(Ref<ConfigFile> p_layout) {
PackedStringArray scenes;
Restore scenes on startup, issue 2385
2017-11-25 00:32:54 +01:00
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
String path = editor_data.get_scene_path(i);
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 10:42:46 +01:00
if (path.is_empty()) {
Restore scenes on startup, issue 2385
2017-11-25 00:32:54 +01:00
continue;
}
scenes.push_back(path);
}
Improve editor state persistence
2023-05-11 04:17:03 +02:00
p_layout->set_value(EDITOR_NODE_CONFIG_SECTION, "open_scenes", scenes);
String currently_edited_scene_path = editor_data.get_scene_path(editor_data.get_edited_scene());
Fix current-scene update
2023-07-27 07:45:53 +02:00
p_layout->set_value(EDITOR_NODE_CONFIG_SECTION, "current_scene", currently_edited_scene_path);
Restore scenes on startup, issue 2385
2017-11-25 00:32:54 +01:00
}
Improve editor state persistence
2023-05-11 04:17:03 +02:00
void EditorNode::save_editor_layout_delayed() {
editor_layout_save_delay_timer->start();
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
}
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
void EditorNode::_dock_split_dragged(int ofs) {
Improve editor state persistence
2023-05-11 04:17:03 +02:00
editor_layout_save_delay_timer->start();
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
}
Improve editor state persistence
2023-05-11 04:17:03 +02:00
void EditorNode::_load_editor_layout() {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
Ref<ConfigFile> config;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
config.instantiate();
Rename String `plus_file` to `path_join`
2022-08-30 02:34:01 +02:00
Error err = config->load(EditorPaths::get_singleton()->get_project_settings_dir().path_join("editor_layout.cfg"));
Uncollapse res:// by default
2023-05-26 12:07:06 +02:00
if (err != OK) { // No config.
Uncollapse favorites by default in the editor FileSystem dock
2023-07-28 00:46:31 +02:00
// If config is not found, expand the res:// folder and favorites by default.
Uncollapse res:// by default
2023-05-26 12:07:06 +02:00
TreeItem *root = FileSystemDock::get_singleton()->get_tree_control()->get_item_with_metadata("res://", 0);
if (root) {
root->set_collapsed(false);
}
Uncollapse favorites by default in the editor FileSystem dock
2023-07-28 00:46:31 +02:00
TreeItem *favorites = FileSystemDock::get_singleton()->get_tree_control()->get_item_with_metadata("Favorites", 0);
if (favorites) {
favorites->set_collapsed(false);
}
Allow to override the default editor layout
2016-01-11 22:23:45 +01:00
if (overridden_default_layout >= 0) {
_layout_menu_option(overridden_default_layout);
}
return;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
}
Editor layouts menu
2015-11-22 19:11:17 +01:00
_load_docks_from_config(config, "docks");
Improve editor state persistence
2023-05-11 04:17:03 +02:00
_load_open_scenes_from_config(config);
_load_central_editor_layout_from_config(config);
Editor: Skip loading main scene if restore_scenes_on_load is used
2018-09-21 05:14:04 +02:00
Editor layouts menu
2015-11-22 19:11:17 +01:00
editor_data.set_plugin_window_layout(config);
}
Prevent docks to be reset to first tab when switching dock visibility
2022-02-13 14:16:12 +01:00
void EditorNode::_update_dock_slots_visibility(bool p_keep_selected_tabs) {
Added fullscreen and distraction free modes
2016-05-30 20:29:43 +02:00
if (!docks_visible) {
for (int i = 0; i < DOCK_SLOT_MAX; i++) {
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
dock_slot[i]->hide();
Added fullscreen and distraction free modes
2016-05-30 20:29:43 +02:00
}
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
for (int i = 0; i < vsplits.size(); i++) {
vsplits[i]->hide();
Added fullscreen and distraction free modes
2016-05-30 20:29:43 +02:00
}
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
Added fullscreen and distraction free modes
2016-05-30 20:29:43 +02:00
right_hsplit->hide();
} else {
for (int i = 0; i < DOCK_SLOT_MAX; i++) {
fix dock visibility issues
2023-10-28 17:08:59 +02:00
int first_tab_visible = -1;
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
for (int j = 0; j < dock_slot[i]->get_tab_count(); j++) {
Make `TabContainer` use `TabBar` internally
2022-03-02 15:37:10 +01:00
if (!dock_slot[i]->is_tab_hidden(j)) {
fix dock visibility issues
2023-10-28 17:08:59 +02:00
first_tab_visible = j;
break;
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
}
}
fix dock visibility issues
2023-10-28 17:08:59 +02:00
if (first_tab_visible >= 0) {
Added fullscreen and distraction free modes
2016-05-30 20:29:43 +02:00
dock_slot[i]->show();
fix dock visibility issues
2023-10-28 17:08:59 +02:00
if (p_keep_selected_tabs) {
int current_tab = dock_slot[i]->get_current_tab();
if (dock_slot[i]->is_tab_hidden(current_tab)) {
dock_slot[i]->set_block_signals(true);
dock_slot[i]->select_next_available();
dock_slot[i]->set_block_signals(false);
}
} else {
dock_slot[i]->set_block_signals(true);
dock_slot[i]->set_current_tab(first_tab_visible);
dock_slot[i]->set_block_signals(false);
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
} else {
Added fullscreen and distraction free modes
2016-05-30 20:29:43 +02:00
dock_slot[i]->hide();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Added fullscreen and distraction free modes
2016-05-30 20:29:43 +02:00
}
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
for (int i = 0; i < vsplits.size(); i++) {
fix dock visibility issues
2023-10-28 17:08:59 +02:00
bool in_use = dock_slot[i * 2 + 0]->is_visible() || dock_slot[i * 2 + 1]->is_visible();
vsplits[i]->set_visible(in_use);
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
}
Fixed right dock dragger not disappearing when there is no docks there.
2017-12-22 19:49:14 +01:00
fix dock visibility issues
2023-10-28 17:08:59 +02:00
right_hsplit->set_visible(right_l_vsplit->is_visible() || right_r_vsplit->is_visible());
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
}
}
Drag to rearrange Tabs and TabContainer
2018-02-07 14:01:45 +01:00
void EditorNode::_dock_tab_changed(int p_tab) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Update visibility but don't set current tab.
fix dock visibility issues
2023-10-28 17:08:59 +02:00
_update_dock_slots_visibility(true);
Drag to rearrange Tabs and TabContainer
2018-02-07 14:01:45 +01:00
}
Add multi window code and shader editors
2022-11-02 15:23:25 +01:00
void EditorNode::_restore_floating_dock(const Dictionary &p_dock_dump, Control *p_dock, int p_slot_index) {
WindowWrapper *wrapper = Object::cast_to<WindowWrapper>(p_dock);
if (!wrapper) {
_dock_make_float(p_dock, p_slot_index, false);
wrapper = floating_docks[floating_docks.size() - 1];
}
wrapper->restore_window_from_saved_position(
p_dock_dump.get("window_rect", Rect2i()),
p_dock_dump.get("window_screen", -1),
p_dock_dump.get("window_screen_rect", Rect2i()));
}
Editor layouts menu
2015-11-22 19:11:17 +01:00
void EditorNode::_load_docks_from_config(Ref<ConfigFile> p_layout, const String &p_section) {
Add multi window code and shader editors
2022-11-02 15:23:25 +01:00
Dictionary floating_docks_dump = p_layout->get_value(p_section, "dock_floating", Dictionary());
bool restore_window_on_load = EDITOR_GET("interface/multi_window/restore_windows_on_load");
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
for (int i = 0; i < DOCK_SLOT_MAX; i++) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!p_layout->has_section_key(p_section, "dock_" + itos(i + 1))) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
Editor layouts menu
2015-11-22 19:11:17 +01:00
Vector<String> names = String(p_layout->get_value(p_section, "dock_" + itos(i + 1))).split(",");
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
Fix that the History Dock appears before other Docks in old projects Newly introduced docks, that are not apparent in old projects should be positioned after the ones in the project-config-file. This way it seems to be less irritating.
2022-11-25 02:31:06 +01:00
for (int j = names.size() - 1; j >= 0; j--) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
String name = names[j];
Add multi window code and shader editors
2022-11-02 15:23:25 +01:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// FIXME: Find it, in a horribly inefficient way.
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
int atidx = -1;
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
Control *node = nullptr;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
for (int k = 0; k < DOCK_SLOT_MAX; k++) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!dock_slot[k]->has_node(name)) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Convert Object::cast_to() to the static version Currently we rely on some undefined behavior when Object->cast_to() gets called with a Null pointer. This used to work fine with GCC < 6 but newer versions of GCC remove all codepaths in which the this pointer is Null. However, the non-static cast_to() was supposed to be null safe. This patch makes cast_to() Null safe and removes the now redundant Null checks where they existed. It is explained in this article: https://www.viva64.com/en/b/0226/
2017-08-24 22:58:51 +02:00
node = Object::cast_to<Control>(dock_slot[k]->get_node(name));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!node) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
atidx = k;
break;
}
Add multi window code and shader editors
2022-11-02 15:23:25 +01:00
if (atidx == -1) {
// Try floating docks.
for (WindowWrapper *wrapper : floating_docks) {
if (wrapper->get_meta("dock_name") == name) {
if (restore_window_on_load && floating_docks_dump.has(name)) {
_restore_floating_dock(floating_docks_dump[name], wrapper, i);
} else {
fix load floating dock layout
2023-10-03 21:36:53 +02:00
atidx = wrapper->get_meta("dock_slot");
node = wrapper->get_wrapped_control();
wrapper->set_window_enabled(false);
Add multi window code and shader editors
2022-11-02 15:23:25 +01:00
}
fix load floating dock layout
2023-10-03 21:36:53 +02:00
break;
Add multi window code and shader editors
2022-11-02 15:23:25 +01:00
}
}
fix load floating dock layout
2023-10-03 21:36:53 +02:00
}
if (!node) {
Add multi window code and shader editors
2022-11-02 15:23:25 +01:00
// Well, it's not anywhere.
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
Editor layouts menu
2015-11-22 19:11:17 +01:00
if (atidx == i) {
Fix that the History Dock appears before other Docks in old projects Newly introduced docks, that are not apparent in old projects should be positioned after the ones in the project-config-file. This way it seems to be less irritating.
2022-11-25 02:31:06 +01:00
dock_slot[i]->move_child(node, 0);
Add multi window code and shader editors
2022-11-02 15:23:25 +01:00
} else if (atidx != -1) {
fix dock visibility issues
2023-10-28 17:08:59 +02:00
dock_slot[i]->move_tab_from_tab_container(dock_slot[atidx], dock_slot[atidx]->get_tab_idx_from_control(node), 0);
Add multi window code and shader editors
2022-11-02 15:23:25 +01:00
}
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
Add multi window code and shader editors
2022-11-02 15:23:25 +01:00
WindowWrapper *wrapper = Object::cast_to<WindowWrapper>(node);
if (restore_window_on_load && floating_docks_dump.has(name)) {
fix dock visibility issues
2023-10-28 17:08:59 +02:00
if (!dock_slot[i]->is_tab_hidden(dock_slot[i]->get_tab_idx_from_control(node))) {
_restore_floating_dock(floating_docks_dump[name], node, i);
}
Add multi window code and shader editors
2022-11-02 15:23:25 +01:00
} else if (wrapper) {
fix load floating dock layout
2023-10-03 21:36:53 +02:00
wrapper->set_window_enabled(false);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
}
}
Move the FileSystem dock layout properties to the per-project layout file
2019-02-25 23:39:49 +01:00
Improve editor state persistence
2023-05-11 04:17:03 +02:00
if (!p_layout->has_section_key(p_section, "dock_" + itos(i + 1) + "_selected_tab_idx")) {
continue;
}
Allow sorting files by type
2020-10-07 21:56:53 +02:00
Improve editor state persistence
2023-05-11 04:17:03 +02:00
int selected_tab_idx = p_layout->get_value(p_section, "dock_" + itos(i + 1) + "_selected_tab_idx");
if (selected_tab_idx >= 0 && selected_tab_idx < dock_slot[i]->get_tab_count()) {
dock_slot[i]->call_deferred("set_current_tab", selected_tab_idx);
}
Include filesystem dock split offset in editor layouts Cherry-picked from 2ac89f65403c606ad9a3cdf65e591cb375faf024
2017-01-25 02:46:44 +01:00
}
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
for (int i = 0; i < vsplits.size(); i++) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!p_layout->has_section_key(p_section, "dock_split_" + itos(i + 1))) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
Editor layouts menu
2015-11-22 19:11:17 +01:00
int ofs = p_layout->get_value(p_section, "dock_split_" + itos(i + 1));
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
vsplits[i]->set_split_offset(ofs);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
}
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
for (int i = 0; i < hsplits.size(); i++) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!p_layout->has_section_key(p_section, "dock_hsplit_" + itos(i + 1))) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Editor layouts menu
2015-11-22 19:11:17 +01:00
int ofs = p_layout->get_value(p_section, "dock_hsplit_" + itos(i + 1));
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
hsplits[i]->set_split_offset(ofs);
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
}
fix dock visibility issues
2023-10-28 17:08:59 +02:00
_update_dock_slots_visibility(false);
Improve editor state persistence
2023-05-11 04:17:03 +02:00
// FileSystemDock.
if (p_layout->has_section_key(p_section, "dock_filesystem_split")) {
int fs_split_ofs = p_layout->get_value(p_section, "dock_filesystem_split");
FileSystemDock::get_singleton()->set_split_offset(fs_split_ofs);
}
if (p_layout->has_section_key(p_section, "dock_filesystem_display_mode")) {
FileSystemDock::DisplayMode dock_filesystem_display_mode = FileSystemDock::DisplayMode(int(p_layout->get_value(p_section, "dock_filesystem_display_mode")));
FileSystemDock::get_singleton()->set_display_mode(dock_filesystem_display_mode);
}
if (p_layout->has_section_key(p_section, "dock_filesystem_file_sort")) {
FileSystemDock::FileSortOption dock_filesystem_file_sort = FileSystemDock::FileSortOption(int(p_layout->get_value(p_section, "dock_filesystem_file_sort")));
FileSystemDock::get_singleton()->set_file_sort(dock_filesystem_file_sort);
}
if (p_layout->has_section_key(p_section, "dock_filesystem_file_list_display_mode")) {
FileSystemDock::FileListDisplayMode dock_filesystem_file_list_display_mode = FileSystemDock::FileListDisplayMode(int(p_layout->get_value(p_section, "dock_filesystem_file_list_display_mode")));
FileSystemDock::get_singleton()->set_file_list_display_mode(dock_filesystem_file_list_display_mode);
}
if (p_layout->has_section_key(p_section, "dock_filesystem_selected_paths")) {
PackedStringArray dock_filesystem_selected_paths = p_layout->get_value(p_section, "dock_filesystem_selected_paths");
for (int i = 0; i < dock_filesystem_selected_paths.size(); i++) {
FileSystemDock::get_singleton()->select_file(dock_filesystem_selected_paths[i]);
}
}
// Restore collapsed state of FileSystemDock.
Uncollapse res:// by default
2023-05-26 12:07:06 +02:00
PackedStringArray uncollapsed_tis;
Improve editor state persistence
2023-05-11 04:17:03 +02:00
if (p_layout->has_section_key(p_section, "dock_filesystem_uncollapsed_paths")) {
Uncollapse res:// by default
2023-05-26 12:07:06 +02:00
uncollapsed_tis = p_layout->get_value(p_section, "dock_filesystem_uncollapsed_paths");
} else {
uncollapsed_tis = { "res://" };
}
if (!uncollapsed_tis.is_empty()) {
Improve editor state persistence
2023-05-11 04:17:03 +02:00
for (int i = 0; i < uncollapsed_tis.size(); i++) {
TreeItem *uncollapsed_ti = FileSystemDock::get_singleton()->get_tree_control()->get_item_with_metadata(uncollapsed_tis[i], 0);
if (uncollapsed_ti) {
uncollapsed_ti->set_collapsed(false);
}
}
FileSystemDock::get_singleton()->get_tree_control()->queue_redraw();
}
Editor layouts menu
2015-11-22 19:11:17 +01:00
}
fixes for dock motion
2015-06-14 05:41:08 +02:00
Improve editor state persistence
2023-05-11 04:17:03 +02:00
void EditorNode::_save_central_editor_layout_to_config(Ref<ConfigFile> p_config_file) {
// Bottom panel.
int center_split_offset = center_split->get_split_offset();
p_config_file->set_value(EDITOR_NODE_CONFIG_SECTION, "center_split_offset", center_split_offset);
int selected_bottom_panel_item_idx = -1;
for (int i = 0; i < bottom_panel_items.size(); i++) {
Revert "Remember only permanent bottom tabs" This reverts commit 5dde57e95827806101cede5d46391f2bd4b9150c.
2023-06-23 15:23:36 +02:00
if (bottom_panel_items[i].button->is_pressed()) {
Improve editor state persistence
2023-05-11 04:17:03 +02:00
selected_bottom_panel_item_idx = i;
break;
}
}
if (selected_bottom_panel_item_idx != -1) {
p_config_file->set_value(EDITOR_NODE_CONFIG_SECTION, "selected_bottom_panel_item", selected_bottom_panel_item_idx);
Handle contextual editors gracefully when restoring layout
2023-06-23 15:46:06 +02:00
} else {
p_config_file->set_value(EDITOR_NODE_CONFIG_SECTION, "selected_bottom_panel_item", Variant());
Improve editor state persistence
2023-05-11 04:17:03 +02:00
}
// Debugger tab.
int selected_default_debugger_tab_idx = EditorDebuggerNode::get_singleton()->get_default_debugger()->get_current_debugger_tab();
p_config_file->set_value(EDITOR_NODE_CONFIG_SECTION, "selected_default_debugger_tab_idx", selected_default_debugger_tab_idx);
// Main editor (plugin).
int selected_main_editor_idx = -1;
for (int i = 0; i < main_editor_buttons.size(); i++) {
if (main_editor_buttons[i]->is_pressed()) {
selected_main_editor_idx = i;
break;
}
}
if (selected_main_editor_idx != -1) {
p_config_file->set_value(EDITOR_NODE_CONFIG_SECTION, "selected_main_editor_idx", selected_main_editor_idx);
Handle contextual editors gracefully when restoring layout
2023-06-23 15:46:06 +02:00
} else {
p_config_file->set_value(EDITOR_NODE_CONFIG_SECTION, "selected_main_editor_idx", Variant());
Improve editor state persistence
2023-05-11 04:17:03 +02:00
}
}
void EditorNode::_load_central_editor_layout_from_config(Ref<ConfigFile> p_config_file) {
// Bottom panel.
Collapse bottom panel if there is no active tab
2023-07-05 23:04:14 +02:00
bool has_active_tab = false;
Improve editor state persistence
2023-05-11 04:17:03 +02:00
if (p_config_file->has_section_key(EDITOR_NODE_CONFIG_SECTION, "selected_bottom_panel_item")) {
int selected_bottom_panel_item_idx = p_config_file->get_value(EDITOR_NODE_CONFIG_SECTION, "selected_bottom_panel_item");
if (selected_bottom_panel_item_idx >= 0 && selected_bottom_panel_item_idx < bottom_panel_items.size()) {
Handle contextual editors gracefully when restoring layout
2023-06-23 15:46:06 +02:00
// Make sure we don't try to open contextual editors which are not enabled in the current context.
if (bottom_panel_items[selected_bottom_panel_item_idx].button->is_visible()) {
_bottom_panel_switch(true, selected_bottom_panel_item_idx);
Collapse bottom panel if there is no active tab
2023-07-05 23:04:14 +02:00
has_active_tab = true;
Handle contextual editors gracefully when restoring layout
2023-06-23 15:46:06 +02:00
}
Improve editor state persistence
2023-05-11 04:17:03 +02:00
}
}
Collapse bottom panel if there is no active tab
2023-07-05 23:04:14 +02:00
if (p_config_file->has_section_key(EDITOR_NODE_CONFIG_SECTION, "center_split_offset")) {
int center_split_offset = p_config_file->get_value(EDITOR_NODE_CONFIG_SECTION, "center_split_offset");
center_split->set_split_offset(center_split_offset);
// If there is no active tab we need to collapse the panel.
if (!has_active_tab) {
bottom_panel_items[0].control->show(); // _bottom_panel_switch() can collapse only visible tabs.
_bottom_panel_switch(false, 0);
}
}
Improve editor state persistence
2023-05-11 04:17:03 +02:00
// Debugger tab.
if (p_config_file->has_section_key(EDITOR_NODE_CONFIG_SECTION, "selected_default_debugger_tab_idx")) {
int selected_default_debugger_tab_idx = p_config_file->get_value(EDITOR_NODE_CONFIG_SECTION, "selected_default_debugger_tab_idx");
EditorDebuggerNode::get_singleton()->get_default_debugger()->switch_to_debugger(selected_default_debugger_tab_idx);
}
// Main editor (plugin).
if (p_config_file->has_section_key(EDITOR_NODE_CONFIG_SECTION, "selected_main_editor_idx")) {
int selected_main_editor_idx = p_config_file->get_value(EDITOR_NODE_CONFIG_SECTION, "selected_main_editor_idx");
if (selected_main_editor_idx >= 0 && selected_main_editor_idx < main_editor_buttons.size()) {
callable_mp(this, &EditorNode::editor_select).call_deferred(selected_main_editor_idx);
}
}
}
void EditorNode::_load_open_scenes_from_config(Ref<ConfigFile> p_layout) {
-Ability to open resources in the same window -Plenty of fixes and improvements to new inspector -Fixes that were needed to make inspector work better
2018-05-17 23:02:16 +02:00
if (!bool(EDITOR_GET("interface/scene_tabs/restore_scenes_on_load"))) {
Restore scenes on startup, issue 2385
2017-11-25 00:32:54 +01:00
return;
}
Improve editor state persistence
2023-05-11 04:17:03 +02:00
if (!p_layout->has_section(EDITOR_NODE_CONFIG_SECTION) ||
!p_layout->has_section_key(EDITOR_NODE_CONFIG_SECTION, "open_scenes")) {
Restore scenes on startup, issue 2385
2017-11-25 00:32:54 +01:00
return;
}
restoring_scenes = true;
Improve editor state persistence
2023-05-11 04:17:03 +02:00
PackedStringArray scenes = p_layout->get_value(EDITOR_NODE_CONFIG_SECTION, "open_scenes");
Restore scenes on startup, issue 2385
2017-11-25 00:32:54 +01:00
for (int i = 0; i < scenes.size(); i++) {
load_scene(scenes[i]);
}
Improve editor state persistence
2023-05-11 04:17:03 +02:00
if (p_layout->has_section_key(EDITOR_NODE_CONFIG_SECTION, "current_scene")) {
String current_scene = p_layout->get_value(EDITOR_NODE_CONFIG_SECTION, "current_scene");
int current_scene_idx = scenes.find(current_scene);
Fix current-scene update
2023-07-27 07:45:53 +02:00
if (current_scene_idx >= 0) {
Extract editor scene tabs into their own component
2023-08-24 12:24:29 +02:00
_set_current_scene(current_scene_idx);
Fix current-scene update
2023-07-27 07:45:53 +02:00
}
Improve editor state persistence
2023-05-11 04:17:03 +02:00
}
save_editor_layout_delayed();
Restore scenes on startup, issue 2385
2017-11-25 00:32:54 +01:00
restoring_scenes = false;
}
Editor: Skip loading main scene if restore_scenes_on_load is used
2018-09-21 05:14:04 +02:00
bool EditorNode::has_scenes_in_session() {
if (!bool(EDITOR_GET("interface/scene_tabs/restore_scenes_on_load"))) {
return false;
}
Ref<ConfigFile> config;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
config.instantiate();
Rename String `plus_file` to `path_join`
2022-08-30 02:34:01 +02:00
Error err = config->load(EditorPaths::get_singleton()->get_project_settings_dir().path_join("editor_layout.cfg"));
Editor: Skip loading main scene if restore_scenes_on_load is used
2018-09-21 05:14:04 +02:00
if (err != OK) {
return false;
}
Improve editor state persistence
2023-05-11 04:17:03 +02:00
if (!config->has_section(EDITOR_NODE_CONFIG_SECTION) || !config->has_section_key(EDITOR_NODE_CONFIG_SECTION, "open_scenes")) {
Editor: Skip loading main scene if restore_scenes_on_load is used
2018-09-21 05:14:04 +02:00
return false;
}
Improve editor state persistence
2023-05-11 04:17:03 +02:00
Array scenes = config->get_value(EDITOR_NODE_CONFIG_SECTION, "open_scenes");
Rename empty() to is_empty()
2020-12-15 13:04:21 +01:00
return !scenes.is_empty();
Editor: Skip loading main scene if restore_scenes_on_load is used
2018-09-21 05:14:04 +02:00
}
Ensure main scene is set when running on device
2019-03-22 02:08:28 +01:00
bool EditorNode::ensure_main_scene(bool p_from_native) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
pick_main_scene->set_meta("from_native", p_from_native); // Whether from play button or native run.
Remove duplicate project settings definitions
2022-10-20 15:43:17 +02:00
String main_scene = GLOBAL_GET("application/run/main_scene");
Ensure main scene is set when running on device
2019-03-22 02:08:28 +01:00
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 10:42:46 +01:00
if (main_scene.is_empty()) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
current_menu_option = -1;
Ensure main scene is set when running on device
2019-03-22 02:08:28 +01:00
pick_main_scene->set_text(TTR("No main scene has ever been defined, select one?\nYou can change it later in \"Project Settings\" under the 'application' category."));
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
pick_main_scene->popup_centered();
Added 'Select Current' option when user is prompted to select main scene after clicking play
2021-07-06 16:10:07 +02:00
if (editor_data.get_edited_scene_root()) {
select_current_scene_button->set_disabled(false);
select_current_scene_button->grab_focus();
} else {
select_current_scene_button->set_disabled(true);
}
Ensure main scene is set when running on device
2019-03-22 02:08:28 +01:00
return false;
}
if (!FileAccess::exists(main_scene)) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
current_menu_option = -1;
Ensure main scene is set when running on device
2019-03-22 02:08:28 +01:00
pick_main_scene->set_text(vformat(TTR("Selected scene '%s' does not exist, select a valid one?\nYou can change it later in \"Project Settings\" under the 'application' category."), main_scene));
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
pick_main_scene->popup_centered();
Ensure main scene is set when running on device
2019-03-22 02:08:28 +01:00
return false;
}
if (ResourceLoader::get_resource_type(main_scene) != "PackedScene") {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
current_menu_option = -1;
Ensure main scene is set when running on device
2019-03-22 02:08:28 +01:00
pick_main_scene->set_text(vformat(TTR("Selected scene '%s' is not a scene file, select a valid one?\nYou can change it later in \"Project Settings\" under the 'application' category."), main_scene));
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
pick_main_scene->popup_centered();
Ensure main scene is set when running on device
2019-03-22 02:08:28 +01:00
return false;
}
return true;
}
Implement Extension Loader * Extensions are now scanned and loaded on demand. * Extensions found are cached into a file that is used to load them (which is also exported). * Editor will ask to restart when an extension requires core functionality. * Editor will attempt to load extensions always before importing or loading scenes. This ensures extensions can register the relevant types.
2021-08-20 20:32:56 +02:00
void EditorNode::_immediate_dialog_confirmed() {
immediate_dialog_confirmed = true;
}
Implementation of tool to automatically upgrade and re-save meshes
2023-10-19 13:31:26 +02:00
bool EditorNode::immediate_confirmation_dialog(const String &p_text, const String &p_ok_text, const String &p_cancel_text, uint32_t p_wrap_width) {
Implement Extension Loader * Extensions are now scanned and loaded on demand. * Extensions found are cached into a file that is used to load them (which is also exported). * Editor will ask to restart when an extension requires core functionality. * Editor will attempt to load extensions always before importing or loading scenes. This ensures extensions can register the relevant types.
2021-08-20 20:32:56 +02:00
ConfirmationDialog *cd = memnew(ConfirmationDialog);
cd->set_text(p_text);
Add ok_button_text to AcceptDialog and cancel_button_text to ConfirmationDialog
2022-07-08 02:31:19 +02:00
cd->set_ok_button_text(p_ok_text);
cd->set_cancel_button_text(p_cancel_text);
Implementation of tool to automatically upgrade and re-save meshes
2023-10-19 13:31:26 +02:00
if (p_wrap_width > 0) {
cd->set_autowrap(true);
cd->get_label()->set_custom_minimum_size(Size2(p_wrap_width, 0) * EDSCALE);
}
Implement Extension Loader * Extensions are now scanned and loaded on demand. * Extensions found are cached into a file that is used to load them (which is also exported). * Editor will ask to restart when an extension requires core functionality. * Editor will attempt to load extensions always before importing or loading scenes. This ensures extensions can register the relevant types.
2021-08-20 20:32:56 +02:00
cd->connect("confirmed", callable_mp(singleton, &EditorNode::_immediate_dialog_confirmed));
singleton->gui_base->add_child(cd);
cd->popup_centered();
while (true) {
OS::get_singleton()->delay_usec(1);
DisplayServer::get_singleton()->process_events();
Main::iteration();
if (singleton->immediate_dialog_confirmed || !cd->is_visible()) {
break;
}
}
memdelete(cd);
return singleton->immediate_dialog_confirmed;
}
Move editor class and plugin registrations to a dedicated file
2022-05-01 11:57:36 +02:00
void EditorNode::cleanup() {
_init_callbacks.clear();
}
Editor layouts menu
2015-11-22 19:11:17 +01:00
void EditorNode::_update_layouts_menu() {
editor_layouts->clear();
Allow to override the default editor layout
2016-01-11 22:23:45 +01:00
overridden_default_layout = -1;
Added `reset_size` method to `Control` and `Window` classes
2021-11-20 09:04:57 +01:00
editor_layouts->reset_size();
-customizable shortcuts in editor -editor settings now save to .tres instead of .xml -buttons can now hold a shortcut
2016-06-05 02:31:29 +02:00
editor_layouts->add_shortcut(ED_SHORTCUT("layout/save", TTR("Save Layout")), SETTINGS_LAYOUT_SAVE);
Fix layout menu labels and shortcuts
2016-06-19 19:53:27 +02:00
editor_layouts->add_shortcut(ED_SHORTCUT("layout/delete", TTR("Delete Layout")), SETTINGS_LAYOUT_DELETE);
Editor layouts menu
2015-11-22 19:11:17 +01:00
editor_layouts->add_separator();
Fix layout menu labels and shortcuts
2016-06-19 19:53:27 +02:00
editor_layouts->add_shortcut(ED_SHORTCUT("layout/default", TTR("Default")), SETTINGS_LAYOUT_DEFAULT);
Editor layouts menu
2015-11-22 19:11:17 +01:00
Ref<ConfigFile> config;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
config.instantiate();
Use new XDG folders to dehardcode paths
2017-11-17 21:48:24 +01:00
Error err = config->load(EditorSettings::get_singleton()->get_editor_layouts_config());
Editor layouts menu
2015-11-22 19:11:17 +01:00
if (err != OK) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
return; // No config.
Editor layouts menu
2015-11-22 19:11:17 +01:00
}
List<String> layouts;
config.ptr()->get_sections(&layouts);
Use const references where possible for List range iterators
2021-07-24 15:46:25 +02:00
for (const String &layout : layouts) {
Modified editor strings to be translatable in the future
2016-05-04 03:25:37 +02:00
if (layout == TTR("Default")) {
Allow to override the default editor layout
2016-01-11 22:23:45 +01:00
editor_layouts->remove_item(editor_layouts->get_item_index(SETTINGS_LAYOUT_DEFAULT));
overridden_default_layout = editor_layouts->get_item_count();
}
editor_layouts->add_item(layout);
Editor layouts menu
2015-11-22 19:11:17 +01:00
}
}
void EditorNode::_layout_menu_option(int p_id) {
switch (p_id) {
case SETTINGS_LAYOUT_SAVE: {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
current_menu_option = p_id;
Modified editor strings to be translatable in the future
2016-05-04 03:25:37 +02:00
layout_dialog->set_title(TTR("Save Layout"));
Add ok_button_text to AcceptDialog and cancel_button_text to ConfirmationDialog
2022-07-08 02:31:19 +02:00
layout_dialog->set_ok_button_text(TTR("Save"));
editor save/delete layout dialog with layout list
2019-05-30 20:16:40 +02:00
layout_dialog->set_name_line_enabled(true);
Do not add child twice and set initial focus
2022-12-21 22:26:11 +01:00
layout_dialog->popup_centered();
Editor layouts menu
2015-11-22 19:11:17 +01:00
} break;
case SETTINGS_LAYOUT_DELETE: {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
current_menu_option = p_id;
Modified editor strings to be translatable in the future
2016-05-04 03:25:37 +02:00
layout_dialog->set_title(TTR("Delete Layout"));
Add ok_button_text to AcceptDialog and cancel_button_text to ConfirmationDialog
2022-07-08 02:31:19 +02:00
layout_dialog->set_ok_button_text(TTR("Delete"));
editor save/delete layout dialog with layout list
2019-05-30 20:16:40 +02:00
layout_dialog->set_name_line_enabled(false);
Do not add child twice and set initial focus
2022-12-21 22:26:11 +01:00
layout_dialog->popup_centered();
Editor layouts menu
2015-11-22 19:11:17 +01:00
} break;
case SETTINGS_LAYOUT_DEFAULT: {
Allow to override the default editor layout
2016-01-11 22:23:45 +01:00
_load_docks_from_config(default_layout, "docks");
Improve editor state persistence
2023-05-11 04:17:03 +02:00
_save_editor_layout();
Editor layouts menu
2015-11-22 19:11:17 +01:00
} break;
default: {
Ref<ConfigFile> config;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
config.instantiate();
Use new XDG folders to dehardcode paths
2017-11-17 21:48:24 +01:00
Error err = config->load(EditorSettings::get_singleton()->get_editor_layouts_config());
Editor layouts menu
2015-11-22 19:11:17 +01:00
if (err != OK) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
return; // No config.
Editor layouts menu
2015-11-22 19:11:17 +01:00
}
Fix editor layouts broken after 9a7ff65
2015-12-14 16:44:15 +01:00
_load_docks_from_config(config, editor_layouts->get_item_text(p_id));
Improve editor state persistence
2023-05-11 04:17:03 +02:00
_save_editor_layout();
Editor layouts menu
2015-11-22 19:11:17 +01:00
}
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
}
Scene tab closing refactor
2022-10-14 20:41:05 +02:00
void EditorNode::_proceed_closing_scene_tabs() {
List<String>::Element *E = tabs_to_close.front();
if (!E) {
if (_is_closing_editor()) {
current_menu_option = tab_closing_menu_option;
_menu_option_confirm(tab_closing_menu_option, true);
} else {
current_menu_option = -1;
save_confirmation->hide();
}
return;
}
String scene_to_close = E->get();
tabs_to_close.pop_front();
int tab_idx = -1;
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
if (editor_data.get_scene_path(i) == scene_to_close) {
tab_idx = i;
break;
}
}
ERR_FAIL_COND(tab_idx < 0);
_scene_tab_closed(tab_idx);
}
bool EditorNode::_is_closing_editor() const {
return tab_closing_menu_option == FILE_QUIT || tab_closing_menu_option == RUN_PROJECT_MANAGER || tab_closing_menu_option == RELOAD_CURRENT_PROJECT;
}
Extract editor scene tabs into their own component
2023-08-24 12:24:29 +02:00
void EditorNode::_scene_tab_closed(int p_tab) {
current_menu_option = SCENE_TAB_CLOSE;
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
tab_closing_idx = p_tab;
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
Node *scene = editor_data.get_edited_scene_root(p_tab);
Fix crash on closing [empty](*) scene tab
2017-07-09 20:48:39 +02:00
if (!scene) {
_discard_changes();
return;
}
Fix checking unsaved changes only in current scene
2016-05-02 13:40:44 +02:00
Check for unsaved changes when closing a scene
2023-04-05 15:45:41 +02:00
String scene_filename = scene->get_scene_file_path();
String unsaved_message;
if (EditorUndoRedoManager::get_singleton()->is_history_unsaved(editor_data.get_scene_history_id(p_tab))) {
if (scene_filename.is_empty()) {
unsaved_message = TTR("This scene was never saved.");
} else {
Display time of last save in the unsaved changes confirmation editor dialog When multitasking, this makes it clearer whether closing a window with unsaved changes is potentially dangerous or not.
2023-08-25 01:18:05 +02:00
// Consider editor startup to be a point of saving, so that when you
// close and reopen the editor, you don't get an excessively long
// "modified X hours ago".
const uint64_t last_modified_seconds = Time::get_singleton()->get_unix_time_from_system() - MAX(started_timestamp, FileAccess::get_modified_time(scene->get_scene_file_path()));
String last_modified_string;
if (last_modified_seconds < 120) {
last_modified_string = vformat(TTRN("%d second ago", "%d seconds ago", last_modified_seconds), last_modified_seconds);
} else if (last_modified_seconds < 7200) {
last_modified_string = vformat(TTRN("%d minute ago", "%d minutes ago", last_modified_seconds / 60), last_modified_seconds / 60);
} else {
last_modified_string = vformat(TTRN("%d hour ago", "%d hours ago", last_modified_seconds / 3600), last_modified_seconds / 3600);
}
unsaved_message = vformat(TTR("Scene \"%s\" has unsaved changes.\nLast saved: %s."), scene_filename, last_modified_string);
Check for unsaved changes when closing a scene
2023-04-05 15:45:41 +02:00
}
} else {
// Check if any plugin has unsaved changes in that scene.
for (int i = 0; i < editor_data.get_editor_plugin_count(); i++) {
unsaved_message = editor_data.get_editor_plugin(i)->get_unsaved_status(scene_filename);
if (!unsaved_message.is_empty()) {
break;
}
}
}
if (!unsaved_message.is_empty()) {
Extract editor scene tabs into their own component
2023-08-24 12:24:29 +02:00
if (scene_tabs->get_current_tab() != p_tab) {
_set_current_scene(p_tab);
Scene tab closing refactor
2022-10-14 20:41:05 +02:00
}
Extract editor scene tabs into their own component
2023-08-24 12:24:29 +02:00
save_confirmation->set_ok_button_text(TTR("Save & Close"));
save_confirmation->set_text(unsaved_message + "\n\n" + TTR("Save before closing?"));
Adjust size of some dialogs
2023-04-10 17:04:47 +02:00
save_confirmation->reset_size();
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
save_confirmation->popup_centered();
Ask confirmation on closing a scene tab
2015-11-19 14:15:17 +01:00
} else {
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 06:15:39 +02:00
_discard_changes();
Ask confirmation on closing a scene tab
2015-11-19 14:15:17 +01:00
}
Restore scenes on startup, issue 2385
2017-11-25 00:32:54 +01:00
Improve editor state persistence
2023-05-11 04:17:03 +02:00
save_editor_layout_delayed();
Extract editor scene tabs into their own component
2023-08-24 12:24:29 +02:00
scene_tabs->update_scene_tabs();
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
}
Import 3D Scene Improvements -=-=-=-=-=-=-=-=-=-=-=-=-=-=- -If re-importing from the "dependency changed" dialog, edited scene will keep the local changes. -Imported scene will keep track of changes in the source asset -Geometry changes in source geometry or nodes with a different transform will be updated. -Materials will be kept if changed locally. -New nodes added will be kept -If nodes were reparented or renamed, they will still keep track -Deleted notes will be restored, use the -noimp option to avoid this. -In general, you can trust that if you do local modifications to the imported scene, they will not be erased after re-import. -Erasing your changes is done by re-importing from the "Re-Import" menu, re-opening the "Import 3D Scene" dialog. This wil re-import fresh. Overall, This should allow you to work on a scene and see changes made to 3D assets in real-time. So Please test!!
2014-06-19 07:23:03 +02:00
Revert "Remember only permanent bottom tabs" This reverts commit 5dde57e95827806101cede5d46391f2bd4b9150c.
2023-06-23 15:23:36 +02:00
Button *EditorNode::add_bottom_panel_item(String p_text, Control *p_item) {
Remove ToolButton in favor of Button ToolButton has no redeeming differences with Button; it's just a Button with the Flat property enabled by default. Removing it avoids some confusion when creating GUIs. Existing ToolButtons will be converted to Buttons, but the Flat property won't be enabled automatically. This closes https://github.com/godotengine/godot-proposals/issues/1081.
2020-06-19 20:49:04 +02:00
Button *tb = memnew(Button);
tb->set_flat(true);
Remove Signal connect binds Remove the optional argument p_binds from `Object::connect` since it was deprecated by Callable.bind(). Changed all uses of it to Callable.bind()
2022-07-28 22:56:41 +02:00
tb->connect("toggled", callable_mp(this, &EditorNode::_bottom_panel_switch).bind(bottom_panel_items.size()));
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
tb->set_text(p_text);
tb->set_toggle_mode(true);
tb->set_focus_mode(Control::FOCUS_NONE);
bottom_panel_vb->add_child(p_item);
Rename raise() to move_to_front()
2022-04-10 20:52:55 +02:00
bottom_panel_hb->move_to_front();
Added small icon to expand the bottom panel (and shortcut too)
2018-07-16 03:38:14 +02:00
bottom_panel_hb_editors->add_child(tb);
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
p_item->set_v_size_flags(Control::SIZE_EXPAND_FILL);
p_item->hide();
BottomPanelItem bpi;
bpi.button = tb;
bpi.control = p_item;
bpi.name = p_text;
bottom_panel_items.push_back(bpi);
return tb;
}
void EditorNode::hide_bottom_panel() {
Make bottom panel only try to hide editors when they're visible
2019-03-16 07:39:49 +01:00
for (int i = 0; i < bottom_panel_items.size(); i++) {
if (bottom_panel_items[i].control->is_visible()) {
_bottom_panel_switch(false, i);
break;
}
}
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
}
void EditorNode::make_bottom_panel_item_visible(Control *p_item) {
for (int i = 0; i < bottom_panel_items.size(); i++) {
if (bottom_panel_items[i].control == p_item) {
_bottom_panel_switch(true, i);
break;
}
}
}
void EditorNode::raise_bottom_panel_item(Control *p_item) {
for (int i = 0; i < bottom_panel_items.size(); i++) {
if (bottom_panel_items[i].control == p_item) {
Rename raise() to move_to_front()
2022-04-10 20:52:55 +02:00
bottom_panel_items[i].button->move_to_front();
Reduce unnecessary COW on Vector by make writing explicit This commit makes operator[] on Vector const and adds a write proxy to it. From now on writes to Vectors need to happen through the .write proxy. So for instance: Vector<int> vec; vec.push_back(10); std::cout << vec[0] << std::endl; vec.write[0] = 20; Failing to use the .write proxy will cause a compilation error. In addition COWable datatypes can now embed a CowData pointer to their data. This means that String, CharString, and VMap no longer use or derive from Vector. _ALWAYS_INLINE_ and _FORCE_INLINE_ are now equivalent for debug and non-debug builds. This is a lot faster for Vector in the editor and while running tests. The reason why this difference used to exist is because force-inlined methods used to give a bad debugging experience. After extensive testing with modern compilers this is no longer the case.
2018-07-25 03:11:03 +02:00
SWAP(bottom_panel_items.write[i], bottom_panel_items.write[bottom_panel_items.size() - 1]);
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
break;
}
}
for (int i = 0; i < bottom_panel_items.size(); i++) {
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
bottom_panel_items[i].button->disconnect("toggled", callable_mp(this, &EditorNode::_bottom_panel_switch));
Remove Signal connect binds Remove the optional argument p_binds from `Object::connect` since it was deprecated by Callable.bind(). Changed all uses of it to Callable.bind()
2022-07-28 22:56:41 +02:00
bottom_panel_items[i].button->connect("toggled", callable_mp(this, &EditorNode::_bottom_panel_switch).bind(i));
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
}
}
Adds EditorPlugin::remove_control_from_bottom_panel() Also renames `add_control_to_bottom_dock` to `add_control_to_bottom_panel` so that it would be clear that the removal functions are different too.
2016-02-28 20:58:17 +01:00
void EditorNode::remove_bottom_panel_item(Control *p_item) {
for (int i = 0; i < bottom_panel_items.size(); i++) {
if (bottom_panel_items[i].control == p_item) {
New API for visibility in both CanvasItem and Spatial visible (property) - access set_visible(bool) is_visible() is_visible_in_tree() - true when visible and parents visible show() hide() - for convenience
2017-01-13 14:45:50 +01:00
if (p_item->is_visible_in_tree()) {
Make bottom panel only try to hide editors when they're visible
2019-03-16 07:39:49 +01:00
_bottom_panel_switch(false, i);
Adds EditorPlugin::remove_control_from_bottom_panel() Also renames `add_control_to_bottom_dock` to `add_control_to_bottom_panel` so that it would be clear that the removal functions are different too.
2016-02-28 20:58:17 +01:00
}
bottom_panel_vb->remove_child(bottom_panel_items[i].control);
Added small icon to expand the bottom panel (and shortcut too)
2018-07-16 03:38:14 +02:00
bottom_panel_hb_editors->remove_child(bottom_panel_items[i].button);
Adds EditorPlugin::remove_control_from_bottom_panel() Also renames `add_control_to_bottom_dock` to `add_control_to_bottom_panel` so that it would be clear that the removal functions are different too.
2016-02-28 20:58:17 +01:00
memdelete(bottom_panel_items[i].button);
Rename `remove()` to `remove_at()` when removing by index
2021-07-04 00:17:03 +02:00
bottom_panel_items.remove_at(i);
Adds EditorPlugin::remove_control_from_bottom_panel() Also renames `add_control_to_bottom_dock` to `add_control_to_bottom_panel` so that it would be clear that the removal functions are different too.
2016-02-28 20:58:17 +01:00
break;
}
}
for (int i = 0; i < bottom_panel_items.size(); i++) {
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
bottom_panel_items[i].button->disconnect("toggled", callable_mp(this, &EditorNode::_bottom_panel_switch));
Remove Signal connect binds Remove the optional argument p_binds from `Object::connect` since it was deprecated by Callable.bind(). Changed all uses of it to Callable.bind()
2022-07-28 22:56:41 +02:00
bottom_panel_items[i].button->connect("toggled", callable_mp(this, &EditorNode::_bottom_panel_switch).bind(i));
Adds EditorPlugin::remove_control_from_bottom_panel() Also renames `add_control_to_bottom_dock` to `add_control_to_bottom_panel` so that it would be clear that the removal functions are different too.
2016-02-28 20:58:17 +01:00
}
}
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
void EditorNode::_bottom_panel_switch(bool p_enable, int p_idx) {
Fix broken bottom panel switching
2023-01-30 21:50:00 +01:00
if (bottom_panel_updating) {
return;
}
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
ERR_FAIL_INDEX(p_idx, bottom_panel_items.size());
Make bottom panel only try to hide editors when they're visible
2019-03-16 07:39:49 +01:00
if (bottom_panel_items[p_idx].control->is_visible() == p_enable) {
return;
}
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
if (p_enable) {
Fix AnimationTrackEditor doesn't open when selecting AnimationPlayer
2023-02-06 19:00:33 +01:00
bottom_panel_updating = true;
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
for (int i = 0; i < bottom_panel_items.size(); i++) {
bottom_panel_items[i].button->set_pressed(i == p_idx);
New API for visibility in both CanvasItem and Spatial visible (property) - access set_visible(bool) is_visible() is_visible_in_tree() - true when visible and parents visible show() hide() - for convenience
2017-01-13 14:45:50 +01:00
bottom_panel_items[i].control->set_visible(i == p_idx);
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
if (EditorDebuggerNode::get_singleton() == bottom_panel_items[p_idx].control) {
// This is the debug panel which uses tabs, so the top section should be smaller.
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
bottom_panel->add_theme_style_override("panel", theme->get_stylebox(SNAME("BottomPanelDebuggerOverride"), EditorStringName(EditorStyles)));
fixed bottom panel debugger exception - make it work in combination with the border for tabs - fixed updating when changing theme
2017-09-18 21:06:55 +02:00
} else {
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
bottom_panel->add_theme_style_override("panel", theme->get_stylebox(SNAME("BottomPanel"), EditorStringName(EditorStyles)));
fixed bottom panel debugger exception - make it work in combination with the border for tabs - fixed updating when changing theme
2017-09-18 21:06:55 +02:00
}
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
center_split->set_dragger_visibility(SplitContainer::DRAGGER_VISIBLE);
center_split->set_collapsed(false);
Added small icon to expand the bottom panel (and shortcut too)
2018-07-16 03:38:14 +02:00
if (bottom_panel_raise->is_pressed()) {
top_split->hide();
}
bottom_panel_raise->show();
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
} else {
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
bottom_panel->add_theme_style_override("panel", theme->get_stylebox(SNAME("BottomPanel"), EditorStringName(EditorStyles)));
Make bottom panel only try to hide editors when they're visible
2019-03-16 07:39:49 +01:00
bottom_panel_items[p_idx].button->set_pressed(false);
bottom_panel_items[p_idx].control->set_visible(false);
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
center_split->set_dragger_visibility(SplitContainer::DRAGGER_HIDDEN);
center_split->set_collapsed(true);
Added small icon to expand the bottom panel (and shortcut too)
2018-07-16 03:38:14 +02:00
bottom_panel_raise->hide();
if (bottom_panel_raise->is_pressed()) {
top_split->show();
}
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
}
}
Added fullscreen and distraction free modes
2016-05-30 20:29:43 +02:00
void EditorNode::set_docks_visible(bool p_show) {
docks_visible = p_show;
Prevent docks to be reset to first tab when switching dock visibility
2022-02-13 14:16:12 +01:00
_update_dock_slots_visibility(true);
Added fullscreen and distraction free modes
2016-05-30 20:29:43 +02:00
}
bool EditorNode::get_docks_visible() const {
return docks_visible;
}
-Add a distraction free mode button (so users know it's there) -Made distaction free not hide the top bar, it's more loss than gain to hide it -Fix fullscreen toggling and added a menu option for it so it's also visible in settings.
2016-09-13 14:46:17 +02:00
void EditorNode::_toggle_distraction_free_mode() {
Unify usage of GLOBAL/EDITOR_GET
2022-10-18 16:43:37 +02:00
if (EDITOR_GET("interface/editor/separate_distraction_mode")) {
Separate fullscreen state for scene & script editor
2017-04-25 13:48:35 +02:00
int screen = -1;
for (int i = 0; i < editor_table.size(); i++) {
if (editor_plugin_screen == editor_table[i]) {
screen = i;
break;
}
}
if (screen == EDITOR_SCRIPT) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
script_distraction_free = !script_distraction_free;
set_distraction_free_mode(script_distraction_free);
Separate fullscreen state for scene & script editor
2017-04-25 13:48:35 +02:00
} else {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
scene_distraction_free = !scene_distraction_free;
set_distraction_free_mode(scene_distraction_free);
Separate fullscreen state for scene & script editor
2017-04-25 13:48:35 +02:00
}
} else {
set_distraction_free_mode(distraction_free->is_pressed());
}
-Add a distraction free mode button (so users know it's there) -Made distaction free not hide the top bar, it's more loss than gain to hide it -Fix fullscreen toggling and added a menu option for it so it's also visible in settings.
2016-09-13 14:46:17 +02:00
}
Added fullscreen and distraction free modes
2016-05-30 20:29:43 +02:00
void EditorNode::set_distraction_free_mode(bool p_enter) {
-Add a distraction free mode button (so users know it's there) -Made distaction free not hide the top bar, it's more loss than gain to hide it -Fix fullscreen toggling and added a menu option for it so it's also visible in settings.
2016-09-13 14:46:17 +02:00
distraction_free->set_pressed(p_enter);
Added fullscreen and distraction free modes
2016-05-30 20:29:43 +02:00
if (p_enter) {
if (docks_visible) {
set_docks_visible(false);
}
} else {
set_docks_visible(true);
}
}
Add a getter and property for the editor distraction-free mode
2020-05-31 19:58:15 +02:00
bool EditorNode::is_distraction_free_mode_enabled() const {
-Add a distraction free mode button (so users know it's there) -Made distaction free not hide the top bar, it's more loss than gain to hide it -Fix fullscreen toggling and added a menu option for it so it's also visible in settings.
2016-09-13 14:46:17 +02:00
return distraction_free->is_pressed();
Added fullscreen and distraction free modes
2016-05-30 20:29:43 +02:00
}
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
void EditorNode::add_control_to_dock(DockSlot p_slot, Control *p_control) {
ERR_FAIL_INDEX(p_slot, DOCK_SLOT_MAX);
dock_slot[p_slot]->add_child(p_control);
_update_dock_slots_visibility();
}
void EditorNode::remove_control_from_dock(Control *p_control) {
Editor: Fix `remove_control_from_dock` fails when dock is floating.
2023-10-17 19:14:26 +02:00
// If the dock is floating, close it first.
for (WindowWrapper *wrapper : floating_docks) {
if (p_control == wrapper->get_wrapped_control()) {
wrapper->set_window_enabled(false);
break;
}
}
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
Control *dock = nullptr;
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
for (int i = 0; i < DOCK_SLOT_MAX; i++) {
if (p_control->get_parent() == dock_slot[i]) {
dock = dock_slot[i];
break;
}
}
[Editor] Replace `ERR_FAIL_COND` with `ERR_FAIL_NULL` where applicable
2023-09-09 17:24:40 +02:00
ERR_FAIL_NULL_MSG(dock, "Control was not in dock.");
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
dock->remove_child(p_control);
_update_dock_slots_visibility();
}
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 16:46:08 +02:00
Variant EditorNode::drag_resource(const Ref<Resource> &p_res, Control *p_from) {
Control *drag_control = memnew(Control);
some class renames TextureFrame -> TextureRect Patch9Frame -> NinePatchRect ColorFrame -> ColorRect
2017-01-12 22:27:27 +01:00
TextureRect *drag_preview = memnew(TextureRect);
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 16:46:08 +02:00
Label *label = memnew(Label);
Texture refactor -Texture renamed to Texture2D -TextureLayered as base now inherits 2Darray, cubemap and cubemap array -Removed all references to flags in textures (they will go in the shader) -Texture3D gone for now (will come back later done properly) -Create base rasterizer for RenderDevice, RasterizerRD
2019-06-11 20:43:37 +02:00
Ref<Texture2D> preview;
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 16:46:08 +02:00
{
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// TODO: make proper previews
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
Ref<ImageTexture> texture = theme->get_icon(SNAME("FileBigThumb"), EditorStringName(EditorIcons));
Rename Texture.get_data() to get_image()
2021-03-28 13:32:17 +02:00
Ref<Image> img = texture->get_image();
Removal of Image from Variant, converted to a Resource.
2017-05-17 12:36:47 +02:00
img = img->duplicate();
Rename `Tabs` to `TabBar`
2021-10-17 18:55:44 +02:00
img->resize(48, 48); // meh
Add static methods for creating Image and ImageTexture
2022-05-04 01:49:20 +02:00
preview = ImageTexture::create_from_image(img);
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 16:46:08 +02:00
}
drag_preview->set_texture(preview);
drag_control->add_child(drag_preview);
if (p_res->get_path().is_resource_file()) {
label->set_text(p_res->get_path().get_file());
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 10:42:46 +01:00
} else if (!p_res->get_name().is_empty()) {
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 16:46:08 +02:00
label->set_text(p_res->get_name());
} else {
ObjectTypeDB was renamed to ClassDB. Types are meant to be more generic to Variant. All usages of "type" to refer to classes were renamed to "class" ClassDB has been exposed to GDScript. OBJ_TYPE() macro is now GDCLASS()
2017-01-03 03:03:46 +01:00
label->set_text(p_res->get_class());
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 16:46:08 +02:00
}
drag_control->add_child(label);
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
p_from->set_drag_preview(drag_control); // Wait until it enters scene.
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 16:46:08 +02:00
Rename [gs]et_pos to [gs]et_position for Controls Control set_pos -> set_position Control set_global_pos -> set_global_position [gs]et_mouse_pos -> [gs]et_mouse_position [gs]et_global_mouse_pos -> [gs]et_global_mouse_position fixes #8005
2017-03-29 17:29:38 +02:00
label->set_position(Point2((preview->get_width() - label->get_minimum_size().width) / 2, preview->get_height()));
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 16:46:08 +02:00
Dictionary drag_data;
drag_data["type"] = "resource";
drag_data["resource"] = p_res;
drag_data["from"] = p_from;
return drag_data;
}
Improve file/folder drag preview on filesystem dock Added icons for files/folders in drag preview Fixed folders getting an empty string label Don't show "1 more file(s)" label instead of the file Added "more folders" case if moving folders exclusively Merged drag_files and drag_files_and_dirs to reduce code duplication Simplified get_drag_data_fw and removed commented out code
2017-10-25 00:09:04 +02:00
Variant EditorNode::drag_files_and_dirs(const Vector<String> &p_paths, Control *p_from) {
bool has_folder = false;
bool has_file = false;
for (int i = 0; i < p_paths.size(); i++) {
bool is_folder = p_paths[i].ends_with("/");
has_folder |= is_folder;
has_file |= !is_folder;
}
int max_rows = 6;
Minor visual adjustment in drag preview of the scene and file tree editors
2019-09-30 18:36:49 +02:00
int num_rows = p_paths.size() > max_rows ? max_rows - 1 : p_paths.size(); // Don't waste a row to say "1 more file" - list it instead.
Improve file/folder drag preview on filesystem dock Added icons for files/folders in drag preview Fixed folders getting an empty string label Don't show "1 more file(s)" label instead of the file Added "more folders" case if moving folders exclusively Merged drag_files and drag_files_and_dirs to reduce code duplication Simplified get_drag_data_fw and removed commented out code
2017-10-25 00:09:04 +02:00
VBoxContainer *vbox = memnew(VBoxContainer);
for (int i = 0; i < num_rows; i++) {
HBoxContainer *hbox = memnew(HBoxContainer);
TextureRect *icon = memnew(TextureRect);
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 16:46:08 +02:00
Label *label = memnew(Label);
Improve file/folder drag preview on filesystem dock Added icons for files/folders in drag preview Fixed folders getting an empty string label Don't show "1 more file(s)" label instead of the file Added "more folders" case if moving folders exclusively Merged drag_files and drag_files_and_dirs to reduce code duplication Simplified get_drag_data_fw and removed commented out code
2017-10-25 00:09:04 +02:00
if (p_paths[i].ends_with("/")) {
label->set_text(p_paths[i].substr(0, p_paths[i].length() - 1).get_file());
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
icon->set_texture(theme->get_icon(SNAME("Folder"), EditorStringName(EditorIcons)));
Improve file/folder drag preview on filesystem dock Added icons for files/folders in drag preview Fixed folders getting an empty string label Don't show "1 more file(s)" label instead of the file Added "more folders" case if moving folders exclusively Merged drag_files and drag_files_and_dirs to reduce code duplication Simplified get_drag_data_fw and removed commented out code
2017-10-25 00:09:04 +02:00
} else {
label->set_text(p_paths[i].get_file());
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
icon->set_texture(theme->get_icon(SNAME("File"), EditorStringName(EditorIcons)));
Improve file/folder drag preview on filesystem dock Added icons for files/folders in drag preview Fixed folders getting an empty string label Don't show "1 more file(s)" label instead of the file Added "more folders" case if moving folders exclusively Merged drag_files and drag_files_and_dirs to reduce code duplication Simplified get_drag_data_fw and removed commented out code
2017-10-25 00:09:04 +02:00
}
Minor visual adjustment in drag preview of the scene and file tree editors
2019-09-30 18:36:49 +02:00
icon->set_stretch_mode(TextureRect::STRETCH_KEEP_CENTERED);
Improve file/folder drag preview on filesystem dock Added icons for files/folders in drag preview Fixed folders getting an empty string label Don't show "1 more file(s)" label instead of the file Added "more folders" case if moving folders exclusively Merged drag_files and drag_files_and_dirs to reduce code duplication Simplified get_drag_data_fw and removed commented out code
2017-10-25 00:09:04 +02:00
icon->set_size(Size2(16, 16));
hbox->add_child(icon);
hbox->add_child(label);
vbox->add_child(hbox);
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 16:46:08 +02:00
}
Improve file/folder drag preview on filesystem dock Added icons for files/folders in drag preview Fixed folders getting an empty string label Don't show "1 more file(s)" label instead of the file Added "more folders" case if moving folders exclusively Merged drag_files and drag_files_and_dirs to reduce code duplication Simplified get_drag_data_fw and removed commented out code
2017-10-25 00:09:04 +02:00
if (p_paths.size() > num_rows) {
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 16:46:08 +02:00
Label *label = memnew(Label);
Improve file/folder drag preview on filesystem dock Added icons for files/folders in drag preview Fixed folders getting an empty string label Don't show "1 more file(s)" label instead of the file Added "more folders" case if moving folders exclusively Merged drag_files and drag_files_and_dirs to reduce code duplication Simplified get_drag_data_fw and removed commented out code
2017-10-25 00:09:04 +02:00
if (has_file && has_folder) {
label->set_text(vformat(TTR("%d more files or folders"), p_paths.size() - num_rows));
} else if (has_folder) {
label->set_text(vformat(TTR("%d more folders"), p_paths.size() - num_rows));
} else {
label->set_text(vformat(TTR("%d more files"), p_paths.size() - num_rows));
}
vbox->add_child(label);
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 16:46:08 +02:00
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
p_from->set_drag_preview(vbox); // Wait until it enters scene.
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 16:46:08 +02:00
Dictionary drag_data;
Improve file/folder drag preview on filesystem dock Added icons for files/folders in drag preview Fixed folders getting an empty string label Don't show "1 more file(s)" label instead of the file Added "more folders" case if moving folders exclusively Merged drag_files and drag_files_and_dirs to reduce code duplication Simplified get_drag_data_fw and removed commented out code
2017-10-25 00:09:04 +02:00
drag_data["type"] = has_folder ? "files_and_dirs" : "files";
drag_data["files"] = p_paths;
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 16:46:08 +02:00
drag_data["from"] = p_from;
return drag_data;
}
Make tool menu plugins use Callables for callback
2020-12-16 00:04:21 +01:00
void EditorNode::add_tool_menu_item(const String &p_name, const Callable &p_callback) {
Added tool menu functions in EditorPlugin
2018-03-17 02:50:35 +01:00
int idx = tool_menu->get_item_count();
tool_menu->add_item(p_name, TOOLS_CUSTOM);
Make tool menu plugins use Callables for callback
2020-12-16 00:04:21 +01:00
tool_menu->set_item_metadata(idx, p_callback);
Added tool menu functions in EditorPlugin
2018-03-17 02:50:35 +01:00
}
void EditorNode::add_tool_submenu_item(const String &p_name, PopupMenu *p_submenu) {
ERR_FAIL_NULL(p_submenu);
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
ERR_FAIL_COND(p_submenu->get_parent() != nullptr);
Added tool menu functions in EditorPlugin
2018-03-17 02:50:35 +01:00
tool_menu->add_child(p_submenu);
tool_menu->add_submenu_item(p_name, p_submenu->get_name(), TOOLS_CUSTOM);
}
void EditorNode::remove_tool_menu_item(const String &p_name) {
for (int i = 0; i < tool_menu->get_item_count(); i++) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (tool_menu->get_item_id(i) != TOOLS_CUSTOM) {
Added tool menu functions in EditorPlugin
2018-03-17 02:50:35 +01:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Added tool menu functions in EditorPlugin
2018-03-17 02:50:35 +01:00
if (tool_menu->get_item_text(i) == p_name) {
if (tool_menu->get_item_submenu(i) != "") {
Node *n = tool_menu->get_node(tool_menu->get_item_submenu(i));
tool_menu->remove_child(n);
memdelete(n);
}
tool_menu->remove_item(i);
Remove set_as_minsize()
2022-03-06 00:57:42 +01:00
tool_menu->reset_size();
Added tool menu functions in EditorPlugin
2018-03-17 02:50:35 +01:00
return;
}
}
}
move gltf export under scene menu
2022-04-06 14:41:04 +02:00
PopupMenu *EditorNode::get_export_as_menu() {
return export_as_menu;
}
Improvements to files_dropped signal
2022-04-10 21:25:24 +02:00
void EditorNode::_dropped_files(const Vector<String> &p_files) {
Add EditorInterface.get_selected_paths() Exposes the selected paths in the editor filesystem dock. Implements this proposal : https://github.com/godotengine/godot-proposals/issues/2424 Also renamed the old `get_selected_path` to `get_selected_directory` to better match the already existing get_current_path function.
2022-05-10 22:25:36 +02:00
String to_path = ProjectSettings::get_singleton()->globalize_path(FileSystemDock::get_singleton()->get_current_directory());
Editor: Drop files to copy to project.
2017-11-17 21:52:03 +01:00
Allow to drop folders onto editor
2019-03-25 22:39:45 +01:00
_add_dropped_files_recursive(p_files, to_path);
EditorFileSystem::get_singleton()->scan_changes();
}
void EditorNode::_add_dropped_files_recursive(const Vector<String> &p_files, String to_path) {
Make FileAccess and DirAccess classes reference counted.
2022-03-23 10:08:58 +01:00
Ref<DirAccess> dir = DirAccess::create(DirAccess::ACCESS_FILESYSTEM);
Add error checks for DirAccess creation.
2023-09-26 04:07:43 +02:00
ERR_FAIL_COND(dir.is_null());
Allow to drop folders onto editor
2019-03-25 22:39:45 +01:00
Editor: Drop files to copy to project.
2017-11-17 21:52:03 +01:00
for (int i = 0; i < p_files.size(); i++) {
String from = p_files[i];
Rename String `plus_file` to `path_join`
2022-08-30 02:34:01 +02:00
String to = to_path.path_join(from.get_file());
Allow to drop folders onto editor
2019-03-25 22:39:45 +01:00
if (dir->dir_exists(from)) {
Vector<String> sub_files;
Make FileAccess and DirAccess classes reference counted.
2022-03-23 10:08:58 +01:00
Ref<DirAccess> sub_dir = DirAccess::open(from);
Add error checks for DirAccess creation.
2023-09-26 04:07:43 +02:00
ERR_FAIL_COND(sub_dir.is_null());
Allow to drop folders onto editor
2019-03-25 22:39:45 +01:00
sub_dir->list_dir_begin();
String next_file = sub_dir->get_next();
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 10:42:46 +01:00
while (!next_file.is_empty()) {
Allow to drop folders onto editor
2019-03-25 22:39:45 +01:00
if (next_file == "." || next_file == "..") {
next_file = sub_dir->get_next();
continue;
}
Rename String `plus_file` to `path_join`
2022-08-30 02:34:01 +02:00
sub_files.push_back(from.path_join(next_file));
Allow to drop folders onto editor
2019-03-25 22:39:45 +01:00
next_file = sub_dir->get_next();
}
Rename empty() to is_empty()
2020-12-15 13:04:21 +01:00
if (!sub_files.is_empty()) {
Allow to drop folders onto editor
2019-03-25 22:39:45 +01:00
dir->make_dir(to);
_add_dropped_files_recursive(sub_files, to);
}
continue;
}
Editor: Drop files to copy to project.
2017-11-17 21:52:03 +01:00
dir->copy(from, to);
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
}
Changed import workflow -Rearrange favorites in fs dock with drag and drop -Removed import -> sub-scene, moved to scenetree contextual menu -Removed import -> re-import , moved and integrated to FS dock -Added ability in FS dock to re-import more than one resource simultaneously -Added ability to drag from native filesystem explorer to Godot, only works on Windows though -Removed scene reimport merge options, never worked well. Eventually merging materials should be re-added -Added ability to set custom root node type when importing scenes -Re-Import is now automatic, can be configured back to manual in editor settings -Added resource previews in property list for many resource types
2016-05-27 19:18:40 +02:00
}
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
-Add visible IO errors when closing a file fails due to it being locked (most likely on windows), closes #4760
2016-06-13 15:10:50 +02:00
void EditorNode::_file_access_close_error_notify(const String &p_str) {
Make certain editor callbacks thread-safe
2023-05-19 18:45:22 +02:00
callable_mp_static(&EditorNode::_file_access_close_error_notify_impl).bind(p_str).call_deferred();
}
void EditorNode::_file_access_close_error_notify_impl(const String &p_str) {
Add missing i18n to various strings
2022-03-07 14:50:02 +01:00
add_io_error(vformat(TTR("Unable to write to file '%s', file in use, locked or lacking permissions."), p_str));
-Add visible IO errors when closing a file fails due to it being locked (most likely on windows), closes #4760
2016-06-13 15:10:50 +02:00
}
Changed import workflow -Rearrange favorites in fs dock with drag and drop -Removed import -> sub-scene, moved to scenetree contextual menu -Removed import -> re-import , moved and integrated to FS dock -Added ability in FS dock to re-import more than one resource simultaneously -Added ability to drag from native filesystem explorer to Godot, only works on Windows though -Removed scene reimport merge options, never worked well. Eventually merging materials should be re-added -Added ability to set custom root node type when importing scenes -Re-Import is now automatic, can be configured back to manual in editor settings -Added resource previews in property list for many resource types
2016-05-27 19:18:40 +02:00
Reimport bone attachment fixes: Assign bone_idx to GLTF importer to fix serialization. Notifies Skeletons and BoneAttachments when reimporting. Removes usage of NOTIFICATION_NODE_RECACHE_REQUESTED
2023-09-28 06:32:32 +02:00
// Since we felt that a bespoke NOTIFICATION might not be desirable, this function
// provides the hardcoded callbacks to address known bugs which occur on certain
// nodes during reimport.
// Ideally, we should probably agree on a standardized method name which could be
// called from here instead.
void EditorNode::_notify_scene_updated(Node *p_node) {
Skeleton3D *skel_3d = Object::cast_to<Skeleton3D>(p_node);
if (skel_3d) {
skel_3d->reset_bone_poses();
} else {
BoneAttachment3D *attachment = Object::cast_to<BoneAttachment3D>(p_node);
if (attachment) {
attachment->notify_rebind_required();
}
}
for (int i = 0; i < p_node->get_child_count(); i++) {
_notify_scene_updated(p_node->get_child(i));
}
}
Editor properly reloads scenes if they changed on disk or were reimported
2016-06-28 23:53:31 +02:00
void EditorNode::reload_scene(const String &p_path) {
int scene_idx = -1;
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
if (editor_data.get_scene_path(i) == p_path) {
scene_idx = i;
break;
}
}
int current_tab = editor_data.get_edited_scene();
if (scene_idx == -1) {
if (get_edited_scene()) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Scene is not open, so at it might be instantiated. We'll refresh the whole scene later.
Add EditorUndoRedoManager singleton
2022-12-23 23:53:16 +01:00
EditorUndoRedoManager::get_singleton()->clear_history(false, editor_data.get_current_edited_scene_history_id());
Editor properly reloads scenes if they changed on disk or were reimported
2016-06-28 23:53:31 +02:00
}
return;
}
if (current_tab == scene_idx) {
editor_data.apply_changes_in_editors();
Improve editor state persistence
2023-05-11 04:17:03 +02:00
_save_editor_states(p_path);
Editor properly reloads scenes if they changed on disk or were reimported
2016-06-28 23:53:31 +02:00
}
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 05:36:23 +02:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Reload scene.
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 05:36:23 +02:00
_remove_scene(scene_idx, false);
Fix issues regarding reload of resources in imported scenes. Closes #10017
2017-08-31 23:57:03 +02:00
load_scene(p_path, true, false, true, true);
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 05:36:23 +02:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Adjust index so tab is back a the previous position.
Editor properly reloads scenes if they changed on disk or were reimported
2016-06-28 23:53:31 +02:00
editor_data.move_edited_scene_to_index(scene_idx);
Add EditorUndoRedoManager singleton
2022-12-23 23:53:16 +01:00
EditorUndoRedoManager::get_singleton()->clear_history(false, editor_data.get_scene_history_id(scene_idx));
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 05:36:23 +02:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Recover the tab.
Editor properly reloads scenes if they changed on disk or were reimported
2016-06-28 23:53:31 +02:00
scene_tabs->set_current_tab(current_tab);
}
Update instances of scenes which have been reimported.
2022-01-30 22:31:32 +01:00
void EditorNode::find_all_instances_inheriting_path_in_node(Node *p_root, Node *p_node, const String &p_instance_path, List<Node *> &p_instance_list) {
String scene_file_path = p_node->get_scene_file_path();
// This is going to get messy...
if (p_node->get_scene_file_path() == p_instance_path) {
p_instance_list.push_back(p_node);
} else {
Node *current_node = p_node;
Ref<SceneState> inherited_state = current_node->get_scene_inherited_state();
while (inherited_state.is_valid()) {
String inherited_path = inherited_state->get_path();
if (inherited_path == p_instance_path) {
p_instance_list.push_back(p_node);
break;
}
inherited_state = inherited_state->get_base_scene_state();
}
}
for (int i = 0; i < p_node->get_child_count(); i++) {
Node *child = p_node->get_child(i);
find_all_instances_inheriting_path_in_node(p_root, child, p_instance_path, p_instance_list);
}
}
void EditorNode::reload_instances_with_path_in_edited_scenes(const String &p_instance_path) {
int original_edited_scene_idx = editor_data.get_edited_scene();
HashMap<int, List<Node *>> edited_scene_map;
// Walk through each opened scene to get a global list of all instances which match
// the current reimported scenes.
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
if (editor_data.get_scene_path(i) != p_instance_path) {
Node *edited_scene_root = editor_data.get_edited_scene_root(i);
if (edited_scene_root) {
List<Node *> valid_nodes;
find_all_instances_inheriting_path_in_node(edited_scene_root, edited_scene_root, p_instance_path, valid_nodes);
if (valid_nodes.size() > 0) {
edited_scene_map[i] = valid_nodes;
}
}
}
}
if (edited_scene_map.size() > 0) {
// Reload the new instance.
Error err;
Fix CACHE_MODE_REPLACE
2023-10-29 23:37:54 +01:00
Ref<PackedScene> instance_scene_packed_scene = ResourceLoader::load(p_instance_path, "", ResourceFormatLoader::CACHE_MODE_REPLACE, &err);
Update instances of scenes which have been reimported.
2022-01-30 22:31:32 +01:00
ERR_FAIL_COND(err != OK);
ERR_FAIL_COND(instance_scene_packed_scene.is_null());
HashMap<String, Ref<PackedScene>> local_scene_cache;
local_scene_cache[p_instance_path] = instance_scene_packed_scene;
for (const KeyValue<int, List<Node *>> &edited_scene_map_elem : edited_scene_map) {
// Set the current scene.
int current_scene_idx = edited_scene_map_elem.key;
editor_data.set_edited_scene(current_scene_idx);
Node *current_edited_scene = editor_data.get_edited_scene_root(current_scene_idx);
// Clear the history for this tab (should we allow history to be retained?).
EditorUndoRedoManager::get_singleton()->clear_history();
// Update the version
editor_data.is_scene_changed(current_scene_idx);
for (Node *original_node : edited_scene_map_elem.value) {
// Walk the tree for the current node and extract relevant diff data, storing it in the modification table.
// For additional nodes which are part of the current scene, they get added to the addition table.
HashMap<NodePath, ModificationNodeEntry> modification_table;
List<AdditiveNodeEntry> addition_list;
update_diff_data_for_node(current_edited_scene, original_node, original_node, modification_table, addition_list);
// Disconnect all relevant connections, all connections from and persistent connections to.
for (const KeyValue<NodePath, ModificationNodeEntry> &modification_table_entry : modification_table) {
for (Connection conn : modification_table_entry.value.connections_from) {
conn.signal.get_object()->disconnect(conn.signal.get_name(), conn.callable);
}
for (ConnectionWithNodePath cwnp : modification_table_entry.value.connections_to) {
Connection conn = cwnp.connection;
if (conn.flags & CONNECT_PERSIST) {
conn.signal.get_object()->disconnect(conn.signal.get_name(), conn.callable);
}
}
}
// Store all the paths for any selected nodes which are ancestors of the node we're replacing.
List<NodePath> selected_node_paths;
for (Node *selected_node : editor_selection->get_selected_node_list()) {
if (selected_node == original_node || original_node->is_ancestor_of(selected_node)) {
selected_node_paths.push_back(original_node->get_path_to(selected_node));
editor_selection->remove_node(selected_node);
}
}
// Remove all nodes which were added as additional elements (they will be restored later).
for (AdditiveNodeEntry additive_node_entry : addition_list) {
Node *addition_node = additive_node_entry.node;
addition_node->get_parent()->remove_child(addition_node);
}
// Clear ownership of the nodes (kind of hack to workaround an issue with
// replace_by when called on nodes in other tabs).
List<Node *> nodes_owned_by_original_node;
original_node->get_owned_by(original_node, &nodes_owned_by_original_node);
for (Node *owned_node : nodes_owned_by_original_node) {
owned_node->set_owner(nullptr);
}
// Delete all the remaining node children.
while (original_node->get_child_count()) {
Node *child = original_node->get_child(0);
original_node->remove_child(child);
child->queue_free();
}
// Reset the editable instance state.
bool is_editable = true;
Node *owner = original_node->get_owner();
if (owner) {
is_editable = owner->is_editable_instance(original_node);
}
// Load a replacement scene for the node.
Ref<PackedScene> current_packed_scene;
if (original_node->get_scene_file_path() == p_instance_path) {
// If the node file name directly matches the scene we're replacing,
// just load it since we already cached it.
current_packed_scene = instance_scene_packed_scene;
} else {
// Otherwise, check the inheritance chain, reloading and caching any scenes
// we require along the way.
List<String> required_load_paths;
String scene_path = original_node->get_scene_file_path();
// Do we need to check if the paths are empty?
if (!scene_path.is_empty()) {
required_load_paths.push_front(scene_path);
}
Ref<SceneState> inherited_state = original_node->get_scene_inherited_state();
while (inherited_state.is_valid()) {
String inherited_path = inherited_state->get_path();
// Do we need to check if the paths are empty?
if (!inherited_path.is_empty()) {
required_load_paths.push_front(inherited_path);
}
inherited_state = inherited_state->get_base_scene_state();
}
// Ensure the inheritance chain is loaded in the correct order so that cache can
// be properly updated.
for (String path : required_load_paths) {
if (!local_scene_cache.find(path)) {
Fix CACHE_MODE_REPLACE
2023-10-29 23:37:54 +01:00
current_packed_scene = ResourceLoader::load(path, "", ResourceFormatLoader::CACHE_MODE_REPLACE, &err);
Update instances of scenes which have been reimported.
2022-01-30 22:31:32 +01:00
local_scene_cache[path] = current_packed_scene;
} else {
current_packed_scene = local_scene_cache[path];
}
}
}
ERR_FAIL_COND(current_packed_scene.is_null());
// Instantiate the node.
Node *instantiated_node = nullptr;
if (current_packed_scene.is_valid()) {
instantiated_node = current_packed_scene->instantiate(PackedScene::GEN_EDIT_STATE_INSTANCE);
}
[Editor] Replace `ERR_FAIL_COND` with `ERR_FAIL_NULL` where applicable
2023-09-09 17:24:40 +02:00
ERR_FAIL_NULL(instantiated_node);
Update instances of scenes which have been reimported.
2022-01-30 22:31:32 +01:00
bool original_node_is_displayed_folded = original_node->is_displayed_folded();
bool original_node_scene_instance_load_placeholder = original_node->get_scene_instance_load_placeholder();
// Update the name to match
instantiated_node->set_name(original_node->get_name());
// Is this replacing the edited root node?
String original_node_file_path = original_node->get_scene_file_path();
if (current_edited_scene == original_node) {
instantiated_node->set_scene_instance_state(original_node->get_scene_instance_state());
// Fix unsaved inherited scene
if (original_node_file_path.is_empty()) {
Ref<SceneState> state = current_packed_scene->get_state();
state->set_path(current_packed_scene->get_path());
instantiated_node->set_scene_inherited_state(state);
Fix path for unsaved inherited scenes.
2023-01-25 04:06:59 +01:00
instantiated_node->set_scene_file_path(String());
Update instances of scenes which have been reimported.
2022-01-30 22:31:32 +01:00
}
editor_data.set_edited_scene_root(instantiated_node);
current_edited_scene = instantiated_node;
if (original_node->is_inside_tree()) {
SceneTreeDock::get_singleton()->set_edited_scene(current_edited_scene);
original_node->get_tree()->set_edited_scene_root(instantiated_node);
}
}
// Replace the original node with the instantiated version.
original_node->replace_by(instantiated_node, false);
// Mark the old node for deletion.
original_node->queue_free();
// Restore the folded and placeholder state from the original node.
instantiated_node->set_display_folded(original_node_is_displayed_folded);
instantiated_node->set_scene_instance_load_placeholder(original_node_scene_instance_load_placeholder);
if (owner) {
Ref<SceneState> ss_inst = owner->get_scene_instance_state();
if (ss_inst.is_valid()) {
ss_inst->update_instance_resource(p_instance_path, current_packed_scene);
}
owner->set_editable_instance(instantiated_node, is_editable);
}
// Attempt to re-add all the additional nodes.
for (AdditiveNodeEntry additive_node_entry : addition_list) {
Node *parent_node = instantiated_node->get_node_or_null(additive_node_entry.parent);
if (!parent_node) {
parent_node = current_edited_scene;
}
parent_node->add_child(additive_node_entry.node);
parent_node->move_child(additive_node_entry.node, additive_node_entry.index);
// If the additive node's owner was the node which got replaced, update it.
if (additive_node_entry.owner == original_node) {
additive_node_entry.owner = instantiated_node;
}
additive_node_entry.node->set_owner(additive_node_entry.owner);
// If the parent node was lost, attempt to restore the original global transform.
{
Node2D *node_2d = Object::cast_to<Node2D>(additive_node_entry.node);
if (node_2d) {
node_2d->set_transform(additive_node_entry.transform_2d);
}
Node3D *node_3d = Object::cast_to<Node3D>(additive_node_entry.node);
if (node_3d) {
node_3d->set_transform(additive_node_entry.transform_3d);
}
}
Fix ownership bug on ancestor nodes when scene is reimported.
2023-02-22 19:07:36 +01:00
// Restore the ownership of its ancestors
for (KeyValue<Node *, Node *> &E : additive_node_entry.ownership_table) {
Node *current_ancestor = E.key;
Node *ancestor_owner = E.value;
if (ancestor_owner == original_node) {
ancestor_owner = instantiated_node;
}
current_ancestor->set_owner(ancestor_owner);
}
Update instances of scenes which have been reimported.
2022-01-30 22:31:32 +01:00
}
// Restore the selection.
if (selected_node_paths.size()) {
for (NodePath selected_node_path : selected_node_paths) {
Node *selected_node = instantiated_node->get_node_or_null(selected_node_path);
if (selected_node) {
editor_selection->add_node(selected_node);
}
}
editor_selection->update();
}
// Attempt to restore the modified properties and signals for the instantitated node and all its owned children.
for (KeyValue<NodePath, ModificationNodeEntry> &E : modification_table) {
NodePath new_current_path = E.key;
Node *modifiable_node = instantiated_node->get_node_or_null(new_current_path);
if (modifiable_node) {
// Get properties for this node.
List<PropertyInfo> pinfo;
modifiable_node->get_property_list(&pinfo);
Fix various typos with codespell And include #72377. Co-authored-by: Wiktor Kocielski <withaust@gmail.com>
2023-01-30 14:22:47 +01:00
// Get names of all valid property names (TODO: make this more efficient).
Update instances of scenes which have been reimported.
2022-01-30 22:31:32 +01:00
List<String> property_names;
for (const PropertyInfo &E2 : pinfo) {
if (E2.usage & PROPERTY_USAGE_STORAGE) {
property_names.push_back(E2.name);
}
}
// Restore the modified properties for this node.
for (const KeyValue<StringName, Variant> &E2 : E.value.property_table) {
if (property_names.find(E2.key)) {
modifiable_node->set(E2.key, E2.value);
}
}
// Restore the connections to other nodes.
for (const ConnectionWithNodePath &E2 : E.value.connections_to) {
Connection conn = E2.connection;
Fix various typos with codespell And include #72377. Co-authored-by: Wiktor Kocielski <withaust@gmail.com>
2023-01-30 14:22:47 +01:00
// Get the node the callable is targeting.
Update instances of scenes which have been reimported.
2022-01-30 22:31:32 +01:00
Node *target_node = cast_to<Node>(conn.callable.get_object());
// If the callable object no longer exists or is marked for deletion,
// attempt to reaccquire the closest match by using the node path
// we saved earlier.
if (!target_node || !target_node->is_queued_for_deletion()) {
target_node = modifiable_node->get_node_or_null(E2.node_path);
}
if (target_node) {
// Reconstruct the callable.
Callable new_callable = Callable(target_node, conn.callable.get_method());
if (!modifiable_node->is_connected(conn.signal.get_name(), new_callable)) {
ERR_FAIL_COND(modifiable_node->connect(conn.signal.get_name(), new_callable, conn.flags) != OK);
}
}
}
// Restore the connections from other nodes.
for (const Connection &E2 : E.value.connections_from) {
Connection conn = E2;
bool valid = modifiable_node->has_method(conn.callable.get_method()) || Ref<Script>(modifiable_node->get_script()).is_null() || Ref<Script>(modifiable_node->get_script())->has_method(conn.callable.get_method());
ERR_CONTINUE_MSG(!valid, vformat("Attempt to connect signal '%s.%s' to nonexistent method '%s.%s'.", conn.signal.get_object()->get_class(), conn.signal.get_name(), conn.callable.get_object()->get_class(), conn.callable.get_method()));
// Get the object which the signal is connected from.
Object *source_object = conn.signal.get_object();
if (source_object) {
ERR_FAIL_COND(source_object->connect(conn.signal.get_name(), Callable(modifiable_node, conn.callable.get_method()), conn.flags) != OK);
}
}
// Re-add the groups.
for (const Node::GroupInfo &E2 : E.value.groups) {
modifiable_node->add_to_group(E2.name, E2.persistent);
}
}
}
}
Reimport bone attachment fixes: Assign bone_idx to GLTF importer to fix serialization. Notifies Skeletons and BoneAttachments when reimporting. Removes usage of NOTIFICATION_NODE_RECACHE_REQUESTED
2023-09-28 06:32:32 +02:00
Update instances of scenes which have been reimported.
2022-01-30 22:31:32 +01:00
// Cleanup the history of the changes.
editor_history.cleanup_history();
Reimport bone attachment fixes: Assign bone_idx to GLTF importer to fix serialization. Notifies Skeletons and BoneAttachments when reimporting. Removes usage of NOTIFICATION_NODE_RECACHE_REQUESTED
2023-09-28 06:32:32 +02:00
_notify_scene_updated(current_edited_scene);
Update instances of scenes which have been reimported.
2022-01-30 22:31:32 +01:00
}
edited_scene_map.clear();
}
editor_data.set_edited_scene(original_edited_scene_idx);
_edit_current();
}
Likely with bugs and with some features are missing, as well as profiler support, but VisualScript should be more or less done!
2016-08-07 00:00:54 +02:00
int EditorNode::plugin_init_callback_count = 0;
void EditorNode::add_plugin_init_callback(EditorPluginInitializeCallback p_callback) {
ERR_FAIL_COND(plugin_init_callback_count == MAX_INIT_CALLBACKS);
plugin_init_callbacks[plugin_init_callback_count++] = p_callback;
}
EditorPluginInitializeCallback EditorNode::plugin_init_callbacks[EditorNode::MAX_INIT_CALLBACKS];
Added API version and hashing to ObjectTypeDB
2016-09-15 00:37:37 +02:00
int EditorNode::build_callback_count = 0;
void EditorNode::add_build_callback(EditorBuildCallback p_callback) {
ERR_FAIL_COND(build_callback_count == MAX_INIT_CALLBACKS);
build_callbacks[build_callback_count++] = p_callback;
}
Improve build callbacks - Build callbacks now return bool to determine if the build was successful. If the build fails, the editor won't run the game. - Makes sure build callbacks are called after saving the scene ("Save Before Running" option).
2017-08-29 23:59:20 +02:00
EditorBuildCallback EditorNode::build_callbacks[EditorNode::MAX_BUILD_CALLBACKS];
Added API version and hashing to ObjectTypeDB
2016-09-15 00:37:37 +02:00
Added an auto quit and auto build flag to the command line options.
2018-02-14 16:23:04 +01:00
bool EditorNode::call_build() {
Add EditorPlugin.build() build callbacks
2018-01-08 16:55:22 +01:00
bool builds_successful = true;
for (int i = 0; i < build_callback_count && builds_successful; i++) {
if (!build_callbacks[i]()) {
ERR_PRINT("A Godot Engine build callback failed.");
builds_successful = false;
}
Call run callback
2016-09-15 00:44:08 +02:00
}
Improve build callbacks - Build callbacks now return bool to determine if the build was successful. If the build fails, the editor won't run the game. - Makes sure build callbacks are called after saving the scene ("Save Before Running" option).
2017-08-29 23:59:20 +02:00
Add EditorPlugin.build() build callbacks
2018-01-08 16:55:22 +01:00
if (builds_successful && !editor_data.call_build()) {
ERR_PRINT("An EditorPlugin build callback failed.");
builds_successful = false;
}
return builds_successful;
Call run callback
2016-09-15 00:44:08 +02:00
}
Added API version and hashing to ObjectTypeDB
2016-09-15 00:37:37 +02:00
completed scene importing (I hope?)
2017-02-05 00:31:15 +01:00
void EditorNode::_inherit_imported(const String &p_action) {
open_imported->hide();
load_scene(open_import_request, true, true);
}
void EditorNode::_open_imported() {
load_scene(open_import_request, true, false, true, true);
}
Remove `dim_editor_on_dialog_popup` from editor settings
2021-05-29 01:58:03 +02:00
void EditorNode::dim_editor(bool p_dimming) {
dimmed = p_dimming;
gui_base->set_modulate(p_dimming ? Color(0.5, 0.5, 0.5) : Color(1, 1, 1));
Editor: Dim UI when a WindowDialog is shown. Darkens the editor on WindowDialog popup. This adds the following new Editor settings: - interface/dim_editor_on_dialog_popup (true) # Enable/Disable editor dimming - interface/dim_amount (0.6) # Percentage of how much the editor will be darkened (0-1) - interface/dim_transition_time # The duration (in seconds) of the color blending effect (0-1), 0 is instant. Please test this thoroughly, I haven't yet seen a case where it fails to work properly but I'm sure I didn't test all windows of the editor :P
2017-03-06 20:11:56 +01:00
}
Make the editor dimming smarter
2019-10-31 20:58:53 +01:00
bool EditorNode::is_editor_dimmed() const {
return dimmed;
}
Export template management dialog. Missing download (need to discuss this!)
2017-03-21 03:31:41 +01:00
void EditorNode::open_export_template_manager() {
export_template_manager->popup_manager();
}
Ability to convert from SpatialMaterial to ShaderMaterial
2017-09-22 14:20:28 +02:00
void EditorNode::add_resource_conversion_plugin(const Ref<EditorResourceConversionPlugin> &p_plugin) {
resource_conversion_plugins.push_back(p_plugin);
}
void EditorNode::remove_resource_conversion_plugin(const Ref<EditorResourceConversionPlugin> &p_plugin) {
resource_conversion_plugins.erase(p_plugin);
}
Style: Set clang-format Standard to Cpp11 For us, it practically only changes the fact that `A<A<int>>` is now used instead of the C++03 compatible `A<A<int> >`. Note: clang-format 10+ changed the `Standard` arguments to fully specified `c++11`, `c++14`, etc. versions, but we can't use `c++17` now if we want to preserve compatibility with clang-format 8 and 9. `Cpp11` is still supported as deprecated alias for `Latest`.
2020-03-17 07:33:00 +01:00
Vector<Ref<EditorResourceConversionPlugin>> EditorNode::find_resource_conversion_plugin(const Ref<Resource> &p_for_resource) {
Vector<Ref<EditorResourceConversionPlugin>> ret;
Ability to convert from SpatialMaterial to ShaderMaterial
2017-09-22 14:20:28 +02:00
for (int i = 0; i < resource_conversion_plugins.size(); i++) {
if (resource_conversion_plugins[i].is_valid() && resource_conversion_plugins[i]->handles(p_for_resource)) {
ret.push_back(resource_conversion_plugins[i]);
}
}
return ret;
}
Added small icon to expand the bottom panel (and shortcut too)
2018-07-16 03:38:14 +02:00
void EditorNode::_bottom_panel_raise_toggled(bool p_pressed) {
Make the expand icon in the bottom panel always be the same
2019-07-29 23:08:05 +02:00
top_split->set_visible(!p_pressed);
Added small icon to expand the bottom panel (and shortcut too)
2018-07-16 03:38:14 +02:00
}
Split rendering driver project setting into renderer_name and rendering_driver. To differentiate between a driver (e.g. Vulkan or D3D12) and a renderer (e.g. clustered or mobile renderer).
2022-09-08 02:44:36 +02:00
void EditorNode::_update_renderer_color() {
Fix coloring of the renderer options button
2023-03-08 12:12:43 +01:00
String rendering_method = renderer->get_selected_metadata();
if (rendering_method == "forward_plus") {
Bring back the renderer options button on the main editor
2022-12-23 22:54:09 +01:00
renderer->add_theme_color_override("font_color", Color::hex(0x5d8c3fff));
}
Fix coloring of the renderer options button
2023-03-08 12:12:43 +01:00
if (rendering_method == "mobile") {
Bring back the renderer options button on the main editor
2022-12-23 22:54:09 +01:00
renderer->add_theme_color_override("font_color", Color::hex(0xa5557dff));
}
Fix coloring of the renderer options button
2023-03-08 12:12:43 +01:00
if (rendering_method == "gl_compatibility") {
Split rendering driver project setting into renderer_name and rendering_driver. To differentiate between a driver (e.g. Vulkan or D3D12) and a renderer (e.g. clustered or mobile renderer).
2022-09-08 02:44:36 +02:00
renderer->add_theme_color_override("font_color", Color::hex(0x5586a4ff));
Reflection probe support in GLES2 back-end.
2018-09-28 21:40:20 +02:00
}
}
Split rendering driver project setting into renderer_name and rendering_driver. To differentiate between a driver (e.g. Vulkan or D3D12) and a renderer (e.g. clustered or mobile renderer).
2022-09-08 02:44:36 +02:00
void EditorNode::_renderer_selected(int p_which) {
String rendering_method = renderer->get_item_metadata(p_which);
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
Split rendering driver project setting into renderer_name and rendering_driver. To differentiate between a driver (e.g. Vulkan or D3D12) and a renderer (e.g. clustered or mobile renderer).
2022-09-08 02:44:36 +02:00
String current_renderer = GLOBAL_GET("rendering/renderer/rendering_method");
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
Split rendering driver project setting into renderer_name and rendering_driver. To differentiate between a driver (e.g. Vulkan or D3D12) and a renderer (e.g. clustered or mobile renderer).
2022-09-08 02:44:36 +02:00
if (rendering_method == current_renderer) {
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
return;
}
Split rendering driver project setting into renderer_name and rendering_driver. To differentiate between a driver (e.g. Vulkan or D3D12) and a renderer (e.g. clustered or mobile renderer).
2022-09-08 02:44:36 +02:00
renderer_request = rendering_method;
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
video_restart_dialog->popup_centered();
Split rendering driver project setting into renderer_name and rendering_driver. To differentiate between a driver (e.g. Vulkan or D3D12) and a renderer (e.g. clustered or mobile renderer).
2022-09-08 02:44:36 +02:00
renderer->select(renderer_current);
_update_renderer_color();
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
}
Use render method from OS in compositor RD; Update related UI
2023-12-14 04:38:46 +01:00
void EditorNode::_add_renderer_entry(const String &p_renderer_name, bool p_mark_overridden) {
String item_text;
if (p_renderer_name == "forward_plus") {
item_text = TTR("Forward+");
}
if (p_renderer_name == "mobile") {
item_text = TTR("Mobile");
}
if (p_renderer_name == "gl_compatibility") {
item_text = TTR("Compatibility");
}
if (p_mark_overridden) {
item_text += " " + TTR("(Overridden)");
}
renderer->add_item(item_text);
}
Remove `RES` and `REF` typedefs in favor of spelled out `Ref<>` These typedefs don't save much typing compared to the full `Ref<Resource>` and `Ref<RefCounted>`, yet they sometimes introduce confusion among new contributors.
2022-05-03 01:43:50 +02:00
void EditorNode::_resource_saved(Ref<Resource> p_resource, const String &p_path) {
Prevent cache corruption when saving resources in the editor
2023-03-08 19:46:55 +01:00
if (singleton->saving_resources_in_path.has(p_resource)) {
// This is going to be handled by save_resource_in_path when the time is right.
return;
}
Moved folding outside the resource files, now saved outside the project.
2018-10-29 20:36:31 +01:00
if (EditorFileSystem::get_singleton()) {
EditorFileSystem::get_singleton()->update_file(p_path);
}
singleton->editor_folding.save_resource_folding(p_resource, p_path);
}
Remove `RES` and `REF` typedefs in favor of spelled out `Ref<>` These typedefs don't save much typing compared to the full `Ref<Resource>` and `Ref<RefCounted>`, yet they sometimes introduce confusion among new contributors.
2022-05-03 01:43:50 +02:00
void EditorNode::_resource_loaded(Ref<Resource> p_resource, const String &p_path) {
Moved folding outside the resource files, now saved outside the project.
2018-10-29 20:36:31 +01:00
singleton->editor_folding.load_resource_folding(p_resource, p_path);
}
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
void EditorNode::_feature_profile_changed() {
Ref<EditorFeatureProfile> profile = feature_profile_manager->get_current_profile();
fix dock visibility issues
2023-10-28 17:08:59 +02:00
// FIXME: Close all floating docks to avoid crash.
for (WindowWrapper *wrapper : floating_docks) {
wrapper->set_window_enabled(false);
}
Store panels and docks singletons in their own classes
2021-11-17 21:08:55 +01:00
TabContainer *import_tabs = cast_to<TabContainer>(ImportDock::get_singleton()->get_parent());
TabContainer *node_tabs = cast_to<TabContainer>(NodeDock::get_singleton()->get_parent());
TabContainer *fs_tabs = cast_to<TabContainer>(FileSystemDock::get_singleton()->get_parent());
Allow to disable History Dock via feature profile
2022-11-06 20:53:20 +01:00
TabContainer *history_tabs = cast_to<TabContainer>(history_dock->get_parent());
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
if (profile.is_valid()) {
Make `TabContainer` use `TabBar` internally
2022-03-02 15:37:10 +01:00
node_tabs->set_tab_hidden(node_tabs->get_tab_idx_from_control(NodeDock::get_singleton()), profile->is_feature_disabled(EditorFeatureProfile::FEATURE_NODE_DOCK));
Make the Import dock depend on the FileSystem dock
2020-05-08 21:51:42 +02:00
// The Import dock is useless without the FileSystem dock. Ensure the configuration is valid.
bool fs_dock_disabled = profile->is_feature_disabled(EditorFeatureProfile::FEATURE_FILESYSTEM_DOCK);
Make `TabContainer` use `TabBar` internally
2022-03-02 15:37:10 +01:00
fs_tabs->set_tab_hidden(fs_tabs->get_tab_idx_from_control(FileSystemDock::get_singleton()), fs_dock_disabled);
import_tabs->set_tab_hidden(import_tabs->get_tab_idx_from_control(ImportDock::get_singleton()), fs_dock_disabled || profile->is_feature_disabled(EditorFeatureProfile::FEATURE_IMPORT_DOCK));
Allow to disable History Dock via feature profile
2022-11-06 20:53:20 +01:00
history_tabs->set_tab_hidden(history_tabs->get_tab_idx_from_control(history_dock), profile->is_feature_disabled(EditorFeatureProfile::FEATURE_HISTORY_DOCK));
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
main_editor_buttons[EDITOR_3D]->set_visible(!profile->is_feature_disabled(EditorFeatureProfile::FEATURE_3D));
main_editor_buttons[EDITOR_SCRIPT]->set_visible(!profile->is_feature_disabled(EditorFeatureProfile::FEATURE_SCRIPT));
[AssetLib] Fix crash in Web editor. Add EditorAssetLibrary::is_available which always returns false in the Web editor and use it in EditorNode for detection.
2022-06-29 19:27:27 +02:00
if (AssetLibraryEditorPlugin::is_available()) {
Fix editor crash when StreamPeerSSL is unavilable. The fix for EditorNode is a bit hacky, but the handling of the buttons and features there is hacky too (based on enums that might not reflect the actual state).
2019-07-02 15:28:34 +02:00
main_editor_buttons[EDITOR_ASSETLIB]->set_visible(!profile->is_feature_disabled(EditorFeatureProfile::FEATURE_ASSET_LIB));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Enhancements and fixes for the editor feature profile
2019-06-05 06:12:08 +02:00
if ((profile->is_feature_disabled(EditorFeatureProfile::FEATURE_3D) && singleton->main_editor_buttons[EDITOR_3D]->is_pressed()) ||
(profile->is_feature_disabled(EditorFeatureProfile::FEATURE_SCRIPT) && singleton->main_editor_buttons[EDITOR_SCRIPT]->is_pressed()) ||
[AssetLib] Fix crash in Web editor. Add EditorAssetLibrary::is_available which always returns false in the Web editor and use it in EditorNode for detection.
2022-06-29 19:27:27 +02:00
(AssetLibraryEditorPlugin::is_available() && profile->is_feature_disabled(EditorFeatureProfile::FEATURE_ASSET_LIB) && singleton->main_editor_buttons[EDITOR_ASSETLIB]->is_pressed())) {
Port remaining connections to callable_mp
2020-12-06 16:09:18 +01:00
editor_select(EDITOR_2D);
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
}
} else {
Make `TabContainer` use `TabBar` internally
2022-03-02 15:37:10 +01:00
import_tabs->set_tab_hidden(import_tabs->get_tab_idx_from_control(ImportDock::get_singleton()), false);
node_tabs->set_tab_hidden(node_tabs->get_tab_idx_from_control(NodeDock::get_singleton()), false);
fs_tabs->set_tab_hidden(fs_tabs->get_tab_idx_from_control(FileSystemDock::get_singleton()), false);
Allow to disable History Dock via feature profile
2022-11-06 20:53:20 +01:00
history_tabs->set_tab_hidden(history_tabs->get_tab_idx_from_control(history_dock), false);
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
main_editor_buttons[EDITOR_3D]->set_visible(true);
Enhancements and fixes for the editor feature profile
2019-06-05 06:12:08 +02:00
main_editor_buttons[EDITOR_SCRIPT]->set_visible(true);
[AssetLib] Fix crash in Web editor. Add EditorAssetLibrary::is_available which always returns false in the Web editor and use it in EditorNode for detection.
2022-06-29 19:27:27 +02:00
if (AssetLibraryEditorPlugin::is_available()) {
Fix editor crash when StreamPeerSSL is unavilable. The fix for EditorNode is a bit hacky, but the handling of the buttons and features there is hacky too (based on enums that might not reflect the actual state).
2019-07-02 15:28:34 +02:00
main_editor_buttons[EDITOR_ASSETLIB]->set_visible(true);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
}
_update_dock_slots_visibility();
}
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
void EditorNode::_bind_methods() {
Fix "method not found" error when script is removed from object
2018-12-31 09:52:09 +01:00
ClassDB::bind_method(D_METHOD("push_item", "object", "property", "inspector_only"), &EditorNode::push_item, DEFVAL(""), DEFVAL(false));
ObjectTypeDB was renamed to ClassDB. Types are meant to be more generic to Variant. All usages of "type" to refer to classes were renamed to "class" ClassDB has been exposed to GDScript. OBJ_TYPE() macro is now GDCLASS()
2017-01-03 03:03:46 +01:00
ClassDB::bind_method("set_edited_scene", &EditorNode::set_edited_scene);
ClassDB::bind_method("open_request", &EditorNode::open_request);
Switch scene when editing foreign resource
2022-03-25 01:17:30 +01:00
ClassDB::bind_method("edit_foreign_resource", &EditorNode::edit_foreign_resource);
Disable editing properties in foreign resources from imported scenes or objects returning true from a function named '_is_read_only' and disable resaving imported resources.
2022-04-29 08:06:48 +02:00
ClassDB::bind_method("is_resource_read_only", &EditorNode::is_resource_read_only);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ObjectTypeDB was renamed to ClassDB. Types are meant to be more generic to Variant. All usages of "type" to refer to classes were renamed to "class" ClassDB has been exposed to GDScript. OBJ_TYPE() macro is now GDCLASS()
2017-01-03 03:03:46 +01:00
ClassDB::bind_method("stop_child_process", &EditorNode::stop_child_process);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ObjectTypeDB was renamed to ClassDB. Types are meant to be more generic to Variant. All usages of "type" to refer to classes were renamed to "class" ClassDB has been exposed to GDScript. OBJ_TYPE() macro is now GDCLASS()
2017-01-03 03:03:46 +01:00
ClassDB::bind_method("_set_main_scene_state", &EditorNode::_set_main_scene_state);
Add an option to clear recent scenes in the 'Open Recent' submenu
2017-10-12 04:35:15 +02:00
ClassDB::bind_method("_update_recent_scenes", &EditorNode::_update_recent_scenes);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
Editor: Make "open 2d/3d/script editor" shortcuts configurable. Also adds shortcuts for opening the AssetLib and for switching to the next/prev editor.
2017-05-16 21:26:32 +02:00
ADD_SIGNAL(MethodInfo("request_help_search"));
PoolVector is gone, replaced by Vector Typed `PoolTypeArray` types are now renamed `PackedTypeArray` and are sugar for `Vector<Type>`.
2020-02-17 22:06:54 +01:00
ADD_SIGNAL(MethodInfo("script_add_function_request", PropertyInfo(Variant::OBJECT, "obj"), PropertyInfo(Variant::STRING, "function"), PropertyInfo(Variant::PACKED_STRING_ARRAY, "args")));
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
ADD_SIGNAL(MethodInfo("resource_saved", PropertyInfo(Variant::OBJECT, "obj")));
Improve save handling for built-in scripts
2021-11-06 02:15:19 +01:00
ADD_SIGNAL(MethodInfo("scene_saved", PropertyInfo(Variant::STRING, "path")));
Add history dock
2022-08-27 13:52:06 +02:00
ADD_SIGNAL(MethodInfo("scene_changed"));
Close built-in shaders when closing scene
2023-04-09 20:43:55 +02:00
ADD_SIGNAL(MethodInfo("scene_closed", PropertyInfo(Variant::STRING, "path")));
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
}
Groundbreaking!! Godot resources can now be flagged to be local to the scene being edited! This means that each time this scene is instanced, the resource will be unique! As such, thanks to this, the following features were implemented: -ButtonGroup is no longer a control, it's now a resource local to the scene -ViewportTexture can be created from the editor and set to any object, making ViewportSprite and other kind of nodes obsolete!
2017-01-10 05:04:31 +01:00
static Node *_resource_get_edited_scene() {
return EditorNode::get_singleton()->get_edited_scene();
}
Adding print_rich for printing with BBCode
2022-05-03 01:29:38 +02:00
void EditorNode::_print_handler(void *p_this, const String &p_string, bool p_error, bool p_rich) {
Make certain editor callbacks thread-safe
2023-05-19 18:45:22 +02:00
callable_mp_static(&EditorNode::_print_handler_impl).bind(p_string, p_error, p_rich).call_deferred();
}
void EditorNode::_print_handler_impl(const String &p_string, bool p_error, bool p_rich) {
Avoid crash on exiting due to late prints
2023-08-02 11:43:35 +02:00
if (!singleton) {
return;
}
Adding print_rich for printing with BBCode
2022-05-03 01:29:38 +02:00
if (p_error) {
Make certain editor callbacks thread-safe
2023-05-19 18:45:22 +02:00
singleton->log->add_message(p_string, EditorLog::MSG_TYPE_ERROR);
Adding print_rich for printing with BBCode
2022-05-03 01:29:38 +02:00
} else if (p_rich) {
Make certain editor callbacks thread-safe
2023-05-19 18:45:22 +02:00
singleton->log->add_message(p_string, EditorLog::MSG_TYPE_STD_RICH);
Adding print_rich for printing with BBCode
2022-05-03 01:29:38 +02:00
} else {
Make certain editor callbacks thread-safe
2023-05-19 18:45:22 +02:00
singleton->log->add_message(p_string, EditorLog::MSG_TYPE_STD);
Adding print_rich for printing with BBCode
2022-05-03 01:29:38 +02:00
}
Add a print handler for the editor output panel
2017-11-14 23:02:31 +01:00
}
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
static void _execute_thread(void *p_ud) {
EditorNode::ExecuteThreadArgs *eta = (EditorNode::ExecuteThreadArgs *)p_ud;
Split OS::execute into two methods 1. execute(): Executes a command and returns the results. 2. create_process(): Creates a new process and returns the new process' id.
2020-12-18 19:49:13 +01:00
Error err = OS::get_singleton()->execute(eta->path, eta->args, &eta->output, &eta->exitcode, true, &eta->execute_output_mutex);
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
print_verbose("Thread exit status: " + itos(eta->exitcode));
if (err != OK) {
eta->exitcode = err;
}
Modernize atomics - Based on C++11's `atomic` - Reworked `SafeRefCount` (based on the rewrite by @hpvb) - Replaced free atomic functions by the new `SafeNumeric<T>` - Replaced wrong cases of `volatile bool` by the new `SafeFlag` - Platform-specific implementations no longer needed Co-authored-by: Hein-Pieter van Braam-Stewart <hp@tmm.cx>
2021-02-10 19:22:13 +01:00
eta->done.set();
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
}
Preserve the output from the gradle build command Updates `EditorNode#execute_and_show_output(...)` to return the output of the executed command.
2023-11-12 02:20:04 +01:00
int EditorNode::execute_and_show_output(const String &p_title, const String &p_path, const List<String> &p_arguments, bool p_close_on_ok, bool p_close_on_errors, String *r_output) {
Automatically reparent editor message dialogs to avoid error spam.
2023-02-15 15:35:16 +01:00
if (execute_output_dialog) {
execute_output_dialog->set_title(p_title);
execute_output_dialog->get_ok_button()->set_disabled(true);
execute_outputs->clear();
execute_outputs->set_scroll_follow(true);
Expose dialog parent-and-popup logic to the API
2023-04-20 15:13:21 +02:00
EditorInterface::get_singleton()->popup_dialog_centered_ratio(execute_output_dialog);
Automatically reparent editor message dialogs to avoid error spam.
2023-02-15 15:35:16 +01:00
}
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
ExecuteThreadArgs eta;
eta.path = p_path;
eta.args = p_arguments;
eta.exitcode = 255;
int prev_len = 0;
Modernize Thread - Based on C++11's `thread` and `thread_local` - No more need to allocate-deallocate or check for null - No pointer anymore, just a member variable - Platform-specific implementations no longer needed (except for the few cases of non-portable functions) - Simpler for `NO_THREADS` - Thread ids are now the same across platforms (main is 1; others follow)
2021-01-19 13:29:41 +01:00
eta.execute_output_thread.start(_execute_thread, &eta);
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
Modernize atomics - Based on C++11's `atomic` - Reworked `SafeRefCount` (based on the rewrite by @hpvb) - Replaced free atomic functions by the new `SafeNumeric<T>` - Replaced wrong cases of `volatile bool` by the new `SafeFlag` - Platform-specific implementations no longer needed Co-authored-by: Hein-Pieter van Braam-Stewart <hp@tmm.cx>
2021-02-10 19:22:13 +01:00
while (!eta.done.is_set()) {
Reimplement Mutex with C++'s <mutex> Main: - It's now implemented thanks to `<mutex>`. No more platform-specific implementations. - `BinaryMutex` (non-recursive) is added, as an alternative for special cases. - Doesn't need allocation/deallocation anymore. It can live in the stack and be part of other classes. - Because of that, it's methods are now `const` and the inner mutex is `mutable` so it can be easily used in `const` contexts. - A no-op implementation is provided if `NO_THREADS` is defined. No more need to add `#ifdef NO_THREADS` just for this. - `MutexLock` now takes a reference. At this point the cases of null `Mutex`es are rare. If you ever need that, just don't use `MutexLock`. - Thread-safe utilities are therefore simpler now. Misc.: - `ScopedMutexLock` is dropped and replaced by `MutexLock`, because they were pretty much the same. - Every case of lock, do-something, unlock is replaced by `MutexLock` (complex cases where it's not straightfoward are kept as as explicit lock and unlock). - `ShaderRD` contained an `std::mutex`, which has been replaced by `Mutex`.
2020-02-26 11:28:13 +01:00
{
MutexLock lock(eta.execute_output_mutex);
if (prev_len != eta.output.length()) {
String to_add = eta.output.substr(prev_len, eta.output.length());
prev_len = eta.output.length();
execute_outputs->add_text(to_add);
Automatically reparent editor message dialogs to avoid error spam.
2023-02-15 15:35:16 +01:00
DisplayServer::get_singleton()->process_events(); // Get rid of pending events.
Reimplement Mutex with C++'s <mutex> Main: - It's now implemented thanks to `<mutex>`. No more platform-specific implementations. - `BinaryMutex` (non-recursive) is added, as an alternative for special cases. - Doesn't need allocation/deallocation anymore. It can live in the stack and be part of other classes. - Because of that, it's methods are now `const` and the inner mutex is `mutable` so it can be easily used in `const` contexts. - A no-op implementation is provided if `NO_THREADS` is defined. No more need to add `#ifdef NO_THREADS` just for this. - `MutexLock` now takes a reference. At this point the cases of null `Mutex`es are rare. If you ever need that, just don't use `MutexLock`. - Thread-safe utilities are therefore simpler now. Misc.: - `ScopedMutexLock` is dropped and replaced by `MutexLock`, because they were pretty much the same. - Every case of lock, do-something, unlock is replaced by `MutexLock` (complex cases where it's not straightfoward are kept as as explicit lock and unlock). - `ShaderRD` contained an `std::mutex`, which has been replaced by `Mutex`.
2020-02-26 11:28:13 +01:00
Main::iteration();
}
}
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
OS::get_singleton()->delay_usec(1000);
}
Modernize Thread - Based on C++11's `thread` and `thread_local` - No more need to allocate-deallocate or check for null - No pointer anymore, just a member variable - Platform-specific implementations no longer needed (except for the few cases of non-portable functions) - Simpler for `NO_THREADS` - Thread ids are now the same across platforms (main is 1; others follow)
2021-01-19 13:29:41 +01:00
eta.execute_output_thread.wait_to_finish();
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
execute_outputs->add_text("\nExit Code: " + itos(eta.exitcode));
Automatically reparent editor message dialogs to avoid error spam.
2023-02-15 15:35:16 +01:00
if (execute_output_dialog) {
if (p_close_on_errors && eta.exitcode != 0) {
execute_output_dialog->hide();
}
if (p_close_on_ok && eta.exitcode == 0) {
execute_output_dialog->hide();
}
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
Automatically reparent editor message dialogs to avoid error spam.
2023-02-15 15:35:16 +01:00
execute_output_dialog->get_ok_button()->set_disabled(false);
}
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
Preserve the output from the gradle build command Updates `EditorNode#execute_and_show_output(...)` to return the output of the executed command.
2023-11-12 02:20:04 +01:00
if (r_output) {
*r_output = eta.output;
}
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
return eta.exitcode;
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
EditorNode::EditorNode() {
Clean up some Editor, OpenXR, VideoStream code - EditorNode has excessive and pointless checks for Input singleton. - EditorNode initialization order is a bit awkward. - OpenXR binds a method that doesn't need that (for call deferred). - VideoStream has a formatting error.
2023-10-20 17:54:39 +02:00
DEV_ASSERT(!singleton);
singleton = this;
i18n: Make property paths and categories translatable
2022-03-03 11:25:11 +01:00
Groundbreaking!! Godot resources can now be flagged to be local to the scene being edited! This means that each time this scene is instanced, the resource will be unique! As such, thanks to this, the following features were implemented: -ButtonGroup is no longer a control, it's now a resource local to the scene -ViewportTexture can be created from the editor and set to any object, making ViewportSprite and other kind of nodes obsolete!
2017-01-10 05:04:31 +01:00
Resource::_get_local_scene_func = _resource_get_edited_scene;
Clean up some Editor, OpenXR, VideoStream code - EditorNode has excessive and pointless checks for Input singleton. - EditorNode initialization order is a bit awkward. - OpenXR binds a method that doesn't need that (for call deferred). - VideoStream has a formatting error.
2023-10-20 17:54:39 +02:00
{
PortableCompressedTexture2D::set_keep_all_compressed_buffers(true);
RenderingServer::get_singleton()->set_debug_generate_wireframes(true);
baking now shows a proper button, and bakes can be saved.
2016-12-23 04:37:38 +01:00
Clean up some Editor, OpenXR, VideoStream code - EditorNode has excessive and pointless checks for Input singleton. - EditorNode initialization order is a bit awkward. - OpenXR binds a method that doesn't need that (for call deferred). - VideoStream has a formatting error.
2023-10-20 17:54:39 +02:00
AudioServer::get_singleton()->set_enable_tagging_used_audio_streams(true);
Implement BPM support Based on #62896, only implements the BPM support part. * Implements BPM support in the AudioStreamOGG/MP3 importers. * Can select BPM/Bar Size and total beats in a song file, as well as edit looping points. * Looping is now BPM aware * Added a special importer UI for configuring this. * Added a special preview showing the audio waveform as well as the playback position in the resource picker. * Renamed `AudioStream::instance` to `instantiate` for correctness.
2022-07-21 01:00:58 +02:00
Clean up some Editor, OpenXR, VideoStream code - EditorNode has excessive and pointless checks for Input singleton. - EditorNode initialization order is a bit awkward. - OpenXR binds a method that doesn't need that (for call deferred). - VideoStream has a formatting error.
2023-10-20 17:54:39 +02:00
// No navigation by default if in editor.
if (NavigationServer3D::get_singleton()->get_debug_enabled()) {
NavigationServer3D::get_singleton()->set_active(true);
} else {
NavigationServer3D::get_singleton()->set_active(false);
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
Clean up some Editor, OpenXR, VideoStream code - EditorNode has excessive and pointless checks for Input singleton. - EditorNode initialization order is a bit awkward. - OpenXR binds a method that doesn't need that (for call deferred). - VideoStream has a formatting error.
2023-10-20 17:54:39 +02:00
// No physics by default if in editor.
PhysicsServer3D::get_singleton()->set_active(false);
PhysicsServer2D::get_singleton()->set_active(false);
- Integrated NavigationServer and Navigation2DServer. - Added Navigation Agents and Obstacles. - Integrated Collision Avoidance. This work has been kindly sponsored by IMVU.
2020-01-10 12:22:34 +01:00
Clean up some Editor, OpenXR, VideoStream code - EditorNode has excessive and pointless checks for Input singleton. - EditorNode initialization order is a bit awkward. - OpenXR binds a method that doesn't need that (for call deferred). - VideoStream has a formatting error.
2023-10-20 17:54:39 +02:00
// No scripting by default if in editor (except for tool).
ScriptServer::set_scripting_enabled(false);
Input::get_singleton()->set_use_accumulated_input(true);
if (!DisplayServer::get_singleton()->is_touchscreen_available()) {
// Only if no touchscreen ui hint, disable emulation just in case.
Input::get_singleton()->set_emulate_touch_from_mouse(false);
}
DisplayServer::get_singleton()->cursor_set_custom_image(Ref<Resource>());
}
Disable scripting and physics early in EditorNode This avoids issues with scripts being instanced before this is set, like autoloads.
2018-08-21 02:55:01 +02:00
-fixes and more fixes to new scene system, seems stable now.. BUT DONT TRUST ME IT MAY STILL BREAK, USE WITH CARE!!
2015-10-17 00:11:23 +02:00
SceneState::set_disable_placeholders(true);
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
ResourceLoader::clear_translation_remaps(); // Using no remaps if in editor.
GDScript files are converted to binary on export now.
2017-12-14 19:33:54 +01:00
ResourceLoader::clear_path_remaps();
Implement missing Node & Resource placeholders Implemented by request of @neikeq to advance in the GDExtension version of Mono. * If a Resource type is missing upon load, it will be remembered together with its data (Unless manually overriden). * If a Node type is missing upon load, it will be also be remembered together with its data (unless deleted). This feature makes working with GDExtension much easier, as it ensures that missing types no longer cause data loss.
2022-04-28 22:49:10 +02:00
ResourceLoader::set_create_missing_resources_if_class_unavailable(true);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Clean up some Editor, OpenXR, VideoStream code - EditorNode has excessive and pointless checks for Input singleton. - EditorNode initialization order is a bit awkward. - OpenXR binds a method that doesn't need that (for call deferred). - VideoStream has a formatting error.
2023-10-20 17:54:39 +02:00
EditorPropertyNameProcessor *epnp = memnew(EditorPropertyNameProcessor);
add_child(epnp);
Separate fullscreen state for scene & script editor
2017-04-25 13:48:35 +02:00
Add EditorUndoRedoManager singleton
2022-12-23 23:53:16 +01:00
EditorUndoRedoManager::get_singleton()->connect("version_changed", callable_mp(this, &EditorNode::_update_undo_redo_allowed));
EditorUndoRedoManager::get_singleton()->connect("history_changed", callable_mp(this, &EditorNode::_update_undo_redo_allowed));
Deprecate project_settings_changed signal
2023-08-09 17:52:01 +02:00
ProjectSettings::get_singleton()->connect("settings_changed", callable_mp(this, &EditorNode::_update_from_settings));
Implement reloading of GDExtensions
2023-08-05 03:34:14 +02:00
GDExtensionManager::get_singleton()->connect("extensions_reloaded", callable_mp(this, &EditorNode::_gdextensions_reloaded));
Fix Undo/Redo not working until Scene menu is opened.
2023-01-08 09:35:15 +01:00
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
TranslationServer::get_singleton()->set_enabled(false);
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Load settings.
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!EditorSettings::get_singleton()) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
EditorSettings::create();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Make Godot detect if the screen is too small (<1200 pixels wide), and use single dock column like in 1.0 if that's the case.
2016-09-13 16:20:09 +02:00
Properly save the new save safe setting, avoid crash.
2018-01-12 21:18:40 +01:00
FileAccess::set_backup_save(EDITOR_GET("filesystem/on_save/safe_save_on_backup_then_rename"));
Overhaul the SurfaceUpgradeTool This defers the update to a fresh restart of the editor (to ensure we aren't mid way through loading scenes anymore. It also ensures that the popup can't be used by multiple threads at once Co-authored-by: Yuri Sizov <yuris@humnom.net>
2023-10-30 15:34:18 +01:00
// Warm up the surface upgrade tool as early as possible.
surface_upgrade_tool = memnew(SurfaceUpgradeTool);
run_surface_upgrade_tool = EditorSettings::get_singleton()->get_project_metadata("surface_upgrade_tool", "run_on_restart", false);
if (run_surface_upgrade_tool) {
SurfaceUpgradeTool::get_singleton()->begin_upgrade();
}
make hdpi manually configurable in project settings also added hidpi support to project manager
2016-06-05 23:43:45 +02:00
{
Unify usage of GLOBAL/EDITOR_GET
2022-10-18 16:43:37 +02:00
int display_scale = EDITOR_GET("interface/editor/display_scale");
Overhaul the display scaling editor settings This adds more scaling options, in addition to a custom scaling option which allows any scale between 0.75 and 3.0 to be used.
2018-03-22 20:20:42 +01:00
switch (display_scale) {
EditorSettings: Factor code to compute auto display scale Also fixes typo introduced in https://github.com/godotengine/godot/pull/48597/files#r652636544.
2021-06-16 14:36:09 +02:00
case 0:
Use 75% editor scale on small displays automatically This also makes borders always display in the editor theme, even if the editor scale is below 100%. Otherwise, "focus" outlines would vanish when using an editor scale below 100%, which harms usability.
2020-11-12 16:01:27 +01:00
// Try applying a suitable display scale automatically.
Single Compilation Unit build. Adds support for simple SCU build (DEV_ENABLED only). This speeds up compilation by compiling multiple cpp files within a single translation unit.
2023-05-17 17:22:26 +02:00
EditorScale::set_scale(EditorSettings::get_singleton()->get_auto_display_scale());
EditorSettings: Factor code to compute auto display scale Also fixes typo introduced in https://github.com/godotengine/godot/pull/48597/files#r652636544.
2021-06-16 14:36:09 +02:00
break;
Use 75% editor scale on small displays automatically This also makes borders always display in the editor theme, even if the editor scale is below 100%. Otherwise, "focus" outlines would vanish when using an editor scale below 100%, which harms usability.
2020-11-12 16:01:27 +01:00
case 1:
Single Compilation Unit build. Adds support for simple SCU build (DEV_ENABLED only). This speeds up compilation by compiling multiple cpp files within a single translation unit.
2023-05-17 17:22:26 +02:00
EditorScale::set_scale(0.75);
Use 75% editor scale on small displays automatically This also makes borders always display in the editor theme, even if the editor scale is below 100%. Otherwise, "focus" outlines would vanish when using an editor scale below 100%, which harms usability.
2020-11-12 16:01:27 +01:00
break;
case 2:
Single Compilation Unit build. Adds support for simple SCU build (DEV_ENABLED only). This speeds up compilation by compiling multiple cpp files within a single translation unit.
2023-05-17 17:22:26 +02:00
EditorScale::set_scale(1.0);
Use 75% editor scale on small displays automatically This also makes borders always display in the editor theme, even if the editor scale is below 100%. Otherwise, "focus" outlines would vanish when using an editor scale below 100%, which harms usability.
2020-11-12 16:01:27 +01:00
break;
case 3:
Single Compilation Unit build. Adds support for simple SCU build (DEV_ENABLED only). This speeds up compilation by compiling multiple cpp files within a single translation unit.
2023-05-17 17:22:26 +02:00
EditorScale::set_scale(1.25);
Use 75% editor scale on small displays automatically This also makes borders always display in the editor theme, even if the editor scale is below 100%. Otherwise, "focus" outlines would vanish when using an editor scale below 100%, which harms usability.
2020-11-12 16:01:27 +01:00
break;
case 4:
Single Compilation Unit build. Adds support for simple SCU build (DEV_ENABLED only). This speeds up compilation by compiling multiple cpp files within a single translation unit.
2023-05-17 17:22:26 +02:00
EditorScale::set_scale(1.5);
Use 75% editor scale on small displays automatically This also makes borders always display in the editor theme, even if the editor scale is below 100%. Otherwise, "focus" outlines would vanish when using an editor scale below 100%, which harms usability.
2020-11-12 16:01:27 +01:00
break;
case 5:
Single Compilation Unit build. Adds support for simple SCU build (DEV_ENABLED only). This speeds up compilation by compiling multiple cpp files within a single translation unit.
2023-05-17 17:22:26 +02:00
EditorScale::set_scale(1.75);
Use 75% editor scale on small displays automatically This also makes borders always display in the editor theme, even if the editor scale is below 100%. Otherwise, "focus" outlines would vanish when using an editor scale below 100%, which harms usability.
2020-11-12 16:01:27 +01:00
break;
case 6:
Single Compilation Unit build. Adds support for simple SCU build (DEV_ENABLED only). This speeds up compilation by compiling multiple cpp files within a single translation unit.
2023-05-17 17:22:26 +02:00
EditorScale::set_scale(2.0);
Use 75% editor scale on small displays automatically This also makes borders always display in the editor theme, even if the editor scale is below 100%. Otherwise, "focus" outlines would vanish when using an editor scale below 100%, which harms usability.
2020-11-12 16:01:27 +01:00
break;
default:
Single Compilation Unit build. Adds support for simple SCU build (DEV_ENABLED only). This speeds up compilation by compiling multiple cpp files within a single translation unit.
2023-05-17 17:22:26 +02:00
EditorScale::set_scale(EDITOR_GET("interface/editor/custom_display_scale"));
Use 75% editor scale on small displays automatically This also makes borders always display in the editor theme, even if the editor scale is below 100%. Otherwise, "focus" outlines would vanish when using an editor scale below 100%, which harms usability.
2020-11-12 16:01:27 +01:00
break;
make hdpi manually configurable in project settings also added hidpi support to project manager
2016-06-05 23:43:45 +02:00
}
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Define a minimum window size to prevent UI elements from overlapping or being cut off.
Set main window min. size via Window object instead of DisplayServer to preserve it during window updates.
2023-01-03 08:25:45 +01:00
Window *w = Object::cast_to<Window>(SceneTree::get_singleton()->get_root());
if (w) {
Correctly enforce minimum window size in editor Also set the maximum size for the language picked in the project manager.
2023-12-20 13:19:21 +01:00
const Size2 minimum_size = Size2(1024, 600) * EDSCALE;
w->set_min_size(minimum_size); // Calling it this early doesn't sync the property with DS.
DisplayServer::get_singleton()->window_set_min_size(minimum_size);
Set main window min. size via Window object instead of DisplayServer to preserve it during window updates.
2023-01-03 08:25:45 +01:00
}
Define a minimum window size in the editor and project manager This prevents most UI elements from overlapping or being cut off as a result of the window being too small. This closes #20669.
2019-08-17 21:56:59 +02:00
Unify usage of GLOBAL/EDITOR_GET
2022-10-18 16:43:37 +02:00
EditorFileDialog::set_default_show_hidden_files(EDITOR_GET("filesystem/file_dialog/show_hidden_files"));
EditorFileDialog::set_default_display_mode((EditorFileDialog::DisplayMode)EDITOR_GET("filesystem/file_dialog/display_mode").operator int());
Add editor setting for AcceptDialog OK/Cancel buttons positioning The position (left/right) of the Cancel and OK buttons in AcceptDialog are DisplayServer specific, as Windows uses OK/Cancel and macOS uses Cancel/OK. Linux/X11 currently uses the macOS convention which is also the GTK+/GNOME one, though it's not consistent with Qt/KDE applications which follow the Windows convention. Since that can't satisfy everyone, it's best if it's configurable also for the editor (it's already configurable for the project). Fixes #59379.
2022-03-21 10:55:18 +01:00
int swap_cancel_ok = EDITOR_GET("interface/editor/accept_dialog_cancel_ok_buttons");
if (swap_cancel_ok != 0) { // 0 is auto, set in register_scene based on DisplayServer.
// Swap on means OK first.
AcceptDialog::set_swap_cancel_ok(swap_cancel_ok == 2);
}
[Editor] Add option to override editor UI layout direction.
2023-11-17 07:54:07 +01:00
int ed_root_dir = EDITOR_GET("interface/editor/ui_layout_direction");
Control::set_root_layout_direction(ed_root_dir);
Window::set_root_layout_direction(ed_root_dir);
Add editor setting for AcceptDialog OK/Cancel buttons positioning The position (left/right) of the Cancel and OK buttons in AcceptDialog are DisplayServer specific, as Windows uses OK/Cancel and macOS uses Cancel/OK. Linux/X11 currently uses the macOS convention which is also the GTK+/GNOME one, though it's not consistent with Qt/KDE applications which follow the Windows convention. Since that can't satisfy everyone, it's best if it's configurable also for the editor (it's already configurable for the project). Fixes #59379.
2022-03-21 10:55:18 +01:00
ResourceLoader::set_abort_on_missing_resources(false);
Simplify ResourceLoader error callbacks
2023-01-17 14:26:16 +01:00
ResourceLoader::set_error_notify_func(&EditorNode::add_io_error);
ResourceLoader::set_dependency_error_notify_func(&EditorNode::_dependency_error_report);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Let editor workaround a case of inconsistency in compound scenes
2023-06-07 13:44:37 +02:00
SceneState::set_instantiation_warning_notify_func([](const String &p_warning) {
add_io_warning(p_warning);
callable_mp(EditorInterface::get_singleton(), &EditorInterface::mark_scene_as_unsaved).call_deferred();
});
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
{
// Register importers at the beginning, so dialogs are created with the right extensions.
Register and cleanup resource importer singletons in a predictable way
2023-08-07 17:00:46 +02:00
Ref<ResourceImporterTexture> import_texture = memnew(ResourceImporterTexture(true));
Lot of work in new importer, importing textures now works.
2017-02-01 13:45:45 +01:00
ResourceFormatImporter::get_singleton()->add_importer(import_texture);
CSV translation import plugin
2017-02-02 00:41:05 +01:00
New lightmapper -Added LocalVector (needed it) -Added stb_rect_pack (It's pretty cool, we could probably use it for other stuff too) -Fixes and changes all around the place -Added library for 128 bits fixed point (required for Delaunay3D)
2020-05-01 14:34:23 +02:00
Ref<ResourceImporterLayeredTexture> import_cubemap;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
import_cubemap.instantiate();
Texture refactor -Texture renamed to Texture2D -TextureLayered as base now inherits 2Darray, cubemap and cubemap array -Removed all references to flags in textures (they will go in the shader) -Texture3D gone for now (will come back later done properly) -Create base rasterizer for RenderDevice, RasterizerRD
2019-06-11 20:43:37 +02:00
import_cubemap->set_mode(ResourceImporterLayeredTexture::MODE_CUBEMAP);
ResourceFormatImporter::get_singleton()->add_importer(import_cubemap);
Added proper import support for 3D and Array textures
2018-08-06 19:56:06 +02:00
Ref<ResourceImporterLayeredTexture> import_array;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
import_array.instantiate();
Texture refactor -Texture renamed to Texture2D -TextureLayered as base now inherits 2Darray, cubemap and cubemap array -Removed all references to flags in textures (they will go in the shader) -Texture3D gone for now (will come back later done properly) -Create base rasterizer for RenderDevice, RasterizerRD
2019-06-11 20:43:37 +02:00
import_array->set_mode(ResourceImporterLayeredTexture::MODE_2D_ARRAY);
Added proper import support for 3D and Array textures
2018-08-06 19:56:06 +02:00
ResourceFormatImporter::get_singleton()->add_importer(import_array);
Texture refactor -Texture renamed to Texture2D -TextureLayered as base now inherits 2Darray, cubemap and cubemap array -Removed all references to flags in textures (they will go in the shader) -Texture3D gone for now (will come back later done properly) -Create base rasterizer for RenderDevice, RasterizerRD
2019-06-11 20:43:37 +02:00
Ref<ResourceImporterLayeredTexture> import_cubemap_array;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
import_cubemap_array.instantiate();
Texture refactor -Texture renamed to Texture2D -TextureLayered as base now inherits 2Darray, cubemap and cubemap array -Removed all references to flags in textures (they will go in the shader) -Texture3D gone for now (will come back later done properly) -Create base rasterizer for RenderDevice, RasterizerRD
2019-06-11 20:43:37 +02:00
import_cubemap_array->set_mode(ResourceImporterLayeredTexture::MODE_CUBEMAP_ARRAY);
ResourceFormatImporter::get_singleton()->add_importer(import_cubemap_array);
New lightmapper -Added LocalVector (needed it) -Added stb_rect_pack (It's pretty cool, we could probably use it for other stuff too) -Fixes and changes all around the place -Added library for 128 bits fixed point (required for Delaunay3D)
2020-05-01 14:34:23 +02:00
Register and cleanup resource importer singletons in a predictable way
2023-08-07 17:00:46 +02:00
Ref<ResourceImporterLayeredTexture> import_3d = memnew(ResourceImporterLayeredTexture(true));
New lightmapper -Added LocalVector (needed it) -Added stb_rect_pack (It's pretty cool, we could probably use it for other stuff too) -Fixes and changes all around the place -Added library for 128 bits fixed point (required for Delaunay3D)
2020-05-01 14:34:23 +02:00
import_3d->set_mode(ResourceImporterLayeredTexture::MODE_3D);
Implement 3D textures as import and resource format.
2020-09-09 17:40:51 +02:00
ResourceFormatImporter::get_singleton()->add_importer(import_3d);
New lightmapper -Added LocalVector (needed it) -Added stb_rect_pack (It's pretty cool, we could probably use it for other stuff too) -Fixes and changes all around the place -Added library for 128 bits fixed point (required for Delaunay3D)
2020-05-01 14:34:23 +02:00
It is now possible to import images as a separate resource, closes #5738 and likely many others
2018-07-29 21:45:23 +02:00
Ref<ResourceImporterImage> import_image;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
import_image.instantiate();
It is now possible to import images as a separate resource, closes #5738 and likely many others
2018-07-29 21:45:23 +02:00
ResourceFormatImporter::get_singleton()->add_importer(import_image);
Added ability for multiple images to be imported as an atlas This adds support for groups in the import system, which point to a single file. Add property hint for saving files in file field
2019-04-19 20:54:33 +02:00
Ref<ResourceImporterTextureAtlas> import_texture_atlas;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
import_texture_atlas.instantiate();
Added ability for multiple images to be imported as an atlas This adds support for groups in the import system, which point to a single file. Add property hint for saving files in file field
2019-04-19 20:54:33 +02:00
ResourceFormatImporter::get_singleton()->add_importer(import_texture_atlas);
Makes FontData importable resource. Adds multi-channel SDF font texture generation and rendering support. Adds per-font oversampling support. Adds FontData import plugins (for dynamic fonts, BMFonts and monospaced image fonts), font texture cache pre-generation and loading. Adds BMFont binary format and outline support.
2020-12-27 14:30:33 +01:00
Ref<ResourceImporterDynamicFont> import_font_data_dynamic;
import_font_data_dynamic.instantiate();
ResourceFormatImporter::get_singleton()->add_importer(import_font_data_dynamic);
Ref<ResourceImporterBMFont> import_font_data_bmfont;
import_font_data_bmfont.instantiate();
ResourceFormatImporter::get_singleton()->add_importer(import_font_data_bmfont);
Ref<ResourceImporterImageFont> import_font_data_image;
import_font_data_image.instantiate();
ResourceFormatImporter::get_singleton()->add_importer(import_font_data_image);
CSV translation import plugin
2017-02-02 00:41:05 +01:00
Ref<ResourceImporterCSVTranslation> import_csv_translation;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
import_csv_translation.instantiate();
CSV translation import plugin
2017-02-02 00:41:05 +01:00
ResourceFormatImporter::get_singleton()->add_importer(import_csv_translation);
wav file importing!
2017-02-03 02:51:26 +01:00
Ref<ResourceImporterWAV> import_wav;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
import_wav.instantiate();
wav file importing!
2017-02-03 02:51:26 +01:00
ResourceFormatImporter::get_singleton()->add_importer(import_wav);
Restored ability to import OBJ files as meshes directly. Finally closes #9445.
2017-09-30 01:38:27 +02:00
Ref<ResourceImporterOBJ> import_obj;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
import_obj.instantiate();
Restored ability to import OBJ files as meshes directly. Finally closes #9445.
2017-09-30 01:38:27 +02:00
ResourceFormatImporter::get_singleton()->add_importer(import_obj);
Exposed RenderingDevice to script API Also added an easier way to load native GLSL shaders. Extras: Had to fix no-cache for subresources in resource loader, it was not properly working, making shaders not properly reload. Note: The precommit hooks are broken because they don't seem to support enums from one class being used in another. Feel free to fix this after merging this PR.
2020-04-20 04:19:21 +02:00
Ref<ResourceImporterShaderFile> import_shader_file;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
import_shader_file.instantiate();
Exposed RenderingDevice to script API Also added an easier way to load native GLSL shaders. Extras: Had to fix no-cache for subresources in resource loader, it was not properly working, making shaders not properly reload. Note: The precommit hooks are broken because they don't seem to support enums from one class being used in another. Feel free to fix this after merging this PR.
2020-04-20 04:19:21 +02:00
ResourceFormatImporter::get_singleton()->add_importer(import_shader_file);
Register and cleanup resource importer singletons in a predictable way
2023-08-07 17:00:46 +02:00
Ref<ResourceImporterScene> import_scene = memnew(ResourceImporterScene(false, true));
Scene import more or less working, needs some missing features.
2017-02-04 13:48:04 +01:00
ResourceFormatImporter::get_singleton()->add_importer(import_scene);
Register and cleanup resource importer singletons in a predictable way
2023-08-07 17:00:46 +02:00
Ref<ResourceImporterScene> import_animation = memnew(ResourceImporterScene(true, true));
Import scenes as AnimationLibrary Added the ability to import scenes as AnimationLibrary * Completes implementation of https://github.com/godotengine/godot-proposals/issues/4296 * Helps if you want to export animations to a separate file (say a GLTF) to avoid re-importing/exporting them every time the model changes. * Helps if you simply want to have animations using a dummy model, which can be shared across multiple models. Creates a secondary scene importer used only for animations. **NOTE**: A new flag for scene importer: EditorSceneFormatImporter.IMPORT_DISCARD_MESHES_AND_MATERIALS has been added, to hint importers that they should skip meshes and animations (and hence make importing faster). It is not implemented in any importer yet, this should be done in a separate PR.
2022-04-12 16:07:09 +02:00
ResourceFormatImporter::get_singleton()->add_importer(import_animation);
Scene import more or less working, needs some missing features.
2017-02-04 13:48:04 +01:00
{
Add scene Post-Import Plugin support. * New plugin system to control the whole import workflow * Can add options and run code at every import step (general, per node, mesh, animation, material etc.) This constitutes a first version of these plugins. The ability to interact with the import preview dialog will likely be added later on.
2021-10-14 19:34:27 +02:00
Ref<EditorSceneFormatImporterCollada> import_collada;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
import_collada.instantiate();
Fix referring to ResourceImporterScene static importers via instances
2023-10-08 07:48:53 +02:00
ResourceImporterScene::add_scene_importer(import_collada);
-Reorganized all properties of project settings (Sorry, Again). (Lot's of bloat accumulated, so it was time for clean up.) -Made EditorSettings and ProjectSettings search more useful (search in sections too)
2017-07-18 02:05:38 +02:00
Add -Wshadow=local to warnings and fix reported issues. Fixes #25316.
2019-02-12 21:10:08 +01:00
Ref<EditorOBJImporter> import_obj2;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
import_obj2.instantiate();
Fix referring to ResourceImporterScene static importers via instances
2023-10-08 07:48:53 +02:00
ResourceImporterScene::add_scene_importer(import_obj2);
-Added GLTF scene support (still missing animations and .glb extension) -Fixed bugs regarding tangent generation in SurfaceTool
2017-08-02 20:34:55 +02:00
Add scene Post-Import Plugin support. * New plugin system to control the whole import workflow * Can add options and run code at every import step (general, per node, mesh, animation, material etc.) This constitutes a first version of these plugins. The ability to interact with the import preview dialog will likely be added later on.
2021-10-14 19:34:27 +02:00
Ref<EditorSceneFormatImporterESCN> import_escn;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
import_escn.instantiate();
Fix referring to ResourceImporterScene static importers via instances
2023-10-08 07:48:53 +02:00
ResourceImporterScene::add_scene_importer(import_escn);
Scene import more or less working, needs some missing features.
2017-02-04 13:48:04 +01:00
}
Removed PBM bitmap loader, added abiliy to importi mages as bitmap. Fixes #14828
2018-01-06 20:36:49 +01:00
Ref<ResourceImporterBitMap> import_bitmap;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
import_bitmap.instantiate();
Removed PBM bitmap loader, added abiliy to importi mages as bitmap. Fixes #14828
2018-01-06 20:36:49 +01:00
ResourceFormatImporter::get_singleton()->add_importer(import_bitmap);
Lot of work in new importer, importing textures now works.
2017-02-01 13:45:45 +01:00
}
-New inspector. -Changed UI resizing code, gained huge amount of speed. -Reorganized timer sync to clean up behavior (sorry forgot commit this before) -
2018-05-15 22:12:35 +02:00
{
Ref<EditorInspectorDefaultPlugin> eidp;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
eidp.instantiate();
-New inspector. -Changed UI resizing code, gained huge amount of speed. -Reorganized timer sync to clean up behavior (sorry forgot commit this before) -
2018-05-15 22:12:35 +02:00
EditorInspector::add_inspector_plugin(eidp);
-Add root motion support in AnimationTree. -Add RootMotionView, to debug root motion in 3D (disabled in runtime)
2018-06-27 00:05:11 +02:00
Ref<EditorInspectorRootMotionPlugin> rmp;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
rmp.instantiate();
-Add root motion support in AnimationTree. -Add RootMotionView, to debug root motion in 3D (disabled in runtime)
2018-06-27 00:05:11 +02:00
EditorInspector::add_inspector_plugin(rmp);
Visual Shaders are back.
2018-07-14 23:15:42 +02:00
Rename EditorPropertyShaderMode to EditorPropertyVisualShaderMode
2022-08-15 21:39:53 +02:00
Ref<EditorInspectorVisualShaderModePlugin> smp;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
smp.instantiate();
Visual Shaders are back.
2018-07-14 23:15:42 +02:00
EditorInspector::add_inspector_plugin(smp);
Improve editing of min/max particle properties
2023-10-10 23:48:46 +02:00
Ref<EditorInspectorParticleProcessMaterialPlugin> ppm;
ppm.instantiate();
EditorInspector::add_inspector_plugin(ppm);
-New inspector. -Changed UI resizing code, gained huge amount of speed. -Reorganized timer sync to clean up behavior (sorry forgot commit this before) -
2018-05-15 22:12:35 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
editor_selection = memnew(EditorSelection);
EditorFileSystem *efs = memnew(EditorFileSystem);
add_child(efs);
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Used for previews.
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
FileDialog::get_icon_func = _file_dialog_get_icon;
FileDialog::register_func = _file_dialog_register;
FileDialog::unregister_func = _file_dialog_unregister;
work in progress, resource previews
2015-05-31 06:59:42 +02:00
EditorFileDialog::get_icon_func = _file_dialog_get_icon;
EditorFileDialog::register_func = _editor_file_dialog_register;
EditorFileDialog::unregister_func = _editor_file_dialog_unregister;
Editor Export Settings Dialog is completed!! Now on to make some exporters..
2017-02-20 03:19:30 +01:00
editor_export = memnew(EditorExport);
add_child(editor_export);
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Exporters might need the theme.
Extract editor color map and simplify SVG color conversion
2022-08-23 13:15:31 +02:00
EditorColorMap::create();
Fix StringName leaks in GDExtension, core, and editor themes
2023-10-18 17:36:20 +02:00
EditorTheme::initialize();
Fix EditorNode.get_editor_theme EditorNode was not correctly setting the class memeber when creating the theme, using a local variable instead. Theme is now created before registering exporters (as they might need it).
2019-10-11 13:21:24 +02:00
theme = create_custom_theme();
Add EditorStringNames singleton
2023-08-13 02:33:39 +02:00
DisplayServer::set_early_window_clear_color_override(true, theme->get_color(SNAME("background"), EditorStringName(Editor)));
Fix EditorNode.get_editor_theme EditorNode was not correctly setting the class memeber when creating the theme, using a local variable instead. Theme is now created before registering exporters (as they might need it).
2019-10-11 13:21:24 +02:00
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
register_exporters();
Add a "save on focus loss" editor setting (disabled by default) This performs a Ctrl + S action every time the editor window loses focus, saving both scenes and scripts as needed.
2021-04-11 15:39:31 +02:00
EDITOR_DEF("interface/editor/save_on_focus_loss", false);
Make visibility of update spinner editor-wide, hidden by default - Make visibility of the spinner and "update always" option editor-wide, rather than per-project metadata. - Add options "Show Update Spinner" and "Update Continuously" under Editor Settings > Interface > Editor. Both options are false by default. - Rename some variables and constants to be more consistent and clearer: "update always" -> "update continuously", "update changes" -> "update when changed", "update menu" -> "update spinner", "circle" -> "update spinner". Fixes #23738.
2018-12-11 16:52:25 +01:00
EDITOR_DEF("interface/editor/show_update_spinner", false);
EDITOR_DEF("interface/editor/update_continuously", false);
Add property name style toggle to Inspector
2022-03-23 02:46:59 +01:00
EDITOR_DEF("interface/editor/localize_settings", true);
Make restore_scenes_on_load true by default
2021-09-12 16:11:56 +02:00
EDITOR_DEF_RST("interface/scene_tabs/restore_scenes_on_load", true);
Add property name style toggle to Inspector
2022-03-23 02:46:59 +01:00
EDITOR_DEF_RST("interface/inspector/default_property_name_style", EditorPropertyNameProcessor::STYLE_CAPITALIZED);
EditorSettings::get_singleton()->add_property_hint(PropertyInfo(Variant::INT, "interface/inspector/default_property_name_style", PROPERTY_HINT_ENUM, "Raw,Capitalized,Localized"));
Inspector: Make default float step configurable Also allow lifting the decimal step formatting with a hint range step of 0. A new `range_step_decimals()` is added for this to avoid breaking compatibility on the general purpose `step_decimals()` (which still returns 0 for an input step of 0). Supersedes #25470. Partial fix for #18251.
2019-07-23 17:27:55 +02:00
EDITOR_DEF_RST("interface/inspector/default_float_step", 0.001);
Fix some properties having an invalid float step of `0` This also clamps the float step in the editor to the lowest value that is guaranteed to work in all situations (including for 32-bit floats).
2022-03-04 19:59:12 +01:00
// The lowest value is equal to the minimum float step for 32-bit floats.
// The step must be set manually, as changing this setting should not change the step here.
EditorSettings::get_singleton()->add_property_hint(PropertyInfo(Variant::FLOAT, "interface/inspector/default_float_step", PROPERTY_HINT_RANGE, "0.0000001,1,0.0000001"));
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
EDITOR_DEF_RST("interface/inspector/disable_folding", false);
Rewrite code for unfolding and make it automatic on scene load, which works better.
2018-11-25 14:46:26 +01:00
EDITOR_DEF_RST("interface/inspector/auto_unfold_foreign_scenes", true);
Several improvements to inspector. -Added optional horizontal/vertical modes for vector editing (default false for vec2, true for vec3) -Some clean ups with fonts and styles
2018-08-07 17:19:19 +02:00
EDITOR_DEF("interface/inspector/horizontal_vector2_editing", false);
Make Rect2 EditorProperty obey the horizontal setting
2018-09-23 05:20:36 +02:00
EDITOR_DEF("interface/inspector/horizontal_vector_types_editing", true);
Visual Shaders are back.
2018-07-14 23:15:42 +02:00
EDITOR_DEF("interface/inspector/open_resources_in_current_inspector", true);
Use a PackedStringArray for the "open in new inspector" editor setting This is safer and provides a more convenient array editor for users.
2021-08-23 18:59:26 +02:00
PackedStringArray open_in_new_inspector_defaults;
// Required for the script editor to work.
open_in_new_inspector_defaults.push_back("Script");
// Required for the GridMap editor to work.
open_in_new_inspector_defaults.push_back("MeshLibrary");
EDITOR_DEF("interface/inspector/resources_to_open_in_new_inspector", open_in_new_inspector_defaults);
Default ColorPicker color mode setting There is a new setting for Default ColorPicker color mode in Editor Settings->Interface->Inspector. Initially this setting will be RGB. Editor ColorPicker will always start with mode defined in this settiing. Fixes #30755 and #30754
2019-08-30 22:25:15 +02:00
EDITOR_DEF("interface/inspector/default_color_picker_mode", 0);
ColorPicker Refactor
2022-05-29 17:17:37 +02:00
EditorSettings::get_singleton()->add_property_hint(PropertyInfo(Variant::INT, "interface/inspector/default_color_picker_mode", PROPERTY_HINT_ENUM, "RGB,HSV,RAW,OKHSL", PROPERTY_USAGE_DEFAULT));
Allow picking similar colours using OKHSL.
2022-04-18 20:29:29 +02:00
EDITOR_DEF("interface/inspector/default_color_picker_shape", (int32_t)ColorPicker::SHAPE_OKHSL_CIRCLE);
EditorSettings::get_singleton()->add_property_hint(PropertyInfo(Variant::INT, "interface/inspector/default_color_picker_shape", PROPERTY_HINT_ENUM, "HSV Rectangle,HSV Rectangle Wheel,VHS Circle,OKHSL Circle", PROPERTY_USAGE_DEFAULT));
Add ViewPanner to 2D editor
2022-01-19 19:59:12 +01:00
ED_SHORTCUT("canvas_item_editor/pan_view", TTR("Pan View"), Key::SPACE);
-Ability to open resources in the same window -Plenty of fixes and improvements to new inspector -Fixes that were needed to make inspector work better
2018-05-17 23:02:16 +02:00
Unify usage of GLOBAL/EDITOR_GET
2022-10-18 16:43:37 +02:00
const Vector<String> textfile_ext = ((String)(EDITOR_GET("docks/filesystem/textfile_extensions"))).split(",", false);
Add TextFile support across the editor
2021-09-23 23:09:15 +02:00
for (const String &E : textfile_ext) {
textfile_extensions.insert(E);
}
work in progress, resource previews
2015-05-31 06:59:42 +02:00
resource_preview = memnew(EditorResourcePreview);
add_child(resource_preview);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
progress_dialog = memnew(ProgressDialog);
Fix auto-reparenting logic in the `ProgressDialog` * Make sure `Popup` signals are disconnected when unparented. * Remove a fail condition from `Window::is_embedded` when not in tree.
2023-05-29 17:00:09 +02:00
progress_dialog->set_unparent_when_invisible(true);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
gui_base = memnew(Panel);
add_child(gui_base);
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Take up all screen.
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
gui_base->set_anchors_and_offsets_preset(Control::PRESET_FULL_RECT);
Rename Control margin to offset
2020-12-22 17:24:29 +01:00
gui_base->set_anchor(SIDE_RIGHT, Control::ANCHOR_END);
gui_base->set_anchor(SIDE_BOTTOM, Control::ANCHOR_END);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
gui_base->set_end(Point2(0, 0));
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
main_vbox = memnew(VBoxContainer);
gui_base->add_child(main_vbox);
Extract editor run toolbar into its own component - Simplify and update its logic. - Simplify EditorScript. - Improve EditorNode and other relevant includes. - Fix scene-based path in the movie writer when reloading a scene.
2023-04-12 21:02:28 +02:00
title_bar = memnew(EditorTitleBar);
main_vbox->add_child(title_bar);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
left_l_hsplit = memnew(HSplitContainer);
main_vbox->add_child(left_l_hsplit);
left_l_hsplit->set_v_size_flags(Control::SIZE_EXPAND_FILL);
left_l_vsplit = memnew(VSplitContainer);
left_l_hsplit->add_child(left_l_vsplit);
dock_slot[DOCK_SLOT_LEFT_UL] = memnew(TabContainer);
left_l_vsplit->add_child(dock_slot[DOCK_SLOT_LEFT_UL]);
dock_slot[DOCK_SLOT_LEFT_BL] = memnew(TabContainer);
left_l_vsplit->add_child(dock_slot[DOCK_SLOT_LEFT_BL]);
left_r_hsplit = memnew(HSplitContainer);
left_l_hsplit->add_child(left_r_hsplit);
left_r_vsplit = memnew(VSplitContainer);
left_r_hsplit->add_child(left_r_vsplit);
dock_slot[DOCK_SLOT_LEFT_UR] = memnew(TabContainer);
left_r_vsplit->add_child(dock_slot[DOCK_SLOT_LEFT_UR]);
dock_slot[DOCK_SLOT_LEFT_BR] = memnew(TabContainer);
left_r_vsplit->add_child(dock_slot[DOCK_SLOT_LEFT_BR]);
main_hsplit = memnew(HSplitContainer);
left_r_hsplit->add_child(main_hsplit);
-fixed tabs
2015-11-18 08:47:41 +01:00
VBoxContainer *center_vb = memnew(VBoxContainer);
main_hsplit->add_child(center_vb);
center_vb->set_h_size_flags(Control::SIZE_EXPAND_FILL);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
center_split = memnew(VSplitContainer);
-fixed tabs
2015-11-18 08:47:41 +01:00
center_split->set_v_size_flags(Control::SIZE_EXPAND_FILL);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
center_split->set_collapsed(false);
-fixed tabs
2015-11-18 08:47:41 +01:00
center_vb->add_child(center_split);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
right_hsplit = memnew(HSplitContainer);
main_hsplit->add_child(right_hsplit);
right_l_vsplit = memnew(VSplitContainer);
right_hsplit->add_child(right_l_vsplit);
dock_slot[DOCK_SLOT_RIGHT_UL] = memnew(TabContainer);
right_l_vsplit->add_child(dock_slot[DOCK_SLOT_RIGHT_UL]);
dock_slot[DOCK_SLOT_RIGHT_BL] = memnew(TabContainer);
right_l_vsplit->add_child(dock_slot[DOCK_SLOT_RIGHT_BL]);
right_r_vsplit = memnew(VSplitContainer);
right_hsplit->add_child(right_r_vsplit);
dock_slot[DOCK_SLOT_RIGHT_UR] = memnew(TabContainer);
right_r_vsplit->add_child(dock_slot[DOCK_SLOT_RIGHT_UR]);
dock_slot[DOCK_SLOT_RIGHT_BR] = memnew(TabContainer);
right_r_vsplit->add_child(dock_slot[DOCK_SLOT_RIGHT_BR]);
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Store them for easier access.
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
vsplits.push_back(left_l_vsplit);
vsplits.push_back(left_r_vsplit);
vsplits.push_back(right_l_vsplit);
vsplits.push_back(right_r_vsplit);
hsplits.push_back(left_l_hsplit);
hsplits.push_back(left_r_hsplit);
hsplits.push_back(main_hsplit);
hsplits.push_back(right_hsplit);
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
for (int i = 0; i < vsplits.size(); i++) {
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
vsplits[i]->connect("dragged", callable_mp(this, &EditorNode::_dock_split_dragged));
hsplits[i]->connect("dragged", callable_mp(this, &EditorNode::_dock_split_dragged));
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
EditorNode: remove obsolete comments in constructor
2017-07-18 15:04:20 +02:00
dock_select_popup = memnew(PopupPanel);
gui_base->add_child(dock_select_popup);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
VBoxContainer *dock_vb = memnew(VBoxContainer);
EditorNode: remove obsolete comments in constructor
2017-07-18 15:04:20 +02:00
dock_select_popup->add_child(dock_vb);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
HBoxContainer *dock_hb = memnew(HBoxContainer);
Remove ToolButton in favor of Button ToolButton has no redeeming differences with Button; it's just a Button with the Flat property enabled by default. Removing it avoids some confusion when creating GUIs. Existing ToolButtons will be converted to Buttons, but the Flat property won't be enabled automatically. This closes https://github.com/godotengine/godot-proposals/issues/1081.
2020-06-19 20:49:04 +02:00
dock_tab_move_left = memnew(Button);
dock_tab_move_left->set_flat(true);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
dock_tab_move_left->set_focus_mode(Control::FOCUS_NONE);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
dock_tab_move_left->connect("pressed", callable_mp(this, &EditorNode::_dock_move_left));
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
dock_hb->add_child(dock_tab_move_left);
Added a label to the Dock Positioner.
2017-11-19 06:00:42 +01:00
Label *dock_label = memnew(Label);
dock_label->set_text(TTR("Dock Position"));
dock_label->set_h_size_flags(Control::SIZE_EXPAND_FILL);
align to horizontal_alignment, valign to vertical_alignment, related
2021-11-25 03:58:47 +01:00
dock_label->set_horizontal_alignment(HORIZONTAL_ALIGNMENT_CENTER);
Added a label to the Dock Positioner.
2017-11-19 06:00:42 +01:00
dock_hb->add_child(dock_label);
Remove ToolButton in favor of Button ToolButton has no redeeming differences with Button; it's just a Button with the Flat property enabled by default. Removing it avoids some confusion when creating GUIs. Existing ToolButtons will be converted to Buttons, but the Flat property won't be enabled automatically. This closes https://github.com/godotengine/godot-proposals/issues/1081.
2020-06-19 20:49:04 +02:00
dock_tab_move_right = memnew(Button);
dock_tab_move_right->set_flat(true);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
dock_tab_move_right->set_focus_mode(Control::FOCUS_NONE);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
dock_tab_move_right->connect("pressed", callable_mp(this, &EditorNode::_dock_move_right));
fixes for dock motion
2015-06-14 05:41:08 +02:00
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
dock_hb->add_child(dock_tab_move_right);
dock_vb->add_child(dock_hb);
dock_select = memnew(Control);
Fixes the editor layout
2018-10-26 12:44:49 +02:00
dock_select->set_custom_minimum_size(Size2(128, 64) * EDSCALE);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
dock_select->connect("gui_input", callable_mp(this, &EditorNode::_dock_select_input));
dock_select->connect("draw", callable_mp(this, &EditorNode::_dock_select_draw));
dock_select->connect("mouse_exited", callable_mp(this, &EditorNode::_dock_popup_exit));
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
dock_select->set_v_size_flags(Control::SIZE_EXPAND_FILL);
dock_vb->add_child(dock_select);
Make the single window mode check more strict Check the "interface/editor/single_window_mode" editor settings.
2023-07-22 17:24:47 +02:00
if (!SceneTree::get_singleton()->get_root()->is_embedding_subwindows() && !EDITOR_GET("interface/editor/single_window_mode") && EDITOR_GET("interface/multi_window/enable")) {
Add multi window code and shader editors
2022-11-02 15:23:25 +01:00
dock_float = memnew(Button);
Add EditorStringNames singleton
2023-08-13 02:33:39 +02:00
dock_float->set_icon(theme->get_icon("MakeFloating", EditorStringName(EditorIcons)));
Add multi window code and shader editors
2022-11-02 15:23:25 +01:00
dock_float->set_text(TTR("Make Floating"));
dock_float->set_focus_mode(Control::FOCUS_NONE);
dock_float->set_h_size_flags(Control::SIZE_SHRINK_CENTER);
dock_float->connect("pressed", callable_mp(this, &EditorNode::_dock_make_selected_float));
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
Add multi window code and shader editors
2022-11-02 15:23:25 +01:00
dock_vb->add_child(dock_float);
}
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
Remove set_as_minsize()
2022-03-06 00:57:42 +01:00
dock_select_popup->reset_size();
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
for (int i = 0; i < DOCK_SLOT_MAX; i++) {
Fixes the editor layout
2018-10-26 12:44:49 +02:00
dock_slot[i]->set_custom_minimum_size(Size2(170, 0) * EDSCALE);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
dock_slot[i]->set_v_size_flags(Control::SIZE_EXPAND_FILL);
EditorNode: remove obsolete comments in constructor
2017-07-18 15:04:20 +02:00
dock_slot[i]->set_popup(dock_select_popup);
Remove Signal connect binds Remove the optional argument p_binds from `Object::connect` since it was deprecated by Callable.bind(). Changed all uses of it to Callable.bind()
2022-07-28 22:56:41 +02:00
dock_slot[i]->connect("pre_popup_pressed", callable_mp(this, &EditorNode::_dock_pre_popup).bind(i));
Drag to rearrange Tabs and TabContainer
2018-02-07 14:01:45 +01:00
dock_slot[i]->set_drag_to_rearrange_enabled(true);
dock_slot[i]->set_tabs_rearrange_group(1);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
dock_slot[i]->connect("tab_changed", callable_mp(this, &EditorNode::_dock_tab_changed));
Make tab containers in editor, project settings, and export dialog, to use hidden tabs for min size computation.
2019-01-26 19:41:36 +01:00
dock_slot[i]->set_use_hidden_tabs_for_min_size(true);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Improve editor state persistence
2023-05-11 04:17:03 +02:00
editor_layout_save_delay_timer = memnew(Timer);
add_child(editor_layout_save_delay_timer);
editor_layout_save_delay_timer->set_wait_time(0.5);
editor_layout_save_delay_timer->set_one_shot(true);
editor_layout_save_delay_timer->connect("timeout", callable_mp(this, &EditorNode::_save_editor_layout));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
top_split = memnew(VSplitContainer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
center_split->add_child(top_split);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
top_split->set_v_size_flags(Control::SIZE_EXPAND_FILL);
top_split->set_collapsed(true);
VBoxContainer *srt = memnew(VBoxContainer);
srt->set_v_size_flags(Control::SIZE_EXPAND_FILL);
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 10:14:58 +01:00
srt->add_theme_constant_override("separation", 0);
Extract editor scene tabs into their own component
2023-08-24 12:24:29 +02:00
top_split->add_child(srt);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Extract editor scene tabs into their own component
2023-08-24 12:24:29 +02:00
scene_tabs = memnew(EditorSceneTabs);
srt->add_child(scene_tabs);
scene_tabs->connect("tab_changed", callable_mp(this, &EditorNode::_set_current_scene));
scene_tabs->connect("tab_closed", callable_mp(this, &EditorNode::_scene_tab_closed));
Fix buggy behavior of the "Add tab" button in the scene tabs
2022-01-23 16:42:52 +01:00
Remove ToolButton in favor of Button ToolButton has no redeeming differences with Button; it's just a Button with the Flat property enabled by default. Removing it avoids some confusion when creating GUIs. Existing ToolButtons will be converted to Buttons, but the Flat property won't be enabled automatically. This closes https://github.com/godotengine/godot-proposals/issues/1081.
2020-06-19 20:49:04 +02:00
distraction_free = memnew(Button);
distraction_free->set_flat(true);
Fix key mapping changes when moving from macOS to other platform Removes separate `Command` key (use `Meta` instead). Adds an event flag to automatically remap `Command` <-> `Control` (cannot be set alongside `Control` or `Meta`).
2022-09-02 11:37:48 +02:00
ED_SHORTCUT_AND_COMMAND("editor/distraction_free_mode", TTR("Distraction Free Mode"), KeyModifierMask::CTRL | KeyModifierMask::SHIFT | Key::F11);
ED_SHORTCUT_OVERRIDE("editor/distraction_free_mode", "macos", KeyModifierMask::META | KeyModifierMask::CTRL | Key::D);
Added ability to override shortcut definitions for OSX (remove preprocessor defines)
2021-08-08 05:52:00 +02:00
distraction_free->set_shortcut(ED_GET_SHORTCUT("editor/distraction_free_mode"));
Rename `hint_tooltip` to `tooltip_text` & setget `hint_tooltip` -> `tooltip_text` `set_tooltip` -> `set_tooltip_text` `_get_tooltip` -> `get_tooltip_text` Updates documentation, too.
2022-08-25 12:42:17 +02:00
distraction_free->set_tooltip_text(TTR("Toggle distraction-free mode."));
Join text menus on the top-left, move shortcut buttons to new location
2017-05-24 12:00:55 +02:00
distraction_free->set_toggle_mode(true);
Extract editor scene tabs into their own component
2023-08-24 12:24:29 +02:00
scene_tabs->add_extra_button(distraction_free);
distraction_free->connect("pressed", callable_mp(this, &EditorNode::_toggle_distraction_free_mode));
add scene button and tab scrolling
2017-11-16 23:57:57 +01:00
-Property apply limits to V/H Splits in main editor window. Fixes #3567
2016-02-08 17:01:54 +01:00
scene_root_parent = memnew(PanelContainer);
-Some fixes to OSX retina scaling for window functions -Implemented HiDPI detection and support for Godot Editor!
2016-05-30 05:28:29 +02:00
scene_root_parent->set_custom_minimum_size(Size2(0, 80) * EDSCALE);
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
scene_root_parent->add_theme_style_override("panel", theme->get_stylebox(SNAME("Content"), EditorStringName(EditorStyles)));
Added border for tabs + container. - moved tabConetent position to be more reasonable. - fixed drawing order to allow those kind of styles.
2017-09-02 03:29:04 +02:00
scene_root_parent->set_draw_behind_parent(true);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
srt->add_child(scene_root_parent);
scene_root_parent->set_v_size_flags(Control::SIZE_EXPAND_FILL);
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 02:51:12 +01:00
scene_root = memnew(SubViewport);
Cleanup embed subwindows getters
2022-03-13 16:18:44 +01:00
scene_root->set_embedding_subwindows(true);
Fixes to 2D viewport * Editor 2D viewport now uses embedded subwindows (windows no longer pop up) * Restored the ability to disable 3D on the 2D viewport (makes 3D not display on 2D when there is a camera on the scene)
2021-06-29 18:36:32 +02:00
scene_root->set_disable_3d(true);
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 02:41:10 +01:00
scene_root->set_disable_input(true);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
scene_root->set_as_audio_listener_2d(true);
Rename EditorInterface.get_editor_main_control to get_editor_main_screen
2022-09-07 01:30:54 +02:00
main_screen_vbox = memnew(VBoxContainer);
main_screen_vbox->set_name("MainScreen");
main_screen_vbox->set_v_size_flags(Control::SIZE_EXPAND_FILL);
main_screen_vbox->add_theme_constant_override("separation", 0);
scene_root_parent->add_child(main_screen_vbox);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
bool global_menu = !bool(EDITOR_GET("interface/editor/use_embedded_menu")) && DisplayServer::get_singleton()->has_feature(DisplayServer::FEATURE_GLOBAL_MENU);
[macOS] Extend editor contents to the window titlebar for better space usage.
2022-08-23 12:40:48 +02:00
bool can_expand = bool(EDITOR_GET("interface/editor/expand_to_title")) && DisplayServer::get_singleton()->has_feature(DisplayServer::FEATURE_EXTEND_TO_TITLE);
if (can_expand) {
// Add spacer to avoid other controls under window minimize/maximize/close buttons (left side).
[macOS extend-to-title] Add scene/project name to the editor title, fix incorrect window button position/order when system primary language is RTL.
2022-09-22 11:06:11 +02:00
left_menu_spacer = memnew(Control);
left_menu_spacer->set_mouse_filter(Control::MOUSE_FILTER_PASS);
Extract editor run toolbar into its own component - Simplify and update its logic. - Simplify EditorScript. - Improve EditorNode and other relevant includes. - Fix scene-based path in the movie writer when reloading a scene.
2023-04-12 21:02:28 +02:00
title_bar->add_child(left_menu_spacer);
[macOS] Extend editor contents to the window titlebar for better space usage.
2022-08-23 12:40:48 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
main_menu = memnew(MenuBar);
Extract editor run toolbar into its own component - Simplify and update its logic. - Simplify EditorScript. - Improve EditorNode and other relevant includes. - Fix scene-based path in the movie writer when reloading a scene.
2023-04-12 21:02:28 +02:00
title_bar->add_child(main_menu);
[macOS extend-to-title] Add scene/project name to the editor title, fix incorrect window button position/order when system primary language is RTL.
2022-09-22 11:06:11 +02:00
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
main_menu->add_theme_style_override("hover", theme->get_stylebox(SNAME("MenuHover"), EditorStringName(EditorStyles)));
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
main_menu->set_flat(true);
main_menu->set_start_index(0); // Main menu, add to the start of global menu.
main_menu->set_prefer_global_menu(global_menu);
main_menu->set_switch_on_hover(true);
file_menu = memnew(PopupMenu);
file_menu->set_name(TTR("Scene"));
main_menu->add_child(file_menu);
main_menu->set_menu_tooltip(0, TTR("Operations with scene files."));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Expose dialog parent-and-popup logic to the API
2023-04-20 15:13:21 +02:00
accept = memnew(AcceptDialog);
accept->set_unparent_when_invisible(true);
Fix a crash when an early dialog tries to appear This changes the order of creating some of the dialogs that may appear during project import/startup. It is possible for the 'accept' dialog to be required before it is initialized. This moves all of these dialogs to earlier in the constructor so this can't happen.
2017-08-30 13:59:48 +02:00
Expose dialog parent-and-popup logic to the API
2023-04-20 15:13:21 +02:00
save_accept = memnew(AcceptDialog);
save_accept->set_unparent_when_invisible(true);
Remove Signal connect binds Remove the optional argument p_binds from `Object::connect` since it was deprecated by Callable.bind(). Changed all uses of it to Callable.bind()
2022-07-28 22:56:41 +02:00
save_accept->connect("confirmed", callable_mp(this, &EditorNode::_menu_option).bind((int)MenuOptions::FILE_SAVE_AS_SCENE));
Corrected Save Scene and Save All Scenes not working when the scene's dir no longer exists
2021-09-11 03:35:13 +02:00
Fix a crash when an early dialog tries to appear This changes the order of creating some of the dialogs that may appear during project import/startup. It is possible for the 'accept' dialog to be required before it is initialized. This moves all of these dialogs to earlier in the constructor so this can't happen.
2017-08-30 13:59:48 +02:00
project_export = memnew(ProjectExportDialog);
gui_base->add_child(project_export);
dependency_error = memnew(DependencyErrorDialog);
gui_base->add_child(dependency_error);
dependency_fixer = memnew(DependencyEditor);
gui_base->add_child(dependency_fixer);
Minor fixes/refactoring of project and editor setting dialogs
2022-02-01 00:19:01 +01:00
editor_settings_dialog = memnew(EditorSettingsDialog);
gui_base->add_child(editor_settings_dialog);
Fix a crash when an early dialog tries to appear This changes the order of creating some of the dialogs that may appear during project import/startup. It is possible for the 'accept' dialog to be required before it is initialized. This moves all of these dialogs to earlier in the constructor so this can't happen.
2017-08-30 13:59:48 +02:00
Minor fixes/refactoring of project and editor setting dialogs
2022-02-01 00:19:01 +01:00
project_settings_editor = memnew(ProjectSettingsEditor(&editor_data));
gui_base->add_child(project_settings_editor);
Fix a crash when an early dialog tries to appear This changes the order of creating some of the dialogs that may appear during project import/startup. It is possible for the 'accept' dialog to be required before it is initialized. This moves all of these dialogs to earlier in the constructor so this can't happen.
2017-08-30 13:59:48 +02:00
Rename ImportSettings dialogs to have "Dialog" in the name
2023-10-06 09:00:36 +02:00
scene_import_settings = memnew(SceneImportSettingsDialog);
Improved 3D Scene Importer * Added option for importers to show an Advanced settings dialog * Created advanced settings dialog for Scene Importer * Cleaned up importers (remove many old/unused options) * Added the ability to customize every node, material, mesh and animation individually * Saving to animations and meshes to files is now a manual process, making it more predictable * Added the ability for materials to be replaced by external files (or to be made external, up to you). * When doubleclicking an impoted scene in the filesystem dock, it automatically shows the import settings instead of asking to open it. WARNING: Lightmap UV unwrap is not working, it needs to be re-made.
2021-03-19 13:57:52 +01:00
gui_base->add_child(scene_import_settings);
Rename ImportSettings dialogs to have "Dialog" in the name
2023-10-06 09:00:36 +02:00
audio_stream_import_settings = memnew(AudioStreamImportSettingsDialog);
Implement BPM support Based on #62896, only implements the BPM support part. * Implements BPM support in the AudioStreamOGG/MP3 importers. * Can select BPM/Bar Size and total beats in a song file, as well as edit looping points. * Looping is now BPM aware * Added a special importer UI for configuring this. * Added a special preview showing the audio waveform as well as the playback position in the resource picker. * Renamed `AudioStream::instance` to `instantiate` for correctness.
2022-07-21 01:00:58 +02:00
gui_base->add_child(audio_stream_import_settings);
Rename ImportSettings dialogs to have "Dialog" in the name
2023-10-06 09:00:36 +02:00
fontdata_import_settings = memnew(DynamicFontImportSettingsDialog);
Makes FontData importable resource. Adds multi-channel SDF font texture generation and rendering support. Adds per-font oversampling support. Adds FontData import plugins (for dynamic fonts, BMFonts and monospaced image fonts), font texture cache pre-generation and loading. Adds BMFont binary format and outline support.
2020-12-27 14:30:33 +01:00
gui_base->add_child(fontdata_import_settings);
Fix a crash when an early dialog tries to appear This changes the order of creating some of the dialogs that may appear during project import/startup. It is possible for the 'accept' dialog to be required before it is initialized. This moves all of these dialogs to earlier in the constructor so this can't happen.
2017-08-30 13:59:48 +02:00
export_template_manager = memnew(ExportTemplateManager);
gui_base->add_child(export_template_manager);
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
feature_profile_manager = memnew(EditorFeatureProfileManager);
gui_base->add_child(feature_profile_manager);
Implement Feature Build Profiles This PR is a continuation of #50381 (which was implemented exactly a year ago!) * Add a visual interface to select which classes should not be built into Godot (well, they are built if something else uses them, but if not used the optimizer will remove them out). * Add a detection system to scan the project and figure out the actual classes used. * Added the ability for SCons to load build profiles. Obligatory Screen: A simple test with a couple of nodes in the scene resulted in a 25% reduction for the final binary size TODO: * Script languages need to implement used class detection (left for another PR). * Options to disable servers or server functionalities (like 2D or 3D physics, navigation, etc). Are missing, that should also greatly aid in reducing binary size. * Options to disable some modules would be desired. * More options to disable drivers (OpenGL, Vulkan, etc) would be desired. In general this PR is a starting point for more contributors to improve and enhance this functionality.
2022-07-14 14:18:18 +02:00
build_profile_manager = memnew(EditorBuildProfileManager);
gui_base->add_child(build_profile_manager);
Fix a crash when an early dialog tries to appear This changes the order of creating some of the dialogs that may appear during project import/startup. It is possible for the 'accept' dialog to be required before it is initialized. This moves all of these dialogs to earlier in the constructor so this can't happen.
2017-08-30 13:59:48 +02:00
about = memnew(EditorAbout);
gui_base->add_child(about);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
feature_profile_manager->connect("current_feature_profile_changed", callable_mp(this, &EditorNode::_feature_profile_changed));
Fix a crash when an early dialog tries to appear This changes the order of creating some of the dialogs that may appear during project import/startup. It is possible for the 'accept' dialog to be required before it is initialized. This moves all of these dialogs to earlier in the constructor so this can't happen.
2017-08-30 13:59:48 +02:00
Add a dialog for customizing FBX import * If FBX files are found, a dialog will pop up asking to configure FBX2glTF. * Dialog can also be accessed by going Editor -> Configure FBX Import. * The dialog also shows a link to click to download the converter, which should contain instructions.
2022-04-02 13:43:15 +02:00
#if !defined(ANDROID_ENABLED) && !defined(WEB_ENABLED)
fbx_importer_manager = memnew(FBXImporterManager);
gui_base->add_child(fbx_importer_manager);
#endif
Expose dialog parent-and-popup logic to the API
2023-04-20 15:13:21 +02:00
warning = memnew(AcceptDialog);
warning->set_unparent_when_invisible(true);
Add a way to copy the text of warnings shown in the editor Closes #20662
2019-07-09 20:11:31 +02:00
warning->add_button(TTR("Copy Text"), true, "copy");
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
warning->connect("custom_action", callable_mp(this, &EditorNode::_copy_warning));
Fix a crash when an early dialog tries to appear This changes the order of creating some of the dialogs that may appear during project import/startup. It is possible for the 'accept' dialog to be required before it is initialized. This moves all of these dialogs to earlier in the constructor so this can't happen.
2017-08-30 13:59:48 +02:00
Fix key mapping changes when moving from macOS to other platform Removes separate `Command` key (use `Meta` instead). Adds an event flag to automatically remap `Command` <-> `Control` (cannot be set alongside `Control` or `Meta`).
2022-09-02 11:37:48 +02:00
ED_SHORTCUT("editor/next_tab", TTR("Next Scene Tab"), KeyModifierMask::CMD_OR_CTRL + Key::TAB);
ED_SHORTCUT("editor/prev_tab", TTR("Previous Scene Tab"), KeyModifierMask::CMD_OR_CTRL + KeyModifierMask::SHIFT + Key::TAB);
ED_SHORTCUT("editor/filter_files", TTR("Focus FileSystem Filter"), KeyModifierMask::CMD_OR_CTRL + KeyModifierMask::ALT + Key::P);
Added EditorCommandPalette
2021-05-29 15:28:16 +02:00
command_palette = EditorCommandPalette::get_singleton();
command_palette->set_title(TTR("Command Palette"));
gui_base->add_child(command_palette);
Fix key mapping changes when moving from macOS to other platform Removes separate `Command` key (use `Meta` instead). Adds an event flag to automatically remap `Command` <-> `Control` (cannot be set alongside `Control` or `Meta`).
2022-09-02 11:37:48 +02:00
file_menu->add_shortcut(ED_SHORTCUT_AND_COMMAND("editor/new_scene", TTR("New Scene"), KeyModifierMask::CMD_OR_CTRL + Key::N), FILE_NEW_SCENE);
file_menu->add_shortcut(ED_SHORTCUT_AND_COMMAND("editor/new_inherited_scene", TTR("New Inherited Scene..."), KeyModifierMask::CMD_OR_CTRL + KeyModifierMask::SHIFT + Key::N), FILE_NEW_INHERITED_SCENE);
file_menu->add_shortcut(ED_SHORTCUT_AND_COMMAND("editor/open_scene", TTR("Open Scene..."), KeyModifierMask::CMD_OR_CTRL + Key::O), FILE_OPEN_SCENE);
file_menu->add_shortcut(ED_SHORTCUT_AND_COMMAND("editor/reopen_closed_scene", TTR("Reopen Closed Scene"), KeyModifierMask::CMD_OR_CTRL + KeyModifierMask::SHIFT + Key::T), FILE_OPEN_PREV);
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
file_menu->add_submenu_item(TTR("Open Recent"), "RecentScenes", FILE_OPEN_RECENT);
Add Undo Close Tab option in tabs context menu
2019-04-10 17:21:26 +02:00
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
file_menu->add_separator();
Fix key mapping changes when moving from macOS to other platform Removes separate `Command` key (use `Meta` instead). Adds an event flag to automatically remap `Command` <-> `Control` (cannot be set alongside `Control` or `Meta`).
2022-09-02 11:37:48 +02:00
file_menu->add_shortcut(ED_SHORTCUT_AND_COMMAND("editor/save_scene", TTR("Save Scene"), KeyModifierMask::CMD_OR_CTRL + Key::S), FILE_SAVE_SCENE);
file_menu->add_shortcut(ED_SHORTCUT_AND_COMMAND("editor/save_scene_as", TTR("Save Scene As..."), KeyModifierMask::CMD_OR_CTRL + KeyModifierMask::SHIFT + Key::S), FILE_SAVE_AS_SCENE);
file_menu->add_shortcut(ED_SHORTCUT_AND_COMMAND("editor/save_all_scenes", TTR("Save All Scenes"), KeyModifierMask::CMD_OR_CTRL + KeyModifierMask::SHIFT + KeyModifierMask::ALT + Key::S), FILE_SAVE_ALL_SCENES);
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
file_menu->add_separator();
Reorganize various menus for consistency and conciseness - Clean up the recent scripts dialog to match the recent scenes dialog - Add "..." at the end of shortcuts that cause a modal dialog to appear This closes #31148.
2019-08-12 22:23:00 +02:00
Add Ctrl/CMD+P as a shortcut to quick open files in addition to Shift+Alt+O
2023-09-16 23:32:37 +02:00
file_menu->add_shortcut(ED_SHORTCUT_ARRAY_AND_COMMAND("editor/quick_open", TTR("Quick Open..."), { int32_t(KeyModifierMask::SHIFT + KeyModifierMask::ALT + Key::O), int32_t(KeyModifierMask::CMD_OR_CTRL + Key::P) }), FILE_QUICK_OPEN);
ED_SHORTCUT_OVERRIDE_ARRAY("editor/quick_open", "macos", { int32_t(KeyModifierMask::META + KeyModifierMask::CTRL + Key::O), int32_t(KeyModifierMask::CMD_OR_CTRL + Key::P) });
Fix key mapping changes when moving from macOS to other platform Removes separate `Command` key (use `Meta` instead). Adds an event flag to automatically remap `Command` <-> `Control` (cannot be set alongside `Control` or `Meta`).
2022-09-02 11:37:48 +02:00
file_menu->add_shortcut(ED_SHORTCUT_AND_COMMAND("editor/quick_open_scene", TTR("Quick Open Scene..."), KeyModifierMask::CMD_OR_CTRL + KeyModifierMask::SHIFT + Key::O), FILE_QUICK_OPEN_SCENE);
file_menu->add_shortcut(ED_SHORTCUT_AND_COMMAND("editor/quick_open_script", TTR("Quick Open Script..."), KeyModifierMask::CMD_OR_CTRL + KeyModifierMask::ALT + Key::O), FILE_QUICK_OPEN_SCRIPT);
Reorganize various menus for consistency and conciseness - Clean up the recent scripts dialog to match the recent scenes dialog - Add "..." at the end of shortcuts that cause a modal dialog to appear This closes #31148.
2019-08-12 22:23:00 +02:00
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
file_menu->add_separator();
move gltf export under scene menu
2022-04-06 14:41:04 +02:00
export_as_menu = memnew(PopupMenu);
export_as_menu->set_name("Export");
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
file_menu->add_child(export_as_menu);
file_menu->add_submenu_item(TTR("Export As..."), "Export");
move gltf export under scene menu
2022-04-06 14:41:04 +02:00
export_as_menu->add_shortcut(ED_SHORTCUT("editor/export_as_mesh_library", TTR("MeshLibrary...")), FILE_EXPORT_MESH_LIBRARY);
export_as_menu->connect("index_pressed", callable_mp(this, &EditorNode::_export_as_menu_option));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
file_menu->add_separator();
Add option to allow echo events in menu shortcuts
2020-02-23 22:23:34 +01:00
file_menu->add_shortcut(ED_GET_SHORTCUT("ui_undo"), EDIT_UNDO, true, true);
file_menu->add_shortcut(ED_GET_SHORTCUT("ui_redo"), EDIT_REDO, true, true);
Reorganize various menus for consistency and conciseness - Clean up the recent scripts dialog to match the recent scenes dialog - Add "..." at the end of shortcuts that cause a modal dialog to appear This closes #31148.
2019-08-12 22:23:00 +02:00
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
file_menu->add_separator();
file_menu->add_shortcut(ED_SHORTCUT_AND_COMMAND("editor/reload_saved_scene", TTR("Reload Saved Scene")), EDIT_RELOAD_SAVED_SCENE);
Fix key mapping changes when moving from macOS to other platform Removes separate `Command` key (use `Meta` instead). Adds an event flag to automatically remap `Command` <-> `Control` (cannot be set alongside `Control` or `Meta`).
2022-09-02 11:37:48 +02:00
file_menu->add_shortcut(ED_SHORTCUT_AND_COMMAND("editor/close_scene", TTR("Close Scene"), KeyModifierMask::CMD_OR_CTRL + KeyModifierMask::SHIFT + Key::W), FILE_CLOSE);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
recent_scenes = memnew(PopupMenu);
recent_scenes->set_name("RecentScenes");
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
file_menu->add_child(recent_scenes);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
recent_scenes->connect("id_pressed", callable_mp(this, &EditorNode::_open_recent_scene));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
if (!global_menu || !OS::get_singleton()->has_feature("macos")) {
// On macOS "Quit" and "About" options are in the "app" menu.
file_menu->add_separator();
Fix key mapping changes when moving from macOS to other platform Removes separate `Command` key (use `Meta` instead). Adds an event flag to automatically remap `Command` <-> `Control` (cannot be set alongside `Control` or `Meta`).
2022-09-02 11:37:48 +02:00
file_menu->add_shortcut(ED_SHORTCUT_AND_COMMAND("editor/file_quit", TTR("Quit"), KeyModifierMask::CMD_OR_CTRL + Key::Q), FILE_QUIT, true);
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
}
project and scene swapped, sorry could never get used to it :( Also reorganized menus a bit.
2017-06-22 23:04:03 +02:00
[macOS] Add default Window and Help menus, allow special menu customization.
2023-10-15 19:52:56 +02:00
ED_SHORTCUT_AND_COMMAND("editor/editor_settings", TTR("Editor Settings..."));
ED_SHORTCUT_OVERRIDE("editor/editor_settings", "macos", KeyModifierMask::META + Key::COMMA);
#ifdef MACOS_ENABLED
if (global_menu) {
apple_menu = memnew(PopupMenu);
apple_menu->set_system_menu_root("_apple");
main_menu->add_child(apple_menu);
apple_menu->add_shortcut(ED_GET_SHORTCUT("editor/editor_settings"), SETTINGS_PREFERENCES);
apple_menu->add_separator();
apple_menu->connect("id_pressed", callable_mp(this, &EditorNode::_menu_option));
}
#endif
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
project_menu = memnew(PopupMenu);
project_menu->set_name(TTR("Project"));
main_menu->add_child(project_menu);
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
project_menu->add_shortcut(ED_SHORTCUT_AND_COMMAND("editor/project_settings", TTR("Project Settings..."), Key::NONE, TTR("Project Settings")), RUN_SETTINGS);
project_menu->connect("id_pressed", callable_mp(this, &EditorNode::_menu_option));
Reorganize various menus for consistency and conciseness - Clean up the recent scripts dialog to match the recent scenes dialog - Add "..." at the end of shortcuts that cause a modal dialog to appear This closes #31148.
2019-08-12 22:23:00 +02:00
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
project_menu->add_separator();
Fix theme of editor VCS dialogs These dialogs were added to the plugin itself so theme can't be propagated. Also moved initialization of the VCS menu after the creation of EditorInterface.
2023-04-12 14:59:34 +02:00
project_menu->add_item(TTR("Version Control"), VCS_MENU);
Add VCS editor plugin UI elements to editor
2019-09-03 16:42:08 +02:00
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
project_menu->add_separator();
project_menu->add_shortcut(ED_SHORTCUT_AND_COMMAND("editor/export", TTR("Export..."), Key::NONE, TTR("Export")), FILE_EXPORT_PROJECT);
Disable menus and functionality that are not relevant on the Android Editor port
2022-09-14 05:48:33 +02:00
#ifndef ANDROID_ENABLED
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
project_menu->add_item(TTR("Install Android Build Template..."), FILE_INSTALL_ANDROID_SOURCE);
project_menu->add_item(TTR("Open User Data Folder"), RUN_USER_DATA_FOLDER);
Disable menus and functionality that are not relevant on the Android Editor port
2022-09-14 05:48:33 +02:00
#endif
project and scene swapped, sorry could never get used to it :( Also reorganized menus a bit.
2017-06-22 23:04:03 +02:00
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
project_menu->add_separator();
project_menu->add_item(TTR("Customize Engine Build Configuration..."), TOOLS_BUILD_PROFILE_MANAGER);
project_menu->add_separator();
Implement Feature Build Profiles This PR is a continuation of #50381 (which was implemented exactly a year ago!) * Add a visual interface to select which classes should not be built into Godot (well, they are built if something else uses them, but if not used the optimizer will remove them out). * Add a detection system to scan the project and figure out the actual classes used. * Added the ability for SCons to load build profiles. Obligatory Screen: A simple test with a couple of nodes in the scene resulted in a 25% reduction for the final binary size TODO: * Script languages need to implement used class detection (left for another PR). * Options to disable servers or server functionalities (like 2D or 3D physics, navigation, etc). Are missing, that should also greatly aid in reducing binary size. * Options to disable some modules would be desired. * More options to disable drivers (OpenGL, Vulkan, etc) would be desired. In general this PR is a starting point for more contributors to improve and enhance this functionality.
2022-07-14 14:18:18 +02:00
Added tool menu functions in EditorPlugin
2018-03-17 02:50:35 +01:00
tool_menu = memnew(PopupMenu);
project and scene swapped, sorry could never get used to it :( Also reorganized menus a bit.
2017-06-22 23:04:03 +02:00
tool_menu->set_name("Tools");
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
tool_menu->connect("index_pressed", callable_mp(this, &EditorNode::_tool_menu_option));
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
project_menu->add_child(tool_menu);
project_menu->add_submenu_item(TTR("Tools"), "Tools");
Reorganize various menus for consistency and conciseness - Clean up the recent scripts dialog to match the recent scenes dialog - Add "..." at the end of shortcuts that cause a modal dialog to appear This closes #31148.
2019-08-12 22:23:00 +02:00
tool_menu->add_item(TTR("Orphan Resource Explorer..."), TOOLS_ORPHAN_RESOURCES);
Prevent the surface upgrade tool from running during export Also add an explicit way to trigger the tool manually at user's will.
2023-11-20 14:44:38 +01:00
tool_menu->add_item(TTR("Upgrade Mesh Surfaces..."), TOOLS_SURFACE_UPGRADE);
Add menu buttons to open the project and editor data folders
2018-07-25 19:53:12 +02:00
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
project_menu->add_separator();
project_menu->add_shortcut(ED_SHORTCUT("editor/reload_current_project", TTR("Reload Current Project")), RELOAD_CURRENT_PROJECT);
Fix key mapping changes when moving from macOS to other platform Removes separate `Command` key (use `Meta` instead). Adds an event flag to automatically remap `Command` <-> `Control` (cannot be set alongside `Control` or `Meta`).
2022-09-02 11:37:48 +02:00
ED_SHORTCUT_AND_COMMAND("editor/quit_to_project_list", TTR("Quit to Project List"), KeyModifierMask::CTRL + KeyModifierMask::SHIFT + Key::Q);
[macOS] Replace all `Alt/Option+Letter/Number` default shortcuts to avoid conflicts with special character input.
2023-02-16 10:28:04 +01:00
ED_SHORTCUT_OVERRIDE("editor/quit_to_project_list", "macos", KeyModifierMask::META + KeyModifierMask::CTRL + KeyModifierMask::ALT + Key::Q);
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
project_menu->add_shortcut(ED_GET_SHORTCUT("editor/quit_to_project_list"), RUN_PROJECT_MANAGER, true);
-fixed tabs
2015-11-18 08:47:41 +01:00
[macOS] Extend editor contents to the window titlebar for better space usage.
2022-08-23 12:40:48 +02:00
// Spacer to center 2D / 3D / Script buttons.
[macOS extend-to-title] Add scene/project name to the editor title, fix incorrect window button position/order when system primary language is RTL.
2022-09-22 11:06:11 +02:00
HBoxContainer *left_spacer = memnew(HBoxContainer);
[macOS] Extend editor contents to the window titlebar for better space usage.
2022-08-23 12:40:48 +02:00
left_spacer->set_mouse_filter(Control::MOUSE_FILTER_PASS);
[macOS extend-to-title] Add scene/project name to the editor title, fix incorrect window button position/order when system primary language is RTL.
2022-09-22 11:06:11 +02:00
left_spacer->set_h_size_flags(Control::SIZE_EXPAND_FILL);
Extract editor run toolbar into its own component - Simplify and update its logic. - Simplify EditorScript. - Improve EditorNode and other relevant includes. - Fix scene-based path in the movie writer when reloading a scene.
2023-04-12 21:02:28 +02:00
title_bar->add_child(left_spacer);
[macOS] Extend editor contents to the window titlebar for better space usage.
2022-08-23 12:40:48 +02:00
[macOS extend-to-title] Add scene/project name to the editor title, fix incorrect window button position/order when system primary language is RTL.
2022-09-22 11:06:11 +02:00
if (can_expand && global_menu) {
project_title = memnew(Label);
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
project_title->add_theme_font_override("font", theme->get_font(SNAME("bold"), EditorStringName(EditorFonts)));
project_title->add_theme_font_size_override("font_size", theme->get_font_size(SNAME("bold_size"), EditorStringName(EditorFonts)));
[macOS extend-to-title] Add scene/project name to the editor title, fix incorrect window button position/order when system primary language is RTL.
2022-09-22 11:06:11 +02:00
project_title->set_focus_mode(Control::FOCUS_NONE);
project_title->set_text_overrun_behavior(TextServer::OVERRUN_TRIM_ELLIPSIS);
project_title->set_vertical_alignment(VERTICAL_ALIGNMENT_CENTER);
project_title->set_h_size_flags(Control::SIZE_EXPAND_FILL);
[macOS] Move extended title bar input to _gui_input and add mouse filters to prevent editor buttons from passing double-click to title.
2023-01-20 11:47:05 +01:00
project_title->set_mouse_filter(Control::MOUSE_FILTER_PASS);
[macOS extend-to-title] Add scene/project name to the editor title, fix incorrect window button position/order when system primary language is RTL.
2022-09-22 11:06:11 +02:00
left_spacer->add_child(project_title);
}
Cleanup editor's top bar of old nodes
2019-02-11 05:18:54 +01:00
[macOS extend-to-title] Add scene/project name to the editor title, fix incorrect window button position/order when system primary language is RTL.
2022-09-22 11:06:11 +02:00
main_editor_button_hb = memnew(HBoxContainer);
Extract editor run toolbar into its own component - Simplify and update its logic. - Simplify EditorScript. - Improve EditorNode and other relevant includes. - Fix scene-based path in the movie writer when reloading a scene.
2023-04-12 21:02:28 +02:00
title_bar->add_child(main_editor_button_hb);
-Add a distraction free mode button (so users know it's there) -Made distaction free not hide the top bar, it's more loss than gain to hide it -Fix fullscreen toggling and added a menu option for it so it's also visible in settings.
2016-09-13 14:46:17 +02:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Options are added and handled by DebuggerEditorPlugin.
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
debug_menu = memnew(PopupMenu);
debug_menu->set_name(TTR("Debug"));
main_menu->add_child(debug_menu);
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
settings_menu = memnew(PopupMenu);
settings_menu->set_name(TTR("Editor"));
main_menu->add_child(settings_menu);
Added ability to override shortcut definitions for OSX (remove preprocessor defines)
2021-08-08 05:52:00 +02:00
[macOS] Add default Window and Help menus, allow special menu customization.
2023-10-15 19:52:56 +02:00
#ifdef MACOS_ENABLED
if (!global_menu) {
settings_menu->add_shortcut(ED_GET_SHORTCUT("editor/editor_settings"), SETTINGS_PREFERENCES);
}
#else
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
settings_menu->add_shortcut(ED_GET_SHORTCUT("editor/editor_settings"), SETTINGS_PREFERENCES);
[macOS] Add default Window and Help menus, allow special menu customization.
2023-10-15 19:52:56 +02:00
#endif
Fix key mapping changes when moving from macOS to other platform Removes separate `Command` key (use `Meta` instead). Adds an event flag to automatically remap `Command` <-> `Control` (cannot be set alongside `Control` or `Meta`).
2022-09-02 11:37:48 +02:00
settings_menu->add_shortcut(ED_SHORTCUT("editor/command_palette", TTR("Command Palette..."), KeyModifierMask::CMD_OR_CTRL | KeyModifierMask::SHIFT | Key::P), HELP_COMMAND_PALETTE);
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
settings_menu->add_separator();
Add menu buttons to open the project and editor data folders
2018-07-25 19:53:12 +02:00
Join text menus on the top-left, move shortcut buttons to new location
2017-05-24 12:00:55 +02:00
editor_layouts = memnew(PopupMenu);
editor_layouts->set_name("Layouts");
Turn off auto translate for some editor controls * Scene tab * Animation name list in Animation panel * Feature profile name list in Editor Feature Profile dialog * Layout names in editor layout menu * Subresource list in Inspector dock * Resource type shown in EditorResourcePicker * Enum dropdowns in inspectors: We'll eventually allow auto translating these after implementing a way to opt-out auto translation on a property-by-property basis and a way to extract enumerators.
2023-03-28 17:02:02 +02:00
editor_layouts->set_auto_translate(false);
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
settings_menu->add_child(editor_layouts);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
editor_layouts->connect("id_pressed", callable_mp(this, &EditorNode::_layout_menu_option));
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
settings_menu->add_submenu_item(TTR("Editor Layout"), "Layouts");
settings_menu->add_separator();
Added ability to override shortcut definitions for OSX (remove preprocessor defines)
2021-08-08 05:52:00 +02:00
Use "enum class" for input enums
2021-08-13 23:31:57 +02:00
ED_SHORTCUT_AND_COMMAND("editor/take_screenshot", TTR("Take Screenshot"), KeyModifierMask::CTRL | Key::F12);
Fix key mapping changes when moving from macOS to other platform Removes separate `Command` key (use `Meta` instead). Adds an event flag to automatically remap `Command` <-> `Control` (cannot be set alongside `Control` or `Meta`).
2022-09-02 11:37:48 +02:00
ED_SHORTCUT_OVERRIDE("editor/take_screenshot", "macos", KeyModifierMask::META | Key::F12);
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
settings_menu->add_shortcut(ED_GET_SHORTCUT("editor/take_screenshot"), EDITOR_SCREENSHOT);
Added ability to override shortcut definitions for OSX (remove preprocessor defines)
2021-08-08 05:52:00 +02:00
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
settings_menu->set_item_tooltip(-1, TTR("Screenshots are stored in the Editor Data/Settings Folder."));
Added ability to override shortcut definitions for OSX (remove preprocessor defines)
2021-08-08 05:52:00 +02:00
Disable menus and functionality that are not relevant on the Android Editor port
2022-09-14 05:48:33 +02:00
#ifndef ANDROID_ENABLED
Use "enum class" for input enums
2021-08-13 23:31:57 +02:00
ED_SHORTCUT_AND_COMMAND("editor/fullscreen_mode", TTR("Toggle Fullscreen"), KeyModifierMask::SHIFT | Key::F11);
Fix key mapping changes when moving from macOS to other platform Removes separate `Command` key (use `Meta` instead). Adds an event flag to automatically remap `Command` <-> `Control` (cannot be set alongside `Control` or `Meta`).
2022-09-02 11:37:48 +02:00
ED_SHORTCUT_OVERRIDE("editor/fullscreen_mode", "macos", KeyModifierMask::META | KeyModifierMask::CTRL | Key::F);
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
settings_menu->add_shortcut(ED_GET_SHORTCUT("editor/fullscreen_mode"), SETTINGS_TOGGLE_FULLSCREEN);
Disable menus and functionality that are not relevant on the Android Editor port
2022-09-14 05:48:33 +02:00
#endif
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
settings_menu->add_separator();
Add menu buttons to open the project and editor data folders
2018-07-25 19:53:12 +02:00
Disable menus and functionality that are not relevant on the Android Editor port
2022-09-14 05:48:33 +02:00
#ifndef ANDROID_ENABLED
Add menu buttons to open the project and editor data folders
2018-07-25 19:53:12 +02:00
if (OS::get_singleton()->get_data_path() == OS::get_singleton()->get_config_path()) {
Corrected capitalisation of macOS In documentation and comments, ignoring thirdparty code
2023-03-12 17:48:52 +01:00
// Configuration and data folders are located in the same place (Windows/macOS).
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
settings_menu->add_item(TTR("Open Editor Data/Settings Folder"), SETTINGS_EDITOR_DATA_FOLDER);
Add menu buttons to open the project and editor data folders
2018-07-25 19:53:12 +02:00
} else {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Separate configuration and data folders (Linux).
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
settings_menu->add_item(TTR("Open Editor Data Folder"), SETTINGS_EDITOR_DATA_FOLDER);
settings_menu->add_item(TTR("Open Editor Settings Folder"), SETTINGS_EDITOR_CONFIG_FOLDER);
Add menu buttons to open the project and editor data folders
2018-07-25 19:53:12 +02:00
}
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
settings_menu->add_separator();
Disable menus and functionality that are not relevant on the Android Editor port
2022-09-14 05:48:33 +02:00
#endif
Add menu buttons to open the project and editor data folders
2018-07-25 19:53:12 +02:00
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
settings_menu->add_item(TTR("Manage Editor Features..."), SETTINGS_MANAGE_FEATURE_PROFILES);
Disable menus and functionality that are not relevant on the Android Editor port
2022-09-14 05:48:33 +02:00
#ifndef ANDROID_ENABLED
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
settings_menu->add_item(TTR("Manage Export Templates..."), SETTINGS_MANAGE_EXPORT_TEMPLATES);
Disable menus and functionality that are not relevant on the Android Editor port
2022-09-14 05:48:33 +02:00
#endif
Add a dialog for customizing FBX import * If FBX files are found, a dialog will pop up asking to configure FBX2glTF. * Dialog can also be accessed by going Editor -> Configure FBX Import. * The dialog also shows a link to click to download the converter, which should contain instructions.
2022-04-02 13:43:15 +02:00
#if !defined(ANDROID_ENABLED) && !defined(WEB_ENABLED)
settings_menu->add_item(TTR("Configure FBX Importer..."), SETTINGS_MANAGE_FBX_IMPORTER);
#endif
Added an help menu Also renamed the "tutorials" button in the script editor to be consistent with the help menu entry. Fixed #8921
2017-05-26 16:34:41 +02:00
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
help_menu = memnew(PopupMenu);
help_menu->set_name(TTR("Help"));
[macOS] Add default Window and Help menus, allow special menu customization.
2023-10-15 19:52:56 +02:00
help_menu->set_system_menu_root("_help");
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
main_menu->add_child(help_menu);
fixed hover line for menu button
2017-09-02 03:25:40 +02:00
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
help_menu->connect("id_pressed", callable_mp(this, &EditorNode::_menu_option));
Added ability to override shortcut definitions for OSX (remove preprocessor defines)
2021-08-08 05:52:00 +02:00
Use "enum class" for input enums
2021-08-13 23:31:57 +02:00
ED_SHORTCUT_AND_COMMAND("editor/editor_help", TTR("Search Help"), Key::F1);
ED_SHORTCUT_OVERRIDE("editor/editor_help", "macos", KeyModifierMask::ALT | Key::SPACE);
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
help_menu->add_icon_shortcut(theme->get_icon(SNAME("HelpSearch"), EditorStringName(EditorIcons)), ED_GET_SHORTCUT("editor/editor_help"), HELP_SEARCH);
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
help_menu->add_separator();
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
help_menu->add_icon_shortcut(theme->get_icon(SNAME("ExternalLink"), EditorStringName(EditorIcons)), ED_SHORTCUT_AND_COMMAND("editor/online_docs", TTR("Online Documentation")), HELP_DOCS);
help_menu->add_icon_shortcut(theme->get_icon(SNAME("ExternalLink"), EditorStringName(EditorIcons)), ED_SHORTCUT_AND_COMMAND("editor/q&a", TTR("Questions & Answers")), HELP_QA);
Editor: Rearrange "Main Menu > Help" items
2023-09-07 15:01:33 +02:00
help_menu->add_icon_shortcut(theme->get_icon(SNAME("ExternalLink"), EditorStringName(EditorIcons)), ED_SHORTCUT_AND_COMMAND("editor/community", TTR("Community")), HELP_COMMUNITY);
help_menu->add_separator();
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
help_menu->add_icon_shortcut(theme->get_icon(SNAME("ActionCopy"), EditorStringName(EditorIcons)), ED_SHORTCUT_AND_COMMAND("editor/copy_system_info", TTR("Copy System Info")), HELP_COPY_SYSTEM_INFO);
Make system information for issue reports single-line Additionally: * for custom builds, add commit hash * added a tooltip to help mitigate potential/understandable confusion whether the single-line output might be a bug * prettify driver name
2023-05-29 22:20:40 +02:00
help_menu->set_item_tooltip(-1, TTR("Copies the system info as a single-line text into the clipboard."));
Editor: Rearrange "Main Menu > Help" items
2023-09-07 15:01:33 +02:00
help_menu->add_icon_shortcut(theme->get_icon(SNAME("ExternalLink"), EditorStringName(EditorIcons)), ED_SHORTCUT_AND_COMMAND("editor/report_a_bug", TTR("Report a Bug")), HELP_REPORT_A_BUG);
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
help_menu->add_icon_shortcut(theme->get_icon(SNAME("ExternalLink"), EditorStringName(EditorIcons)), ED_SHORTCUT_AND_COMMAND("editor/suggest_a_feature", TTR("Suggest a Feature")), HELP_SUGGEST_A_FEATURE);
help_menu->add_icon_shortcut(theme->get_icon(SNAME("ExternalLink"), EditorStringName(EditorIcons)), ED_SHORTCUT_AND_COMMAND("editor/send_docs_feedback", TTR("Send Docs Feedback")), HELP_SEND_DOCS_FEEDBACK);
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
help_menu->add_separator();
if (!global_menu || !OS::get_singleton()->has_feature("macos")) {
// On macOS "Quit" and "About" options are in the "app" menu.
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
help_menu->add_icon_shortcut(theme->get_icon(SNAME("Godot"), EditorStringName(EditorIcons)), ED_SHORTCUT_AND_COMMAND("editor/about", TTR("About Godot")), HELP_ABOUT);
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
}
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
help_menu->add_icon_shortcut(theme->get_icon(SNAME("Heart"), EditorStringName(EditorIcons)), ED_SHORTCUT_AND_COMMAND("editor/support_development", TTR("Support Godot Development")), HELP_SUPPORT_GODOT_DEVELOPMENT);
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
[macOS] Extend editor contents to the window titlebar for better space usage.
2022-08-23 12:40:48 +02:00
// Spacer to center 2D / 3D / Script buttons.
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
Control *right_spacer = memnew(Control);
[macOS] Extend editor contents to the window titlebar for better space usage.
2022-08-23 12:40:48 +02:00
right_spacer->set_mouse_filter(Control::MOUSE_FILTER_PASS);
[macOS extend-to-title] Add scene/project name to the editor title, fix incorrect window button position/order when system primary language is RTL.
2022-09-22 11:06:11 +02:00
right_spacer->set_h_size_flags(Control::SIZE_EXPAND_FILL);
Extract editor run toolbar into its own component - Simplify and update its logic. - Simplify EditorScript. - Improve EditorNode and other relevant includes. - Fix scene-based path in the movie writer when reloading a scene.
2023-04-12 21:02:28 +02:00
title_bar->add_child(right_spacer);
project_run_bar = memnew(EditorRunBar);
title_bar->add_child(project_run_bar);
project_run_bar->connect("play_pressed", callable_mp(this, &EditorNode::_project_run_started));
project_run_bar->connect("stop_pressed", callable_mp(this, &EditorNode::_project_run_stopped));
Implement Running Godot as Movie Writer * Allows running the game in "movie writer" mode. * It ensures entirely stable framerate, so your run can be saved stable and with proper sound (which is impossible if your CPU/GPU can't sustain doing this in real-time). * If disabling vsync, it can save movies faster than the game is run, but if you want to control the interaction it can get difficult. * Implements a simple, default MJPEG writer. This new features has two main use cases, which have high demand: * Saving game videos in high quality and ensuring the frame rate is *completely* stable, always. * Using Godot as a tool to make movies and animations (which is ideal if you want interaction, or creating them procedurally. No other software is as good for this). **Note**: This feature **IS NOT** for capturing real-time footage. Use something like OBS, SimpleScreenRecorder or FRAPS to achieve that, as they do a much better job at intercepting the compositor than Godot can probably do using Vulkan or OpenGL natively. If your game runs near real-time when capturing, you can still use this feature but it will play no sound (sound will be saved directly). Usage: $ godot --write-movie movie.avi [scene_file.tscn] Missing: * Options for configuring video writing via GLOBAL_DEF * UI Menu for launching with this mode from the editor. * Add to list of command line options. * Add a feature tag to override configurations when movie writing (fantastic for saving videos with highest quality settings).
2022-06-17 00:55:19 +02:00
Cleanup some unused controls in the editor's top bar
2018-12-09 19:10:07 +01:00
HBoxContainer *right_menu_hb = memnew(HBoxContainer);
Extract editor run toolbar into its own component - Simplify and update its logic. - Simplify EditorScript. - Improve EditorNode and other relevant includes. - Fix scene-based path in the movie writer when reloading a scene.
2023-04-12 21:02:28 +02:00
title_bar->add_child(right_menu_hb);
Cleanup some unused controls in the editor's top bar
2018-12-09 19:10:07 +01:00
Split rendering driver project setting into renderer_name and rendering_driver. To differentiate between a driver (e.g. Vulkan or D3D12) and a renderer (e.g. clustered or mobile renderer).
2022-09-08 02:44:36 +02:00
renderer = memnew(OptionButton);
Bring back the renderer options button on the main editor
2022-12-23 22:54:09 +01:00
renderer->set_visible(true);
Split rendering driver project setting into renderer_name and rendering_driver. To differentiate between a driver (e.g. Vulkan or D3D12) and a renderer (e.g. clustered or mobile renderer).
2022-09-08 02:44:36 +02:00
renderer->set_flat(true);
Bring back the renderer options button on the main editor
2022-12-23 22:54:09 +01:00
renderer->set_fit_to_longest_item(false);
Split rendering driver project setting into renderer_name and rendering_driver. To differentiate between a driver (e.g. Vulkan or D3D12) and a renderer (e.g. clustered or mobile renderer).
2022-09-08 02:44:36 +02:00
renderer->set_focus_mode(Control::FOCUS_NONE);
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
renderer->add_theme_font_override("font", theme->get_font(SNAME("bold"), EditorStringName(EditorFonts)));
renderer->add_theme_font_size_override("font_size", theme->get_font_size(SNAME("bold_size"), EditorStringName(EditorFonts)));
Bring back the renderer options button on the main editor
2022-12-23 22:54:09 +01:00
renderer->set_tooltip_text(TTR("Choose a renderer."));
Add GLES2 2D renderer + Linux display manager First implementation with Linux display manager. - Add single-threaded mode for EditorResourcePreview (needed for OpenGL). Co-authored-by: clayjohn <claynjohn@gmail.com> Co-authored-by: Fabio Alessandrelli <fabio.alessandrelli@gmail.com>
2020-11-18 19:11:30 +01:00
Split rendering driver project setting into renderer_name and rendering_driver. To differentiate between a driver (e.g. Vulkan or D3D12) and a renderer (e.g. clustered or mobile renderer).
2022-09-08 02:44:36 +02:00
right_menu_hb->add_child(renderer);
Add GLES2 2D renderer + Linux display manager First implementation with Linux display manager. - Add single-threaded mode for EditorResourcePreview (needed for OpenGL). Co-authored-by: clayjohn <claynjohn@gmail.com> Co-authored-by: Fabio Alessandrelli <fabio.alessandrelli@gmail.com>
2020-11-18 19:11:30 +01:00
[macOS] Extend editor contents to the window titlebar for better space usage.
2022-08-23 12:40:48 +02:00
if (can_expand) {
// Add spacer to avoid other controls under the window minimize/maximize/close buttons (right side).
[macOS extend-to-title] Add scene/project name to the editor title, fix incorrect window button position/order when system primary language is RTL.
2022-09-22 11:06:11 +02:00
right_menu_spacer = memnew(Control);
right_menu_spacer->set_mouse_filter(Control::MOUSE_FILTER_PASS);
Extract editor run toolbar into its own component - Simplify and update its logic. - Simplify EditorScript. - Improve EditorNode and other relevant includes. - Fix scene-based path in the movie writer when reloading a scene.
2023-04-12 21:02:28 +02:00
title_bar->add_child(right_menu_spacer);
[macOS] Extend editor contents to the window titlebar for better space usage.
2022-08-23 12:40:48 +02:00
}
Use render method from OS in compositor RD; Update related UI
2023-12-14 04:38:46 +01:00
String current_renderer_ps = GLOBAL_GET("rendering/renderer/rendering_method");
current_renderer_ps = current_renderer_ps.to_lower();
String current_renderer_os = OS::get_singleton()->get_current_rendering_method().to_lower();
Add GLES2 2D renderer + Linux display manager First implementation with Linux display manager. - Add single-threaded mode for EditorResourcePreview (needed for OpenGL). Co-authored-by: clayjohn <claynjohn@gmail.com> Co-authored-by: Fabio Alessandrelli <fabio.alessandrelli@gmail.com>
2020-11-18 19:11:30 +01:00
Use render method from OS in compositor RD; Update related UI
2023-12-14 04:38:46 +01:00
// Add the renderers name to the UI.
if (current_renderer_ps == current_renderer_os) {
renderer->connect("item_selected", callable_mp(this, &EditorNode::_renderer_selected));
// As we are doing string comparisons, keep in standard case to prevent problems with capitals
// "vulkan" in particular uses lowercase "v" in the code, and uppercase in the UI.
PackedStringArray renderers = ProjectSettings::get_singleton()->get_custom_property_info().get(StringName("rendering/renderer/rendering_method")).hint_string.split(",", false);
for (int i = 0; i < renderers.size(); i++) {
String rendering_method = renderers[i];
_add_renderer_entry(rendering_method, false);
renderer->set_item_metadata(i, rendering_method);
// Lowercase for standard comparison.
rendering_method = rendering_method.to_lower();
if (current_renderer_ps == rendering_method) {
renderer->select(i);
renderer_current = i;
}
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
}
Use render method from OS in compositor RD; Update related UI
2023-12-14 04:38:46 +01:00
} else {
// It's an CLI-overridden rendering method.
_add_renderer_entry(current_renderer_os, true);
renderer->set_item_metadata(0, current_renderer_os);
renderer->select(0);
renderer_current = 0;
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
}
Split rendering driver project setting into renderer_name and rendering_driver. To differentiate between a driver (e.g. Vulkan or D3D12) and a renderer (e.g. clustered or mobile renderer).
2022-09-08 02:44:36 +02:00
_update_renderer_color();
Add GLES2 2D renderer + Linux display manager First implementation with Linux display manager. - Add single-threaded mode for EditorResourcePreview (needed for OpenGL). Co-authored-by: clayjohn <claynjohn@gmail.com> Co-authored-by: Fabio Alessandrelli <fabio.alessandrelli@gmail.com>
2020-11-18 19:11:30 +01:00
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
video_restart_dialog = memnew(ConfirmationDialog);
Split rendering driver project setting into renderer_name and rendering_driver. To differentiate between a driver (e.g. Vulkan or D3D12) and a renderer (e.g. clustered or mobile renderer).
2022-09-08 02:44:36 +02:00
video_restart_dialog->set_text(TTR("Changing the renderer requires restarting the editor."));
Add ok_button_text to AcceptDialog and cancel_button_text to ConfirmationDialog
2022-07-08 02:31:19 +02:00
video_restart_dialog->set_ok_button_text(TTR("Save & Restart"));
Split rendering driver project setting into renderer_name and rendering_driver. To differentiate between a driver (e.g. Vulkan or D3D12) and a renderer (e.g. clustered or mobile renderer).
2022-09-08 02:44:36 +02:00
video_restart_dialog->connect("confirmed", callable_mp(this, &EditorNode::_menu_option).bind(SET_RENDERER_NAME_SAVE_AND_RESTART));
-Fix tooltips in inspector, now they show as rich text.
2018-07-20 23:14:33 +02:00
gui_base->add_child(video_restart_dialog);
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
-fixed tabs
2015-11-18 08:47:41 +01:00
progress_hb = memnew(BackgroundProgress);
editor save/delete layout dialog with layout list
2019-05-30 20:16:40 +02:00
layout_dialog = memnew(EditorLayoutsDialog);
Editor layouts menu
2015-11-22 19:11:17 +01:00
gui_base->add_child(layout_dialog);
layout_dialog->set_hide_on_ok(false);
editor save/delete layout dialog with layout list
2019-05-30 20:16:40 +02:00
layout_dialog->set_size(Size2(225, 270) * EDSCALE);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
layout_dialog->connect("name_confirmed", callable_mp(this, &EditorNode::_dialog_action));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Make visibility of update spinner editor-wide, hidden by default - Make visibility of the spinner and "update always" option editor-wide, rather than per-project metadata. - Add options "Show Update Spinner" and "Update Continuously" under Editor Settings > Interface > Editor. Both options are false by default. - Rename some variables and constants to be more consistent and clearer: "update always" -> "update continuously", "update changes" -> "update when changed", "update menu" -> "update spinner", "circle" -> "update spinner". Fixes #23738.
2018-12-11 16:52:25 +01:00
update_spinner = memnew(MenuButton);
right_menu_hb->add_child(update_spinner);
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
update_spinner->set_icon(theme->get_icon(SNAME("Progress1"), EditorStringName(EditorIcons)));
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
update_spinner->get_popup()->connect("id_pressed", callable_mp(this, &EditorNode::_menu_option));
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
PopupMenu *p = update_spinner->get_popup();
Make visibility of update spinner editor-wide, hidden by default - Make visibility of the spinner and "update always" option editor-wide, rather than per-project metadata. - Add options "Show Update Spinner" and "Update Continuously" under Editor Settings > Interface > Editor. Both options are false by default. - Rename some variables and constants to be more consistent and clearer: "update always" -> "update continuously", "update changes" -> "update when changed", "update menu" -> "update spinner", "circle" -> "update spinner". Fixes #23738.
2018-12-11 16:52:25 +01:00
p->add_radio_check_item(TTR("Update Continuously"), SETTINGS_UPDATE_CONTINUOUSLY);
p->add_radio_check_item(TTR("Update When Changed"), SETTINGS_UPDATE_WHEN_CHANGED);
editor_node: add an option to stop the update spinner from spinning, fixes #6653
2016-10-01 16:15:07 +02:00
p->add_separator();
Make visibility of update spinner editor-wide, hidden by default - Make visibility of the spinner and "update always" option editor-wide, rather than per-project metadata. - Add options "Show Update Spinner" and "Update Continuously" under Editor Settings > Interface > Editor. Both options are false by default. - Rename some variables and constants to be more consistent and clearer: "update always" -> "update continuously", "update changes" -> "update when changed", "update menu" -> "update spinner", "circle" -> "update spinner". Fixes #23738.
2018-12-11 16:52:25 +01:00
p->add_item(TTR("Hide Update Spinner"), SETTINGS_UPDATE_SPINNER_HIDE);
_update_update_spinner();
-fixed tabs
2015-11-18 08:47:41 +01:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Instantiate and place editor docks.
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Remove most EditorNode constructor parameters and fields
2022-01-27 10:36:51 +01:00
memnew(SceneTreeDock(scene_root, editor_selection, editor_data));
memnew(InspectorDock(editor_data));
Store panels and docks singletons in their own classes
2021-11-17 21:08:55 +01:00
memnew(ImportDock);
memnew(NodeDock);
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
Remove most EditorNode constructor parameters and fields
2022-01-27 10:36:51 +01:00
FileSystemDock *filesystem_dock = memnew(FileSystemDock);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
filesystem_dock->connect("inherit", callable_mp(this, &EditorNode::_inherit_request));
Remove more instances of 'instance' being used as a verb
2022-11-16 00:13:39 +01:00
filesystem_dock->connect("instantiate", callable_mp(this, &EditorNode::_instantiate_request));
Improve editor state persistence
2023-05-11 04:17:03 +02:00
filesystem_dock->connect("display_mode_changed", callable_mp(this, &EditorNode::_save_editor_layout));
Show dependency warning when removing remaps and fallback if translation remap does not exist
2022-01-04 18:52:32 +01:00
get_project_settings()->connect_filesystem_dock_signals(filesystem_dock);
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
Allow to disable History Dock via feature profile
2022-11-06 20:53:20 +01:00
history_dock = memnew(HistoryDock);
Add history dock
2022-08-27 13:52:06 +02:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Scene: Top left.
Store panels and docks singletons in their own classes
2021-11-17 21:08:55 +01:00
dock_slot[DOCK_SLOT_LEFT_UR]->add_child(SceneTreeDock::get_singleton());
Make `TabContainer` use `TabBar` internally
2022-03-02 15:37:10 +01:00
dock_slot[DOCK_SLOT_LEFT_UR]->set_tab_title(dock_slot[DOCK_SLOT_LEFT_UR]->get_tab_idx_from_control(SceneTreeDock::get_singleton()), TTR("Scene"));
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Import: Top left, behind Scene.
Store panels and docks singletons in their own classes
2021-11-17 21:08:55 +01:00
dock_slot[DOCK_SLOT_LEFT_UR]->add_child(ImportDock::get_singleton());
Make `TabContainer` use `TabBar` internally
2022-03-02 15:37:10 +01:00
dock_slot[DOCK_SLOT_LEFT_UR]->set_tab_title(dock_slot[DOCK_SLOT_LEFT_UR]->get_tab_idx_from_control(ImportDock::get_singleton()), TTR("Import"));
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// FileSystem: Bottom left.
Store panels and docks singletons in their own classes
2021-11-17 21:08:55 +01:00
dock_slot[DOCK_SLOT_LEFT_BR]->add_child(FileSystemDock::get_singleton());
Make `TabContainer` use `TabBar` internally
2022-03-02 15:37:10 +01:00
dock_slot[DOCK_SLOT_LEFT_BR]->set_tab_title(dock_slot[DOCK_SLOT_LEFT_BR]->get_tab_idx_from_control(FileSystemDock::get_singleton()), TTR("FileSystem"));
Lot of work in new importer, importing textures now works.
2017-02-01 13:45:45 +01:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Inspector: Full height right.
Store panels and docks singletons in their own classes
2021-11-17 21:08:55 +01:00
dock_slot[DOCK_SLOT_RIGHT_UL]->add_child(InspectorDock::get_singleton());
Make `TabContainer` use `TabBar` internally
2022-03-02 15:37:10 +01:00
dock_slot[DOCK_SLOT_RIGHT_UL]->set_tab_title(dock_slot[DOCK_SLOT_RIGHT_UL]->get_tab_idx_from_control(InspectorDock::get_singleton()), TTR("Inspector"));
Only assume HiDPI mode if DPI >= 192 and width > 2000 Also fix detection of single-column dock if width < 1200, it only worked with hidpi_mode=auto.
2017-03-24 17:39:16 +01:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Node: Full height right, behind Inspector.
Store panels and docks singletons in their own classes
2021-11-17 21:08:55 +01:00
dock_slot[DOCK_SLOT_RIGHT_UL]->add_child(NodeDock::get_singleton());
Make `TabContainer` use `TabBar` internally
2022-03-02 15:37:10 +01:00
dock_slot[DOCK_SLOT_RIGHT_UL]->set_tab_title(dock_slot[DOCK_SLOT_RIGHT_UL]->get_tab_idx_from_control(NodeDock::get_singleton()), TTR("Node"));
Signals became a tab added icons to contextual scene tree menu
2016-06-04 02:03:09 +02:00
Add history dock
2022-08-27 13:52:06 +02:00
// History: Full height right, behind Node.
Allow to disable History Dock via feature profile
2022-11-06 20:53:20 +01:00
dock_slot[DOCK_SLOT_RIGHT_UL]->add_child(history_dock);
dock_slot[DOCK_SLOT_RIGHT_UL]->set_tab_title(dock_slot[DOCK_SLOT_RIGHT_UL]->get_tab_idx_from_control(history_dock), TTR("History"));
Add history dock
2022-08-27 13:52:06 +02:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Hide unused dock slots and vsplits.
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
dock_slot[DOCK_SLOT_LEFT_UL]->hide();
dock_slot[DOCK_SLOT_LEFT_BL]->hide();
EditorNode: New default dock layout As discussed with @reduz, now that the FileSystem dock is getting files display in tree view (#21426), we can change the docks layout again to give more height to the new inspector. The new layout is thus: - Top left: Scene and Import docks - Bottom left: FileSystem - Right (full height): Inspector and Node docks The 2nd left (LEFT_R) and 1st right (RIGHT_L) VSplitContainers (the ones in use) also get an additional 40px of width compared to their previous size (which was the minimum size). Fixes #21480.
2018-09-14 17:07:46 +02:00
dock_slot[DOCK_SLOT_RIGHT_BL]->hide();
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
dock_slot[DOCK_SLOT_RIGHT_UR]->hide();
dock_slot[DOCK_SLOT_RIGHT_BR]->hide();
left_l_vsplit->hide();
right_r_vsplit->hide();
Make Godot detect if the screen is too small (<1200 pixels wide), and use single dock column like in 1.0 if that's the case.
2016-09-13 16:20:09 +02:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Add some offsets to left_r and main hsplits to make LEFT_R and RIGHT_L docks wider than minsize.
Increase default size of docks
2023-01-18 16:49:08 +01:00
left_r_hsplit->set_split_offset(270 * EDSCALE);
main_hsplit->set_split_offset(-270 * EDSCALE);
EditorNode: New default dock layout As discussed with @reduz, now that the FileSystem dock is getting files display in tree view (#21426), we can change the docks layout again to give more height to the new inspector. The new layout is thus: - Top left: Scene and Import docks - Bottom left: FileSystem - Right (full height): Inspector and Node docks The 2nd left (LEFT_R) and 1st right (RIGHT_L) VSplitContainers (the ones in use) also get an additional 40px of width compared to their previous size (which was the minimum size). Fixes #21480.
2018-09-14 17:07:46 +02:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Define corresponding default layout.
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Editor layouts menu
2015-11-22 19:11:17 +01:00
const String docks_section = "docks";
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
default_layout.instantiate();
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Dock numbers are based on DockSlot enum value + 1.
EditorNode: New default dock layout As discussed with @reduz, now that the FileSystem dock is getting files display in tree view (#21426), we can change the docks layout again to give more height to the new inspector. The new layout is thus: - Top left: Scene and Import docks - Bottom left: FileSystem - Right (full height): Inspector and Node docks The 2nd left (LEFT_R) and 1st right (RIGHT_L) VSplitContainers (the ones in use) also get an additional 40px of width compared to their previous size (which was the minimum size). Fixes #21480.
2018-09-14 17:07:46 +02:00
default_layout->set_value(docks_section, "dock_3", "Scene,Import");
default_layout->set_value(docks_section, "dock_4", "FileSystem");
History dock singleton, set default editor layout, ready notification - add the history dock to the default editor layout, so when a user does Editor -> Editor Layout -> Default the history dock will no longer disappear - change the enter tree notification to a ready notification to prevent the history dock from trying to connect 'on_history_changed' signal everytime the dock is moved in the editor layout
2022-11-24 01:30:20 +01:00
default_layout->set_value(docks_section, "dock_5", "Inspector,Node,History");
Editor layouts menu
2015-11-22 19:11:17 +01:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
for (int i = 0; i < vsplits.size(); i++) {
Allow to override the default editor layout
2016-01-11 22:23:45 +01:00
default_layout->set_value(docks_section, "dock_split_" + itos(i + 1), 0);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
EditorNode: New default dock layout As discussed with @reduz, now that the FileSystem dock is getting files display in tree view (#21426), we can change the docks layout again to give more height to the new inspector. The new layout is thus: - Top left: Scene and Import docks - Bottom left: FileSystem - Right (full height): Inspector and Node docks The 2nd left (LEFT_R) and 1st right (RIGHT_L) VSplitContainers (the ones in use) also get an additional 40px of width compared to their previous size (which was the minimum size). Fixes #21480.
2018-09-14 17:07:46 +02:00
default_layout->set_value(docks_section, "dock_hsplit_1", 0);
Increase default size of docks
2023-01-18 16:49:08 +01:00
default_layout->set_value(docks_section, "dock_hsplit_2", 270 * EDSCALE);
default_layout->set_value(docks_section, "dock_hsplit_3", -270 * EDSCALE);
EditorNode: New default dock layout As discussed with @reduz, now that the FileSystem dock is getting files display in tree view (#21426), we can change the docks layout again to give more height to the new inspector. The new layout is thus: - Top left: Scene and Import docks - Bottom left: FileSystem - Right (full height): Inspector and Node docks The 2nd left (LEFT_R) and 1st right (RIGHT_L) VSplitContainers (the ones in use) also get an additional 40px of width compared to their previous size (which was the minimum size). Fixes #21480.
2018-09-14 17:07:46 +02:00
default_layout->set_value(docks_section, "dock_hsplit_4", 0);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Editor layouts menu
2015-11-22 19:11:17 +01:00
_update_layouts_menu();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Bottom panels.
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
bottom_panel = memnew(PanelContainer);
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
bottom_panel->add_theme_style_override("panel", theme->get_stylebox(SNAME("BottomPanel"), EditorStringName(EditorStyles)));
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
center_split->add_child(bottom_panel);
center_split->set_dragger_visibility(SplitContainer::DRAGGER_HIDDEN);
-fixed tabs
2015-11-18 08:47:41 +01:00
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
bottom_panel_vb = memnew(VBoxContainer);
bottom_panel->add_child(bottom_panel_vb);
-fixed tabs
2015-11-18 08:47:41 +01:00
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
bottom_panel_hb = memnew(HBoxContainer);
Make some small enhancements to the ColorPicker
2019-01-26 22:07:32 +01:00
bottom_panel_hb->set_custom_minimum_size(Size2(0, 24 * EDSCALE)); // Adjust for the height of the "Expand Bottom Dock" icon.
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
bottom_panel_vb->add_child(bottom_panel_hb);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Added small icon to expand the bottom panel (and shortcut too)
2018-07-16 03:38:14 +02:00
bottom_panel_hb_editors = memnew(HBoxContainer);
bottom_panel_hb_editors->set_h_size_flags(Control::SIZE_EXPAND_FILL);
bottom_panel_hb->add_child(bottom_panel_hb_editors);
Display version information in the editor at all times This closes #27811.
2019-07-22 23:14:51 +02:00
Implement toast notifications in the editor
2021-09-22 17:36:40 +02:00
editor_toaster = memnew(EditorToaster);
bottom_panel_hb->add_child(editor_toaster);
Make it possible to copy the Godot version identifier by clicking it This closes #24317.
2019-12-24 01:20:54 +01:00
VBoxContainer *version_info_vbc = memnew(VBoxContainer);
bottom_panel_hb->add_child(version_info_vbc);
// Add a dummy control node for vertical spacing.
Control *v_spacer = memnew(Control);
version_info_vbc->add_child(v_spacer);
version_btn = memnew(LinkButton);
version_btn->set_text(VERSION_FULL_CONFIG);
String hash = String(VERSION_HASH);
if (hash.length() != 0) {
Separate version hash from version number in editor and project manager When copy-pasting the version from About dialog to bug reports at GitHub, this makes the version hash linkable to commits at GitHub.
2021-06-07 23:51:18 +02:00
hash = " " + vformat("[%s]", hash.left(9));
Make it possible to copy the Godot version identifier by clicking it This closes #24317.
2019-12-24 01:20:54 +01:00
}
// Set the text to copy in metadata as it slightly differs from the button's text.
version_btn->set_meta(META_TEXT_TO_COPY, "v" VERSION_FULL_BUILD + hash);
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Fade out the version label to be less prominent, but still readable.
Make it possible to copy the Godot version identifier by clicking it This closes #24317.
2019-12-24 01:20:54 +01:00
version_btn->set_self_modulate(Color(1, 1, 1, 0.65));
version_btn->set_underline_mode(LinkButton::UNDERLINE_MODE_ON_HOVER);
Rename `hint_tooltip` to `tooltip_text` & setget `hint_tooltip` -> `tooltip_text` `set_tooltip` -> `set_tooltip_text` `_get_tooltip` -> `get_tooltip_text` Updates documentation, too.
2022-08-25 12:42:17 +02:00
version_btn->set_tooltip_text(TTR("Click to copy."));
Make it possible to copy the Godot version identifier by clicking it This closes #24317.
2019-12-24 01:20:54 +01:00
version_btn->connect("pressed", callable_mp(this, &EditorNode::_version_button_pressed));
version_info_vbc->add_child(version_btn);
// Add a dummy control node for horizontal spacing.
Control *h_spacer = memnew(Control);
bottom_panel_hb->add_child(h_spacer);
Display version information in the editor at all times This closes #27811.
2019-07-22 23:14:51 +02:00
Remove ToolButton in favor of Button ToolButton has no redeeming differences with Button; it's just a Button with the Flat property enabled by default. Removing it avoids some confusion when creating GUIs. Existing ToolButtons will be converted to Buttons, but the Flat property won't be enabled automatically. This closes https://github.com/godotengine/godot-proposals/issues/1081.
2020-06-19 20:49:04 +02:00
bottom_panel_raise = memnew(Button);
Added small icon to expand the bottom panel (and shortcut too)
2018-07-16 03:38:14 +02:00
bottom_panel_hb->add_child(bottom_panel_raise);
bottom_panel_raise->hide();
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
bottom_panel_raise->set_flat(true);
Added small icon to expand the bottom panel (and shortcut too)
2018-07-16 03:38:14 +02:00
bottom_panel_raise->set_toggle_mode(true);
Add theme contexts to various parts of the editor This change defines additional theme contexts for editor branches to prevent theme leaking between the default theme, the project theme, and the editor theme. - Both editor window and EditorNode define an editor-specific context with the editor theme and the default theme. - The 2D viewport defines a project-specific context with the project theme and the default theme. - Theme editor preview tabs define the default-only context with the default theme. Additionally, the default theme context now only includes the project theme for running projects (both export and debug). This prevents the project theme from leaking into the editor. This commit also does a little clean up on the theming aspects of the EditorNode.
2023-09-06 16:11:05 +02:00
bottom_panel_raise->set_shortcut(ED_SHORTCUT_AND_COMMAND("editor/bottom_panel_expand", TTR("Expand Bottom Panel"), KeyModifierMask::SHIFT | Key::F12));
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
bottom_panel_raise->connect("toggled", callable_mp(this, &EditorNode::_bottom_panel_raise_toggled));
Added small icon to expand the bottom panel (and shortcut too)
2018-07-16 03:38:14 +02:00
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
log = memnew(EditorLog);
Revert "Remember only permanent bottom tabs" This reverts commit 5dde57e95827806101cede5d46391f2bd4b9150c.
2023-06-23 15:23:36 +02:00
Button *output_button = add_bottom_panel_item(TTR("Output"), log);
Show error icon at "Output" in case of errors
2018-03-11 14:20:32 +01:00
log->set_tool_button(output_button);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
center_split->connect("resized", callable_mp(this, &EditorNode::_vp_resized));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Added ability to visualize native shaders
2021-01-06 00:01:50 +01:00
native_shader_source_visualizer = memnew(EditorNativeShaderSourceVisualizer);
gui_base->add_child(native_shader_source_visualizer);
-orphan resource explorer dialog + tools menu
2015-11-29 05:08:31 +01:00
orphan_resources = memnew(OrphanResourcesDialog);
gui_base->add_child(orphan_resources);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Prevent the surface upgrade tool from running during export Also add an explicit way to trigger the tool manually at user's will.
2023-11-20 14:44:38 +01:00
surface_upgrade_dialog = memnew(SurfaceUpgradeDialog);
gui_base->add_child(surface_upgrade_dialog);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
confirmation = memnew(ConfirmationDialog);
gui_base->add_child(confirmation);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
confirmation->connect("confirmed", callable_mp(this, &EditorNode::_menu_confirm_current));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 06:15:39 +02:00
save_confirmation = memnew(ConfirmationDialog);
Fix cancel/OK button order on macOS The macOS platform convention regarding button order is cancel on left, OK on right.
2020-07-09 01:02:38 +02:00
save_confirmation->add_button(TTR("Don't Save"), DisplayServer::get_singleton()->get_swap_cancel_ok(), "discard");
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 06:15:39 +02:00
gui_base->add_child(save_confirmation);
Adjust size of some dialogs
2023-04-10 17:04:47 +02:00
save_confirmation->set_min_size(Vector2(450.0 * EDSCALE, 0));
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
save_confirmation->connect("confirmed", callable_mp(this, &EditorNode::_menu_confirm_current));
save_confirmation->connect("custom_action", callable_mp(this, &EditorNode::_discard_changes));
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 06:15:39 +02:00
Rename Godot's 'custom build' to 'gradle build' to better reflect the underlying build process.
2023-02-02 00:17:06 +01:00
gradle_build_manage_templates = memnew(ConfirmationDialog);
gradle_build_manage_templates->set_text(TTR("Android build template is missing, please install relevant templates."));
gradle_build_manage_templates->set_ok_button_text(TTR("Manage Templates"));
gradle_build_manage_templates->add_button(TTR("Install from file"))->connect("pressed", callable_mp(this, &EditorNode::_menu_option).bind(SETTINGS_INSTALL_ANDROID_BUILD_TEMPLATE));
gradle_build_manage_templates->connect("confirmed", callable_mp(this, &EditorNode::_menu_option).bind(SETTINGS_MANAGE_EXPORT_TEMPLATES));
gui_base->add_child(gradle_build_manage_templates);
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
Addes ability to load build sources from file. * If not present, the dialog asks to load build sources from a file. * The export templates check now also verifies that build sources are installed and skips the template check. This makes Android development easier.
2021-07-15 15:12:56 +02:00
file_android_build_source = memnew(EditorFileDialog);
Improve various texts
2021-11-23 12:20:57 +01:00
file_android_build_source->set_title(TTR("Select Android sources file"));
Addes ability to load build sources from file. * If not present, the dialog asks to load build sources from a file. * The export templates check now also verifies that build sources are installed and skips the template check. This makes Android development easier.
2021-07-15 15:12:56 +02:00
file_android_build_source->set_access(EditorFileDialog::ACCESS_FILESYSTEM);
file_android_build_source->set_file_mode(EditorFileDialog::FILE_MODE_OPEN_FILE);
file_android_build_source->add_filter("*.zip");
file_android_build_source->connect("file_selected", callable_mp(this, &EditorNode::_android_build_source_selected));
gui_base->add_child(file_android_build_source);
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
install_android_build_template = memnew(ConfirmationDialog);
Rename Godot's 'custom build' to 'gradle build' to better reflect the underlying build process.
2023-02-02 00:17:06 +01:00
install_android_build_template->set_text(TTR("This will set up your project for gradle Android builds by installing the source template to \"res://android/build\".\nYou can then apply modifications and build your own custom APK on export (adding modules, changing the AndroidManifest.xml, etc.).\nNote that in order to make gradle builds instead of using pre-built APKs, the \"Use Gradle Build\" option should be enabled in the Android export preset."));
Add ok_button_text to AcceptDialog and cancel_button_text to ConfirmationDialog
2022-07-08 02:31:19 +02:00
install_android_build_template->set_ok_button_text(TTR("Install"));
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
install_android_build_template->connect("confirmed", callable_mp(this, &EditorNode::_menu_confirm_current));
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
gui_base->add_child(install_android_build_template);
remove_android_build_template = memnew(ConfirmationDialog);
Android: Improve dialogs about custom build template The language didn't make it clear that it's installing a *source* template to the project folder, for later use when compiling custom APKs. Fixes #28736.
2019-08-27 13:07:24 +02:00
remove_android_build_template->set_text(TTR("The Android build template is already installed in this project and it won't be overwritten.\nRemove the \"res://android/build\" directory manually before attempting this operation again."));
Add ok_button_text to AcceptDialog and cancel_button_text to ConfirmationDialog
2022-07-08 02:31:19 +02:00
remove_android_build_template->set_ok_button_text(TTR("Show in File Manager"));
Remove Signal connect binds Remove the optional argument p_binds from `Object::connect` since it was deprecated by Callable.bind(). Changed all uses of it to Callable.bind()
2022-07-28 22:56:41 +02:00
remove_android_build_template->connect("confirmed", callable_mp(this, &EditorNode::_menu_option).bind(FILE_EXPLORE_ANDROID_BUILD_TEMPLATES));
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
gui_base->add_child(remove_android_build_template);
Some fixes and improvements. Changed FileDialogs for EditorFileDialogs in EditorNode. Updated CheckButton.
2017-11-10 23:45:08 +01:00
file_templates = memnew(EditorFileDialog);
i18n: Proofreading of all strings Done to ensure that no important identifiers are translatable, to fix compound strings using the new vformat() function, and some general English proofreading here and there.
2016-05-19 00:08:12 +02:00
file_templates->set_title(TTR("Import Templates From ZIP File"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
gui_base->add_child(file_templates);
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
file_templates->set_file_mode(EditorFileDialog::FILE_MODE_OPEN_FILE);
Some fixes and improvements. Changed FileDialogs for EditorFileDialogs in EditorNode. Updated CheckButton.
2017-11-10 23:45:08 +01:00
file_templates->set_access(EditorFileDialog::ACCESS_FILESYSTEM);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
file_templates->clear_filters();
Seperate filter and description in FileDialog.add_filter()
2022-07-04 23:26:26 +02:00
file_templates->add_filter("*.tpz", TTR("Template Package"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
work in progress, resource previews
2015-05-31 06:59:42 +02:00
file = memnew(EditorFileDialog);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
gui_base->add_child(file);
file->set_current_dir("res://");
Some fixes and improvements. Changed FileDialogs for EditorFileDialogs in EditorNode. Updated CheckButton.
2017-11-10 23:45:08 +01:00
file_export_lib = memnew(EditorFileDialog);
Modified editor strings to be translatable in the future
2016-05-04 03:25:37 +02:00
file_export_lib->set_title(TTR("Export Library"));
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
file_export_lib->set_file_mode(EditorFileDialog::FILE_MODE_SAVE_FILE);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
file_export_lib->connect("file_selected", callable_mp(this, &EditorNode::_dialog_action));
Use CheckBoxes in the editor instead of CheckButtons when applicable CheckButtons should only be used if toggling them has an immediate effect. Otherwise, CheckBoxes should be used.
2019-07-04 17:30:44 +02:00
file_export_lib_merge = memnew(CheckBox);
Modified editor strings to be translatable in the future
2016-05-04 03:25:37 +02:00
file_export_lib_merge->set_text(TTR("Merge With Existing"));
Improved some editor checkboxes
2021-11-21 21:29:34 +01:00
file_export_lib_merge->set_h_size_flags(Control::SIZE_SHRINK_CENTER);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
file_export_lib_merge->set_pressed(true);
file_export_lib->get_vbox()->add_child(file_export_lib_merge);
implement individual mesh transform for meshlibrary items
2021-09-01 01:17:33 +02:00
file_export_lib_apply_xforms = memnew(CheckBox);
file_export_lib_apply_xforms->set_text(TTR("Apply MeshInstance Transforms"));
Improved some editor checkboxes
2021-11-21 21:29:34 +01:00
file_export_lib_apply_xforms->set_h_size_flags(Control::SIZE_SHRINK_CENTER);
implement individual mesh transform for meshlibrary items
2021-09-01 01:17:33 +02:00
file_export_lib_apply_xforms->set_pressed(false);
file_export_lib->get_vbox()->add_child(file_export_lib_apply_xforms);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
gui_base->add_child(file_export_lib);
Some fixes and improvements. Changed FileDialogs for EditorFileDialogs in EditorNode. Updated CheckButton.
2017-11-10 23:45:08 +01:00
file_script = memnew(EditorFileDialog);
Modified editor strings to be translatable in the future
2016-05-04 03:25:37 +02:00
file_script->set_title(TTR("Open & Run a Script"));
Some fixes and improvements. Changed FileDialogs for EditorFileDialogs in EditorNode. Updated CheckButton.
2017-11-10 23:45:08 +01:00
file_script->set_access(EditorFileDialog::ACCESS_FILESYSTEM);
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
file_script->set_file_mode(EditorFileDialog::FILE_MODE_OPEN_FILE);
-run script in editor -add search docs dialog that returns places string was found -added flash
2014-02-21 03:01:44 +01:00
List<String> sexts;
ResourceLoader::get_recognized_extensions_for_type("Script", &sexts);
Use const references where possible for List range iterators
2021-07-24 15:46:25 +02:00
for (const String &E : sexts) {
Use C++ iterators for Lists in many situations
2021-07-16 05:45:57 +02:00
file_script->add_filter("*." + E);
-run script in editor -add search docs dialog that returns places string was found -added flash
2014-02-21 03:01:44 +01:00
}
gui_base->add_child(file_script);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
file_script->connect("file_selected", callable_mp(this, &EditorNode::_dialog_action));
-run script in editor -add search docs dialog that returns places string was found -added flash
2014-02-21 03:01:44 +01:00
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
file_menu->connect("id_pressed", callable_mp(this, &EditorNode::_menu_option));
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
file_menu->connect("about_to_popup", callable_mp(this, &EditorNode::_update_file_menu_opened));
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
file_menu->connect("popup_hide", callable_mp(this, &EditorNode::_update_file_menu_closed));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
settings_menu->connect("id_pressed", callable_mp(this, &EditorNode::_menu_option));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
file->connect("file_selected", callable_mp(this, &EditorNode::_dialog_action));
file_templates->connect("file_selected", callable_mp(this, &EditorNode::_dialog_action));
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
audio_preview_gen = memnew(AudioStreamPreviewGenerator);
add_child(audio_preview_gen);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Remove most EditorNode constructor parameters and fields
2022-01-27 10:36:51 +01:00
add_editor_plugin(memnew(DebuggerEditorPlugin(debug_menu)));
Detect external modification of scenes
2019-08-28 19:42:27 +02:00
disk_changed = memnew(ConfirmationDialog);
{
VBoxContainer *vbc = memnew(VBoxContainer);
disk_changed->add_child(vbc);
Label *dl = memnew(Label);
dl->set_text(TTR("The following files are newer on disk.\nWhat action should be taken?"));
vbc->add_child(dl);
disk_changed_list = memnew(Tree);
vbc->add_child(disk_changed_list);
disk_changed_list->set_v_size_flags(Control::SIZE_EXPAND_FILL);
disk_changed->connect("confirmed", callable_mp(this, &EditorNode::_reload_modified_scenes));
Detect external modification of project.godot
2021-01-17 01:09:17 +01:00
disk_changed->connect("confirmed", callable_mp(this, &EditorNode::_reload_project_settings));
Add ok_button_text to AcceptDialog and cancel_button_text to ConfirmationDialog
2022-07-08 02:31:19 +02:00
disk_changed->set_ok_button_text(TTR("Reload"));
Detect external modification of scenes
2019-08-28 19:42:27 +02:00
disk_changed->add_button(TTR("Resave"), !DisplayServer::get_singleton()->get_swap_cancel_ok(), "resave");
disk_changed->connect("custom_action", callable_mp(this, &EditorNode::_resave_scenes));
}
gui_base->add_child(disk_changed);
Remove most EditorNode constructor parameters and fields
2022-01-27 10:36:51 +01:00
add_editor_plugin(memnew(AnimationPlayerEditorPlugin));
Add inspector plugin for key time edit & Change find key argument
2022-12-08 13:38:01 +01:00
add_editor_plugin(memnew(AnimationTrackKeyEditEditorPlugin));
Remove most EditorNode constructor parameters and fields
2022-01-27 10:36:51 +01:00
add_editor_plugin(memnew(CanvasItemEditorPlugin));
add_editor_plugin(memnew(Node3DEditorPlugin));
add_editor_plugin(memnew(ScriptEditorPlugin));
WIP new AudioServer, with buses, effects, etc.
2017-01-21 23:00:25 +01:00
Audio bus editing is COMPLETE!
2017-01-25 18:30:40 +01:00
EditorAudioBuses *audio_bus_editor = EditorAudioBuses::register_editor();
WIP new AudioServer, with buses, effects, etc.
2017-01-21 23:00:25 +01:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
ScriptTextEditor::register_editor(); // Register one for text scripts.
Allow opening and editing of any utf_8 file in script editor
2018-05-28 17:52:28 +02:00
TextEditor::register_editor();
WIP visual scripting, not working yet but you can check out stuff
2016-08-03 00:11:05 +02:00
[AssetLib] Fix crash in Web editor. Add EditorAssetLibrary::is_available which always returns false in the Web editor and use it in EditorNode for detection.
2022-06-29 19:27:27 +02:00
if (AssetLibraryEditorPlugin::is_available()) {
Remove most EditorNode constructor parameters and fields
2022-01-27 10:36:51 +01:00
add_editor_plugin(memnew(AssetLibraryEditorPlugin));
Better way to disable asset library
2016-06-10 03:47:43 +02:00
} else {
AssetLib: Only notify when unavailable in verbose mode
2022-07-08 15:25:54 +02:00
print_verbose("Asset Library not available (due to using Web editor, or SSL support disabled).");
Better way to disable asset library
2016-06-10 03:47:43 +02:00
}
-Split EditorPlugin into EditorPlugin and EditorInterface -Added EditorInterface to EditorScript -Added functions to save the scene to EditorInterface
2017-08-26 15:32:15 +02:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// More visually meaningful to have this later.
Implemented SkeletonEditorGizmo Co-authored-by: Lyuma <xn.lyuma@gmail.com>
2021-02-04 09:20:26 +01:00
raise_bottom_panel_item(AnimationPlayerEditor::get_singleton());
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
Add VCS editor plugin UI elements to editor
2019-09-03 16:42:08 +02:00
add_editor_plugin(VersionControlEditorPlugin::get_singleton());
Fix theme of editor VCS dialogs These dialogs were added to the plugin itself so theme can't be propagated. Also moved initialization of the VCS menu after the creation of EditorInterface.
2023-04-12 14:59:34 +02:00
vcs_actions_menu = VersionControlEditorPlugin::get_singleton()->get_version_control_actions_panel();
vcs_actions_menu->set_name("Version Control");
vcs_actions_menu->connect("index_pressed", callable_mp(this, &EditorNode::_version_control_menu_option));
Fix menu items that trigger secondary interface missing ellipsis fix #80347
2023-08-09 15:25:03 +02:00
vcs_actions_menu->add_item(TTR("Create Version Control Metadata..."), RUN_VCS_METADATA);
vcs_actions_menu->add_item(TTR("Version Control Settings..."), RUN_VCS_SETTINGS);
Fix theme of editor VCS dialogs These dialogs were added to the plugin itself so theme can't be propagated. Also moved initialization of the VCS menu after the creation of EditorInterface.
2023-04-12 14:59:34 +02:00
project_menu->add_child(vcs_actions_menu);
project_menu->set_item_submenu(project_menu->get_item_index(VCS_MENU), "Version Control");
Alphabetize editor plugins and move 2D plugins to their own section
2022-07-16 20:22:50 +02:00
add_editor_plugin(memnew(AudioBusesEditorPlugin(audio_bus_editor)));
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
for (int i = 0; i < EditorPlugins::get_plugin_count(); i++) {
Remove the EditorNode parameter from EditorPlugins create methods Remove EditorNode usage from the Navigation editor plugin.
2022-02-14 17:59:06 +01:00
add_editor_plugin(EditorPlugins::create(i));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Allow GDExtensions to add editor plugins
2023-05-11 23:46:53 +02:00
for (const StringName &extension_class_name : GDExtensionEditorPlugins::get_extension_classes()) {
add_extension_editor_plugin(extension_class_name);
}
GDExtensionEditorPlugins::editor_node_add_plugin = &EditorNode::add_extension_editor_plugin;
GDExtensionEditorPlugins::editor_node_remove_plugin = &EditorNode::remove_extension_editor_plugin;
Likely with bugs and with some features are missing, as well as profiler support, but VisualScript should be more or less done!
2016-08-07 00:00:54 +02:00
for (int i = 0; i < plugin_init_callback_count; i++) {
plugin_init_callbacks[i]();
}
work in progress, resource previews
2015-05-31 06:59:42 +02:00
-Restored multithread capability to VisualServer -Restored resource previews!
2017-06-09 05:23:50 +02:00
resource_preview->add_preview_generator(Ref<EditorTexturePreviewPlugin>(memnew(EditorTexturePreviewPlugin)));
Generate inspector preview for Image resources
2020-06-27 22:03:20 +02:00
resource_preview->add_preview_generator(Ref<EditorImagePreviewPlugin>(memnew(EditorImagePreviewPlugin)));
-Restored multithread capability to VisualServer -Restored resource previews!
2017-06-09 05:23:50 +02:00
resource_preview->add_preview_generator(Ref<EditorPackedScenePreviewPlugin>(memnew(EditorPackedScenePreviewPlugin)));
resource_preview->add_preview_generator(Ref<EditorMaterialPreviewPlugin>(memnew(EditorMaterialPreviewPlugin)));
resource_preview->add_preview_generator(Ref<EditorScriptPreviewPlugin>(memnew(EditorScriptPreviewPlugin)));
Entirely new (and much improved) animation editor.
2018-06-07 17:46:14 +02:00
resource_preview->add_preview_generator(Ref<EditorAudioStreamPreviewPlugin>(memnew(EditorAudioStreamPreviewPlugin)));
-Restored multithread capability to VisualServer -Restored resource previews!
2017-06-09 05:23:50 +02:00
resource_preview->add_preview_generator(Ref<EditorMeshPreviewPlugin>(memnew(EditorMeshPreviewPlugin)));
resource_preview->add_preview_generator(Ref<EditorBitmapPreviewPlugin>(memnew(EditorBitmapPreviewPlugin)));
Adding font preview to file browsers
2018-04-16 05:00:56 +02:00
resource_preview->add_preview_generator(Ref<EditorFontPreviewPlugin>(memnew(EditorFontPreviewPlugin)));
Add gradient resource preview generator
2022-04-21 00:08:35 +02:00
resource_preview->add_preview_generator(Ref<EditorGradientPreviewPlugin>(memnew(EditorGradientPreviewPlugin)));
Likely with bugs and with some features are missing, as well as profiler support, but VisualScript should be more or less done!
2016-08-07 00:00:54 +02:00
Ability to convert from SpatialMaterial to ShaderMaterial
2017-09-22 14:20:28 +02:00
{
Modernized default 3D material, fixes material bugs.
2019-09-15 06:01:52 +02:00
Ref<StandardMaterial3DConversionPlugin> spatial_mat_convert;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
spatial_mat_convert.instantiate();
Ability to convert from SpatialMaterial to ShaderMaterial
2017-09-22 14:20:28 +02:00
resource_conversion_plugins.push_back(spatial_mat_convert);
Create ParticlesMaterialConversionPlugin and format generated shader code
2017-10-12 13:12:50 +02:00
Added convertor from `ORMMaterial3D` to `ShaderMaterial`
2021-10-29 16:49:12 +02:00
Ref<ORMMaterial3DConversionPlugin> orm_mat_convert;
orm_mat_convert.instantiate();
resource_conversion_plugins.push_back(orm_mat_convert);
Finalized ability to convert from CanvasItem/Spatial/Particles materials to ShaderMaterial, closes #10242
2017-11-14 19:44:51 +01:00
Ref<CanvasItemMaterialConversionPlugin> canvas_item_mat_convert;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
canvas_item_mat_convert.instantiate();
Finalized ability to convert from CanvasItem/Spatial/Particles materials to ShaderMaterial, closes #10242
2017-11-14 19:44:51 +01:00
resource_conversion_plugins.push_back(canvas_item_mat_convert);
Rename ParticlesMaterial to ParticleProcessMaterial Also affects their file names, related classes and documentation.
2022-08-18 11:09:22 +02:00
Ref<ParticleProcessMaterialConversionPlugin> particles_mat_convert;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
particles_mat_convert.instantiate();
Create ParticlesMaterialConversionPlugin and format generated shader code
2017-10-12 13:12:50 +02:00
resource_conversion_plugins.push_back(particles_mat_convert);
Added convertor from VisualShader to Shader
2019-06-28 13:51:51 +02:00
Working sky shader implementation
2020-03-20 01:32:19 +01:00
Ref<ProceduralSkyMaterialConversionPlugin> procedural_sky_mat_convert;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
procedural_sky_mat_convert.instantiate();
Working sky shader implementation
2020-03-20 01:32:19 +01:00
resource_conversion_plugins.push_back(procedural_sky_mat_convert);
Ref<PanoramaSkyMaterialConversionPlugin> panorama_sky_mat_convert;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
panorama_sky_mat_convert.instantiate();
Working sky shader implementation
2020-03-20 01:32:19 +01:00
resource_conversion_plugins.push_back(panorama_sky_mat_convert);
Ref<PhysicalSkyMaterialConversionPlugin> physical_sky_mat_convert;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
physical_sky_mat_convert.instantiate();
Working sky shader implementation
2020-03-20 01:32:19 +01:00
resource_conversion_plugins.push_back(physical_sky_mat_convert);
Addition of FogVolumes, FogShaders, FogMaterial, and overhaul of VolumetricFog Co-authored-by: Brian Semrau <brian.semrau@gmail.com>
2021-10-03 13:28:55 +02:00
Ref<FogMaterialConversionPlugin> fog_mat_convert;
fog_mat_convert.instantiate();
resource_conversion_plugins.push_back(fog_mat_convert);
Added convertor from VisualShader to Shader
2019-06-28 13:51:51 +02:00
Ref<VisualShaderConversionPlugin> vshader_convert;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
vshader_convert.instantiate();
Added convertor from VisualShader to Shader
2019-06-28 13:51:51 +02:00
resource_conversion_plugins.push_back(vshader_convert);
Ability to convert from SpatialMaterial to ShaderMaterial
2017-09-22 14:20:28 +02:00
}
Implement Feature Build Profiles This PR is a continuation of #50381 (which was implemented exactly a year ago!) * Add a visual interface to select which classes should not be built into Godot (well, they are built if something else uses them, but if not used the optimizer will remove them out). * Add a detection system to scan the project and figure out the actual classes used. * Added the ability for SCons to load build profiles. Obligatory Screen: A simple test with a couple of nodes in the scene resulted in a 25% reduction for the final binary size TODO: * Script languages need to implement used class detection (left for another PR). * Options to disable servers or server functionalities (like 2D or 3D physics, navigation, etc). Are missing, that should also greatly aid in reducing binary size. * Options to disable some modules would be desired. * More options to disable drivers (OpenGL, Vulkan, etc) would be desired. In general this PR is a starting point for more contributors to improve and enhance this functionality.
2022-07-14 14:18:18 +02:00
Make visibility of update spinner editor-wide, hidden by default - Make visibility of the spinner and "update always" option editor-wide, rather than per-project metadata. - Add options "Show Update Spinner" and "Update Continuously" under Editor Settings > Interface > Editor. Both options are false by default. - Rename some variables and constants to be more consistent and clearer: "update always" -> "update continuously", "update changes" -> "update when changed", "update menu" -> "update spinner", "circle" -> "update spinner". Fixes #23738.
2018-12-11 16:52:25 +01:00
update_spinner_step_msec = OS::get_singleton()->get_ticks_msec();
update_spinner_step_frame = Engine::get_singleton()->get_frames_drawn();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
editor_plugin_screen = nullptr;
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-30 01:02:53 +02:00
editor_plugins_over = memnew(EditorPluginList);
Universalize draw-over API for EditorPlugins - Now it is usable from both `CanvasItem` and `Spatial` editors. - `EditorPlugin` API changes: - `forward_draw_over_canvas()` becomes `forward_draw_over_viewport()`. - `update_canvas()` becomes `update_overlays()`, which now triggers the update of every overlay on top of any 2D or 3D viewports present. Also now it returns the number of such viewports, which is useful whenever you need to know the number of draw-over calls you'll get. - New: `[set/is]_force_draw_over_forwarding_enabled()` to force overlaying regardless it handles the current object type, in a similar fashion as `[set/is]_input_event_forwarding_always_enabled`. This kind of overlay is also on top of those for regular handled node types. - New: `forward_force_draw_over_canvas()`, which is the callback that gets called for plugins that enable forced overlaying.
2017-10-29 20:32:09 +01:00
editor_plugins_force_over = memnew(EditorPluginList);
EditorPlugin can request user inputs from editor 3d view
2017-06-08 19:57:35 +02:00
editor_plugins_force_input_forwarding = memnew(EditorPluginList);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Implement GDExtension export plugin.
2022-03-10 08:48:25 +01:00
Ref<GDExtensionExportPlugin> gdextension_export_plugin;
gdextension_export_plugin.instantiate();
EditorExport::get_singleton()->add_export_plugin(gdextension_export_plugin);
Add "dedicated server" export mode which can strip unneeded visual resources
2022-12-20 22:49:11 +01:00
Ref<DedicatedServerExportPlugin> dedicated_server_export_plugin;
dedicated_server_export_plugin.instantiate();
EditorExport::get_singleton()->add_export_plugin(dedicated_server_export_plugin);
Add translation parser plugin support
2020-06-23 13:48:59 +02:00
Ref<PackedSceneEditorTranslationParserPlugin> packed_scene_translation_parser_plugin;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 00:03:09 +02:00
packed_scene_translation_parser_plugin.instantiate();
Add translation parser plugin support
2020-06-23 13:48:59 +02:00
EditorTranslationParser::get_singleton()->add_parser(packed_scene_translation_parser_plugin, EditorTranslationParser::STANDARD);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
_edit_current();
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
current = nullptr;
Add Save option to resource property menu
2018-11-18 15:17:04 +01:00
saving_resource = Ref<Resource>();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
set_process(true);
completed scene importing (I hope?)
2017-02-05 00:31:15 +01:00
open_imported = memnew(ConfirmationDialog);
Add ok_button_text to AcceptDialog and cancel_button_text to ConfirmationDialog
2022-07-08 02:31:19 +02:00
open_imported->set_ok_button_text(TTR("Open Anyway"));
Fix cancel/OK button order on macOS The macOS platform convention regarding button order is cancel on left, OK on right.
2020-07-09 01:02:38 +02:00
new_inherited_button = open_imported->add_button(TTR("New Inherited"), !DisplayServer::get_singleton()->get_swap_cancel_ok(), "inherit");
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
open_imported->connect("confirmed", callable_mp(this, &EditorNode::_open_imported));
open_imported->connect("custom_action", callable_mp(this, &EditorNode::_inherit_imported));
completed scene importing (I hope?)
2017-02-05 00:31:15 +01:00
gui_base->add_child(open_imported);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
quick_open = memnew(EditorQuickOpen);
gui_base->add_child(quick_open);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
quick_open->connect("quick_open", callable_mp(this, &EditorNode::_quick_opened));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
_update_recent_scenes();
[Input] Add extra `shortcut_input` input processing step to process Unicode character input with Alt / Ctrl modifiers, after processing of shortcuts.
2022-01-11 14:59:52 +01:00
set_process_shortcut_input(true);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Fix error reporting when a scene is not imported properly, closes #3968
2016-06-26 20:37:04 +02:00
load_errors = memnew(RichTextLabel);
Expose dialog parent-and-popup logic to the API
2023-04-20 15:13:21 +02:00
load_error_dialog = memnew(AcceptDialog);
load_error_dialog->set_unparent_when_invisible(true);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
load_error_dialog->add_child(load_errors);
Modified editor strings to be translatable in the future
2016-05-04 03:25:37 +02:00
load_error_dialog->set_title(TTR("Load Errors"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
execute_outputs = memnew(RichTextLabel);
Enable text selection in execute output of EditorNode
2020-06-04 14:38:55 +02:00
execute_outputs->set_selection_enabled(true);
Enable `RichTextLabel` context menu if selection is enabled
2023-02-28 14:19:48 +01:00
execute_outputs->set_context_menu_enabled(true);
Expose dialog parent-and-popup logic to the API
2023-04-20 15:13:21 +02:00
execute_output_dialog = memnew(AcceptDialog);
execute_output_dialog->set_unparent_when_invisible(true);
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
execute_output_dialog->add_child(execute_outputs);
i18n: Fix extract.py support for new TTRC Also make compatible with Python 3.
2019-06-16 21:57:34 +02:00
execute_output_dialog->set_title("");
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
EditorFileSystem::get_singleton()->connect("sources_changed", callable_mp(this, &EditorNode::_sources_changed));
EditorFileSystem::get_singleton()->connect("filesystem_changed", callable_mp(this, &EditorNode::_fs_changed));
EditorFileSystem::get_singleton()->connect("resources_reimported", callable_mp(this, &EditorNode::_resources_reimported));
EditorFileSystem::get_singleton()->connect("resources_reload", callable_mp(this, &EditorNode::_resources_changed));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Update icons when theme changed
2018-02-25 17:04:16 +01:00
_build_icon_type_cache();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Ask about selecting a main scene if one has not been selected.
2016-06-28 00:59:33 +02:00
pick_main_scene = memnew(ConfirmationDialog);
gui_base->add_child(pick_main_scene);
Add ok_button_text to AcceptDialog and cancel_button_text to ConfirmationDialog
2022-07-08 02:31:19 +02:00
pick_main_scene->set_ok_button_text(TTR("Select"));
Remove Signal connect binds Remove the optional argument p_binds from `Object::connect` since it was deprecated by Callable.bind(). Changed all uses of it to Callable.bind()
2022-07-28 22:56:41 +02:00
pick_main_scene->connect("confirmed", callable_mp(this, &EditorNode::_menu_option).bind(SETTINGS_PICK_MAIN_SCENE));
Added 'Select Current' option when user is prompted to select main scene after clicking play
2021-07-06 16:10:07 +02:00
select_current_scene_button = pick_main_scene->add_button(TTR("Select Current"), true, "select_current");
pick_main_scene->connect("custom_action", callable_mp(this, &EditorNode::_pick_main_scene_custom_action));
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
for (int i = 0; i < _init_callbacks.size(); i++) {
-scripts are converted to bytecode on export -fix bug in doc where touchscreen events were not documented
2014-02-25 13:31:47 +01:00
_init_callbacks[i]();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
editor_data.add_edited_scene(-1);
editor_data.set_edited_scene(0);
Extract editor scene tabs into their own component
2023-08-24 12:24:29 +02:00
scene_tabs->update_scene_tabs();
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
Store panels and docks singletons in their own classes
2021-11-17 21:08:55 +01:00
ImportDock::get_singleton()->initialize_import_options();
Suppress get_edited_scene_root error
2017-07-23 16:44:42 +02:00
-Add visible IO errors when closing a file fails due to it being locked (most likely on windows), closes #4760
2016-06-13 15:10:50 +02:00
FileAccess::set_file_close_fail_notify_callback(_file_access_close_error_notify);
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
Add a print handler for the editor output panel
2017-11-14 23:02:31 +01:00
print_handler.printfunc = _print_handler;
print_handler.userdata = this;
add_print_handler(&print_handler);
Moved folding outside the resource files, now saved outside the project.
2018-10-29 20:36:31 +01:00
ResourceSaver::set_save_callback(_resource_saved);
ResourceLoader::set_load_callback(_resource_loaded);
Require Ctrl for switching between editors, bind F2 to Rename Node Switching between editors now requires holding Ctrl to avoid conflicts with the new F2 shortcut. The asset library can now be accessed by pressing Ctrl + F4 on Windows and Linux, or Alt + 4 on macOS. This partially addresses #38139.
2020-04-25 15:04:49 +02:00
// Use the Ctrl modifier so F2 can be used to rename nodes in the scene tree dock.
Use "enum class" for input enums
2021-08-13 23:31:57 +02:00
ED_SHORTCUT_AND_COMMAND("editor/editor_2d", TTR("Open 2D Editor"), KeyModifierMask::CTRL | Key::F1);
ED_SHORTCUT_AND_COMMAND("editor/editor_3d", TTR("Open 3D Editor"), KeyModifierMask::CTRL | Key::F2);
ED_SHORTCUT_AND_COMMAND("editor/editor_script", TTR("Open Script Editor"), KeyModifierMask::CTRL | Key::F3);
ED_SHORTCUT_AND_COMMAND("editor/editor_assetlib", TTR("Open Asset Library"), KeyModifierMask::CTRL | Key::F4);
[macOS] Replace all `Alt/Option+Letter/Number` default shortcuts to avoid conflicts with special character input.
2023-02-16 10:28:04 +01:00
ED_SHORTCUT_OVERRIDE("editor/editor_2d", "macos", KeyModifierMask::META | KeyModifierMask::CTRL | Key::KEY_1);
ED_SHORTCUT_OVERRIDE("editor/editor_3d", "macos", KeyModifierMask::META | KeyModifierMask::CTRL | Key::KEY_2);
ED_SHORTCUT_OVERRIDE("editor/editor_script", "macos", KeyModifierMask::META | KeyModifierMask::CTRL | Key::KEY_3);
ED_SHORTCUT_OVERRIDE("editor/editor_assetlib", "macos", KeyModifierMask::META | KeyModifierMask::CTRL | Key::KEY_4);
Added ability to override shortcut definitions for OSX (remove preprocessor defines)
2021-08-08 05:52:00 +02:00
ED_SHORTCUT_AND_COMMAND("editor/editor_next", TTR("Open the next Editor"));
ED_SHORTCUT_AND_COMMAND("editor/editor_prev", TTR("Open the previous Editor"));
Add editor screenshot on control - f12.
2019-03-29 14:53:11 +01:00
screenshot_timer = memnew(Timer);
screenshot_timer->set_one_shot(true);
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
screenshot_timer->set_wait_time(settings_menu->get_submenu_popup_delay() + 0.1f);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
screenshot_timer->connect("timeout", callable_mp(this, &EditorNode::_request_screenshot));
Add editor screenshot on control - f12.
2019-03-29 14:53:11 +01:00
add_child(screenshot_timer);
screenshot_timer->set_owner(get_owner());
for third-party tools - editor_path is stored in project's editor settings
2020-03-12 13:59:48 +01:00
[macOS] Extend editor contents to the window titlebar for better space usage.
2022-08-23 12:40:48 +02:00
// Adjust spacers to center 2D / 3D / Script buttons.
Extract editor run toolbar into its own component - Simplify and update its logic. - Simplify EditorScript. - Improve EditorNode and other relevant includes. - Fix scene-based path in the movie writer when reloading a scene.
2023-04-12 21:02:28 +02:00
int max_w = MAX(project_run_bar->get_minimum_size().x + right_menu_hb->get_minimum_size().x, main_menu->get_minimum_size().x);
[macOS] Extend editor contents to the window titlebar for better space usage.
2022-08-23 12:40:48 +02:00
left_spacer->set_custom_minimum_size(Size2(MAX(0, max_w - main_menu->get_minimum_size().x), 0));
Extract editor run toolbar into its own component - Simplify and update its logic. - Simplify EditorScript. - Improve EditorNode and other relevant includes. - Fix scene-based path in the movie writer when reloading a scene.
2023-04-12 21:02:28 +02:00
right_spacer->set_custom_minimum_size(Size2(MAX(0, max_w - project_run_bar->get_minimum_size().x - right_menu_hb->get_minimum_size().x), 0));
[macOS] Extend editor contents to the window titlebar for better space usage.
2022-08-23 12:40:48 +02:00
// Extend menu bar to window title.
if (can_expand) {
[macOS] Process events before changing title style to update window frame.
2023-11-15 08:33:23 +01:00
DisplayServer::get_singleton()->process_events();
[macOS] Extend editor contents to the window titlebar for better space usage.
2022-08-23 12:40:48 +02:00
DisplayServer::get_singleton()->window_set_flag(DisplayServer::WINDOW_FLAG_EXTEND_TO_TITLE, true, DisplayServer::MAIN_WINDOW_ID);
Extract editor run toolbar into its own component - Simplify and update its logic. - Simplify EditorScript. - Improve EditorNode and other relevant includes. - Fix scene-based path in the movie writer when reloading a scene.
2023-04-12 21:02:28 +02:00
title_bar->set_can_move_window(true);
[macOS] Extend editor contents to the window titlebar for better space usage.
2022-08-23 12:40:48 +02:00
}
Implement `MenuBar` control to wrap `PopupMenu`s or native menu, use native menu for editor.
2022-08-01 11:28:16 +02:00
for third-party tools - editor_path is stored in project's editor settings
2020-03-12 13:59:48 +01:00
String exec = OS::get_singleton()->get_executable_path();
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 20:12:26 +02:00
// Save editor executable path for third-party tools.
EditorSettings::get_singleton()->set_project_metadata("editor_metadata", "executable_path", exec);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
remove trailing whitespace
2016-03-09 00:00:52 +01:00
EditorNode::~EditorNode() {
-New inspector. -Changed UI resizing code, gained huge amount of speed. -Reorganized timer sync to clean up behavior (sorry forgot commit this before) -
2018-05-15 22:12:35 +02:00
EditorInspector::cleanup_plugins();
Fix EditorTranslationParser leak
2020-07-27 16:58:21 +02:00
EditorTranslationParser::get_singleton()->clean_parsers();
Import scenes as AnimationLibrary Added the ability to import scenes as AnimationLibrary * Completes implementation of https://github.com/godotengine/godot-proposals/issues/4296 * Helps if you want to export animations to a separate file (say a GLTF) to avoid re-importing/exporting them every time the model changes. * Helps if you simply want to have animations using a dummy model, which can be shared across multiple models. Creates a secondary scene importer used only for animations. **NOTE**: A new flag for scene importer: EditorSceneFormatImporter.IMPORT_DISCARD_MESHES_AND_MATERIALS has been added, to hint importers that they should skip meshes and animations (and hence make importing faster). It is not implemented in any importer yet, this should be done in a separate PR.
2022-04-12 16:07:09 +02:00
ResourceImporterScene::clean_up_importer_plugins();
-New inspector. -Changed UI resizing code, gained huge amount of speed. -Reorganized timer sync to clean up behavior (sorry forgot commit this before) -
2018-05-15 22:12:35 +02:00
Add a print handler for the editor output panel
2017-11-14 23:02:31 +01:00
remove_print_handler(&print_handler);
Generate editor docs on a thread * The main generation could not be moved to a thread, as it instantiates classes to get default values, interacts with ProjectSettings, etc. * Only uncompressing documentation and merging it is threaded. * Seems to improve editor load times by 0.5 seconds.
2021-07-25 19:44:03 +02:00
EditorHelp::cleanup_doc();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
memdelete(editor_selection);
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-30 01:02:53 +02:00
memdelete(editor_plugins_over);
Universalize draw-over API for EditorPlugins - Now it is usable from both `CanvasItem` and `Spatial` editors. - `EditorPlugin` API changes: - `forward_draw_over_canvas()` becomes `forward_draw_over_viewport()`. - `update_canvas()` becomes `update_overlays()`, which now triggers the update of every overlay on top of any 2D or 3D viewports present. Also now it returns the number of such viewports, which is useful whenever you need to know the number of draw-over calls you'll get. - New: `[set/is]_force_draw_over_forwarding_enabled()` to force overlaying regardless it handles the current object type, in a similar fashion as `[set/is]_input_event_forwarding_always_enabled`. This kind of overlay is also on top of those for regular handled node types. - New: `forward_force_draw_over_canvas()`, which is the callback that gets called for plugins that enable forced overlaying.
2017-10-29 20:32:09 +01:00
memdelete(editor_plugins_force_over);
EditorPlugin can request user inputs from editor 3d view
2017-06-08 19:57:35 +02:00
memdelete(editor_plugins_force_input_forwarding);
Fixed several memory leaks
2017-08-24 18:51:28 +02:00
memdelete(progress_hb);
Implementation of tool to automatically upgrade and re-save meshes
2023-10-19 13:31:26 +02:00
memdelete(surface_upgrade_tool);
-Moved EditorDefaultValue to ClassDB, made it core -Removed one and zero hints for properties, replaced by default value
2018-11-08 15:30:02 +01:00
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
EditorSettings::destroy();
Fix StringName leaks in GDExtension, core, and editor themes
2023-10-18 17:36:20 +02:00
EditorColorMap::finish();
EditorTheme::finalize();
Prevent GDExtensions from trying to remove editor plugins at shutdown
2023-07-15 00:48:14 +02:00
GDExtensionEditorPlugins::editor_node_add_plugin = nullptr;
GDExtensionEditorPlugins::editor_node_remove_plugin = nullptr;
Avoid crash on exiting due to late prints
2023-08-02 11:43:35 +02:00
Disconnect `EditorNode` from file dialogs on destruction
2023-11-01 13:01:28 +01:00
FileDialog::get_icon_func = nullptr;
FileDialog::register_func = nullptr;
FileDialog::unregister_func = nullptr;
EditorFileDialog::get_icon_func = nullptr;
EditorFileDialog::register_func = nullptr;
EditorFileDialog::unregister_func = nullptr;
file_dialogs.clear();
editor_file_dialogs.clear();
Avoid crash on exiting due to late prints
2023-08-02 11:43:35 +02:00
singleton = nullptr;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-30 01:02:53 +02:00
/*
* EDITOR PLUGIN LIST
*/
void EditorPluginList::make_visible(bool p_visible) {
Made it possible to properly draw over the 2D canvas for 2D objects. Arranged some functions to achieve this.
2016-09-10 21:44:03 +02:00
for (int i = 0; i < plugins_list.size(); i++) {
plugins_list[i]->make_visible(p_visible);
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-30 01:02:53 +02:00
}
}
void EditorPluginList::edit(Object *p_object) {
Made it possible to properly draw over the 2D canvas for 2D objects. Arranged some functions to achieve this.
2016-09-10 21:44:03 +02:00
for (int i = 0; i < plugins_list.size(); i++) {
plugins_list[i]->edit(p_object);
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-30 01:02:53 +02:00
}
}
Fixes snapping and replaces the _draw_canvas by forward_canvas_draw
2017-10-15 22:33:25 +02:00
bool EditorPluginList::forward_gui_input(const Ref<InputEvent> &p_event) {
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-30 01:02:53 +02:00
bool discard = false;
Made it possible to properly draw over the 2D canvas for 2D objects. Arranged some functions to achieve this.
2016-09-10 21:44:03 +02:00
for (int i = 0; i < plugins_list.size(); i++) {
Fixes snapping and replaces the _draw_canvas by forward_canvas_draw
2017-10-15 22:33:25 +02:00
if (plugins_list[i]->forward_canvas_gui_input(p_event)) {
Made it possible to properly draw over the 2D canvas for 2D objects. Arranged some functions to achieve this.
2016-09-10 21:44:03 +02:00
discard = true;
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-30 01:02:53 +02:00
}
}
Made it possible to properly draw over the 2D canvas for 2D objects. Arranged some functions to achieve this.
2016-09-10 21:44:03 +02:00
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-30 01:02:53 +02:00
return discard;
}
Rename remaining "Spatial" in Plugins to "Node3D" For EditorNode3DGizmo: - `get_spatial_node` -> `get_node_3d` - `set_spatial_node` -> `set_node_3d` For EditorPlugin: - `add_spatial_gizmo_plugin` -> `add_node_3d_gizmo_plugin` - `remove_spatial_gizmo_plugin` -> `remove_node_3d_gizmo_plugin` Also renames some internal methods for consistency (`forward_3d_draw_over_viewport` & `forward_3d_force_draw_over_viewport` ...). Basically, Spatial has been completely eradicated.
2022-09-08 18:38:33 +02:00
EditorPlugin::AfterGUIInput EditorPluginList::forward_3d_gui_input(Camera3D *p_camera, const Ref<InputEvent> &p_event, bool serve_when_force_input_enabled) {
Implemented SkeletonEditorGizmo Co-authored-by: Lyuma <xn.lyuma@gmail.com>
2021-02-04 09:20:26 +01:00
EditorPlugin::AfterGUIInput after = EditorPlugin::AFTER_GUI_INPUT_PASS;
Made it possible to properly draw over the 2D canvas for 2D objects. Arranged some functions to achieve this.
2016-09-10 21:44:03 +02:00
for (int i = 0; i < plugins_list.size(); i++) {
EditorPlugin can request user inputs from editor 3d view
2017-06-08 19:57:35 +02:00
if ((!serve_when_force_input_enabled) && plugins_list[i]->is_input_event_forwarding_always_enabled()) {
continue;
}
Rename remaining "Spatial" in Plugins to "Node3D" For EditorNode3DGizmo: - `get_spatial_node` -> `get_node_3d` - `set_spatial_node` -> `set_node_3d` For EditorPlugin: - `add_spatial_gizmo_plugin` -> `add_node_3d_gizmo_plugin` - `remove_spatial_gizmo_plugin` -> `remove_node_3d_gizmo_plugin` Also renames some internal methods for consistency (`forward_3d_draw_over_viewport` & `forward_3d_force_draw_over_viewport` ...). Basically, Spatial has been completely eradicated.
2022-09-08 18:38:33 +02:00
EditorPlugin::AfterGUIInput current_after = plugins_list[i]->forward_3d_gui_input(p_camera, p_event);
Implemented SkeletonEditorGizmo Co-authored-by: Lyuma <xn.lyuma@gmail.com>
2021-02-04 09:20:26 +01:00
if (current_after == EditorPlugin::AFTER_GUI_INPUT_STOP) {
after = EditorPlugin::AFTER_GUI_INPUT_STOP;
}
bind AfterGUIInput
2022-08-15 20:04:17 +02:00
if (after != EditorPlugin::AFTER_GUI_INPUT_STOP && current_after == EditorPlugin::AFTER_GUI_INPUT_CUSTOM) {
after = EditorPlugin::AFTER_GUI_INPUT_CUSTOM;
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-30 01:02:53 +02:00
}
}
Made it possible to properly draw over the 2D canvas for 2D objects. Arranged some functions to achieve this.
2016-09-10 21:44:03 +02:00
Implemented SkeletonEditorGizmo Co-authored-by: Lyuma <xn.lyuma@gmail.com>
2021-02-04 09:20:26 +01:00
return after;
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-30 01:02:53 +02:00
}
Fixes drawing of the 2D plugins on the 3D view
2018-09-18 20:00:07 +02:00
void EditorPluginList::forward_canvas_draw_over_viewport(Control *p_overlay) {
Made it possible to properly draw over the 2D canvas for 2D objects. Arranged some functions to achieve this.
2016-09-10 21:44:03 +02:00
for (int i = 0; i < plugins_list.size(); i++) {
Fixes drawing of the 2D plugins on the 3D view
2018-09-18 20:00:07 +02:00
plugins_list[i]->forward_canvas_draw_over_viewport(p_overlay);
Universalize draw-over API for EditorPlugins - Now it is usable from both `CanvasItem` and `Spatial` editors. - `EditorPlugin` API changes: - `forward_draw_over_canvas()` becomes `forward_draw_over_viewport()`. - `update_canvas()` becomes `update_overlays()`, which now triggers the update of every overlay on top of any 2D or 3D viewports present. Also now it returns the number of such viewports, which is useful whenever you need to know the number of draw-over calls you'll get. - New: `[set/is]_force_draw_over_forwarding_enabled()` to force overlaying regardless it handles the current object type, in a similar fashion as `[set/is]_input_event_forwarding_always_enabled`. This kind of overlay is also on top of those for regular handled node types. - New: `forward_force_draw_over_canvas()`, which is the callback that gets called for plugins that enable forced overlaying.
2017-10-29 20:32:09 +01:00
}
}
Fixes drawing of the 2D plugins on the 3D view
2018-09-18 20:00:07 +02:00
void EditorPluginList::forward_canvas_force_draw_over_viewport(Control *p_overlay) {
Universalize draw-over API for EditorPlugins - Now it is usable from both `CanvasItem` and `Spatial` editors. - `EditorPlugin` API changes: - `forward_draw_over_canvas()` becomes `forward_draw_over_viewport()`. - `update_canvas()` becomes `update_overlays()`, which now triggers the update of every overlay on top of any 2D or 3D viewports present. Also now it returns the number of such viewports, which is useful whenever you need to know the number of draw-over calls you'll get. - New: `[set/is]_force_draw_over_forwarding_enabled()` to force overlaying regardless it handles the current object type, in a similar fashion as `[set/is]_input_event_forwarding_always_enabled`. This kind of overlay is also on top of those for regular handled node types. - New: `forward_force_draw_over_canvas()`, which is the callback that gets called for plugins that enable forced overlaying.
2017-10-29 20:32:09 +01:00
for (int i = 0; i < plugins_list.size(); i++) {
Fixes drawing of the 2D plugins on the 3D view
2018-09-18 20:00:07 +02:00
plugins_list[i]->forward_canvas_force_draw_over_viewport(p_overlay);
}
}
Rename remaining "Spatial" in Plugins to "Node3D" For EditorNode3DGizmo: - `get_spatial_node` -> `get_node_3d` - `set_spatial_node` -> `set_node_3d` For EditorPlugin: - `add_spatial_gizmo_plugin` -> `add_node_3d_gizmo_plugin` - `remove_spatial_gizmo_plugin` -> `remove_node_3d_gizmo_plugin` Also renames some internal methods for consistency (`forward_3d_draw_over_viewport` & `forward_3d_force_draw_over_viewport` ...). Basically, Spatial has been completely eradicated.
2022-09-08 18:38:33 +02:00
void EditorPluginList::forward_3d_draw_over_viewport(Control *p_overlay) {
Fixes drawing of the 2D plugins on the 3D view
2018-09-18 20:00:07 +02:00
for (int i = 0; i < plugins_list.size(); i++) {
Rename remaining "Spatial" in Plugins to "Node3D" For EditorNode3DGizmo: - `get_spatial_node` -> `get_node_3d` - `set_spatial_node` -> `set_node_3d` For EditorPlugin: - `add_spatial_gizmo_plugin` -> `add_node_3d_gizmo_plugin` - `remove_spatial_gizmo_plugin` -> `remove_node_3d_gizmo_plugin` Also renames some internal methods for consistency (`forward_3d_draw_over_viewport` & `forward_3d_force_draw_over_viewport` ...). Basically, Spatial has been completely eradicated.
2022-09-08 18:38:33 +02:00
plugins_list[i]->forward_3d_draw_over_viewport(p_overlay);
Fixes drawing of the 2D plugins on the 3D view
2018-09-18 20:00:07 +02:00
}
}
Rename remaining "Spatial" in Plugins to "Node3D" For EditorNode3DGizmo: - `get_spatial_node` -> `get_node_3d` - `set_spatial_node` -> `set_node_3d` For EditorPlugin: - `add_spatial_gizmo_plugin` -> `add_node_3d_gizmo_plugin` - `remove_spatial_gizmo_plugin` -> `remove_node_3d_gizmo_plugin` Also renames some internal methods for consistency (`forward_3d_draw_over_viewport` & `forward_3d_force_draw_over_viewport` ...). Basically, Spatial has been completely eradicated.
2022-09-08 18:38:33 +02:00
void EditorPluginList::forward_3d_force_draw_over_viewport(Control *p_overlay) {
Fixes drawing of the 2D plugins on the 3D view
2018-09-18 20:00:07 +02:00
for (int i = 0; i < plugins_list.size(); i++) {
Rename remaining "Spatial" in Plugins to "Node3D" For EditorNode3DGizmo: - `get_spatial_node` -> `get_node_3d` - `set_spatial_node` -> `set_node_3d` For EditorPlugin: - `add_spatial_gizmo_plugin` -> `add_node_3d_gizmo_plugin` - `remove_spatial_gizmo_plugin` -> `remove_node_3d_gizmo_plugin` Also renames some internal methods for consistency (`forward_3d_draw_over_viewport` & `forward_3d_force_draw_over_viewport` ...). Basically, Spatial has been completely eradicated.
2022-09-08 18:38:33 +02:00
plugins_list[i]->forward_3d_force_draw_over_viewport(p_overlay);
Made it possible to properly draw over the 2D canvas for 2D objects. Arranged some functions to achieve this.
2016-09-10 21:44:03 +02:00
}
}
EditorPlugin can request user inputs from editor 3d view
2017-06-08 19:57:35 +02:00
void EditorPluginList::add_plugin(EditorPlugin *p_plugin) {
Fix TileMap dragging selection
2023-02-17 17:55:03 +01:00
ERR_FAIL_COND(plugins_list.has(p_plugin));
EditorPlugin can request user inputs from editor 3d view
2017-06-08 19:57:35 +02:00
plugins_list.push_back(p_plugin);
}
Fix editor crash after disabling plugin that used forward_spatial_gui_input Fixes #26124.
2019-02-25 16:49:06 +01:00
void EditorPluginList::remove_plugin(EditorPlugin *p_plugin) {
plugins_list.erase(p_plugin);
}
Rename empty() to is_empty()
2020-12-15 13:04:21 +01:00
bool EditorPluginList::is_empty() {
return plugins_list.is_empty();
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-30 01:02:53 +02:00
}
void EditorPluginList::clear() {
plugins_list.clear();
}
EditorPluginList::EditorPluginList() {
}
EditorPluginList::~EditorPluginList() {
}
Reference in a new issue Copy permalink