asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[3.x] BVH - fix not refitting upward from leaf nodes

Browse source 
Fix leaf node possibly not updating aabb due to wrong node id.

Additionally, when requesting a new leaf, mark `dirty` as `false` in `clear()`.
This commit is contained in:
风青山 2023-09-29 05:54:40 +08:00
parent 5271c971f3
commit 01c60dc9ee
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
core/math/bvh_refit.inc
View file

@ -134,7 +134,7 @@ void refit_branch(uint32_t p_node_id) {
TLeaf &leaf = _node_get_leaf(tnode); TLeaf &leaf = _node_get_leaf(tnode);
if (leaf.is_dirty()) { if (leaf.is_dirty()) {
leaf.set_dirty(false); leaf.set_dirty(false);
refit_upward(p_node_id); refit_upward(rp.node_id);
} }
} }
} // while more nodes to pop } // while more nodes to pop

2
core/math/bvh_structs.inc
View file

@ -71,7 +71,7 @@ public:
void clear() { void clear() {
num_items = 0; num_items = 0;
set_dirty(true); set_dirty(false);
} }
bool is_full() const { return num_items >= MAX_ITEMS; } bool is_full() const { return num_items >= MAX_ITEMS; }