asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #76203 from dalexeev/gds-fix-warning-ignore-member-var

Browse source 
GDScript: Fix warning ignoring for member variables
This commit is contained in:
Rémi Verschelde 2023-05-12 20:12:55 +02:00
commit 02c7ffc85c
No known key found for this signature in database
GPG key ID: C3336907360768E1
3 changed files with 23 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
modules/gdscript/gdscript_analyzer.cpp
View file

@ -1336,10 +1336,11 @@ void GDScriptAnalyzer::resolve_class_body(GDScriptParser::ClassNode *p_class, co
push_error(vformat(R"(Getter with type "%s" cannot be used along with setter of type "%s".)", getter_function->datatype.to_string(), setter_function->parameters[0]->datatype.to_string()), member.variable);
}
}
#ifdef DEBUG_ENABLED
parser->ignored_warnings = previously_ignored_warnings;
#endif // DEBUG_ENABLED
}
#ifdef DEBUG_ENABLED
parser->ignored_warnings = previously_ignored_warnings;
#endif // DEBUG_ENABLED
}
}

10
modules/gdscript/tests/scripts/analyzer/warnings/unused_private_class_variable.gd Normal file
View file

@ -0,0 +1,10 @@
# GH-72135
var _a
@warning_ignore("unused_private_class_variable")
var _b
@warning_ignore("unused_private_class_variable") var _c
var _d
func test():
pass

9
modules/gdscript/tests/scripts/analyzer/warnings/unused_private_class_variable.out Normal file
View file

@ -0,0 +1,9 @@
GDTEST_OK
>> WARNING
>> Line: 3
>> UNUSED_PRIVATE_CLASS_VARIABLE
>> The class variable "_a" is declared but never used in the script.
>> WARNING
>> Line: 7
>> UNUSED_PRIVATE_CLASS_VARIABLE
>> The class variable "_d" is declared but never used in the script.