asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Fix Input Map key assignments missing after project conversion

Browse source 
Fixes #76336 (Input Map keys missing).
Moves the project.godot config_version stamping from the project manager
to the project converter. Now there's no difference between converting through
the project manager and the CLI tool.
Fixes being prompted to re-convert the project in the project manager after
having done so through the CLI tool.
This commit is contained in:
jpcerrone 2023-05-16 12:26:58 -03:00
parent a8453cb333
commit 0985019c28
2 changed files with 3 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
editor/project_converter_3_to_4.cpp
View file

@ -439,6 +439,7 @@ bool ProjectConverter3To4::convert() {
rename_common(RenamesMap3To4::builtin_types_renames, reg_container.builtin_types_regexes, source_lines); rename_common(RenamesMap3To4::builtin_types_renames, reg_container.builtin_types_regexes, source_lines);
rename_input_map_scancode(source_lines, reg_container); rename_input_map_scancode(source_lines, reg_container);
rename_common(RenamesMap3To4::input_map_renames, reg_container.input_map_regexes, source_lines); rename_common(RenamesMap3To4::input_map_renames, reg_container.input_map_regexes, source_lines);
custom_rename(source_lines, "config_version=4", "config_version=5");
} else if (file_name.ends_with(".csproj")) { } else if (file_name.ends_with(".csproj")) {
// TODO // TODO
} else if (file_name.ends_with(".import")) { } else if (file_name.ends_with(".import")) {

10
editor/project_manager.cpp
View file

@ -2272,14 +2272,6 @@ void ProjectManager::_perform_full_project_conversion() {
const String &path = selected_list[0].path; const String &path = selected_list[0].path;
print_line("Converting project: " + path); print_line("Converting project: " + path);
Ref<ConfigFile> cf;
cf.instantiate();
cf->load(path.path_join("project.godot"));
cf->set_value("", "config_version", GODOT4_CONFIG_VERSION);
cf->save(path.path_join("project.godot"));
_project_list->set_project_version(path, GODOT4_CONFIG_VERSION);
List<String> args; List<String> args;
args.push_back("--path"); args.push_back("--path");
args.push_back(path); args.push_back(path);
@ -2287,6 +2279,8 @@ void ProjectManager::_perform_full_project_conversion() {
Error err = OS::get_singleton()->create_instance(args); Error err = OS::get_singleton()->create_instance(args);
ERR_FAIL_COND(err); ERR_FAIL_COND(err);
_project_list->set_project_version(path, GODOT4_CONFIG_VERSION);
} }
void ProjectManager::_run_project_confirm() { void ProjectManager::_run_project_confirm() {