asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Fix DynamicBVH crash after #59867

Browse source 
I made a wrong assumption that initialization the other pointer in the
union would properly initialize the `childs` array.
This commit is contained in:
Rémi Verschelde 2022-04-05 02:13:04 +02:00
parent af2c8fbcb6
commit 099b024a2b
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
core/math/dynamic_bvh.h
View file

@ -183,7 +183,7 @@ private:
Node *parent = nullptr; Node *parent = nullptr;
union { union {
Node *childs[2]; Node *childs[2];
void *data = nullptr; void *data;
}; };
_FORCE_INLINE_ bool is_leaf() const { return childs[1] == nullptr; } _FORCE_INLINE_ bool is_leaf() const { return childs[1] == nullptr; }
@ -215,7 +215,10 @@ private:
return axis.dot(volume.get_center() - org) <= 0; return axis.dot(volume.get_center() - org) <= 0;
} }
Node() {} Node() {
childs[0] = nullptr;
childs[1] = nullptr;
}
}; };
PagedAllocator<Node> node_allocator; PagedAllocator<Node> node_allocator;