asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #44188 from madmiraal/tabs-signal-names

Browse source 
Rename Tabs close and hover signals to tab_closed and tab_hovered
This commit is contained in:
Rémi Verschelde 2020-12-08 12:30:49 +01:00 committed by GitHub
commit 0f6745b6aa
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
doc/classes/Tabs.xml
View file

@ -299,14 +299,14 @@
Emitted when a tab is clicked, even if it is the current tab.
</description>
</signal>
<signal name="tab_close">
<signal name="tab_closed">
<argument index="0" name="tab" type="int">
</argument>
<description>
Emitted when a tab is closed.
</description>
</signal>
<signal name="tab_hover">
<signal name="tab_hovered">
<argument index="0" name="tab" type="int">
</argument>
<description>

8
scene/gui/tabs.cpp
View file

@ -153,7 +153,7 @@ void Tabs::_gui_input(const Ref<InputEvent> &p_event) {
if (cb_pressing && !mb->is_pressed() && mb->get_button_index() == BUTTON_LEFT) {
if (cb_hover != -1) {
//pressed
emit_signal("tab_close", cb_hover);
emit_signal("tab_closed", cb_hover);
}
cb_pressing = false;
@ -641,7 +641,7 @@ void Tabs::_update_hover() {
}
if (hover != hover_now) {
hover = hover_now;
emit_signal("tab_hover", hover);
emit_signal("tab_hovered", hover);
}
if (hover_buttons == -1) { // no hover
@ -1114,8 +1114,8 @@ void Tabs::_bind_methods() {
ADD_SIGNAL(MethodInfo("tab_changed", PropertyInfo(Variant::INT, "tab")));
ADD_SIGNAL(MethodInfo("right_button_pressed", PropertyInfo(Variant::INT, "tab")));
ADD_SIGNAL(MethodInfo("tab_close", PropertyInfo(Variant::INT, "tab")));
ADD_SIGNAL(MethodInfo("tab_hover", PropertyInfo(Variant::INT, "tab")));
ADD_SIGNAL(MethodInfo("tab_closed", PropertyInfo(Variant::INT, "tab")));
ADD_SIGNAL(MethodInfo("tab_hovered", PropertyInfo(Variant::INT, "tab")));
ADD_SIGNAL(MethodInfo("reposition_active_tab_request", PropertyInfo(Variant::INT, "idx_to")));
ADD_SIGNAL(MethodInfo("tab_clicked", PropertyInfo(Variant::INT, "tab")));