asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Fix some incorrect uses of String over StringName

Browse source 
These were accepting `SNAME` assignments
This commit is contained in:
A Thousand Ships 2024-06-03 13:42:31 +02:00
parent 0d11108a01
commit 0f72b15bc2
No known key found for this signature in database
GPG key ID: 2033189A662F8BD7
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
editor/gui/scene_tree_editor.cpp
View file

@ -291,7 +291,7 @@ void SceneTreeEditor::_add_nodes(Node *p_node, TreeItem *p_parent) {
const PackedStringArray warnings = p_node->get_configuration_warnings(); const PackedStringArray warnings = p_node->get_configuration_warnings();
const int num_warnings = warnings.size(); const int num_warnings = warnings.size();
if (num_warnings > 0) { if (num_warnings > 0) {
String warning_icon; StringName warning_icon;
if (num_warnings == 1) { if (num_warnings == 1) {
warning_icon = SNAME("NodeWarning"); warning_icon = SNAME("NodeWarning");
} else if (num_warnings <= 3) { } else if (num_warnings <= 3) {

6
editor/plugins/control_editor_plugin.cpp
View file

@ -360,9 +360,9 @@ void EditorPropertySizeFlags::setup(const Vector<String> &p_options, bool p_vert
} }
Control *gui_base = EditorNode::get_singleton()->get_gui_base(); Control *gui_base = EditorNode::get_singleton()->get_gui_base();
String wide_preset_icon = SNAME("ControlAlignHCenterWide"); StringName wide_preset_icon = SNAME("ControlAlignHCenterWide");
String begin_preset_icon = SNAME("ControlAlignCenterLeft"); StringName begin_preset_icon = SNAME("ControlAlignCenterLeft");
String end_preset_icon = SNAME("ControlAlignCenterRight"); StringName end_preset_icon = SNAME("ControlAlignCenterRight");
if (vertical) { if (vertical) {
wide_preset_icon = SNAME("ControlAlignVCenterWide"); wide_preset_icon = SNAME("ControlAlignVCenterWide");
begin_preset_icon = SNAME("ControlAlignCenterTop"); begin_preset_icon = SNAME("ControlAlignCenterTop");