asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #96383 from dsnopek/gdextension-pdb-missing-error

Browse source 
GDExtension: Show warning on missing PDB file, rather than error
This commit is contained in:
Rémi Verschelde 2024-09-02 12:13:34 +02:00
commit 109fafc7a4
No known key found for this signature in database
GPG key ID: C3336907360768E1
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
platform/windows/windows_utils.cpp
View file

@ -155,7 +155,11 @@ Error WindowsUtils::copy_and_rename_pdb(const String &p_dll_path) {
} else if (!FileAccess::exists(copy_pdb_path)) { } else if (!FileAccess::exists(copy_pdb_path)) {
copy_pdb_path = dll_base_dir.path_join(copy_pdb_path.get_file()); copy_pdb_path = dll_base_dir.path_join(copy_pdb_path.get_file());
} }
ERR_FAIL_COND_V_MSG(!FileAccess::exists(copy_pdb_path), FAILED, vformat("File '%s' does not exist.", copy_pdb_path)); if (!FileAccess::exists(copy_pdb_path)) {
// The PDB file may be distributed separately on purpose, so we don't consider this an error.
WARN_VERBOSE(vformat("PDB file '%s' for library '%s' was not found, skipping copy/rename.", copy_pdb_path, p_dll_path));
return ERR_SKIP;
}
String new_pdb_base_name = p_dll_path.get_file().get_basename() + "_"; String new_pdb_base_name = p_dll_path.get_file().get_basename() + "_";