From 399bce02cf80239ab5d987e4b754eaf5c5d2eaaf Mon Sep 17 00:00:00 2001 From: Markus Sauermann <6299227+Sauermann@users.noreply.github.com> Date: Thu, 22 Jun 2023 18:55:19 +0200 Subject: [PATCH] Fix 3D top_level resetting There is no need to erase the top_level flag on EXIT_TREE. During ENTER_TREE, `top_level = true` is not necessary, because it is already set to true. --- scene/3d/node_3d.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/scene/3d/node_3d.cpp b/scene/3d/node_3d.cpp index 4f9c523806b..18773312771 100644 --- a/scene/3d/node_3d.cpp +++ b/scene/3d/node_3d.cpp @@ -153,7 +153,6 @@ void Node3D::_notification(int p_what) { data.local_transform = data.parent->get_global_transform() * get_transform(); _replace_dirty_mask(DIRTY_EULER_ROTATION_AND_SCALE); // As local transform was updated, rot/scale should be dirty. } - data.top_level = true; } _set_dirty_bits(DIRTY_GLOBAL_TRANSFORM); // Global is always dirty upon entering a scene. @@ -173,7 +172,6 @@ void Node3D::_notification(int p_what) { } data.parent = nullptr; data.C = nullptr; - data.top_level = false; _update_visibility_parent(true); } break;