From 15057c9284740f155077f1079dc8d235c4ccab4d Mon Sep 17 00:00:00 2001 From: Thakee Nathees Date: Thu, 5 Mar 2020 16:12:41 +0530 Subject: [PATCH] Fix EditorFolding crash when switching scenes (cherry picked from commit 3275e8488b59fb8a7a53c4edc0e6755b0ced782c) --- editor/editor_folding.cpp | 2 ++ editor/editor_node.cpp | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/editor/editor_folding.cpp b/editor/editor_folding.cpp index 475f16f12f1..e75668ddd55 100644 --- a/editor/editor_folding.cpp +++ b/editor/editor_folding.cpp @@ -133,6 +133,8 @@ void EditorFolding::_fill_folds(const Node *p_root, const Node *p_node, Array &p } void EditorFolding::save_scene_folding(const Node *p_scene, const String &p_path) { + ERR_FAIL_NULL(p_scene); + FileAccessRef file_check = FileAccess::create(FileAccess::ACCESS_RESOURCES); if (!file_check->file_exists(p_path)) //This can happen when creating scene from FilesystemDock. It has path, but no file. return; diff --git a/editor/editor_node.cpp b/editor/editor_node.cpp index c283aca70e0..e94acd28073 100644 --- a/editor/editor_node.cpp +++ b/editor/editor_node.cpp @@ -3246,7 +3246,7 @@ void EditorNode::_clear_undo_history() { void EditorNode::set_current_scene(int p_idx) { //Save the folding in case the scene gets reloaded. - if (editor_data.get_scene_path(p_idx) != "") + if (editor_data.get_scene_path(p_idx) != "" && editor_data.get_edited_scene_root(p_idx)) editor_folding.save_scene_folding(editor_data.get_edited_scene_root(p_idx), editor_data.get_scene_path(p_idx)); if (editor_data.check_and_update_scene(p_idx)) {