asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

C#: Ignore late bound methods in MustBeVariantAnalyzer

Browse source 
If symbol is late bound (as is the case when using `dynamic`) we can't obtain the symbol to analyze the usage of `[MustBeVariant]`.
This commit is contained in:
Raul Santos 2024-04-30 19:36:43 +02:00
parent d282e4f0e6
commit 1510f88ae1
No known key found for this signature in database
GPG key ID: B532473AE3A803E4
2 changed files with 18 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
modules/mono/editor/Godot.NET.Sdk/Godot.SourceGenerators.Tests/TestData/Sources/MustBeVariant.GD0301.cs
View file

@ -66,6 +66,12 @@ public class MustBeVariantGD0301
Method<Rid[]>();
}
public void MethodCallDynamic()
{
dynamic self = this;
self.Method<object>();
}
public void Method<[MustBeVariant] T>()
{
}

14
modules/mono/editor/Godot.NET.Sdk/Godot.SourceGenerators/MustBeVariantAnalyzer.cs
View file

@ -50,8 +50,18 @@ namespace Godot.SourceGenerators
var typeSymbol = sm.GetSymbolInfo(typeSyntax).Symbol as ITypeSymbol;
Helper.ThrowIfNull(typeSymbol);
var parentSymbol = sm.GetSymbolInfo(parentSyntax).Symbol;
Helper.ThrowIfNull(parentSymbol);
var parentSymbolInfo = sm.GetSymbolInfo(parentSyntax);
var parentSymbol = parentSymbolInfo.Symbol;
if (parentSymbol == null)
{
if (parentSymbolInfo.CandidateReason == CandidateReason.LateBound)
{
// Invocations on dynamic are late bound so we can't retrieve the symbol.
continue;
}
Helper.ThrowIfNull(parentSymbol);
}
if (!ShouldCheckTypeArgument(context, parentSyntax, parentSymbol, typeSyntax, typeSymbol, i))
{