asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

GDScript: Fix override signature check of script inheritance

Browse source 
Avoid treating the super class as a meta type for signature check, since
it is looking at the instance level for that.
This commit is contained in:
George Marques 2023-02-21 14:37:08 -03:00
parent 7e79aead99
commit 1731010774
No known key found for this signature in database
GPG key ID: 046BD46A3201E43D
3 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
modules/gdscript/gdscript_analyzer.cpp
View file

@ -1534,6 +1534,7 @@ void GDScriptAnalyzer::resolve_function_signature(GDScriptParser::FunctionNode *
// Check if the function signature matches the parent. If not it's an error since it breaks polymorphism.
// Not for the constructor which can vary in signature.
GDScriptParser::DataType base_type = parser->current_class->base_type;
base_type.is_meta_type = false;
GDScriptParser::DataType parent_return_type;
List<GDScriptParser::DataType> parameters_types;
int default_par_count = 0;

10
modules/gdscript/tests/scripts/analyzer/features/inheritance_signature_check_no_meta.gd Normal file
View file

@ -0,0 +1,10 @@
func test():
print("ok")
# https://github.com/godotengine/godot/issues/71994
class A:
extends RefCounted
class B:
extends A
func duplicate():
pass

2
modules/gdscript/tests/scripts/analyzer/features/inheritance_signature_check_no_meta.out Normal file
View file

@ -0,0 +1,2 @@
GDTEST_OK
ok