asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Merge pull request #83780 from jsjtxietian/prevent-null-variant-crash

Browse source 
Prevent `_allocate_placeholders` crash if `p_version->variants` is null
This commit is contained in:
Rémi Verschelde 2023-10-23 12:42:04 +02:00
commit 17aa5c5170
No known key found for this signature in database
GPG key ID: C3336907360768E1
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
servers/rendering/renderer_rd/shader_rd.cpp
View file

@ -480,6 +480,7 @@ void ShaderRD::_save_to_cache(Version *p_version, int p_group) {
} }
void ShaderRD::_allocate_placeholders(Version *p_version, int p_group) { void ShaderRD::_allocate_placeholders(Version *p_version, int p_group) {
ERR_FAIL_NULL(p_version->variants);
for (uint32_t i = 0; i < group_to_variant_map[p_group].size(); i++) { for (uint32_t i = 0; i < group_to_variant_map[p_group].size(); i++) {
int variant_id = group_to_variant_map[p_group][i]; int variant_id = group_to_variant_map[p_group][i];
RID shader = RD::get_singleton()->shader_create_placeholder(); RID shader = RD::get_singleton()->shader_create_placeholder();