asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Stop asuming a default value of NIL means there's no default

Browse source
This commit is contained in:
Pedro J. Estébanez 2021-12-11 14:03:48 +01:00
parent 092a286127
commit 18663aa305
6 changed files with 32 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
editor/editor_inspector.cpp
View file

@ -413,17 +413,21 @@ bool EditorProperty::is_read_only() const {
return read_only; return read_only;
} }
Variant EditorPropertyRevert::get_property_revert_value(Object *p_object, const StringName &p_property) { Variant EditorPropertyRevert::get_property_revert_value(Object *p_object, const StringName &p_property, bool *r_is_valid) {
if (p_object->has_method("property_can_revert") && p_object->call("property_can_revert", p_property)) { if (p_object->has_method("property_can_revert") && p_object->call("property_can_revert", p_property)) {
if (r_is_valid) {
*r_is_valid = true;
}
return p_object->call("property_get_revert", p_property); return p_object->call("property_get_revert", p_property);
} }
return PropertyUtils::get_property_default_value(p_object, p_property); return PropertyUtils::get_property_default_value(p_object, p_property, r_is_valid);
} }
bool EditorPropertyRevert::can_property_revert(Object *p_object, const StringName &p_property) { bool EditorPropertyRevert::can_property_revert(Object *p_object, const StringName &p_property) {
Variant revert_value = EditorPropertyRevert::get_property_revert_value(p_object, p_property); bool is_valid_revert = false;
if (revert_value.get_type() == Variant::NIL) { Variant revert_value = EditorPropertyRevert::get_property_revert_value(p_object, p_property, &is_valid_revert);
if (!is_valid_revert) {
return false; return false;
} }
Variant current_value = p_object->get(p_property); Variant current_value = p_object->get(p_property);
@ -637,7 +641,9 @@ void EditorProperty::gui_input(const Ref<InputEvent> &p_event) {
} }
if (revert_rect.has_point(mpos)) { if (revert_rect.has_point(mpos)) {
Variant revert_value = EditorPropertyRevert::get_property_revert_value(object, property); bool is_valid_revert = false;
Variant revert_value = EditorPropertyRevert::get_property_revert_value(object, property, &is_valid_revert);
ERR_FAIL_COND(!is_valid_revert);
emit_changed(property, revert_value); emit_changed(property, revert_value);
update_property(); update_property();
} }
@ -783,8 +789,9 @@ static bool _is_value_potential_override(Node *p_node, const String &p_property)
if (states_stack.size()) { if (states_stack.size()) {
return true; return true;
} else { } else {
bool is_valid_default = false;
bool is_class_default = false; bool is_class_default = false;
PropertyUtils::get_property_default_value(p_node, p_property, &states_stack, false, nullptr, &is_class_default); PropertyUtils::get_property_default_value(p_node, p_property, &is_valid_default, &states_stack, false, nullptr, &is_class_default);
return !is_class_default; return !is_class_default;
} }
} }

2
editor/editor_inspector.h
View file

@ -46,7 +46,7 @@ public:
static bool get_instantiated_node_original_property(Node *p_node, const StringName &p_prop, Variant &value, bool p_check_class_default = true); static bool get_instantiated_node_original_property(Node *p_node, const StringName &p_prop, Variant &value, bool p_check_class_default = true);
static bool is_node_property_different(Node *p_node, const Variant &p_current, const Variant &p_orig); static bool is_node_property_different(Node *p_node, const Variant &p_current, const Variant &p_orig);
static bool is_property_value_different(const Variant &p_a, const Variant &p_b); static bool is_property_value_different(const Variant &p_a, const Variant &p_b);
static Variant get_property_revert_value(Object *p_object, const StringName &p_property); static Variant get_property_revert_value(Object *p_object, const StringName &p_property, bool *r_is_valid);
static bool can_property_revert(Object *p_object, const StringName &p_property); static bool can_property_revert(Object *p_object, const StringName &p_property);
}; };

5
editor/scene_tree_dock.cpp
View file

@ -3157,8 +3157,9 @@ void SceneTreeDock::_create_remap_for_node(Node *p_node, Map<RES, RES> &r_remap)
states_stack_ready = true; states_stack_ready = true;
} }
Variant orig = PropertyUtils::get_property_default_value(p_node, E.name, &states_stack); bool is_valid_default = false;
if (!PropertyUtils::is_property_value_different(v, orig)) { Variant orig = PropertyUtils::get_property_default_value(p_node, E.name, &is_valid_default, &states_stack);
if (is_valid_default && !PropertyUtils::is_property_value_different(v, orig)) {
continue; continue;
} }

13
scene/property_utils.cpp
View file

@ -50,7 +50,7 @@ bool PropertyUtils::is_property_value_different(const Variant &p_a, const Varian
} }
} }
Variant PropertyUtils::get_property_default_value(const Object *p_object, const StringName &p_property, const Vector<SceneState::PackState> *p_states_stack_cache, bool p_update_exports, const Node *p_owner, bool *r_is_class_default) { Variant PropertyUtils::get_property_default_value(const Object *p_object, const StringName &p_property, bool *r_is_valid, const Vector<SceneState::PackState> *p_states_stack_cache, bool p_update_exports, const Node *p_owner, bool *r_is_class_default) {
// This function obeys the way property values are set when an object is instantiated, // This function obeys the way property values are set when an object is instantiated,
// which is the following (the latter wins): // which is the following (the latter wins):
// 1. Default value from builtin class // 1. Default value from builtin class
@ -60,6 +60,9 @@ Variant PropertyUtils::get_property_default_value(const Object *p_object, const
if (r_is_class_default) { if (r_is_class_default) {
*r_is_class_default = false; *r_is_class_default = false;
} }
if (r_is_valid) {
*r_is_valid = false;
}
Ref<Script> topmost_script; Ref<Script> topmost_script;
@ -71,6 +74,9 @@ Variant PropertyUtils::get_property_default_value(const Object *p_object, const
bool found = false; bool found = false;
Variant value_in_ancestor = ia.state->get_property_value(ia.node, p_property, found); Variant value_in_ancestor = ia.state->get_property_value(ia.node, p_property, found);
if (found) { if (found) {
if (r_is_valid) {
*r_is_valid = true;
}
return value_in_ancestor; return value_in_ancestor;
} }
// Save script for later // Save script for later
@ -97,6 +103,9 @@ Variant PropertyUtils::get_property_default_value(const Object *p_object, const
} }
Variant default_value; Variant default_value;
if (topmost_script->get_property_default_value(p_property, default_value)) { if (topmost_script->get_property_default_value(p_property, default_value)) {
if (r_is_valid) {
*r_is_valid = true;
}
return default_value; return default_value;
} }
} }
@ -105,7 +114,7 @@ Variant PropertyUtils::get_property_default_value(const Object *p_object, const
if (r_is_class_default) { if (r_is_class_default) {
*r_is_class_default = true; *r_is_class_default = true;
} }
return ClassDB::class_get_default_property_value(p_object->get_class_name(), p_property); return ClassDB::class_get_default_property_value(p_object->get_class_name(), p_property, r_is_valid);
} }
// Like SceneState::PackState, but using a raw pointer to avoid the cost of // Like SceneState::PackState, but using a raw pointer to avoid the cost of

2
scene/property_utils.h
View file

@ -38,7 +38,7 @@ class PropertyUtils {
public: public:
static bool is_property_value_different(const Variant &p_a, const Variant &p_b); static bool is_property_value_different(const Variant &p_a, const Variant &p_b);
// Gets the most pure default value, the one that would be set when the node has just been instantiated // Gets the most pure default value, the one that would be set when the node has just been instantiated
static Variant get_property_default_value(const Object *p_object, const StringName &p_property, const Vector<SceneState::PackState> *p_states_stack_cache = nullptr, bool p_update_exports = false, const Node *p_owner = nullptr, bool *r_is_class_default = nullptr); static Variant get_property_default_value(const Object *p_object, const StringName &p_property, bool *r_is_valid = nullptr, const Vector<SceneState::PackState> *p_states_stack_cache = nullptr, bool p_update_exports = false, const Node *p_owner = nullptr, bool *r_is_class_default = nullptr);
// Gets the instance/inheritance states of this node, in order of precedence, // Gets the instance/inheritance states of this node, in order of precedence,
// that is, from the topmost (the most able to override values) to the lowermost // that is, from the topmost (the most able to override values) to the lowermost

5
scene/resources/packed_scene.cpp
View file

@ -501,8 +501,9 @@ Error SceneState::_parse_node(Node *p_owner, Node *p_node, int p_parent_idx, Map
Variant value = forced_value.get_type() == Variant::NIL ? p_node->get(name) : forced_value; Variant value = forced_value.get_type() == Variant::NIL ? p_node->get(name) : forced_value;
if (!pinned_props.has(name) && forced_value.get_type() == Variant::NIL) { if (!pinned_props.has(name) && forced_value.get_type() == Variant::NIL) {
Variant default_value = PropertyUtils::get_property_default_value(p_node, name, &states_stack, true); bool is_valid_default = false;
if (!PropertyUtils::is_property_value_different(value, default_value)) { Variant default_value = PropertyUtils::get_property_default_value(p_node, name, &is_valid_default, &states_stack, true);
if (is_valid_default && !PropertyUtils::is_property_value_different(value, default_value)) {
continue; continue;
} }
} }