asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Optimize DirAccessUnix::get_next() for some file systems

Browse source 
On some file systems, like ext4 on Linux, readdir() gives enough
information to determine the entry type in order to avoid doing
a stat() system call.

Use this information and call stat() only if necessary.
This commit is contained in:
Hadrien 2019-07-17 20:34:37 +02:00
parent d087a9e328
commit 1898a559a9
1 changed files with 14 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
drivers/unix/dir_access_unix.cpp
View file

@ -136,27 +136,31 @@ String DirAccessUnix::get_next() {
return "";
}
//typedef struct stat Stat;
struct stat flags;
String fname = fix_unicode_name(entry->d_name);
String f = current_dir.plus_file(fname);
if (entry->d_type == DT_UNKNOWN) {
//typedef struct stat Stat;
struct stat flags;
if (stat(f.utf8().get_data(), &flags) == 0) {
String f = current_dir.plus_file(fname);
if (S_ISDIR(flags.st_mode)) {
if (stat(f.utf8().get_data(), &flags) == 0) {
_cisdir = true;
if (S_ISDIR(flags.st_mode)) {
_cisdir = true;
} else {
_cisdir = false;
}
} else {
_cisdir = false;
}
} else {
_cisdir = false;
_cisdir = (entry->d_type == DT_DIR);
}
_cishidden = (fname != "." && fname != ".." && fname.begins_with("."));