From 18b90508a115661b9beba32fad372cd60a1ae0cd Mon Sep 17 00:00:00 2001 From: Hugo Locurcio Date: Fri, 22 Feb 2019 21:40:01 +0100 Subject: [PATCH] Fix crash when using `wrapi()` with a range of zero `wrapi()` and `wrapf()` will now return the value of the `min` parameter if the range is equal to zero. --- core/math/math_funcs.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/core/math/math_funcs.h b/core/math/math_funcs.h index 629002ced65..f8f5ddfeaa7 100644 --- a/core/math/math_funcs.h +++ b/core/math/math_funcs.h @@ -219,15 +219,15 @@ public: static _ALWAYS_INLINE_ int wrapi(int value, int min, int max) { int rng = max - min; - return min + ((((value - min) % rng) + rng) % rng); + return (rng != 0) ? min + ((((value - min) % rng) + rng) % rng) : min; } static _ALWAYS_INLINE_ double wrapf(double value, double min, double max) { double rng = max - min; - return value - (rng * Math::floor((value - min) / rng)); + return (!is_equal_approx(rng, 0.0)) ? value - (rng * Math::floor((value - min) / rng)) : min; } static _ALWAYS_INLINE_ float wrapf(float value, float min, float max) { float rng = max - min; - return value - (rng * Math::floor((value - min) / rng)); + return (!is_equal_approx(rng, 0.0f)) ? value - (rng * Math::floor((value - min) / rng)) : min; } // double only, as these functions are mainly used by the editor and not performance-critical,