asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix crash caused by null parameter passed to CameraServer.add_feed()

Browse source 
Fixes #46181

CameraServer.add_feed() takes a CameraFeed object type as parameter.
Passing in another type of data while binding the method it will make
tha parameter null.
Added a check for null which returns from function and does not make the
engine crash anymore.

(cherry picked from commit c158a63a8a)
This commit is contained in:
lucicam 2021-04-02 16:16:40 +03:00 committed by Rémi Verschelde
parent c081596a55
commit 1cd13d22c2
No known key found for this signature in database
GPG key ID: C3336907360768E1
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
servers/camera_server.cpp
View file

@ -99,6 +99,8 @@ Ref<CameraFeed> CameraServer::get_feed_by_id(int p_id) {
}; };
void CameraServer::add_feed(const Ref<CameraFeed> &p_feed) { void CameraServer::add_feed(const Ref<CameraFeed> &p_feed) {
ERR_FAIL_COND(p_feed.is_null());
// add our feed // add our feed
feeds.push_back(p_feed); feeds.push_back(p_feed);