asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #96666 from aXu-AP/unique-node-no-quotes

Browse source 
Remove unneeded quotes from autocomplete % nodes
This commit is contained in:
Rémi Verschelde 2024-09-11 12:35:00 +02:00
commit 1ff2186fe9
No known key found for this signature in database
GPG key ID: C3336907360768E1
3 changed files with 16 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
modules/gdscript/gdscript_editor.cpp
View file

@ -3486,10 +3486,10 @@ static void _find_call_arguments(GDScriptParser::CompletionContext &p_context, c
opt = opt.substr(1); opt = opt.substr(1);
} }
// The path needs quotes if at least one of its components (excluding `/` separations) // The path needs quotes if at least one of its components (excluding `%` prefix and `/` separations)
// is not a valid identifier. // is not a valid identifier.
bool path_needs_quote = false; bool path_needs_quote = false;
for (const String &part : opt.split("/")) { for (const String &part : opt.trim_prefix("%").split("/")) {
if (!part.is_valid_ascii_identifier()) { if (!part.is_valid_ascii_identifier()) {
path_needs_quote = true; path_needs_quote = true;
break; break;

9
modules/gdscript/tests/scripts/completion/get_node/literal_scene/dollar_unique.cfg Normal file
View file

@ -0,0 +1,9 @@
[input]
scene="res://completion/get_node/get_node.tscn"
[output]
include=[
{"display": "%UniqueA"},
]
exclude=[
{"display": "\"%UniqueA\""},
]

5
modules/gdscript/tests/scripts/completion/get_node/literal_scene/dollar_unique.gd Normal file
View file

@ -0,0 +1,5 @@
extends Node
func a():
$➡
pass