asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Changed HTML input color_changed logic.

Browse source 
Made the HTML field send change events based on whether the new color's string is different from the previous color's string (instead of whether the new string parses to the current color value).
Previously, updating the color value even when the corresponding string hadn't changed would unnecessarily quantize the color value to 8 bits just by opening/closing the Color Picker.
This commit is contained in:
Michael Wörner 2023-12-04 17:19:39 +01:00
parent 41365c6c8b
commit 21d778b0c3
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
scene/gui/color_picker.cpp
View file

@ -556,16 +556,17 @@ void ColorPicker::_html_submitted(const String &p_html) {
return;
}
const Color previous_color = color;
color = Color::from_string(p_html.strip_edges(), previous_color);
Color new_color = Color::from_string(p_html.strip_edges(), color);
if (!is_editing_alpha()) {
color.a = previous_color.a;
new_color.a = color.a;
}
if (color == previous_color) {
if (new_color.to_argb32() == color.to_argb32()) {
return;
}
color = new_color;
if (!is_inside_tree()) {
return;
}