asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fixed crash with StringBuilder

Browse source 
When using a newly created StringBuilder then the as_string() method
will crash when trying to free an allocated 0-sized chunk of memory.

When 0 bytes get allocated with memnew_arr then a NULL pointer gets
returned. When trying to free that pointer the programm will crash.
This commit is contained in:
karroffel 2018-01-20 15:23:03 +01:00
parent 09732a15a5
commit 30822e8ab7
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
core/string_builder.cpp
View file

@ -56,6 +56,9 @@ StringBuilder &StringBuilder::append(const char *p_cstring) {
String StringBuilder::as_string() const { String StringBuilder::as_string() const {
if (string_length == 0)
return "";
CharType *buffer = memnew_arr(CharType, string_length); CharType *buffer = memnew_arr(CharType, string_length);
int current_position = 0; int current_position = 0;