asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Batching - GLES3 fix light pass modulates

Browse source 
The final_modulate was incorrectly being set in the uniform on light passes in GLES3 in situations where color was baked in the vertices. This was already correct in GLES2. This PR makes prevents setting final_modulate in this situation.
This commit is contained in:
lawnjelly 2021-04-24 10:21:33 +01:00
parent adaf488963
commit 35c5ccce9e
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/gles3/rasterizer_canvas_gles3.cpp
View file

@ -1493,7 +1493,11 @@ void RasterizerCanvasGLES3::render_joined_item(const BItemJoined &p_bij, RenderI
Light *light = r_ris.item_group_light; Light *light = r_ris.item_group_light;
bool light_used = false; bool light_used = false;
VS::CanvasLightMode mode = VS::CANVAS_LIGHT_MODE_ADD; VS::CanvasLightMode mode = VS::CANVAS_LIGHT_MODE_ADD;
state.canvas_item_modulate = p_ci->final_modulate; // remove the canvas modulate
// we leave this set to 1, 1, 1, 1 if using software because the colors are baked into the vertices
if (p_bij.is_single_item()) {
state.canvas_item_modulate = p_ci->final_modulate; // remove the canvas modulate
}
while (light) { while (light) {