From fe0696618163de1f329ce380612ed133af58a498 Mon Sep 17 00:00:00 2001 From: Hugo Locurcio Date: Sat, 7 Dec 2019 01:05:11 +0100 Subject: [PATCH] Make some arguments in PCKPacker methods optional Those arguments aren't required for most common use cases, so making them optional should help with code readability. --- core/io/pck_packer.cpp | 4 ++-- core/io/pck_packer.h | 2 +- doc/classes/PCKPacker.xml | 8 ++++---- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/core/io/pck_packer.cpp b/core/io/pck_packer.cpp index 443f390bb79..011ebb1812f 100644 --- a/core/io/pck_packer.cpp +++ b/core/io/pck_packer.cpp @@ -55,9 +55,9 @@ static void _pad(FileAccess *p_file, int p_bytes) { void PCKPacker::_bind_methods() { - ClassDB::bind_method(D_METHOD("pck_start", "pck_name", "alignment"), &PCKPacker::pck_start); + ClassDB::bind_method(D_METHOD("pck_start", "pck_name", "alignment"), &PCKPacker::pck_start, DEFVAL(0)); ClassDB::bind_method(D_METHOD("add_file", "pck_path", "source_path"), &PCKPacker::add_file); - ClassDB::bind_method(D_METHOD("flush", "verbose"), &PCKPacker::flush); + ClassDB::bind_method(D_METHOD("flush", "verbose"), &PCKPacker::flush, DEFVAL(false)); }; Error PCKPacker::pck_start(const String &p_file, int p_alignment) { diff --git a/core/io/pck_packer.h b/core/io/pck_packer.h index 4df495b11f2..f5661c55a19 100644 --- a/core/io/pck_packer.h +++ b/core/io/pck_packer.h @@ -54,7 +54,7 @@ class PCKPacker : public Reference { Vector files; public: - Error pck_start(const String &p_file, int p_alignment); + Error pck_start(const String &p_file, int p_alignment = 0); Error add_file(const String &p_file, const String &p_src); Error flush(bool p_verbose = false); diff --git a/doc/classes/PCKPacker.xml b/doc/classes/PCKPacker.xml index ff45ca925cd..1946438cc23 100644 --- a/doc/classes/PCKPacker.xml +++ b/doc/classes/PCKPacker.xml @@ -6,9 +6,9 @@ The [PCKPacker] is used to create packages in application runtime. [codeblock] var packer = PCKPacker.new() - packer.pck_start("test.pck", 0) + packer.pck_start("test.pck") packer.add_file("res://text.txt", "text.txt") - packer.flush(false) + packer.flush() [/codeblock] The above [PCKPacker] creates package [b]test.pck[/b], then adds a file named [b]text.txt[/b] in the root of the package. @@ -29,7 +29,7 @@ - + @@ -39,7 +39,7 @@ - +