asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #44189 from madmiraal/canvasitem-hidden-signal

Browse source 
Rename CanvasItem's hide signal to hidden
This commit is contained in:
Rémi Verschelde 2020-12-08 13:50:15 +01:00 committed by GitHub
commit 3846a3703a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
doc/classes/CanvasItem.xml
View file

@ -608,7 +608,7 @@
Emitted when the [CanvasItem] must redraw. This can only be connected realtime, as deferred will not allow drawing.
</description>
</signal>
<signal name="hide">
<signal name="hidden">
<description>
Emitted when becoming hidden.
</description>

4
scene/main/canvas_item.cpp
View file

@ -364,7 +364,7 @@ void CanvasItem::_propagate_visibility_changed(bool p_visible) {
if (p_visible) {
update(); //todo optimize
} else {
emit_signal(SceneStringNames::get_singleton()->hide);
emit_signal(SceneStringNames::get_singleton()->hidden);
}
_block();
@ -1227,7 +1227,7 @@ void CanvasItem::_bind_methods() {
ADD_SIGNAL(MethodInfo("draw"));
ADD_SIGNAL(MethodInfo("visibility_changed"));
ADD_SIGNAL(MethodInfo("hide"));
ADD_SIGNAL(MethodInfo("hidden"));
ADD_SIGNAL(MethodInfo("item_rect_changed"));
BIND_CONSTANT(NOTIFICATION_TRANSFORM_CHANGED);

2
scene/scene_string_names.cpp
View file

@ -41,7 +41,7 @@ SceneStringNames::SceneStringNames() {
doubledot = StaticCString::create("..");
draw = StaticCString::create("draw");
_draw = StaticCString::create("_draw");
hide = StaticCString::create("hide");
hidden = StaticCString::create("hidden");
visibility_changed = StaticCString::create("visibility_changed");
input_event = StaticCString::create("input_event");
shader = StaticCString::create("shader");

2
scene/scene_string_names.h
View file

@ -58,7 +58,7 @@ public:
StringName dot;
StringName doubledot;
StringName draw;
StringName hide;
StringName hidden;
StringName visibility_changed;
StringName input_event;
StringName _input_event;