asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix memory leak in Text Editor and FileSystem Dock

Browse source
This commit is contained in:
qarmin 2019-05-30 21:31:05 +02:00
parent 8c923fc617
commit 392f6f89cd
2 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
editor/code_editor.cpp
View file

@ -675,14 +675,14 @@ void CodeTextEditor::_line_col_changed() {
} }
} }
StringBuilder *sb = memnew(StringBuilder); StringBuilder sb;
sb->append("("); sb.append("(");
sb->append(itos(text_editor->cursor_get_line() + 1).lpad(3)); sb.append(itos(text_editor->cursor_get_line() + 1).lpad(3));
sb->append(","); sb.append(",");
sb->append(itos(positional_column + 1).lpad(3)); sb.append(itos(positional_column + 1).lpad(3));
sb->append(")"); sb.append(")");
line_and_col_txt->set_text(sb->as_string()); line_and_col_txt->set_text(sb.as_string());
} }
void CodeTextEditor::_text_changed() { void CodeTextEditor::_text_changed() {

2
editor/filesystem_dock.cpp
View file

@ -451,9 +451,11 @@ void FileSystemDock::_navigate_to_path(const String &p_path, bool p_select_in_fa
} else if (dirAccess->dir_exists(p_path)) { } else if (dirAccess->dir_exists(p_path)) {
path = target_path + "/"; path = target_path + "/";
} else { } else {
memdelete(dirAccess);
ERR_EXPLAIN(vformat(TTR("Cannot navigate to '%s' as it has not been found in the file system!"), p_path)); ERR_EXPLAIN(vformat(TTR("Cannot navigate to '%s' as it has not been found in the file system!"), p_path));
ERR_FAIL(); ERR_FAIL();
} }
memdelete(dirAccess);
} }
_set_current_path_text(path); _set_current_path_text(path);